[ovs-dev] [PATCH 2/2] doc: Add info on distributions shipping openvswitch package.

2017-02-07 Thread Bhanuprakash Bodireddy
List details of various popular distributions shipping Open vSwitch packages. Also include the information of the distros supporting DPDK accelerated datapath. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- Documentation/automake.mk

[ovs-dev] [PATCH] netdev-dpdk: Use intermediate queue during packet transmission.

2016-12-16 Thread Bhanuprakash Bodireddy
pdk: Use instant sending instead of queueing of packets.") Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com> Co-authored-by: Antonio Fischetti <antonio.fische...@intel.com> Signed-off-by:

[ovs-dev] [RFC PATCH] netdev-dpdk: Add OVS DPDK keep-alive functionality.

2016-12-21 Thread Bhanuprakash Bodireddy
r | <-- | collectd ceilometer plugin | < +--+-+ +---+----+ Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- This patch is based on commit '8b6987d799fb0bc530ebb7f767767b1c661548c9' and [PATCH v2 00/19] DPDK/pmd reconfiguration refactor and bugfixe

[ovs-dev] [PATCH v8] netdev-dpdk: Increase pmd thread priority

2016-12-21 Thread Bhanuprakash Bodireddy
Increase the DPDK pmd thread scheduling priority by lowering the nice value. This will advise the kernel scheduler to prioritize pmd thread over other processes. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- v7->v8: * Rebase * Update the documenta

[ovs-dev] [PATCH 0/7] Add OVS DPDK keep-alive functionality

2017-04-01 Thread Bhanuprakash Bodireddy
r | <-- | collectd ceilometer plugin | < +--+-+ +---++ Bhanuprakash Bodireddy (7): dpdk: Add helper functions for DPDK keepalive. dpif-netdev: Register packet processing cores for keepalive. netdev-dpdk: Add support for keepalive functionality. process: Retrieve process status

[ovs-dev] [PATCH 7/7] Documentation: Update DPDK doc with Keepalive feature.

2017-04-01 Thread Bhanuprakash Bodireddy
Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- Documentation/howto/dpdk.rst | 95 1 file changed, 95 insertions(+) diff --git a/Documentation/howto/dpdk.rst b/Documentation/howto/dpdk.rst index dc63f7d..26f702c

[ovs-dev] [PATCH 6/7] vswitch.xml: Add keepalive support.

2017-04-01 Thread Bhanuprakash Bodireddy
_name"' Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- vswitchd/vswitch.xml | 38 ++ 1 file changed, 38 insertions(+) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 14297bf..1c3ba84 100644 --- a/vswitchd/

[ovs-dev] [RFC PATCH] netdev-dpdk: Add Tx intermediate queue for vhost ports.

2017-04-23 Thread Bhanuprakash Bodireddy
: https://patchwork.ozlabs.org/patch/723309/ Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com> Co-authored-by: Antonio Fischetti <antonio.fische...@intel.com> --- - Limited testing is done with th

[ovs-dev] [PATCH 1/5] dpif-netdev: Skip EMC lookup when EMC is disabled.

2017-03-12 Thread Bhanuprakash Bodireddy
is disabled. This is useful to avoid wasting CPU cycles and also improve performance considerably. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> CC: Ciara Loftus <ciara.lof...@intel.com> CC: Georg Schmuecking <georg.schmueck...@ericsson.com> --- lib/dpif-netd

[ovs-dev] [PATCH 3/5] Documentation: Update DPDK doc EMC conditional insert section.

2017-03-12 Thread Bhanuprakash Bodireddy
Update the documentation with the information on the megaflow hits observed with the default 'emc-insert-inv-prob' value. Also add the recommended setting for achieving higher forwarding performance. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> CC: Ciara

[ovs-dev] [PATCH 2/5] dpif-netdev: Reorder elements in dp_netdev structure.

2017-03-12 Thread Bhanuprakash Bodireddy
'emc_insert_min' variable is made to align on a 64-byte boundary and this introduces a 24 byte hole. This patch moves the emc_insert_min member variable slightly higher in the order to remove the hole and thus saves a cache line with the new ordering. Signed-off-by: Bhanuprakash Bodireddy

[ovs-dev] [PATCH 4/5] dpif-netdev: Fix comments for dp_netdev_pmd_thread struct.

2017-03-12 Thread Bhanuprakash Bodireddy
-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 006cea6..628690a 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -507,9 +507,9 @@ struct t

[ovs-dev] [PATCH 5/5] dp-packet.h: Fix comments in dp_packet_source.

2017-03-12 Thread Bhanuprakash Bodireddy
Add the appropriate function and the source file. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dp-packet.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 17b7026..c73ca19 100644 --- a/lib/dp-pa

[ovs-dev] [PATCH 4/7] process: Retrieve process status.

2017-04-01 Thread Bhanuprakash Bodireddy
Implement function to retrieve the process status. This will be used by Keepalive monitoring thread for detecting false alarms. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/process.c | 60 ++

[ovs-dev] [PATCH 5/7] utils: Introduce xusleep for subsecond granularity.

2017-04-01 Thread Bhanuprakash Bodireddy
This will be used by KA framework that needs millisecond granularity. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/util.c | 12 lib/util.h | 1 + 2 files changed, 13 insertions(+) diff --git a/lib/util.c b/lib/util.c index 1c06ce0..8

[ovs-dev] [PATCH 2/7] dpif-netdev: Register packet processing cores for keepalive.

2017-04-01 Thread Bhanuprakash Bodireddy
This commit registers the packet processing cores for keepalive monitoring. Also the pmd threads respond to heartbeats by marking themselves alive. When the pmd thread is teared down due to datapath reconfiguration the core state is marked as 'sleep'. Signed-off-by: Bhanuprakash Bodireddy

[ovs-dev] [PATCH v3 04/19] Keepalive: Add initial keepalive support.

2017-08-04 Thread Bhanuprakash Bodireddy
en_vSwitch . \ other_config:keepalive-interval="5000" Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/automake.mk| 2 + lib/dpdk-stub.c| 6 ++ lib/dpdk.c | 30 +++-- lib/dpdk.h | 4 ++ lib/ke

[ovs-dev] [PATCH v3 05/19] keepalive: Add more helper functions to KA framework.

2017-08-04 Thread Bhanuprakash Bodireddy
This commit introduces helper functions in 'keepalive' module that are needed to register/unregister PMD threads to KA framework. Also introduce APIs to mark the PMD core states. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/keepalive.

[ovs-dev] [PATCH v3 09/19] keepalive: Retrieve PMD status periodically.

2017-08-04 Thread Bhanuprakash Bodireddy
56784913" "pmd64"="ALIVE,2,9220698256785902" "pmd65"="ALIVE,3,9220698256786231" Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 1 + lib/keepalive.c | 73 ++

[ovs-dev] [PATCH v3 00/19] Add OVS DPDK keep-alive functionality.

2017-08-04 Thread Bhanuprakash Bodireddy
* Fix ovs-appctl keepalive/* hang issue when KA disabled. * Fixed memory leaks with appctl commands for keepalive/pmd-health-show, pmd-xstats-show. * Refactor code and fixed APIs dealing with PMD health monitoring. Bhanuprakash Bodireddy (19): dpdk: Add helper functions for DPDK datapa

[ovs-dev] [PATCH v3 07/19] dpif-netdev: Register packet processing cores to KA framework.

2017-08-04 Thread Bhanuprakash Bodireddy
by marking themselves alive. As long as PMD responds to heartbeats it is considered 'healthy'. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 99 +++ lib/keepalive.c

[ovs-dev] [PATCH v3 08/19] dpif-netdev: Enable heartbeats for DPDK datapath.

2017-08-04 Thread Bhanuprakash Bodireddy
the port. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpdk-stub.c | 6 ++ lib/dpdk.c| 7 +++ lib/dpdk.h| 2 ++ lib/dpif-netdev.c | 9 - lib/keepalive.c | 9 + lib/keepalive.h | 1 + 6 files changed, 33 inse

[ovs-dev] [PATCH v3 06/19] dpif-netdev: Add helper function to store datapath tids.

2017-08-04 Thread Bhanuprakash Bodireddy
This commit adds an API to store the PMD thread ids in to KA info struct. The thread ids shall be used to check false positives and for status and statistics reporting. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 3 +++ lib/keepalive.c

[ovs-dev] [PATCH v3 12/19] keepalive: Add support to query keepalive status.

2017-08-04 Thread Bhanuprakash Bodireddy
This commit adds support to query if keepalive status is enabled/disabled. $ ovs-appctl keepalive/status keepAlive Status: Enabled Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/keepalive.c | 15 +++ 1 file changed, 15 insertions(+)

[ovs-dev] [PATCH v3 02/19] process: Avoid warnings compiling process.c

2017-08-04 Thread Bhanuprakash Bodireddy
This commit fixes the following "sparse" warning: lib/process.c:439:16: error: use of assignment suppression and length modifier together in gnu_scanf format [-Werror=format=]. This fix doesn't need any other changes as the fields aren't used for now. Signed-off-by: Bhanuprakash

[ovs-dev] [PATCH v3 03/19] process: Add helper function to retrieve process status.

2017-08-04 Thread Bhanuprakash Bodireddy
Implement helper function to retrieve the process status. This commit also enables the fields relating to process name, state and core the process was last scheduled. The APIs will be used by keepalive monitoring framework in future commits. Signed-off-by: Bhanuprakash Bodireddy

[ovs-dev] [PATCH v3 01/19] dpdk: Add helper functions for DPDK datapath keepalive.

2017-08-04 Thread Bhanuprakash Bodireddy
Introduce helper functions in 'dpdk' module that are needed for DPDK keepalive functionality. Also add dummy functions in 'dpdk-stub' module that are needed when DPDK datapath is not available. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpdk-stub.

[ovs-dev] [PATCH v3 10/19] bridge: Update keepalive status in OVSDB

2017-08-04 Thread Bhanuprakash Bodireddy
quot;="ALIVE,1,9226460230168100" "pmd64"="ALIVE,2,9226460230168905" "pmd65"="ALIVE,3,9226460230169632"} Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/keepalive.c |

[ovs-dev] [PATCH v3 11/19] keepalive: Add support to query keepalive statistics.

2017-08-04 Thread Bhanuprakash Bodireddy
6 ALIVE 8632190191005713 pmd697 ALIVE 8632190191006555 Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/keepalive.c | 78 + 1 file changed, 78 insertions(+) diff --git

[ovs-dev] [PATCH v2] ovsschema: Fix line lengths.

2017-07-12 Thread Bhanuprakash Bodireddy
According to coding style the line lengths should be <=79. Fix the schema file and update the checksum and version number to reflect the change. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- v1->v2 * Update version number from 7.15.0 -> 7.5.1. Als

[ovs-dev] [PATCH v2] packets: Do not initialize ct_orig_tuple.

2017-07-12 Thread Bhanuprakash Bodireddy
32419.html Fixes: daf4d3c18da4("odp: Support conntrack orig tuple key.") Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com> Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> Co-authored-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@in

[ovs-dev] [PATCH v2 16/19] keepalive: Check the PMD cycle stats as part of PMD health checks.

2017-07-21 Thread Bhanuprakash Bodireddy
This commit adds the support to check the PMD cycle stats. If the cycles aren't changing for a duration of time this can be flagged as possible PMD stall. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 17 + lib/dpif-netdev.

[ovs-dev] [PATCH v2 17/19] netdev-dpdk: Enable PMD health checks on heartbeat failure.

2017-07-21 Thread Bhanuprakash Bodireddy
red. - Link status of the ports polled by PMD thread. - Statistics of the ports polled by PMD thread. - PMD polling and processing cycles. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/keepalive.c | 16 ++ lib/keepalive.h | 2

[ovs-dev] [PATCH v2 07/19] dpif-netdev: Register packet processing cores to KA framework.

2017-07-21 Thread Bhanuprakash Bodireddy
by marking themselves alive. As long as PMD responds to heartbeats it is considered 'healthy'. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 100 +++ lib/keepalive.c

[ovs-dev] [PATCH v2 14/19] keepalive: Check the link status as part of PMD health checks.

2017-07-21 Thread Bhanuprakash Bodireddy
This commit adds the initial support in to performing PMD health checks. The ports handled by the PMD threads are checked for the link status and the same is updated in to keepalive info structure. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-ne

[ovs-dev] [PATCH v2 13/19] dpif-netdev: Add additional datapath health checks.

2017-07-21 Thread Bhanuprakash Bodireddy
keepalive thread. It should be noted that the PMD health checks are only performed on the PMD threads whose health check is enabled. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 30 + lib/keepalive.c

[ovs-dev] [PATCH v2 03/19] process: Add helper function to retrieve process status.

2017-07-21 Thread Bhanuprakash Bodireddy
Implement helper function to retrieve the process status. This commit also enables the fields relating to process name, state and core the process was last scheduled. The APIs will be used by keepalive monitoring framework in future commits. Signed-off-by: Bhanuprakash Bodireddy

[ovs-dev] [PATCH v2 04/19] Keepalive: Add initial keepalive support.

2017-07-21 Thread Bhanuprakash Bodireddy
en_vSwitch . \ other_config:keepalive-interval="5000" Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/automake.mk| 2 + lib/dpdk-stub.c| 6 ++ lib/dpdk.c | 30 +++-- lib/dpdk.h | 4 ++ lib/ke

[ovs-dev] [PATCH v2 10/19] bridge: Update keepalive status in OVSDB

2017-07-21 Thread Bhanuprakash Bodireddy
quot;="ALIVE,1,9226460230168100" "pmd64"="ALIVE,2,9226460230168905" "pmd65"="ALIVE,3,9226460230169632"} Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/keepalive.c |

[ovs-dev] [PATCH v2 15/19] keepalive: Check the packet statistics as part of PMD health checks.

2017-07-21 Thread Bhanuprakash Bodireddy
-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 25 +++--- lib/keepalive.c | 97 +++ lib/keepalive.h | 5 +++ 3 files changed, 122 insertions(+), 5 deletions(-) diff --git a/lib/dpif-netd

[ovs-dev] [PATCH v2 11/19] keepalive: Add support to query keepalive statistics.

2017-07-21 Thread Bhanuprakash Bodireddy
6 ALIVE 8632190191005713 pmd697 ALIVE 8632190191006555 Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/keepalive.c | 78 + 1 file changed, 78 insertions(+) diff --git

[ovs-dev] [PATCH v2 02/19] process: Avoid warnings compiling process.c

2017-07-21 Thread Bhanuprakash Bodireddy
This commit fixes the following "sparse" warning: lib/process.c:439:16: error: use of assignment suppression and length modifier together in gnu_scanf format [-Werror=format=]. This fix doesn't need any other changes as the fields aren't used for now. Signed-off-by: Bhanuprakash

[ovs-dev] [PATCH v2 00/19] Add OVS DPDK keep-alive functionality.

2017-07-21 Thread Bhanuprakash Bodireddy
e the actual implementation is done(suggested by Ben). * Fix ovs-appctl keepalive/* hang issue when KA disabled. * Fixed memory leaks with appctl commands for keepalive/pmd-health-show, pmd-xstats-show. * Refactor code and fixed APIs dealing with PMD health monitoring. Bhanuprakash Bodire

[ovs-dev] [PATCH v2 01/19] dpdk: Add helper functions for DPDK datapath keepalive.

2017-07-21 Thread Bhanuprakash Bodireddy
Introduce helper functions in 'dpdk' module that are needed for DPDK keepalive functionality. Also add dummy functions in 'dpdk-stub' module that are needed when DPDK datapath is not available. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpdk-stub.

[ovs-dev] [PATCH v2 19/19] Documentation: Update DPDK doc with Keepalive feature.

2017-07-21 Thread Bhanuprakash Bodireddy
ns, Avg:173,005ns, Max:1,504,670ns) for Phy2Phy loopback test case with 100 unique streams. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- Documentation/howto/dpdk.rst | 90 1 file changed, 90 insertions(+) dif

[ovs-dev] [PATCH v2 09/19] keepalive: Retrieve PMD status periodically.

2017-07-21 Thread Bhanuprakash Bodireddy
56784913" "pmd64"="ALIVE,2,9220698256785902" "pmd65"="ALIVE,3,9220698256786231" Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 1 + lib/keepalive.c | 73 ++

[ovs-dev] [PATCH v2 08/19] dpif-netdev: Enable heartbeats for DPDK datapath.

2017-07-21 Thread Bhanuprakash Bodireddy
the port. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpdk-stub.c | 6 ++ lib/dpdk.c| 7 +++ lib/dpdk.h| 2 ++ lib/dpif-netdev.c | 9 - lib/keepalive.c | 9 + lib/keepalive.h | 1 + 6 files changed, 33 inse

[ovs-dev] [PATCH] util: Add PADDED_MEMBERS_CACHELINE_MARKER macro to mark cachelines.

2017-07-24 Thread Bhanuprakash Bodireddy
PADDED_MEMBERS_CACHELINE_MARKER macro introduces a way to mark cachelines. This macro expands to an anonymous union containing cacheline marker, members in nested anonymous structure, followed by array of bytes that is multiple of UNIT bytes. Signed-off-by: Bhanuprakash Bodireddy

[ovs-dev] [PATCH v3] packets: Reorganize the pkt_metadata structure.

2017-07-24 Thread Bhanuprakash Bodireddy
having the members that needs to be zeroed out. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> Signed-off-by: Ben Pfaff <b...@ovn.org> --- v2->v3: Use PADDED_MEMBERS_CACHELINE_MARKER. v1->v2: Use PADDED_MEMBERS. lib/packets.h | 23 +--

[ovs-dev] [PATCH] dpif-netdev: Reorder elements in dp_netdev_port structure.

2017-07-24 Thread Bhanuprakash Bodireddy
padbytes:0, cachelines:2 Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 47a9fa0..fb5d612 100644 --- a/lib/dpif-netdev.c +++ b/li

[ovs-dev] [PATCH v3 0/6] netdev-dpdk: Use intermediate queue during packet transmission.

2017-06-29 Thread Bhanuprakash Bodireddy
es appropriately. * No functional change changes. Bhanuprakash Bodireddy (6): netdev: Add netdev_txq_flush function. netdev-dpdk: Add netdev_dpdk_txq_flush function. netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function. netdev-dpdk: Add intermediate queue support. netdev-dpdk: Enable in

[ovs-dev] [PATCH v3 1/6] netdev: Add netdev_txq_flush function.

2017-06-29 Thread Bhanuprakash Bodireddy
Add netdev_txq_flush(), that flush packets on a queue. This is needed to transmit packets on the intermediate queue. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com> Co-authored-by: Anton

[ovs-dev] [PATCH v3 2/6] netdev-dpdk: Add netdev_dpdk_txq_flush function.

2017-06-29 Thread Bhanuprakash Bodireddy
This commit adds netdev_dpdk_txq_flush() function. If there are any packets waiting in the queue, they are transmitted instantly using the rte_eth_tx_burst function. In XPS enabled case, lock is taken on the tx queue before flushing the queue. Signed-off-by: Bhanuprakash Bodireddy

[ovs-dev] [PATCH v3 3/6] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-06-29 Thread Bhanuprakash Bodireddy
Add netdev_dpdk_vhost_txq_flush(), that flushes packets on vHost User port queues. Also add netdev_dpdk_vhost_tx_burst() function that uses rte_vhost_enqueue_burst() to enqueue burst of packets on vHost User ports. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com>

[ovs-dev] [PATCH v3 5/6] netdev-dpdk: Enable intermediate queue for vHost User port.

2017-06-29 Thread Bhanuprakash Bodireddy
hau...@redhat.com>] Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com> Co-authored-by: Antonio Fischetti <antonio.fische...@intel.com> Acked-by: Eelco Chaudron <echau...@redhat.com&g

[ovs-dev] [PATCH v3 6/6] dpif-netdev: Flush the packets in intermediate queue.

2017-06-29 Thread Bhanuprakash Bodireddy
-by: Eelco Chaudron <echau...@redhat.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/331039.html Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com> Co-authored-by:

[ovs-dev] [PATCH 01/20] process: Consolidate process related APIs.

2017-07-03 Thread Bhanuprakash Bodireddy
functionality. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/process.c | 189 lib/process.h | 12 +++ lib/util.c | 68 + lib/util.h | 3 + vswitchd/system-stats.c

[ovs-dev] [PATCH 00/20] Add OVS DPDK keep-alive functionality.

2017-07-03 Thread Bhanuprakash Bodireddy
pctl commands for keepalive/pmd-health-show, pmd-xstats-show. * Refactored code and fixed APIs dealing with PMD health monitoring. Bhanuprakash Bodireddy (20): process: Consolidate process related APIs. dpdk: Add helper functions for DPDK datapath keepalive. process: Avoid warning

[ovs-dev] [PATCH 03/20] process: Avoid warnings compiling process.c

2017-07-03 Thread Bhanuprakash Bodireddy
This commit fixes the following "sparse" warning: lib/process.c:439:16: error: use of assignment suppression and length modifier together in gnu_scanf format [-Werror=format=]. This fix doesn't need any other changes as the fields aren't used for now. Signed-off-by: Bhanuprakash

[ovs-dev] [PATCH 02/20] dpdk: Add helper functions for DPDK datapath keepalive.

2017-07-03 Thread Bhanuprakash Bodireddy
Introduce helper functions in 'dpdk' module that are needed for DPDK keepalive functionality. Also add dummy functions in 'dpdk-stub' module that are needed when DPDK datapath is not available. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpdk-stub.

[ovs-dev] [PATCH 05/20] Keepalive: Add initial keepalive support.

2017-07-03 Thread Bhanuprakash Bodireddy
en_vSwitch . \ other_config:keepalive-interval="5000" Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/automake.mk| 2 + lib/dpdk-stub.c| 6 ++ lib/dpdk.c | 30 +++-- lib/dpdk.h | 4 ++ lib/ke

[ovs-dev] [PATCH 07/20] dpif-netdev: Add helper function to store datapath tids.

2017-07-03 Thread Bhanuprakash Bodireddy
This commit adds an API to store the PMD thread ids in to KA info struct. The thread ids shall be used to check false positives and for status and statistics reporting. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 3 +++ lib/keepalive.c

[ovs-dev] [PATCH 04/20] process: Add helper function to retrieve process status.

2017-07-03 Thread Bhanuprakash Bodireddy
Implement helper function to retrieve the process status. This commit also enables the fields relating to process name, state and core the process was last scheduled. The APIs will be used by keepalive monitoring framework in future commits. Signed-off-by: Bhanuprakash Bodireddy

[ovs-dev] [PATCH 06/20] keepalive: Add more helper functions to KA framework.

2017-07-03 Thread Bhanuprakash Bodireddy
This commit introduces helper functions in 'keepalive' module that are needed to register/unregister PMD threads to KA framework. Also introduce APIs to mark the PMD core states. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/keepalive.

[ovs-dev] [PATCH 08/20] dpif-netdev: Register packet processing cores to KA framework.

2017-07-03 Thread Bhanuprakash Bodireddy
by marking themselves alive. As long as PMD responds to heartbeats it is considered 'healthy'. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 100 +++ lib/keepalive.c

[ovs-dev] [PATCH 09/20] dpif-netdev: Enable heartbeats for DPDK datapath.

2017-07-03 Thread Bhanuprakash Bodireddy
the port. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpdk-stub.c | 6 ++ lib/dpdk.c| 7 +++ lib/dpdk.h| 2 ++ lib/dpif-netdev.c | 9 - lib/keepalive.c | 9 + lib/keepalive.h | 1 + 6 files changed, 33 inse

[ovs-dev] [PATCH 11/20] bridge: Update keepalive status in OVSDB

2017-07-03 Thread Bhanuprakash Bodireddy
quot;="ALIVE,1,9226460230168100" "pmd64"="ALIVE,2,9226460230168905" "pmd65"="ALIVE,3,9226460230169632"} Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/keepalive.c |

[ovs-dev] [PATCH 12/20] keepalive: Add support to query keepalive statistics.

2017-07-03 Thread Bhanuprakash Bodireddy
6 ALIVE 8632190191005713 pmd697 ALIVE 8632190191006555 Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/keepalive.c | 78 + 1 file changed, 78 insertions(+) diff --git

[ovs-dev] [PATCH 14/20] dpif-netdev: Add additional datapath health checks.

2017-07-03 Thread Bhanuprakash Bodireddy
keepalive thread. It should be noted that the PMD health checks are only performed on the PMD threads whose health check is enabled. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 30 + lib/keepalive.c

[ovs-dev] [PATCH 13/20] keepalive: Add support to query keepalive status.

2017-07-03 Thread Bhanuprakash Bodireddy
This commit adds support to query if keepalive status is enabled/disabled. $ ovs-appctl keepalive/status keepAlive Status: Enabled Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/keepalive.c | 15 +++ 1 file changed, 15 insertions(+)

[ovs-dev] [PATCH 15/20] keepalive: Check the link status as part of PMD health checks.

2017-07-03 Thread Bhanuprakash Bodireddy
This commit adds the initial support in to performing PMD health checks. The ports handled by the PMD threads are checked for the link status and the same is updated in to keepalive info structure. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-ne

[ovs-dev] [PATCH 16/20] keepalive: Check the packet statistics as part of PMD health checks.

2017-07-03 Thread Bhanuprakash Bodireddy
-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 25 +++--- lib/keepalive.c | 97 +++ lib/keepalive.h | 5 +++ 3 files changed, 122 insertions(+), 5 deletions(-) diff --git a/lib/dpif-netd

[ovs-dev] [PATCH 19/20] keepalive: Display extended Keepalive status.

2017-07-03 Thread Bhanuprakash Bodireddy
, on a heartbeat failure, health checks are enabled and additional stats(pkt stats, cpu cycles) are displayed as above. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/keepalive.c | 112 1 file change

[ovs-dev] [PATCH 18/20] netdev-dpdk: Enable PMD health checks on heartbeat failure.

2017-07-03 Thread Bhanuprakash Bodireddy
red. - Link status of the ports polled by PMD thread. - Statistics of the ports polled by PMD thread. - PMD polling and processing cycles. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/keepalive.c | 16 ++ lib/keepalive.h | 2

[ovs-dev] [PATCH 17/20] keepalive: Check the PMD cycle stats as part of PMD health checks.

2017-07-03 Thread Bhanuprakash Bodireddy
This commit adds the support to check the PMD cycle stats. If the cycles aren't changing for a duration of time this can be flagged as possible PMD stall. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 16 +--- lib/dpif-netdev.

[ovs-dev] [PATCH 20/20] Documentation: Update DPDK doc with Keepalive feature.

2017-07-03 Thread Bhanuprakash Bodireddy
ns, Avg:173,005ns, Max:1,504,670ns) for Phy2Phy loopback test case with 100 unique streams. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- Documentation/howto/dpdk.rst | 90 1 file changed, 90 insertions(+) dif

[ovs-dev] [PATCH v2 3/6] dpif-netdev: Register packet processing cores for keepalive.

2017-04-26 Thread Bhanuprakash Bodireddy
This commit registers the packet processing cores for keepalive monitoring. Also the pmd threads respond to heartbeats by marking themselves alive. When the pmd thread is teared down due to datapath reconfiguration the core state is marked as 'sleep'. Signed-off-by: Bhanuprakash Bodireddy

[ovs-dev] [PATCH v2 4/6] netdev-dpdk: Add support for keepalive functionality.

2017-04-26 Thread Bhanuprakash Bodireddy
implements APIs to read the keepalive settings from OVSDB. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/netdev-dpdk.c | 220 +- 1 file changed, 219 insertions(+), 1 deletion(-) diff --git a/lib/netdev-dp

[ovs-dev] [PATCH v2 6/6] Documentation: Update DPDK doc with Keepalive feature.

2017-04-26 Thread Bhanuprakash Bodireddy
rved with KA feature enabled. The tests were run with 100ms KA interval and latency is (Min:134,710ns, Avg:173,005ns, Max:1,504,670ns) for Phy2Phy loopback test case with 100 unique streams. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire..

[ovs-dev] [PATCH v2 5/6] vswitch.xml: Add keepalive support.

2017-04-26 Thread Bhanuprakash Bodireddy
_name"' Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- vswitchd/vswitch.xml | 38 ++ 1 file changed, 38 insertions(+) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 02980b1..458148c 100644 --- a/vswitchd/

[ovs-dev] [PATCH v2 1/6] dpdk: Add helper functions for DPDK keepalive.

2017-04-26 Thread Bhanuprakash Bodireddy
Introduce helper functions in 'dpdk' module that are needed for keepalive functionality. Also add dummy functions in 'dpdk-stub' module that are needed when DPDK is not available. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpdk-stub.c

[ovs-dev] [PATCH v2 2/6] process: Retrieve process status.

2017-04-26 Thread Bhanuprakash Bodireddy
Implement function to retrieve the process status. This will be used by Keepalive monitoring thread for detecting false alarms. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/process.c | 60 ++

[ovs-dev] [PATCH v2 0/6] Add OVS DPDK keep-alive functionality

2017-04-26 Thread Bhanuprakash Bodireddy
states. - Remove semaphore and all the logic associated with it. - Fix the documentation as suggested. - Fix and added few appropriate comments to KA helper functions. - Add latency stats details in the commit log for future reference. Bhanuprakash Bodireddy (6): dpdk: Add helper functions for DPDK

[ovs-dev] [PATCH v4 3/5] netdev-dpdk: Add intermediate queue support.

2017-08-08 Thread Bhanuprakash Bodireddy
This commit introduces netdev_dpdk_eth_tx_queue() function that implements intermediate queue and packet buffering. The packets get buffered till the threshold 'INTERIM_QUEUE_BURST_THRESHOLD[32] is reached and eventually gets transmitted. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bod

[ovs-dev] [PATCH v4 4/5] netdev-dpdk: Enable intermediate queue for vHost User port.

2017-08-08 Thread Bhanuprakash Bodireddy
hau...@redhat.com>] Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com> Co-authored-by: Antonio Fischetti <antonio.fische...@intel.com> Acked-by: Eelco Chaudron <echau...@redhat.com&g

[ovs-dev] [PATCH v4 1/5] netdev: Add netdev_txq_flush function.

2017-08-08 Thread Bhanuprakash Bodireddy
. In XPS enabled case, lock is taken on the tx queue before flushing the queue. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com> Co-authored-by: Antonio Fischetti <antonio.fische...@intel.com> Sig

[ovs-dev] [PATCH] dpif-netdev: Fix comments for dp_netdev_pmd_thread struct.

2017-05-15 Thread Bhanuprakash Bodireddy
("dpif-netdev: dpcls per in_port with sorted subtables") Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/dpif-netdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/l

[ovs-dev] [RFC PATCH v2 04/19] bridge: Invoke keepalive framework.

2017-06-12 Thread Bhanuprakash Bodireddy
. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- vswitchd/bridge.c | 4 1 file changed, 4 insertions(+) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index cc7a43b..d40879d 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -34,6 +34,7 @@ #i

[ovs-dev] [RFC PATCH v2 06/19] dpif-netdev: Register packet processing cores to KA framework.

2017-06-12 Thread Bhanuprakash Bodireddy
by marking themselves alive. As long as PMD responds to heartbeats it is considered 'healthy'. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 65 +++ 1 file changed, 65 insertions(+) diff --git

[ovs-dev] [RFC PATCH v2 05/19] keepalive: Add more helper functions to KA framework.

2017-06-12 Thread Bhanuprakash Bodireddy
This commit introduces helper functions in 'keepalive' module that are needed to register/unregister PMD threads to KA framework. Also introduce APIs to mark the PMD core states. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/keepalive.

[ovs-dev] [RFC PATCH v2 13/19] dpif-netdev: Add additional datapath health checks.

2017-06-12 Thread Bhanuprakash Bodireddy
keepalive thread. It should be noted that the PMD health checks are only performed on the PMD threads whose health check is enabled. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 23 +++ lib/keepalive.c

[ovs-dev] [RFC PATCH v2 14/19] keepalive: Check the link status as part of PMD health checks.

2017-06-12 Thread Bhanuprakash Bodireddy
This commit adds the initial support in to performing PMD health checks. The ports handled by the PMD threads are checked for the link status and the same is updated in to SHM block. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.

[ovs-dev] [RFC PATCH v2 12/19] dpif-netdev: Add helper function to check false positives.

2017-06-12 Thread Bhanuprakash Bodireddy
This commit adds an API to store the PMD thread id in SHM block. The tid later shall be retrieved by callback function that gets invoked to check for false positives. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpif-netdev.c | 1 + lib/keepalive.c

[ovs-dev] [RFC PATCH v2 07/19] dpif-netdev: Enable heartbeats for DPDK datapath.

2017-06-12 Thread Bhanuprakash Bodireddy
the port. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpdk-stub.c | 6 ++ lib/dpdk.c| 7 +++ lib/dpdk.h| 2 ++ lib/dpif-netdev.c | 5 + 4 files changed, 20 insertions(+) diff --git a/lib/dpdk-stub.c b/lib/dpdk-stub.c index d

[ovs-dev] [RFC PATCH v2 08/19] keepalive: Retrieve PMD status periodically.

2017-06-12 Thread Bhanuprakash Bodireddy
LIVE,9220698256784207" CORE_1="ALIVE,9220698256784913" CORE_2="ALIVE,9220698256785902" CORE_3="ALIVE,9220698256786231" Datapath status:HEALTHY" Signed-off-by: Bhanuprakash Bodireddy <bhan

[ovs-dev] [RFC PATCH v2 01/19] dpdk: Add helper functions for DPDK datapath keepalive.

2017-06-12 Thread Bhanuprakash Bodireddy
Introduce helper functions in 'dpdk' module that are needed for DPDK keepalive functionality. Also add dummy functions in 'dpdk-stub' module that are needed when DPDK datapath is not available. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/dpdk-stub.

[ovs-dev] [RFC PATCH v2 18/19] keepalive: Display extended Keepalive status.

2017-06-12 Thread Bhanuprakash Bodireddy
and additional stats(pkt stats, cpu cycles) are displayed as above. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/keepalive.c | 129 1 file changed, 129 insertions(+) diff --git a/lib/keepalive.c b/lib/keepa

[ovs-dev] [RFC PATCH v2 00/19] Add OVS DPDK keep-alive functionality

2017-06-12 Thread Bhanuprakash Bodireddy
xstats-show. * Refactored code and fixed APIs dealing with PMD health monitoring. Bhanuprakash Bodireddy (19): [9] patches help update OVSDB with keepalive status dpdk: Add helper functions for DPDK datapath keepalive. process: Retrieve process status. Keepalive: Add initial keepaliv

[ovs-dev] [RFC PATCH v2 02/19] process: Retrieve process status.

2017-06-12 Thread Bhanuprakash Bodireddy
Implement helper function to retrieve the process status. This will be used by keepalive monitoring thread to detect false alarms and to show PMD thread state in future commits. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/process.

[ovs-dev] [RFC PATCH v2 03/19] Keepalive: Add initial keepalive support.

2017-06-12 Thread Bhanuprakash Bodireddy
5000" To set shared memory block name where the events shall be updated 'ovs-vsctl --no-wait set Open_vSwitch . other_config:keepalive-shm-name="/ovs_keepalive_shm_name"' Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> --- lib/automa

  1   2   3   >