8632190191006555
Datapath status : BAD
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 78 +
1 file changed, 78 insertions(+)
diff --git a/lib/keepalive.c b/lib/keepalive.c
index ff9ce2b..3786d47 100644
--- a/lib
"CORE_1"="ALIVE,9226460230168100"
"CORE_2"="ALIVE,9226460230168905"
"CORE_3"="ALIVE,9226460230169632"
This commit adds support to query if keepalive status is
enabled/disabled.
$ ovs-appctl keepalive/status
keepAlive Status: Enabled
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/lib/keepalive.c b/lib
This commit adds an API to store the PMD thread id in SHM block.
The tid later shall be retrieved by callback function that gets invoked to
check for false positives.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 1 +
lib/keepalive.c | 23 +++
lib
keepalive thread.
It should be noted that the PMD health checks are only performed on
the PMD threads whose health check is enabled.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 23 +++
lib/keepalive.c | 47
This commit adds the initial support in to performing PMD health checks.
The ports handled by the PMD threads are checked for the link status and
the same is updated in to SHM block.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 42 --
lib/keepalive.c
d-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 23 +++--
lib/keepalive.c | 100 ++
lib/keepalive.h | 6
3 files changed, 126 insertions(+), 3 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 32
d.
- Link status of the ports polled by PMD thread.
- Statistics of the ports polled by PMD thread.
- PMD polling and processing cycles.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.h | 3 +++
lib/netdev-dpdk.c | 55 +--
2 fi
This commit adds the support to check the PMD cycle stats. If the cycles
aren't changing for a duration of time this can be flagged as possible
PMD stall.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 18 +++---
lib/dpif-netdev.h | 6 ++
lib/keepalive.c
additional stats(pkt stats, cpu cycles) are displayed as above.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 129
1 file changed, 129 insertions(+)
diff --git a/lib/keepalive.c b/lib/keepalive.c
index 84813bf..014001e 100644
--
No noticeable performance or latency impact is observed with
KA feature enabled. The tests were run with 100ms KA interval
and latency is (Min:134,710ns, Avg:173,005ns, Max:1,504,670ns)
for Phy2Phy loopback test case with 100 unique streams.
Sig
gt; v2
* Merged the xml and schema commits to later commit where the actual
implementation is done(suggested by Ben).
* Fix ovs-appctl keepalive/* hang issue when KA disabled.
* Fixed memory leaks with appctl commands for keepalive/pmd-health-show,
pmd-xstats-show.
* Refactored code and
Introduce helper functions in 'dpdk' module that are needed for
DPDK keepalive functionality. Also add dummy functions in 'dpdk-stub' module
that are needed when DPDK datapath is not available.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpdk-stub.c | 24
Implement helper functions to retrieve the process status, name and last
core the process was scheduled. The APIs will be used by keepalive monitoring
framework in future commits.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/process.c | 152
vs-vsctl --no-wait set Open_vSwitch . \
other_config:keepalive-interval="5000"
Signed-off-by: Bhanuprakash Bodireddy
---
lib/automake.mk| 2 +
lib/dpdk.c | 17 +
lib/dpdk.h | 2 +
lib/keepalive.c| 160 ++
This commit introduces helper functions in 'keepalive' module that are
needed to register/unregister PMD threads to KA framework. Also
introduce APIs to mark the PMD core states.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepal
This commit adds an API to store the PMD thread ids in to KA info struct.
The thread ids shall be used to check false positives and for status and
statistics reporting.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 3 +++
lib/keepalive.c | 13 +
lib/keepalive.h
marking themselves
alive. As long as PMD responds to heartbeats it is considered 'healthy'.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 100 +
lib/keepalive.c | 130 +++---
lib/k
ad polling the port.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpdk-stub.c | 6 ++
lib/dpdk.c| 7 +++
lib/dpdk.h| 2 ++
lib/dpif-netdev.c | 9 -
lib/keepalive.c | 9 +
lib/keepalive.h | 1 +
6 files changed, 33 insertions(+), 1 deletion(-)
diff -
56784913"
"PMD64"="ALIVE,2,9220698256785902"
"PMD65"="ALIVE,3,9220698256786231"
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 1 +
lib/keepalive.c | 73 +++
lib/keepalive.h
quot;="ALIVE,1,9226460230168100"
"PMD64"="ALIVE,2,9226460230168905"
"PMD65"="ALIVE,3,9226460230169632"}
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 15 +++
lib/keepalive.h |
6 ALIVE 8632190191005713
pmd697 ALIVE 8632190191006555
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 78 +
1 file changed, 78 insertions(+)
diff --git a/lib/keepalive.c b/lib/keepalive.c
index f0b75f0
This commit adds support to query if keepalive status is
enabled/disabled.
$ ovs-appctl keepalive/status
keepAlive Status: Enabled
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/lib/keepalive.c b/lib
keepalive thread.
It should be noted that the PMD health checks are only performed on
the PMD threads whose health check is enabled.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 30 +
lib/keepalive.c | 81
This commit adds the initial support in to performing PMD health checks.
The ports handled by the PMD threads are checked for the link status and
the same is updated in to keepalive info structure.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 37
This commit adds the support to check the PMD cycle stats. If the cycles
aren't changing for a duration of time this can be flagged as possible
PMD stall.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 16 +---
lib/dpif-netdev.h | 6 ++
lib/keepalive.c
d-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 25 +++---
lib/keepalive.c | 97 +++
lib/keepalive.h | 5 +++
3 files changed, 122 insertions(+), 5 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 4d
d.
- Link status of the ports polled by PMD thread.
- Statistics of the ports polled by PMD thread.
- PMD polling and processing cycles.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 16 ++
lib/keepalive.h | 2
d latency is (Min:134,710ns, Avg:173,005ns, Max:1,504,670ns)
for Phy2Phy loopback test case with 100 unique streams.
Signed-off-by: Bhanuprakash Bodireddy
---
Documentation/howto/dpdk.rst | 90
1 file changed, 90 insertions(+)
diff --git a/Documenta
, health checks are enabled
and additional stats(pkt stats, cpu cycles) are displayed as above.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 112
1 file changed, 112 insertions(+)
diff --git a/lib/keepalive.c b/lib/keepalive.c
ble
names appropriately.
* No functional change changes.
Bhanuprakash Bodireddy (6):
netdev: Add netdev_txq_flush function.
netdev-dpdk: Add netdev_dpdk_txq_flush function.
netdev-dpdk: Add intermediate queue support.
dpif-netdev: Flush the packets in intermediate queue.
netdev-dpdk:
Add netdev_txq_flush(), that flush packets on a queue. This is needed
to transmit packets on the intermediate queue.
Signed-off-by: Bhanuprakash Bodireddy
Signed-off-by: Antonio Fischetti
Co-authored-by: Antonio Fischetti
Signed-off-by: Markus Magnusson
Co-authored-by: Markus Magnusson
Acked
This commit adds netdev_dpdk_txq_flush() function. If there are
any packets waiting in the queue, they are transmitted instantly
using the rte_eth_tx_burst function. In XPS enabled case, lock is
taken on the tx queue before flushing the queue.
Signed-off-by: Bhanuprakash Bodireddy
Signed-off-by
t low rate and
can potentially get stuck in the queue, flush logic is implemented
that gets invoked from dp_netdev_flush_txq_ports() as part of PMD packet
processing loop.
Signed-off-by: Bhanuprakash Bodireddy
Signed-off-by: Antonio Fischetti
Co-authored-by: Antonio Fischetti
Signed-off-by: M
: Eelco Chaudron
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/331039.html
Signed-off-by: Bhanuprakash Bodireddy
Signed-off-by: Antonio Fischetti
Co-authored-by: Antonio Fischetti
Signed-off-by: Markus Magnusson
Co-authored-by: Markus Magnusson
Acked-by: Eelco Chaudron
ff-by: Bhanuprakash Bodireddy
Signed-off-by: Antonio Fischetti
Co-authored-by: Antonio Fischetti
Acked-by: Eelco Chaudron
---
lib/netdev-dpdk.c | 38 +++---
1 file changed, 15 insertions(+), 23 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
Add netdev_dpdk_vhost_txq_flush(), that flushes packets on vHost User
port queues. Also add netdev_dpdk_vhost_tx_burst() function that
uses rte_vhost_enqueue_burst() to enqueue burst of packets on vHost User
ports.
Signed-off-by: Bhanuprakash Bodireddy
Signed-off-by: Antonio Fischetti
Co
Suggest the author to use the OVS wrapper of the assert function.
Signed-off-by: Bhanuprakash Bodireddy
---
utilities/checkpatch.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index b45a255..304d2fd 100755
--- a/utilities/checkpatch.py
According to coding style the line lengths should be <=79. Fix the
schema file and update only the checksum as no changes are made to
schema.
Signed-off-by: Bhanuprakash Bodireddy
---
vswitchd/vswitch.ovsschema | 65 ++
1 file changed, 43 inserti
is passed to qsort in this case.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 2b65dc7..4b5b23b 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -884
e any functionality.
CC: Ben Pfaff
Signed-off-by: Bhanuprakash Bodireddy
---
lib/process.c | 172 +
lib/process.h | 12 +++
lib/util.c | 85
lib/util.h | 4 +
vswitchd/system-stats.c
Clang reports "Argument with 'nonnull' attribute passed null" warning.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpctl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/dpctl.c b/lib/dpctl.c
index 7f44d02..2ad475b 100644
--- a/lib/dpctl
Clang reports variable 'ifmsg' never been used in the function.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netlink-rtnl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/dpif-netlink-rtnl.c b/lib/dpif-netlink-rtnl.c
index c3c31eb..17ae24a 100644
---
Clang reports that array access from 'dumps' variable result in null pointer
dereference.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/netdev.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/lib/netdev.c b/lib/netdev.c
index 001b7b3..336c141 10
Clang reports that value store to 'batch_size' is never read.
Signed-off-by: Bhanuprakash Bodireddy
---
tests/test-conntrack.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/test-conntrack.c b/tests/test-conntrack.c
index f79a9fc..5d2f8b8 100644
--- a/tests/test-conntra
e any functionality.
CC: Ben Pfaff
Signed-off-by: Bhanuprakash Bodireddy
---
v1->v2
* Move ticks_to_ms() from util.c to process.c
* Verify the changes and test it by enabling statistics using,
$ovs-vsctl set Open_vSwitch . other_config:enable-statistics=true
lib/process.c
'-20'.
$ ps -eLo comm,policy,psr,nice | grep pmd
COMMAND POLICY PROCESSORNICE
pmd62 TS3-20
pmd63 TS0-20
pmd64 TS1-20
pmd65 TS2-20
Signed-off-by: Bhanuprakash Bodireddy
Tested
-dev/2017-May/332419.html
Fixes: daf4d3c18da4("odp: Support conntrack orig tuple key.")
Signed-off-by: Daniele Di Proietto
Signed-off-by: Bhanuprakash Bodireddy
Co-authored-by: Bhanuprakash Bodireddy
---
Original RFC was posted by Daniele here:
https://mail.openvswitch.org/pipermail/ovs-
having the members that needs to be zeroed out.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/packets.h | 30 --
lib/util.h| 1 +
2 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/lib/packets.h b/lib/packets.h
index 94c3dcc..2c942aa 100644
--- a/lib
'-20'.
$ ps -eLo comm,policy,psr,nice | grep pmd
COMMAND POLICY PROCESSORNICE
pmd62 TS3-20
pmd63 TS0-20
pmd64 TS1-20
pmd65 TS2-20
Signed-off-by: Bhanuprakash Bodireddy
Tested
priately.
* No functional change changes.
Bhanuprakash Bodireddy (6):
netdev: Add netdev_txq_flush function.
netdev-dpdk: Add netdev_dpdk_txq_flush function.
netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.
netdev-dpdk: Add intermediate queue support.
netdev-dpdk: Enable interm
This commit adds netdev_dpdk_txq_flush() function. If there are
any packets waiting in the queue, they are transmitted instantly
using the rte_eth_tx_burst function. In XPS enabled case, lock is
taken on the tx queue before flushing the queue.
Signed-off-by: Bhanuprakash Bodireddy
Signed-off-by
Add netdev_dpdk_vhost_txq_flush(), that flushes packets on vHost User
port queues. Also add netdev_dpdk_vhost_tx_burst() function that
uses rte_vhost_enqueue_burst() to enqueue burst of packets on vHost User
ports.
Signed-off-by: Bhanuprakash Bodireddy
Signed-off-by: Antonio Fischetti
Co
Add netdev_txq_flush(), that flush packets on a queue. This is needed
to transmit packets on the intermediate queue.
Signed-off-by: Bhanuprakash Bodireddy
Signed-off-by: Antonio Fischetti
Co-authored-by: Antonio Fischetti
Signed-off-by: Markus Magnusson
Co-authored-by: Markus Magnusson
Acked
t low rate and
can potentially get stuck in the queue, flush logic is implemented
that gets invoked from dp_netdev_flush_txq_ports() as part of PMD packet
processing loop.
Signed-off-by: Bhanuprakash Bodireddy
Signed-off-by: Antonio Fischetti
Co-authored-by: Antonio Fischetti
Signed-off-by: M
ff-by: Bhanuprakash Bodireddy
Signed-off-by: Antonio Fischetti
Co-authored-by: Antonio Fischetti
Acked-by: Eelco Chaudron
---
lib/netdev-dpdk.c | 38 +++---
1 file changed, 15 insertions(+), 23 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
: Eelco Chaudron
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/331039.html
Signed-off-by: Bhanuprakash Bodireddy
Signed-off-by: Antonio Fischetti
Co-authored-by: Antonio Fischetti
Signed-off-by: Markus Magnusson
Co-authored-by: Markus Magnusson
Acked-by: Eelco Chaudron
* Fixed memory leaks with appctl commands for keepalive/pmd-health-show,
pmd-xstats-show.
* Refactored code and fixed APIs dealing with PMD health monitoring.
Bhanuprakash Bodireddy (20):
process: Consolidate process related APIs.
dpdk: Add helper functions for DPDK datapath keepa
e any functionality.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/process.c | 189
lib/process.h | 12 +++
lib/util.c | 68 +
lib/util.h | 3 +
vswitchd/system-stats.c
Introduce helper functions in 'dpdk' module that are needed for
DPDK keepalive functionality. Also add dummy functions in 'dpdk-stub' module
that are needed when DPDK datapath is not available.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpdk-stub.c | 24
This commit fixes the following "sparse" warning:
lib/process.c:439:16: error: use of assignment suppression and length
modifier together in gnu_scanf format [-Werror=format=].
This fix doesn't need any other changes as the fields aren't used for now.
Signed-off-by: Bh
Implement helper function to retrieve the process status. This commit
also enables the fields relating to process name, state and core the
process was last scheduled. The APIs will be used by keepalive monitoring
framework in future commits.
Signed-off-by: Bhanuprakash Bodireddy
---
lib
vs-vsctl --no-wait set Open_vSwitch . \
other_config:keepalive-interval="5000"
Signed-off-by: Bhanuprakash Bodireddy
---
lib/automake.mk| 2 +
lib/dpdk-stub.c| 6 ++
lib/dpdk.c | 30 +++--
lib/dpdk.h
This commit introduces helper functions in 'keepalive' module that are
needed to register/unregister PMD threads to KA framework. Also
introduce APIs to mark the PMD core states.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepal
This commit adds an API to store the PMD thread ids in to KA info struct.
The thread ids shall be used to check false positives and for status and
statistics reporting.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 3 +++
lib/keepalive.c | 13 +
lib/keepalive.h
marking themselves
alive. As long as PMD responds to heartbeats it is considered 'healthy'.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 100 +++
lib/keepalive.c | 138 +++---
lib/keepalive
ad polling the port.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpdk-stub.c | 6 ++
lib/dpdk.c| 7 +++
lib/dpdk.h| 2 ++
lib/dpif-netdev.c | 9 -
lib/keepalive.c | 9 +
lib/keepalive.h | 1 +
6 files changed, 33 insertions(+), 1 deletion(-)
diff -
56784913"
"PMD64"="ALIVE,2,9220698256785902"
"PMD65"="ALIVE,3,9220698256786231"
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 1 +
lib/keepalive.c | 73 +++
lib/keepalive.h
quot;="ALIVE,1,9226460230168100"
"pmd64"="ALIVE,2,9226460230168905"
"pmd65"="ALIVE,3,9226460230169632"}
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 15 +++
lib/keepalive.h |
6 ALIVE 8632190191005713
pmd697 ALIVE 8632190191006555
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 78 +
1 file changed, 78 insertions(+)
diff --git a/lib/keepalive.c b/lib/keepalive.c
index db5a2dc
This commit adds support to query if keepalive status is
enabled/disabled.
$ ovs-appctl keepalive/status
keepAlive Status: Enabled
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/lib/keepalive.c b/lib
keepalive thread.
It should be noted that the PMD health checks are only performed on
the PMD threads whose health check is enabled.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 30 +
lib/keepalive.c | 81
This commit adds the initial support in to performing PMD health checks.
The ports handled by the PMD threads are checked for the link status and
the same is updated in to keepalive info structure.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 37
d-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 25 +++---
lib/keepalive.c | 97 +++
lib/keepalive.h | 5 +++
3 files changed, 122 insertions(+), 5 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index dc
This commit adds the support to check the PMD cycle stats. If the cycles
aren't changing for a duration of time this can be flagged as possible
PMD stall.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 16 +---
lib/dpif-netdev.h | 6 ++
lib/keepalive.c
d.
- Link status of the ports polled by PMD thread.
- Statistics of the ports polled by PMD thread.
- PMD polling and processing cycles.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 16 ++
lib/keepalive.h | 2
heartbeat failure, health checks are enabled
and additional stats(pkt stats, cpu cycles) are displayed as above.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 112
1 file changed, 112 insertions(+)
diff --git a/lib
d latency is (Min:134,710ns, Avg:173,005ns, Max:1,504,670ns)
for Phy2Phy loopback test case with 100 unique streams.
Signed-off-by: Bhanuprakash Bodireddy
---
Documentation/howto/dpdk.rst | 90
1 file changed, 90 insertions(+)
diff --git a/Documenta
According to coding style the line lengths should be <=79. Fix the
schema file and update the checksum and version number to reflect the
change.
Signed-off-by: Bhanuprakash Bodireddy
---
v1->v2
* Update version number from 7.15.0 -> 7.5.1. Also updated cksum accordingly.
-dev/2017-May/332419.html
Fixes: daf4d3c18da4("odp: Support conntrack orig tuple key.")
Signed-off-by: Daniele Di Proietto
Signed-off-by: Bhanuprakash Bodireddy
Co-authored-by: Bhanuprakash Bodireddy
---
v1->v2
* Fix comments(as suggested by Darrell).
lib/packets.h | 10
a commits to later commit where the actual
implementation is done(suggested by Ben).
* Fix ovs-appctl keepalive/* hang issue when KA disabled.
* Fixed memory leaks with appctl commands for keepalive/pmd-health-show,
pmd-xstats-show.
* Refactor code and fixed APIs dealing with PMD health mo
Introduce helper functions in 'dpdk' module that are needed for
DPDK keepalive functionality. Also add dummy functions in 'dpdk-stub' module
that are needed when DPDK datapath is not available.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpdk-stub.c | 24
This commit fixes the following "sparse" warning:
lib/process.c:439:16: error: use of assignment suppression and length
modifier together in gnu_scanf format [-Werror=format=].
This fix doesn't need any other changes as the fields aren't used for now.
Signed-off-by: Bh
Implement helper function to retrieve the process status. This commit
also enables the fields relating to process name, state and core the
process was last scheduled. The APIs will be used by keepalive monitoring
framework in future commits.
Signed-off-by: Bhanuprakash Bodireddy
---
lib
vs-vsctl --no-wait set Open_vSwitch . \
other_config:keepalive-interval="5000"
Signed-off-by: Bhanuprakash Bodireddy
---
lib/automake.mk| 2 +
lib/dpdk-stub.c| 6 ++
lib/dpdk.c | 30 +++--
lib/dpdk.h
This commit adds an API to store the PMD thread ids in to KA info struct.
The thread ids shall be used to check false positives and for status and
statistics reporting.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 3 +++
lib/keepalive.c | 13 +
lib/keepalive.h
This commit introduces helper functions in 'keepalive' module that are
needed to register/unregister PMD threads to KA framework. Also
introduce APIs to mark the PMD core states.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepal
56784913"
"pmd64"="ALIVE,2,9220698256785902"
"pmd65"="ALIVE,3,9220698256786231"
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 1 +
lib/keepalive.c | 73 +++
lib/keepalive.h
ad polling the port.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpdk-stub.c | 6 ++
lib/dpdk.c| 7 +++
lib/dpdk.h| 2 ++
lib/dpif-netdev.c | 9 -
lib/keepalive.c | 9 +
lib/keepalive.h | 1 +
6 files changed, 33 insertions(+), 1 deletion(-)
diff -
This commit adds support to query if keepalive status is
enabled/disabled.
$ ovs-appctl keepalive/status
keepAlive Status: Enabled
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/lib/keepalive.c b/lib
keepalive thread.
It should be noted that the PMD health checks are only performed on
the PMD threads whose health check is enabled.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 30 +
lib/keepalive.c | 81
marking themselves
alive. As long as PMD responds to heartbeats it is considered 'healthy'.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 100 +++
lib/keepalive.c | 138 +++---
lib/keepalive
This commit adds the initial support in to performing PMD health checks.
The ports handled by the PMD threads are checked for the link status and
the same is updated in to keepalive info structure.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 37
6 ALIVE 8632190191005713
pmd697 ALIVE 8632190191006555
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 78 +
1 file changed, 78 insertions(+)
diff --git a/lib/keepalive.c b/lib/keepalive.c
index db5a2dc
quot;="ALIVE,1,9226460230168100"
"pmd64"="ALIVE,2,9226460230168905"
"pmd65"="ALIVE,3,9226460230169632"}
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 15 +++
lib/keepalive.h |
d-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 25 +++---
lib/keepalive.c | 97 +++
lib/keepalive.h | 5 +++
3 files changed, 122 insertions(+), 5 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index eb
d.
- Link status of the ports polled by PMD thread.
- Statistics of the ports polled by PMD thread.
- PMD polling and processing cycles.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 16 ++
lib/keepalive.h | 2
heartbeat failure, health checks are enabled
and additional stats(pkt stats, cpu cycles) are displayed as above.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/keepalive.c | 112
1 file changed, 112 insertions(+)
diff --git a/lib
This commit adds the support to check the PMD cycle stats. If the cycles
aren't changing for a duration of time this can be flagged as possible
PMD stall.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netdev.c | 17 +
lib/dpif-netdev.h | 7 +++
lib/keepalive.c
d latency is (Min:134,710ns, Avg:173,005ns, Max:1,504,670ns)
for Phy2Phy loopback test case with 100 unique streams.
Signed-off-by: Bhanuprakash Bodireddy
---
Documentation/howto/dpdk.rst | 90
1 file changed, 90 insertions(+)
diff --git a/Documenta
201 - 300 of 303 matches
Mail list logo
