On 9/8/2021 9:57 PM, Eelco Chaudron wrote:
On 8 Sep 2021, at 13:52, Chris Mi wrote:
On 9/6/2021 5:47 PM, Eelco Chaudron wrote:
On 6 Sep 2021, at 11:14, Chris Mi wrote:
On 9/3/2021 8:54 PM, Eelco Chaudron wrote:
On 3 Sep 2021, at 14:02, Eelco Chaudron wrote:
On 15 Jul 2021, at 8:01,
On 9/3/2021 8:54 PM, Eelco Chaudron wrote:
On 3 Sep 2021, at 14:02, Eelco Chaudron wrote:
On 15 Jul 2021, at 8:01, Chris Mi wrote:
This patch set adds offload support for sFlow.
Psample is a genetlink channel for packet sampling. TC action
act_sample
uses
Hi Eelco,
On 9/3/2021 8:02 PM, Eelco Chaudron wrote:
On 15 Jul 2021, at 8:01, Chris Mi wrote:
This patch set adds offload support for sFlow.
Psample is a genetlink channel for packet sampling. TC action
act_sample
uses psample to send sampled packets to userspace.
When
On 9/9/2021 10:29 PM, Eelco Chaudron wrote:
On 15 Jul 2021, at 8:01, Chris Mi wrote:
Create a unique group ID to map the sFlow info when offloading sFlow
action to TC. When showing the offloaded datapath flows, translate
the
group ID from TC sample action to sFlow info using
On 9/13/2021 5:18 PM, Eelco Chaudron wrote:
On 10 Sep 2021, at 13:02, Chris Mi wrote:
On 9/9/2021 10:29 PM, Eelco Chaudron wrote:
On 15 Jul 2021, at 8:01, Chris Mi wrote:
Create a unique group ID to map the sFlow info when offloading sFlow
action to TC. When showing the offloaded
Update kernel UAPI to support psample and the tc sample action.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
include/linux/automake.mk| 4 ++-
include/linux/psample.h | 62
include/linux/tc_act/tc_sample.h |
Process sFlow offload packet in handler thread if handler id is 0.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
ofproto/ofproto-dpif-upcall.c | 63 +++
1 file changed, 63 insertions(+)
diff --git a/ofproto/ofproto-dpif-upcall.c
Create a unique group ID to map the sFlow info when offloading sFlow
action to TC. When showing the offloaded datapath flows, translate the
group ID from TC sample action to sFlow info using the mapping.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
NEWS| 1 +
When offloading sample action to TC, userspace creates a unique ID
to map sFlow action and tunnel info and passes this ID to kernel instead
of the sFlow info. psample will send this ID and sampled packet to
userspace. Using the ID, userspace can recover the sFlow info and send
sampled packet to
Load kernel module psample to receive sampled packets from TC.
Before removing kernel module psample, remove act_sample first.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
utilities/ovs-kmod-ctl.in | 14 ++
1 file changed, 14 insertions(+)
diff
Some offload actions require functionality that is not netdev
based, but dpif. For example, sFlow action requires to create
a psample netlink socket to receive the sampled packets from
TC or kernel driver.
Create dpif-offload-provider layer to support such actions.
Signed-off-by: Chris Mi
Implement dpif-offload API for netlink datapath.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
lib/automake.mk | 1 +
lib/dpif-netlink.c | 2 +-
lib/dpif-offload-netlink.c | 208
lib/dpif-offload-provider.h | 13 ++-
4
This patch set adds offload support for sFlow.
Psample is a genetlink channel for packet sampling. TC action act_sample
uses psample to send sampled packets to userspace.
When offloading sample action to TC, userspace creates a unique ID to
map sFlow action and tunnel info and passes this ID to
Add two sFlow offload test caes:
3: sflow offloads with sampling=1 - ping between two ports - offloads enabled
ok
4: sflow offloads with sampling=2 - ping between two ports - offloads enabled
ok
Signed-off-by: Chris Mi
---
tests/system-offloads-traffic.at | 84
On 9/6/2021 5:47 PM, Eelco Chaudron wrote:
On 6 Sep 2021, at 11:14, Chris Mi wrote:
On 9/3/2021 8:54 PM, Eelco Chaudron wrote:
On 3 Sep 2021, at 14:02, Eelco Chaudron wrote:
On 15 Jul 2021, at 8:01, Chris Mi wrote:
This patch set adds offload support for sFlow.
On 9/7/2021 1:59 PM, Eelco Chaudron wrote:
On 7 Sep 2021, at 3:34, Chris Mi wrote:
On 9/6/2021 5:47 PM, Eelco Chaudron wrote:
On 6 Sep 2021, at 11:14, Chris Mi wrote:
On 9/3/2021 8:54 PM, Eelco Chaudron wrote:
On 3 Sep 2021, at 14:02, Eelco Chaudron wrote:
On 15 Jul 2021, at 8:01,
On 9/6/2021 5:47 PM, Eelco Chaudron wrote:
On 6 Sep 2021, at 11:14, Chris Mi wrote:
On 9/3/2021 8:54 PM, Eelco Chaudron wrote:
On 3 Sep 2021, at 14:02, Eelco Chaudron wrote:
On 15 Jul 2021, at 8:01, Chris Mi wrote:
This patch set adds offload support for sFlow.
On 9/6/2021 6:56 PM, Eelco Chaudron wrote:
On 15 Jul 2021, at 8:01, Chris Mi wrote:
Some offload actions require functionality that is not netdev
based, but dpif. For example, sFlow action requires to create
a psample netlink socket to receive the sampled packets from
TC or kernel driver.
On 9/6/2021 7:41 PM, Eelco Chaudron wrote:
On 15 Jul 2021, at 8:01, Chris Mi wrote:
When offloading sample action to TC, userspace creates a unique ID
to map sFlow action and tunnel info and passes this ID to kernel instead
of the sFlow info. psample will send this ID and sampled packet to
On 9/6/2021 9:20 PM, Eelco Chaudron wrote:
On 15 Jul 2021, at 8:01, Chris Mi wrote:
Implement dpif-offload API for netlink datapath.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
lib/automake.mk | 1 +
lib/dpif-netlink.c | 2 +-
On 9/7/2021 4:01 PM, Eelco Chaudron wrote:
On 15 Jul 2021, at 8:01, Chris Mi wrote:
Process sFlow offload packet in handler thread if handler id is 0.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Thanks for making these changes, as this implementation looks way
cleaner
On 9/9/2021 8:44 PM, Eelco Chaudron wrote:
Two more comments to this patch…
On 7 Sep 2021, at 10:01, Eelco Chaudron wrote:
On 15 Jul 2021, at 8:01, Chris Mi wrote:
Process sFlow offload packet in handler thread if handler id is 0.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
On 9/9/2021 10:29 PM, Eelco Chaudron wrote:
On 15 Jul 2021, at 8:01, Chris Mi wrote:
Create a unique group ID to map the sFlow info when offloading sFlow
action to TC. When showing the offloaded datapath flows, translate
the
group ID from TC sample action to sFlow info using
On 9/3/2021 5:15 PM, Eelco Chaudron wrote:
On 15 Jul 2021, at 8:01, Chris Mi wrote:
Update kernel UAPI to support psample and the tc sample action.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
Hi Chris,
I plan to review and test this patchset over the
Implement dpif-offload API for netlink datapath.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
lib/automake.mk | 1 +
lib/dpif-netlink.c | 2 +-
lib/dpif-offload-netlink.c | 210
lib/dpif-offload-provider.h | 12 +++
4
Process sFlow offload packet in handler thread if handler id is 0.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
ofproto/ofproto-dpif-upcall.c | 57 +++
1 file changed, 57 insertions(+)
diff --git a/ofproto/ofproto-dpif-upcall.c
This patch set adds offload support for sFlow.
Psample is a genetlink channel for packet sampling. TC action act_sample
uses psample to send sampled packets to userspace.
When offloading sample action to TC, userspace creates a unique ID to
map sFlow action and tunnel info and passes this ID to
Update kernel UAPI to support psample and the tc sample action.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
include/linux/automake.mk| 4 ++-
include/linux/psample.h | 62
include/linux/tc_act/tc_sample.h |
When offloading sample action to TC, userspace creates a unique ID
to map sFlow action and tunnel info and passes this ID to kernel instead
of the sFlow info. psample will send this ID and sampled packet to
userspace. Using the ID, userspace can recover the sFlow info and send
sampled packet to
Load kernel module psample to receive sampled packets from TC.
Before removing kernel module psample, remove act_sample first.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
utilities/ovs-kmod-ctl.in | 14 ++
1 file changed, 14 insertions(+)
diff
When offloading sample action to TC, userspace creates a unique ID
to map sFlow action and tunnel info and passes this ID to kernel instead
of the sFlow info. psample will send this ID and sampled packet to
userspace. Using the ID, userspace can recover the sFlow info and send
sampled packet to
Process sFlow offload packet in handler thread if handler id is 0.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
ofproto/ofproto-dpif-upcall.c | 57 +++
1 file changed, 57 insertions(+)
diff --git a/ofproto/ofproto-dpif-upcall.c
Some offload actions require functionality that is not netdev
based, but dpif. For example, sFlow action requires to create
a psample netlink socket to receive the sampled packets from
TC or kernel driver.
Create dpif-offload-provider layer to support such actions.
Signed-off-by: Chris Mi
Create a unique group ID to map the sFlow info when offloading sFlow
action to TC. When showing the offloaded datapath flows, translate the
group ID from TC sample action to sFlow info using the mapping.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
NEWS| 1 +
Load kernel module psample to receive sampled packets from TC.
Before removing kernel module psample, remove act_sample first.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
utilities/ovs-kmod-ctl.in | 14 ++
1 file changed, 14 insertions(+)
diff
Update kernel UAPI to support psample and the tc sample action.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
include/linux/automake.mk| 4 ++-
include/linux/psample.h | 62
include/linux/tc_act/tc_sample.h |
This patch set adds offload support for sFlow.
Psample is a genetlink channel for packet sampling. TC action act_sample
uses psample to send sampled packets to userspace.
When offloading sample action to TC, userspace creates a unique ID to
map sFlow action and tunnel info and passes this ID to
Implement dpif-offload API for netlink datapath.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
lib/automake.mk | 1 +
lib/dpif-netlink.c | 2 +-
lib/dpif-offload-netlink.c | 210
lib/dpif-offload-provider.h | 12 +++
4
Some offload actions require functionality that is not netdev
based, but dpif. For example, sFlow action requires to create
a psample netlink socket to receive the sampled packets from
TC or kernel driver.
Create dpif-offload-provider layer to support such actions.
Signed-off-by: Chris Mi
Create a unique group ID to map the sFlow info when offloading sFlow
action to TC. When showing the offloaded datapath flows, translate the
group ID from TC sample action to sFlow info using the mapping.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
NEWS| 1 +
On 10/1/2021 5:43 PM, Eelco Chaudron wrote:
On 1 Oct 2021, at 11:35, Eelco Chaudron wrote:
Hi Chris,
I just started to review this patchset, but as some of the v14 discussions have
not finished, I’ll copy them over to v15. This way, all the open items are
contained in a single
On 10/1/2021 5:52 PM, Eelco Chaudron wrote:
See some small comments inline.
On 15 Sep 2021, at 14:43, Chris Mi wrote:
Some offload actions require functionality that is not netdev
based, but dpif. For example, sFlow action requires to create
a psample netlink socket to receive the sampled
Hi Eelco,
Sorry for the late reply due to the long National Day holiday in China.
On 10/1/2021 10:34 PM, Eelco Chaudron wrote:
Thanks for working on the test cases. I have two small requests below to make
the tests also verify the datapath actions.
And as you already discussed with Simon
On 10/8/2021 2:47 PM, Eelco Chaudron wrote:
Hi Chris,
I hope you enjoyed the holiday. And don't worry about the delay, as I try to
only spend time reviewing stuff on Fridays.
Thanks for fixing the comments, and I will re-review once it's integrated into
the sflow patchset.
Sure.
Thanks,
On 10/1/2021 6:20 PM, Eelco Chaudron wrote:
One nit, rest looks good. Thanks for removing the expired list handling, as it
looks way cleaner now!
//Eelco
On 15 Sep 2021, at 14:43, Chris Mi wrote:
When offloading sample action to TC, userspace creates a unique ID
to map sFlow action and
On 10/12/2021 2:53 PM, Eelco Chaudron wrote:
On 9 Oct 2021, at 10:16, Chris Mi wrote:
On 10/1/2021 5:43 PM, Eelco Chaudron wrote:
On 1 Oct 2021, at 11:35, Eelco Chaudron wrote:
Hi Chris,
I just started to review this patchset, but as some of the v14 discussions have
not finished, I’ll
Create a unique group ID to map the sFlow info when offloading sFlow
action to TC. When showing the offloaded datapath flows, translate the
group ID from TC sample action to sFlow info using the mapping.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
NEWS| 1 +
Some offload actions require functionality that is not netdev
based, but dpif. For example, sFlow action requires to create
a psample netlink socket to receive the sampled packets from
TC or kernel driver.
Create dpif-offload-provider layer to support such actions.
Signed-off-by: Chris Mi
Implement dpif-offload API for netlink datapath.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
lib/automake.mk | 1 +
lib/dpif-netlink.c | 2 +-
lib/dpif-offload-netlink.c | 209
lib/dpif-offload-provider.h | 13 ++-
4
Load kernel module psample to receive sampled packets from TC.
Before removing kernel module psample, remove act_sample first.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
utilities/ovs-kmod-ctl.in | 14 ++
1 file changed, 14 insertions(+)
diff
When offloading sample action to TC, userspace creates a unique ID
to map sFlow action and tunnel info and passes this ID to kernel instead
of the sFlow info. psample will send this ID and sampled packet to
userspace. Using the ID, userspace can recover the sFlow info and send
sampled packet to
Process sFlow offload packet in handler thread if handler id is 0.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
ofproto/ofproto-dpif-upcall.c | 73 +++
1 file changed, 73 insertions(+)
diff --git a/ofproto/ofproto-dpif-upcall.c
This patch set adds offload support for sFlow.
Psample is a genetlink channel for packet sampling. TC action act_sample
uses psample to send sampled packets to userspace.
When offloading sample action to TC, userspace creates a unique ID to
map sFlow action and tunnel info and passes this ID to
Update kernel UAPI to support psample and the tc sample action.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
include/linux/automake.mk| 4 ++-
include/linux/psample.h | 62
include/linux/tc_act/tc_sample.h |
Add two sFlow offload test caes:
3: sflow offloads with sampling=1 - ping between two ports - offloads enabled
ok
4: sflow offloads with sampling=2 - ping between two ports - offloads enabled
ok
Signed-off-by: Chris Mi
---
tests/system-offloads-traffic.at | 101
On 10/1/2021 7:57 PM, Eelco Chaudron wrote:
Some comments on user-facing log messages, the rest look ok.
//Eelco
On 15 Sep 2021, at 14:43, Chris Mi wrote:
Implement dpif-offload API for netlink datapath.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
lib/automake.mk
On 10/1/2021 8:24 PM, Eelco Chaudron wrote:
See comments below.
On 15 Sep 2021, at 14:43, Chris Mi wrote:
Process sFlow offload packet in handler thread if handler id is 0.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
ofproto/ofproto-dpif-upcall.c | 63
On 10/1/2021 9:55 PM, Eelco Chaudron wrote:
One small nit below.
On 15 Sep 2021, at 14:43, Chris Mi wrote:
Create a unique group ID to map the sFlow info when offloading sFlow
action to TC. When showing the offloaded datapath flows, translate the
group ID from TC sample action to sFlow info
On 10/8/2021 4:34 PM, Eelco Chaudron wrote:
On 8 Oct 2021, at 10:06, Chris Mi wrote:
On 10/1/2021 5:52 PM, Eelco Chaudron wrote:
See some small comments inline.
On 15 Sep 2021, at 14:43, Chris Mi wrote:
--- /dev/null
+++ b/lib/dpif-offload-provider.h
@@ -0,0 +1,47 @@
+/*
+ * Copyright
On 10/21/2021 4:27 PM, Eelco Chaudron wrote:
On 21 Oct 2021, at 10:00, Chris Mi wrote:
On 10/15/2021 9:42 PM, Eelco Chaudron wrote:
Small comments inline, and Ilya please take a look at the first comment/request.
//Eelco
On 12 Oct 2021, at 10:19, Chris Mi wrote:
Some offload actions
Create a unique group ID to map the sFlow info when offloading sFlow
action to TC. When showing the offloaded datapath flows, translate the
group ID from TC sample action to sFlow info using the mapping.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
NEWS| 1 +
Add two sFlow offload test caes:
3: sflow offloads with sampling=1 - ping between two ports - offloads enabled
ok
4: sflow offloads with sampling=2 - ping between two ports - offloads enabled
ok
Signed-off-by: Chris Mi
Acked-by: Eelco Chaudron
---
tests/system-offloads-traffic.at | 101
Update kernel UAPI to support psample and the tc sample action.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
include/linux/automake.mk| 4 ++-
include/linux/psample.h | 62
include/linux/tc_act/tc_sample.h |
When offloading sample action to TC, userspace creates a unique ID
to map sFlow action and tunnel info and passes this ID to kernel instead
of the sFlow info. psample will send this ID and sampled packet to
userspace. Using the ID, userspace can recover the sFlow info and send
sampled packet to
Some offload actions require functionality that is not netdev
based, but dpif. For example, sFlow action requires to create
a psample netlink socket to receive the sampled packets from
TC or kernel driver.
Create dpif-offload-provider layer to support such actions.
Signed-off-by: Chris Mi
On 10/15/2021 9:42 PM, Eelco Chaudron wrote:
Small comments inline, and Ilya please take a look at the first comment/request.
//Eelco
On 12 Oct 2021, at 10:19, Chris Mi wrote:
Some offload actions require functionality that is not netdev
based, but dpif. For example, sFlow action requires
Load kernel module psample to receive sampled packets from TC.
Before removing kernel module psample, remove act_sample first.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
utilities/ovs-kmod-ctl.in | 14 ++
1 file changed, 14 insertions(+)
diff
Process sFlow offload packet in handler thread if handler id is 0.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
ofproto/ofproto-dpif-upcall.c | 73 +++
1 file changed, 73 insertions(+)
diff --git
On 10/15/2021 8:57 PM, Eelco Chaudron wrote:
See some small comments below...
On 12 Oct 2021, at 10:19, Chris Mi wrote:
Create a unique group ID to map the sFlow info when offloading sFlow
action to TC. When showing the offloaded datapath flows, translate the
group ID from TC sample action to
This patch set adds offload support for sFlow.
Psample is a genetlink channel for packet sampling. TC action act_sample
uses psample to send sampled packets to userspace.
When offloading sample action to TC, userspace creates a unique ID to
map sFlow action and tunnel info and passes this ID to
Implement dpif-offload API for netlink datapath.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
lib/automake.mk | 1 +
lib/dpif-netdev.c | 3 +-
lib/dpif-netlink.c | 11 +-
lib/dpif-offload-netlink.c | 207
On 10/18/2021 11:14 PM, Eelco Chaudron wrote:
On 18 Oct 2021, at 14:03, Chris Mi wrote:
Hi Eelco,
On 10/15/2021 9:42 PM, Eelco Chaudron wrote:
Small comments inline, and Ilya please take a look at the first comment/request.
//Eelco
On 12 Oct 2021, at 10:19, Chris Mi wrote:
Some offload
On 10/8/2021 4:34 PM, Eelco Chaudron wrote:
On 8 Oct 2021, at 10:06, Chris Mi wrote:
On 10/1/2021 5:52 PM, Eelco Chaudron wrote:
See some small comments inline.
On 15 Sep 2021, at 14:43, Chris Mi wrote:
--- /dev/null
+++ b/lib/dpif-offload-provider.h
@@ -0,0 +1,47 @@
+/*
+ * Copyright
Hi Eelco,
On 10/15/2021 9:42 PM, Eelco Chaudron wrote:
Small comments inline, and Ilya please take a look at the first comment/request.
//Eelco
On 12 Oct 2021, at 10:19, Chris Mi wrote:
Some offload actions require functionality that is not netdev
based, but dpif. For example, sFlow action
Hi Simon,
On 9/24/2021 3:03 PM, Simon Horman wrote:
On Thu, Sep 16, 2021 at 11:38:52AM +0300, Chris Mi wrote:
Add two sFlow offload test caes:
3: sflow offloads with sampling=1 - ping between two ports - offloads
enabled ok
4: sflow offloads with sampling=2 - ping between two ports -
Hi Eelco,
That's ok. Please review it according to your plan.
Thanks,
Chris
On 9/21/2021 4:12 PM, Eelco Chaudron wrote:
Hi Chris,
Just a quick update, I did see your responses to v14 and I also noticed you
send out a v15. I planned to review it this week, but due to some other
unforeseen
Hi Simon,
On 9/24/2021 3:03 PM, Simon Horman wrote:
On Thu, Sep 16, 2021 at 11:38:52AM +0300, Chris Mi wrote:
Add two sFlow offload test caes:
3: sflow offloads with sampling=1 - ping between two ports - offloads
enabled ok
4: sflow offloads with sampling=2 - ping between two ports -
Load kernel module psample to receive sampled packets from TC.
Before removing kernel module psample, remove act_sample first.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
utilities/ovs-kmod-ctl.in | 14 ++
1 file changed, 14 insertions(+)
diff
Update kernel UAPI to support psample and the tc sample action.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
include/linux/automake.mk| 4 ++-
include/linux/psample.h | 62
include/linux/tc_act/tc_sample.h |
Some offload actions require functionality that is not netdev
based, but dpif. For example, sFlow action requires to create
a psample netlink socket to receive the sampled packets from
TC or kernel driver.
Create dpif-offload-provider layer to support such actions.
Signed-off-by: Chris Mi
This patch set adds offload support for sFlow.
Psample is a genetlink channel for packet sampling. TC action act_sample
uses psample to send sampled packets to userspace.
When offloading sample action to TC, userspace creates a unique ID to
map sFlow action and tunnel info and passes this ID to
Implement dpif-offload API for netlink datapath. And implement a
dummy dpif-offload API for netdev datapath to make tests pass.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
lib/automake.mk | 2 +
lib/dpif-netdev.c | 8 +-
lib/dpif-netlink.c | 4 +-
Add two sFlow offload test caes:
3: sflow offloads with sampling=1 - ping between two ports - offloads enabled
ok
4: sflow offloads with sampling=2 - ping between two ports - offloads enabled
ok
Signed-off-by: Chris Mi
Acked-by: Eelco Chaudron
---
tests/system-offloads-traffic.at | 101
When offloading sample action to TC, userspace creates a unique ID
to map sFlow action and tunnel info and passes this ID to kernel instead
of the sFlow info. psample will send this ID and sampled packet to
userspace. Using the ID, userspace can recover the sFlow info and send
sampled packet to
Create a unique group ID to map the sFlow info when offloading sFlow
action to TC. When showing the offloaded datapath flows, translate the
group ID from TC sample action to sFlow info using the mapping.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
NEWS
Process sFlow offload packet in handler thread if handler id is 0.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
ofproto/ofproto-dpif-upcall.c | 73 +++
1 file changed, 73 insertions(+)
diff --git
Hi Eelco,
Version 19 mainly fixes a bug that psample_sock is destroyed when last
bridge is deleted.
And it also addresses some of the minor comments in v18. I think there
is no use
to address all of them because if we need to change the dpif-offload
design, maybe
some of them will be
On 11/25/2021 4:52 PM, Eelco Chaudron wrote:
On 15 Nov 2021, at 3:53, Chris Mi wrote:
Some offload actions require functionality that is not netdev
based, but dpif. For example, sFlow action requires to create
a psample netlink socket to receive the sampled packets from
TC or kernel driver.
On 11/25/2021 7:27 PM, Eelco Chaudron wrote:
On 15 Nov 2021, at 3:53, Chris Mi wrote:
Create a unique group ID to map the sFlow info when offloading sFlow
action to TC. When showing the offloaded datapath flows, translate the
group ID from TC sample action to sFlow info using the mapping.
Create a unique group ID to map the sFlow info when offloading sFlow
action to TC. When showing the offloaded datapath flows, translate the
group ID from TC sample action to sFlow info using the mapping.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
NEWS
When offloading sample action to TC, userspace creates a unique ID
to map sFlow action and tunnel info and passes this ID to kernel instead
of the sFlow info. psample will send this ID and sampled packet to
userspace. Using the ID, userspace can recover the sFlow info and send
sampled packet to
Some offload actions require functionality that is not netdev
based, but dpif. For example, sFlow action requires to create
a psample netlink socket to receive the sampled packets from
TC or kernel driver.
Create dpif-offload-provider layer to support such actions.
Signed-off-by: Chris Mi
Update kernel UAPI to support psample and the tc sample action.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
include/linux/automake.mk| 4 ++-
include/linux/psample.h | 62
include/linux/tc_act/tc_sample.h |
This patch set adds offload support for sFlow.
Psample is a genetlink channel for packet sampling. TC action act_sample
uses psample to send sampled packets to userspace.
When offloading sample action to TC, userspace creates a unique ID to
map sFlow action and tunnel info and passes this ID to
Load kernel module psample to receive sampled packets from TC.
Before removing kernel module psample, remove act_sample first.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
utilities/ovs-kmod-ctl.in | 14 ++
1 file changed, 14 insertions(+)
diff
On 11/5/2021 9:24 PM, Eelco Chaudron wrote:
On 21 Oct 2021, at 10:01, Chris Mi wrote:
Implement dpif-offload API for netlink datapath.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
Chris, if you make changes to this patch after I have ACKed it, you need to
Implement dpif-offload API for netlink datapath. And implement a
dummy dpif-offload API for netdev datapath to make tests pass.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
lib/automake.mk | 2 +
lib/dpif-netdev.c | 8 +-
lib/dpif-netlink.c | 4 +-
Process sFlow offload packet in handler thread if handler id is 0.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
ofproto/ofproto-dpif-upcall.c | 73 +++
1 file changed, 73 insertions(+)
diff --git
Add two sFlow offload test caes:
3: sflow offloads with sampling=1 - ping between two ports - offloads enabled
ok
4: sflow offloads with sampling=2 - ping between two ports - offloads enabled
ok
Signed-off-by: Chris Mi
Acked-by: Eelco Chaudron
---
tests/system-offloads-traffic.at | 101
On 11/5/2021 8:18 PM, Eelco Chaudron wrote:
On 21 Oct 2021, at 10:00, Chris Mi wrote:
Some offload actions require functionality that is not netdev
based, but dpif. For example, sFlow action requires to create
a psample netlink socket to receive the sampled packets from
TC or kernel driver.
1 - 100 of 266 matches
Mail list logo
