[ovs-dev] [patch v5 07/11] ipf: Add set maximum fragments supported command.

A new command "ovs-appctl dpctl/ipf-set-maxfrags" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpct

[ovs-dev] [patch v5 11/11] tests: Enable fragmentation for userspace datapath.

Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-kmod-macros.at | 30 -- tests/system-traffic.at | 43 ++ tests/system-userspace-macros.at | 125 --- 3 files changed, 173 insertions(+), 25 deletions(-)

[ovs-dev] [patch v5 10/11] tests: Add missed local stack checks.

Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-traffic.at | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index dbd5640..5b59392 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -2093,6 +

[ovs-dev] [patch v5 09/11] ipf: Enhance ipf_get_status.

A verbose option is added to dump the frag lists. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/ct-dpif.c | 24 + lib/ct-dpif.h | 4 +++ lib/dpctl.c | 37 -- lib/dpctl.man | 5 ++-- lib/dpif-netdev.c

[ovs-dev] [patch v5 08/11] ipf: Add command to get fragmentation handling status.

A new command "ovs-appctl dpctl/ipf-get-status" is added for userspace datapath conntrack fragmentation support. The command shows the configuration status as well as fragment counters. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-d

[ovs-dev] [patch v5 06/11] ipf: Add set minimum fragment size command.

A new command "ovs-appctl dpctl/ipf-set-minfrag" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpct

[ovs-dev] [patch v5 05/11] ipf: Add command to enable fragmentation handling.

A new command "ovs-appctl dpctl/ipf-set-enabled" is added to enable/disable userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpct

[ovs-dev] [patch v5 03/11] Userspace datapath: Add fragmentation handling.

Fragmentation handling is added for supporting conntrack. Fragmentation handling is disabled by default and enabled via a user commands implemented in a subsequent patch. Both v4 and v6 are supported. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- include/sparse/netinet/ip6.h |1

[ovs-dev] [patch v5 04/11] conntrack: Support fragmentation.

The conntrack module now calls fragmentation support apis. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/conntrack.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/NEWS b/NEWS index 8c360ba..ee1f272 100644 --- a/NEWS +++ b/NEWS @@ -11,6 +11,8 @

[ovs-dev] [patch v5 02/11] flow: Enhance parse_ipv6_ext_hdrs.

Enhance the api parse_ipv6_ext_hdrs to return the fragmentation header to be used in later patches. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack.c | 5 +++-- lib/flow.c | 23 ++- lib/flow.h | 3 ++- 3 files changed, 19 insertions(

[ovs-dev] [patch v5 01/11] dp-packet: Add const qualifiers for checksum apis.

Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/dp-packet.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index b4b721c..61d4cd4 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -637,7 +637,7 @@ dp_packet_mbuf_init(

[ovs-dev] [patch v5 00/11] Userspace datapath: Add fragmentation support.

was more loose than intended. Add another sanity check for fragment ip_tot_len; even though it be redundant, add for completeness. v1->v2: Few fixes, improvements and cleanups. Darrell Ball (11): dp-packet: Add const qualifiers for checksum apis. flow: Enhance p

Re: [ovs-dev] [PATCH] learn: improve test case

On Wed, Jan 31, 2018 at 6:32 PM, William Tu wrote: > Current learn test cases use only ovs-ofctl add/del flows. > The patch add a new test case for learn with delete_learned and > limit option enabled. > > Signed-off-by: William Tu > --- > tests/learn.at

Re: [ovs-dev] [patch v4 03/10] Userspace datapath: Add fragmentation handling.

_list->last_inuse_idx) { I'll send a new version later, after some soak time. Thanks Darrell On Tue, Jan 30, 2018 at 12:58 AM, Darrell Ball <dlu...@gmail.com> wrote: > Fragmentation handling is added for supporting conntrack. > Fragmentation handling is disabled by de

[ovs-dev] [patch v4 10/10] tests: Enable fragmentation for userspace datapath.

Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-kmod-macros.at | 14 +++- tests/system-traffic.at | 34 tests/system-userspace-macros.at | 49 3 files changed, 72 insertions(

[ovs-dev] [patch v4 09/10] tests: Add missed local stack checks.

Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-traffic.at | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index dbd5640..5b59392 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -2093,6 +

[ovs-dev] [patch v4 06/10] ipf: Add set minimum fragment size command.

A new command "ovs-appctl dpctl/ipf-set-minfrag" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpct

[ovs-dev] [patch v4 05/10] ipf: Add command to enable fragmentation handling.

A new command "ovs-appctl dpctl/ipf-set-enabled" is added to enable/disable userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpct

[ovs-dev] [patch v4 03/10] Userspace datapath: Add fragmentation handling.

Fragmentation handling is added for supporting conntrack. Fragmentation handling is disabled by default and enabled via a user commands implemented in a subsequent patch. Both v4 and v6 are supported. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- include/sparse/netinet/ip6.h |1

[ovs-dev] [patch v4 04/10] conntrack: Support fragmentation.

The conntrack module now calls fragmentation support apis. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/conntrack.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/NEWS b/NEWS index 726589c..dccff06 100644 --- a/NEWS +++ b/NEWS @@ -3,6 +3,8 @

[ovs-dev] [patch v4 02/10] flow: Enhance parse_ipv6_ext_hdrs.

Enhance the api parse_ipv6_ext_hdrs to return the fragmentation header to be used in later patches. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack.c | 5 +++-- lib/flow.c | 23 ++- lib/flow.h | 3 ++- 3 files changed, 19 insertions(

[ovs-dev] [patch v4 01/10] dp-packet: Add const qualifiers for checksum apis.

Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/dp-packet.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index b4b721c..61d4cd4 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -637,7 +637,7 @@ dp_packet_mbuf_init(

[ovs-dev] [patch v4 00/10] Userspace datapath: Add fragmentation support.

dd for completeness. v1->v2: Few fixes, improvements and cleanups. Darrell Ball (10): dp-packet: Add const qualifiers for checksum apis. flow: Enhance parse_ipv6_ext_hdrs. Userspace datapath: Add fragmentation handling. conntrack: Support fragmentation. ipf: Add command to enable fragmentation

Re: [ovs-dev] [patch v3 2/9] Userspace datapath: Add v4 fragmentation handling.

On 1/25/18, 6:07 PM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell Ball" <ovs-dev-boun...@openvswitch.org on behalf of dlu...@gmail.com> wrote: Fragmentation handling is added for supporting conntrack. Presently, only v4 is supported, with v6 coming soon.

[ovs-dev] [patch v3 8/9] tests: Add missed local stack check.

Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-traffic.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index dbd5640..aee7391 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -2093,6 +2093,7 @@ AT

[ovs-dev] [patch v3 7/9] ipf: Add command to get fragmentation handling status.

A new command "ovs-appctl dpctl/ipf-get-status" is added for userspace datapath conntrack fragmentation support. The command shows the configuration status as well as fragment counters. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-d

[ovs-dev] [patch v3 6/9] ipf: Add set maximum fragments supported command.

A new command "ovs-appctl dpctl/ipf-set-maxfrags" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpct

[ovs-dev] [patch v3 5/9] ipf: Add set minimum fragment size command.

A new command "ovs-appctl dpctl/ipf-set-minfragment" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpct

[ovs-dev] [patch v3 2/9] Userspace datapath: Add v4 fragmentation handling.

Fragmentation handling is added for supporting conntrack. Presently, only v4 is supported, with v6 coming soon. Fragmentation handling is disabled by default and enabled via a user command implemented in a subsequent patch. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/automake.mk

[ovs-dev] [patch v3 4/9] ipf: Add command to enable fragmentation handling.

A new command "ovs-appctl dpctl/ipf-set-enabled" is added to enable/disable userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpct

[ovs-dev] [patch v3 3/9] conntrack: Support v4 fragmentation.

The conntrack module now calls fragmentation support apis. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 3 ++- lib/conntrack.c | 6 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index d7d585b..137c511 100644 --- a/NEWS +++ b/NEWS @

[ovs-dev] [patch v3 1/9] dp-packet: Add const qualifiers for checksum apis.

Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/dp-packet.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index b4b721c..61d4cd4 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -637,7 +637,7 @@ dp_packet_mbuf_init(

[ovs-dev] [patch v3 0/9] Userspace datapath: Add fragmentation support.

gt;v2: Few fixes, improvements and cleanups. Darrell Ball (9): dp-packet: Add const qualifiers for checksum apis. Userspace datapath: Add v4 fragmentation handling. conntrack: Support v4 fragmentation. ipf: Add command to enable fragmentation handling. ipf: Add set minimum fragment size com

[ovs-dev] [patch v2 9/9] tests: Enable v4 fragmentation for userspace datapath.

Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-kmod-macros.at | 14 +++--- tests/system-traffic.at | 27 +-- tests/system-userspace-macros.at | 36 3 files changed, 60 insertions(+), 17 del

[ovs-dev] [patch v2 8/9] tests: Add missed local stack check.

Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-traffic.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index dbd5640..aee7391 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -2093,6 +2093,7 @@ AT

[ovs-dev] [patch v2 6/9] ipf: Add set maximum fragments supported command.

A new command "ovs-appctl dpctl/ipf-set-maxfrags" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpct

[ovs-dev] [patch v2 7/9] ipf: Add command to get fragmentation handling status.

A new command "ovs-appctl dpctl/ipf-get-status" is added for userspace datapath conntrack fragmentation support. The command shows the configuration status as well as fragment counters. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-d

[ovs-dev] [patch v2 4/9] ipf: Add command to enable fragmentation handling.

A new command "ovs-appctl dpctl/ipf-set-enabled" is added to enable/disable userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpct

[ovs-dev] [patch v2 5/9] ipf: Add set minimum fragment size command.

A new command "ovs-appctl dpctl/ipf-set-minfragment" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpct

[ovs-dev] [patch v2 3/9] conntrack: Support v4 fragmentation.

The conntrack module now calls fragmentation support apis. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 3 ++- lib/conntrack.c | 6 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index d7d585b..137c511 100644 --- a/NEWS +++ b/NEWS @

[ovs-dev] [patch v2 2/9] Userspace datapath: Add v4 fragmentation handling.

Fragmentation handling is added for supporting conntrack. Presently, only v4 is supported, with v6 coming soon. Fragmentation handling is disabled by default and enabled via a user command implemented in a subsequent patch. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/automake.mk

[ovs-dev] [patch v2 0/9] Userspace datapath: Add fragmentation support.

Fragmentation support for userspace datapath conntrack is added; see patches for additional details. v1->v2: Few fixes, improvements and cleanups. Darrell Ball (9): dp-packet: Add const qualifiers for checksum apis. Userspace datapath: Add v4 fragmentation handling. conntrack: Support

[ovs-dev] [patch v2 1/9] dp-packet: Add const qualifiers for checksum apis.

Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/dp-packet.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index b4b721c..61d4cd4 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -637,7 +637,7 @@ dp_packet_mbuf_init(

[ovs-dev] [patch v1 9/9] tests: Enable v4 fragmentation tests for userspace datapath.

Enable v4 fragmentation tests for the userspace datapath. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-kmod-macros.at | 14 +++--- tests/system-traffic.at | 27 +-- tests/system-userspace-macros.a

[ovs-dev] [patch v1 8/9] tests: Add missed local stack check.

Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-traffic.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index dbd5640..aee7391 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -2093,6 +2093,7 @@ AT

[ovs-dev] [patch v1 7/9] ipf: Add command to get fragmentation handling status.

A new command "ovs-appctl dpctl/ipf-get-status" is added for userspace datapath conntrack fragmentation support. The command shows the configuration status as well as fragment counters. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-d

[ovs-dev] [patch v1 6/9] ipf: Add command to set maximum fragments supported.

A new command "ovs-appctl dpctl/ipf-set-maxfrags" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpct

[ovs-dev] [patch v1 5/9] ipf: Add command to set minimum fragment size supported.

A new command "ovs-appctl dpctl/ipf-set-minfragment" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpct

[ovs-dev] [patch v1 2/9] Userspace datapath: Add v4 fragmentation handling.

Fragmentation handling is added for supporting conntrack. Presently, only v4 is supported, with v6 coming soon. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/automake.mk | 2 + lib/ipf.c | 858 lib/ipf.h

[ovs-dev] [patch v1 1/9] dp-packet: Add const qualifiers for checksum apis.

Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/dp-packet.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index b4b721c..61d4cd4 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -637,7 +637,7 @@ dp_packet_mbuf_init(

[ovs-dev] [patch v1 0/9] Userspace datapath: Add fragmentation support.

Fragmentation support for userspace datapath conntrack is added; see patches for additional details. Patch 5 has line length checkpatch warning in NEWS which will be fixed later :-). Darrell Ball (9): dp-packet: Add const qualifiers for checksum apis. Userspace datapath: Add v4 fragmentation

Re: [ovs-dev] [PATCH V2 2/2] rhel: Add post installation check for kernel modules

Thanks for working on this Greg I just have a few comments/questions. On 1/12/18, 8:38 AM, "ovs-dev-boun...@openvswitch.org on behalf of Greg Rose" wrote: A bug in RHEL 7.2 has been found in which a customer who installed

Re: [ovs-dev] [PATCH] ofproto-dpif: Issue clear error messages for unsupported CT features.

On 1/10/18, 1:05 PM, "Ben Pfaff" <b...@ovn.org> wrote: On Wed, Jan 10, 2018 at 08:49:15PM +0000, Darrell Ball wrote: > Thanks for doing this; I have debugged the associated kinds of problems and the new more granular errors for mask and action will help. >

Re: [ovs-dev] [PATCH] ofproto-dpif: Issue clear error messages for unsupported CT features.

Thanks for doing this; I have debugged the associated kinds of problems and the new more granular errors for mask and action will help. I did not test it yet, but I have one comment inline. On 1/10/18, 8:35 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"

Re: [ovs-dev] [PATCH 0/3] Initial support for new SIP Alg.

On 1/9/18, 12:44 PM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell Ball" <ovs-dev-boun...@openvswitch.org on behalf of db...@vmware.com> wrote: On 1/9/18, 11:33 AM, "ovs-dev-boun...@openvswitch.org on behalf of Mark Michelson" <ov

[ovs-dev] [patch v4 3/4] conntrack: Some style improvements.

instances where a local variable for conn_key_hash could be eliminated. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- v3->v4: Eliminate some instances of local variables used for conn_key_hash. v2->v3: Incorporate review comments from Flavio. A separate follow

[ovs-dev] [patch v4 4/4] conntrack: Reorder sanity checks in extract_l3_ipvx().

the assignments. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- v4: Rebase series. v3: First version. lib/conntrack.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 3a7667f..44dfcf4 100644 --- a/lib/conntrack.c

[ovs-dev] [patch v4 2/4] conntrack: Add additional alg support.

to support the above changes. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- v3->v4: Add a comment. v1->v3: Rebase patches and create series. lib/conntrack-private.h | 6 ++-- lib/conntrack.c | 91 +++-- 2 files changed, 60 inser

[ovs-dev] [patch v4 1/4] conntrack: Fix alg expectation cleanup.

connections are removed. The previous code to expire the expectations is removed at the same time. Fixes: bd5e81a0e ("Userspace Datapath: Add ALG infra and FTP.") Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-December/341683.html Signed-off-by: Darrell Ball <dlu

Re: [ovs-dev] [patch v3 2/5] conntrack: Fix alg expectation cleanup.

On 1/9/18, 12:56 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" <ovs-dev-boun...@openvswitch.org on behalf of b...@ovn.org> wrote: On Mon, Jan 08, 2018 at 12:54:26PM -0800, Darrell Ball wrote: > Presently, alg expectations are removed by

Re: [ovs-dev] [PATCH 0/3] Initial support for new SIP Alg.

On 1/9/18, 11:33 AM, "ovs-dev-boun...@openvswitch.org on behalf of Mark Michelson" wrote: On 12/22/2017 01:53 PM, Tiago Lam wrote: > This patch-set is an initial approach at implementing the new SIP Alg, >

[ovs-dev] [patch v2 3/3] tests: Add dpctl test for conntrack nconns/maxconns.

Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-kmod-macros.at | 19 + tests/system-traffic.at | 85 tests/system-userspace-macros.at | 12 ++ 3 files changed, 116 insertions(+) diff --git a/tests/syste

[ovs-dev] [patch v2 2/3] dpctl conntrack: Add get number of connections.

A get command is added for number of conntrack connections. This command is only supported in the userspace datapath at this time. Signed-off-by: Darrell Ball <dlu...@gmail.com> Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com> Co-authored-by: Antonio Fischetti <

[ovs-dev] [patch v2 1/3] dpctl conntrack: Add get and set maxconns command.

Get and set dpctl commands are added for conntrack maxconns. These commands are only supported in the userspace datapath at this time. Signed-off-by: Darrell Ball <dlu...@gmail.com> Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com> Co-authored-by: Antonio Fischetti <

[ovs-dev] [patch v2 0/3] dpctl conntrack: Add nconns/maxconns commands.

xed instead of atomic_init Add NEWS items. Add missing comments to the documentation that new commands are only supported for the userspace datapath. Darrell Ball (3): dpctl conntrack: Add get and set maxconns command. dpctl conntrack: Add get number of connections. te

[ovs-dev] [patch v3 4/5] conntrack: Some style improvements.

not needed by prior art and some cases where they were needed but missed. There was one case where there was a missing space after "}". There were a few cases where for loop index declarations could be folded into the loop. One function was missing some const qualifiers. Signed-off-by: Da

[ovs-dev] [patch v3 5/5] conntrack: Reorder sanity checks in extract_l3_ipvx().

the assignments. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 0902e0e..a068910 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -1517,11 +1

[ovs-dev] [patch v3 3/5] conntrack: Add additional alg support.

to support the above changes. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack-private.h | 6 ++-- lib/conntrack.c | 89 ++--- 2 files changed, 58 insertions(+), 37 deletions(-) diff --git a/lib/conntrack-private.h b/lib/con

[ovs-dev] [patch v3 2/5] conntrack: Fix alg expectation cleanup.

connections are removed. The previous code to expire the expectations is removed at the same time. Fixes: bd5e81a0e ("Userspace Datapath: Add ALG infra and FTP.") Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-December/341683.html Signed-off-by: Darrell Ball <dlu

[ovs-dev] [patch v3 1/5] hindex: Add hindex_next_node_with_hash.

Add hindex_next_node_with_hash() api which gets a next hindex node with the same hash as the parameter node or null if there is no such next node. This api will be used is a subsequent patch. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/hindex.h | 9 + 1 file chan

Re: [ovs-dev] Userspace space conntrack tcp issue

Hi Wang Pls see inline Thanks Darrell On 1/1/18, 10:57 PM, "ovs-dev-boun...@openvswitch.org on behalf of 王志克" wrote: Hi, I am testing below scenario, and I think there is some issue on TCP conntrack

Re: [ovs-dev] [PATCH 0/3] Initial support for new SIP Alg.

Thanks for the series/work; I’ll be reviewing this series, but focusing on the high level aspects initially. Some high level comments: I noticed that your own comments in the series often pointed out various issues with this series, such as assuming TCP transport, which is ‘unusual’, no NAT

Re: [ovs-dev] [patch v1 1/4] conntrack: Some formatting improvements.

y anymore, but I reviewed anyways. Thank you Flavio ! This patch was superceded and now outdated, but let me fold your comments for V3, since there is now a request to combine some weakly related patches including this one into a series. Cheers Darrell On Sun, Nov 19, 2017 at 01:02:19PM -08

Re: [ovs-dev] [patch v2] conntrack: Fix alg expectation cleanup.

On 1/4/18, 1:25 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" <ovs-dev-boun...@openvswitch.org on behalf of b...@ovn.org> wrote: On Fri, Dec 15, 2017 at 07:32:48PM -0800, Darrell Ball wrote: > Presently, alg expectations are removed by

Re: [ovs-dev] [patch v1 1/3] dpctl conntrack: Add get and set maxconns command.

On 1/4/18, 1:30 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" <ovs-dev-boun...@openvswitch.org on behalf of b...@ovn.org> wrote: On Mon, Dec 18, 2017 at 08:27:17AM -0800, Darrell Ball wrote: > Get and set dpctl commands are added for

Re: [ovs-dev] [patch v1] conntrack: Add additional alg support.

On 1/4/18, 1:07 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" <ovs-dev-boun...@openvswitch.org on behalf of b...@ovn.org> wrote: On Tue, Dec 26, 2017 at 10:51:38AM -0800, Darrell Ball wrote: > In order to support more algs with different requirements

[ovs-dev] [patch v1] conntrack: Add additional alg support.

In order to support more algs with different requirements, expectation handling is allowed to handle more cases, such as a wildcard source ip as in the case of SIP. NAT can also be skipped in some alg cases. Some renaming is done to support the above changes. Signed-off-by: Darrell Ball <

Re: [ovs-dev] [PATCH v4 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

le lookup stats is renamed to make it clear that it > > relates to masked lookups. > > > > 8. The PMD stats test is updated to handle the new user stats of > > packets received, packets recirculated and average number of datapath > > passes per packet. > >

[ovs-dev] [patch v1 3/3] tests: Add dpctl test for conntrack nconns/maxconns.

Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-kmod-macros.at | 19 + tests/system-traffic.at | 85 tests/system-userspace-macros.at | 12 ++ 3 files changed, 116 insertions(+) diff --git a/tests/syste

[ovs-dev] [patch v1 2/3] dpctl conntrack: Add get number of connections command.

A get command is added for number of conntrack connections. This command is only supported in the userspace datapath at this time. Signed-off-by: Darrell Ball <dlu...@gmail.com> Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com> Co-authored-by: Antonio Fischetti <

[ovs-dev] [patch v1 1/3] dpctl conntrack: Add get and set maxconns command.

Get and set dpctl commands are added for conntrack maxconns. These commands are only supported in the userspace datapath at this time. Signed-off-by: Darrell Ball <dlu...@gmail.com> Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com> Co-authored-by: Antonio Fischetti <

[ovs-dev] [patch v1 0/3] dpctl conntrack: Add nconns/maxconns commands.

Commands are added to: Get the number of conntrack connections. Get the maximum limit of conntrack connections. Set the maximum limit of conntrack connections. These commands are only supported in the userspace datapath at this time. A supporting test is added. Darrell Ball (3): dpctl

[ovs-dev] [patch v2] conntrack: Fix alg expectation cleanup.

at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-December/341683.html Signed-off-by: Darrell Ball <dlu...@gmail.com> --- v1->v2: Use single node for both expectations and expectation_refs. Remove outdated comment. Simplify an api. lib/conntrack-private.h | 7

Re: [ovs-dev] [PATCH v3 2/5] conntrack: add commands to r/w CT parameters.

ds, -Antonio > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Monday, December 11, 2017 6:44 PM > To: Fischetti, Antonio <antonio.fische...@intel.com>; > d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v3 2/5] conntrack:

Re: [ovs-dev] [patch v1] conntrack: Fix icmp error address sanity check.

I sent a V2 here https://patchwork.ozlabs.org/patch/847315/ an extra signoff had snuck into v1 Thanks Darrell On 12/11/17, 5:22 PM, "Darrell Ball" <db...@vmware.com> wrote: Ben I sent a 2.7 patch here: https://patchwork.ozlabs.org/patch/847308/ it shou

[ovs-dev] [patch v2 2.7] conntrack: Fix icmp error address sanity check.

roiet...@vmware.com> Signed-off-by: Darrell Ball <dlu...@gmail.com> Signed-off-by: wangzhike <wangzh...@jd.com> Co-authored-by: wangzhike <wangzh...@jd.com> --- lib/conntrack.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/conntrack.c b/lib/c

Re: [ovs-dev] [patch v1] conntrack: Fix icmp error address sanity check.

or 2.6, can you look at that? On Mon, Dec 11, 2017 at 10:28:32PM +0000, Darrell Ball wrote: > Yes, it is Ben > > Thanks Darrell > > On 12/11/17, 2:27 PM, "Ben Pfaff" <b...@ovn.org> wrote: > > It fails to app

[ovs-dev] [patch 2.7] conntrack: Fix icmp error address sanity check.

roiet...@vmware.com> Signed-off-by: Darrell Ball <dlu...@gmail.com> Signed-off-by: wangzhike <wangzh...@jd.com> Co-authored-by: wangzhike <wangzh...@jd.com> Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack.c | 7 ++- 1 file changed, 2 insertions(+), 5 de

Re: [ovs-dev] [PATCH v2 2/3] conntrack: Support conntrack flush by ct 5-tuple

A few suggestions Yi-hung Thanks Darrell On 11/21/17, 5:04 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yi-Hung Wei" wrote: This patch adds support of flushing a conntrack entry specified by the conntrack 5-tuple

Re: [ovs-dev] [patch v1] conntrack: Fix icmp error address sanity check.

Yes, it is Ben Thanks Darrell On 12/11/17, 2:27 PM, "Ben Pfaff" <b...@ovn.org> wrote: It fails to apply due to conflicts in system-traffic.at. Is it safe to drop that change and apply the rest? On Mon, Dec 11, 2017 at 10:22:39PM +0000, Darrell Ball wrote:

Re: [ovs-dev] [patch v1] conntrack: Fix icmp error address sanity check.

Needs to go back to 2.6; at least the changes in lib/conntrack.c Thanks Darrell On 12/11/17, 2:20 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" <ovs-dev-boun...@openvswitch.org on behalf of b...@ovn.org> wrote: On Wed, Dec 06, 2017 at 06:04:20PM -0800, Da

Re: [ovs-dev] [PATCH v3 2/5] conntrack: add commands to r/w CT parameters.

One extra note inline Thanks Darrell On 12/11/17, 8:35 AM, "Darrell Ball" <db...@vmware.com> wrote: Thanks Antonio for doing all this and pushing it forward. Regarding patches 2-4: I understand you want to save some code for various possible set and

Re: [ovs-dev] [PATCH v3 5/5] doc: ConnTracker cfg parameters.

the new commands to Read/Write ConnTracker configuration parameters. CC: Kevin Traynor <ktray...@redhat.com> CC: Darrell Ball <dlu...@gmail.com> Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com> --- Documen

Re: [ovs-dev] [PATCH v3 2/5] conntrack: add commands to r/w CT parameters.

, "ovs-dev-boun...@openvswitch.org on behalf of antonio.fische...@intel.com" <ovs-dev-boun...@openvswitch.org on behalf of antonio.fische...@intel.com> wrote: Add infrastructure to implement: - dpctl/ct-get-glbl-cfg to read a current va

[ovs-dev] [patch v2] conntrack: Some style improvements.

not needed by prior art and some cases where they were needed but missed. There was one case where there was a missing space after "}". There were a few cases where for loop index decalrations could be folded into the loop. One function was missing some const qualifiers. Signed-off-by: Da

Re: [ovs-dev] [PATCH v2 2/3] conntrack: Support conntrack flush by ct 5-tuple

On 12/6/17, 2:57 PM, "ovs-dev-boun...@openvswitch.org on behalf of Justin Pettit" wrote: > On Nov 21, 2017, at 5:00 PM, Yi-Hung Wei wrote: > > diff --git a/lib/conntrack.c

[ovs-dev] [patch v1] conntrack: Fix alg expectation cleanup.

at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-December/341683.html Signed-off-by: Darrell Ball <dlu...@gmail.com> --- This patch depends on the series here: https://patchwork.ozlabs.org/project/openvswitch/list/?series=16626 lib/conntrack-private.h | 13 ++- lib/conntrack

Re: [ovs-dev] [PATCH] lib/conntrack: remove unnecessary addr check for ICMP.

ack will or can do is “making assumptions”. I am open to the decision. So if you think your patch is more suitable, I can be the co-author. [Darrell] I will keep you as co-author then. Br, Wang Zhike -Original Message- From: Darrell Ball [mailto:

Re: [ovs-dev] [PATCH] lib/conntrack: remove unnecessary addr check for ICMP.

. Also. if you prefer, I can make you the author. Thanks Darrell On 12/6/17, 11:22 AM, "Darrell Ball" <db...@vmware.com> wrote: Thanks for looking at this. In the commit message, can you delineate. 1/ The forward direction packet in terms of src ip, dest i

[ovs-dev] [patch v1] conntrack: Fix icmp error address sanity check.

roiet...@vmware.com> Signed-off-by: Darrell Ball <dlu...@gmail.com> Signed-off-by: wangzhike <wangzh...@jd.com> Co-authored-by: wangzhike <wangzh...@jd.com> --- lib/conntrack.c | 7 ++- tests/system-traffic.at | 6 +++--- 2 files changed, 5 insertions(+), 8 deletion

<    3   4   5   6   7   8   9   10   11   12   >