Re: [ovs-dev] [PATCH 1/2] Documentation: update IPsec tutorial for F32

On Fri, Oct 02, 2020 at 01:33:57PM -0400, Mark Gray wrote: > F32 requires the "python3-openvswitch" package now. Also, the > iptables chain "IN_FedoraServer_allow" does not exist on Fedora 32. > > Signed-off-by: Mark Gray > --- > Documentation/tutorials/ipsec.rst | 27

[ovs-dev] RFC: ct action ofproto/trace improvements

Hi all, Below is a short proposal for improving the results of ofproto/trace in regards to ct actions. Feedback welcome. Eric. --->8--- ### Problem statement - ofproto/trace fails in regard to conntrack states and address/port translations - conntrack is used heavily in OVN - makes debugging

Re: [ovs-dev] [ovs-discuss] [PATCH v2] [PATCH] QinQ: support more vlan headers.

and there are alternatives such as VXLAN. If it wasn't splitting the MPLS labels across cache lines then it would be a harmless change. > > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, September 11, 2018 3:33 AM > To: Eric Garver ;

Re: [ovs-dev] [ovs-discuss] [PATCH v2] [PATCH] QinQ: support more vlan headers.

better solution. > > Thanks. > > -Original Message- > From: Eric Garver [mailto:e...@garver.life] > Sent: Friday, September 07, 2018 10:14 PM > To: Lilijun (Jerry, Cloud Networking) > Cc: Ben Pfaff ; d...@openvswitch.org; > ovs-disc...@openvswitch.org > Subject:

Re: [ovs-dev] [PATCH] vswitch.xml: Better explain vlan-limit.

On Fri, Sep 07, 2018 at 10:39:18AM -0700, Ben Pfaff wrote: > CC: Eric Garver > Requested-by: Jerry Lilijun > Signed-off-by: Ben Pfaff > --- > vswitchd/vswitch.xml | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/vswitchd/vswitch.xm

Re: [ovs-dev] [ovs-discuss] [PATCH v2] [PATCH] QinQ: support more vlan headers.

On Fri, Sep 07, 2018 at 09:53:44AM +, Lilijun (Jerry, Cloud Networking) wrote: > In my test, vlan-limit is set to 0 that means unlimited the count of vlan > headers. > ovs-vsctl set Open_vSwitch . other_config:vlan-limit=0 > > But in fact the macro FLOW_MAX_VLAN_HEADERS is defined as 2, so

Re: [ovs-dev] [ovs-discuss] [PATCH] [PATCH] QinQ: support more vlan headers.

supported VLANs in; the Open vSwitch userpsace (currently 2), and the datapath. > > > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, September 07, 2018 12:13 PM > To: Lilijun (Jerry, Cloud Networking) > Cc: ovs-disc...@openvswitch.or

Re: [ovs-dev] [ovs-discuss] fix the mod_vlan_vid actions with OpenFlow13.

an come up with something. > > B.R. > Lilijun > > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Eric Garver > Sent: Tuesday, August 21, 2018 9:45 PM > To: wangyunjian > Cc: d...@ope

Re: [ovs-dev] [ovs-discuss] fix the mod_vlan_vid actions with OpenFlow13.

On Tue, Aug 21, 2018 at 02:23:33AM +, wangyunjian wrote: > > > > -Original Message- > > From: Eric Garver [mailto:e...@erig.me] > > Sent: Monday, August 20, 2018 9:15 PM > > To: wangyunjian > > Cc: d...@openvswitch.org; ovs-disc...@openvs

Re: [ovs-dev] [ovs-discuss] fix the mod_vlan_vid actions with OpenFlow13.

On Mon, Aug 20, 2018 at 02:17:34AM +, wangyunjian wrote: > > [..] > > > On Fri, Aug 17, 2018 at 12:15:30PM +, wangyunjian wrote: > > > > The datapath flow which pushs double vlan was found using ovs-appctl > > > > dpctl/dump-flows, but the flow was set mod_vlan_vid actions. > > > > This

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

On Fri, Jun 01, 2018 at 11:23:12AM -0700, William Tu wrote: > On Fri, Jun 1, 2018 at 9:38 AM, Jiri Benc wrote: > > On Fri, 1 Jun 2018 09:15:33 -0700, Gregory Rose wrote: > >> Since ERSPAN over gre/ip_gre was added to the Linux 4.16 kernel the > >> compat interface is needed > >> for kernels up to

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

On Fri, Jun 01, 2018 at 07:40:49AM -0700, Gregory Rose wrote: > On 6/1/2018 6:15 AM, Eric Garver wrote: > > I'm a bit late, but I have comments below. > > > > I'm also a bit out of touch, so I may be missing some context - if so, I > > apologize. > > > > O

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

I'm a bit late, but I have comments below. I'm also a bit out of touch, so I may be missing some context - if so, I apologize. On Thu, May 31, 2018 at 03:50:31PM -0700, Greg Rose wrote: > When verifying the built-in gre kernel module check for ERSPAN support. > > Reported-by: Guru Shetty >

Re: [ovs-dev] [PATCH V2] datapath: Prevent panic

On Fri, Apr 20, 2018 at 09:03:14AM -0700, Gregory Rose wrote: > On 4/20/2018 5:39 AM, Eric Garver wrote: > > On Thu, Apr 19, 2018 at 08:07:33PM -0700, Gregory Rose wrote: > > Fantastic, I'll test this and whip up a patch. > > > Thanks! > > > > > > - Greg

Re: [ovs-dev] [PATCH V2] datapath: Prevent panic

On Thu, Apr 19, 2018 at 08:07:33PM -0700, Gregory Rose wrote: > On 4/19/2018 4:18 PM, Flavio Leitner wrote: > > On Tue, Apr 17, 2018 at 12:34:08PM -0700, Greg Rose wrote: > > > On RHEL 7.x kernels we observe a panic induced by a paging error > > > when the timer kicks off a job that subsequently

Re: [ovs-dev] [PATCH 0/2] ofproto-dpif-xlate: translate action_set in clone action

On Thu, Mar 08, 2018 at 10:51:54AM -0800, Ben Pfaff wrote: > On Thu, Mar 01, 2018 at 05:59:40PM -0500, Eric Garver wrote: > > write_actions() defined inside of a clone() were being ignored. Notably this > > affected patch ports between bridges. More details in patch 1. > >

Re: [ovs-dev] [PATCH 0/2] ofproto-dpif-xlate: translate action_set in clone action

On Thu, Mar 01, 2018 at 05:59:40PM -0500, Eric Garver wrote: > write_actions() defined inside of a clone() were being ignored. Notably this > affected patch ports between bridges. More details in patch 1. > > travis-ci: https://travis-ci.org/erig0/ovs/builds/347988851 > > Not

[ovs-dev] [PATCH 2/2] tests/ofproto-dpif: New test for action_set after traversing patch port

Signed-off-by: Eric Garver <e...@erig.me> --- tests/ofproto-dpif.at | 25 + 1 file changed, 25 insertions(+) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index 600afdda8528..73ad50b6f3d4 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-d

[ovs-dev] [PATCH 1/2] ofproto-dpif-xlate: translate action_set in clone action

traversing to a second bridge via patch port will never be affected by write_action() in the second bridge's flow table. Lets make clone() aware of the action_set. Signed-off-by: Eric Garver <e...@erig.me> --- ofproto/ofproto-dpif-xlate.c | 9 + 1 file changed, 9 insertions(+) diff

[ovs-dev] [PATCH 0/2] ofproto-dpif-xlate: translate action_set in clone action

test machine, debian-9 kernel 4.9.65-3+deb9u2. Eric Garver (2): ofproto-dpif-xlate: translate action_set in clone action tests/ofproto-dpif: New test for action_set after traversing patch port ofproto/ofproto-dpif-xlate.c | 9 + tests/ofproto-dpif.at| 25

Re: [ovs-dev] [PATCH v2 1/1] userspace: Add IPv6 extension header parsing for tunnels

s unsupported extension headers"); > +return NULL; > +} > + > +*hlen += l3_size - IPV6_HEADER_LEN - ip6_size; > + > } else { > VLOG_WARN_RL(_rl, "ipv4 packet has invalid version (%d)", > IP_VER(ip->ip

Re: [ovs-dev] [PATCH v1 0/5] datapath: enable NSH support in kernel compat mode

port_pc 32768 0 > i2c_piix4 24576 0 > mac_hid16384 0 > sb_edac24576 0 > serio_raw 16384 0 > lp 20480 0 > parport49152 3 lp,parport_pc,ppdev > pata_acpi 16384 0

Re: [ovs-dev] [PATCH v1 0/5] datapath: enable NSH support in kernel compat mode

fc test environment in my machine and have > verified kernel data path, my test environment has two vagrant VMs, each one > VM starts two containers which play SF roles, end-to-end ping and http are > both ok. > > -Original Message- > From: Eric Garver [mailto:e...@

Re: [ovs-dev] [PATCH v1 0/5] datapath: enable NSH support in kernel compat mode

On Tue, Jan 30, 2018 at 11:33:55AM +, Yang, Yi Y wrote: > Hi, Greg > > I installed linux 3.10.107 in Ubuntu 14.04 and fixed skb_gso_error_unwind > issue, but for unit test, tests/system-layer3-tunnels.at is a good reference > for it because we used vxlan-gpe for nsh, I ran unit test 90, but

Re: [ovs-dev] [PATCH] ofproto-dpif: Delete system tunnel interface when remove ovs bridge

On Wed, Jan 24, 2018 at 12:48:38PM -0800, Ben Pfaff wrote: > On Wed, Jan 24, 2018 at 09:31:32AM -0500, Eric Garver wrote: > > On Tue, Jan 23, 2018 at 07:46:47PM -0800, Ben Pfaff wrote: > > > On Thu, Oct 26, 2017 at 10:24:46AM -0400, Eric Garver wrote: > > > > On W

Re: [ovs-dev] [PATCH] ofproto-dpif: Delete system tunnel interface when remove ovs bridge

On Tue, Jan 23, 2018 at 07:46:47PM -0800, Ben Pfaff wrote: > On Thu, Oct 26, 2017 at 10:24:46AM -0400, Eric Garver wrote: > > On Wed, Oct 25, 2017 at 11:41:27AM +0800, ju...@redhat.com wrote: > > > When there is only one bridge,create tunnel in the bridge, > > > then

Re: [ovs-dev] [PATCH 2/2] datapath: add ct_clear action

On Mon, Jan 22, 2018 at 02:38:07PM -0800, Pravin Shelar wrote: > On Mon, Jan 22, 2018 at 11:10 AM, Eric Garver <e...@erig.me> wrote: > > Upstream commit: > > commit b8226962b1c49c784aeddb9d2fafbf53dfdc2190 > > Author: Eric Garver <e...@erig.me> > &g

Re: [ovs-dev] [PATCH] NEWS: Move ct_clear support to 2.9.0 section.

ct_clear action is now backed by kernel datapath. Support is probed > for > + when OVS starts. > - Linux kernel 4.13 > * Add support for compiling OVS with the latest Linux 4.13 kernel > - ovs-dpctl and related ovs-appctl commands: > -- > 2.7.4 Thanks J

[ovs-dev] [PATCH 2/2] datapath: add ct_clear action

Upstream commit: commit b8226962b1c49c784aeddb9d2fafbf53dfdc2190 Author: Eric Garver <e...@erig.me> Date: Tue Oct 10 16:54:44 2017 -0400 openvswitch: add ct_clear action This adds a ct_clear action for clearing conntrack state. ct_clear is currently implemented

[ovs-dev] [PATCH 1/2] acinclude: check for IP_CT_UNTRACKED

IP_CT_UNTRACKED is fairly new, but used by the kernel datapath ct_clear action. Signed-off-by: Eric Garver <e...@erig.me> --- acinclude.m4 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4 index 16a57a341b7d..c04c2c65bcdb 100644 --- a/acinclude.m4

[ovs-dev] [PATCH 0/2] datapath: backport ct_clear action

This series backports the kernel datapath support for the ct_clear action. travis-ci: https://travis-ci.org/erig0/ovs/builds/331926792 Eric Garver (2): acinclude: check for IP_CT_UNTRACKED datapath: add ct_clear action acinclude.m4| 2 ++ datapath/actions.c | 4

Re: [ovs-dev] [PATCH v4 1/3] dpif: Add support for OVS_ACTION_ATTR_CT_CLEAR

On Sat, Jan 20, 2018 at 11:22:06AM -0800, Justin Pettit wrote: > > > On Jan 19, 2018, at 11:21 AM, Eric Garver <e...@erig.me> wrote: > > > > This supports using the ct_clear action in the kernel datapath. To > > preserve compatibility with current ct_clear beh

[ovs-dev] [PATCH v4 1/3] dpif: Add support for OVS_ACTION_ATTR_CT_CLEAR

This supports using the ct_clear action in the kernel datapath. To preserve compatibility with current ct_clear behavior on old kernels, we only pass this action down to the datapath if a probe reveals the datapath actually supports it. Signed-off-by: Eric Garver <e...@erig.me> Acked-by: W

[ovs-dev] [PATCH v4 3/3] system-traffic: Add conntrack floating IP test

ion in the datapath. Signed-off-by: Eric Garver <e...@erig.me> Acked-by: William Tu <u9012...@gmail.com> Acked-by: Flavio Leitner <f...@sysclose.org> --- tests/system-traffic.at | 73 + 1 file changed, 73 insertions(+) diff --git a/tests/syst

[ovs-dev] [PATCH v4 2/3] system-common-macros: Check for ct_clear action in datapath

New macro OVS_CHECK_CT_CLEAR() to check if ct_clear action is supported by the datapath. Signed-off-by: Eric Garver <e...@erig.me> Tested-by: William Tu <u9012...@gmail.com> Acked-by: Flavio Leitner <f...@sysclose.org> --- tests/system-common-macros.at | 4 1 file cha

[ovs-dev] [PATCH v4 0/3] Add dpif support for ct_clear action

ort for nc in test (patch 3) Eric Garver (3): dpif: Add support for OVS_ACTION_ATTR_CT_CLEAR system-common-macros: Check for ct_clear action in datapath system-traffic: Add conntrack floating IP test NEWS | 5 +- datapath/linux/compat/include/linux/ope

Re: [ovs-dev] [PATCH v3 1/2] dpif-netlink-rtnl: Use 65000 instead of 65535 as tunnel MTU.

> commit changes the MTU used in RTM_NEWLINK calls to use a value that should > be acceptable to all tunnels and yet does not noticeably reduce > performance. > > (This code doesn't actually use RTM_SETLINK to change MTU yet, but that's > coming up.) > > Suggested-by: Eric

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Work around MTU bug in kernel GRE driver.

On Tue, Jan 16, 2018 at 09:16:47AM -0800, Ben Pfaff wrote: > On Tue, Jan 16, 2018 at 10:42:16AM -0500, Eric Garver wrote: > > On Fri, Jan 12, 2018 at 12:44:59PM -0800, Ben Pfaff wrote: > > > The kernel GRE driver ignores IFLA_MTU in RTM_NEWLINK requests and > > > over

Re: [ovs-dev] [PATCH v3 0/3] Add dpif support for ct_clear action

On Sat, Nov 18, 2017 at 07:41:43PM -0500, Eric Garver wrote: > This series adds dpif support for OVS_ACTION_ATTR_CT_CLEAR. Previously the > ct_clear action was a userspace only operation, but it has use cases in the > dpif as well. Namely changing a packet's tuple after a ct() l

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Work around MTU bug in kernel GRE driver.

> the MTU. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1488484 > Reported-by: Eric Garver <e...@erig.me> > Reported-by: James Page <james.p...@ubuntu.com> > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > This is not properly tested. It n

Re: [ovs-dev] Odd gre_sys MTU setting (2.6.x vs 2.8.x)

On Tue, Jan 16, 2018 at 06:27:23AM +, James Page wrote: > On Mon, 15 Jan 2018 at 18:55 Christian Ehrhardt < > christian.ehrha...@canonical.com> wrote: > > > On Mon, Jan 15, 2018 at 5:43 PM, Eric Garver <e...@erig.me> wrote: > > > On Mon, Jan 15, 2018 at

Re: [ovs-dev] Odd gre_sys MTU setting (2.6.x vs 2.8.x)

On Mon, Jan 15, 2018 at 11:32:32AM -0500, Eric Garver wrote: > On Mon, Jan 15, 2018 at 03:17:28PM +, James Page wrote: > > Hi Eric > > > > On Mon, 15 Jan 2018 at 16:54 Eric Garver <e...@erig.me> wrote: > > > > > On Sat, Jan 13, 2018 at 03:57:08PM

Re: [ovs-dev] Odd gre_sys MTU setting (2.6.x vs 2.8.x)

On Mon, Jan 15, 2018 at 03:17:28PM +, James Page wrote: > Hi Eric > > On Mon, 15 Jan 2018 at 16:54 Eric Garver <e...@erig.me> wrote: > > > On Sat, Jan 13, 2018 at 03:57:08PM +, James Page wrote: > > > Hi Ben s > > > > > > On Sat, 13

Re: [ovs-dev] Odd gre_sys MTU setting (2.6.x vs 2.8.x)

On Sat, Jan 13, 2018 at 03:57:08PM +, James Page wrote: > Hi Ben s > > On Sat, 13 Jan 2018 at 14:55 James Page wrote: > > > OK, I sent a patch: > >> https://patchwork.ozlabs.org/patch/860192/ > > > > > > Thanks Ben - I'll pull this patch into the Ubuntu

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Work around MTU bug in kernel GRE driver.

On Fri, Jan 12, 2018 at 02:04:11PM -0800, Ben Pfaff wrote: > On Fri, Jan 12, 2018 at 04:51:00PM -0500, Eric Garver wrote: > > On Fri, Jan 12, 2018 at 04:35:06PM -0500, Eric Garver wrote: > > > On Fri, Jan 12, 2018 at 12:44:59PM -0800, Ben Pfaff wrote: > > > > The kern

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Work around MTU bug in kernel GRE driver.

On Fri, Jan 12, 2018 at 04:35:06PM -0500, Eric Garver wrote: > On Fri, Jan 12, 2018 at 12:44:59PM -0800, Ben Pfaff wrote: > > The kernel GRE driver ignores IFLA_MTU in RTM_NEWLINK requests and > > overrides the MTU to 1472 bytes. This commit works around the problem by > > f

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Work around MTU bug in kernel GRE driver.

> the MTU. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1488484 > Reported-by: Eric Garver <e...@erig.me> > Reported-by: James Page <james.p...@ubuntu.com> > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > This is not properly tested. It n

Re: [ovs-dev] Odd gre_sys MTU setting (2.6.x vs 2.8.x)

On Fri, Jan 12, 2018 at 10:18:42AM -0800, Ben Pfaff wrote: > On Fri, Jan 12, 2018 at 10:51:11AM -0500, Eric Garver wrote: > > On Fri, Jan 12, 2018 at 12:33:23PM +, James Page wrote: > > > Hi > > > > > > We're currently trying to debug an issue we're seeing

Re: [ovs-dev] Odd gre_sys MTU setting (2.6.x vs 2.8.x)

On Fri, Jan 12, 2018 at 12:33:23PM +, James Page wrote: > Hi > > We're currently trying to debug an issue we're seeing when using OpenStack > with OVS 2.8.1 (see [0]). > > When using GRE tunnels, we're seeing broken/slow performance due to what > appears to be an incorrect MTU setting on the

[ovs-dev] [PATCH net v3] openvswitch: Fix pop_vlan action for double tagged frames

skb_vlan_pop() expects skb->protocol to be a valid TPID for double tagged frames. So set skb->protocol to the TPID and let skb_vlan_pop() shift the true ethertype into position for us. Fixes: 5108bbaddc37 ("openvswitch: add processing of L3 packets") Signed-off-by: Eric Garv

Re: [ovs-dev] [PATCH net v2] openvswitch: Fix pop_vlan action for double tagged frames

On Wed, Dec 20, 2017 at 06:41:17PM +0100, Jiri Benc wrote: > On Wed, 20 Dec 2017 10:39:32 -0500, Eric Garver wrote: > > + if (is_flow_key_valid(key) && key->eth.vlan.tci && key->eth.cvlan.tci) > > Maybe (key->eth.vlan.tci & htons(VLAN_TAG_PRESENT))

[ovs-dev] [PATCH net v2] openvswitch: Fix pop_vlan action for double tagged frames

skb_vlan_pop() expects skb->protocol to be a valid TPID for double tagged frames, but skb->protocol is set to the ethertype by key_extract(). So temporarily set it to the TPID when doing a pop_vlan. Fixes: 5108bbaddc37 ("openvswitch: add processing of L3 packets") Signed-off-by

Re: [ovs-dev] [PATCH net] openvswitch: Fix pop_vlan action for double tagged frames

On Tue, Dec 19, 2017 at 03:42:47PM -0500, Eric Garver wrote: > On Tue, Dec 19, 2017 at 08:39:29PM +0100, Jiri Benc wrote: > > On Tue, 19 Dec 2017 13:57:53 -0500, Eric Garver wrote: > > > --- a/net/openvswitch/flow.c > > > +++ b/net/openvswitch/flow.c > > > @@ -

Re: [ovs-dev] [PATCH net] openvswitch: Fix pop_vlan action for double tagged frames

On Tue, Dec 19, 2017 at 08:39:29PM +0100, Jiri Benc wrote: > On Tue, 19 Dec 2017 13:57:53 -0500, Eric Garver wrote: > > --- a/net/openvswitch/flow.c > > +++ b/net/openvswitch/flow.c > > @@ -559,8 +559,9 @@ static int parse_nsh(struct sk_buff *skb, struct

[ovs-dev] [PATCH net] openvswitch: Fix pop_vlan action for double tagged frames

skb_vlan_pop() expects skb->protocol to be a valid TPID for double tagged frames. As such don't override skb->protocol for normal ethernet frames when extracting the key. Fixes: 5108bbaddc37 ("openvswitch: add processing of L3 packets") Signed-off-by: Eric Garver <e..

Re: [ovs-dev] [PATCH] ovs-ctl: Don't remember vport-* kernel modules

On Fri, Nov 10, 2017 at 02:45:05PM -0800, Gurucharan Shetty wrote: > From OVS 2.8, ovs-vswitchd, when it starts, will > load the kernel modules for tunnels. It has logic > inside it to choose either upstream kernel module > or vport-* kernel module. > > So, when we run 'force-reload-kmod' to

[ovs-dev] [PATCH v3 3/3] system-traffic: Add conntrack floating IP test

ion in the datapath. Signed-off-by: Eric Garver <e...@erig.me> Acked-by: William Tu <u9012...@gmail.com> Acked-by: Flavio Leitner <f...@sysclose.org> --- tests/system-traffic.at | 73 + 1 file changed, 73 insertions(+) diff --git a/tests/syst

[ovs-dev] [PATCH v3 2/3] system-common-macros: Check for ct_clear action in datapath

New macro OVS_CHECK_CT_CLEAR() to check if ct_clear action is supported by the datapath. Signed-off-by: Eric Garver <e...@erig.me> Tested-by: William Tu <u9012...@gmail.com> Acked-by: Flavio Leitner <f...@sysclose.org> --- tests/system-common-macros.at | 4 1 file cha

[ovs-dev] [PATCH v3 1/3] dpif: Add support for OVS_ACTION_ATTR_CT_CLEAR

This supports using the ct_clear action in the kernel datapath. To preserve compatibility with current ct_clear behavior on old kernels, we only pass this action down to the datapath if a probe reveals the datapath actually supports it. Signed-off-by: Eric Garver <e...@erig.me> Acked-by: W

[ovs-dev] [PATCH v3 0/3] Add dpif support for ct_clear action

("openvswitch: add ct_clear action"). travis-ci: https://travis-ci.org/erig0/ovs/builds/290487503 v3: - add NEWS item - add comment describing OVS_ACTION_ATTR_CT_CLEAR - update parse_odp_action() and add ct_clear to odp test case v2: - Specify port for nc in test (patc

Re: [ovs-dev] [PATCH V2 4/4] netdev-tc-offloads: Add support for action set

On Mon, Sep 18, 2017 at 07:16:04AM +0300, Roi Dayan wrote: > From: Paul Blakey > > Implement support for offloading ovs action set using > tc header rewrite action. > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan > --- >

Re: [ovs-dev] [PATCH v2 1/3] dpif: Add support for OVS_ACTION_ATTR_CT_CLEAR

On Sat, Nov 18, 2017 at 02:23:22AM -0200, Flavio Leitner wrote: > On Thu, 26 Oct 2017 15:30:42 -0400 > Eric Garver <e...@erig.me> wrote: > > > This supports using the ct_clear action in the kernel datapath. To > > preserve compatibility with current ct_clear behavior

Re: [ovs-dev] [PATCH] datapath: compat: fix kernel module reference count.

On Fri, Nov 10, 2017 at 10:01:29AM -0800, William Tu wrote: > On Fri, Nov 10, 2017 at 7:54 AM, Eric Garver <e...@erig.me> wrote: > > On Fri, Nov 10, 2017 at 05:36:25AM -0800, William Tu wrote: > >> Before we introduce dpif-netlink-rtnl, creating a tunnel device > >

Re: [ovs-dev] [PATCH] datapath: compat: fix kernel module reference count.

On Fri, Nov 10, 2017 at 12:23:37PM -0800, William Tu wrote: > >> After the dpif-netlink-rtnl, a tunnel device can be created by using > >> rtnetlink, so the creation of fb device comes from the ovs-vswitchd > >> instead of going through OVS kernel modules. This breaks the module > >> dependency

Re: [ovs-dev] [PATCH] datapath: compat: fix kernel module reference count.

k inserting an artificial dependency is the right answer. Although I'm not sure what problem you're trying to solve. Can you help me understand the issue here? This patch also only address GENEVE, what about VXLAN and GRE? > > Fixes: b6d6830d29e4 ("dpif-netlink-rt

Re: [ovs-dev] [PATCH v2 0/3] Add dpif support for ct_clear action

On Thu, Oct 26, 2017 at 03:30:41PM -0400, Eric Garver wrote: > This series adds dpif support for OVS_ACTION_ATTR_CT_CLEAR. Previously the > ct_clear action was a userspace only operation, but it has use cases in the > dpif as well. Namely changing a packet's tuple after a ct() l

Re: [ovs-dev] [PATCHv3] dpif-netlink-rtnl: Fix ovs_geneve probing after restart.

t-of-tree tunnels, decides > used interface") > Signed-off-by: William Tu <u9012...@gmail.com> > Cc: Eric Garver <e...@erig.me> > Cc: Gurucharan Shetty <g...@ovn.org> > --- > v2->v3: > Add return code checking for netlink parsing > Fix memory

Re: [ovs-dev] [PATCHv2] dpif-netlink-rtnl: Fix ovs_geneve probing after restart.

t-of-tree tunnels, decides > used interface") > Signed-off-by: William Tu <u9012...@gmail.com> > Cc: Eric Garver <e...@erig.me> > Cc: Gurucharan Shetty <g...@ovn.org> > --- > v1->v2: > Add detection of existing module, instead of unconditionally > remo

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Fix ovs_geneve probing after restart

ink() if the device already exists. Then check IFLA_INFO_KIND == "ovs_geneve". > > Thanks > William > > On Thu, Oct 26, 2017 at 1:20 PM, Eric Garver <e...@erig.me> wrote: > > On Thu, Oct 26, 2017 at 12:31:03PM -0700, William Tu wrote: > >> When usin

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Wed, Nov 01, 2017 at 12:03:01PM +0800, Yi Yang wrote: > v14->v15 > - Check size in nsh_hdr_from_nlattr > - Fixed four small issues pointed out By Jiri and Eric Thanks Yi. Acked-by: Eric Garver <e...@erig.me> ___

Re: [ovs-dev] [PATCH net-next v14] openvswitch: enable NSH support

On Mon, Oct 30, 2017 at 09:29:34AM +0800, Yi Yang wrote: [...] > +int nsh_pop(struct sk_buff *skb) > +{ > + struct nshhdr *nh; > + size_t length; > + __be16 inner_proto; > + > + if (!pskb_may_pull(skb, NSH_BASE_HDR_LEN)) > + return -ENOMEM; > + nh = (struct nshhdr

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Fix ovs_geneve probing after restart

pif-netlink: Probe for out-of-tree tunnels, decides > used interface") > Signed-off-by: William Tu <u9012...@gmail.com> > Cc: Eric Garver <e...@erig.me> > Cc: Gurucharan Shetty <g...@ovn.org> > --- > lib/dpif-netlink-rtnl.c | 2 ++ > 1 file changed, 2

[ovs-dev] [PATCH v2 3/3] system-traffic: Add conntrack floating IP test

ion in the datapath. Signed-off-by: Eric Garver <e...@erig.me> --- tests/system-traffic.at | 73 + 1 file changed, 73 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 522eaa615834..cf915d6be7cd 100644 --- a/tests/system-t

[ovs-dev] [PATCH v2 2/3] system-common-macros: Check for ct_clear action in datapath

New macro OVS_CHECK_CT_CLEAR() to check if ct_clear action is supported by the datapath. Signed-off-by: Eric Garver <e...@erig.me> Tested-by: William Tu <u9012...@gmail.com> --- tests/system-common-macros.at | 4 1 file changed, 4 insertions(+) diff --git a/tests/system-common

[ovs-dev] [PATCH v2 1/3] dpif: Add support for OVS_ACTION_ATTR_CT_CLEAR

This supports using the ct_clear action in the kernel datapath. To preserve compatibility with current ct_clear behavior on old kernels, we only pass this action down to the datapath if a probe reveals the datapath actually supports it. Signed-off-by: Eric Garver <e...@erig.me> Acked-by: W

[ovs-dev] [PATCH v2 0/3] Add dpif support for ct_clear action

("openvswitch: add ct_clear action"). travis-ci: https://travis-ci.org/erig0/ovs/builds/290487503 v2: - Specify port for nc in test (patch 3) Eric Garver (3): dpif: Add support for OVS_ACTION_ATTR_CT_CLEAR system-common-macros: Check for ct_clear action in datapath system-tr

Re: [ovs-dev] [PATCH] ofproto-dpif: Delete system tunnel interface when remove ovs bridge

er, bool del) > > udpif_destroy(backer->udpif); > > +SIMAP_FOR_EACH (node, >tnl_backers) { > +dpif_port_del(backer->dpif, u32_to_odp(node->data)); > +} > simap_destroy(>tnl_backers); > ovs_rwlock_destroy(>o

Re: [ovs-dev] [PATCH 3/3] system-traffic: Add conntrack floating IP test

On Thu, Oct 26, 2017 at 06:06:15AM -0700, William Tu wrote: > Hi Eric, > Thanks for the reply. > > >> >> dnl means the datapath didn't process the ct_clear action. Ending in > >> >> SYN_RECV > >> >> dnl (OVS maps to ESTABLISHED) means the initial frame was committed, > >> >> but not a > >> >>

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Fix ovs_geneve probing after restart

/etc/init.d/openvswitch-switch start > > creat a bridge and attach a geneve port using out-of-tree geneve > > /etc/init.d/openvswitch-switch restart > > Fixes: 921c370a9df5 ("dpif-netlink: Probe for out-of-tree tunnels, decides > used interface") > Signed-off-by:

Re: [ovs-dev] [PATCH 3/3] system-traffic: Add conntrack floating IP test

On Tue, Oct 24, 2017 at 02:10:47PM -0700, William Tu wrote: > On Tue, Oct 24, 2017 at 1:44 PM, Eric Garver <e...@erig.me> wrote: > > On Tue, Oct 24, 2017 at 12:46:46PM -0700, William Tu wrote: > >> On Fri, Oct 20, 2017 at 11:23 AM, Eric Garver <e...@erig.me> wrot

Re: [ovs-dev] [PATCH 3/3] system-traffic: Add conntrack floating IP test

On Tue, Oct 24, 2017 at 12:46:46PM -0700, William Tu wrote: > On Fri, Oct 20, 2017 at 11:23 AM, Eric Garver <e...@erig.me> wrote: > > This test cases uses floating IP (FIP) addresses for each endpoint. If > > the destination is a FIP, the packet will undergo a transformation

[ovs-dev] [PATCH 2/3] system-common-macros: Check for ct_clear action in datapath

New macro OVS_CHECK_CT_CLEAR() to check if ct_clear action is supported by the datapath. Signed-off-by: Eric Garver <e...@erig.me> --- tests/system-common-macros.at | 4 1 file changed, 4 insertions(+) diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at

[ovs-dev] [PATCH 3/3] system-traffic: Add conntrack floating IP test

ion in the datapath. Signed-off-by: Eric Garver <e...@erig.me> --- tests/system-traffic.at | 73 + 1 file changed, 73 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 522eaa615834..7cc1e1e21187 100644 --- a/tests/system-t

[ovs-dev] [PATCH 0/3] Add dpif support for ct_clear action

("openvswitch: add ct_clear action"). travis-ci: https://travis-ci.org/erig0/ovs/builds/290487503 Eric Garver (3): dpif: Add support for OVS_ACTION_ATTR_CT_CLEAR system-common-macros: Check for ct_clear action in datapath system-traffic: Add conntrack floating IP test datapath/li

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Set suitable value to ovs geneve and vxlan interfaces' mtu.

On Tue, Oct 17, 2017 at 05:53:37PM +0800, JunhanYan wrote: > From af5c8a50141c7e1a7723a7f992a9e71ad531274d Mon Sep 17 00:00:00 2001 > From: JunhanYan > Date: Tue, 17 Oct 2017 17:26:20 +0800 > Subject: [PATCH] In ovs mtu of ovs geneve interface genev_sys_6081 is always > 0x,

[ovs-dev] [PATCH net-next v2] openvswitch: add ct_clear action

This adds a ct_clear action for clearing conntrack state. ct_clear is currently implemented in OVS userspace, but is not backed by an action in the kernel datapath. This is useful for flows that may modify a packet tuple after a ct lookup has already occurred. Signed-off-by: Eric Garver &l

Re: [ovs-dev] [PATCH net-next] openvswitch: add ct_clear action

On Tue, Oct 10, 2017 at 10:24:20AM -0700, Joe Stringer wrote: > On 10 October 2017 at 08:09, Eric Garver <e...@erig.me> wrote: > > On Tue, Oct 10, 2017 at 05:33:48AM -0700, Joe Stringer wrote: > >> On 9 October 2017 at 21:41, Pravin Shelar <pshe...@ovn.org> wrote: &

Re: [ovs-dev] [PATCH net-next] openvswitch: add ct_clear action

On Tue, Oct 10, 2017 at 05:33:48AM -0700, Joe Stringer wrote: > On 9 October 2017 at 21:41, Pravin Shelar <pshe...@ovn.org> wrote: > > On Fri, Oct 6, 2017 at 9:44 AM, Eric Garver <e...@erig.me> wrote: > >> This adds a ct_clear action for clearing conntrack sta

Re: [ovs-dev] [PATCH net-next] openvswitch: add ct_clear action

On Mon, Oct 09, 2017 at 09:41:53PM -0700, Pravin Shelar wrote: > On Fri, Oct 6, 2017 at 9:44 AM, Eric Garver <e...@erig.me> wrote: > > This adds a ct_clear action for clearing conntrack state. ct_clear is > > currently implemented in OVS userspace, but is not backed by an act

[ovs-dev] [PATCH net-next] openvswitch: add ct_clear action

This adds a ct_clear action for clearing conntrack state. ct_clear is currently implemented in OVS userspace, but is not backed by an action in the kernel datapath. This is useful for flows that may modify a packet tuple after a ct lookup has already occurred. Signed-off-by: Eric Garver &l

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

On Tue, Sep 26, 2017 at 01:02:15PM +0800, Yang, Yi wrote: > On Tue, Sep 26, 2017 at 03:28:42AM +0800, Eric Garver wrote: > > On Mon, Sep 25, 2017 at 10:16:09PM +0800, Yi Yang wrote: > > > + > > > + length = nsh_hdr_len(nsh_hdr); > > > + skb_pull(skb, length); &g

Re: [ovs-dev] [PATCH net-next v4] openvswitch: enable NSH support

On Fri, Aug 18, 2017 at 03:24:31PM +0800, Yi Yang wrote: > v3->v4 > - Add new NSH match field ttl > - Update NSH header to the latest format >which will be final format and won't change >per its author's confirmation. > - Fix comments for v3. Hi Yi, Only a few comments below since Jiri

Re: [ovs-dev] [PATCH] nsh: rework NSH netlink keys and actions

On Thu, Aug 17, 2017 at 12:04:25PM +, Jan Scheurich wrote: > Hi Yi, > > As discussed please adjust the netlink uAPI for NSH as follows: > > OVS_KEY_ATTR_NSH > -- OVS_NSH_KEY_ATTR_BASE mandatory > -- OVS_NSH_KEY_ATTR_MD1 conditional: if mdtype=MD1 > >

Re: [ovs-dev] [PATCH v3] openvswitch: enable NSH support

On Thu, Aug 17, 2017 at 07:49:41AM +0800, Yang, Yi wrote: > On Wed, Aug 16, 2017 at 11:15:28PM +0800, Eric Garver wrote: > > On Wed, Aug 16, 2017 at 01:35:30PM +0800, Yi Yang wrote: > > > + > > > +#define NSH_DST_PORT4790 /* UDP Port for NSH on VXLAN.

Re: [ovs-dev] [PATCH v3] openvswitch: enable NSH support

On Wed, Aug 16, 2017 at 01:35:30PM +0800, Yi Yang wrote: > v2->v3 > - Change OVS_KEY_ATTR_NSH to nested key to handle >length-fixed attributes and length-variable >attriubte more flexibly. > - Remove struct ovs_action_push_nsh completely > - Add code to handle nested attribute for

Re: [ovs-dev] [PATCH net-next v2] openvswitch: enable NSH support

On Thu, Aug 10, 2017 at 09:21:15PM +0800, Yi Yang wrote: > OVS master and 2.8 branch has merged NSH userspace > patch series, this patch is to enable NSH support > in kernel data path in order that OVS can support > NSH in 2.8 release in compat mode by porting this. > > Signed-off-by: Yi Yang

[ovs-dev] [PATCH] dpif-netlink-rtnl: Fix VXLAN port create for regular VXLAN

there. Fixes: c33c412fb139 ("dpif-netlink-rtnl: Support VXLAN-GPE") Fixes: 825e45e0109f ("dpif-netlink-rtnl: Support VXLAN creation") Reported-by: Joe Stringer <j...@ovn.org> Signed-off-by: Eric Garver <e...@erig.me> --- lib/dpif-netlink-rtnl.c | 3 ++- 1 file changed, 2 in

Re: [ovs-dev] [PATCH V2] dpif-netlink: Fix log level for error message

: %s", > netdev_get_name(netdev), ovs_strerror(error)); > } > return error; > -- > 2.7.4 > Acked-by: Eric Garver <e...@erig.me> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] dpif-netlink: Fix log level for error message

On Thu, Jul 27, 2017 at 10:17:48AM -0700, Joe Stringer wrote: > On 27 July 2017 at 05:43, Eric Garver <e...@erig.me> wrote: > > On Thu, Jul 27, 2017 at 10:27:18AM +0300, Roi Dayan wrote: > >> Since it's an error message log it with VLOG_ERR instead of VLOG_INFO. > >&

Re: [ovs-dev] [PATCH] dpif-netlink: Fix log level for error message

On Thu, Jul 27, 2017 at 10:27:18AM +0300, Roi Dayan wrote: > Since it's an error message log it with VLOG_ERR instead of VLOG_INFO. > > Signed-off-by: Roi Dayan > --- > lib/dpif-netlink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

<    1   2   3   4   >