[ovs-dev] [PATCH 1/1] debian: Do not modify pre-existing defaults file

2017-10-17 Thread Frode Nordahl
of the [Debian Policy](https://www.debian.org/doc/debian-policy/#s-config-files). This commit addresses this by removing the part of the postinst script that attempts to append missing documentation parts of the template and leaves the installed defaults file alone when it exists. Signed-off-by: Frode

[ovs-dev] [PATCH ovn] docs: Add note about RBAC and remote ovn-northd connection

2019-11-07 Thread Frode Nordahl
Signed-off-by: Frode Nordahl Acked-by: Aliasgar Ginwala Submitted-at: https://github.com/ovn-org/ovn/pull/25 --- .../topics/role-based-access-control.rst | 7 ++ Documentation/tutorials/ovn-rbac.rst | 25 +++ 2 files changed, 32 insertions(+) diff --git

Re: [ovs-dev] [PATCH ovn v2] northd: Add `is-active` management command

2019-11-17 Thread Frode Nordahl
On Mon, Nov 18, 2019 at 8:11 AM Numan Siddique wrote: > > On Sat, Nov 16, 2019 at 2:46 AM Frode Nordahl > wrote: > > > > When ovn-northd is connected to clustered OVN DB servers a OVSDB > > locking feature is used to ensure only one ovn-northd process is > > act

[ovs-dev] [PATCH ovn v3] northd: Add `status` management command

2019-11-18 Thread Frode Nordahl
Allow the operator to query whether a ovn-northd process is currently active for the standalone and clustered DB use case. At present this information is only available in the log. Signed-off-by: Frode Nordahl --- northd/ovn-northd.8.xml | 9 - northd/ovn-northd.c | 20

[ovs-dev] [PATCH ovn] northd: Add `is-active` management command

2019-11-15 Thread Frode Nordahl
or not. At present this information is only available in the log. Signed-off-by: Frode Nordahl --- northd/ovn-northd.8.xml | 19 +++ northd/ovn-northd.c | 18 +- 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/northd/ovn-northd.8.xml b/northd/ovn-northd.8.xml

[ovs-dev] [PATCH ovn v2] northd: Add `is-active` management command

2019-11-15 Thread Frode Nordahl
or not. At present this information is only available in the log. Signed-off-by: Frode Nordahl --- northd/ovn-northd.8.xml | 19 +++ northd/ovn-northd.c | 18 +- 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/northd/ovn-northd.8.xml b/northd/ovn-northd.8.xml

Re: [ovs-dev] [PATCH ovn] docs: Add note about RBAC and remote ovn-northd connection

2019-11-08 Thread Frode Nordahl
On Fri, Nov 8, 2019 at 11:56 AM Numan Siddique wrote: > > On Fri, Nov 8, 2019 at 11:22 AM Frode Nordahl > wrote: > > > > Signed-off-by: Frode Nordahl > > Acked-by: Aliasgar Ginwala > > Submitted-at: https://github.com/ovn-org/ovn/pull/25 > > I applied

[ovs-dev] [PATCH ovn v2 0/2] northd: Improve pause, resume and status

2019-11-22 Thread Frode Nordahl
work both for the current code and the proposed code. Travis passed: https://travis-ci.org/fnordahl/ovn/builds/615446047 Frode Nordahl (2): northd: Amend ovn-northd pause resume test northd: Improve handling of pause and resume northd/ovn-northd.8.xml | 9 +++-- northd/ovn-northd.c | 87

[ovs-dev] [PATCH ovn v2 2/2] northd: Improve handling of pause and resume

2019-11-22 Thread Frode Nordahl
status command test into the pause and resume tests. Signed-off-by: Frode Nordahl --- northd/ovn-northd.8.xml | 9 +++-- northd/ovn-northd.c | 87 +++-- tests/ovn-northd.at | 24 +++- 3 files changed, 79 insertions(+), 41 deletions(-) diff

[ovs-dev] [PATCH ovn v2 1/2] northd: Amend ovn-northd pause resume test

2019-11-22 Thread Frode Nordahl
The current pause and resume tests rely on that ``ovn-northd`` will hold on to the lock while paused. Update the test to pause both ``ovn-northd`` instances so we may change this behaviour. Replace references to ``ovs-appctl`` with ``ovn-appctl``. Signed-off-by: Frode Nordahl --- tests/ovn

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Improve handling of pause and resume

2019-11-22 Thread Frode Nordahl
Ok, this time I am at a loss of what's wrong with the submission, I would kindly request reviews of the submission as-is while I figure out my grievances with the bot. -- Frode Nordahl On Fri, Nov 22, 2019 at 4:03 PM 0-day Robot wrote: > > Bleep bloop. Greetings Frode Nordahl, I am a

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Improve handling of pause and resume

2019-11-22 Thread Frode Nordahl
fre. 22. nov. 2019, 19:10 skrev Numan Siddique : > On Fri, Nov 22, 2019 at 8:22 PM Frode Nordahl > wrote: > > > > Move paused state to ``struct northd_context`` and pass the > > context to paused and status command handlers. > > > > On pause release the OVSD

[ovs-dev] [PATCH ovn v3 2/2] northd: Improve handling of pause and resume

2019-11-23 Thread Frode Nordahl
', and 'standby' states. Merge separate status command test into the pause and resume tests. Signed-off-by: Frode Nordahl --- northd/ovn-northd.8.xml | 9 +++-- northd/ovn-northd.c | 89 +++-- tests/ovn-northd.at | 24 ++- 3 files changed, 80 insertions

[ovs-dev] [PATCH ovn v3 0/2] northd: Improve pause, resume and status

2019-11-23 Thread Frode Nordahl
work both for the current code and the proposed code. Travis passed: https://travis-ci.org/fnordahl/ovn/builds/615918643 Note that the failure in job 5.11 has it's origin from upstream openvswitch where the tests appear to fail on master atm. Frode Nordahl (2): northd: Amend ovn-northd pause

[ovs-dev] [PATCH ovn v3 1/2] northd: Amend ovn-northd pause resume test

2019-11-23 Thread Frode Nordahl
The current pause and resume tests rely on that ``ovn-northd`` will hold on to the lock while paused. Update the test to pause both ``ovn-northd`` instances so we may change this behaviour. Replace references to ``ovs-appctl`` with ``ovn-appctl``. Signed-off-by: Frode Nordahl --- tests/ovn

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Improve handling of pause and resume

2019-11-23 Thread Frode Nordahl
to request reviews regardless of the robots remarks :-) -- Frode Nordahl On Sat, Nov 23, 2019 at 10:58 AM 0-day Robot wrote: > > Bleep bloop. Greetings Frode Nordahl, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some e

Re: [ovs-dev] [PATCH ovn v3] northd: Add `status` management command

2019-11-20 Thread Frode Nordahl
On Wed, Nov 20, 2019 at 2:20 PM Numan Siddique wrote: > > On Wed, Nov 20, 2019 at 3:10 PM Frode Nordahl > wrote: > > > > Hello Numan, > > > > Have you had a chance to take a look at my updated proposal? > > > > Based on your feedback of `is-active` co

Re: [ovs-dev] [PATCH ovn v3] northd: Add `status` management command

2019-11-20 Thread Frode Nordahl
change. What do you think? https://patchwork.ozlabs.org/patch/1196828/ -- Frode Nordahl On Mon, Nov 18, 2019 at 4:44 PM Frode Nordahl wrote: > > Allow the operator to query whether a ovn-northd process is > currently active for the standalone and clustered DB use case. >

Re: [ovs-dev] [PATCH ovn v3 0/2] northd: Improve pause, resume and status

2019-11-26 Thread Frode Nordahl
On Wed, Nov 27, 2019 at 8:34 AM Numan Siddique wrote: > > On Sat, Nov 23, 2019 at 3:20 PM Frode Nordahl > wrote: > > > > At present when the ``pause`` command is issued any lock the > > ``ovn-northd`` process holds on the SB DB will be kept. > > > > To be

[ovs-dev] [PATCH ovn 1/2] northd: Pause both ovn-northd instances in pause resume test

2019-11-22 Thread Frode Nordahl
The current pause and resume tests rely on that ``ovn-northd`` will hold on to the lock while paused. Update the test to pause both ``ovn-northd`` instances so we may change this behaviour. Replace references to ``ovs-appctl`` with ``ovn-appctl``. Signed-off-by: Frode Nordahl --- tests/ovn

[ovs-dev] [PATCH ovn 0/2] northd: Improve pause, resume and status

2019-11-22 Thread Frode Nordahl
work both for the current code and the proposed code. Travis passed: https://travis-ci.org/fnordahl/ovn/builds/615446047 Frode Nordahl (2): northd: Pause both ovn-northd instances in pause resume test northd: Improve handling of pause and resume northd/ovn-northd.8.xml | 9 +++-- northd/ovn

Re: [ovs-dev] [PATCH ovn 2/2] northd: Improve handling of pause and resume

2019-11-22 Thread Frode Nordahl
This is weird, the patches apply on an up-to-date ovn repo with git am on blobs from the list. I noticed the mailing list thread order is in reverse with patch number two preceding patch number one, could that be the issue? -- Frode Nordahl On Fri, Nov 22, 2019 at 10:59 AM 0-day Robot wrote

Re: [ovs-dev] [PATCH ovn 2/2] northd: Improve handling of pause and resume

2019-11-22 Thread Frode Nordahl
On Fri, Nov 22, 2019 at 11:12 AM Frode Nordahl wrote: > > This is weird, the patches apply on an up-to-date ovn repo with git am > on blobs from the list. > > I noticed the mailing list thread order is in reverse with patch > number two preceding patch number one, could that be

Re: [ovs-dev] [PATCH ovn 2/2] northd: Improve handling of pause and resume

2019-11-22 Thread Frode Nordahl
On Fri, Nov 22, 2019 at 11:46 AM Frode Nordahl wrote: > > On Fri, Nov 22, 2019 at 11:12 AM Frode Nordahl > wrote: > > > > This is weird, the patches apply on an up-to-date ovn repo with git am > > on blobs from the list. > > > > I noticed the mailing lis

[ovs-dev] [PATCH ovn 2/2] northd: Improve handling of pause and resume

2019-11-22 Thread Frode Nordahl
status command test into the pause and resume tests. Signed-off-by: Frode Nordahl --- northd/ovn-northd.8.xml | 9 +++-- northd/ovn-northd.c | 87 +++-- tests/ovn-northd.at | 24 +++- 3 files changed, 79 insertions(+), 41 deletions(-) diff

[ovs-dev] [PATCH ovn] ovn-controller: No bridge for localnet port is not an error

2020-02-27 Thread Frode Nordahl
. This may be some chassis or all chassis depending on end user requirements. At present `ovn-controller` will repeatedly log an error on chassis without mapping for a localnet port while in reality it is not an error. Sined-off-by: Frode Nordahl --- controller/patch.c | 7 ++- 1 file changed

[ovs-dev] [PATCH ovn v2] ovn-controller: No bridge for localnet port is not an error

2020-02-27 Thread Frode Nordahl
. This may be some chassis or all chassis depending on end user requirements. At present `ovn-controller` will repeatedly log an error on chassis without mapping for a localnet port while in reality it is not an error. Signed-off-by: Frode Nordahl --- controller/patch.c | 7 ++- 1 file changed

Re: [ovs-dev] OVN 20.03.0 Release: Final call for patches

2020-02-28 Thread Frode Nordahl
/ as I imagine it could be a source for confusion and unnecessary bug reports. I also recognize how late it was posted, so no worries if you deem it not for inclusion at this time :-) FWIW, we're tracking it here: https://bugs.launchpad.net/ubuntu/+source/ovn/+bug/1865127 Cheers! -- Frode Nordahl &g

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: No bridge for localnet port is not an error

2020-02-28 Thread Frode Nordahl
On Fri, Feb 28, 2020 at 5:53 PM Numan Siddique wrote: > > On Thu, Feb 27, 2020 at 6:46 PM Frode Nordahl > wrote: > > > > There is a pattern among CMSes to create a `localnet` port > > binding without any chassis affiliation. > > > > It is then up to the

Re: [ovs-dev] [PATCH ovn v3] debian: fix debian packaging and remove ovs files

2020-12-18 Thread Frode Nordahl
='--with-ovs-source=path/to/ovs' > > DEB_BUILD_OPTIONS='parallel=8 nocheck' fakeroot debian/rules binary > > > > Signed-off-by: Wan Junjie > > Thanks for the patch. > > @Frode Nordahl Would you be fine reviewing this patch. > Sure I'll take a look, it may take some

[ovs-dev] [PATCH ovn] northd: Add Chassis_Private "external_ids" column to RBAC

2021-01-25 Thread Frode Nordahl
/blob/master/neutron/agent/ovn/metadata/agent.py#L175-L191 Reported-at: https://bugs.launchpad.net/bugs/1913024 Fixes: 4adc10f58127 ("Avoid nb_cfg update notification flooding") Signed-off-by: Frode Nordahl --- northd/ovn-northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[ovs-dev] [PATCH ovn] docs: Update information about OVN Patchwork Instance

2021-01-27 Thread Frode Nordahl
As per [0] the OVN project now has a separate Patchwork Instance, let's reflect that fact in the documentation. 0: https://mail.openvswitch.org/pipermail/ovs-dev/2020-September/374317.html Signed-off-by: Frode Nordahl --- Documentation/faq/contributing.rst| 12 ++-- Documentation

Re: [ovs-dev] [PATCH ovn] northd: Add Chassis_Private "external_ids" column to RBAC

2021-01-27 Thread Frode Nordahl
On Wed, Jan 27, 2021 at 11:52 AM Dumitru Ceara wrote: > > On 1/25/21 9:34 PM, Frode Nordahl wrote: > > After introduction of the Chassis_Private table in OVN 20.09, CMS'es do > > expect data plane components that may be subject to the > > `ovn-controller` RBAC

Re: [ovs-dev] [RFC PATCH ovn] Introduce representor port plugging support

2021-06-10 Thread Frode Nordahl
On Thu, Jun 10, 2021 at 1:46 PM Ilya Maximets wrote: > > On 6/10/21 8:36 AM, Han Zhou wrote: > > > > > > On Thu, May 13, 2021 at 9:25 AM Frode Nordahl > <mailto:frode.nord...@canonical.com>> wrote: > >> > >> On Thu, May 13, 2021 at 5:12 P

Re: [ovs-dev] [RFC PATCH ovn] Introduce representor port plugging support

2021-05-13 Thread Frode Nordahl
On Thu, May 13, 2021 at 5:12 PM Ilya Maximets wrote: > > On 5/9/21 4:03 PM, Frode Nordahl wrote: > > Introduce plugging module that adds and removes ports on the > > integration bridge, as directed by Port_Binding options. > > > > Traditionally it has been the

Re: [ovs-dev] [PATCH ovn v1 1/1] ovn-controller: Ensure br-int is using secure fail-mode

2021-05-07 Thread Frode Nordahl
ged, I wonder if the text could be rephrased. As it stands it could read as having br-int in secure fail-mode is a undesirable situation, whereas the opposite is true. + } > } > if (br_int && ovs_idl_txn) { > const struct ovsrec_open_vswitch *cfg; > -- > 2.

[ovs-dev] [RFC PATCH ovn] Introduce representor port plugging support

2021-05-09 Thread Frode Nordahl
CI VPD, or a value stored in the local Open vSwitch database maintained by the operator. * Write tests. * Update documentation. Signed-off-by: Frode Nordahl --- controller/automake.mk | 2 + controller/binding.c| 17 +- controller/lport.c | 9 + controller/l

Re: [ovs-dev] [PATCH ovn v1 1/1] ovn-controller: Ensure br-int is using secure fail-mode

2021-05-07 Thread Frode Nordahl
On Fri, May 7, 2021 at 3:23 PM Flavio Fernandes wrote: > On May 7, 2021, at 3:02 AM, Frode Nordahl wrote: > fre. 7. mai 2021, 03:22 skrev Flavio Fernandes : >> diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c >> index 6106a9661..e4cbf3583 100644 >&

[ovs-dev] [PATCH] lib: Introduce netlink-devlink library

2021-05-05 Thread Frode Nordahl
-specs/+/788821 Signed-off-by: Frode Nordahl --- include/linux/automake.mk | 1 + include/linux/devlink.h | 625 ++ include/openvswitch/types.h | 8 + lib/automake.mk | 2 + lib/netlink-devlink.c | 498

[ovs-dev] [PATCH v2] lib: Introduce netlink-devlink library

2021-05-06 Thread Frode Nordahl
-specs/+/788821 Signed-off-by: Frode Nordahl --- include/linux/automake.mk | 1 + include/linux/devlink.h | 625 ++ include/openvswitch/types.h | 8 + lib/automake.mk | 2 + lib/netlink-devlink.c | 499

Re: [ovs-dev] [PATCH ovn v2 1/1] ovn-controller: Ensure br-int is using secure fail-mode

2021-05-07 Thread Frode Nordahl
br_int, datapath_type); > } > +if (!br_int->fail_mode || strcmp(br_int->fail_mode, "secure")) { > +ovsrec_bridge_set_fail_mode(br_int, "secure"); > +VLOG_WARN("Integration bridge fail-mode changed to > 'secure'

Re: [ovs-dev] [ovs-discuss] Moving of the primary #openvswitch channel to irc.libera.chat ?

2021-05-26 Thread Frode Nordahl
er picture. Our, and some 700 other channels, were just taken over for advertising other IRC networks in topic (see attached screenshot). I think this is the cue to leave Freenode. -- Frode Nordahl > I hope it helps, > Ihar > > On Wed, May 19, 2021 at 4:04 PM Ilya Maximets wrote: &

Re: [ovs-dev] [RFC PATCH ovn] Introduce representor port plugging support

2021-07-08 Thread Frode Nordahl
On Wed, Jul 7, 2021 at 8:30 AM Frode Nordahl wrote: > > On Tue, Jul 6, 2021 at 8:11 PM Han Zhou wrote: > > > > > > > > On Tue, Jul 6, 2021 at 1:19 AM Frode Nordahl > > wrote: > > > > > > On Mon, Jul 5, 2021 at 6:57 PM Numan Siddique wrote:

Re: [ovs-dev] [RFC PATCH ovn] Introduce representor port plugging support

2021-07-05 Thread Frode Nordahl
On Wed, Jun 30, 2021 at 12:32 AM Numan Siddique wrote: > > On Thu, Jun 10, 2021 at 10:13 AM Frode Nordahl > wrote: > > > > On Thu, Jun 10, 2021 at 1:46 PM Ilya Maximets wrote: > > > > > > On 6/10/21 8:36 AM, Han Zhou wrote: > > > > > >

Re: [ovs-dev] [RFC PATCH ovn] Introduce representor port plugging support

2021-07-07 Thread Frode Nordahl
On Tue, Jul 6, 2021 at 8:11 PM Han Zhou wrote: > > > > On Tue, Jul 6, 2021 at 1:19 AM Frode Nordahl > wrote: > > > > On Mon, Jul 5, 2021 at 6:57 PM Numan Siddique wrote: > > > > > > On Mon, Jul 5, 2021 at 12:12 PM Frode Nordahl > > > w

Re: [ovs-dev] [RFC PATCH ovn] Introduce representor port plugging support

2021-07-09 Thread Frode Nordahl
On Thu, Jul 8, 2021 at 11:58 AM Frode Nordahl wrote: > > On Wed, Jul 7, 2021 at 8:30 AM Frode Nordahl > wrote: > > > > On Tue, Jul 6, 2021 at 8:11 PM Han Zhou wrote: > > > > > > > > > > > > On Tue, Jul 6, 2021 at 1:19 AM Frode Nordahl

Re: [ovs-dev] [RFC PATCH ovn] Introduce representor port plugging support

2021-07-06 Thread Frode Nordahl
On Mon, Jul 5, 2021 at 6:57 PM Numan Siddique wrote: > > On Mon, Jul 5, 2021 at 12:12 PM Frode Nordahl > wrote: > > > > On Wed, Jun 30, 2021 at 12:32 AM Numan Siddique wrote: > > > > > > On Thu, Jun 10, 2021 at 10:13 AM Frode Nordahl > > > wrote:

Re: [ovs-dev] [PATCH ovn] Add IGMP_Group to ovn-controller RBAC

2021-02-11 Thread Frode Nordahl
Thank you Pedro, We built a test package [0] with this patch and received confirmation it solved the problem. Acked-by: Frode Nordahl 0: https://bugs.launchpad.net/ubuntu/+source/ovn/+bug/1914988 On Thu, Feb 11, 2021 at 10:55 AM Pedro Guimaraes wrote: > > If RBAC and IGMP sn

Re: [ovs-dev] [PATCH ovn v2 6/9] tests: Amend release stale port binding test for RBAC

2021-03-23 Thread Frode Nordahl
kported? I can take care of all the merges > at the same time once I get this info. Numan already did the required backports for patches 1-5 so we should be good there. Would be great to get the tests into master. Cheers! -- Frode Nordahl > Thanks. > > On 3/5/21 7:16 AM, Frode No

Re: [ovs-dev] [PATCH ovn v2 6/9] tests: Amend release stale port binding test for RBAC

2021-03-24 Thread Frode Nordahl
s/testpki-main-cert.pem] Error 1 > make[2]: Leaving directory '/tmp/ovn/_gcc' Thank you for finding this issue, as it hid itself from me when checking with a plain `make distcheck`. I'll investigate and put up a v3. -- Frode Nordahl > Thanks > Numan > > > > > > --

[ovs-dev] [RFC PATCH] lib: Introduce netlink-devlink library

2021-03-23 Thread Frode Nordahl
://github.com/torvalds/linux/blob/master/Documentation/networking/devlink/devlink-info.rst TODO: - Polish a small (non-install) utility that can be used for testing dump and monitoring of devlink changes. - Write tests Signed-off-by: Frode Nordahl --- acinclude.m4| 80

Re: [ovs-dev] [PATCH ovn v2 6/9] tests: Amend release stale port binding test for RBAC

2021-03-25 Thread Frode Nordahl
On Wed, Mar 24, 2021 at 2:32 PM Frode Nordahl wrote: > > On Wed, Mar 24, 2021 at 1:54 PM Numan Siddique wrote: > > I applied the patches 6 and 7 to the main branch. > > > > There are some issues with patch 9. I didn't apply patch 8 as it > > seems related to patch

Re: [ovs-dev] [PATCH ovn v2 6/9] tests: Amend release stale port binding test for RBAC

2021-03-29 Thread Frode Nordahl
On Thu, Mar 25, 2021 at 2:39 PM Frode Nordahl wrote: > > On Wed, Mar 24, 2021 at 2:32 PM Frode Nordahl > wrote: > > > > On Wed, Mar 24, 2021 at 1:54 PM Numan Siddique wrote: > > > I applied the patches 6 and 7 to the main branch. > > > > > > The

Re: [ovs-dev] [RFC PATCH] lib: Introduce netlink-devlink library

2021-03-23 Thread Frode Nordahl
On Tue, Mar 23, 2021 at 5:23 PM Ben Pfaff wrote: > > On Tue, Mar 23, 2021 at 03:50:32PM +0100, Frode Nordahl wrote: > > The devlink interface was introduced [0] in the Linux 4.6 time > > frame and has since gained traction among multiple hardware > > vendors. >

Re: [ovs-dev] [PATCH ovn branch-20.03 01/16] ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb

2021-03-11 Thread Frode Nordahl
On Thu, Mar 11, 2021 at 4:12 PM Frode Nordahl wrote: > > On Thu, Mar 11, 2021 at 1:14 PM Ilya Maximets wrote: > > > > On 3/3/21 2:19 PM, Frode Nordahl wrote: > > > > > > > > >> > > >>> --- > > >>> utilities/ovn-ctl |

[ovs-dev] [PATCH ovn branch-20.03 v2 0/2] Fix broken backport of ovn-ctl

2021-03-11 Thread Frode Nordahl
: https://mail.openvswitch.org/pipermail/ovs-dev/2021-February/380497.html Frode Nordahl (1): Revert "ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb" Numan Siddique (1): ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb utilities/ovn-ctl | 2 +- 1 file changed, 1 inser

[ovs-dev] [PATCH ovn branch-20.03 v2 1/2] Revert "ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb"

2021-03-11 Thread Frode Nordahl
This reverts commit dce49ab7bf0365e50e9660098f743b340d444fbe. Signed-off-by: Frode Nordahl --- utilities/ovn-ctl | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl index 7285c0533..c7cb42bc1 100755 --- a/utilities/ovn

[ovs-dev] [PATCH ovn branch-20.03 v2 2/2] ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb

2021-03-11 Thread Frode Nordahl
67e2f386cc838d0b0f9b4b5da7fe611e1113b70c) (adapted to not use `start_wrapped_daemon` which does not exist in branch-20.03) Signed-off-by: Frode Nordahl --- utilities/ovn-ctl | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl index c7cb42bc1

[ovs-dev] [PATCH ovn branch-20.06 v2 0/2] Fix broken backport of ovn-ctl

2021-03-11 Thread Frode Nordahl
: https://mail.openvswitch.org/pipermail/ovs-dev/2021-February/380480.html Frode Nordahl (1): Revert "ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb" Numan Siddique (1): ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb utilities/ovn-ctl | 2 +- 1 file changed, 1 inser

[ovs-dev] [PATCH ovn branch-20.06 v2 1/2] Revert "ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb"

2021-03-11 Thread Frode Nordahl
This reverts commit 3ee3d4ee41c19df7e700d59950ceb8816686c0fd. Signed-off-by: Frode Nordahl --- utilities/ovn-ctl | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl index ad8e6bb04..8afe68a0a 100755 --- a/utilities/ovn

[ovs-dev] [PATCH ovn branch-20.06 v2 2/2] ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb

2021-03-11 Thread Frode Nordahl
67e2f386cc838d0b0f9b4b5da7fe611e1113b70c) (adapted to not use `start_wrapped_daemon` which does not exist in branch-20.06) Signed-off-by: Frode Nordahl --- utilities/ovn-ctl | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl index 8afe68a0a

Re: [ovs-dev] [PATCH ovn branch-20.03 01/16] ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb

2021-03-11 Thread Frode Nordahl
On Thu, Mar 11, 2021 at 1:14 PM Ilya Maximets wrote: > > On 3/3/21 2:19 PM, Frode Nordahl wrote: > > > > >> > >>> --- > >>> utilities/ovn-ctl | 20 +++- > >>> 1 file changed, 19 insertions(+), 1 deletion(-) &g

[ovs-dev] [PATCH] python: Check for SSL as well as socet errors

2021-03-16 Thread Frode Nordahl
d.net/bugs/1907686 Signed-off-by: Frode Nordahl --- python/ovs/socket_util.py | 27 +-- python/ovs/stream.py | 8 2 files changed, 21 insertions(+), 14 deletions(-) diff --git a/python/ovs/socket_util.py b/python/ovs/socket_util.py index 3faa64e9d..96d1db

Re: [ovs-dev] [PATCH] python: Check for SSL as well as socet errors

2021-03-16 Thread Frode Nordahl
On Tue, Mar 16, 2021 at 2:01 PM Ilya Maximets wrote: > > On 3/16/21 1:39 PM, Frode Nordahl wrote: > > When connected to a OVSDB server with a SSL stream calls to > > functions dealing with sockets may raise SSL.SysCallError > > Exception in addition to the socket.error

Re: [ovs-dev] [PATCH ovn] northd: Amend RBAC rules for Port_Binding table

2021-03-11 Thread Frode Nordahl
On Tue, Mar 2, 2021 at 7:29 PM Numan Siddique wrote: > > On Tue, Mar 2, 2021 at 11:39 PM Frode Nordahl > wrote: > > > > On Tue, Mar 2, 2021 at 6:55 PM Numan Siddique wrote: > > > > > > On Tue, Mar 2, 2021 at 10:54 PM Frode Nordahl > > > wro

[ovs-dev] [PATCH ovn] northd: Amend RBAC rules for Port_Binding table

2021-03-02 Thread Frode Nordahl
: https://github.com/ovn-org/ovn/blob/b7b0fbdab03ce8b39d5bdc114876e6b0d0683892/controller/pinctrl.c#L6150 Fixes: 054f4c85c ("Add a new logical switch port type - 'virtual'") Reported-At: https://bugs.launchpad.net/ubuntu/+source/ovn/+bug/1917475 Signed-off-by: Frode Nordahl --- northd/ovn-no

Re: [ovs-dev] [PATCH ovn] northd: Amend RBAC rules for Port_Binding table

2021-03-02 Thread Frode Nordahl
On Tue, Mar 2, 2021 at 6:55 PM Numan Siddique wrote: > > On Tue, Mar 2, 2021 at 10:54 PM Frode Nordahl > wrote: > > > > When `ovn-controller` claims a virtual lport it will update the > > Port_Binding table with which chassis currently has claimed the > > port

[ovs-dev] [PATCH v2] ovs-ctl: Allow recording hostname separately

2021-02-25 Thread Frode Nordahl
recording the hostname in the database as well as a new ctl command to record the hostname separately. This command can be called by the system startup scripts when the system is ready to collect and record this information. Reported-At: https://bugs.launchpad.net/bugs/1915829 Signed-off-by: Frode

Re: [ovs-dev] [PATCH] ovs-ctl: Allow recording hostname separately

2021-02-25 Thread Frode Nordahl
On Thu, Feb 25, 2021 at 1:33 PM Ilya Maximets wrote: > > On 2/25/21 6:56 AM, Frode Nordahl wrote: > > On Wed, Feb 24, 2021 at 5:36 PM Ilya Maximets wrote: > >> > >> On 2/19/21 9:10 AM, Christian Ehrhardt wrote: > >>> On Tue, Feb 16, 2021 at 5:32 PM Fro

Re: [ovs-dev] [PATCH v2] ovs-ctl: Allow recording hostname separately

2021-03-01 Thread Frode Nordahl
On Mon, Mar 1, 2021 at 9:26 PM Ilya Maximets wrote: > > On 2/25/21 4:28 PM, Frode Nordahl wrote: > > ovs-ctl determines the system FQDN or hostname and records it in > > the `external-ids:hostname` field of the `Open-vSwitch` table on > > system startup

Re: [ovs-dev] [PATCH ovn branch-20.03 01/16] ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb

2021-03-03 Thread Frode Nordahl
On Tue, Mar 2, 2021 at 7:35 PM Numan Siddique wrote: > > On Thu, Feb 18, 2021 at 2:21 PM Frode Nordahl > wrote: > > > > From: Numan Siddique > > > > when ovn-ctl run_(nb_sb)_ovsdb is called, the ovsdb-server is started > > without > > passing --de

Re: [ovs-dev] [PATCH] ovs-ctl: Allow recording hostname separately

2021-02-24 Thread Frode Nordahl
On Wed, Feb 24, 2021 at 5:36 PM Ilya Maximets wrote: > > On 2/19/21 9:10 AM, Christian Ehrhardt wrote: > > On Tue, Feb 16, 2021 at 5:32 PM Frode Nordahl > > wrote: > >> > >> ovs-ctl determines the system FQDN or hostname and records it in > >> t

[ovs-dev] [PATCH ovn v2 3/9] northd: Amend Chassis RBAC rules

2021-03-05 Thread Frode Nordahl
The Transport Zones support does currently not work when RBAC is enabled. Fixes: 07d0d258d ("OVN: Add support for Transport Zones") Signed-off-by: Frode Nordahl --- northd/ovn-northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/northd/ovn-northd.c b/northd/ov

[ovs-dev] [PATCH ovn v2 5/9] northd-ddlog: Update RBAC rules

2021-03-05 Thread Frode Nordahl
This patch summarizes a series of fixes to the C northd for missing or out of date RBAC rules and updates the DDlog version of Northd accordingly. Signed-off-by: Frode Nordahl --- northd/ovn_northd.dl | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [PATCH ovn v2 0/9] Fix missing RBAC rules and enable testing

2021-03-05 Thread Frode Nordahl
essful testrun can be viewed at [0], in addittion I have done local testing with ovn-northd-ddlog. 0: https://github.com/fnordahl/ovn/actions/runs/624324890 Frode Nordahl (9): northd: Amend RBAC rules for Port_Binding table northd: Add missing RBAC rules for FDB table northd: Amend Chassi

[ovs-dev] [PATCH ovn v2 4/9] northd: Add Controller_Event RBAC rules

2021-03-05 Thread Frode Nordahl
The use of the Controller_Event table does currently not work when RBAC is enabled. Fixes: be1eeb09d ("OVN: introduce Controller_Event table") Signed-off-by: Frode Nordahl --- northd/ovn-northd.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/northd/ovn-northd.

[ovs-dev] [PATCH ovn v2 7/9] tests: Use ovn_start in tests/ovn-controller.at

2021-03-05 Thread Frode Nordahl
to 'ovn-controller - Chassis other_config' test. Signed-off-by: Frode Nordahl --- tests/ovn-controller.at | 50 - 1 file changed, 44 insertions(+), 6 deletions(-) diff --git a/tests/ovn-controller.at b/tests/ovn-controller.at index 2cd3e261f..1dd1553cd

[ovs-dev] [PATCH ovn v2 1/9] northd: Amend RBAC rules for Port_Binding table

2021-03-05 Thread Frode Nordahl
132 (" ovn-controller: Store the local port bindings in the runtime data I-P state") Reported-At: https://bugs.launchpad.net/ubuntu/+source/ovn/+bug/1917475 Signed-off-by: Frode Nordahl --- northd/ovn-northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/northd/ovn-n

[ovs-dev] [PATCH ovn v2 6/9] tests: Amend release stale port binding test for RBAC

2021-03-05 Thread Frode Nordahl
for authentication. Update the test to set the `hostname` field when simulating chassis registration so that `ovn-controller` does not attempt to update it and subsequently make the test fail. Fixes b6b3823d4 ("ovn-controller: Fix I-P for SB Port_Binding and OVS Interface") Signed-off-by: Fro

[ovs-dev] [PATCH ovn v2 2/9] northd: Add missing RBAC rules for FDB table

2021-03-05 Thread Frode Nordahl
The recently added FDB table did not get its RBAC rules which would prohibit a `ovn-controller` from updating it with RBAC enabled. Fixes: 6ec3b1259 ("MAC learning: Add a new FDB table in southbound db") Signed-off-by: Frode Nordahl --- northd/ovn-northd.c | 13 + 1 file c

[ovs-dev] [PATCH ovn v2 8/9] tests: Make certificate generation extendable

2021-03-05 Thread Frode Nordahl
an update to existing tests so that they use the new filenames. Signed-off-by: Frode Nordahl --- tests/automake.mk | 48 ++- tests/ovn.at | 48 +++ 2 files changed, 46 insertions(+), 50 deletions(-) diff

[ovs-dev] [PATCH ovn v2 9/9] tests: Test with SSL and RBAC for controller by default

2021-03-05 Thread Frode Nordahl
To help ourself to not forget updating RBAC rules when we land changes to existing functionality and new features we must enable SSL+RBAC on the `ovn-controller` <-> SB DB connection for builds with OpenSSL enabled. Signed-off-by: Frode Nordahl --- tests/automake.mk | 9 +++--

[ovs-dev] [PATCH] ovs-ctl: Allow recording hostname separately

2021-02-16 Thread Frode Nordahl
a system is configured to use a Open vSwitch controlled datapath as its only network connection, the current ordering of events would always produce a unreliable hostname Reported-At: https://bugs.launchpad.net/bugs/1915829 Signed-off-by: Frode Nordahl --- utilities/ovs-ctl.in | 12 +++- 1

[ovs-dev] [PATCH ovn branch-20.03 16/16] tests: Fix test "ovn -- Superseding ACLs with conjunction".

2021-02-18 Thread Frode Nordahl
g flow actions.") Reported-by: Numan Siddique Signed-off-by: Dumitru Ceara Signed-off-by: Numan Siddique (cherry picked from commit 6e3d69e6b5153e26c869a03ec7dd1aaa40488005) (patch was adapted to branch-20.03 by checking table 44 not 45) Signed-off-by: Frode Nordahl --

[ovs-dev] [PATCH ovn branch-20.03 15/16] tests: Add ofctl_strip_all() to filter OVS flow outputs.

2021-02-18 Thread Frode Nordahl
picked from commit 0879a0aa9f332bdc689769a1bc2f156f1c3149a5) Signed-off-by: Frode Nordahl --- tests/ofproto-macros.at | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index 6c4ff60e7..22999c1ca 100644

[ovs-dev] [PATCH ovn branch-20.03 07/16] ofctrl.c: Fix duplicated flow handling in I-P while merging opposite changes.

2021-02-18 Thread Frode Nordahl
Signed-off-by: Frode Nordahl --- controller/ofctrl.c | 28 +++- tests/ovn.at| 108 2 files changed, 134 insertions(+), 2 deletions(-) diff --git a/controller/ofctrl.c b/controller/ofctrl.c index b526c68f4..41495c41f 100644 --- a/controller/ofct

[ovs-dev] [PATCH ovn branch-20.03 14/16] ovn.at: Make some of the tests more predictable.

2021-02-18 Thread Frode Nordahl
From: Dumitru Ceara Fix some of the race conditions that are present in the current OVN test suite. Signed-off-by: Dumitru Ceara Signed-off-by: Ben Pfaff (cherry picked from commit d6594a4695084e1b0f4fb3170547942876d3a81a) Signed-off-by: Frode Nordahl --- tests/ovn.at | 48

[ovs-dev] [PATCH ovn branch-20.06 00/15] Backport rollup

2021-02-18 Thread Frode Nordahl
Hello all, In Ubuntu we have backported a set of fixes to our OVN 20.06 and OVN 20.03 packages. In preparing for new point releases for OVN 20.06 and OVN 20.03, we would very much like to add these patches to the upstream branches. The issues solved for OVN 20.06 with these patches are: *

[ovs-dev] [PATCH ovn branch-20.03 03/16] ofctrl.c: Maintain references between installed flows and desired flows.

2021-02-18 Thread Frode Nordahl
354d3853d40cbce89a434632f67daed7fc992d8b) Signed-off-by: Frode Nordahl --- controller/ofctrl.c | 428 ++-- 1 file changed, 294 insertions(+), 134 deletions(-) diff --git a/controller/ofctrl.c b/controller/ofctrl.c index 2a337e309..0d6326fc3 100644 --- a/controller

[ovs-dev] [PATCH ovn branch-20.03 06/16] ofctrl.c: Merge opposite changes of tracked flows before installing.

2021-02-18 Thread Frode Nordahl
rom commit f4e508dd7a6cfbfc2e3250a8c11a8d0fdc1dfdd0) Signed-off-by: Frode Nordahl --- controller/ofctrl.c | 74 + 1 file changed, 74 insertions(+) diff --git a/controller/ofctrl.c b/controller/ofctrl.c index 3ff8604b1..b526c68f4 100644 --- a/controller/ofct

[ovs-dev] [PATCH ovn branch-20.03 01/16] ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb

2021-02-18 Thread Frode Nordahl
67e2f386cc838d0b0f9b4b5da7fe611e1113b70c) Signed-off-by: Frode Nordahl --- utilities/ovn-ctl | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl index c7cb42bc1..7285c0533 100755 --- a/utilities/ovn-ctl +++ b/utilities/ovn-ctl @@ -284,7 +284,21

[ovs-dev] [PATCH ovn branch-20.03 13/16] ofctrl.c: Add a predictable resolution for conflicting flow actions.

2021-02-18 Thread Frode Nordahl
at: https://bugzilla.redhat.com/1871931 Signed-off-by: Dumitru Ceara Acked-by: Mark Gray Signed-off-by: Han Zhou (cherry picked from commit 986b3d5e4ad6f05245d021ba699c957246294a22) Signed-off-by: Frode Nordahl --- controller/ofctrl.c | 74 +-- tests/ovn.at| 214 +

[ovs-dev] [PATCH ovn branch-20.03 05/16] ofctrl: Incremental processing for flow installation by tracking.

2021-02-18 Thread Frode Nordahl
Michelson Signed-off-by: Han Zhou (cherry picked from commit 6f0b1e02d9ab3a94048c4818f2d382938cad4b71) Signed-off-by: Frode Nordahl --- controller/ofctrl.c | 289 +++- controller/ofctrl.h | 6 +- 2 files changed, 240 insertions(+), 55 deletions(-) diff

[ovs-dev] [PATCH ovn branch-20.03 09/16] ofctrl.c: Only merge actions for conjunctive flows.

2021-02-18 Thread Frode Nordahl
into one flow.") Signed-off-by: Dumitru Ceara Signed-off-by: Han Zhou (cherry picked from commit dadae4f800ccb1f2759378f0bd804dd002e31605) Signed-off-by: Frode Nordahl --- controller/ofctrl.c | 124 +++- 1 file changed, 99 insertions(+), 25 dele

[ovs-dev] [PATCH ovn branch-20.03 10/16] ofctrl.c: Do not change flow ordering when merging opposite changes.

2021-02-18 Thread Frode Nordahl
of desired flows. Signed-off-by: Dumitru Ceara Signed-off-by: Han Zhou (cherry picked from commit e49ce9a33f38f29c44e3c30afcc189b5f6a9ef8e) Signed-off-by: Frode Nordahl --- controller/ofctrl.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git

[ovs-dev] [PATCH ovn branch-20.03 02/16] Revert "Manage ARP process locally in a DVR scenario"

2021-02-18 Thread Frode Nordahl
From: Lorenzo Bianconi This reverts commit c0bf32d72f8b893bbe3cb64912b0fd259d71555f. Signed-off-by: Lorenzo Bianconi Signed-off-by: Han Zhou (cherry picked from commit d9ed450713eda62af1bec5009694b2d206c9f435) Signed-off-by: Frode Nordahl --- northd/ovn-northd.8.xml | 37

[ovs-dev] [PATCH ovn branch-20.03 11/16] ofctrl.c: Simplify active desired flow selection.

2021-02-18 Thread Frode Nordahl
alled flows. Signed-off-by: Dumitru Ceara Signed-off-by: Han Zhou (cherry picked from commit 107bb25029350bd0f7dfeeb0ef3053adbd504e3e) Signed-off-by: Frode Nordahl --- controller/ofctrl.c | 91 ++--- 1 file changed, 36 insertions(+), 55 deletions(-) dif

[ovs-dev] [PATCH ovn branch-20.03 08/16] ofctrl.c: Avoid repeatedly linking an installed flow and a desired flow.

2021-02-18 Thread Frode Nordahl
() and convert it to an assert. 2. Before calling link_installed_to_desired() in the above mentioned loop, check if the desired flow is already installed. Acked-by: Dumitru Ceara Signed-off-by: Han Zhou (cherry picked from commit 7cab7bd1268ba67429954da4f73de91090acf779) Signed-off-by: Frode

[ovs-dev] [PATCH ovn branch-20.03 12/16] ofctrl.c: Always log the most recent flow changes.

2021-02-18 Thread Frode Nordahl
From: Dumitru Ceara Fixes: 6f0b1e02d9ab ("ofctrl: Incremental processing for flow installation by tracking.") Signed-off-by: Dumitru Ceara Signed-off-by: Han Zhou (cherry picked from commit 33c15c145988daa6172928dc870f3a0225515f50) Signed-off-by: Frode Nordahl --- controller/of

[ovs-dev] [PATCH ovn branch-20.03 04/16] ofctrl.c: Refactor - move openflow msg construction to functions.

2021-02-18 Thread Frode Nordahl
From: Han Zhou These functions will be reused in multiple places in a future patch. Acked-by: Mark Michelson Signed-off-by: Han Zhou (cherry picked from commit 23063cf4178c05f5d6b3e4ec6d323ccc88df6101) Signed-off-by: Frode Nordahl --- controller/ofctrl.c | 103

  1   2   3   4   5   6   >