[ovs-dev] [PATCH V2 07/10] datapath: Fix an error handling path in 'ovs_nla_init_match_and_action()

2018-02-07 Thread Greg Rose
Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Christophe JAILLET <christophe.jail...@wanadoo.fr> Fixes: 850c2a4d1a ("datapath: Avoid using stack larger than 1024.") Signed-off-by: Greg Rose <gvrose8...@gma

[ovs-dev] [PATCH V2 08/10] datapath: fix data type in queue_gso_packets

2018-02-07 Thread Greg Rose
I fixed them up as well. Cc: Gustavo A. R. Silva <garsi...@embeddedor.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/datapath.c | 2 +- datapath/linux/compat/stt.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath/datapath.c b/datapat

[ovs-dev] [PATCH V2 10/10] datapath: use ktime_get_ts64() instead of ktime_get_ts()

2018-02-07 Thread Greg Rose
ergmann <a...@arndb.de> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 3 +++ datapath/flow.c | 7 --- datapath/linux/Modules.mk | 1 + datapath/linux/compat/include

[ovs-dev] [PATCH v2 00/11] Add upstream Linux 4.14 kernel support

2018-02-07 Thread Greg Rose
: Add meter netlink definitions datapath: Add meter infrastructure Greg Rose (3): Documentation: Update NEWS and faq acinclude.m4: Enable Linux 4.14 travis: Update kernel test list from kernel.org Gustavo A. R. Silva (2): datapath: meter: fix NULL pointer dereference

[ovs-dev] [PATCH v2 01/11] datapath: export get_dp() API

2018-02-07 Thread Greg Rose
th.c. Export it. Signed-off-by: Andy Zhou <az...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Andy Zhou <az...@ovn.org> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/datapath.c | 29 - datapath/datapath.h | 3

[ovs-dev] [PATCH v2 02/11] datapath: reliable interface indentification in port dumps

2018-02-07 Thread Greg Rose
er if needed. Signed-off-by: Jiri Benc <jb...@redhat.com> Signed-off-by: David S. Miller <da...@davemloft.net> Added compat fixup for peernet2id. Cc: Jiri Benc <jb...@redhat.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4

[ovs-dev] [PATCH v2 03/11] datapath: Add meter netlink definitions

2018-02-07 Thread Greg Rose
ink messages and attributes for communicating with the user space programs. Signed-off-by: Andy Zhou <az...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Andy Zhou <az...@ovn.org> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linu

[ovs-dev] [PATCH v2 05/11] datapath: Fix return value check in ovs_meter_cmd_features()

2018-02-07 Thread Greg Rose
m> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Wei Yongjun <weiyongj...@huawei.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/meter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[ovs-dev] [PATCH v2 04/11] datapath: Add meter infrastructure

2018-02-07 Thread Greg Rose
ded another compat fixup for ktime_get_ns. Cc: Andy Zhou <az...@ovn.org> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4| 3 + datapath/Modules.mk | 6 +- datapath/datapath.c

[ovs-dev] [PATCH v2 06/11] datapath: Using kfree_rcu() to simplify the code

2018-02-07 Thread Greg Rose
gt; Cc: Wei Yongjun <weiyongj...@huawei.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/meter.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/datapath/meter.c b/datapath/meter.c index bc940ae..7b9391d 100644 --- a/datapath/meter.c +++ b/datapat

[ovs-dev] [PATCH v2 07/11] datapath: meter: fix NULL pointer dereference in ovs_meter_cmd_reply_start

2018-02-07 Thread Greg Rose
nvswitch: Add meter infrastructure") Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Gustavo A. R. Silva <garsi...@embeddedor.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapa

[ovs-dev] [PATCH v2 09/11] Documentation: Update NEWS and faq

2018-02-07 Thread Greg Rose
Per the Linux 4.14 kernel support. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- Documentation/faq/releases.rst | 1 + NEWS | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 6

[ovs-dev] [PATCH v2 10/11] acinclude.m4: Enable Linux 4.14

2018-02-07 Thread Greg Rose
Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 414b96a..6928db8 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -151,10 +151,10 @@ AC_DEFUN([OVS_CHECK

[ovs-dev] [PATCH v2 11/11] travis: Update kernel test list from kernel.org

2018-02-07 Thread Greg Rose
Also add package libelf-dev - since 4.14 it's required for making the source. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- .travis.yml | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.travis.yml b/.travis.yml index 48acc8e..cfd9b6f

[ovs-dev] [PATCH V2] lib: Make error messages more useful

2017-12-28 Thread Greg Rose
open error occurred. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- lib/dpctl.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/lib/dpctl.c b/lib/dpctl.c index b769544..a0c639e 100644 --- a/lib/dpctl.c +++ b/lib/dpctl.c @@ -120,6 +12

[ovs-dev] [PATCH 2/2] compat: Fix RHEL 7 build warnings

2018-02-26 Thread Greg Rose
A prior commit to fix up netdev_master_upper_dev_link for recent kernels caused a compile warning on RHEL 7 builds. Fixes: 36d3520b5f ("datapath: Fix netdev_master_upper_dev_link for 4.14") Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/include/linux

[ovs-dev] [PATCH 1/2] compat: Fix RHEL 7 compile

2018-02-26 Thread Greg Rose
Check for frag_percpu_counter_batch") Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 4 datapath/linux/compat/include/net/inet_frag.h | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index b5f62cc

[ovs-dev] [PATCH V2] compat: Allow IPv6 GRE/ERSPAN Tx when ip6_gre is loaded

2018-07-27 Thread Greg Rose
is loaded and in that case still enable IPv6 GRE/ERSPAN Tx. Signed-off-by: Greg Rose --- V2 - Fix up a couple of issues William found --- datapath/linux/compat/ip6_gre.c | 41 +++-- datapath/vport.c| 17 +++-- 2 files changed, 46

[ovs-dev] [PATCH] compat: Allow IPv6 GRE/ERSPAN Tx when ip6_gre is loaded

2018-07-26 Thread Greg Rose
is loaded and in that case still enable IPv6 GRE/ERSPAN Tx. Signed-off-by: Greg Rose --- datapath/linux/compat/ip6_gre.c | 39 +-- datapath/vport.c| 17 +++-- 2 files changed, 48 insertions(+), 8 deletions(-) diff --git a/datapath

[ovs-dev] [PATCH] datapath: meter: Fix setting meter id for new entries

2018-08-07 Thread Greg Rose
iller Cc: Justin Pettit Signed-off-by: Greg Rose --- datapath/meter.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/datapath/meter.c b/datapath/meter.c index 1c2ed46..281d869 100644 --- a/datapath/meter.c +++ b/datapath/meter.c @@ -221,6 +221,7 @@ static struc

[ovs-dev] [PATCH 1/2] ip_gre: fix IFLA_MTU ignored on NEWLINK

2018-08-07 Thread Greg Rose
x that now. Cc: Xin Long Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c index 1ab7981..47ee525 100644 --- a/datapath/linux/compat/ip_gre.c +++ b/datapath/linux/compa

[ovs-dev] [PATCH 2/2] ip_gre: remove redundant variables t_hlen

2018-08-07 Thread Greg Rose
never read, hence they are redundant and can be removed. Signed-off-by: YueHaibing Signed-off-by: David S. Miller Cc: YueHaibing Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c | 5 - 1 file changed, 5 deletions(-) diff --git a/datapath/linux/compat/ip_gre.c b/data

[ovs-dev] [PATCH V2] ofproto-dpif: Check for EBUSY as well

2018-08-24 Thread Greg Rose
/pipermail/ovs-discuss/2018-August/047214.html Reported-by: Guru Shetty Signed-off-by: Greg Rose --- V2 - Add Reported-at tag as requested by Ben --- ofproto/ofproto-dpif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c ind

[ovs-dev] [PATCH] ofproto-dpif: Check for EBUSY as well

2018-08-22 Thread Greg Rose
Sometimes a driver will return EBUSY as well as EEXIST for some duplicate configurations. Check for EBUSY too. Fixes: 7521e0cf9e ("ofproto-dpif: Let the dpif report when a ...") Reported by: Guru Shetty Signed-off-by: Greg Rose --- ofproto/ofproto-dpif.c | 2 +- 1 file changed, 1

[ovs-dev] [PATCH] compat: Initialize IPv4 reassembly secret timer

2018-07-19 Thread Greg Rose
inet_frags_secret_rebuild() would try to rearm a timer from the openvswitch kernel module which had just been removed. Also remove the prior, and now unnecessary, work around. VMware BZ 2094203 Fixes: 595e069a ("compat: Backport IPv4 reassembly.") Signed-off-by: Greg Rose ---

[ovs-dev] [PATCH] erspan: set bso bit based on mirrored packet's len

2018-07-18 Thread Greg Rose
10 --> Payload is an Oversized Frame Based the short/oversized definitions in RFC1757, the patch sets the bso bit based on the mirrored packet's size. Reported-by: Xiaoyan Jin Signed-off-by: William Tu Signed-off-by: David S. Miller Cc: William Tu Signed-off-b

[ovs-dev] [PATCH V2] Documentation: Add netstat to testing instructions

2018-07-16 Thread Greg Rose
Add netstat when mentioning testing. Many check-kmod failures result when it is not present. Signed-off-by: Greg Rose --- V2 - Fix commit title --- Documentation/intro/install/general.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/intro/install/general.rst b

[ovs-dev] [PATCH] erspan: set erspan_ver to 1 by default when adding an erspan dev

2018-09-06 Thread Greg Rose
nlin Shi Signed-off-by: Xin Long Signed-off-by: David S. Miller Fixes: 5e720da59d ("erspan: fix invalid erspan version.") Cc: Xin Long Signed-off-by: Greg Rose --- datapath/linux/compat/ip6_gre.c | 1 + datapath/linux/compat/ip_gre.c | 3 +++ 2 files changed, 4 insertions(+

[ovs-dev] [PATCH] Documentation:

2018-07-13 Thread Greg Rose
Add netstat when mentioning testing. Many check-kmod failures result when it is not present. Signed-off-by: Greg Rose --- Documentation/intro/install/general.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/intro/install/general.rst b/Documentation/intro/install

[ovs-dev] [PATCH V3] datapath: Prevent panic

2018-04-20 Thread Greg Rose
gt; 89 71 08 48 89 4d c0 48 8b 4a 30 48 89 4d c8 48 89 31 48 89 [252257.842366] RIP [] run_timer_softirq+0xe0/0x310 [252257.843183] RSP [252257.843955] CR2: c07c6298 Fixes: dd41d330b03 ("openvswitch: Add force commit.") Suggested-by: Eric Garver <e...@erig.me> Signed-off-by:

[ovs-dev] [PATCH] compat: Fix upstream 4.4.119 kernel

2018-04-20 Thread Greg Rose
separated out. Add the necessary compatibility detection layer in acinclude.m4 and then fixup the source files so that if the built-in kernel includes dst_cache support then exclude our own compatibility code. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4

[ovs-dev] [PATCH] datapath: Prevent panic

2018-04-16 Thread Greg Rose
rlying bug, which does need to be investigated and fixed, but it does prevent it from occurring. We would like to prevent customer systems from panicking while we do futher investigation to find the root cause. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/datapat

[ovs-dev] [PATCH V2] datapath: Prevent panic

2018-04-17 Thread Greg Rose
4 a7 01 00 00 49 63 d4 48 83 43 10 01 48 8d 75 c0 48 c1 e2 04 48 01 da 48 8b 4a 28 48 8d 42 28 <48> 89 71 08 48 89 4d c0 48 8b 4a 30 48 89 4d c8 48 89 31 48 89 [252257.842366] RIP [] run_timer_softirq+0xe0/0x310 [252257.843183] RSP [252257.843955] CR2: c07c6298 Signed-off-by: Gr

[ovs-dev] [PATCH 00/11] Patches 1-11 of ERSPAN backport

2018-04-25 Thread Greg Rose
kernel. Currently the series only builds on kernels <= 4.9. A future patch will enable builds on kernels greater than 4.9. Greg Rose (1): compat: Remove unsupported kernel compat code William Tu (7): gre: introduce native tunnel support for ERSPAN gre: fix goto statement typo gre: refac

[ovs-dev] [PATCH 02/11] gre: introduce native tunnel support for ERSPAN

2018-04-25 Thread Greg Rose
r <da...@davemloft.net> This commit also backports heavily from upstream gre, ip_gre and ip_tunnel modules to support the necessary erspan ip gre infrastructure as well as implementing a variety of compatability layer changes for same support. Cc: William Tu <u9012...@gmail.com>

[ovs-dev] [PATCH 07/11] ip_gre: get key from session_id correctly in erspan_rcv

2018-04-25 Thread Greg Rose
..@davemloft.net> Cc: Xin Long <lucien@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c | 1 - 1 file changed, 1 deletion(-) diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c index 2377d82..caa6e6c 100644 ---

[ovs-dev] [PATCH 04/11] gre: refactor the gre_fb_xmit

2018-04-25 Thread Greg Rose
re_fb_xmit() but we need the prepare_fb_xmit() function for the subsequent patch. Cc: William Tu <u9012...@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c | 48 ++ 1 file changed, 48 insertions(+) diff --

[ovs-dev] [PATCH 05/11] compat/gre: add collect_md mode

2018-04-25 Thread Greg Rose
; With some adjustments for compatibility layer. Cc: William Tu <u9012...@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/include/net/ip_tunnels.h | 68 +++--- datapath/linux/compat/ip_gre.c | 23 ++--- 2 files changed, 54

[ovs-dev] [PATCH 10/11] ip_gre: Refactor the erpsan tunnel code.

2018-04-25 Thread Greg Rose
le, erspan.h, so ipv6 erspan implementation can use it. Signed-off-by: William Tu <u9012...@gmail.com> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: William Tu <u9012...@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/li

[ovs-dev] [PATCH 11/11] compat/erspan: refactor existing erspan code

2018-04-25 Thread Greg Rose
re support. Cc: William Tu <u9012...@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip

[ovs-dev] [PATCH 09/11] ip_gre: erspan device should keep dst

2018-04-25 Thread Greg Rose
Miller <da...@davemloft.net> Cc: Xin Long <lucien....@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c index 7a4b5

[ovs-dev] [PATCH 01/11] compat: Remove unsupported kernel compat code

2018-04-25 Thread Greg Rose
Anything less than 3.10 isn't supported since a couple of releases ago so remove the dead code. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/include/linux/etherdevice.h | 30 -- datapath/linux/compat/include/linux/if_vlan.h | 11 --- datapath/linux/

[ovs-dev] [PATCH 03/11] gre: fix goto statement typo

2018-04-25 Thread Greg Rose
am Tu <u9012...@gmail.com> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: William Tu <u9012...@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

[ovs-dev] [PATCH 06/11] ip_gre: check packet length and mtu correctly in erspan tx

2018-04-25 Thread Greg Rose
pport for ERSPAN") Signed-off-by: William Tu <u9012...@gmail.com> Cc: Xin Long <lucien@gmail.com> Cc: David Laight <david.lai...@aculab.com> Reviewed-by: Xin Long <lucien@gmail.com> Signed-off-by: David S. Miller <da...@davemloft.net> C

[ovs-dev] [ERSPAN RFC 00/25] Introduce ERSPAN for OVS

2018-03-22 Thread Greg Rose
at_erspan0 type=erspan options:remote_ip=192.168.0.103 options:erspan_ver=1 options:erspan_idx=0x7 Greg Rose (6): compat: Remove unsupported kernel compat code compat: Move function to header compat: Add #define for gre_handle_offloads compat: Fixups for some compile warnings and error

[ovs-dev] [ERSPAN RFC 01/25] gre: introduce native tunnel support for ERSPAN

2018-03-22 Thread Greg Rose
r <da...@davemloft.net> This commit also backports heavily from upstream gre, ip_gre and ip_tunnel modules to support the necessary erspan ip gre infrastructure as well as implementing a variety of compatability layer changes for same support. Cc: William Tu <u9012...@gmail.com>

[ovs-dev] [ERSPAN RFC 03/25] gre: refactor the gre_fb_xmit

2018-03-22 Thread Greg Rose
re_fb_xmit() but we need the prepare_fb_xmit() function for the subsequent patch. Cc: William Tu <u9012...@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c | 48 ++ 1 file changed, 48 insertions(+) diff --

[ovs-dev] [ERSPAN RFC 02/25] gre: fix goto statement typo

2018-03-22 Thread Greg Rose
am Tu <u9012...@gmail.com> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: William Tu <u9012...@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

[ovs-dev] [ERSPAN RFC 04/25] compat/gre: add collect_md mode

2018-03-22 Thread Greg Rose
; With some adjustments for compatibility layer. Cc: William Tu <u9012...@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/include/net/ip_tunnels.h | 68 -- datapath/linux/compat/ip_gre.c | 117 ++--- 2 files chan

[ovs-dev] [ERSPAN RFC 06/25] ip_gre: get key from session_id correctly in erspan_rcv

2018-03-22 Thread Greg Rose
..@davemloft.net> Cc: Xin Long <lucien@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c index af9fbb

[ovs-dev] [ERSPAN RFC 08/25] ip_gre: erspan device should keep dst

2018-03-22 Thread Greg Rose
Miller <da...@davemloft.net> Cc: Xin Long <lucien....@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c index dc583

[ovs-dev] [ERSPAN RFC 07/25] ip_gre: set tunnel hlen properly in erspan_tunnel_init

2018-03-22 Thread Greg Rose
; Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Xin Long <lucien@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/datapath/linux/compat/ip_gre.c b/da

[ovs-dev] [ERSPAN RFC 05/25] ip_gre: check packet length and mtu correctly in erspan tx

2018-03-22 Thread Greg Rose
pport for ERSPAN") Signed-off-by: William Tu <u9012...@gmail.com> Cc: Xin Long <lucien@gmail.com> Cc: David Laight <david.lai...@aculab.com> Reviewed-by: Xin Long <lucien@gmail.com> Signed-off-by: David S. Miller <da...@davemloft.net> C

[ovs-dev] [ERSPAN RFC 09/25] ip_gre: Refactor the erpsan tunnel code.

2018-03-22 Thread Greg Rose
le, erspan.h, so ipv6 erspan implementation can use it. Signed-off-by: William Tu <u9012...@gmail.com> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: William Tu <u9012...@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/li

[ovs-dev] [ERSPAN RFC 10/25] compat/erspan: refactor existing erspan code

2018-03-22 Thread Greg Rose
re support. Cc: William Tu <u9012...@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip

[ovs-dev] [ERSPAN RFC 15/25] compat: Remove unsupported kernel compat code

2018-03-22 Thread Greg Rose
Anything less than 3.10 isn't supported since a couple of releases ago so remove the dead code. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/include/linux/etherdevice.h | 30 -- datapath/linux/compat/include/linux/if_vlan.h | 11 --- datapath/linux/

[ovs-dev] [ERSPAN RFC 11/25] ip_gre: fix wrong return value of erspan_rcv

2018-03-22 Thread Greg Rose
by: William Tu <u9012...@gmail.com> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Haishuang Yan <yanhaishu...@cmss.chinamobile.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[ovs-dev] [ERSPAN RFC 13/25] ip_gre: remove the incorrect mtu limit for ipgre tap

2018-03-22 Thread Greg Rose
at.com> Signed-off-by: Xin Long <lucien@gmail.com> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Xin Long <lucien@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c | 3 ++- 1 file changed, 2 in

[ovs-dev] [ERSPAN RFC 12/25] ip_gre: erspan: reload pointer after pskb_may_pull

2018-03-22 Thread Greg Rose
ng Yan <yanhaishu...@cmss.chinamobile.com> Signed-off-by: David S. Miller <da...@davemloft.net> Only the ip_gre portion of the upstream commit. The ipv6 portion is pulled in with later patch in series. Cc: William Tu <u9012...@gmail.com> Signed-off-by: Greg Rose <gvrose8...@g

[ovs-dev] [ERSPAN RFC 14/25] ip_gre: fix potential memory leak in erspan_rcv

2018-03-22 Thread Greg Rose
Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Haishuang Yan <yanhaishu...@cmss.chinamobile.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/datapath/linux/compat/ip_

[ovs-dev] [ERSPAN RFC 17/25] compat: Add #define for gre_handle_offloads

2018-03-22 Thread Greg Rose
Fixes compile errors on some 4.x kernels. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c index 9ed391d..6e75094 100644 --- a/datapath

[ovs-dev] [ERSPAN RFC 16/25] compat: Move function to header

2018-03-22 Thread Greg Rose
tnl_flags_to_gre_flags is also needed in both ip_gre.c and gre.c on some kernels. Move it from ip_gre.c to the common header. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/include/net/gre.h | 23 +++ datapath/linux/compat/ip_gre.c

[ovs-dev] [ERSPAN RFC 20/25] datapath: erspan: introduce erspan v2 for ip_gre

2018-03-22 Thread Greg Rose
am Tu <u9012...@gmail.com> Signed-off-by: David S. Miller <da...@davemloft.net> Includes some compatability layer adjustments and portions of this commit were introduced earlier while pulling in ipv6 erspan. Cc: William Tu <u9012...@gmail.com> Signed-off-by: Greg Rose <gvrose8.

[ovs-dev] [ERSPAN RFC 18/25] compat: Fixups for some compile warnings and errors

2018-03-22 Thread Greg Rose
A lot of code has been pulled in. Fix it up to make sure it compiles correctly. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4| 3 +++ datapath/linux/compat/gre.c | 23 datapath/linux/compat/include/net/gre.

[ovs-dev] [ERSPAN RFC 22/25] net: erspan: fix metadata extraction

2018-03-22 Thread Greg Rose
m Tu <u9012...@gmail.com> Signed-off-by: David S. Miller <da...@davemloft.net> This is just the ip_gre portion of this upstream commit. The portions of the upstream commit that went to erpsan.h and ip6_gre.c were folded in during a previous commit to introduce ip6 gre. Cc: W

[ovs-dev] [ERSPAN RFC 19/25] compat: Add ipv6 GRE and IPV6 Tunneling

2018-03-22 Thread Greg Rose
files then the patches are also listed separately within this patch series. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4| 36 + datapath/linux/Modules.mk |2 + datapath/linux/compat/include/linux/compiler.h

[ovs-dev] [ERSPAN RFC 24/25] datapath: add erspan version I and II support

2018-03-22 Thread Greg Rose
perly. Signed-off-by: William Tu <u9012...@gmail.com> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: William Tu <u9012...@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- da

[ovs-dev] [ERSPAN RFC 23/25] erspan: fix erspan config overwrite

2018-03-22 Thread Greg Rose
ff-by: David S. Miller <da...@davemloft.net> This is just the ip_gre portion of the commit. The ip6_gre part of the commit was folded in during the prior commit to introduce ip6 gre and ip6 tunneling. Cc: William Tu <u9012...@gmail.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com

[ovs-dev] [ERSPAN RFC 25/25] datapath: More ipgre fixes

2018-03-22 Thread Greg Rose
this patch doesn't really exist. All of this code will be folded into previous patches and this patch series re-ordered. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 6 +- datapath/linux/compat/gre.c | 27 +- da

[ovs-dev] [PATCH V2 1/2] compat: Fix gre header bug

2018-06-28 Thread Greg Rose
newer kernels") Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c index ac9fb8b..df0217e 100644 --- a/datapath/linux/compat/ip_gre.c +++ b/data

[ovs-dev] [PATCH V2 2/2] datapath: Add missing code in ip_tunnel_lookup()

2018-06-28 Thread Greg Rose
("gre: introduce native tunnel support for ERSPAN") Reported-by: William Tu Signed-off-by: Greg Rose --- V2 - Address the missing code problem brought up by William in review of the initial patch --- datapath/linux/compat/ip_gre.c| 3 +-- datapath/linux/compat/ip_tunnel.c |

[ovs-dev] [PATCH 1/2] compat: Fix gre header bug

2018-06-28 Thread Greg Rose
newer kernels") Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c index ac9fb8b..df0217e 100644 --- a/datapath/linux/compat/ip_gre.c +++ b/data

[ovs-dev] [PATCH 2/2] datapath: Ignore key in ip_tunnel_lookup

2018-06-28 Thread Greg Rose
The key value is always zero in ip_tunnel_lookup() for all OVS tunnels but in received packets it is set. Just ignore it for the ip_tunnel_lookup() in the same manner as erspan_rcv(). Fixes: 8e53509c ("gre: introduce native tunnel support for ERSPAN") Signed-off-by: Greg Rose ---

[ovs-dev] [PATCH 2/2] vswitchd: Update documentation for legacy_l3 type packets

2018-11-06 Thread Greg Rose
The documentation needs to specify that for GRE tunnels there is no support for legacy_l3 type packets in the kernel datapath. Signed-off-by: Greg Rose --- vswitchd/vswitch.xml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index efa1ef8

[ovs-dev] [PATCH 1/2] gre: Remove dead ipgre code

2018-11-06 Thread Greg Rose
Open vSwitch uses gretap, not ipgre for gre tunneling. Remove dead code for ipgre type tunnels. Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c | 65 ++ 1 file changed, 2 insertions(+), 63 deletions(-) diff --git a/datapath/linux/compat

[ovs-dev] [PATCH] compat: Remove unused function

2018-08-31 Thread Greg Rose
The compat function rpl_nf_conntrack_in() does not appear to be used anywhere and emits warnings as such during builds < 4.10. The patch passes Travis: https://travis-ci.org/gvrose8192/ovs-experimental/builds/423097292 Remove it. Signed-off-by: Greg Rose --- .../include/net/netfil

[ovs-dev] [PATCH V2] rhel: bug fix upgrade path in kmod fedora spec file

2019-01-22 Thread Greg Rose
Obsoletes is needed for the upgrade path from kmod-openvswitch to openvswitch-kmod. Fixes: 22c33c3039 (rhel: support kmod build against mulitple kernel versions, fedora) VMware-BZ: #2249788 Signed-off-by: Martin Xu Signed-off-by: Greg Rose CC: Flavio Leitner CC: Yi-Hung Wei CC: Yifeng Sun CC: Zak Whitti

[ovs-dev] [PATCH] datapath: return -EEXIST if inet6_add_protocol fails

2019-01-22 Thread Greg Rose
://mail.openvswitch.org/pipermail/ovs-discuss/2019-January/048090.html Reported-by: Ken Ajiro Signed-off-by: Greg Rose --- datapath/linux/compat/ip6_gre.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/datapath/linux/compat/ip6_gre.c b/datapath/linux/compat/ip6_gre.c index 1827852..2ffdda5

[ovs-dev] [Branch 2.9 Patch] compat: Fixup ipv6 fragmentation on 4.9.135+ kernels

2019-01-23 Thread Greg Rose
perimental/builds/478033409 Cc: William Tu Cc: Yi-Hung Wei Cc: Yifeng Sun Acked-by: Yi-Hung Wei Signed-off-by: Greg Rose Signed-off-by: Ben Pfaff --- .travis.yml| 2 +- acinclude.m4 | 3 ++ datapath/linux/compat/nf_conntrack_re

[ovs-dev] [Branch 2.10 Patch] compat: Fixup ipv6 fragmentation on 4.9.135+ kernels

2019-01-23 Thread Greg Rose
perimental/builds/478033409 Cc: William Tu Cc: Yi-Hung Wei Cc: Yifeng Sun Acked-by: Yi-Hung Wei Signed-off-by: Greg Rose Signed-off-by: Ben Pfaff --- .travis.yml| 2 +- acinclude.m4 | 3 ++ datapath/linux/compat/nf_conntrack_re

[ovs-dev] [V2 with ACKS 2/8] datapath: kzalloc() -> kcalloc()

2018-12-13 Thread Greg Rose
calloc ( - (E1) * (E2) + E1, E2 , ...) | - kzalloc + kcalloc ( - E1 * E2 + E1, E2 , ...) ) Signed-off-by: Kees Cook CC: Kees Cook Signed-off-by: Greg Rose Acked-by: William Tu --- datapath/vport.c | 2 +- 1 file changed, 1 insert

[ovs-dev] [V2 with ACKS 7/8] datapath: load NAT helper

2018-12-13 Thread Greg Rose
Signed-off-by: David S. Miller CC: Flavio Leitner Signed-off-by: Greg Rose Acked-by: Flavio Leitner --- datapath/conntrack.c | 4 1 file changed, 4 insertions(+) diff --git a/datapath/conntrack.c b/datapath/conntrack.c index c6e731b..952b6ad 100644 --- a/datapath/conntrack.c +++ b

[ovs-dev] [V2 with ACKS 8/8] datapath: fix spelling mistake "execeeds" -> "exceeds"

2018-12-13 Thread Greg Rose
atelimited message, fix this. Signed-off-by: Colin Ian King Reviewed-by: Simon Horman Signed-off-by: David S. Miller CC: Colin Ian King Signed-off-by: Greg Rose Acked-by: William Tu --- datapath/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[ovs-dev] [V2 with ACKS 4/8] datapath: check tunnel option type in tunnel flags

2018-12-13 Thread Greg Rose
. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Jakub Kicinski Signed-off-by: David S. Miller CC: Pieter Jansen van Vuuren Signed-off-by: Greg Rose Acked-by: William Tu --- datapath/flow_netlink.c| 7 ++- datapath/linux/compat/geneve.c

[ovs-dev] [V2 with ACKS 5/8] datapath: Derive IP protocol number for IPv6 later frags

2018-12-13 Thread Greg Rose
CC: Yi-Hung Wei Signed-off-by: Greg Rose Acked-by: Yi-Hung Wei --- datapath/flow.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c index fadc074..f685cf3 100644 --- a/datapath/flow.c +++ b/datapath/flow.c @@ -254,21

[ovs-dev] [V2 with ACKS 6/8] datapath: fix return type of ndo_start_xmit function

2018-12-13 Thread Greg Rose
-by: Greg Rose Acked-by: William Tu --- datapath/vport-internal_dev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c index 629965e..0318f58 100644 --- a/datapath/vport-internal_dev.c +++ b/datapath/vport

[ovs-dev] [V2 with ACKS 1/8] datapath: kmalloc() -> kmalloc_array()

2018-12-13 Thread Greg Rose
loc_array ( - E1 * E2 + E1, E2 , ...) ) Signed-off-by: Kees Cook CC: Kees Cook Signed-off-by: Greg Rose Acked-by: William Tu --- datapath/datapath.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapat

[ovs-dev] [V2 with ACKS 0/8] datapath: Pull in upstream fixes and updates

2018-12-13 Thread Greg Rose
. There are other updates specific to netfilter/conntrack code which will be submitted separately in an upcoming patch series. Colin Ian King (1): datapath: fix spelling mistake "execeeds" -> "exceeds" Flavio Leitner (1): datapath: load NAT helper Greg Ro

[ovs-dev] [V2 with ACKS 3/8] compat: Fixup ip_tunnel_info_opts_set

2018-12-13 Thread Greg Rose
A new flags parameter has been added in 4.19 so add compat fixup. Signed-off-by: Greg Rose Reviewed-by: Yifeng Sun --- acinclude.m4 | 3 +++ datapath/linux/compat/include/net/ip_tunnels.h | 16 +++- 2 files changed, 18 insertions(+), 1 deletion

[ovs-dev] [PATCH 3/8] compat: Fixup ip_tunnel_info_opts_set

2018-12-05 Thread Greg Rose
A new flags parameter has been added in 4.19 so add compat fixup. Signed-off-by: Greg Rose --- acinclude.m4 | 3 +++ datapath/linux/compat/include/net/ip_tunnels.h | 16 +++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH 4/8] datapath: check tunnel option type in tunnel flags

2018-12-05 Thread Greg Rose
. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Jakub Kicinski Signed-off-by: David S. Miller CC: Pieter Jansen van Vuuren Signed-off-by: Greg Rose --- datapath/flow_netlink.c| 7 ++- datapath/linux/compat/geneve.c | 3

[ovs-dev] [PATCH 5/8] datapath: Derive IP protocol number for IPv6 later frags

2018-12-05 Thread Greg Rose
CC: Yi-Hung Wei Signed-off-by: Greg Rose --- datapath/flow.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c index fadc074..f685cf3 100644 --- a/datapath/flow.c +++ b/datapath/flow.c @@ -254,21 +254,18 @@ static bool

[ovs-dev] [PATCH 1/8] datapath: kmalloc() -> kmalloc_array()

2018-12-05 Thread Greg Rose
loc_array ( - E1 * E2 + E1, E2 , ...) ) Signed-off-by: Kees Cook CC: Kees Cook Signed-off-by: Greg Rose --- datapath/datapath.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 3f1cd

[ovs-dev] [PATCH 0/8] datapath: Pull in upstream fixes and updates

2018-12-05 Thread Greg Rose
. There are other updates specific to netfilter/conntrack code which will be submitted separately in an upcoming patch series. Colin Ian King (1): datapath: fix spelling mistake "execeeds" -> "exceeds" Flavio Leitner (1): datapath: load NAT helper Greg Ro

[ovs-dev] [PATCH 2/8] datapath: kzalloc() -> kcalloc()

2018-12-05 Thread Greg Rose
calloc ( - (E1) * (E2) + E1, E2 , ...) | - kzalloc + kcalloc ( - E1 * E2 + E1, E2 , ...) ) Signed-off-by: Kees Cook CC: Kees Cook Signed-off-by: Greg Rose --- datapath/vport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[ovs-dev] [PATCH 8/8] datapath: fix spelling mistake "execeeds" -> "exceeds"

2018-12-05 Thread Greg Rose
atelimited message, fix this. Signed-off-by: Colin Ian King Reviewed-by: Simon Horman Signed-off-by: David S. Miller CC: Colin Ian King Signed-off-by: Greg Rose --- datapath/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/conntrack.c b/dat

[ovs-dev] [PATCH 6/8] datapath: fix return type of ndo_start_xmit function

2018-12-05 Thread Greg Rose
-by: Greg Rose --- datapath/vport-internal_dev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c index 629965e..0318f58 100644 --- a/datapath/vport-internal_dev.c +++ b/datapath/vport-internal_dev.c @@ -43,7 +43,8

[ovs-dev] [PATCH 7/8] datapath: load NAT helper

2018-12-05 Thread Greg Rose
Signed-off-by: David S. Miller CC: Flavio Leitner Signed-off-by: Greg Rose --- datapath/conntrack.c | 4 1 file changed, 4 insertions(+) diff --git a/datapath/conntrack.c b/datapath/conntrack.c index c6e731b..952b6ad 100644 --- a/datapath/conntrack.c +++ b/datapath/conntrack.c

[ovs-dev] [PATCH] compat: Fixup ipv6 fragmentation on 4.9.135+ kernels

2019-01-10 Thread Greg Rose
perimental/builds/478033409 Cc: William Tu Cc: Yi-Hung Wei Cc: Yifeng Sun Signed-off-by: Greg Rose --- .travis.yml| 2 +- acinclude.m4 | 3 ++ datapath/linux/compat/nf_conntrack_reasm.c | 54 -- 3 files c

[ovs-dev] [PATCH] Revert "datapath: Derive IP protocol number for IPv6 later frags"

2018-12-18 Thread Greg Rose
er kernels. CC: Yi-Hung Wei Signed-off-by: Greg Rose --- datapath/flow.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c index f685cf3..fadc074 100644 --- a/datapath/flow.c +++ b/datapath/flow.c @@ -254,18 +254,21 @@ s

<    1   2   3   4   5   6   7   8   9   10   >