l_loop.idl, external_ids[i]);
> +}
> +
> unixctl_command_register("nb-connection-status", "", 0, 0,
> ovn_conn_show, ovnnb_idl_loop.idl);
>
> --
> 2.46.0
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Thanks Ilya. The result numbers are impressive and the change is
simple and straightforward.
Acked-by: Han Zhou
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Mar 6, 2024 at 11:13 AM Dumitru Ceara wrote:
>
> On 3/5/24 15:56, Numan Siddique wrote:
> > On Mon, Feb 26, 2024 at 7:59 AM Dumitru Ceara wrote:
> >>
> >> Otherwise, in case there's also a SNAT rule that uses the VIP as
> >> external IP, we break sessions initiated from behind the VIP.
>
On Tue, Aug 20, 2024 at 6:36 AM Lorenzo Bianconi
wrote:
>
> Lorenzo Bianconi (4):
> northd: Introduce bfd_sync_data data structure.
> northd: Optimize lookup in bfd_is_port_running.
> northd: Get rid of bfd_connections in bfd_sync_data.
> northd: Make bfd_connections static in build_parsed
On Thu, Aug 22, 2024 at 8:21 AM Dumitru Ceara wrote:
>
> On 8/22/24 17:17, Lorenzo Bianconi wrote:
> >> Hi Lorenzo,
> >>
> >> I have one complaint below, otherwise the series looks good to me.
> >>
> >
> > [...]
> >
> >>> @@ -742,12 +738,6 @@ void static_routes_destroy(struct static_routes_data
>
isredirect".
>
> Fixes: 8d13579bf5b3 ("Add support for centralize routing for distributed gw
> ports.")
> Reported-by: Felix Huettner
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2024-August/416264.html
> CC: Han Zhou
> Signed-off-by: Numa
On Wed, Aug 7, 2024 at 2:36 PM Han Zhou wrote:
>
> On Wed, Aug 7, 2024 at 10:29 AM Lorenzo Bianconi
> wrote:
> >
> > > On Tue, Aug 6, 2024 at 9:53 AM Lorenzo Bianconi
> > > wrote:
> > > >
> > > > [...]
> > > > > &
On Wed, Aug 7, 2024 at 8:39 PM Numan Siddique wrote:
>
> On Sat, Jul 20, 2024 at 1:24 AM Han Zhou wrote:
> >
> > When there are multiple encap IPs configured for a chassis, there are
> > situations that any of the IP may be used, e.g. when encap-ip is not
> > co
On Wed, Aug 7, 2024 at 12:58 PM Numan Siddique wrote:
>
> On Wed, Aug 7, 2024 at 3:53 PM Han Zhou wrote:
> >
> > On Wed, Aug 7, 2024 at 11:30 AM Numan Siddique wrote:
> > >
> > > On Wed, Aug 7, 2024 at 11:35 AM Han Zhou wrote:
> > > >
>
On Wed, Aug 7, 2024 at 10:29 AM Lorenzo Bianconi
wrote:
>
> > On Tue, Aug 6, 2024 at 9:53 AM Lorenzo Bianconi
> > wrote:
> > >
> > > [...]
> > > > > -void
> > > > > -bfd_cleanup_connections(const struct nbrec_bfd_table
> > > > > *nbrec_bfd_table,
> > > > > -struct hmap *b
On Wed, Aug 7, 2024 at 11:30 AM Numan Siddique wrote:
>
> On Wed, Aug 7, 2024 at 11:35 AM Han Zhou wrote:
> >
> > On Wed, Aug 7, 2024 at 7:18 AM Felix Huettner
> > wrote:
> > >
> > > On Wed, Aug 07, 2024 at 12:11:42AM -0700, Han Zhou wrote:
> > &g
On Wed, Aug 7, 2024 at 7:18 AM Felix Huettner
wrote:
>
> On Wed, Aug 07, 2024 at 12:11:42AM -0700, Han Zhou wrote:
> > [Einige Personen, die diese Nachricht erhalten haben, erhalten häufig keine
> > E-Mails von zhou...@gmail.com. Weitere Informationen, warum dies wichtig
&
On Tue, Aug 6, 2024 at 9:53 AM Lorenzo Bianconi
wrote:
>
> [...]
> > > -void
> > > -bfd_cleanup_connections(const struct nbrec_bfd_table *nbrec_bfd_table,
> > > -struct hmap *bfd_map)
> > > +static bool
> > > +bfd_is_port_running(const struct hmap *bfd_map, const char *port
On Mon, Jul 29, 2024 at 7:39 PM wrote:
>
> From: Numan Siddique
>
> Consider a deployment with the below logical resources:
>
> 1. A bridged logical switch 'public' with a port - P1 and a localnet
>port ln-public.
> 2. A logical router 'R'
> 3. Logical switch 'public' connected to R via logic
On Fri, Aug 2, 2024 at 4:12 AM Lorenzo Bianconi
wrote:
>
> Introduce bfd, static_routes, route_policies and bfd_sync nodes to northd I-P
> engine to track bfd connections and northd static_route/policy_route
> changes.
>
> Reported-at: https://issues.redhat.com/browse/FDP-600
> Signed-off-by: Lore
On Wed, Jul 31, 2024 at 1:32 PM Lorenzo Bianconi
wrote:
>
> Introduce bfd, static_routes, route_policies and bfd_sync nodes to northd I-P
> engine to track bfd connections and northd static_route/policy_route
> changes.
>
> Reported-at: https://issues.redhat.com/browse/FDP-600
> Signed-off-by: Lor
On Wed, Jul 31, 2024 at 8:42 AM Lorenzo Bianconi
wrote:
>
> [...]
> > > #endif /* EN_NORTHD_H */
> > > diff --git a/northd/inc-proc-northd.c b/northd/inc-proc-northd.c
> > > index 522236ad2..77610cdd8 100644
> > > --- a/northd/inc-proc-northd.c
> > > +++ b/northd/inc-proc-northd.c
> > > @@ -155,6
On Tue, Jul 30, 2024 at 9:34 AM Lorenzo Bianconi
wrote:
>
> Introduce bfd, static_routes, route_policies and bfd_sync nodes to northd I-P
> engine to track bfd connections and northd static_route/policy_route
> changes.
>
> Reported-at: https://issues.redhat.com/browse/FDP-600
> Signed-off-by: Lor
On Mon, Jul 29, 2024 at 2:44 PM Numan Siddique wrote:
>
> On Mon, Jul 29, 2024 at 2:58 PM Han Zhou wrote:
> >
> > + @Dmitry Yusupov
> >
> > Reported-by: Dmitry Yusupov
> >
> > On Mon, Jul 29, 2024 at 11:42 AM Han Zhou wrote:
> > >
> > &
+ @Dmitry Yusupov
Reported-by: Dmitry Yusupov
On Mon, Jul 29, 2024 at 11:42 AM Han Zhou wrote:
>
> In 24.03 branch 'OVN' was used as the package name which breaks debian
> build:
>
> dpkg-gencontrol: error: source package name 'OVN' is illegal: character &
In 24.03 branch 'OVN' was used as the package name which breaks debian
build:
dpkg-gencontrol: error: source package name 'OVN' is illegal: character 'O' not
allowed
Signed-off-by: Han Zhou
---
debian/changelog | 6 +++---
1 file changed, 3 insertions(+), 3 del
On Sat, Jul 20, 2024 at 8:22 AM Lorenzo Bianconi
wrote:
>
> > On Fri, Jul 19, 2024 at 9:20 AM Lorenzo Bianconi
> > wrote:
> > >
> > > [...]
> > > >
> > > > Hi Han,
> > > >
> > > > I had suggested Lorenzo to add a new node to do the sync for the
> > > > reasons Lorenzo mentioned.
> > > > I'm fine
patch introduces the ovn-encap-ip-default option,
allowing the configuration of a default IP to be used to ensure
deterministic encap IP selection in such cases.
Signed-off-by: Han Zhou
---
NEWS| 3 +++
controller/binding.c| 13 +-
controller
On Fri, Jul 19, 2024 at 9:20 AM Lorenzo Bianconi
wrote:
>
> [...]
> >
> > Hi Han,
> >
> > I had suggested Lorenzo to add a new node to do the sync for the
> > reasons Lorenzo mentioned.
> > I'm fine with your suggestion or any other optimization or re-ordering
> > as long as we can
> > avoid loopi
On Thu, Jul 18, 2024 at 8:34 AM Lorenzo Bianconi
wrote:
>
> Introduce bfd, static_routes and route_policies nodes to northd I-P
> engine to track bfd connections and northd static_route/policy_route
> changes.
>
> Acked-by: Numan Siddique
> Reported-at: https://issues.redhat.com/browse/FDP-600
>
On Wed, Jul 10, 2024 at 11:24 AM Lorenzo Bianconi
wrote:
>
> Introduce bfd, static_routes and route_policies nodes to northd I-P
> engine to track bfd connections and northd static_route/policy_route
> changes.
>
> Acked-by: Numan Siddique
> Reported-at: https://issues.redhat.com/browse/FDP-600
>
On Thu, Jun 6, 2024 at 3:38 PM wrote:
>
> From: Numan Siddique
>
> It is expected that a provider network logical switch has a localnet logical
> switch port in order to bridge the overlay traffic to the underlay traffic.
> There can be some usecases where a overlay logical switch (without
> a lo
On Wed, May 29, 2024 at 5:26 AM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
>
> Introduce bfd and bfd_consumer nodes to northd I-P engine to track bfd
> connections and northd static_route/policy_route changes.
>
> Reported-at: https://issues.redhat.com/browse/FDP-600
> Signed-off-by: Lo
On Wed, Mar 13, 2024 at 12:00 AM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
>
> Introduce ECMP_Nexthop table in the SB db in order to track active
> ecmp-symmetric-reply connections and flush stale ones.
>
> Signed-off-by: Lorenzo Bianconi
> ---
> northd/en-northd.c | 4 +++
>
== ff:ff:ff:ff:ff:ff to the IPv6 NS responder flows, which is
obviously wrong. Please ignore my feedback for the current patch and we can
address IPv6 in a separate patch if it is required.
Thanks,
Han
> On Wed, May 22, 2024 at 12:16 AM Han Zhou wrote:
>>
>>
>>
>> On Tue, May
On Tue, May 21, 2024 at 9:56 PM Numan Siddique wrote:
>
> On Mon, May 20, 2024 at 1:47 AM Vasyl Saienko
wrote:
> >
> > Thanks for feedback Numan.
> >
> > On Wed, May 15, 2024 at 12:04 AM Numan Siddique wrote:
> >
> > > On Mon, May 13, 2024 at 9:00 AM Dumitru Ceara
wrote:
> > > >
> > > > On 5/4/
On Mon, May 20, 2024 at 5:32 PM Indrajitt Valsaraj <
indrajitt.valsa...@nutanix.com> wrote:
>
> Issue:
> In case of a Logical_Router without mac_binding_age_threshold set or a
> Logical_Router with an incorrectly formatted mac_binding_threshold
> option, entries were not being purged from the Mac B
On Thu, May 16, 2024 at 10:09 PM Indrajitt Valsaraj <
indrajitt.valsa...@nutanix.com> wrote:
>
> Issue:
> In case of a Logical_Router without mac_binding_age_threshold set or a
> Logical_Router with an incorrectly formatted mac_binding_threshold
> option, entries were not being purged from the Mac
On Thu, May 2, 2024 at 8:22 AM Lorenzo Bianconi
wrote:
>
> Introduce bfd and bfd_consumer nodes to northd I-P engine to track bfd
> connections and northd static_route/policy_route changes.
>
> Reported-at: https://issues.redhat.com/browse/FDP-600
> Signed-off-by: Lorenzo Bianconi
Hi Lorenzo,
T
On Fri, May 10, 2024 at 9:23 AM Numan Siddique wrote:
>
> On Fri, May 10, 2024 at 2:37 AM Han Zhou wrote:
> >
> > On Thu, May 9, 2024 at 10:32 AM Mark Michelson
wrote:
> > >
> > > On 5/7/24 02:12, Han Zhou wrote:
> > > >
> >
On Thu, May 9, 2024 at 10:32 AM Mark Michelson wrote:
>
> On 5/7/24 02:12, Han Zhou wrote:
> >
> >
> > On Mon, May 6, 2024 at 10:37 PM Ales Musil > <mailto:amu...@redhat.com>> wrote:
> > >
> > >
> > >
> > >
On Mon, May 6, 2024 at 10:37 PM Ales Musil wrote:
>
>
>
> On Mon, May 6, 2024 at 8:41 PM Han Zhou wrote:
>>
>>
>>
>> On Thu, May 2, 2024 at 10:35 PM Ales Musil wrote:
>> >
>> > On Thu, May 2, 2024 at 6:23 PM Han Zhou wrote:
>> > &
On Thu, May 2, 2024 at 10:35 PM Ales Musil wrote:
>
> On Thu, May 2, 2024 at 6:23 PM Han Zhou wrote:
> >
> >
> >
> > On Thu, May 2, 2024 at 6:29 AM Ales Musil wrote:
> > >
> > > Instead of tracking address set per struct expr_constant_set track it
On Thu, May 2, 2024 at 9:01 AM Numan Siddique wrote:
>
> On Mon, Apr 22, 2024 at 2:41 AM Han Zhou wrote:
> >
> > The current comments are obviously conflicting. Fixing it according the
> > current implementation - static route overrides src-ip route.
> >
> >
On Thu, May 2, 2024 at 6:29 AM Ales Musil wrote:
>
> Instead of tracking address set per struct expr_constant_set track it
> per individual struct expr_constant. This allows more fine grained
> control for I-P processing of address sets in controller. It helps with
> scenarios like matching on two
On Tue, Apr 30, 2024 at 9:56 AM Ales Musil wrote:
>
> Instead of tracking address set per struct expr_constant_set track it
> per individual struct expr_constant. This allows more fine grained
> control for I-P processing of address sets in controller. It helps with
> scenarios like matching on tw
On Fri, Apr 12, 2024 at 8:20 AM Ales Musil wrote:
>
> Instead of tracking address set per struct expr_constant_set track it
> per individual struct expr_constant. This allows more fine grained
> control for I-P processing of address sets in controller. It helps with
> scenarios like matching on tw
On Tue, Apr 23, 2024 at 2:50 AM Martin Kalcok
wrote:
>
> Signed-off-by: Martin Kalcok
> ---
> ovn-sb.xml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ovn-sb.xml b/ovn-sb.xml
> index f9fb6c304..bf4689f12 100644
> --- a/ovn-sb.xml
> +++ b/ovn-sb.xml
> @@ -1456,7 +14
The current comments are obviously conflicting. Fixing it according the
current implementation - static route overrides src-ip route.
Signed-off-by: Han Zhou
---
northd/northd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/northd/northd.c b/northd/northd.c
index
existing user would depend on the old behavior. Thinking it
more carefully, for OVN it seems not possible because the ovn-encap-ip used
as the local_ip is always the one shared to other chassis through SB DB. So
now I think we should be safe to change the default behavior.
Ack
On Wed, Apr 10, 2024 at 6:52 AM Simon Horman wrote:
>
> Hi,
>
> I would like to announce that the primary development branch for OvS
> has been renamed main.
>
> The rename occurred a little earlier today.
>
> OVS is currently hosted on GitHub. We can expect the following behaviour
> after the ren
On Thu, Mar 21, 2024 at 10:05 AM Ilya Maximets wrote:
>
> On 3/14/24 06:23, Han Zhou wrote:
> >
> >
> > On Fri, Apr 22, 2022 at 1:41 AM Eelco Chaudron mailto:echau...@redhat.com>> wrote:
> >>
> >>
> >>
> >> On 15 Apr 2022, at 13:
On Thu, Apr 4, 2024 at 10:03 AM Mark Michelson wrote:
>
> Thanks for the fix, Han.
>
> Acked-by: Mark Michelson
Thanks Mark. Applied to main and backported.
Han
>
> On 4/4/24 02:47, Han Zhou wrote:
> > Fixes: bbf2f941965a ("ofctrl: Wait at S_WAIT_BEFORE_CLEAR o
Fixes: bbf2f941965a ("ofctrl: Wait at S_WAIT_BEFORE_CLEAR only once.")
Signed-off-by: Han Zhou
---
tests/ovn-controller.at | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tests/ovn-controller.at b/tests/ovn-controller.at
index 3202f0beff46..f2c792c9c
On Tue, Apr 2, 2024 at 11:11 PM Han Zhou wrote:
>
>
>
> On Tue, Apr 2, 2024 at 10:48 PM Han Zhou wrote:
> >
> >
> >
> > On Thu, Mar 28, 2024 at 1:29 PM Mark Michelson
wrote:
> > >
> > > Thanks Han,
> > >
> > > Acked-by: M
On Tue, Apr 2, 2024 at 10:48 PM Han Zhou wrote:
>
>
>
> On Thu, Mar 28, 2024 at 1:29 PM Mark Michelson
wrote:
> >
> > Thanks Han,
> >
> > Acked-by: Mark Michelson
>
> Thanks Mark. Applied to main.
Also backported down to branch-23.06
Han
>
&
On Thu, Mar 28, 2024 at 1:29 PM Mark Michelson wrote:
>
> Thanks Han,
>
> Acked-by: Mark Michelson
Thanks Mark. Applied to main.
Han
>
> On 3/28/24 02:58, Han Zhou wrote:
> > The ovn-ofctrl-wait-before-clear setting is designed to minimize
> > downtime during t
On Wed, Mar 20, 2024 at 4:07 PM Han Zhou wrote:
>
>
>
> On Mon, Mar 18, 2024 at 11:27 AM Mark Michelson
wrote:
> >
> > Hi Han,
> >
> > I have a comment below
> >
> > On 3/5/24 01:27, Han Zhou wrote:
> > > The ovn-ofctrl-wait-before-clear
educe
down time during upgrade.")
Signed-off-by: Han Zhou
---
v2: Addressed Mark's comments - made test case more reliable.
controller/ofctrl.c | 1 -
tests/ovn-controller.at | 9 +++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/controller/ofctrl.c b/cont
On Wed, Mar 27, 2024 at 12:46 AM Ales Musil wrote:
>
> On Wed, Mar 27, 2024 at 7:14 AM Han Zhou wrote:
>
> >
> >
> > On Tue, Mar 19, 2024 at 9:45 AM Ales Musil wrote:
> > >
> > >
> > >
> > > On Tue, Mar 19, 2024 at 5:43 PM Ales
On Tue, Mar 19, 2024 at 9:45 AM Ales Musil wrote:
>
>
>
> On Tue, Mar 19, 2024 at 5:43 PM Ales Musil wrote:
>>
>> Instead of tracking address set per struct expr_constant_set track it
>> per individual struct expr_constant. This allows more fine grained
>> control for I-P processing of address se
hey either
have all
> + * the append requests queued up for them before the
leadership
> + * transfer message or their connection is broken and we
will not
> + * transfer anyway. */
> +threshold = 0;
> +}
> +goto re
On Wed, Mar 20, 2024 at 12:48 PM Mark Michelson wrote:
>
> Thanks Ales, looks good to me.
>
> Acked-by: Mark Michelson
>
Thanks Ales and Mark. I applied to main and backported down to branch-23.06.
Han
> On 3/19/24 11:57, Ales Musil wrote:
> > The memory usage would be increased for size of sb
t;/s$j \
> + cluster/failure-test \
> +transfer-leadership-after-starting-to-add \
> +| grep -q "engaged"])
> +done
> +
> +AT_CHECK([ovsdb-server -v -vconsole:off -vsyslog:off \
> +
o deal
with disruptive server.")
> Signed-off-by: Ilya Maximets
Thanks for the fix.
Acked-by: Han Zhou
> ---
> ovsdb/raft.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ovsdb/raft.c b/ovsdb/raft.c
> index 237d7ebf5..c41419052 100644
> --
struct raft_server *s;
> +struct hmap servers;
> +
> +error = raft_servers_from_json(e->servers, &servers);
> +ovs_assert(!error);
> +HMAP_FOR_EACH (s, hmap_node, &servers) {
> +struct raft_server *server
raft_reset_ping_timer(raft);
> }
>
> +uint64_t interval = raft->joining
> +? 1000 :
RAFT_TIMER_THRESHOLD(raft->election_timer);
nit: the hardcoded joining timer value 1000 is used at least 3 places, so
probably better to define a macro for it.
Acked-b
On Tue, Mar 19, 2024 at 12:05 AM Felix Huettner via dev <
ovs-dev@openvswitch.org> wrote:
>
> On Mon, Mar 18, 2024 at 05:52:12PM +0100, Ilya Maximets wrote:
> > On 3/18/24 17:15, Felix Huettner wrote:
> > > On Fri, Mar 15, 2024 at 09:14:49PM +0100, Ilya Maximets wrote:
> > >> Each cluster member ty
On Mon, Mar 18, 2024 at 11:27 AM Mark Michelson wrote:
>
> Hi Han,
>
> I have a comment below
>
> On 3/5/24 01:27, Han Zhou wrote:
> > The ovn-ofctrl-wait-before-clear setting is designed to minimize
> > downtime during the initial start-up of the ovn-controller.
On Wed, Mar 20, 2024 at 2:56 AM Dumitru Ceara wrote:
>
> On 3/20/24 06:41, Han Zhou wrote:
> > ovn-controller runs at 100% cpu when OVS exits. This is because the
> > ofctrl_run is not called while ofctrl_wait is always called in the main
> > loop. Because of the missin
ing a chance to run ofctrl_run
as long as ofctrl_wait is called.
Fixes: 1d6d953bf883 ("controller: Don't artificially limit group and meter IDs
to 16bit.")
Fixes: 94cbc59dc0f1 ("ovn-controller: Fix use of dangling pointers in I-P
runtime_data.")
Signed-off-by: Han
On Fri, Apr 22, 2022 at 1:41 AM Eelco Chaudron wrote:
>
>
>
> On 15 Apr 2022, at 13:25, wenx05124...@163.com wrote:
>
> > From: wenxu
> >
> > The netdev-offload in tc mode can't work with flow-restore-wait.
> > When the vswitchd restart with flow-restore-wait, the tc qdisc
> > will be delete in n
t; + * type from the netdev layer directly.
> + * When a port deleted, the corresponding netdev is also removed
from
> + * netdev_shash. netdev_get_type_from_name returns NULL in such
case.
> + * We should try to get type from ofport->netdev. */
nit: th
On Fri, Mar 8, 2024 at 12:17 AM Tao Liu wrote:
>
>
> On 3/7/24 5:39 AM, Ilya Maximets wrote:
> > On 2/27/24 20:14, Han Zhou wrote:
> >> For kernel datapath, when a new tunnel port is created in the same
> >> transaction in which an old tunnel port with the
educe
down time during upgrade.")
Signed-off-by: Han Zhou
---
controller/ofctrl.c | 1 -
tests/ovn-controller.at | 9 +++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/controller/ofctrl.c b/controller/ofctrl.c
index f14cd79a8dbb..0d72ecbaa167 100644
--- a/controlle
On Fri, Mar 1, 2024 at 2:26 AM Dumitru Ceara wrote:
>
> On 2/16/24 07:52, Han Zhou wrote:
> > In commit 41eefcb2807d, the format of external_ids:ovn-chassis-id for
> > tunnels was modified to include the local encapsulation IP. This change
> > can lead to the recreat
eric approach to
just re-run the bridge_reconfigure() when there are any port creations
encountered "File exists" error, which indicates a possible resource
conflict may have happened due to a later deleted port, and retry may
succeed.
Signed-off-by: Han Zhou
---
This is RFC because I am not
on maintainers. But it is severe enough, IMO.
>
Thanks Ilya. The fix looks good to me. And I think it is ok to backport,
since the change is simple enough.
Acked-by: Han Zhou
Just curious, how would the OVS perform with this large number of meters?
Thanks,
Han
> controller/ofctrl.c
On Fri, Feb 16, 2024 at 2:50 PM Numan Siddique wrote:
>
> On Mon, Feb 12, 2024 at 2:49 PM Han Zhou wrote:
> >
> > The MFF_LOG_ENCAP_ID register was defined to save the encap ID and avoid
> > changing across pipelines, but in the function
> > load_logical
reate separate tunnels for multiple local encap
IPs.")
Signed-off-by: Han Zhou
---
controller/encaps.c | 83 -
tests/ovn-controller.at | 44 ++
2 files changed, 110 insertions(+), 17 deletions(-)
diff --git a/controller/
t;hmap_node, hash);
> } else {
> @@ -1350,8 +1349,10 @@ dp_refcnt_use(struct hmap *dp_refcnts_map, size_t
dp_index)
> struct dp_refcnt *dp_refcnt = dp_refcnt_find(dp_refcnts_map,
dp_index);
>
> if (!dp_refcnt) {
> -dp_refcnt = xzalloc(sizeof *dp_refcnt);
> +dp_refcnt = xmalloc(sizeof *dp_refcnt);
> dp_refcnt->dp_index = dp_index;
> +/* Allocation is happening on the second (!) use. */
> +dp_refcnt->refcnt = 1;
>
> hmap_insert(dp_refcnts_map, &dp_refcnt->key_node, dp_index);
> }
> --
> 2.43.0
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Thanks Ilya and Numan.
Acked-by: Han Zhou
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_insert(&lflow_ref->lflow_ref_nodes, &lrn->ref_node,
hash);
> }
> -
> lrn->linked = true;
> }
>
> --
> 2.43.0
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Thanks Numan for the fix.
Acked-by: Han Zhou
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
,
> +if (!sset_contains(&lr_stateful_rec->lb_ips->ips_v4,
> nat->external_ip)) {
> build_lswitch_rport_arp_req_flow(
> nat->external_ip, AF_INET, sw_op, sw_od, 80, lfl
stinfo/ovs-dev
Thanks Numan. The patch LGTM except that the function
build_lr_nat_defrag_and_lb_default_flows() doesn't seem to be the right
place to add the flow. I'd either add a new function, or just call the
ovn_lflow_add_default_drop directly in
build_lswitch_and_lrouter_iterate_by_lr for this flow.
With this addressed:
Acked-by: Han Zhou
Regards,
Han
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
it by ensuring the register is loaded only
in the flows of table 0, which is where packets from VIFs enter the
pipeline for the first time.
Fixes: 17b6a12fa286 ("ovn-controller: Support VIF-based local encap IPs
selection.")
Signed-off-by: Han Zhou
---
controller/physical.c | 28 --
On Mon, Feb 5, 2024 at 7:47 PM Numan Siddique wrote:
>
> On Mon, Feb 5, 2024 at 9:41 PM Han Zhou wrote:
> >
> > On Mon, Feb 5, 2024 at 4:12 PM Numan Siddique wrote:
> > >
> > > On Mon, Feb 5, 2024 at 5:54 PM Han Zhou wrote:
> > > >
>
On Mon, Feb 5, 2024 at 4:12 PM Numan Siddique wrote:
>
> On Mon, Feb 5, 2024 at 5:54 PM Han Zhou wrote:
> >
> > On Mon, Feb 5, 2024 at 10:15 AM Ilya Maximets
wrote:
> > >
> > > On 2/5/24 15:45, Ilya Maximets wrote:
> > > > On 2/5/24 11:34, Ilya M
On Mon, Feb 5, 2024 at 10:15 AM Ilya Maximets wrote:
>
> On 2/5/24 15:45, Ilya Maximets wrote:
> > On 2/5/24 11:34, Ilya Maximets wrote:
> >> On 2/5/24 09:23, Dumitru Ceara wrote:
> >>> On 2/5/24 08:13, Han Zhou wrote:
> >>>> On S
On Sun, Feb 4, 2024 at 9:26 PM Numan Siddique wrote:
>
> On Sun, Feb 4, 2024 at 9:53 PM Han Zhou wrote:
> >
> > On Sun, Feb 4, 2024 at 5:46 AM Ilya Maximets wrote:
> > >
> > > >>>
> > > >>> > 35 files changed, 9681 insertions(+)
as branch-24.03 was created. I'm more than happy to
submit
> > follow up patches if you have any comments to address. Please let me
know.
> >>
> >
> > Hi Numan,
> >
> > I was writing the reply and saw your email just now. Thanks a lot for
> > taking
On Thu, Feb 1, 2024 at 5:30 PM Han Zhou wrote:
>
>
>
> On Mon, Jan 29, 2024 at 1:36 AM Dumitru Ceara wrote:
> >
> > On 1/29/24 07:20, Ales Musil wrote:
> > > Considering following topology:
> > > client - sw0 - lrp0 - lr - lrp1 - sw1 - server
>
On Mon, Jan 29, 2024 at 1:36 AM Dumitru Ceara wrote:
>
> On 1/29/24 07:20, Ales Musil wrote:
> > Considering following topology:
> > client - sw0 - lrp0 - lr - lrp1 - sw1 - server
> > sw0 in subnet 192.168.0.0/24
> > sw1 in subnet 172.168.0.0/24
> > SNAT configured for client
> > gateway_mtu=1400
On Tue, Jan 30, 2024 at 3:35 AM Dumitru Ceara wrote:
>
> On 1/30/24 08:59, Ales Musil wrote:
> > On Tue, Jan 30, 2024 at 8:58 AM Ales Musil wrote:
> >
> >> The Fedora version of grep (grep (GNU grep) 3.11) complains
> >> about the syntax grep "output\:": grep: warning: stray \ before :
> >>
> >>
On Mon, Jan 29, 2024 at 2:41 AM Ales Musil wrote:
>
>
>
> On Fri, Jan 26, 2024 at 8:05 PM Han Zhou wrote:
>>
>>
>>
>> On Thu, Jan 25, 2024 at 10:54 PM Ales Musil wrote:
>> >
>> >
>> >
>> > On Fri, Jan 26, 2024 at 4:07 AM
On Mon, Jan 29, 2024 at 7:11 PM Numan Siddique wrote:
> On Thu, Jan 25, 2024 at 1:08 AM Han Zhou wrote:
> >
> > On Thu, Jan 11, 2024 at 7:32 AM wrote:
> > >
> > > From: Numan Siddique
> > >
> > > ovn_lflow_add() and other related function
On Thu, Jan 25, 2024 at 10:54 PM Ales Musil wrote:
>
>
>
> On Fri, Jan 26, 2024 at 4:07 AM Han Zhou wrote:
>>
>>
>>
>> On Tue, Jan 23, 2024 at 5:29 AM Ales Musil wrote:
>> >
>> >
>> >
>> > On Wed, Jan 17, 2024 at 6:48
On Thu, Jan 25, 2024 at 8:22 AM Numan Siddique wrote:
>
> On Tue, Jan 23, 2024 at 2:40 AM Han Zhou wrote:
> >
> > On Mon, Jan 22, 2024 at 7:11 PM Numan Siddique wrote:
> > >
> > > On Mon, Jan 22, 2024 at 4:03 PM Han Zhou wrote:
> > > >
> &
On Fri, Jan 26, 2024 at 10:26 AM Han Zhou wrote:
>
>
>
> On Fri, Jan 26, 2024 at 7:53 AM Aaron Conole wrote:
> >
> > Han Zhou writes:
> >
> > > On Thu, Jan 25, 2024 at 12:55 PM Aaron Conole
wrote:
> > >>
> > >> From: Kevin S
On Fri, Jan 26, 2024 at 7:53 AM Aaron Conole wrote:
>
> Han Zhou writes:
>
> > On Thu, Jan 25, 2024 at 12:55 PM Aaron Conole
wrote:
> >>
> >> From: Kevin Sprague
> >>
> >> During normal operations, it is useful to understand when a particular
On Thu, Jan 25, 2024 at 12:55 PM Aaron Conole wrote:
>
> From: Kevin Sprague
>
> During normal operations, it is useful to understand when a particular
flow
> gets removed from the system. This can be useful when debugging
performance
> issues tied to ofproto flow changes, trying to determine dep
On Tue, Jan 23, 2024 at 5:29 AM Ales Musil wrote:
>
>
>
> On Wed, Jan 17, 2024 at 6:48 AM Han Zhou wrote:
>>
>> Commit dd527a283cd8 partially supported multiple encap IPs. It supported
>> remote encap IP selection based on the destination VIF's encap_ip
&g
On Mon, Jan 22, 2024 at 6:36 AM Ales Musil wrote:
>
> On Mon, Jan 22, 2024 at 9:09 AM Felix Huettner via dev <
> ovs-dev@openvswitch.org> wrote:
>
> > On Fri, Jan 19, 2024 at 04:33:28PM -0500, Mark Michelson wrote:
> > > With this change, a chassis may only update MAC Binding records that
it
> > >
scenario for both lflows (p8) and SB load balancers (p15) .
Thanks Numan. I went through this version of the series. I tried my best to
review in details but I can't say I examined every lines of the changes.
The major comments are about the implicit dependency related to p4, p5, p6,
p7, a
;lflows_ref_list) {
> -if (dec_dp_refcnt(&lrn->lflow->dp_refcnts_map,
> - lrn->dp_index)) {
> -bitmap_set0(lrn->lflow->dpg_bitmap, lrn->dp_index);
> +if (lrn->dpgrp_lflow) {
> +
On Wed, Jan 24, 2024 at 10:07 PM Han Zhou wrote:
>
>
>
> On Thu, Jan 11, 2024 at 7:32 AM wrote:
> >
> > From: Numan Siddique
> >
> > ovn_lflow_add() and other related functions/macros are now moved
> > into a separate module - lflow-mgr.c. This module
On Thu, Jan 11, 2024 at 7:32 AM wrote:
>
> From: Numan Siddique
>
> ovn_lflow_add() and other related functions/macros are now moved
> into a separate module - lflow-mgr.c. This module maintains a
> table 'struct lflow_table' for the logical flows. lflow table
> maintains a hmap to store the lo
1 - 100 of 1002 matches
Mail list logo
