On Fri, Aug 11, 2023 at 5:36 AM Dumitru Ceara wrote:
>
> On 8/10/23 17:53, Han Zhou wrote:
> > Today the localnet ports are added to local_lports unconditionally.
> > This has several side-effects:
> >
> > - When ovn-monitor-all is true, all localnet ports a
On Fri, Aug 11, 2023 at 6:23 AM Dumitru Ceara wrote:
>
> On 8/1/23 12:51, Han Zhou wrote:
> > On Tue, Jul 18, 2023 at 6:16 AM Dumitru Ceara wrote:
> >>
> >> On 7/18/23 12:14, Han Zhou wrote:
> >>> On Mon, Jul 17, 2023 at 9:51 PM Dumitru Ceara
wrote:
On Fri, Aug 11, 2023 at 6:07 AM Dumitru Ceara wrote:
>
> On 8/10/23 18:38, Ilya Maximets wrote:
> > On 8/10/23 17:34, Dumitru Ceara wrote:
> >> On 8/10/23 17:20, Han Zhou wrote:
> >>> On Thu, Aug 10, 2023 at 6:36 AM Dumitru Ceara
wrote:
> >>>>
>
Thanks Vladislav and Dumitru for reporting and fixing the issue.
The impact of the issue is more than just the memory spikes in
ovn-controller. More importantly, it incurs much higher load on SB DB
because the conditions are flooded with all the localnet ports regardless
of whether they belong to l
such huge conditions from every node.
[0] https://mail.openvswitch.org/pipermail/ovs-dev/2023-July/406201.html
Signed-off-by: Han Zhou
---
controller/binding.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/controller/binding.c b/controller/binding.c
On Thu, Aug 10, 2023 at 8:34 AM Dumitru Ceara wrote:
>
> On 8/10/23 17:20, Han Zhou wrote:
> > On Thu, Aug 10, 2023 at 6:36 AM Dumitru Ceara wrote:
> >>
> >> On 8/10/23 15:34, Han Zhou wrote:
> >>> On Thu, Aug 10, 2023 at 2:29 AM Dumitru Ceara
wrote:
On Thu, Aug 10, 2023 at 6:36 AM Dumitru Ceara wrote:
>
> On 8/10/23 15:34, Han Zhou wrote:
> > On Thu, Aug 10, 2023 at 2:29 AM Dumitru Ceara wrote:
> >>
> >> On 8/10/23 08:12, Ales Musil wrote:
> >>> On Wed, Aug 9, 2023 at 5:13 PM Mark Michelson
> &
On Thu, Aug 10, 2023 at 2:29 AM Dumitru Ceara wrote:
>
> On 8/10/23 08:12, Ales Musil wrote:
> > On Wed, Aug 9, 2023 at 5:13 PM Mark Michelson
wrote:
> >
> >> Hi Ales,
> >>
> >> I have some high-level comments/questions about this patch.
> >>
> >
> > Hi Mark,
> >
>
> Hi Ales, Mark,
>
> > thank yo
ario because it may be quite common
in environments like ovn-k8s when the first LSP is added to a LS or the
last LSP is deleted from it.
Please also find some minor comments below.
With those addressed:
Acked-by: Han Zhou
> Fixes: b337750e45be ("northd: Incremental proces
On Tue, Jul 18, 2023 at 6:16 AM Dumitru Ceara wrote:
>
> On 7/18/23 12:14, Han Zhou wrote:
> > On Mon, Jul 17, 2023 at 9:51 PM Dumitru Ceara wrote:
> >>
> >> On 7/14/23 08:41, Ales Musil wrote:
> >>> On Thu, Jul 13, 2023 at 4:39 PM Dumitru Ceara
wr
On Tue, Jul 25, 2023 at 10:38 AM wrote:
>
> From: Numan Siddique
>
> This patch series adds the support to handle load balancer and
> load balancer group changes incrementally in the "northd" engine
> node. "flow" engine node doesn't support I-P yet and falls back
> to full recompute. Changes t
On Tue, Jul 25, 2023 at 1:28 AM Numan Siddique wrote:
>
> On Fri, Jul 14, 2023 at 6:54 PM Numan Siddique wrote:
> >
> > On Wed, Jul 12, 2023 at 9:26 PM Han Zhou wrote:
> > >
> > > On Sat, Jul 8, 2023 at 3:57 AM Mark Michelson
wrote:
> > > >
&g
On Wed, Jul 19, 2023 at 2:01 AM Numan Siddique wrote:
>
> On Tue, Jul 18, 2023 at 11:08 AM Han Zhou wrote:
> >
> > On Fri, Jul 7, 2023 at 1:56 PM wrote:
> > >
> > > From: Numan Siddique
> > >
> > > When a logical router gets updated due
On Mon, Jul 17, 2023 at 9:51 PM Dumitru Ceara wrote:
>
> On 7/14/23 08:41, Ales Musil wrote:
> > On Thu, Jul 13, 2023 at 4:39 PM Dumitru Ceara wrote:
> >
> >> Regular dp-hash is not a canonical L4 hash (at least with the netlink
> >> datapath). If the datapath supports l4 symmetrical dp-hash use
ing the upgrade.
Signed-off-by: Han Zhou
---
v1 -> v2: Address comments from Ilya.
NEWS | 7 +++-
ovsdb/raft-rpc.c | 22 ++-
ovsdb/raft-rpc.h | 3 ++
ovsdb/raft.c | 88 ++
tests/ovsdb-cluster.at | 42 +
On Fri, Jul 7, 2023 at 1:56 PM wrote:
>
> From: Numan Siddique
>
> When a logical router gets updated due to load balancer
> or load balancer groups changes, it is now incrementally
> handled in the 'northd' engine node. Other logical router
> updates result in the full recompute of 'northd' eng
On Fri, Jul 7, 2023 at 1:55 PM wrote:
>
> From: Numan Siddique
>
> For every a given load balancer group 'A', northd engine data maintains
> a bitmap of datapaths associated to this lb group. So when lb group 'A'
> gets associated to a logical switch 's1', the bitmap index of 's1' is set
> in it
On Fri, Jul 14, 2023 at 9:12 PM Numan Siddique wrote:
>
> On Thu, Jul 13, 2023 at 7:40 AM Han Zhou wrote:
> >
> > On Wed, Jul 12, 2023 at 11:54 PM Han Zhou wrote:
> > >
> > >
> > >
> > > On Sat, Jul 8, 2023 at 3:57 AM Mark Michelson
wrote
On Fri, Jul 7, 2023 at 1:54 PM wrote:
>
> From: Numan Siddique
>
> Logical switch change handler of the 'northd' engine node
> now also handles changes to load balancers.
>
> Signed-off-by: Numan Siddique
> ---
> lib/lb.c| 17 +++-
> lib/lb.h| 2 +
> northd/northd.c
c_logical_switch *ls)
> +check_unsupported_inc_proc_for_ls_changes(
+1 for refactoring.
Would it be even more clear to name it "ls_changes_can_be_handled"?
(returning false means need to fall back to recompute)
Acked-by: Han Zhou
> +const struct nbrec_logi
On Wed, Jul 12, 2023 at 11:54 PM Han Zhou wrote:
>
>
>
> On Sat, Jul 8, 2023 at 3:57 AM Mark Michelson wrote:
> >
> > Hi Numan,
> >
> > I have one small nit below.
>
> +1
> Acked-by: Han Zhou
>
Sorry that I forgot one small comment regarding t
On Tue, Jul 11, 2023 at 10:41 PM Numan Siddique wrote:
>
> On Sat, Jul 8, 2023 at 1:27 AM Mark Michelson wrote:
> >
> > Hi Numan,
> >
> > I gave the series a look. I've looked at the code but haven't yet run
> > any tests with it. The main reason for this is that the series does not
> > apply cle
up_changes tracked_deleted_lb_groups;
> };
>
> I think option (2) is my preference.
I prefer option (1), because the names of the fields in struct
tracked_lb_data already tells the purpose, and the only member "update" in
the struct tracked_lb_changes is unnecessary. In additio
On Sat, Jul 8, 2023 at 3:57 AM Mark Michelson wrote:
>
> Hi Numan,
>
> I have one small nit below.
+1
Acked-by: Han Zhou
>
> On 7/7/23 01:53, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > This patch separates out the 'lbs' and 'lb_gr
On Fri, Jul 7, 2023 at 1:53 PM wrote:
>
> From: Numan Siddique
>
> Similar to the commit [1], a new sub-engine node "sync_to_sb_lb"
> is added with-in the "sync_to_sb" to sync the SB load balancers.
> Its main input nodes are "northd" (to access the "lbs" hmap built
> by this node) and "sb_load_b
On Fri, Jul 7, 2023 at 8:31 PM Ales Musil wrote:
>
>
>
> On Fri, Jul 7, 2023 at 8:30 AM Han Zhou wrote:
>>
>> After the commit 0c1bde1c4a the recompute counters are more predictable,
>> so we changed the LSP incremental processing test to not tolerate any
>>
On Fri, Jul 7, 2023 at 2:02 PM Numan Siddique wrote:
>
> On Fri, Jul 7, 2023 at 6:40 AM Han Zhou wrote:
> >
> > On Thu, Jul 6, 2023 at 9:55 PM Numan Siddique wrote:
> > >
> > > On Thu, Jul 6, 2023 at 3:32 PM Han Zhou wrote:
> > > >
> > >
interfere with our I-P tests.
Fixes: 0c1bde1c4a47 ("ovn-northd: Avoid recompute caused by in-flight
transactions.")
Signed-off-by: Han Zhou
---
tests/ovn-northd.at | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at
index e79d33b2aec5..3e
On Mon, Jul 3, 2023 at 9:46 PM Ilya Maximets wrote:
>
> On 7/1/23 04:43, Han Zhou wrote:
> >
> >
> > On Fri, Jun 30, 2023 at 4:30 PM Ilya Maximets mailto:i.maxim...@ovn.org>> wrote:
> >>
> >> On 6/25/23 19:35, Han Zhou wrote:
> >&g
On Thu, Jul 6, 2023 at 9:55 PM Numan Siddique wrote:
>
> On Thu, Jul 6, 2023 at 3:32 PM Han Zhou wrote:
> >
> > Although each individual VIF port related changes are handled
> > incrementally, it still triggers recompute if there are in-flight
> > transactions (eit
On Fri, Jun 30, 2023 at 10:27 PM Numan Siddique wrote:
>
> On Sat, Jul 1, 2023 at 7:33 AM Han Zhou wrote:
> >
> > On Thu, Jun 29, 2023 at 10:54 PM Numan Siddique wrote:
> > >
> > > On Sun, Jun 18, 2023 at 11:48 AM Han Zhou wrote:
> > > >
&g
On Thu, Jun 29, 2023 at 10:10 PM Numan Siddique wrote:
>
> On Fri, Jun 30, 2023 at 7:00 AM Han Zhou wrote:
> >
> > On Thu, Jun 29, 2023 at 9:19 AM Dumitru Ceara wrote:
> > >
> > > On 6/27/23 10:23, Numan Siddique wrote:
> > > >
ight transactions), and when skippiing
the runs it keeps the tracked changes in IDL across main loop
iterations. This way we avoid recompute without worrying about missing
any changes.
Signed-off-by: Han Zhou
---
northd/inc-proc-northd.c | 6 +--
northd/ovn-northd.c | 22 +
tests/ovn-north
This patch achieves zero recompute for VIF updates and deletions in
common scenarios. The performance gain for these scenarios is similar to
the patch "northd: Incremental processing of VIF additions in 'lflow'
node."
Signed-off-by: Han Zhou
Acked-by: Numan Siddique
tness without repeating excessive checks already covered by
the feature tests.
Signed-off-by: Han Zhou
---
tests/ovn-northd.at | 29 +
1 file changed, 29 insertions(+)
diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at
index 36f3b91a54c1..f1bf9092eeb7 100644
--- a/
On Fri, Jun 30, 2023 at 4:30 PM Ilya Maximets wrote:
>
> On 6/25/23 19:35, Han Zhou wrote:
> > When a server becomes unstable due to overloading or intermittent
> > partitioning, it may miss some heartbeats and then starts election with
> > a new term, which would disru
On Thu, Jun 29, 2023 at 10:54 PM Numan Siddique wrote:
>
> On Sun, Jun 18, 2023 at 11:48 AM Han Zhou wrote:
> >
> > This patch achieves zero recompute for VIF updates and deletions in
> > common scenarios. The performance gain for these scenarios is similar to
> >
On Thu, Jun 29, 2023 at 10:06 PM Numan Siddique wrote:
>
> On Fri, Jun 30, 2023 at 7:01 AM Han Zhou wrote:
> >
> > On Thu, Jun 29, 2023 at 4:57 AM Dumitru Ceara wrote:
> > >
> > > On 6/18/23 08:17, Han Zhou wrote:
> > > > For incremental p
On Fri, Jun 30, 2023 at 6:35 AM Lucas Martins wrote:
>
> Hi all,
>
> On Thu, Apr 27, 2023 at 7:08 PM Han Zhou wrote:
> >
> >
> >
> > On Thu, Apr 27, 2023 at 10:15 AM Ihar Hrachyshka
wrote:
> > >
> > > On Wed, Apr 19, 2023 at 5:1
On Fri, Jun 30, 2023 at 1:07 AM Dumitru Ceara wrote:
>
> On 6/29/23 08:42, Han Zhou wrote:
> > If the ovs port used as output_port in mirror is deleted (either by
> > mistake or intentionally), ovn-controller would crash in the
> > check_and_update_interface_table() when t
On Fri, Jun 30, 2023 at 5:53 AM Dumitru Ceara wrote:
>
> On 6/28/23 08:22, Han Zhou wrote:
> > The test case intended to ensure there are no more than 3 failures in 10
> > runs. However, it used "break" to exit the loop whenever a failure is
> > encountered, en
On Thu, Jun 29, 2023 at 4:57 AM Dumitru Ceara wrote:
>
> On 6/18/23 08:17, Han Zhou wrote:
> > For incremental processing, we need to maintain SB lflow uuids in
> > northd. For this reason, we generate the row uuid when creating the
> > Logical_Flow record in SB DB, rathe
On Thu, Jun 29, 2023 at 9:19 AM Dumitru Ceara wrote:
>
> On 6/27/23 10:23, Numan Siddique wrote:
> > On Mon, Jun 26, 2023 at 10:34 PM Han Zhou wrote:
> >>
> >> On Mon, Jun 26, 2023 at 7:25 AM Numan Siddique wrote:
> >>>
> >>> On Sun, Jun 1
On Thu, Jun 29, 2023 at 4:23 AM Dumitru Ceara wrote:
>
> On 6/29/23 04:18, Han Zhou wrote:
> > When multiple LSP deletions are handled in incremental processing, if it
> > hits a LSP that can't be incrementally processed after incrementally
> > processing some LS
cases are captured in the updated test case of this patch.
This patch fixes the problem by verifying the existance of the mirror port, and
creates it if needed.
Fixes: ba8aa26e44cb ("OVN Remote Port Mirroring: controller changes to create
ovs mirrors")
Signed-off-by: Han Zhou
---
On Wed, Jun 28, 2023 at 1:17 PM Han Zhou wrote:
>
>
>
> On Wed, Jun 28, 2023 at 12:07 PM Dumitru Ceara wrote:
> >
> > On 6/28/23 19:28, Han Zhou wrote:
> > > On Wed, Jun 28, 2023 at 2:14 AM Dumitru Ceara
wrote:
> > >>
> > >> On 6/27/23
node.")
Reported-by: Dumitru Ceara
Signed-off-by: Han Zhou
---
northd/northd.c | 12 +---
tests/ovn-northd.at | 45 +
2 files changed, 54 insertions(+), 3 deletions(-)
diff --git a/northd/northd.c b/northd/northd.c
index a45c8b53
On Wed, Jun 28, 2023 at 12:07 PM Dumitru Ceara wrote:
>
> On 6/28/23 19:28, Han Zhou wrote:
> > On Wed, Jun 28, 2023 at 2:14 AM Dumitru Ceara wrote:
> >>
> >> On 6/27/23 19:47, Han Zhou wrote:
> >>> On Tue, Jun 27, 2023 at 6:51 AM Dumitru Ceara
wrot
On Wed, Jun 28, 2023 at 5:46 AM Dumitru Ceara wrote:
>
> On 6/2/23 06:11, Han Zhou wrote:
> > This patch introduces a change handler for 'northd' input within the
> > 'lflow' node. It specifically handles cases when VIFs are created, which
> > is an e
On Wed, Jun 28, 2023 at 2:14 AM Dumitru Ceara wrote:
>
> On 6/27/23 19:47, Han Zhou wrote:
> > On Tue, Jun 27, 2023 at 6:51 AM Dumitru Ceara wrote:
> >>
> >> On 6/8/23 07:55, Han Zhou wrote:
> >>> On Wed, Jun 7, 2023 at 12:39 PM Numan Siddique wrot
uot; instead.
Fixes: 8c30ba13869e ("ovn-northd.at: Fix unstable LSP incremental processing
test.")
Signed-off-by: Han Zhou
---
tests/ovn-northd.at | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at
index ada2d2a4aa5e..88fe9
On Thu, Jun 22, 2023 at 1:12 AM Dumitru Ceara wrote:
>
> On 6/21/23 16:50, Han Zhou wrote:
> > On Wed, Jun 21, 2023 at 2:48 AM Dumitru Ceara wrote:
> >>
> >> We don't need to explicitly add port bindings that were already bound
> >> locally. We
On Tue, Jun 27, 2023 at 6:51 AM Dumitru Ceara wrote:
>
> On 6/8/23 07:55, Han Zhou wrote:
> > On Wed, Jun 7, 2023 at 12:39 PM Numan Siddique wrote:
> >>
> >> On Fri, Jun 2, 2023 at 12:13 AM Han Zhou wrote:
> >>>
> >>> This patch introd
On Mon, Jun 26, 2023 at 7:25 AM Numan Siddique wrote:
>
> On Sun, Jun 18, 2023 at 11:48 AM Han Zhou wrote:
> >
> > For incremental processing, it is important to maintain relationship
> > between the inputs and the logical flows generated. This patch creates
> >
d safe for upgrades.
Signed-off-by: Han Zhou
---
ovsdb/raft-rpc.c | 19 -
ovsdb/raft-rpc.h | 3 ++
ovsdb/raft.c | 88 ++
tests/ovsdb-cluster.at | 42
4 files changed, 127 insertions(+), 25 deletions(-)
di
Signed-off-by: Han Zhou
---
ovsdb/raft.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ovsdb/raft.h b/ovsdb/raft.h
index 403ed3dd7321..a5b55d9bf031 100644
--- a/ovsdb/raft.h
+++ b/ovsdb/raft.h
@@ -26,7 +26,8 @@
* ==
*
* Based on Diego Ongaro's Ph.D. t
gt; +++ b/ovn-nb.xml
> @@ -1302,7 +1302,11 @@
>
> The VM interface through which the nested container sends its
network
> traffic. This must match the column for
some
> -other .
> +other . Note: for performance
> +reasons, unlike for regular VIFs, ovn-controller
will
It may be better to say "for performance of OVN Southbound database
conditional monitoring ...", otherwise the user might be confused.
> +register to get updates about all OVN Southbound database
> + table records
> +that correspond to nested container ports.
Better to add: "..., even if 'ovn-monitor-all' is set to false. See
ovn-controlller (8)." or something similar.
Please feel free to adjust the words and merge.
Acked-by: Han Zhou
>
>
>
> --
> 2.31.1
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ttps://mail.openvswitch.org/mailman/listinfo/ovs-dev
LGTM for both patches. Thanks Dumitru!
Acked-by: Han Zhou
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Jun 20, 2023 at 12:48 AM Dumitru Ceara wrote:
>
> On 6/20/23 03:49, Han Zhou wrote:
> > On Tue, Jun 6, 2023 at 7:57 AM Dumitru Ceara wrote:
> >>
> >> We don't need to explicitly add port bindings that were already bound
> >> locally. We
icing SB
DB performance (probably they don't have very high port density so the
conditional monitoring impact is not that big). I am not aware of any such
users yet, but if they complain, we will have to provide a knob, if no
better ideas.
Other than this, the patch looks goo
This patch achieves zero recompute for VIF updates and deletions in
common scenarios. The performance gain for these scenarios is similar to
the patch "northd: Incremental processing of VIF additions in 'lflow'
node."
Signed-off-by: Han Zhou
---
north
patch also refactors the temp_lflow_list operations to
collected_lflows with helper functions to start and end collecting. It
still uses global variables just to avoid updating all the lflow_add_...
related code all over the northd.c file.
Signed-off-by: Han Zhou
---
northd/northd.c | 271
For incremental processing, we need to maintain SB lflow uuids in
northd. For this reason, we generate the row uuid when creating the
Logical_Flow record in SB DB, rather than waiting for SB DB to populate
back.
Signed-off-by: Han Zhou
---
northd/northd.c | 12 ++--
1 file changed, 10
This series closes the gaps of ovn-northd incremental processing for VIF
updates and deletions, with the help of the changes that maintain lflow uuids
and the link between lflows and the input ovn_ports.
Han Zhou (3):
northd.c: Generate and maintain SB lflow uuid in ovn_lflow.
northd.c
On Wed, Jun 14, 2023 at 4:16 AM Dumitru Ceara wrote:
>
> On 6/10/23 20:10, Han Zhou wrote:
> > The test case is unstable because there are many factors that can impact
> > the number of recomputes. For example, when northd updates both NB and
> > SB, both sides have in-fli
On Tue, Jun 13, 2023 at 6:44 AM Mark Michelson wrote:
>
> On 6/12/23 22:07, Han Zhou wrote:
> >
> >
> > On Mon, Jun 12, 2023 at 11:05 AM Mark Michelson > <mailto:mmich...@redhat.com>> wrote:
> > >
> > > Hi Han,
> > >
that when merging.
Or I can do the same and send a v2 waiting for Ack for patch2.
Thanks,
Han
> On 6/9/23 15:12, Han Zhou wrote:
> > Connections and SSL columns are not used by ovn-northd. Omit them in
> > IDL.
> >
> > This is not a functional problem, but it may h
mitru Ceara
Signed-off-by: Han Zhou
---
v1 -> v2: wait ports up and sync after each port binding, to avoid race.
v2 -> v3: refactor and test case and use a probability based test strategy
to ensure the test stability (see commit message).
tests/ovn-nor
d, to avoid the
race.
Reported-by: Dumitru Ceara
Signed-off-by: Han Zhou
---
v1 -> v2: wait ports up and sync after each port binding, to avoid race.
tests/ovn-northd.at | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/tests/ovn-northd.at b/tests/ovn-northd.
fix to unblock the build.
https://github.com/ovn-org/ovn/commit/38644f0590ccc1ad4a09e794c8507430a4529cad
Thanks,
Han
>
> >
> > On 6/8/23 11:27, Numan Siddique wrote:
> >> On Thu, Jun 8, 2023 at 2:04 AM Han Zhou wrote:
> >>>
> >>> On Wed, Jun 7, 2023 at 12:47 P
On Fri, Jun 9, 2023 at 11:53 AM Mark Michelson wrote:
>
> On 6/9/23 06:25, Dumitru Ceara wrote:
> > Hi Mark,
> >
> > Thanks for your feedback on this!
> >
> > On 6/8/23 21:58, Mark Michelson wrote:
> >> In theory, this idea is great. By removing the recheck, our CI will
> >> potentially turn red m
On Thu, Jun 8, 2023 at 3:32 AM Dumitru Ceara wrote:
>
> On 6/8/23 07:57, Han Zhou wrote:
> > On Wed, Jun 7, 2023 at 2:05 PM Numan Siddique wrote:
> >>
> >> On Fri, Jun 2, 2023 at 12:12 AM Han Zhou wrote:
> >>>
> >>> Maintai
d, to avoid the
race.
Reported-by: Dumitru Ceara
Signed-off-by: Han Zhou
---
tests/ovn-northd.at | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at
index 9f2f15abca8f..633b35df616d 100644
--- a/tests/ovn-northd.at
+++ b/tests/ovn-nort
re_lsp_down is
true.")
Reported-by: Dumitru Ceara
Signed-off-by: Han Zhou
---
northd/northd.c | 8
1 file changed, 8 insertions(+)
diff --git a/northd/northd.c b/northd/northd.c
index 2aad2e425a00..6a5c02c7a08c 100644
--- a/northd/northd.c
+++ b/northd/northd.c
@@ -17602,6 +17602,
l be fixed in a separate patch).
Signed-off-by: Han Zhou
---
northd/ovn-northd.c | 4
1 file changed, 4 insertions(+)
diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index 0b8bbfb95cf7..647f60c8583f 100644
--- a/northd/ovn-northd.c
+++ b/northd/ovn-northd.c
@@ -818,6 +818,10 @@ mai
On Tue, Jun 6, 2023 at 11:37 PM Ales Musil wrote:
>
> The incremental processing is broken for addresses
> that have mask which could "erase" portion of the address
> itself e.g. 10.16.0.47/4, after applying the mask with token
> parser the address becomes 0.0.0.0/4, which is fine for
> logical fl
. LGTM except a nit in patch-3, which can be fixed while
merging. For the series:
Acked-by: Han Zhou
> ---
> V3 -> V4 differences:
> * Rebased
> * Added Dumitru's acks from v1 to patches 1, 4, 5, and 8.
> * Updated patch 7 to have fewer scheduled point-releases based on
or the timing of each stage:
>
> .. _long-term-support:
>
> -Long-term Support Releases
> +Long-term Support Versions
s/Versions/Branches
With this addressed:
Acked-by: Han Zhou
> --
>
> -The OVN project will periodically designate a release as &quo
On Wed, Jun 7, 2023 at 2:05 PM Numan Siddique wrote:
>
> On Fri, Jun 2, 2023 at 12:12 AM Han Zhou wrote:
> >
> > Maintain a set of lsp names that are referenced in the column
> > "ip_port_mappings" of load_balancer records (used for health check
> &
On Wed, Jun 7, 2023 at 12:39 PM Numan Siddique wrote:
>
> On Fri, Jun 2, 2023 at 12:13 AM Han Zhou wrote:
> >
> > This patch introduces a change handler for NB logical_switch within the
> > 'northd' node. It specifically handles cases where logical switc
by destroying the initial change set every time new columns
> are added to the monitor. This will trigger re-generation of the
> change set and it will contain all the necessary columns afterwards.
>
> Fixes: 07c27226ee96 ("ovsdb: Monitor: Keep and m
On Tue, Jun 6, 2023 at 3:08 PM Ilya Maximets wrote:
>
> On 6/6/23 22:12, Han Zhou wrote:
> >
> >
> > On Tue, Jun 6, 2023 at 12:10 PM Ilya Maximets mailto:i.maxim...@ovn.org>> wrote:
> >>
> >> On 3/27/23 21:43, Ilya Maximets wrote:
> >> &
On Thu, Jun 1, 2023 at 2:55 PM Han Zhou wrote:
>
>
>
> On Wed, May 31, 2023 at 11:16 PM Ales Musil wrote:
> >
> >
> >
> > On Thu, Jun 1, 2023 at 7:44 AM Han Zhou wrote:
> >>
> >>
> >>
> >> On Wed, May 24, 2023 at 11:27 PM A
On Tue, Jun 6, 2023 at 12:10 PM Ilya Maximets wrote:
>
> On 3/27/23 21:43, Ilya Maximets wrote:
> > Change sets in OVSDB monitor are storing all the changes that happened
> > between a particular transaction ID and now. Initial change set
> > basically contains all the data.
> >
> > On each monit
On Mon, Jun 5, 2023 at 8:58 AM Vladislav Odintsov wrote:
>
> Hi Dumitru, Ilya, Han,
>
> do you guys have any comments here?
> I’m gonna start working on this change in near future...
>
> Thank you.
>
> On 17 May 2023, at 18:34, Numan Siddique wrote:
>
> On Wed, May 17, 2023 at 4:44 AM Vladislav O
On Fri, Jun 2, 2023 at 8:05 AM Numan Siddique wrote:
>
> On Fri, Jun 2, 2023 at 12:13 AM Han Zhou wrote:
> >
> > For changes such as nb_cfg related columns, don't trigger recompute.
> >
> > Signed-off-by: Han Zhou
> > Reviewed-by: Ales Musil
>
&g
On Fri, Jun 2, 2023 at 8:02 AM Numan Siddique wrote:
>
> On Fri, Jun 2, 2023 at 12:12 AM Han Zhou wrote:
> >
> > MAC_Binding table is to store neighbour cache for logical router
> > datapaths to resolve unknown IP addresses to MAC. The datapath field is
> >
On Fri, Jun 2, 2023 at 8:01 AM Numan Siddique wrote:
>
> On Fri, Jun 2, 2023 at 12:12 AM Han Zhou wrote:
> >
> > Refactor so that ENGINE_NODE_WITH_CLEAR_TRACK_DATA_IS_VALID can be used
outside
> > of functions.
> >
> > Signed-off-by: Han Zhou
> > Re
On Fri, Jun 2, 2023 at 7:56 AM Numan Siddique wrote:
>
> On Fri, Jun 2, 2023 at 12:12 AM Han Zhou wrote:
> >
> > This patch ensures logical flows remain persistent between engine runs,
> > given there are no changes. In case of any change, it will deconstruct
> > a
On Fri, Jun 2, 2023 at 7:39 AM Numan Siddique wrote:
>
> On Fri, Jun 2, 2023 at 12:12 AM Han Zhou wrote:
> >
> > bfd_connections isn't related to the I-P engine node "northd". So move
> > it from the northd_data to a local variable of en_lflow_run().
> &
that would have been
triggered by SB port_binding changes. Now for common VIF changes there
is zero recompute of "northd" node.
Signed-off-by: Han Zhou
Reviewed-by: Ales Musil
---
northd/en-northd.c | 18 ++
northd/en-northd.h | 1 +
northd/inc-proc-n
, which is
in fact unnecessary. When the LSP is updated, northd can directly update
the options:additional-chassis-activated when the column
requested_additional_chassis is updated at the same time.
Signed-off-by: Han Zhou
Reviewed-by: Ales Musil
---
northd/northd.c | 6 +++---
1 file changed, 3
This change avoids the unnecessary change handling in "lflow" when
NB_Global:options:ignore_lsp_down is true (default) if the only change
of the LSP is the column "up". This further reduces the number of
recompute of "lflow" to zero for the VIF creation-and-binding
sync-to-sb node but the input is from the other direction. This enables
handling SB changes in different (more efficient) ways from each node.
Signed-off-by: Han Zhou
Reviewed-by: Ales Musil
---
northd/automake.mk | 2 +
northd/en-northd.c | 12 --
northd/en-sync
The SB logical_flow table and multicast_group tables should be updated
by northd only. Omitting the alerts (making them write-only) avoids
unnecessary recompute triggered in northd.
Signed-off-by: Han Zhou
Reviewed-by: Ales Musil
---
northd/ovn-northd.c | 8
1 file changed, 8
ote: the test uses only 1 thread of ovn-northd for flow
recompute. Using multithread should show a larger percentage of
improvement.
Signed-off-by: Han Zhou
Reviewed-by: Ales Musil
---
lib/ovn-util.c | 15 ++
lib/ovn-util.h | 1 +
northd/en-northd.c | 130 ++---
letion: 30ms
It is more than 95% reduction (or 20x faster).
Signed-off-by: Han Zhou
Reviewed-by: Ales Musil
---
northd/en-lflow.c| 82 -
northd/en-lflow.h| 1 +
northd/inc-proc-northd.c | 2 +-
northd/northd.c | 245 +
For changes such as nb_cfg related columns, don't trigger recompute.
Signed-off-by: Han Zhou
Reviewed-by: Ales Musil
---
northd/en-northd.c | 26 ++
northd/en-northd.h | 1 +
northd/inc-proc-northd.c | 3 ++-
tests/ovn-northd.at | 6 +++---
4
Maintain a set of lsp names that are referenced in the column
"ip_port_mappings" of load_balancer records (used for health check
purpose), which will be used for lsp incremental processing.
Signed-off-by: Han Zhou
Reviewed-by: Ales Musil
---
northd/northd.c | 21 ++-
This patch moves the logic responsible for adding ports to the 'unknown'
multicast group. This logic is now part of the build_mcast_groups()
function. This not only improves readability but also removes the
unnecessary dependency of mcast_groups from build_lflows().
Signed-off-by
201 - 300 of 1002 matches
Mail list logo
