Re: [ovs-dev] [PATCH 0/7] userspace: Support for L3 tunneling

Thanks for this contribution, Jan & al! I’ll start reviewing these right away. Please find my comment addressing your concern below, > On Feb 3, 2017, at 2:37 AM, Jan Scheurich wrote: > > This patch set is part of an initiative to deal with non-Ethernet packets in

Re: [ovs-dev] OVS - ODL Sync on OF Bundle in 1.3

ht.org/view/OpenDaylight_OpenFlow_Plugin:Main > <https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Main> > > I will also send a separate meeting invite once you confirm. > > Abhijit > > From: Jarno Rajahalme <ja...@ovn.org <mailto:ja...@ovn.org>> > Date: Wedne

Re: [ovs-dev] [BUG] upcall handler thread crash

> On Feb 5, 2017, at 10:49 PM, wangyunjian wrote: > > My ovs version is > openvswitch-2.5.0(http://openvswitch.org/releases/openvswitch-2.5.0.tar.gz). > I had modified the code as follows and getted other crash. Do it need a lock > to protect the operations > of

Re: [ovs-dev] [userspace clone v3 1/4] dpif-netdev: Avoid sending probe packets

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 20, 2017, at 6:05 PM, Andy Zhou <az...@ovn.org> wrote: > > When ofproto probe for datapath features, no packets should actually > be sent to the network. This pactch fixes the userspace by dropping > probe pack

Re: [ovs-dev] [PATCH v2 1/2] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

The userspace CLONE action is now merged to OVS master, so you can rebase the patches to use that. Jarno > On Jan 24, 2017, at 3:49 AM, Zoltán Balogh wrote: > > Hi, > > All right, we will rebase the code once the patch is merged. > > Could you have a look at

Re: [ovs-dev] OVS - ODL Sync on OF Bundle in 1.3

;>, Sharath > Kumar V <sharath.kuma...@ericsson.com <mailto:sharath.kuma...@ericsson.com>>, > Kanagasundaram K <kanagasundara...@ericsson.com > <mailto:kanagasundara...@ericsson.com>>, Sunil Kumar G > <sunil.g.ku...@ericsson.com <mailto:sunil.g.ku...@eric

Re: [ovs-dev] Sync on PTAP, EXT-382 and NSH

I also missed the meeting, did not have it my calendar, sorry. Jarno > On Jan 24, 2017, at 5:52 AM, Jiri Benc wrote: > > On Wed, 18 Jan 2017 09:53:18 +, Jan Scheurich wrote: >> Please be invited to the next sync meeting. > > Sorry, won't make the meeting today. Too

Re: [ovs-dev] [PATCH v2 3/3] ovs-router: introduce pkt-mark.

Also, IMO this series is good to go to the branch-2.7 as well. Jarno > On Jan 25, 2017, at 2:54 PM, Jarno Rajahalme <ja...@ovn.org> wrote: > > With a few remarks below, > > Acked-by: Jarno Rajahalme <ja...@ovn.org <mailto:ja...@ovn.org>> > >> On

Re: [ovs-dev] [userspace meter v3 3/5] dpif: Meter framework.

It feels weird reviewing my own code from past. What if I make a pass of fixing the problems I see and send a new version of the remaining patches for review? Jarno > On Jan 24, 2017, at 10:45 PM, Andy Zhou <az...@ovn.org> wrote: > > From: Jarno Rajahalme <ja...@ovn.org>

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

> On Jan 27, 2017, at 1:01 PM, Thomas Morin <thomas.mo...@orange.com> wrote: > > Jarno, > > 2017-01-27, Jarno Rajahalme: >> Cleanest solution would be to use the new clone action for the datapath, >> which, if important, we could also backport to OVS 2.5.x. &g

Re: [ovs-dev] [PATCH v2 1/3] tunnel: Add support to configure ptk_mark

With one correction below, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 24, 2017, at 9:57 PM, Pravin B Shelar <pshe...@ovn.org> wrote: > > Today packet mark action is broken for Tunnel ports with > tunnel monitoring. User can write a flow to set pkt-mark

Re: [ovs-dev] [PATCH v2 3/3] ovs-router: introduce pkt-mark.

With a few remarks below, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 24, 2017, at 9:57 PM, Pravin B Shelar <pshe...@ovn.org> wrote: > > OVS router is basically partial copy of linux kernel FIB. > kernel routing table uses skb-mark along with usual routing >

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

to use the new clone action for the datapath, which, if important, we could also backport to OVS 2.5.x. Datapath CLONE is yet to be upstreamed, though, may take a little time. Jarno > -Thomas > > 2017-01-06, Jarno Rajahalme: >> I sent a patch to do this fix on OVS master. IMO

[ovs-dev] [PATCH] mirror: Allow concurrent lookups.

itself) was tested by Yunjian Wang and was found to fix the observed crash when running a script that adds and deletes a port repeatedly. Reported-by: Yunjian Wang <wangyunj...@huawei.com> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif-m

Re: [ovs-dev] [BUG] upcall handler thread crash

Again, thanks for reporting this bug! I just posted a more complete patch to fix this issue to the ova-dev list. Please have a look. Jarno > On Feb 7, 2017, at 4:36 AM, wangyunjian wrote: > > I have tested patch without issue. Will you submit it as an official

[ovs-dev] [PATCH 12/21] lib: Check match and action prerequisities with 'match'.

validity checking due to the conntrack state having and 'invalid' bit, but not 'valid' bit. One way to match an valid conntrack state is to match on the 'tracked' bit being one and 'invalid' bit being zero. The latter requires the corresponding mask bit be verified. Signed-off-by: Jarno Rajahalme <

[ovs-dev] [PATCH 14/21] flow: Make room after ct_state.

'ct_state' currently only needs 8 bits, so we can make room for a new CT field introduced in the next patch. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- include/openvswitch/flow.h | 3 ++- lib/flow.c | 3 ++- lib/match.c| 8 lib/pac

[ovs-dev] [PATCH 11/21] netlink: Simplify nl_msg_start_nested().

Since there is no data to copy nl_msg_put_unspec_uninit() may be used directly, rather than via nl_msg_put_unspec(). Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netlink.c b/lib/netlink.c index a

[ovs-dev] [PATCH 04/21] datapath: Fix comments for skb->_nfct

Upstream commit: commit 5e17da634a21b1200853fe82ba67d6571f2beabe Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:52 2017 -0800 openvswitch: Fix comments for skb->_nfct Fix comments referring to skb 'nfct' and 'nfctinfo' fields now that they are

[ovs-dev] [PATCH 03/21] datapath: add and use nf_ct_set helper

f_conn entry and the ctinfo bits to an sk_buff. This avoids changing code in followup patch that merges skb->nfct and skb->nfctinfo into skb->_nfct. Signed-off-by: Florian Westphal <f...@strlen.de> Signed-off-by: Pablo Neira Ayuso <pa...@netfilter.org> Signed-off-b

[ovs-dev] [PATCH 13/21] datapath: Add original direction conntrack tuple to sw_flow_key.

Upstream commit: commit 9dd7f8907c3705dc7a7a375d1c6e30b06e6daffc Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:59 2017 -0800 openvswitch: Add original direction conntrack tuple to sw_flow_key. Add the fields of the conntrack original direction 5

[ovs-dev] [PATCH 17/21] compat: nf_ct_delete compat.

ct nf_conn has member 'timeout' of type 'struct timer_list'. The following patch introduces the first caller to nf_ct_delete() in the OVS kernel module. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- acinclude.m4 | 4 .../linux/comp

Re: [ovs-dev] Sync on PTAP, EXT-382 and NSH

Thanks for the invite. In general I’d prefer if the email title or body would also contain the proposed meeting date & time. I started review of the L3 userspace patches 3 weeks ago, but unfortunately have been swamped by urgent release tasks ever since. This should ease a bit next week.

Re: [ovs-dev] [PATCH 1/2] ofproto/bond: Fix bond reconfiguration race condition.

LGTM, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Feb 23, 2017, at 1:31 PM, Andy Zhou <az...@ovn.org> wrote: > > During the upcall thread bond output translation, bond_may_recirc() > is currently called outside the lock. In case the main thread executes > bond_rec

Re: [ovs-dev] [PATCH 2/2] ofproto/bond: Fix bond post recirc rule leak.

Looks right to me, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Feb 23, 2017, at 1:31 PM, Andy Zhou <az...@ovn.org> wrote: > > When bond is removed or when its configuration changes, > the post recirculation rules that are installed by current > bond configurat

[ovs-dev] [PATCH 02/21] datapath: add and use skb_nfct helper

and changes its type so add a helper to avoid intrusive rename change later. Signed-off-by: Florian Westphal <f...@strlen.de> Signed-off-by: Pablo Neira Ayuso <pa...@netfilter.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- acinclude.m4

[ovs-dev] [PATCH 01/21] datapath: make ndo_get_stats64 a void function

ts64 to have a void function. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> Signed-off-by: David S. Miller <da...@davemloft.net> This seems to be fine for all prior Linux versions as well. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/vport-int

[ovs-dev] [PATCH 05/21] datapath: Use inverted tuple in ovs_ct_find_existing() if NATted.

Upstream commit: commit 9ff464db50e437eef131f719cc2e9902eea9c607 Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:53 2017 -0800 openvswitch: Use inverted tuple in ovs_ct_find_existing() if NATted. The conntrack lookup for existing connections fails to

[ovs-dev] [PATCH 06/21] datapath: Do not trigger events for unconfirmed connections.

Upstream commit: commit 193e30967897f3a8b6f9f137ac30571d832c2c5c Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:54 2017 -0800 openvswitch: Do not trigger events for unconfirmed connections. Receiving change events before the 'new' event for the connecti

[ovs-dev] [PATCH 07/21] datapath: Unionize ovs_key_ct_label with a u32 array.

Upstream commit: commit cb80d58fae76d8ea93555149b2b16e19b89a1f4f Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:55 2017 -0800 openvswitch: Unionize ovs_key_ct_label with a u32 array. Make the array of labels in struct ovs_key_ct_label an union,

[ovs-dev] [PATCH 08/21] datapath: Simplify labels length logic.

Upstream commit: commit b87cec3814ccc7f6afb0a1378ee7e5110d07cdd3 Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:56 2017 -0800 openvswitch: Simplify labels length logic. Since 23014011ba42 ("netfilter: conntrack: support a fixed size of 128

[ovs-dev] [PATCH 15/21] odp: Support conntrack orig tuple key.

Userspace support for datapath original direction conntrack tuple. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- build-aux/extract-ofp-fields| 3 + include/openvswitch/flow.h | 14 ++- include/openvswitch/match.h | 16 +++ include/openvswitch/meta-flow.h

[ovs-dev] [PATCH 19/21] conntrack: Force commit.

Userspace support for force commit. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- include/openvswitch/ofp-actions.h | 7 +++- lib/conntrack.c | 16 ++-- lib/conntrack.h | 2 +- lib/dpif-netdev.c | 8 +++- lib/odp-

[ovs-dev] [PATCH 16/21] actions: Add resubmit with conntrack tuple.

-by: Jarno Rajahalme <ja...@ovn.org> --- include/openvswitch/ofp-actions.h | 4 +- lib/ofp-actions.c | 82 +++-- ofproto/ofproto-dpif-xlate.c | 68 ++--- tests/ofp-actions.at | 6 ++ tests/ofproto-dpif.at

[ovs-dev] [PATCH 20/21] datapath: Add a missing comment.

Make openvswitch.h better match upstream by adding a missing comment. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/linux/compat/include/linux/openvswitch.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/datapath/linux/compat/include/linux/openvswitch.h b/datapath

[ovs-dev] [PATCH 18/21] datapath: Add force commit.

Upstream patch: commit dd41d33f0b033885211a5d6f3ee19e73238aa9ee Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:22:00 2017 -0800 openvswitch: Add force commit. Stateful network admission policy may allow connections to one direction and reject conne

[ovs-dev] [PATCH 00/21] Conntrack enhancements.

and use skb_nfct helper datapath: add and use nf_ct_set helper Jarno Rajahalme (18): datapath: Fix comments for skb->_nfct datapath: Use inverted tuple in ovs_ct_find_existing() if NATted. datapath: Do not trigger events for unconfirmed connections. datapath: Unionize ovs_key_ct_la

[ovs-dev] [PATCH 09/21] datapath: Refactor labels initialization.

Upstream commit: Refactoring conntrack labels initialization makes changes in later patches easier to review. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Acked-by: Pravin B Shelar <pshe...@ovn.org> Acked-by: Joe Stringer <j...@ovn.org> Signed-off-b

[ovs-dev] [PATCH 10/21] datapath: Inherit master's labels.

Upstream commit: commit 09aa98ad496d6b11a698b258bc64d7f64c55d682 Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:58 2017 -0800 openvswitch: Inherit master's labels. We avoid calling into nf_conntrack_in() for expected connections, as that would

[ovs-dev] [PATCH 21/21] tests: Add an FTP test without conntrack.

If FTP tests with conntrack fail, it is informative to know if the problem is with the FTP client and/or server, or with conntrack itself. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- tests/system-traffic.at | 29 + 1 file changed, 29 insertions(+) diff

[ovs-dev] [PATCH v5 0/4] Userspace meter implementation.

ofproto_check_ofpacts(), as doing so would take more analysis. - Note that the "execution with help" is broken. Userspace datapath execution should never need help, so this is OK for now. Jarno Rajahalme (4): dpif: Meter framework. ofproto: Fix thread safety annotation. ofpr

[ovs-dev] [PATCH v5 1/4] dpif: Meter framework.

Add DPIF-level infrastructure for meters. Allow meter_set to modify the meter configuration (e.g. set the burst size if unspecified). Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- datapath/linux/compat/include/linux/openvswitch.h | 4

[ovs-dev] [PATCH v5 2/4] ofproto: Fix thread safety annotation.

ofproto_check_ofpacts() requires ofproto_mutex, but the header did not tell that so the trace did not take the mutex. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif-trace.c | 2 ++ ofproto/ofproto-provider.h | 3 ++- 2 files changed, 4 insertions(+), 1 de

[ovs-dev] [PATCH v5 3/4] ofproto: Meter translation.

Translate OpenFlow METER instructions to datapath meter actions. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- include/openvswitch/ofp-actions.h | 1 + lib/dpif.c| 47 +++--- lib/o

[ovs-dev] [PATCH v5 4/4] dpif-netdev: Simple DROP meter implementation.

of the meter bands are hit, we need to process the packets individually. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/dpif-netdev.c| 380 --- tests/dpif-netdev.at | 106 ++ 2 f

[ovs-dev] [PATCH v4 4/4] dpif-netdev: Simple DROP meter implementation.

of the meter bands are hit, we need to process the packets individually. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/dpif-netdev.c| 362 --- tests/dpif-netdev.at | 106 +++ 2 f

[ovs-dev] [PATCH v4 3/4] ofproto: Meter translation.

Translate OpenFlow METER instructions to datapath meter actions. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- include/openvswitch/ofp-actions.h | 1 + lib/dpif.c| 47 +++--- lib/o

[ovs-dev] [PATCH 2/8] datapath: use percpu flow stats

Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/flow.c | 42 ++ datapath/fl

[ovs-dev] [PATCH 0/8] Upstream Linux kernel datapath backports.

Many contributors are currently working on backporting upstream Linux kernel datapath changes to the OVS tree kernel datapath. This series addresses apparent gaps in this work as follows: In this series: 08733a0 netfilter: handle NF_REPEAT from nf_conntrack_in() Already applied: 56989f6

[ovs-dev] [PATCH 1/8] datapath: fix flow stats accounting when node 0 is not possible

.net> This patch contained a memory leak that is fixed in this backport. The next patch silently fixed that in upstream, too. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/flow.c | 6 -- datapath/flow_table.c | 3 ++- 2 files changed, 6 insertions(+), 3 deletion

[ovs-dev] [PATCH 4/8] datapath: avoid resetting flow key while installing new flow.

da...@davemloft.net> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/datapath.c | 8 datapath/flow.c | 2 -- datapath/flow_netlink.c | 6 -- datapath/flow_netlink.h | 3 ++- 4 files changed

[ovs-dev] [PATCH 3/8] datapath: Fix Frame-size larger than 1024 bytes warning.

than 1024 bytes [-Wframe-larger-than=] Signed-off-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/datapath.c

[ovs-dev] [PATCH 5/8] datapath: remove unused functions

t's the only caller of free_vport_rcu thus this one can be removed, too. Signed-off-by: Jiri Benc <jb...@redhat.com> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Jarno Rajahalme <ja...@ovn.org

[ovs-dev] [PATCH 6/8] datapath: remove unnecessary EXPORT_SYMBOLs

s are really used only by openvswitch.ko. Remove the exports. Tested by loading all 4 openvswitch modules, nothing breaks. Signed-off-by: Jiri Benc <jb...@redhat.com> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft

[ovs-dev] [PATCH 7/8] datapath: use core MTU range checking in core net infra

ler <da...@davemloft.net> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Upstream commit: commit 425df17ce3a26d98f76e2b6b0af2acf4aeb0b026 Author: Jarno Rajahalme <ja...@ovn.org> Date: Tue Feb 14 21:16:28 2017 -0800 openvswitch: Set internal device max mtu to

[ovs-dev] [PATCH 8/8] datapath: handle NF_REPEAT from nf_conntrack_in()

.@netfilter.org> This upstream change is impossible to detect at module compile time, so we keep the NF_REPEAT check after the nf_conntrack_in() call. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/conntrack.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/datapat

Re: [ovs-dev] [PATCH] doc: Describe backporting process.

Thanks for writing this up - makes my life a little bit easier :-) Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Feb 15, 2017, at 3:05 PM, Joe Stringer <j...@ovn.org> wrote: > > This patch documents the backporting process, and provides a walkthrough > for developers wh

Re: [ovs-dev] [PATCH 3/3] ovs-router: introduce pkt-mark.

> On Dec 28, 2016, at 1:44 AM, Pravin B Shelar wrote: > > OVS router is basically partial copy of linux kernel FIB. > kernel routing table use skb-mark along with usual routing “use”->”uses” Could you elaborate a bit here, is the kernel doing a simple exact match of the

Re: [ovs-dev] [PATCH 2/3] routing-table: parse skb-mark from RTNETLINK msg

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Dec 28, 2016, at 1:44 AM, Pravin B Shelar <pshe...@ovn.org> wrote: > > Keep track of skb-mark of given RTNL routing notification. > This will be used by next commit. > > Signed-off-by: Pravin B Shelar <pshe...@ovn.o

Re: [ovs-dev] OVS - ODL Sync on OF Bundle in 1.3

Wednesday, 18 January, 2017 16:23 > To: Jan Scheurich; Abhijit Kumbhare; Zoltán Balogh; László Sürü; Miklós > Pelyva; Jozef Bacigál; Tomáš Slušný; Prasanna Huddar; Shuva Jyoti Kar; > Sharath Kumar V; Kanagasundaram K; Sunil Kumar G; D Arunprakash; Muthukumaran > K; Jarno Rajahalme (ja...@

Re: [ovs-dev] [PATCH 1/3] tunnel: Add support to configure ptk_mark

Pravin, Sorry for the delay, I hope you find time to respond. > On Dec 28, 2016, at 1:44 AM, Pravin B Shelar wrote: > > Today packet mark action is broaken for Tunnel ports with > tunnel monitoring. “broaken”->”broken” Could you be more specific here. Setting packet mark

[ovs-dev] Fwd: [PATCH] datapath: internal-dev: Disable rtnl_link_ops register under linux < 3.17

Thomas & Pravin, Apparently the commit 5282e284ac57 (“datapath: introduce rtnl ops stub”) applied to OVS two years ago is not compatible with Linux 3.16 or earlier, as the corresponding upstream change was only applied in Linux 3.17. For Linux 3.16 and earlier, in your opinion, is the right

Re: [ovs-dev] [PATCH v2 1/2] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

> On Jan 22, 2017, at 5:50 AM, Jan Scheurich wrote: > > How does the dpif-netdev CLONE action introduced here relate to the similar > action already introduced in the context of the OpenFLow CLONE action (see > for example >

Re: [ovs-dev] [PATCH] faq: Document OVS packet buffering.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2017, at 2:43 PM, Ben Pfaff <b...@ovn.org> wrote: > > We get questions about this sometimes. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > Documentation/faq/design.rst | 32 ++

Re: [ovs-dev] [PATCH 1/3] lib: Add nl_msg_end_non_empty_nested()

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 13, 2017, at 4:13 PM, Andy Zhou <az...@ovn.org> wrote: > > Later patch will make use of this function. IMO it would be good for the commit message to also include the name of the function without referencing the ti

Re: [ovs-dev] [PATCH] ofproto-dpif: Use acquire/release barriers with 'tables_version'.

> On Jan 13, 2017, at 12:23 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Jan 12, 2017 at 10:17:32AM -0800, Jarno Rajahalme wrote: >> Use memory_order_release when updating the tables version number to >> make sure no memory accesses before the atomic_store (possibl

Re: [ovs-dev] [PATCH] ofproto-dpif: Use acquire/release barriers with 'tables_version'.

> On Jan 19, 2017, at 4:49 PM, Jarno Rajahalme <ja...@ovn.org> wrote: > > >> On Jan 13, 2017, at 12:23 PM, Ben Pfaff <b...@ovn.org> wrote: >> >> On Thu, Jan 12, 2017 at 10:17:32AM -0800, Jarno Rajahalme wrote: >>> Use memory_order_release whe

Re: [ovs-dev] [PATCH 2/3] dpif-netdev: Add clone action

> On Jan 13, 2017, at 4:13 PM, Andy Zhou wrote: > > Add support for userspace datapath clone action. The clone action > provides an action envelope to enclose an action list. > For example, with action A, B, C and D, and an action list: “with action”->”with actions” > A,

Re: [ovs-dev] [PATCH 3/3] xlate: Generate of datapath clone action when supported

Needs rebasing if you address my comments to the previous patch. Jarno > On Jan 13, 2017, at 4:13 PM, Andy Zhou wrote: > > Add logic to detect whether datapath support clone. > Enhance the xlate logic to make use of it. > Added logic to turn on/off clone support for testing. >

Re: [ovs-dev] [userspace clone v2 1/4] dpif-netdev: Avoid sending probe packets

> On Jan 19, 2017, at 11:07 PM, Andy Zhou wrote: > > When ofproto probe for datapath features, no packets should actually > be sent to the network. This pactch fixes the userspace by dropping > probe packets before action execution. > > Signed-off-by: Andy Zhou >

Re: [ovs-dev] [userspace clone v2 3/4] dpif-netdev: Add clone action

> On Jan 19, 2017, at 11:07 PM, Andy Zhou wrote: > > Add support for userspace datapath clone action. The clone action > provides an action envelope to enclose an action list. > For example, with actions A, B, C and D, and an action list: > A, clone(B, C), D > > The clone

Re: [ovs-dev] [userspace clone v2 4/4] xlate: Generate of datapath clone action when supported

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 19, 2017, at 11:07 PM, Andy Zhou <az...@ovn.org> wrote: > > Add logic to detect whether datapath support clone. > Enhance the xlate logic to make use of it. > Added logic to turn on/off clone support for testing. &g

Re: [ovs-dev] [PATCH] FAQ: Update kernel support info.

Forgot to add your ack to commit, sorry! Jarno > On Feb 27, 2017, at 5:49 PM, Justin Pettit <jpet...@ovn.org> wrote: > > >> On Feb 27, 2017, at 5:45 PM, Jarno Rajahalme <ja...@ovn.org> wrote: >> >> OVS 2.7 works with Linux kernels 3.10-4.9. &g

Re: [ovs-dev] [PATCH] FAQ: Update kernel support info.

Thanks, Pushed to master and cherry-picked to branch-2.7. Jarno > On Feb 27, 2017, at 5:49 PM, Justin Pettit <jpet...@ovn.org> wrote: > > >> On Feb 27, 2017, at 5:45 PM, Jarno Rajahalme <ja...@ovn.org> wrote: >> >> OVS 2.7 works with Linux kernel

[ovs-dev] [PATCH] FAQ: Update kernel support info.

OVS 2.7 works with Linux kernels 3.10-4.9. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- Documentation/faq/releases.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 319c2d7..118c88d 100644 --- a/Documentati

[ovs-dev] [PATCH v2 04/22] datapath: Fix comments for skb->_nfct

Upstream commit: commit 5e17da634a21b1200853fe82ba67d6571f2beabe Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:52 2017 -0800 openvswitch: Fix comments for skb->_nfct Fix comments referring to skb 'nfct' and 'nfctinfo' fields now that they are

[ovs-dev] [PATCH v2 10/22] datapath: Inherit master's labels.

Upstream commit: commit 09aa98ad496d6b11a698b258bc64d7f64c55d682 Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:58 2017 -0800 openvswitch: Inherit master's labels. We avoid calling into nf_conntrack_in() for expected connections, as that would

[ovs-dev] [PATCH v2 11/22] netlink: Simplify nl_msg_start_nested().

Since there is no data to copy nl_msg_put_unspec_uninit() may be used directly, rather than via nl_msg_put_unspec(). Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netlink.c b/lib/netlink.c index a

[ovs-dev] [PATCH v2 15/22] odp: Support conntrack orig tuple key.

Userspace support for datapath original direction conntrack tuple. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- build-aux/extract-ofp-fields| 3 + include/openvswitch/flow.h | 15 ++- include/openvswitch/match.h | 16 +++ include/openvswitch/meta-flow.h

[ovs-dev] [PATCH v2 22/22] datapath: Allow compiling against Linux 4.10

OVS in-tree datapath compiles against Linux 4.10 kernel, so allow it. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- acinclude.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index f4cbabd..3de635f 100644 --- a/acinclude.m4

[ovs-dev] [PATCH v2 00/22] Conntrack enhancements.

with this series. v2: - Fix compilation on Linux 3.10 and 3.11 - Fix 32-bit compiles. Florian Westphal (2): datapath: add and use skb_nfct helper datapath: add and use nf_ct_set helper Jarno Rajahalme (19): datapath: Fix comments for skb->_nfct datapath: Use inverted tu

[ovs-dev] [PATCH v2 16/22] actions: Add resubmit with conntrack tuple.

-by: Jarno Rajahalme <ja...@ovn.org> --- include/openvswitch/ofp-actions.h | 4 +- lib/ofp-actions.c | 82 +++-- ofproto/ofproto-dpif-xlate.c | 68 ++--- tests/ofp-actions.at | 6 ++ tests/ofproto-dpif.at

[ovs-dev] [PATCH v2 03/22] datapath: add and use nf_ct_set helper

f_conn entry and the ctinfo bits to an sk_buff. This avoids changing code in followup patch that merges skb->nfct and skb->nfctinfo into skb->_nfct. Signed-off-by: Florian Westphal <f...@strlen.de> Signed-off-by: Pablo Neira Ayuso <pa...@netfilter.org> Signed-off-b

[ovs-dev] [PATCH v2 01/22] datapath: make ndo_get_stats64 a void function

ts64 to have a void function. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> Signed-off-by: David S. Miller <da...@davemloft.net> This seems to be fine for all prior Linux versions as well. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/vport-int

[ovs-dev] [PATCH v2 02/22] datapath: add and use skb_nfct helper

and changes its type so add a helper to avoid intrusive rename change later. Signed-off-by: Florian Westphal <f...@strlen.de> Signed-off-by: Pablo Neira Ayuso <pa...@netfilter.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- acinclude.m4

[ovs-dev] [PATCH v2 14/22] flow: Make room after ct_state.

'ct_state' currently only needs 8 bits, so we can make room for a new CT field introduced in the next patch. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- include/openvswitch/flow.h | 3 ++- lib/flow.c | 3 ++- lib/match.c| 8 lib/pac

[ovs-dev] [PATCH v2 13/22] datapath: Add original direction conntrack tuple to sw_flow_key.

Upstream commit: commit 9dd7f8907c3705dc7a7a375d1c6e30b06e6daffc Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:59 2017 -0800 openvswitch: Add original direction conntrack tuple to sw_flow_key. Add the fields of the conntrack original direction 5

[ovs-dev] [PATCH v2 12/22] lib: Check match and action prerequisities with 'match'.

validity checking due to the conntrack state having and 'invalid' bit, but not 'valid' bit. One way to match an valid conntrack state is to match on the 'tracked' bit being one and 'invalid' bit being zero. The latter requires the corresponding mask bit be verified. Signed-off-by: Jarno Rajahalme <

[ovs-dev] [PATCH v2 09/22] datapath: Refactor labels initialization.

Upstream commit: Refactoring conntrack labels initialization makes changes in later patches easier to review. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Acked-by: Pravin B Shelar <pshe...@ovn.org> Acked-by: Joe Stringer <j...@ovn.org> Signed-off-b

[ovs-dev] [PATCH v2 07/22] datapath: Unionize ovs_key_ct_label with a u32 array.

Upstream commit: commit cb80d58fae76d8ea93555149b2b16e19b89a1f4f Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:55 2017 -0800 openvswitch: Unionize ovs_key_ct_label with a u32 array. Make the array of labels in struct ovs_key_ct_label an union,

[ovs-dev] [PATCH v2 06/22] datapath: Do not trigger events for unconfirmed connections.

Upstream commit: commit 193e30967897f3a8b6f9f137ac30571d832c2c5c Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:54 2017 -0800 openvswitch: Do not trigger events for unconfirmed connections. Receiving change events before the 'new' event for the connecti

[ovs-dev] [PATCH v2 08/22] datapath: Simplify labels length logic.

Upstream commit: commit b87cec3814ccc7f6afb0a1378ee7e5110d07cdd3 Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:56 2017 -0800 openvswitch: Simplify labels length logic. Since 23014011ba42 ("netfilter: conntrack: support a fixed size of 128

[ovs-dev] [PATCH v2 05/22] datapath: Use inverted tuple in ovs_ct_find_existing() if NATted.

Upstream commit: commit 9ff464db50e437eef131f719cc2e9902eea9c607 Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:53 2017 -0800 openvswitch: Use inverted tuple in ovs_ct_find_existing() if NATted. The conntrack lookup for existing connections fails to

[ovs-dev] [PATCH v2 18/22] datapath: Add force commit.

Upstream patch: commit dd41d33f0b033885211a5d6f3ee19e73238aa9ee Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:22:00 2017 -0800 openvswitch: Add force commit. Stateful network admission policy may allow connections to one direction and reject conne

[ovs-dev] [PATCH v2 17/22] compat: nf_ct_delete compat.

which in later versions simply calls nf_ct_delete(). Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- acinclude.m4 | 6 .../include/net/netfilter/nf_conntrack_core.h | 37 ++ 2 files changed, 43 insertions(+) diff --git a/a

[ovs-dev] [PATCH v2 20/22] datapath: Add a missing comment.

Make openvswitch.h better match upstream by adding a missing comment. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/linux/compat/include/linux/openvswitch.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/datapath/linux/compat/include/linux/openvswitch.h b/datapath

Re: [ovs-dev] Can we use ovs to implement load balancer by openflow?

> On Feb 27, 2017, at 10:42 PM, Han Zhou wrote: > > On Mon, Feb 27, 2017 at 7:42 PM, Yang, Yi Y wrote: >> >> Hi, all >> >> Can we use ovs to implement load balancer? Our target is to let ovs > distribute the traffic to different service VMs based on 5

Re: [ovs-dev] relationship between dpcls_rule and dp_netdev_flow

> On Nov 15, 2016, at 3:35 PM, Joo Kim wrote: > > Hello, > > In this OVS (2.6) code below, > It seems that a dp_netdev_flow obj contains a dpcls_rule struct, and given > a dpcls_rule, it gets the corresponding dp_netdev_flow via > dp_netdev_flow_cast(). > Does it mean

Re: [ovs-dev] [PATCH] datapath: Linux 4.9 compat.

Thanks for the reviews! Pushed to master with a better title and a compiletime_assert() for GENL_ID_GENERATE, if it is defined. Jarno > On Dec 9, 2016, at 2:36 PM, Pravin Shelar <pshe...@ovn.org> wrote: > > On Wed, Dec 7, 2016 at 4:31 PM, Jarno Rajahalme <ja...@ovn

Re: [ovs-dev] [PATCH] datapath: Fix compile time assertion.

> On Dec 9, 2016, at 17:57, Joe Stringer <j...@ovn.org> wrote: > >> On 9 December 2016 at 17:53, Jarno Rajahalme <ja...@ovn.org> wrote: >> compiletime_assert() cannot be used in file scope, so use preprocessor >> directives instead. >> >> Report

  1   2   3   4   >