Re: [ovs-dev] [PATCH ovn v3] ovn-controller: Fix some issues with CT zone assignment.

2022-11-01 Thread Numan Siddique
t; +ovn-nbctl --wait=hv sync > + > +ct_zones=$(ovn-appctl -t ovn-controller ct-zone-list) > +echo "$ct_zones" > + > +port1_zone=$(get_zone_num "$ct_zones" ls0-hv1) > +port2_zone=$(get_zone_num "$ct_zones" ls0-hv2) > +snat_zone=$(get_zone_num "$

Re: [ovs-dev] [PATCH ovn 0/4] Send Rarps for ipv6 router lsp

2022-11-01 Thread Numan Siddique
On Mon, Oct 24, 2022 at 6:47 AM Felix Hüttner via dev wrote: > > previously garps/rarps where only sent for "external" lsp's if these > had an ipv4 address attached. For lsp's on gateway routers that do > not have an ipv4 address assigned (e.g. if they are ipv6 only) no > rarps were send out. > >

Re: [ovs-dev] [PATCH ovn 4/4] pinctrl: Send RARPs for external ipv6 interfaces

2022-11-01 Thread Numan Siddique
gt; > This change has been tested in an environment with 600 logical routers > on a single ipv6 external network. > > Signed-off-by: Felix Huettner Acked-by: Numan Siddique Numan > --- > controller/pinctrl.c | 23 + > tests/ovn.at | 80 ++

Re: [ovs-dev] [PATCH ovn 3/4] ovn-macros: support ipv6 in ovn_attach

2022-11-01 Thread Numan Siddique
On Mon, Oct 24, 2022 at 6:48 AM Felix Hüttner via dev wrote: > > in order to easily add future ipv6 test cases the common `ovn_attach` > function should also support ipv6 addresses. > > Signed-off-by: Felix Huettner Acked-by: Numan Siddique Numan > --- > tes

Re: [ovs-dev] [PATCH ovn 2/4] northd: handle own rarps like garps

2022-11-01 Thread Numan Siddique
2 changes done, you can add my Acked-by tag in the next version Acked-by: Numan Siddique Numan > --- > northd/northd.c | 9 + > northd/ovn_northd.dl | 2 +- > tests/ovn-northd.at | 18 +- > tests/ovn.at | 8 +++- > 4 files changed, 22

Re: [ovs-dev] [PATCH ovn 1/4] logical-fields: add rarp fields

2022-11-01 Thread Numan Siddique
On Mon, Oct 24, 2022 at 6:47 AM Felix Hüttner via dev wrote: > > We need to be able to handle rarp fields in order to ensure we can > handle rarp messages we send ourselves. > This will be used by the next patch in the series. > > Signed-off-by: Felix Huettner Acked-by: Numa

Re: [ovs-dev] [PATCH ovn v4] ovn-controller: Fixed missing flows after interface deletion

2022-11-01 Thread Numan Siddique
On Fri, Oct 28, 2022 at 11:36 AM Dumitru Ceara wrote: > > Hi Xavier, > > On 10/24/22 17:21, Xavier Simonart wrote: > > In the following scenario: > > - interface "old" is created and external_ids:iface-id is set (to lp) > > - interface "new" is created and external_ids:iface-id is set (to same

Re: [ovs-dev] [PATCH ovn v4 2/3] northd: make default drops explicit

2022-11-01 Thread Numan Siddique
On Mon, Oct 17, 2022 at 9:15 AM Adrian Moreno wrote: > > By default, traffic that doesn't match any configured flow will be dropped. > But having that behavior implicit makes those drops more difficult to > visualize. > > Make default drops explicit both as default logical flows and as default >

Re: [ovs-dev] [PATCH ovn v4 1/3] actions: add sample action

2022-11-01 Thread Numan Siddique
On Mon, Oct 17, 2022 at 9:14 AM Adrian Moreno wrote: > > sample ovn action encodes into the OFPACT_SAMPLE ovs action. > > OVN action allows the following parameters: > > - obs_domain_id: 8-bit integer that identifies the sampling application. > This value will be combined with the datapath's

Re: [ovs-dev] [PATCH ovn] util: Avoid double parsing of LB vip and backend ip

2022-10-18 Thread Numan Siddique
rectly from "sockaddr_storage". > > Signed-off-by: Ales Musil Thanks for the patch. LGTM. Can you please also update the function comments in lib/ovn-util.c now that the function also sets 'struct in6_addr *ip'. Acked-by: Numan Siddique Numan > --- > lib/lb.c

Re: [ovs-dev] [PATCH ovn] controller: Remove unused shash from update_ct_zone

2022-10-18 Thread Numan Siddique
On Wed, Oct 12, 2022 at 3:32 PM Mark Michelson wrote: > > Wow, this shash has been unused since branch-21.06 . Good find! > > Acked-by: Mark Michelson Thanks. Applied to the main branch. Numan > > On 10/12/22 04:07, Ales Musil wrote: > > Signed-off-by: Ales Musil > > --- > >

Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-10-10 Thread Numan Siddique
rc=fa:16:3e:4c:e6:1f,dst=fa:16:3e:c9:a7:6b),eth_type(0x0800),ipv4(src=192.168.210.103,dst=1.1.1.254,proto=6,tos=0/0,ttl=64,frag=no),tcp(src=0/0,dst=0/0), > packets:2, bytes:148, used:3.230s, offloaded:yes, dp:tc, > actions:set(eth(src=fa:16:3e:ae:b5:e5,dst=8c:1f:64:30:61:43)),set(ipv4(t

Re: [ovs-dev] [PATCH ovn] spec: require python3-openvswitch for ovn-detrace

2022-10-05 Thread Numan Siddique
On Tue, Oct 4, 2022 at 5:41 AM Dumitru Ceara wrote: > > On 9/21/22 15:36, Vladislav Odintsov wrote: > > Signed-off-by: Vladislav Odintsov > > --- > > Hi Vladislav, > > > rhel/ovn-fedora.spec.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/rhel/ovn-fedora.spec.in

Re: [ovs-dev] [PATCH ovn v3] northd: Use separate SNAT for already-DNATted traffic.

2022-09-28 Thread Numan Siddique
tage is reached, a > separate CT zone is used for SNAT. > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > v2 -> v3: > * Rebased on top of current main branch > * Fixed checkpatch issues from v2. > * Accounted for the ct_label -> ct_ma

Re: [ovs-dev] [OVN v6] OVN - Add Support for Remote Port Mirroring

2022-09-27 Thread Numan Siddique
On Sun, Sep 11, 2022 at 10:26 AM Abhiram R N wrote: > > Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller. > While Mirror creation just creates the mirror, the lsp-attach-mirror > triggers the sequence to create Mirror in OVS DB on compute node. > OVS already supports Port

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Add Dumitru Ceara.

2022-09-21 Thread Numan Siddique
On Wed, Sep 21, 2022 at 11:33 AM Dumitru Ceara wrote: > > On 9/21/22 16:03, Mark Michelson wrote: > > Acked-by: Mark Michelson > > > > Congrats, Dumitru! Thanks. Applied to main. Congrats, Dumitru ! Numan > > > > On 9/21/22 07:20, num...@ovn.

Re: [ovs-dev] [PATCH ovn] lb: Remove unused ovn_northd_lb_vip vip_port_str member.

2022-09-20 Thread Numan Siddique
On Mon, Sep 19, 2022 at 2:06 AM Ales Musil wrote: > > On Fri, Aug 26, 2022 at 2:35 PM Dumitru Ceara wrote: > > > Signed-off-by: Dumitru Ceara > > --- > > lib/lb.c | 5 + > > lib/lb.h | 1 - > > 2 files changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/lib/lb.c b/lib/lb.c > >

Re: [ovs-dev] [PATCH ovn] northd: Use bitmaps instead of exclusive hash map for datapath groups.

2022-09-16 Thread Numan Siddique
On Fri, Sep 16, 2022 at 11:59 AM Numan Siddique wrote: > > On Tue, Sep 13, 2022 at 7:34 AM Ilya Maximets wrote: > > > > Every time a new logical flow is created, ovn-northd creates an > > exclusive hash map to collect all the datapaths this logical flow is > > appl

Re: [ovs-dev] [PATCH ovn branch-22.09 2/2] Prepare for 22.09.1.

2022-09-16 Thread Numan Siddique
On Fri, Sep 16, 2022 at 11:38 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > &g

Re: [ovs-dev] [PATCH ovn branch-22.09 1/2] Set release date for 22.09.0.

2022-09-16 Thread Numan Siddique
On Fri, Sep 16, 2022 at 11:38 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique I'm sure you're already aware of it (but just as a reminder) that this patch should also be merged to the main branch. Thanks Numan > --- > NEWS | 2

Re: [ovs-dev] [PATCH ovn branch-22.03] Allow for setting the Next server IP in the DHCP header

2022-09-16 Thread Numan Siddique
l DHCP option but a > special use case in OVN. > > [0] > https://github.com/openvswitch/ovs/blob/9dd3031d2e0e9597449e95428320ccaaff7d8b3d/lib/dhcp.h#L42 > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2083629 > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/

Re: [ovs-dev] [PATCH ovn] northd: Use bitmaps instead of exclusive hash map for datapath groups.

2022-09-16 Thread Numan Siddique
gt; everywhere, including ovn_lflow_add(), so we'll have to pass it around > in most of the functions in northd as an argument. Taking that into > account, I decided to make them both global to avoid touching half of > the northd code. > We also have a couple of other global variabl

Re: [ovs-dev] [PATCH ovn] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-15 Thread Numan Siddique
h/20220908140644.2647859-1-odiv...@gmail.com/ > > Regards, > Vladislav Odintsov > > > On 16 Sep 2022, at 02:25, Vladislav Odintsov wrote: > > > > Ok, > > I’ll correct patch and resend v2. > > > > Regards, > > Vladislav Odintsov > &

Re: [ovs-dev] [PATCH ovn v3 0/4] northd: Optimize preparation of load balancers.

2022-09-15 Thread Numan Siddique
On Tue, Sep 13, 2022 at 1:19 PM Han Zhou wrote: > > On Mon, Sep 12, 2022 at 3:25 AM Dumitru Ceara wrote: > > > > On 9/9/22 23:32, Ilya Maximets wrote: > > > Re-compute of 'northd' node in ovn-northd may take almost half of the > > > total processing time in case there is a big number of load

Re: [ovs-dev] [PATCH ovn] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-15 Thread Numan Siddique
> [root@dev1 ~]# ovn-nbctl show public > switch 633ad6c1-f3e5-4f31-b2fe-215203cf5272 (public) > port p-port1 > addresses: ["50:54:00:00:00:03 172.16.0.100"] > port ln-public > type: localnet > addresses: ["unknown"] > [roo

Re: [ovs-dev] stateless acl on ovn-k8s interface

2022-09-15 Thread Numan Siddique
On Tue, Sep 13, 2022 at 6:41 PM venugopal iyer via dev wrote: > > Hi, Han, Numan: > While testing a use case in our ovn-k8s cluster we ran into an issue where > wecouldn't effectively use stateless ACL on the OVN interface. Turns out we > will track > all the packets here, since there will be

Re: [ovs-dev] [PATCH ovn] northd: don't include disabled LSP's IP to Load Balancing

2022-09-15 Thread Numan Siddique
On Mon, Sep 12, 2022 at 6:11 PM Vladislav Odintsov wrote: > > If one has a UDP load balancer with backend IP which is located under > disabled LSP, such backend would be threated as alive and marked as > 'online' on Service_Monitor table and added to load balancing as well. > Though such LSP

Re: [ovs-dev] [PATCH ovn] northd: Don't get stuck in the STATE_INIT_HASH_SIZES state.

2022-09-15 Thread Numan Siddique
On Fri, Sep 9, 2022 at 4:00 AM Ilya Maximets wrote: > > On 8/25/22 11:03, Dumitru Ceara wrote: > > On 8/24/22 18:32, Ilya Maximets wrote: > >> On 8/24/22 17:57, Dumitru Ceara wrote: > >>> On 8/24/22 17:49, Ilya Maximets wrote: > On 8/24/22 17:43, Ilya Maximets wrote: > > On 8/23/22

Re: [ovs-dev] [PATCH ovn] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-15 Thread Numan Siddique
livered to p-public. Thanks Numan > > Regards, > Vladislav Odintsov > > > On 15 Sep 2022, at 15:42, Numan Siddique wrote: > > > > On Thu, Sep 8, 2022 at 7:41 AM Vladislav Odintsov > <mailto:odiv...@gmail.com>> wrote: > >> > >> Prior

Re: [ovs-dev] [PATCH ovn] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-15 Thread Numan Siddique
On Thu, Sep 8, 2022 at 7:41 AM Vladislav Odintsov wrote: > > Prior to this patch traffic to LSPs, which are disabled with > `ovn-nbctl lsp-set-enabled disabled` was dropped in the end of > lswitch egress pipeline. This means that traffic is processed in vain: > - traffic, which should be

Re: [ovs-dev] [PATCH ovn] northd: Accumulate more database updates before processing.

2022-09-12 Thread Numan Siddique
= new_ovnnb_cond_seqno; > > } > > > > - struct ovsdb_idl_txn *ovnsb_txn = > > -ovsdb_idl_loop_run(_idl_loop); > > +struct ovsdb_idl_txn *ovnsb_txn = > run_idl_loop(_idl_loop, > > + > "O

Re: [ovs-dev] [PATCH ovn] northd: Always propagate LB proto to lflows

2022-09-09 Thread Numan Siddique
On Fri, Sep 9, 2022 at 2:11 AM Ales Musil wrote: > > On Fri, Sep 9, 2022 at 7:43 AM Han Zhou wrote: > > > > > > > On Tue, Sep 6, 2022 at 6:02 AM Ales Musil wrote: > > > > > > The current behavior is that load balancers > > > default to tcp protocol if it is not specified. > > > However, this is

Re: [ovs-dev] [PATCH ovn] northd: don't add drop lflow if LB VIP matches LRP IP

2022-09-06 Thread Numan Siddique
On Wed, Aug 31, 2022 at 9:17 AM Vladislav Odintsov wrote: > > Please, add this tag before applying the patch: > > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2022-August/052021.html I'm sorry. I missed adding this tag before applying the patch. I also backported to

Re: [ovs-dev] [ovn] Conntrack zone is not flushed on PB release

2022-09-06 Thread Numan Siddique
On Tue, Sep 6, 2022 at 2:40 PM Vladislav Odintsov wrote: > > Hi, > > we’ve noticed that after port binding is released, the conntrack entries in > the associated to deleted port-binding zone are left in conntrack. > I’ve ran through the code, it seems that conntrack zone flushing after port >

Re: [ovs-dev] [PATCH ovn v2 2/2] Prepare for post-22.09.0

2022-08-31 Thread Numan Siddique
, 10 insertions(+), 1 deletion(-) > > LGTM, > Acked-by: Ilya Maximets Looks like the branch-22.09 is not yet created. For the entire series : Acked-by: Numan Siddique Numan > ___ > dev mailing list > d...@openvswitch

Re: [ovs-dev] [PATCH ovn v3 2/5] binding.c: Missing local_datapath update in runtime_data port_binding handler.

2022-08-19 Thread Numan Siddique
On Fri, Aug 19, 2022 at 10:42 AM Han Zhou wrote: > > On Thu, Aug 18, 2022 at 5:21 PM Han Zhou wrote: > > > > When handling port_binding changes, it is possible that new > > local_datapaths are added, and the fields of the local_datapath, such as > > localnet_port, external_ports, etc. need to be

Re: [ovs-dev] [PATCH ovn v3 1/5] binding.c: Avoid checking OVSDB tracking status in handle_updated_port.

2022-08-19 Thread Numan Siddique
but it is risky if the OVSDB IDL implementation changes. > > Fixes: 3103487e087b ("Split out code to handle port binding db updates") > Signed-off-by: Han Zhou Acked-by: Numan Siddique Numan > --- > controller/binding.c | 10 +- > 1 file changed, 5 insertions(+),

Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-08-17 Thread Numan Siddique
nsiddique/ovn/runs/7891302586?check_suite_focus=true Please also add documentation in ovn-northd.8.xml about the new logical flows you'd be adding, fix any existing test case failures and also add a system test if possible. Thanks Numan > Wentao Jia > > -Original Message- &g

Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-08-17 Thread Numan Siddique
0.102" > type: "dnat_and_snat" > nat 88b9371b-a058-46b5-91f9-6741edf3391a > external ip: "1.1.1.124" > logical ip: "192.168.210.0/24" > type: "snat" > nat f9843d73-341a-4557-b996-ced76b4fa

Re: [ovs-dev] [PATCH ovn] system-ovn.at: add connectivity test between container port and parent one

2022-08-17 Thread Numan Siddique
On Thu, Aug 18, 2022 at 3:47 AM Lorenzo Bianconi wrote: > > Introduce system test for the following fix: > 'd9f69b2d7 ("controller: physical: fix regression for container ports")' Thanks for the follow up patch to add the test case. I applied this to the main branch. Numan > > Signed-off-by:

Re: [ovs-dev] [PATCH ovn] controller: Fix UB due to passing NULL to memcpy.

2022-08-17 Thread Numan Siddique
On Wed, Aug 17, 2022 at 6:01 PM Ales Musil wrote: > > On Tue, Aug 16, 2022 at 4:47 PM Dumitru Ceara wrote: > > > Reported by UndefinedBehaviorSanitizer when running in a sandbox: > > controller/ovn-controller.c:374:21: runtime error: null pointer passed > > as argument 2, which is declared to

Re: [ovs-dev] [Patch ovn] physical.c: Fix bug of wrong use in vm migration

2022-08-17 Thread Numan Siddique
On Thu, Aug 18, 2022 at 5:55 AM Mark Michelson wrote: > > Thanks for finding and fixing this! > > Acked-by: Mark Michelson Thanks. I applied this patch to the main branch, Numan > > On 8/15/22 03:16, wangchuanlei wrote: > > In master branch, pointer ofpacts_p is modified or > > cleared in

Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-08-17 Thread Numan Siddique
4 && outport == "lrp-0e701852-85a0-4c57-8014-77a8607a9406" && > is_chassis_resident("cr-lrp-0e701852-85a0-4c57-8014-77a8607a9406")), > action=(ct_dnat_in_czone;) > table=1 (lr_out_undnat ), priority=100 , match=(ip && ip4.s

Re: [ovs-dev] [ovn] Memory leak in ovn-northd: which fix is preferred?

2022-08-16 Thread Numan Siddique
On Wed, Aug 17, 2022 at 12:58 AM Ales Musil wrote: > > On Tue, Aug 16, 2022 at 1:50 PM Olaf Seibert via dev < > ovs-dev@openvswitch.org> wrote: > > > Hi! We discovered a memory leak in ovn-northd, which grows quickly, caused > > by > > commit 7b56f69580e1f390d9c6753a2cb8f0dbfbb4c467 (dated Wed

Re: [ovs-dev] [PATCH ovn v4 4/6] northd: Add MAC binding aging mechanism

2022-08-15 Thread Numan Siddique
On Tue, Aug 16, 2022 at 3:07 AM Han Zhou wrote: > > On Mon, Aug 15, 2022 at 1:23 AM Dumitru Ceara wrote: > > > > On 8/15/22 08:46, Numan Siddique wrote: > > > " > > > > > > On Mon, Aug 15, 2022 at 3:34 PM Han Zhou wrote: > > >>

Re: [ovs-dev] [PATCH ovn v2] treewide: Disable storing of other_config in external_ids

2022-08-15 Thread Numan Siddique
On Mon, Aug 15, 2022 at 6:18 PM Dumitru Ceara wrote: > > On 8/15/22 07:16, Ales Musil wrote: > > The update of having other_config instead of external_ids > > for configuration has been in place for some time. > > Version that released with this change was 20.06, that > > is plenty of time so we

Re: [ovs-dev] [PATCH ovn] northd: support vtep LSP-attached LS to use L3 services

2022-08-15 Thread Numan Siddique
On Tue, Aug 16, 2022 at 12:19 AM Vladislav Odintsov wrote: > > If LRP's logical switch has attached LSP of vtep type, the > is_chassis_resident() part is not added to lflow to allow traffic > originated from logical switch to reach LR services (LBs, NAT). > > Signed-off-by: Vladislav Odintsov

Re: [ovs-dev] [PATCH ovn v4 4/6] northd: Add MAC binding aging mechanism

2022-08-15 Thread Numan Siddique
" On Mon, Aug 15, 2022 at 3:34 PM Han Zhou wrote: > > On Sun, Aug 14, 2022 at 8:30 PM Numan Siddique wrote: > > > > On Fri, Aug 12, 2022 at 12:21 AM Ales Musil wrote: > > > > > > On Thu, Aug 11, 2022 at 2:45 PM Dumitru Ceara wrote: >

Re: [ovs-dev] [PATCH ovn] controller: Fix assigment typo

2022-08-14 Thread Numan Siddique
On Wed, Aug 10, 2022 at 6:10 PM Dumitru Ceara wrote: > > On 8/10/22 09:32, Ales Musil wrote: > > Signed-off-by: Ales Musil > > --- > > controller/chassis.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/controller/chassis.c b/controller/chassis.c > > index

Re: [ovs-dev] [PATCH ovn] treewide: Disable storing of other_config in external_ids

2022-08-14 Thread Numan Siddique
On Wed, Aug 10, 2022 at 6:15 PM Dumitru Ceara wrote: > > On 8/10/22 09:21, Ales Musil wrote: > > The update of having other_config instead of external_ids > > for configuration has been in place for some time. > > Version that released with this change was 20.06, that > > is plenty of time so we

Re: [ovs-dev] [PATCH ovn] github: ovn-kubernetes: Update go, kube and libovsdb versions.

2022-08-14 Thread Numan Siddique
On Thu, Aug 11, 2022 at 11:27 PM Dumitru Ceara wrote: > > With this they'll match the current upstream ovn-kubernetes code. > > Signed-off-by: Dumitru Ceara Thanks. Applied to main. Do we need to backport this too ? Numan > --- > .ci/ovn-kubernetes/Dockerfile| 2 +- >

Re: [ovs-dev] [PATCH ovn] system-ovn: Fix the "Load balancer for container ports" test.

2022-08-14 Thread Numan Siddique
On Wed, Aug 10, 2022 at 8:17 PM Ales Musil wrote: > > On Wed, Aug 10, 2022 at 10:04 AM Dumitru Ceara wrote: > > > It doesn't really need the load balancer applied on the logical router. > > As a matter of fact, load balancers are not supported on distributed > > routers without distributed

Re: [ovs-dev] [PATCH ovn v4 4/6] northd: Add MAC binding aging mechanism

2022-08-14 Thread Numan Siddique
On Fri, Aug 12, 2022 at 12:21 AM Ales Musil wrote: > > On Thu, Aug 11, 2022 at 2:45 PM Dumitru Ceara wrote: > > > On 8/10/22 18:37, Han Zhou wrote: > > > On Tue, Aug 9, 2022 at 11:22 PM Ales Musil wrote: > > >> > > >> > > >> > > >> On Wed, Aug 10, 2022 at 8:04 AM Han Zhou wrote: > > >> > > >>

Re: [ovs-dev] [PATCH v6 ovn 2/2] controller: throttle port claim attempts

2022-08-14 Thread Numan Siddique
? Thanks Numan > > Thanks again. > > Ihar > > On Tue, Aug 9, 2022 at 8:50 PM Numan Siddique wrote: > > > > On Wed, Aug 10, 2022 at 4:25 AM Ihar Hrachyshka wrote: > > > > > > When multiple chassis are fighting for the same port (requested-chas

Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-08-10 Thread Numan Siddique
On Tue, Aug 9, 2022 at 9:46 PM Ales Musil wrote: > > On Tue, Aug 2, 2022 at 9:05 PM Wentao Jia wrote: > > > snat/dnat rules of logical router, no logical flows for established > > connection, all natted packets deliver to kernel conntrack module by > > ct commit, this is low performance and

Re: [ovs-dev] [PATCH v5] ovsdb idl: Add the support to specify the uuid for row insert.

2022-08-10 Thread Numan Siddique
On Tue, Jul 19, 2022 at 3:39 AM wrote: > > From: Numan Siddique > > ovsdb-server allows the OVSDB clients to specify the uuid for > the row inserts [1]. The C IDL client library is missing this > feature. This patch adds this support. > > For each schema table, a n

Re: [ovs-dev] [PATCH ovn v4 4/6] northd: Add MAC binding aging mechanism

2022-08-09 Thread Numan Siddique
On Wed, Aug 10, 2022 at 3:22 PM Ales Musil wrote: > > On Wed, Aug 10, 2022 at 3:20 AM Numan Siddique wrote: > > > On Tue, Aug 9, 2022 at 9:06 PM Ales Musil wrote: > > > > > > Add MAC binding aging mechanism, that utilizes > > > the timestamp colum

Re: [ovs-dev] [PATCH ovn v4 4/6] northd: Add MAC binding aging mechanism

2022-08-09 Thread Numan Siddique
On Tue, Aug 9, 2022 at 9:06 PM Ales Musil wrote: > > Add MAC binding aging mechanism, that utilizes > the timestamp column of MAC_Binding table. > When the MAC binding exceeds the threshold it is > removed from SB DB, this is postponed only in case > we receive update ARP with update to MAC

Re: [ovs-dev] [PATCH ovn 4/5] debian: Update debian package source.

2022-08-09 Thread Numan Siddique
is credited below. > > > > Signed-off-by: James Page > > Co-Authored-by: James Page > > Signed-off-by: Christian Ehrhardt > > Co-Authored-by: Christian Ehrhardt > > Signed-off-by: Numan Siddique > > Co-Authored-by: Numan Siddique > > Signed-off-

Re: [ovs-dev] [PATCH v6 ovn 2/2] controller: throttle port claim attempts

2022-08-09 Thread Numan Siddique
On Wed, Aug 10, 2022 at 4:25 AM Ihar Hrachyshka wrote: > > When multiple chassis are fighting for the same port (requested-chassis > is not set, e.g. for gateway ports), they may produce an unreasonable > number of chassis field updates in a very short time frame (hundreds of > updates in several

Re: [ovs-dev] [PATCH ovn] northd: Do not relay local IP multicast (224.0.0.X).

2022-08-09 Thread Numan Siddique
On Tue, Aug 9, 2022 at 5:21 PM Ales Musil wrote: > > On Wed, Aug 3, 2022 at 1:21 PM Dumitru Ceara wrote: > > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2077306 > > Signed-off-by: Dumitru Ceara > > --- > > northd/northd.c | 2 +- > > northd/ovn-northd.8.xml | 4 ++-- >

Re: [ovs-dev] [PATCH ovn v2] controller: Fix misaligned access to ip6_hdr

2022-08-09 Thread Numan Siddique
On Tue, Aug 9, 2022 at 5:49 AM Mark Michelson wrote: > > Thanks for the clarification Ales. > > Acked-by: Mark Michelson Thanks. I applied this patch to the main branch. Numan > > On 7/26/22 01:23, Ales Musil wrote: > > I forgot to add the v2 comment, so for clarification just the commit

Re: [ovs-dev] [PATCH ovn] tests: Avoid matching on the OVS flow key contents.

2022-08-09 Thread Numan Siddique
On Tue, Aug 9, 2022 at 6:45 PM Ales Musil wrote: > > On Mon, Aug 8, 2022 at 5:30 PM Dumitru Ceara wrote: > > > These may change over time and, as a matter of fact, have recently changed > > in OVS master branch with commit fcdf8ae4a350 ("lib: Print nw_frag in flow > > key."). > > > > Instead,

Re: [ovs-dev] [PATCH ovn v3 6/6] northd: Limit bulk removal of MAC binding aging

2022-08-09 Thread Numan Siddique
On Wed, Jul 27, 2022 at 12:09 AM Ihar Hrachyshka wrote: > > Acked-By: Ihar Hrachyshka > > On Wed, Jul 20, 2022 at 4:56 AM Ales Musil wrote: > > > > Because the transaction is limited, in terms of how > > many operations it can do, we should not allow > > more than 15 MAC bindings to be removed

Re: [ovs-dev] [PATCH ovn branch-21.12 0/4] Avoid unnecessary deletion & recreation during restart.

2022-08-08 Thread Numan Siddique
On Tue, Aug 9, 2022 at 4:22 AM Mark Michelson wrote: > > On 8/4/22 15:55, Numan Siddique wrote: > > On Thu, Aug 4, 2022 at 10:12 AM Mark Michelson wrote: > >> > >> This is a backport of Han Zhou's patch series "Avoid unnecessary > >> deletion &

Re: [ovs-dev] [PATCH ovn branch-22.03 1/5] ofctrl: Wakeup when entering S_UPDATE_FLOWS.

2022-08-08 Thread Numan Siddique
On Tue, Aug 9, 2022 at 4:29 AM Mark Michelson wrote: > > From: Han Zhou > > In theory it is possible that ovn-controller tried to install flows by > calling ofctrl_put() while ofctrl is at a state other than > S_UPDATE_FLOWS thus not able to install. So, when entering S_UPDATE_FLOWS, > we should

Re: [ovs-dev] [PATCH ovn] northd: add support to make l3dgw ports fully distributed

2022-08-08 Thread Numan Siddique
On Mon, Aug 8, 2022 at 11:29 PM Vladislav Odintsov wrote: > > Hi Numan, > > thanks for the review. > My comments below. > > Regards, > Vladislav Odintsov > > > On 8 Aug 2022, at 03:24, Numan Siddique wrote: > > > > On Wed, Jul 20, 2022 at 12:15 AM Vl

Re: [ovs-dev] [PATCH ovn] controller: physical: fix regression for container ports

2022-08-07 Thread Numan Siddique
On Fri, Jul 29, 2022 at 12:04 AM Ihar Hrachyshka wrote: > > Oops, sorry about that. This should be backported to 22.06. > > Acked-By: Ihar Hrachyshka > On Thu, Jul 28, 2022 at 9:55 AM Lorenzo Bianconi > wrote: > > > > After commit 'd07e5f99d ("Introduce match_outport_dp_and_port_keys > > in

Re: [ovs-dev] [PATCH ovn]OVN-CI: ovn unit tests run in parallel jobs.

2022-08-07 Thread Numan Siddique
On Fri, Aug 5, 2022 at 9:18 PM Dumitru Ceara wrote: > > On 8/4/22 17:32, Mohammad Heib wrote: > > Ovn unit tests supported matrix size has been increased > > after adding support to monitor_all and northd_parallelization > > options recently, and that increased the execution time of the ovn-ci

Re: [ovs-dev] [PATCH ovn] pinctrl: fix bug of monitor status in health check

2022-08-07 Thread Numan Siddique
On Mon, Aug 1, 2022 at 11:06 PM wangchuanlei wrote: > > when vm of backend do not send reply packet, > monitor state should change from waiting to offline, > this patch is to fix it! > > Signed-off-by: wangchuanlei This patch breaks the service monitor functionality for UDP. For UDP protocol,

Re: [ovs-dev] [PATCH ovn] run CI for every commit when merging several commits, not for the latest.

2022-08-07 Thread Numan Siddique
On Fri, Aug 5, 2022 at 1:05 AM Igor Zhukov wrote: > > From: Igor Zhukov > > Docs: > https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value > > Test: https://github.com/fsb4000/ovn/actions and https://imgur.com/a/mUBQWSO > > Signed-off-by: Igor Zhukov

Re: [ovs-dev] [PATCH ovn] tests: enable and fix vif-provider test scenario

2022-08-07 Thread Numan Siddique
On Thu, Jul 28, 2022 at 4:44 PM Frode Nordahl wrote: > > Hello, Ihar, > > On Thu, Jul 28, 2022 at 1:28 AM Ihar Hrachyshka wrote: > > > > Signed-off-by: Ihar Hrachyshka > > --- > > controller/test-vif-plug.c | 2 +- > > tests/ovn-vif-plug.at | 2 +- > > tests/testsuite.at | 1 + > >

Re: [ovs-dev] [PATCH ovn] northd: add support to make l3dgw ports fully distributed

2022-08-07 Thread Numan Siddique
On Wed, Jul 20, 2022 at 12:15 AM Vladislav Odintsov wrote: > > This is used when traffic from HW VTEP goes to > routable networks and logical switch to which VTEP > logical port is attached also needs to support > distributed routing features such as NAT and others. > > Signed-off-by: Vladislav

Re: [ovs-dev] [PATCH ovn 2/2] release-process: Add 2023 calendar.

2022-08-07 Thread Numan Siddique
On Thu, Jul 28, 2022 at 12:28 AM Mark Michelson wrote: > > This also removes the 2021 calendar since that has come and gone. > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > Documentation/internals/release-process.rst | 20 ++-- >

Re: [ovs-dev] [PATCH ovn 1/2] release-process: Change master to main.

2022-08-07 Thread Numan Siddique
On Thu, Jul 28, 2022 at 12:28 AM Mark Michelson wrote: > > The document makes reference to the "master" branch throughout, but it > has been renamed "main" for some time now. > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > Do

Re: [ovs-dev] [PATCH ovn branch-21.12 0/4] Avoid unnecessary deletion & recreation during restart.

2022-08-04 Thread Numan Siddique
29a1f9857b55389f424c5d747406550cb7 to fix a regression caused by this patch series. With the commit db15cf29 also backported - For the entire series Acked-by: Numan Siddique Thanks Numan > > Han Zhou (4): > ofctrl: Wakeup when entering S_UPDATE_FLOWS. > ofctrl: Support ovn-ofctrl-wait-

Re: [ovs-dev] [PATCH ovn v3 4/6] northd: Add MAC binding aging mechanism

2022-08-04 Thread Numan Siddique
On Tue, Jul 26, 2022 at 10:13 AM Ihar Hrachyshka wrote: > > Acked-By: Ihar Hrachyshka > > On Wed, Jul 20, 2022 at 4:50 AM Ales Musil wrote: > > Hi Ales, I couldn't get a chance to thoroughly review the entire series, but overall it looks fine to me. I've a few comments in this patch. > >

Re: [ovs-dev] [PATCH ovn] CI-Actions: define matrix as a list

2022-08-03 Thread Numan Siddique
On Wed, Aug 3, 2022 at 9:55 AM Mohammad Heib wrote: > > Defining the matrix as a list will make it more readable > and easy to extend also users can exclude and add new cases > without using include, exclude just add a new combination > to the list. > > Signed-off-by: Mohammad Heib Thanks.

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Ensure that log/run directory have correct permission

2022-08-03 Thread Numan Siddique
On Tue, Aug 2, 2022 at 3:48 AM Ales Musil wrote: > > When someone creates or changes permission of the var/log > directory it stays that way. This can cause issues for logrotate > as it needs to have correct permission on directory. > > Attempt to fix the permission every time we run

Re: [ovs-dev] [PATCH ovn] system-tests: Make netcat calls more robust

2022-08-03 Thread Numan Siddique
On Wed, Jul 27, 2022 at 3:12 AM Ales Musil wrote: > > The netcat compilation options differ between > distributions, make the nc execution more > robust. Now it does not fail on success message > being printed to stderr. > > Signed-off-by: Ales Musil Thanks. Applied to the main branch. Numan

Re: [ovs-dev] [PATCH v5 ovn 2/2] controller: throttle port claim attempts

2022-08-03 Thread Numan Siddique
' On Tue, Jul 12, 2022 at 5:58 PM Ihar Hrachyshka wrote: > > When multiple chassis are fighting for the same port (requested-chassis > is not set, e.g. for gateway ports), they may produce an unreasonable > number of chassis field updates in a very short time frame (hundreds of > updates in

Re: [ovs-dev] [PATCH v5 ovn 1/2] Split out code to handle port binding db updates

2022-08-03 Thread Numan Siddique
On Mon, Jul 25, 2022 at 4:27 PM Mark Michelson wrote: > > Acked-by: Mark Michelson The patch looks good to me. But it needs a rebase. Numan > > On 7/12/22 17:57, Ihar Hrachyshka wrote: > > This function will later be used to handle port binding updates for > > postponed (throttled) bindings.

Re: [ovs-dev] [PATCH ovn v3] multicast: Properly flood IGMP queries and reports.

2022-08-02 Thread Numan Siddique
OD_L2 (only flood them in the L2 domain). > > Snooped reports are re-injected in the OVS pipeline with outport set to > MC_MROUTER_FLOOD (flood them to snooped mrouters and OVN mrouters). > > The same behavior applies to IPv6 too (MLD). > > [0] https://datatracker.ietf.org/doc/html/r

Re: [ovs-dev] [PATCH ovn v2] northd: handle virtual lport type update

2022-08-02 Thread Numan Siddique
On Tue, Aug 2, 2022 at 10:22 AM Mohammad Heib wrote: > > ovn-northd re-create sbrec row for lport of type > virtual when the type explicitly updated in NBDB. > > This approach was applied to handle container lport > type updates and avoid handling issues in the ovn-controller, > this patch

Re: [ovs-dev] [PATCH ovn v2 0/2] Fix IPv6 prefix delegation and the test flakiness

2022-08-02 Thread Numan Siddique
On Mon, Jul 25, 2022 at 6:50 AM Ales Musil wrote: > > > > Ales Musil (2): > system-tests: Reduce flakiness of IPv6 prefix delegation > controller: Fix IPv6 prefix delegation > Thanks. Applied both the patches to main and backported upto branch-22.03. Numan > controller/binding.c|

Re: [ovs-dev] [PATCH ovn] ofctrl.c: mff_ovn_geneve should be available at state WAIT_BEFORE_CLEAR.

2022-08-02 Thread Numan Siddique
fd2d8b3 ("ofctrl: Support ovn-ofctrl-wait-before-clear to reduce > down time during upgrade.") > Signed-off-by: Han Zhou Acked-by: Numan Siddique Numan > --- > controller/ofctrl.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [ovs-dev] [PATCH ovn] extend-table: Fix table ID double allocation after OVS restart.

2022-07-28 Thread Numan Siddique
node, target) { > hmap_remove(target, >hmap_node); > -/* Don't unset bitmap for desired group_info if the group_id > - * was not freshly reserved. */ > -if (existing || g->new_table_id) { > +if (g->peer) { > + g->

Re: [ovs-dev] [PATCH ovn branch-22.06 v2] IPsec: Add option to force NAT-T encapsulation

2022-07-23 Thread Numan Siddique
ection fails because packets are not > subject to NAT. > > Signed-off-by: Andreas Karis > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2041681 > Signed-off-by: Numan Siddique > (cherry picked from commit d6dd8e49551141159f040406202f8550c18a1846) > --- > Thanks.

Re: [ovs-dev] [PATCH ovn v2] Fix compilation issue in fedora 37/rawhide.

2022-07-21 Thread Numan Siddique
On Thu, Jul 21, 2022 at 3:44 PM Dumitru Ceara wrote: > > On 7/21/22 03:14, num...@ovn.org wrote: > > From: Numan Siddique > > > > Compilation is failing with the error: > > > > File "Documentation/conf.py", line

Re: [ovs-dev] [PATCH ovn] pinctrl: fix monitor state when using udp(icmp) to check healthy state

2022-07-21 Thread Numan Siddique
On Thu, Jul 21, 2022 at 12:40 AM wangchuanlei wrote: > Hi, > On my enviroment, i have a load-balancer, witch uses udp(icmp) > protocol to check connection status between vip and backend. > In normal cirsumstances, vip send request packet to backends , and > backends send reply to vip, so

Re: [ovs-dev] [RFC ovn] Multi-chassis port + MTU behavior

2022-07-20 Thread Numan Siddique
On Mon, Jul 18, 2022 at 7:44 PM Ihar Hrachyshka wrote: > > Hi folks, > > looking for some advices on MTU / IP behavior for multi-chassis ports. > > 22.06 got the new multichassis port concept introduced where the same > port may be present on multiple chassis, which can be used as a > performance

Re: [ovs-dev] [PATCH ovn] tests: fixed '1 LR with distributed router gateway port' fluke

2022-07-20 Thread Numan Siddique
On Tue, Jul 12, 2022 at 11:57 AM Ihar Hrachyshka wrote: > > The test sometimes failed because of duplicate periodic bcast ARPs > captured. Use _UNIQ version of packet check procedure to pass. > > Signed-off-by: Ihar Hrachyshka Thanks. Applied to the main branch. Numan > --- > tests/ovn.at |

Re: [ovs-dev] [PATCH ovn 1/3] Don't save original dst IP and Port to avoid megaflow unwildcarding.

2022-07-20 Thread Numan Siddique
On Wed, Jul 20, 2022 at 6:18 AM Dumitru Ceara wrote: > > > Hi Han, > > On 7/7/22 19:02, Dumitru Ceara wrote: > > On 7/7/22 18:21, Han Zhou wrote: > >> On Thu, Jul 7, 2022 at 8:55 AM Dumitru Ceara wrote: > >>> > >>> On 7/7/22 13:45, Dumitru Ceara wrote: > On 7/7/22 00:08, Han Zhou wrote: >

Re: [ovs-dev] [PATCH ovn] controller: fix typo in get_lport_type_str()

2022-07-20 Thread Numan Siddique
On Tue, Jul 19, 2022 at 10:13 AM Vladislav Odintsov wrote: > > Signed-off-by: Vladislav Odintsov Thanks. Applied to the main branch. Numan > --- > controller/binding.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/controller/binding.c b/controller/binding.c >

Re: [ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Align CI jobs with recent ovn-kubernetes upstream.

2022-07-20 Thread Numan Siddique
On Wed, Jul 20, 2022 at 12:22 AM Ales Musil wrote: > > Hi Dumitru, > > this is a great improvement, thank you. > > Acked-by: Ales Musil Thanks. Applied to the main branch. Numan > > On Tue, Jul 19, 2022 at 10:20 PM Dumitru Ceara wrote: > > > This has the benefit that we now use names that

Re: [ovs-dev] [PATCH ovn v2 1/2] tests: Factor out reset_pcap_file() helper.

2022-07-20 Thread Numan Siddique
On Wed, Jul 20, 2022 at 3:00 AM Ales Musil wrote: > > Hi Dumitru, > > nice to see it unified, thank you. > > Acked-by: Ales Musil Thanks. I applied this patch to the main branch. Numan > > > On Tue, Jul 19, 2022 at 10:43 PM Dumitru Ceara wrote: > > > Signed-off-by: Dumitru Ceara > > --- >

Re: [ovs-dev] [PATCH ovn v3] controller: avoid recomputes triggered by SBDB Port_Binding updates.

2022-07-20 Thread Numan Siddique
On Wed, Jul 13, 2022 at 4:29 AM Dumitru Ceara wrote: > > On 7/13/22 11:08, Dumitru Ceara wrote: > > On 7/13/22 09:40, Xavier Simonart wrote: > >> Hi Han, Dumitru > >> > > > > Hi Han, Xavier, > > > > Sorry, I had already replied to the previous message and only then > > noticed this one. > > > >>

Re: [ovs-dev] [PATCH ovn v2] tests: fixed multiple flaky tests (not waiting for patch flows)

2022-07-19 Thread Numan Siddique
On Mon, Jun 27, 2022 at 4:30 AM Xavier Simonart wrote: > > The following test cases were sometimes failing, (mainly) for the same reason > i.e. packet lost as being sent before patch ports were installed. > - 2 HVs, 2 LS, switching between multiple localnet ports with same tags > - VLAN

Re: [ovs-dev] [PATCH ovn v5] controller: Add delay after multicast ARP packet

2022-07-19 Thread Numan Siddique
On Thu, Jul 14, 2022 at 6:42 AM Dumitru Ceara wrote: > > On 7/14/22 12:37, Ales Musil wrote: > > The ovn-controller had a race condition over MAC > > binding table with other controllers. When multiple > > controllers received GARP from single source usually > > the one who was able to win the

Re: [ovs-dev] [PATCH ovn] pinctrl: fix ovn-controller abort when service start.

2022-07-19 Thread Numan Siddique
On Fri, Jul 15, 2022 at 8:35 AM wangchuanlei wrote: > > Hi, > when start service ovn-controller, the br-int may be not connected, in > case, swconn->version = -1, > on my enviroment, i have loadlalancer, in the process of sending health > check packet, ofp_proto is 0, which will leads

<    1   2   3   4   5   6   7   8   9   10   >