Re: [ovs-dev] OVS/OVN Split initial commits are complete

2019-04-25 Thread Numan Siddique
On Fri, Apr 26, 2019 at 11:14 AM Numan Siddique wrote: > > > On Fri, Apr 26, 2019 at 1:56 AM Ben Pfaff wrote: > >> On Thu, Apr 25, 2019 at 12:51:29PM -0700, Ben Pfaff wrote: >> > On Thu, Apr 25, 2019 at 08:38:06AM -0400, Mark Michelson wrote: >> > > Yes

Re: [ovs-dev] [PATCH v2] Shutdown SSL connection before closing socket

2019-07-16 Thread Numan Siddique
down() and ignores SSL errors, the > > same way that lib/stream-ssl.c does in ssl_close(). > > > > Signed-off-by: Terry Wilson > Acked-by: Numan Siddique > > --- > > python/ovs/stream.py | 8 > > 1 file changed, 8 insertions(+) > > > &g

Re: [ovs-dev] [PATCH v6] ovn: Add a new logical switch port type - 'virtual'

2019-07-16 Thread Numan Siddique
On Wed, Jul 17, 2019 at 3:48 AM Ben Pfaff wrote: > On Fri, Jul 12, 2019 at 11:32:47PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > This new type is added for the following reasons: > > > > - When a load balancer is created in an Op

Re: [ovs-dev] [PATCH v3] ovn-northd: Add the option to pause and resume

2019-07-16 Thread Numan Siddique
On Wed, Jul 17, 2019 at 3:40 AM Ben Pfaff wrote: > On Tue, Jul 09, 2019 at 10:40:57AM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > This patch adds 3 unixctl socket comments - pause, resume and is-paused. > > > > Usage: ovs-appctl -t

Re: [ovs-dev] [PATCH] OVN: Enhance ovndb-servers.ocf to handle inactive_probe_interval updates

2019-06-28 Thread Numan Siddique
rs --set-parameter > inactive_probe_interval --parameter-value > > To set a new inactive probe interval in OVSDB. The patch also handles > the case were multiple connection exists. > > Signed-off-by: Lucas Alvares Gomes > Acked-by: Numan Siddique > --- > ovn/utilities/ovndb-ser

Re: [ovs-dev] [PATCH] OVN: Enhance ovndb-servers.ocf to handle inactive_probe_interval updates

2019-06-28 Thread Numan Siddique
On Fri, Jun 28, 2019 at 11:46 PM Numan Siddique wrote: > > > On Wed, Jun 26, 2019 at 2:42 PM wrote: > >> From: Lucas Alvares Gomes >> >> This patch is enhacing the ovndb-servers.ocf script to handle updates to >> the inactive_probe_interval via p

Re: [ovs-dev] [PATCH v2 1/3] ovn-northd: Refactor the code which sets nat_addresses

2019-07-01 Thread Numan Siddique
On Fri, Jun 28, 2019 at 1:55 PM Dumitru Ceara wrote: > On Fri, Jun 14, 2019 at 2:37 PM wrote: > > > > From: Numan Siddique > > > > The present code which sets the Port_Binding.nat_addresses > > can be simplied. This patch does this. This would he

Re: [ovs-dev] [PATCH v2] OVN: Enhance ovndb-servers.ocf to handle inactive_probe_interval updates

2019-06-28 Thread Numan Siddique
On Thu, Jun 27, 2019 at 12:43 AM Numan Siddique wrote: > > > On Thu, Jun 27, 2019 at 12:41 AM Ben Pfaff wrote: > >> On Wed, Jun 26, 2019 at 11:59:30AM +0100, lmart...@redhat.com wrote: >> > From: Lucas Alvares Gomes >> > >> > This patch is en

Re: [ovs-dev] [PATCH v4 ovn] ovn-northd: Add the option to pause and resume

2019-07-31 Thread Numan Siddique
On Wed, Jul 31, 2019 at 8:07 PM Dumitru Ceara wrote: > On Mon, Jul 29, 2019 at 7:43 PM wrote: > > > > From: Numan Siddique > > > > This patch adds 3 unixctl socket comments - pause, resume and is-paused. > > > > Usage: ovs-appctl -t ovn-northd paus

Re: [ovs-dev] [PATCH] [ovn-northd] Don't emit ICMP need to frag on LRP with no IPv4 address

2019-07-29 Thread Numan Siddique
On Fri, Jul 26, 2019 at 1:52 AM Mark Michelson wrote: > LGTM > > Acked-by: Mark Michelson > > On 7/25/19 11:38 AM, Daniel Alvarez wrote: > > Prior to this patch, when a LRP has only IPv6 addresses, ovn-northd > > will crash (SIGSEV) because the current code injects a flow to > > emit the ICMP

Re: [ovs-dev] [ovn] OVN split: Remove make "modules_install" target

2019-07-29 Thread Numan Siddique
On Tue, Jul 30, 2019 at 2:40 AM Mark Michelson wrote: > Acked-by: Mark Michelson > On 7/29/19 8:59 AM, lmart...@redhat.com wrote: > > From: Lucas Alvares Gomes > > > > This patch is removing the make "modules_install" target for the new OVN > > repository. > > > > The target is not be needed

Re: [ovs-dev] [PATCH ovn 2/2] ovn-controller: Fix flow installation latency caused by recompute.

2019-07-29 Thread Numan Siddique
ducing engine_set_abort_recompute(), > so that we can prioritize new change handling if the change can be > incrementally processed, but if the change triggers recompute, we > abort there without spending CPU on the recompute to avoid blocking > the previous computed flow installation. > &g

Re: [ovs-dev] [PATCH ovn 2/2] ovn-controller: Fix flow installation latency caused by recompute.

2019-07-29 Thread Numan Siddique
On Tue, Jul 30, 2019 at 9:39 AM Numan Siddique wrote: > > > On Tue, Jul 30, 2019 at 7:10 AM Han Zhou wrote: > >> From: Han Zhou >> >> When there are in-flight flow-installations pending to ovs-vswitchd, >> current incremental processing logic priorit

Re: [ovs-dev] [PATCH ovn] Fix the chassis row recreation issue

2019-07-29 Thread Numan Siddique
On Mon, Jul 29, 2019 at 10:54 PM wrote: > From: Numan Siddique > > Before the commit [1], ovn-controller would always recreate its > chassis row if deleted externally. After this commit, it no longer > recreates it. This is regression and needs to be fixed. > > [1

Re: [ovs-dev] [PATCH ovn] Change the package name from openvswitch to ovn in AC_INIT()

2019-08-02 Thread Numan Siddique
On Thu, Aug 1, 2019 at 9:46 PM Mark Michelson wrote: > Acked-by: Mark Michelson > Thanks. I applied this to master. Numan > > On 8/1/19 9:46 AM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Signed-off-by: Numan Siddique > > --- > >

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix IP engine run with in-flight messages

2019-08-02 Thread Numan Siddique
st one test fails for me 100% of the time when I run tests with -j5. Tested-by: Numan Siddique I didn't get the chance to look into the code changes carefully. Thanks Numan --- > controller/ovn-controller.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > >

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fixed memory leak in ovn_port_update_sbrec()

2019-08-02 Thread Numan Siddique
> Signed-off-by: Damijan Skvarc > Acked-by: Numan Siddique > --- > northd/ovn-northd.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c > index cd776fa..d99ae67 100644 > --- a/northd/ovn-northd.c &g

Re: [ovs-dev] [PATCH ovn] Add -u option to ovn-nbctl

2019-08-02 Thread Numan Siddique
tl client the name > of the unixctl socket to attempt to connect to. > > Signed-off-by: Mark Michelson > Acked-by: Numan Siddique > --- > tests/ovn.at | 19 +++ > utilities/ovn-nbctl.8.xml | 20 > utilities/ovn-nbctl.c | 1

Re: [ovs-dev] [PATCH] OVN: fix L4 default lb proto reported by ovn-nbctl

2019-08-02 Thread Numan Siddique
On Fri, Aug 2, 2019 at 6:11 PM Dumitru Ceara wrote: > On Thu, Aug 1, 2019 at 7:40 PM Lorenzo Bianconi > wrote: > > > > If no protocol is specified defining a load balancing rule TCP is > > selected as default but ovn-nbctl lb-list reports 'tcp/udp'. > > Fix it reporting 'tcp' in this case > > >

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fixed memory leak in ovn_port_update_sbrec()

2019-08-02 Thread Numan Siddique
On Fri, Aug 2, 2019 at 6:31 PM 0-day Robot wrote: > Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > git-am: > fatal: sha1 information is

Re: [ovs-dev] [branch2.12] ovn: Add a new logical switch port type - 'virtual'

2019-08-02 Thread Numan Siddique
On Fri, Aug 2, 2019 at 6:20 AM Guru Shetty wrote: > > > On Thu, 1 Aug 2019 at 10:52, wrote: > >> From: Numan Siddique >> >> This new type is added for the following reasons: >> >> - When a load balancer is created in an OpenStack deployment

Re: [ovs-dev] [PATCH ovn v3] ovn-northd: Add IGMP Relay support

2019-08-16 Thread Numan Siddique
On Fri, Aug 16, 2019 at 5:26 PM Dumitru Ceara wrote: > On Fri, Aug 16, 2019 at 12:23 PM Numan Siddique > wrote: > > > > > > > > On Mon, Aug 12, 2019 at 5:32 PM Dumitru Ceara wrote: > >> > >> Add a new configuration option 'mcast_relay' to the >

Re: [ovs-dev] [PATCH ovn] pinctrl: Fix DNS packet parsing

2019-08-16 Thread Numan Siddique
t; >>> send(p) > > Also add a sanity check on minimum L4 size of packets. > > CC: Numan Siddique > Fixes: 16cb4fb8ca49 ("ovn-controller: Add 'dns_lookup' action") > Reported-at: https://bugzilla.redhat.com/1740335 > Reported-by: Priscila > Signed-off-b

Re: [ovs-dev] [PATCH v5 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-16 Thread Numan Siddique
On Fri, Aug 16, 2019 at 1:11 AM Ankur Sharma wrote: > With 795d7f24ce0e2ed5454e193a059451d237289542 we have added > support for E-W routing on vlan backed networks by replacing > router port macs with chassis macs. > > This replacement of router port mac need NOT be done on > gateway chassis for

Re: [ovs-dev] [PATCH ovn v4] ovn-northd: Add IGMP Relay support

2019-08-16 Thread Numan Siddique
On Fri, Aug 16, 2019 at 6:23 PM Numan Siddique wrote: > > > On Fri, Aug 16, 2019 at 5:51 PM Dumitru Ceara wrote: > >> Add a new configuration option 'mcast_relay' to the Logical_Router:options >> in the OVN Northbound database. >> >> If a router is configured

Re: [ovs-dev] [PATCH ovn v4] ovn-northd: Add IGMP Relay support

2019-08-16 Thread Numan Siddique
st > traffic and continue to next table. > - Table S_ROUTER_OUT_DELIVERY: add flow matching IP multicast traffic > and set ETH.SRC to the MAC address of the logical port on which > traffic is forwarded. > > Signed-off-by: Dumitru Ceara > Acked-by: Mark Michelson > Acked-by: Numan S

Re: [ovs-dev] [PATCH v1 ovn] Containerize components

2019-08-16 Thread Numan Siddique
On Thu, Aug 1, 2019 at 3:01 AM Aliasgar Ginwala wrote: > 1. Containerize ovn central components > 2. Containerize ovn host > 3. Update documentation about building/running ovn in containers. > > Hi Aliasgar, Thanks for the patch. This is interesting. I tried out both the OVS patch and this

Re: [ovs-dev] [PATCH ovn 4/4] rhel: Run ovn services with the 'openvswitch' user

2019-08-14 Thread Numan Siddique
vn:openvswitch" and it was not working for me. May be I am doing something wrong ? Thanks for the comments. Numan > BR > Jaime. > > -Original Message- > From: nusid...@redhat.com > To: d...@openvswitch.org > Cc: Jaime Caamano > Subject: [PATCH ovn 4/4]

Re: [ovs-dev] [PATCH ovn] Add support for using OVN specific rundirs

2019-08-12 Thread Numan Siddique
On Mon, Aug 12, 2019 at 2:59 PM Dumitru Ceara wrote: > On Fri, Aug 9, 2019 at 8:24 PM wrote: > > > > From: Numan Siddique > > > > Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). > > The commit [1] changed the package name from openvswit

Re: [ovs-dev] [PATCH ovn 1/4] Add support for using OVN specific rundirs

2019-08-19 Thread Numan Siddique
On Fri, Aug 16, 2019 at 10:45 PM Mark Michelson wrote: > On 8/13/19 12:27 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). > > The commit [1] changed the package name from openvswitc

Re: [ovs-dev] [PATCH ovn 3/4] Fix "make rpm-fedora"

2019-08-19 Thread Numan Siddique
On Fri, Aug 16, 2019 at 10:46 PM Mark Michelson wrote: > On 8/13/19 12:28 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > "make rpm-fedora" is broken and this patch fixes it. Previous patch > > in this series supported building OVN from

Re: [ovs-dev] [PATCH] Make pidfile_is_running more robust against empty pidfiles

2019-08-20 Thread Numan Siddique
On Wed, Aug 14, 2019 at 9:21 PM Michele Baldessari wrote: > On Wed, Aug 14, 2019 at 02:28:13PM +0300, Ilya Maximets wrote: > > On 14.08.2019 11:39, Michele Baldessari wrote: > > > In some of our destructive testing of ovn-dbs inside containers managed > > > by pacemaker we reached a situation

Re: [ovs-dev] [PATCH] test: do not require python2 for CHECK_CONNTRACK macro

2019-08-20 Thread Numan Siddique
I applied this patch to OVN master as this fix is required for ovn repo too. Thanks Numan On Tue, Jul 30, 2019 at 11:51 PM Darrell Ball wrote: > On Tue, Jul 30, 2019 at 10:41 AM Mark Michelson > wrote: > > > Why do these macros require python at all? > > > > alg test tools > > > > > > > On

Re: [ovs-dev] [PATCH] Make pidfile_is_running more robust against empty pidfiles

2019-08-20 Thread Numan Siddique
On Tue, Aug 20, 2019 at 2:52 PM Ilya Maximets wrote: > On 20.08.2019 12:16, Ilya Maximets wrote: > > On 20.08.2019 11:48, Numan Siddique wrote: > >> > >> > >> On Wed, Aug 14, 2019 at 9:21 PM Michele Baldessari <mailto:mich...@acksyn.org>> wrote: >

Re: [ovs-dev] [PATCH ovn v3] ovn-northd: Add IGMP Relay support

2019-08-16 Thread Numan Siddique
On Mon, Aug 12, 2019 at 5:32 PM Dumitru Ceara wrote: > Add a new configuration option 'mcast_relay' to the Logical_Router:options > in the OVN Northbound database. > > If a router is configured with 'mcast_relay' enabled then ovn-northd > will install Logical_Flows to allow IP multicast traffic

Re: [ovs-dev] [PATCH v3 ovn] Containerize components

2019-08-21 Thread Numan Siddique
On Wed, Aug 21, 2019 at 10:38 PM wrote: > From: Aliasgar Ginwala > > 1. Containerize ovn central components > 2. Containerize ovn host > 3. Update documentation about building/running ovn in containers. > > Signed-off-by: Aliasgar Ginwala > Hi Aliasgar, There's something odd with this patch.

Re: [ovs-dev] [PATCH v3 ovn 3/3] OVN: northd: add rate limiting support for SB controller events

2019-08-21 Thread Numan Siddique
On Mon, Aug 19, 2019 at 8:09 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Introduce the capability to associate a meter to each controller event > type in order to not overload the pinctrl thread under heavy load. > Each event type relies on a meter with a defined name: > -

Re: [ovs-dev] [PATCH v4 ovn] Containerize components

2019-08-21 Thread Numan Siddique
On Thu, Aug 22, 2019 at 1:35 AM wrote: > From: Aliasgar Ginwala > > 1. Containerize ovn central components > 2. Containerize ovn host > 3. Update documentation about building/running ovn in containers. > > Signed-off-by: Aliasgar Ginwala > Thanks. Acked-by

Re: [ovs-dev] [PATCH v3 ovn 2/3] OVN: add meter support to trigger_event action

2019-08-21 Thread Numan Siddique
On Mon, Aug 19, 2019 at 8:09 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Introduce meter support to trigger_event action in order to not > overload pinctrl thread under heavy load > > Signed-off-by: Lorenzo Bianconi > Hi Lorenzo, Can you please add a test for the meter option

Re: [ovs-dev] [PATCH v2 ovn 0/5] External OVS source support and separate run dir for OVN

2019-08-21 Thread Numan Siddique
On Wed, Aug 21, 2019 at 10:30 PM Han Zhou wrote: > > > On Mon, Aug 19, 2019 at 11:13 AM wrote: > > > > From: Numan Siddique > > > > This patch series adds support for building OVN from external OVS > > sources. > > > > The first patch adds the

Re: [ovs-dev] [PATCH v3 ovn 1/3] OVN: Repair memory leak for OVN controller events.

2019-08-21 Thread Numan Siddique
On Mon, Aug 19, 2019 at 8:08 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > From: Mark Michelson > > From: Mark Michelson > > Controller event action is leaking its genopts. This corrects the error. > > Signed-off-by: Mark Michelson > Signed-off-by: Lorenzo Bianconi > I applied

Re: [ovs-dev] [PATCH v2 ovn 0/5] External OVS source support and separate run dir for OVN

2019-08-22 Thread Numan Siddique
On Thu, Aug 22, 2019 at 12:27 PM Numan Siddique wrote: > > > On Thu, Aug 22, 2019 at 2:19 AM Han Zhou wrote: > >> >> >> On Wed, Aug 21, 2019 at 11:54 AM Numan Siddique >> wrote: >> > >> > >> > >> > On Wed, Aug 21, 2019 a

Re: [ovs-dev] [PATCH v2 ovn 0/5] External OVS source support and separate run dir for OVN

2019-08-22 Thread Numan Siddique
On Thu, Aug 22, 2019 at 2:19 AM Han Zhou wrote: > > > On Wed, Aug 21, 2019 at 11:54 AM Numan Siddique > wrote: > > > > > > > > On Wed, Aug 21, 2019 at 10:30 PM Han Zhou wrote: > >> > >> > >> > >> On

Re: [ovs-dev] [PATCH v6 2/4 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-24 Thread Numan Siddique
On Sat, Aug 17, 2019 at 6:07 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that

Re: [ovs-dev] [PATCH v6 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-24 Thread Numan Siddique
On Sat, Aug 17, 2019 at 6:23 AM Ankur Sharma wrote: > With 795d7f24ce0e2ed5454e193a059451d237289542 we have added > support for E-W routing on vlan backed networks by replacing > router port macs with chassis macs. > > This replacement of router port mac need NOT be done on > gateway chassis for

Re: [ovs-dev] [PATCH v6 3/4 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-24 Thread Numan Siddique
On Sat, Aug 17, 2019 at 6:08 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that

Re: [ovs-dev] [PATCH v1 ovn] OVN: Replace chassis mac with router port mac on destination chassis

2019-08-27 Thread Numan Siddique
t me know your thoughts, I will be happy to make changes accordingly. > Meanwhile, I am submitting a V2 which is rebased to TOT. > > Appreciate your inputs. > > > Regards, > Ankur > > > > *From:* Numan Siddique > *Sent:* Monday, August 26, 2019 5:02 AM > *To:* Anku

Re: [ovs-dev] [PATCH v7 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-27 Thread Numan Siddique
On Wed, Aug 28, 2019, 6:34 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that >

Re: [ovs-dev] [ovs-discuss] ovn-controller is taking 100% CPU all the time in one deployment

2019-08-30 Thread Numan Siddique
2019 at 11:50 PM Han Zhou wrote: > On Fri, Aug 30, 2019 at 6:46 AM Mark Michelson > wrote: > > > > On 8/30/19 5:39 AM, Daniel Alvarez Sanchez wrote: > > > On Thu, Aug 29, 2019 at 10:01 PM Mark Michelson > wrote: > > >> > > >> On 8/29/19 2:3

Re: [ovs-dev] [ovs-discuss] ovn-controller is taking 100% CPU all the time in one deployment

2019-08-31 Thread Numan Siddique
On Sat, Aug 31, 2019 at 2:05 AM Han Zhou wrote: > > > On Fri, Aug 30, 2019 at 1:25 PM Numan Siddique > wrote: > > > > Hi Han, > > > > I am thinking of this approach to solve this problem. I still need to > test it. > > If you

Re: [ovs-dev] ovn-controller is taking 100% CPU all the time in one deployment

2019-08-30 Thread Numan Siddique
On Fri, Aug 30, 2019 at 1:04 AM Han Zhou wrote: > > > On Thu, Aug 29, 2019 at 12:16 PM Numan Siddique > wrote: > >> >> >> On Fri, Aug 30, 2019 at 12:37 AM Han Zhou wrote: >> >>> >>> >>> On Thu, Aug 29, 2019 at 11:40 AM Numan S

Re: [ovs-dev] [PATCH ovn] Fix configure help string for ovs source/build path

2019-09-03 Thread Numan Siddique
On Fri, Aug 30, 2019 at 6:53 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Signed-off-by: Lorenzo Bianconi > Thanks. I pushed this to master. Numan > --- > acinclude.m4 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/acinclude.m4 b/acinclude.m4 >

Re: [ovs-dev] [PATCH v1 ovn] OVN: Send RARP for vif ports for which OVN does not know the IP.

2019-09-03 Thread Numan Siddique
On Fri, Aug 2, 2019 at 3:12 AM Ankur Sharma wrote: > ISSUE: > For a VIF port (on a bridged logical switch), OVN sends out > GARPs, advertising port's mac and IP. > > However, if a VIF port (on a bridged logical switch) has not > been assigned an IP, then OVN does not advertise anything. > As a

Re: [ovs-dev] [PATCH v2 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-03 Thread Numan Siddique
On Tue, Aug 27, 2019 at 7:31 AM Ankur Sharma wrote: > During E-W routing for vlan backed networks, we replace router port > mac with chassis mac, when packet leaves the source hypervisor. > > As a result, the destination VM (on remote hypervisor) will see > chassis mac as source mac in received

Re: [ovs-dev] [PATCH v4 ovn 0/4] External OVS source support and separate run dir for OVN

2019-08-29 Thread Numan Siddique
On Thu, Aug 29, 2019, 1:16 AM Mark Michelson wrote: > Acked-by: Mark Michelson > Thanks for the review. I applied this series to master. Thanks Numan > On 8/28/19 12:38 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > This patch series adds su

Re: [ovs-dev] [PATCH v2 ovn 2/3] ovn-controller: Optimize update of ct-zones external-ids.

2019-08-28 Thread Numan Siddique
On Fri, Aug 23, 2019 at 4:54 PM Dumitru Ceara wrote: > commit_ct_zones() is called at every ovn-controller iteration but updates > to > ct-zones don't happen at every iteration. Avoid cloning the > br-int->external_ids map unless an update is needed. > > Signed-off-by: Dumitru Ceara > --- >

Re: [ovs-dev] [PATCH v2 ovn 1/3] ofctrl: Avoid recomputing match hash in ofctrl_dup_flow().

2019-08-28 Thread Numan Siddique
On Fri, Aug 23, 2019 at 4:54 PM Dumitru Ceara wrote: > Signed-off-by: Dumitru Ceara > Thanks. I applied this patch to master. Numan > --- > controller/ofctrl.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/controller/ofctrl.c b/controller/ofctrl.c > index

Re: [ovs-dev] [PATCH v2 ovn 3/3] ovn-controller: Minimize SB DB port_binding lookups.

2019-08-28 Thread Numan Siddique
On Fri, Aug 23, 2019 at 4:55 PM Dumitru Ceara wrote: > Instead of storing only peer_ports in struct local_datapath, store both > local-remote mappings for patch ports. Also, it's useful to directly > store sbrec_port_binding pointers for all datapath ports as we avoid > doing costly

Re: [ovs-dev] [PATCH v8 3/3 ovn] OVN: Vlan backed DVR N-S, redirect packet via localnet port

2019-08-28 Thread Numan Siddique
On Wed, Aug 28, 2019 at 7:27 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that

Re: [ovs-dev] [PATCH v8 2/3 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-28 Thread Numan Siddique
On Wed, Aug 28, 2019 at 7:27 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that

Re: [ovs-dev] [PATCH v8 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-28 Thread Numan Siddique
On Wed, Aug 28, 2019 at 7:26 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that

Re: [ovs-dev] ovn-controller is taking 100% CPU all the time in one deployment

2019-08-29 Thread Numan Siddique
On Fri, Aug 30, 2019 at 12:37 AM Han Zhou wrote: > > > On Thu, Aug 29, 2019 at 11:40 AM Numan Siddique > wrote: > > > > Hello Everyone, > > > > In one of the OVN deployments, we are seeing 100% CPU usage by > ovn-controllers all the time. > >

[ovs-dev] ovn-controller is taking 100% CPU all the time in one deployment

2019-08-29 Thread Numan Siddique
Hello Everyone, In one of the OVN deployments, we are seeing 100% CPU usage by ovn-controllers all the time. After investigations we found the below - ovn-controller is taking more than 20 seconds to complete full loop (mainly in lflow_run() function) - The physical switch is sending GARPs

Re: [ovs-dev] [PATCH v4 ovn] Containerize components

2019-08-24 Thread Numan Siddique
On Thu, Aug 22, 2019 at 1:54 AM Numan Siddique wrote: > > > On Thu, Aug 22, 2019 at 1:35 AM wrote: > >> From: Aliasgar Ginwala >> >> 1. Containerize ovn central components >> 2. Containerize ovn host >> 3. Update documentation about building/r

Re: [ovs-dev] [PATCH v1 ovn] OVN: Replace chassis mac with router port mac on destination chassis

2019-08-26 Thread Numan Siddique
Hi Ankur, This patch doesn't apply now. Can you please re base. Few comments below Thanks Numan On Thu, Aug 22, 2019 at 1:51 AM Ankur Sharma wrote: > During E-W routing for vlan backed networks, we replace router port > mac with chassis mac, when packet leaves the source hypervisor. > > As a

Re: [ovs-dev] [PATCH ovn] Fix memory leak in build_pre_lb

2019-08-26 Thread Numan Siddique
On Sun, Aug 25, 2019 at 11:32 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Fix memory leak of ip_address string in build_pre_lb routine if we > install logical flows for empty_lb controller event > > Fixes: f49b17a6cbe3 ("OVN: use trigger_event action to report > 'empty_lb_rule'

Re: [ovs-dev] ovn-controller is taking 100% CPU all the time in one deployment

2019-09-02 Thread Numan Siddique
On Sat, Aug 31, 2019 at 2:48 AM Han Zhou wrote: > > > On Thu, Aug 29, 2019 at 11:36 PM Numan Siddique > wrote: > > > > > > > > On Fri, Aug 30, 2019 at 1:04 AM Han Zhou wrote: > >> > >> > >> > >> On Thu, Aug 29, 2019 at

Re: [ovs-dev] [PATCH ovn] Remove ageing check in run_put_mac_binding

2019-08-22 Thread Numan Siddique
ever be updated > > Signed-off-by: Lorenzo Bianconi > LGTM. Thanks for the patch. Acked-by: Numan Siddique Numan > --- > controller/pinctrl.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/controller/pinctrl.c b/controller/pinctrl.c > index 365a

Re: [ovs-dev] [PATCH v2 ovn] Containerize components

2019-08-21 Thread Numan Siddique
On Sat, Aug 17, 2019 at 12:53 PM Aliasgar Ginwala wrote: > 1. Containerize ovn central components > 2. Containerize ovn host > 3. Update documentation about building/running ovn in containers. > > Signed-off-by: aginwala > This patch has conflicts. Would you mind submit v3 rebasing the patch ?

Re: [ovs-dev] [PATCH v2] OVS: Containerize components

2019-08-22 Thread Numan Siddique
ation about how to build/run ovs in docker. > > Signed-off-by: aginwala > Acked-by: Numan Siddique As discussed in the meeting today, can you please provide the option to enable or disable kernel module compilation when building the docker images in a follow up patch. Also, is it Ok if you

Re: [ovs-dev] [PATCH ovn 4/4] rhel: Run ovn services with the 'openvswitch' user

2019-08-24 Thread Numan Siddique
the dpdk initialization is not done. Maybe it's fedora specific? > > If it were to me I would remove that, and let the admin setup the > appropriate mount point as part of the dpdk setup workflow. > > BR > Jaime. > > -Original Message- > From: Jaime Caamaño Rui

Re: [ovs-dev] [PATCH v5 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-23 Thread Numan Siddique
take a look and come back to you if there are any comments. Thanks Numan > Regards, > > Ankur > > *From:* Ankur Sharma > *Sent:* Friday, August 16, 2019 5:37 PM > *To:* Numan Siddique > *Cc:* ovs-dev@openvswitch.org > *Subject:* RE: [ovs-dev] [PATCH v5 1/4 ovn]

Re: [ovs-dev] [PATCH v3 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-06 Thread Numan Siddique
Hi Ankur, Couple of comments, otherwise LGTM. Thanks Numan On Wed, Sep 4, 2019 at 12:45 AM Ankur Sharma wrote: > During E-W routing for vlan backed networks, we replace router port > mac with chassis mac, when packet leaves the source hypervisor. > > As a result, the destination VM (on

Re: [ovs-dev] [PATCH ovn v2] OVN: Fix learning of neighbors from ARP/ND packets.

2019-09-11 Thread Numan Siddique
On Thu, Aug 15, 2019 at 12:24 PM Han Zhou wrote: > On Wed, Aug 14, 2019 at 11:11 PM Dumitru Ceara wrote: > > > > On Thu, Aug 8, 2019 at 1:52 AM Han Zhou wrote: > > > > > > > > > > > > On Wed, Aug 7, 2019 at 8:12 AM Dumitru Ceara > wrote: > > >> > > >> On Mon, Aug 5, 2019 at 5:34 PM Han Zhou

Re: [ovs-dev] [PATCH ovn v2 1/2] Add ovn-appctl utility

2019-09-11 Thread Numan Siddique
On Tue, Sep 10, 2019 at 11:37 PM Mark Michelson wrote: > For the series, > Acked-by: Mark Michelson > Thanks. I applied this series to master. Numan > > On 9/10/19 3:42 AM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Now that OVN has it's

Re: [ovs-dev] [PATCH ovn] ovn-openstack.rst: Add check for Gateway_Chassis table

2019-09-11 Thread Numan Siddique
On Thu, Sep 5, 2019 at 7:57 PM Flavio Fernandes wrote: > This is related to the section called "Adding a Gateway". > > Added workaround command for a known issue in networking-ovn. > Even after the issue is resolved, it may be useful to have this > in the tutorial, so folks have a feel for how

Re: [ovs-dev] [PATCH v5 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-11 Thread Numan Siddique
On Wed, Sep 11, 2019 at 2:53 AM Ankur Sharma wrote: > During E-W routing for vlan backed networks, we replace router port > mac with chassis mac, when packet leaves the source hypervisor. > > As a result, the destination VM (on remote hypervisor) will see > chassis mac as source mac in received

Re: [ovs-dev] [PATCH] ovn: Fix broken dist* targets.

2019-09-11 Thread Numan Siddique
_libovn_la_SOURCES', > needed by 'distdir'. Stop. > > CC: Mark Michelson > Fixes: f3e24610ea18 ("Remove OVN.") > Signed-off-by: Ilya Maximets > Acked-by: Numan Siddique There's another cleanup patch if you would like to take a look - https://patchwork.ozlabs.org/p

Re: [ovs-dev] [PATCH ovn] Exclude inport and outport symbol tables from conjunction

2019-09-14 Thread Numan Siddique
come up with ideas. I know Dumitru has some idea to make use of conjunctions for port groups. CC'ing Han if he has any comments on ideas. Thanks Numan > Thanks a lot everyone! > Daniel > > > > On 9/13/19 4:49 PM, nusid...@redhat.com wrote: > > > From: Numan Siddique >

Re: [ovs-dev] [PATCH] Fix the segfault seen in ovn-controller when running tests

2019-09-09 Thread Numan Siddique
On Mon, Sep 9, 2019 at 8:48 PM Lorenzo Bianconi wrote: > > > > From: Numan Siddique > > > > The test case - "116: ovn -- 2 HVs, 2 lports/HV, localnet ports, DVR N-S > Ping" > > is failing with the segfault in ovn-controller occationally. > > &g

Re: [ovs-dev] [PATCH v3 ovn] northd: add empty_lb controller_event for logical router

2019-09-16 Thread Numan Siddique
On Sat, Sep 14, 2019 at 2:03 AM Mark Michelson wrote: > Acked-by: Mark Michelson > > On 9/10/19 1:00 PM, Lorenzo Bianconi wrote: > > Add empty load balancer controller_event support to logical router > > pipeline. Update northd documentation even for logical switch pipeline > > > >

Re: [ovs-dev] [PATCH ovn] gitignore: Add missing OVN entries.

2019-09-16 Thread Numan Siddique
On Fri, Sep 13, 2019 at 8:24 PM Dumitru Ceara wrote: > Signed-off-by: Dumitru Ceara > Thanks. I applied this patch to master. Numan > --- > .gitignore | 8 > include/ovn/.gitignore | 2 ++ > utilities/.gitignore | 1 + > 3 files changed, 11 insertions(+) > create

Re: [ovs-dev] [PATCH v3 ovn 0/2] ovn-controller: Logical flow processing optimizations

2019-09-16 Thread Numan Siddique
On Fri, Sep 13, 2019 at 3:13 AM Han Zhou wrote: > On Thu, Sep 12, 2019 at 7:14 AM Dumitru Ceara wrote: > > > > This series adds some (independent) optimizations that improve > > ovn-controller performance by lowering the number of operations that > > need to be executed during a iteration of

Re: [ovs-dev] [PATCH ovn] Handle GARP reply packets from provider networks only on gateway chassis

2019-09-05 Thread Numan Siddique
On Thu, Sep 5, 2019 at 3:19 AM Han Zhou wrote: > > > On Mon, Sep 2, 2019 at 9:32 AM wrote: > > > > From: Numan Siddique > > > > Suppose there is a provider network (with localnet port) and it is > > connected to a logical router via a distributed ga

Re: [ovs-dev] [RFC v2] Document process for compatibility between OVS and OVN.

2019-09-10 Thread Numan Siddique
Hi Mark, Few comments below. On Sat, Sep 7, 2019 at 2:38 AM Mark Michelson wrote: > This document serves to provide an explanation for how OVN will remain > compatible with OVS. It provides instructions for OVN contributors for > how to maintain compatibility even across older versions of OVS

Re: [ovs-dev] [PATCH v4 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-10 Thread Numan Siddique
On Mon, Sep 9, 2019 at 1:58 AM Ankur Sharma wrote: > During E-W routing for vlan backed networks, we replace router port > mac with chassis mac, when packet leaves the source hypervisor. > > As a result, the destination VM (on remote hypervisor) will see > chassis mac as source mac in received

Re: [ovs-dev] [PATCH ovn 1/2] Add ovn-appctl utility

2019-09-10 Thread Numan Siddique
On Wed, Sep 4, 2019 at 11:21 PM Mark Michelson wrote: > On 9/2/19 1:09 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Now that OVN has it's own rundir, "ovs-appctl -t > ovn-controller/ovn-northd" > > doesn't work. To fix this, ovn

Re: [ovs-dev] ovn-controller consuming lots of CPU

2019-07-30 Thread Numan Siddique
On Tue, Jul 30, 2019 at 2:25 PM Frank Wang(王培辉) wrote: > Hi All, > > > > I’m using the latest ovn 2.11.1 version, I found ovn-controller consuming > a lot of CPU, I’d like to know if this is a bug, This seems to have > happened before, but not in the same place, > > This time the lib/stream-fd.c

Re: [ovs-dev] [RFC 0/2] OVN: add rate limiting support for controller_events

2019-07-30 Thread Numan Siddique
On Tue, Jul 30, 2019 at 7:14 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Introduce the capability to associate a meter to each controller event > type in order to not overload the pinctrl thread under heavy load. > For each event type we need to define a naming convention for the

Re: [ovs-dev] OVS/OVN split complete in ovn-org/ovn repository

2019-07-31 Thread Numan Siddique
--Original Message- > From: ovs-dev-boun...@openvswitch.org > On Behalf Of Numan Siddique > Sent: Friday, July 26, 2019 10:38 AM > To: ovs-dev@openvswitch.org; ovs-discuss > Subject: [ovs-dev] OVS/OVN split complete in ovn-org/ovn repository > > Hello everyone, > > We

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix IP engine run with in-flight messages

2019-08-05 Thread Numan Siddique
On Mon, Aug 5, 2019 at 2:11 AM Han Zhou wrote: > On Fri, Aug 2, 2019 at 2:23 AM Dumitru Ceara wrote: > > > > When trying to incrementally process changes even if there are in-flight > > messages we were incorrectly setting the engine_aborted variable to the > > value returned by engine_run.

Re: [ovs-dev] 2.12.0 branch snapshot - test 2618 failure on s390x

2019-08-07 Thread Numan Siddique
On Wed, Aug 7, 2019 at 4:20 PM James Page wrote: > Just tripped on this one whilst building for s390x on Ubuntu: > > ## ## > > ## Summary of the failures. ## > ## ## > Failed tests: > openvswitch 2.12.0 test suite test groups: > > NUM:

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-07 Thread Numan Siddique
On Wed, Aug 7, 2019 at 4:59 PM Damijan Skvarc wrote: > Within this function actions & match dynamic strings are used as helper > variables for adding entries into logical flow table. Variables are > used several times in order to optimize number of memory allocations, > however at the end memory

Re: [ovs-dev] [PATCH ovn] Enable OVN in tutorial/ovs-sandbox by default

2019-08-07 Thread Numan Siddique
On Wed, Aug 7, 2019 at 11:27 PM Mark Michelson wrote: > Acked-by: Mark Michelson > > Thanks for the review. I applied this to master. Numan > On 8/7/19 11:06 AM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > The patch removs the --ovn opt

Re: [ovs-dev] [PATCH v3 3/4 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-08 Thread Numan Siddique
On Fri, Aug 2, 2019 at 5:24 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that

Re: [ovs-dev] [PATCH v5 ovn] ovn-northd: Add the option to pause and resume

2019-07-31 Thread Numan Siddique
On Wed, Jul 31, 2019 at 8:35 PM Dumitru Ceara wrote: > On Wed, Jul 31, 2019 at 4:56 PM wrote: > > > > From: Numan Siddique > > > > This patch adds 3 unixctl socket comments - pause, resume and is-paused. > > > > Usage: ovs-appctl -t ovn-northd paus

Re: [ovs-dev] [PATCH ovn] Include common ovn header files from include/ovn instead of ovs/include/ovn

2019-07-29 Thread Numan Siddique
On Mon, Jul 29, 2019 at 4:00 PM Dumitru Ceara wrote: > On Mon, Jul 29, 2019 at 12:02 PM wrote: > > > > From: Numan Siddique > > > > For the other header files present in lib/, the previous commit [1] > > changed the path. But few were left out. This

Re: [ovs-dev] [[ovn]] OVN split: Fix modules_install

2019-07-29 Thread Numan Siddique
On Mon, Jul 29, 2019 at 2:30 PM wrote: > From: Lucas Alvares Gomes > > The Makefile for modules_install should point to the ovs subrepository > to be able to compile the ovs kernel modules (otherwise the compilation > fails). > > Signed-off-by: Lucas Alvares Gomes > I think it is better to

Re: [ovs-dev] [PATCH ovn] Include ovn header files from lib/ instead of ovn/lib/

2019-07-27 Thread Numan Siddique
On Fri, Jul 26, 2019 at 11:44 PM Mark Michelson wrote: > Acked-by: Mark Michelson > Thanks. I applied this to master. Numan > > On 7/26/19 1:57 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > If we don't change this, we will be inclu

Re: [ovs-dev] [PATCH v3 ovn] Include common ovn header files from include/ovn instead of ovs/include/ovn

2019-07-29 Thread Numan Siddique
On Mon, Jul 29, 2019 at 5:23 PM Dumitru Ceara wrote: > On Mon, Jul 29, 2019 at 1:02 PM wrote: > > > > From: Numan Siddique > > > > For the other header files present in lib/, the previous commit [1] > > changed the path. But few were left out. This patch fix

<    1   2   3   4   5   6   7   8   9   10   >