Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Fix IGMP_Group port extraction.

2020-02-28 Thread Numan Siddique
On Fri, Feb 28, 2020 at 2:08 AM Mark Michelson wrote: > > Acked-by: Mark Michelson Thanks Dumitru and Mark. I applied this patch to master and branch-20.03 Thanks Numan > > On 2/27/20 10:54 AM, Dumitru Ceara wrote: > > It can happen that all ports on which IGMP/MLD join reports were > >

Re: [ovs-dev] [PATCH] Broadcast DHCPREPLY when BROADCAST flag is set

2020-03-06 Thread Numan Siddique
On Fri, Mar 6, 2020 at 7:14 AM Ihar Hrachyshka wrote: > > As per RFC2131, section 4.1: >A server or relay agent sending or relaying a DHCP message directly >to a DHCP client (i.e., not to a relay agent specified in the >'giaddr' field) SHOULD examine the BROADCAST bit in the 'flags' >

Re: [ovs-dev] [PATCH ovn] Improve documentation of gateways.

2020-03-06 Thread Numan Siddique
On Fri, Mar 6, 2020 at 1:07 AM Ben Pfaff wrote: > > I found the documentation for gateways, especially HA gateways, to > be unclear and insufficient. This commit improves it. > > CC: Numan Siddique > CC: Gurucharan Shetty > Signed-off-by: Ben Pfaff Thanks for improv

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix documentation and comments for bridged redirection.

2020-02-25 Thread Numan Siddique
C: Ankur Sharma > Fixes: 37cd27b8a85e ("OVN: Vlan backed DVR N-S, redirect-type option") > Fixes: 8ba15c3d1084 ("OVN: Vlan backed DVR N-S, avoid get_arp on non redirect > chassis.") > Fixes: 03493b33c073 ("OVN: Vlan backed DVR N-S, redirect packet via localnet &g

Re: [ovs-dev] [PATCH ovn] pinctrl: Fix buffer overread in pinctrl_compose_ipv6().

2020-02-25 Thread Numan Siddique
he > > time with Address Sanitizer without this fix, so I guess I'm the only > > one who uses it routinely). > > I'll try to run it regularly from now on. Me too. > > > > > CC: Dumitru Ceara > > Fixes: 677a3ba4d66b ("ovn: Add MLD support.&

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix use of uninitialized variables.

2020-02-24 Thread Numan Siddique
On Saturday, February 22, 2020, Mark Michelson wrote: > Looks good to me > > Acked-by: Mark Michelson I applied this patch to master and branch-20.03 Thanks Numan > > On 2/21/20 6:59 AM, Dumitru Ceara wrote: > >> Calls to ip_address_and_port_from_lb_key() could fail parsing the 'key' >>

Re: [ovs-dev] [PATCH ovn] controller: grant cap_net_admin to ovn-controller

2020-02-27 Thread Numan Siddique
Ying Xu > Signed-off-by: Lorenzo Bianconi Acked-by: Numan Siddique Thanks Numan > --- > controller/ovn-controller.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c > index cacaaa578..

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix documentation and comments for bridged redirection.

2020-02-27 Thread Numan Siddique
On Tue, Feb 25, 2020 at 3:03 PM Numan Siddique wrote: > > On Tue, Feb 25, 2020 at 5:09 AM Ben Pfaff wrote: > > > > The series that introduced redirect-type first used "vlan" as the > > name for the feature, then changed to "bridged" without updatin

Re: [ovs-dev] [PATCH ovn] pinctrl: Fix buffer overread in pinctrl_compose_ipv6().

2020-02-27 Thread Numan Siddique
On Tue, Feb 25, 2020 at 3:02 PM Numan Siddique wrote: > > On Tue, Feb 25, 2020 at 2:43 PM Dumitru Ceara wrote: > > > > On 2/25/20 12:39 AM, Ben Pfaff wrote: > > > The call to packet_set_ipv6() calls into packet_rh_present(), which in > > > turn itera

Re: [ovs-dev] [PATCH 3/3] ovn-controller.c: Support option "ovn-monitor-all".

2020-01-24 Thread Numan Siddique
On Tue, Jan 14, 2020 at 4:22 AM Han Zhou wrote: > > Set this option to true will avoid using conditional monitoring in > ovn-controller. Setting it to true helps in environments where > all (or most) workloads need to be reachable from each other, thus > the effectiveness of conditional

Re: [ovs-dev] [PATCH ovn 1/2] Refactor lflow functions to take one context argument - lflow_ctx.

2020-01-24 Thread Numan Siddique
On Sat, Jan 11, 2020 at 11:02 PM Han Zhou wrote: > > On Fri, Jan 10, 2020 at 11:26 AM wrote: > > > > From: Numan Siddique > > > > Presently most of the lflow_*() functions called from ovn-controller.c > > takes lots of arguments. This patch adds 'struct lflow

Re: [ovs-dev] [PATCH repost 2/2] ofproto: Do not delete datapath flows on exit by default.

2020-01-23 Thread Numan Siddique
is being stopped as part of an upgrade. This commit changes OVS so > that it only removes datapath flows when requested, via "ovs-appctl > exit --cleanup". > > I've only tested this in the OVS sandbox. > > Signed-off-by: Ben Pfaff Acked-by: Numan Siddique Tested with

Re: [ovs-dev] [PATCH repost 1/2] ofproto-dpif-upcall: Get rid of udpif_synchronize().

2020-01-23 Thread Numan Siddique
late_txn_commit(). > So we can get rid of udpif_synchronize() entirely, which this patch > does. > > As a side effect, this eliminates one reason why terminating OVS cleanly > clears the datapath flow table. An upcoming patch will eliminate > other reasons. > > Signed

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Consider load balancer active backends in router pipeline

2020-01-29 Thread Numan Siddique
On Wed, Jan 29, 2020 at 7:05 PM Dumitru Ceara wrote: > > On 1/27/20 2:06 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > The commit [1] which added lood balancer health check support > > missed out on updating the logical flows to consider only >

Re: [ovs-dev] [PATCH v3 ovn 0/2] Add MLD support.

2020-01-29 Thread Numan Siddique
On Wed, Jan 29, 2020 at 2:59 PM Dumitru Ceara wrote: > > The first patch of the series is a minor fix of how IP multicast traffic > is matched. > > The second patch extends the already existing IPv4 Multicast support > (IGMP snooping, IGMP querier, relay and static flood config) to IPv6 > by

Re: [ovs-dev] [PATCH ovn v3 00/13] OVN Interconnection

2020-01-29 Thread Numan Siddique
On Tue, Jan 28, 2020 at 8:26 AM Han Zhou wrote: > > The series supports interconnecting multiple OVN deployments (e.g. located at > multiple data centers) through logical routers connected with tansit logical > switches with overlay tunnels, managed through OVN control plane. See the >

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix uninitialized 'prefix' in 'ip46_parse_cidr'.

2020-01-27 Thread Numan Siddique
On Tue, Jan 28, 2020 at 7:55 AM Han Zhou wrote: > > On Mon, Jan 27, 2020 at 6:32 AM Dumitru Ceara wrote: > > > > On 1/27/20 3:07 PM, Numan Siddique wrote: > > > On Mon, Jan 27, 2020 at 6:35 PM Dumitru Ceara wrote: > > >> > > >> The partiall

Re: [ovs-dev] [PATCH ovn] ovn-northd: Address scale issues with DNAT flows.

2020-02-04 Thread Numan Siddique
g -c > > 7 > > > > And I verified that FIP to FIP traffic works via the localnet port so it > > is really distributed and does not traverse any tunnels. > > > > Thanks! > > Daniel > > > > Tested-By: Daniel Alvarez Sanchez > > Acked-By: Daniel A

Re: [ovs-dev] [PATCH ovn v4 00/13] OVN Interconnection

2020-01-30 Thread Numan Siddique
nterconnection gateway controller. > ovn-ic: Interconnection port controller. > ovn.at: e2e test for OVN interconnection. > ovn-ctl: Refactor to reduce redundant code. > ovn-ctl: Support commands for interconnection. > tutorial: Add tutorial for OVN Interconnection. T

Re: [ovs-dev] [PATCH ovn v3] ovn-northd: Support hairpinning for logical switch load balancing.

2020-01-31 Thread Numan Siddique
On Thu, Jan 30, 2020 at 8:08 PM Dumitru Ceara wrote: > > In case a VIF is trying to connect to a load balancer VIP that includes in > its backends the VIF itself, traffic would get DNAT-ed, ct_lb(VIP), but > when it reaches the VIF, the VIF will try to reply locally as the source IP > is known to

Re: [ovs-dev] [PATCH] AUTHORS: Add Manoj Sharma

2020-01-31 Thread Numan Siddique
On Fri, Jan 31, 2020 at 2:08 PM Dumitru Ceara wrote: > > On 1/31/20 7:35 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > Signed-off-by: Numan Siddique > > --- > > AUTHORS.rst | 1 + > > 1 file changed, 1 insertion(+) > > > > diff

Re: [ovs-dev] [PATCH ovn v1] vagrant: Increase memory sizes

2020-01-30 Thread Numan Siddique
On Fri, Jan 31, 2020 at 7:56 AM Flavio Fernandes wrote: > > Using default memory sizes is not enough to run some of the tests > invoked by make check. Being so, This change bumps the default > memory size of boxes on Virtualbox and Libvirt providers > to 1Gb and 4 CPUs. This value can be changed

Re: [ovs-dev] [PATCH ovn] rhel: Fix make rpm-fedora

2020-01-31 Thread Numan Siddique
On Fri, Jan 31, 2020 at 6:29 PM Dumitru Ceara wrote: > > On 1/31/20 12:01 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > Recent patches which added Interconnection feature broke "make rpm-fedora". > > This patch fixes it. > > > >

Re: [ovs-dev] [PATCH 3/3] ovn-controller.c: Support option "ovn-monitor-all".

2020-01-24 Thread Numan Siddique
On Fri, Jan 24, 2020, 21:38 Han Zhou wrote: > On Fri, Jan 24, 2020 at 1:24 AM Numan Siddique wrote: > > > > On Tue, Jan 14, 2020 at 4:22 AM Han Zhou wrote: > > > > > > Set this option to true will avoid using conditional monitoring in > > >

Re: [ovs-dev] [PATCH v4 ovn 0/2] Forwarding group to load balance l2 traffic with liveness detection

2020-01-23 Thread Numan Siddique
On Thu, Jan 23, 2020 at 3:01 AM Manoj Sharma wrote: > > *** BLURB HERE *** > > Manoj Sharma (2): > Re-apply the v3 to resolve the failure reported by 0-day robot. > A forwarding group is an aggregation of logical switch ports of a > logical switch to load balance traffic across the ports.

Re: [ovs-dev] [PATCH ovn 2/4] ovn-controller: Remove ports from struct local_datapaths.

2020-01-28 Thread Numan Siddique
On Tue, Jan 28, 2020 at 7:42 PM Numan Siddique wrote: > > On Tue, Jan 28, 2020 at 12:51 PM Han Zhou wrote: > > > > On Fri, Jan 24, 2020 at 3:03 AM wrote: > > > > > > From: Numan Siddique > > > > > > struct local_datapaths s

Re: [ovs-dev] [PATCH ovn 3/4] Refactor lflow functions to take two context argument - lflow_ctx_in and lflow_ctx_out.

2020-01-28 Thread Numan Siddique
On Tue, Jan 28, 2020 at 1:11 PM Han Zhou wrote: > > On Fri, Jan 24, 2020 at 3:04 AM wrote: > > > > From: Numan Siddique > > > > Presently most of the lflow_*() functions called from ovn-controller.c > > takes lots of arguments. This patch adds 'struct lflow_c

Re: [ovs-dev] [PATCH ovn 2/4] ovn-controller: Remove ports from struct local_datapaths.

2020-01-28 Thread Numan Siddique
On Tue, Jan 28, 2020 at 12:51 PM Han Zhou wrote: > > On Fri, Jan 24, 2020 at 3:03 AM wrote: > > > > From: Numan Siddique > > > > struct local_datapaths stores the array of port bindings for each > datapath. > > These ports are used only in the pinctrl m

Re: [ovs-dev] [PATCH ovn 2/4] ovn-controller: Remove ports from struct local_datapaths.

2020-01-28 Thread Numan Siddique
On Tue, Jan 28, 2020 at 11:25 PM Han Zhou wrote: > > On Tue, Jan 28, 2020 at 6:14 AM Numan Siddique wrote: > > > > On Tue, Jan 28, 2020 at 7:42 PM Numan Siddique wrote: > > > > > > On Tue, Jan 28, 2020 at 12:51 PM Han Zhou wrote: > > > >

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix uninitialized 'prefix' in 'ip46_parse_cidr'.

2020-01-27 Thread Numan Siddique
On Mon, Jan 27, 2020 at 6:35 PM Dumitru Ceara wrote: > > The partially initialized 'prefix' was later used for computing route > hashes (route_hash()) causing the ECMP routes to be incorrectly > installed. To fix the issue we now zero out the prefix before parsing > it. > > CC: Han Zhou > Fixes:

Re: [ovs-dev] [PATCH 1/2] Prepare for 20.03.0

2020-02-05 Thread Numan Siddique
On Wed, Feb 5, 2020 at 1:49 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique > --- > NEWS | 2 +- > configure.ac | 2 +- > debian/changelog | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff

Re: [ovs-dev] [PATCH 2/2] Prepare for post-20.03.0 (20.03.90).

2020-02-05 Thread Numan Siddique
On Wed, Feb 5, 2020 at 1:49 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 6 +- > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 12 insertions(+), 2 deletions(-) &g

Re: [ovs-dev] [PATCH ovn] ovn-northd: Set stage-hint for Forwarding_Group, ECMP and SNAT

2020-02-05 Thread Numan Siddique
On Wed, Feb 5, 2020 at 2:32 PM Dumitru Ceara wrote: > > Commit 217cc5e9a0bc ("ovn-northd: Set stage-hint for all applicable > flows.") added ovn_lflow_add_with_hint() which sets the stage hint in > the logical flow records for most Northbound DB entities. However a few > cases were missed: > -

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Set stage-hint for all applicable flows.

2020-02-04 Thread Numan Siddique
On Tue, Feb 4, 2020 at 3:32 AM Mark Michelson wrote: > > Acked-by: Mark Michelson Thanks. I applied this patch to master. Numan > > On 1/31/20 6:38 AM, Dumitru Ceara wrote: > > Until now the 'stage-hint' external-id was set only for logical flows > > installed for ACLs. In order to simplify

Re: [ovs-dev] [PATCH ovn] NEWS: Add the news for ECMP support.

2020-01-30 Thread Numan Siddique
On Thu, Jan 30, 2020 at 7:42 AM Han Zhou wrote: > > Signed-off-by: Han Zhou Since it was a small patch, I applied this myself. Thanks Numan > --- > NEWS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/NEWS b/NEWS > index 2b8cd6f..d4f5dee 100644 > --- a/NEWS > +++ b/NEWS > @@ -6,6

Re: [ovs-dev] [PATCH ovn v1] ovn-openstack.rst: Account for networking-ovn-migration

2020-01-30 Thread Numan Siddique
On Thu, Jan 30, 2020 at 4:44 AM Flavio Fernandes wrote: > > The networking-ovn repo has been migrated into Neutron [0] > as of Ussuri release. This change implements the necessary > updates to the OVN OpenStack tutorial. > > Other minor changes here include commands needed to make > Devstack work

Re: [ovs-dev] [PATCH ovn 1/2] Fix incorrect version display

2020-02-17 Thread Numan Siddique
On Mon, Feb 17, 2020 at 8:30 PM Dumitru Ceara wrote: > > On 2/17/20 1:39 PM, Dumitru Ceara wrote: > > On 2/14/20 7:49 PM, num...@ovn.org wrote: > >> From: Numan Siddique > >> > >> Running any ovn binary with --version displays wrong version > >> in

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Provide the option to configure inactive probe from standby to active.

2020-02-17 Thread Numan Siddique
On Tue, Feb 18, 2020 at 7:14 AM Han Zhou wrote: > > On Sun, Feb 16, 2020 at 9:54 PM wrote: > > > > From: Numan Siddique > > > > Recently ovsdb-server supported an unixctl command - > > ovsdb-server/set-active-ovsdb-server-probe-interval to configure inacti

Re: [ovs-dev] [PATCH ovn] ovn-nbctl.8.xml: Daemon mode document minor fix.

2020-02-17 Thread Numan Siddique
On Tue, Feb 18, 2020 at 10:32 AM Han Zhou wrote: > > Signed-off-by: Han Zhou Acked-by: Numan Siddique Thanks Numan > --- > utilities/ovn-nbctl.8.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/utilities/ovn-nbctl.8.xml b/utilities/ovn-nbctl.

Re: [ovs-dev] [PATCH ovn] ovn-controller: Don't clear the lflow resources ref during flow_output_run

2020-02-18 Thread Numan Siddique
On Tue, Feb 18, 2020 at 11:50 PM Han Zhou wrote: > > On Tue, Feb 18, 2020 at 9:27 AM Numan Siddique wrote: > > > On Tue, Feb 18, 2020 at 10:34 PM Han Zhou wrote: > > > > > > On Tue, Feb 18, 2020 at 7:32 AM wrote: > > > > > > > > From: N

Re: [ovs-dev] [PATCH v2 ovn] Save the addr set and port groups in lflow expr cache

2020-02-18 Thread Numan Siddique
On Wed, Feb 19, 2020, 3:01 AM Mark Michelson wrote: > Hi, Numan. Would it be possible to add a test case that exercises the fix? > Hi Mark, The modified test case in this patch fails without the fix. Numan > On 2/18/20 2:53 PM, num...@ovn.org wrote: > > From: Numan Siddique

Re: [ovs-dev] [PATCH ovn] pinctrl: fix IP buffering with connection-tracking

2020-02-19 Thread Numan Siddique
address > >>> resolution we need to preserve ovs ofport in order to let ovs > >>> connection tracking to properly SNAT/DNAT the packet. > >>> Do not overwrite the MFF_IN_PORT in consider_port_binding routine > >>> > >>> Signed-off-by: Nu

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Check for NULL before accessing ovsrec_open_vswitch row.

2020-02-20 Thread Numan Siddique
On Thu, Feb 20, 2020 at 8:25 PM Dumitru Ceara wrote: > > On 2/20/20 3:43 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > There are occasional crashes seen with OpenShift CI > > > > > > gdb) bt > > 0 hmap_first_with_hash (hmap=0x1

Re: [ovs-dev] [PATCH ovn v1] northd: Allow /64 after ipv6_prefix

2020-02-20 Thread Numan Siddique
ovn-northd to take the ipv6_prefix either with or > without a trailing "/64". It still enforces a /64 CIDR prefix length. > > A test case was updated to ensure that a prefix with "/64" is now > accepted. > > Signed-off-by: Russell Bryant With the below check patch warni

Re: [ovs-dev] OVN 20.03.0 Release: Final call for patches

2020-02-21 Thread Numan Siddique
On Fri, Feb 21, 2020 at 1:50 PM Dumitru Ceara wrote: > > On 2/21/20 1:06 AM, Han Zhou wrote: > > On Thu, Feb 20, 2020 at 11:54 AM Mark Michelson wrote: > >> > >> Hi everyone, > >> > >> We've had the OVN 20.03 branch created for a couple of weeks now, and > >> we've seen some important issues

Re: [ovs-dev] [PATCH ovn v1] northd: Allow /64 after ipv6_prefix

2020-02-21 Thread Numan Siddique
On Fri, Feb 21, 2020 at 1:03 AM Russell Bryant wrote: > > On Thu, Feb 20, 2020 at 10:46 AM Numan Siddique wrote: > > > On Wed, Feb 19, 2020 at 9:27 PM Russell Bryant wrote: > > > > > > We recently hit a bug in ovn-kubernetes, where I accidentally added &g

Re: [ovs-dev] [PATCH ovn] Makefile.am: Fix dist-hook-git target.

2020-02-09 Thread Numan Siddique
On Sun, Feb 9, 2020 at 5:03 AM Ben Pfaff wrote: > > This was broken and always printed an error. > > Signed-off-by: Ben Pfaff Acked-by: Numan Siddique Numan > --- > Makefile.am | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Makefi

Re: [ovs-dev] [PATCH ovn 2/2] ovn-ic: Route advertisement.

2020-02-14 Thread Numan Siddique
On Sat, Feb 15, 2020, 2:36 AM Mark Michelson wrote: > On 2/14/20 2:58 PM, Han Zhou wrote: > > > > > > On Fri, Feb 14, 2020 at 3:08 AM Numan Siddique > <mailto:num...@ovn.org>> wrote: > > > > > > On Mon, Feb 10, 2020 at

Re: [ovs-dev] [PATCH ovn 1/2] ovn-northd.c: Move struct v46_ip and related functions to utils.

2020-02-14 Thread Numan Siddique
On Mon, Feb 10, 2020 at 12:31 PM Han Zhou wrote: > > The struct and functions will be reused by other modules. > > Signed-off-by: Han Zhou Acked-by: Numan Siddique Thanks Numan > --- > lib/ovn-util.c | 28 > lib/ovn-util.h | 12 +

Re: [ovs-dev] [PATCH ovn 2/2] ovn-ic: Route advertisement.

2020-02-14 Thread Numan Siddique
ot; to "ir-route-adv" and also all occurrences of "route-ad" in the code to "route-adv". There's one comment below. With these comments addressed - Acked-by: Numan Siddique Thanks Numan > options:ic-route-learn=true > &g

Re: [ovs-dev] [PATCH v2 ovn] Save the addr set and port groups in lflow expr cache

2020-02-19 Thread Numan Siddique
On Wed, Feb 19, 2020 at 1:10 PM Han Zhou wrote: > > On Tue, Feb 18, 2020 at 11:54 AM wrote: > > > > From: Numan Siddique > > > > After the patch [1], which added caching of lflow expr, the > lflow_resource_ref > > is not rebuilt properly when lflow

Re: [ovs-dev] [PATCH ovn] ovn-controller: Don't clear the lflow resources ref during flow_output_run

2020-02-19 Thread Numan Siddique
On Wed, Feb 19, 2020 at 1:16 PM Han Zhou wrote: > > On Tue, Feb 18, 2020 at 11:56 AM Numan Siddique wrote: > > > > On Tue, Feb 18, 2020 at 11:50 PM Han Zhou wrote: > > > > > > On Tue, Feb 18, 2020 at 9:27 AM Numan Siddique wrote: > > > > > &

Re: [ovs-dev] [PATCH ovn] ovn-controller: Don't clear the lflow resources ref during flow_output_run

2020-02-18 Thread Numan Siddique
On Tue, Feb 18, 2020 at 10:34 PM Han Zhou wrote: > > On Tue, Feb 18, 2020 at 7:32 AM wrote: > > > > From: Numan Siddique > > > > After the patch [1], which added caching of lflow expr, the > lflow_resource_ref > > is not rebuilt properly when lflow

Re: [ovs-dev] [PATCH v1 ovn 0/1] Forwarding group to load balance l2 traffic with liveness detection

2020-01-08 Thread Numan Siddique
On Tue, Jan 7, 2020 at 3:55 AM Manoj Sharma wrote: > > A forwarding group is an aggregation of logical switch ports of a > logical switch to load balance traffic across the ports. It also > detects the liveness if the logical switch ports are realized as > OVN tunnel ports on the physical

Re: [ovs-dev] [PATCH ovn] OVN container scripts: Support for cluster mode

2020-01-08 Thread Numan Siddique
On Wed, Jan 8, 2020 at 7:02 AM wrote: > > From: Aliasgar Ginwala > > 1. Container scripts for starting ovn central node >containers in HA using cluster mode > 2. Update documentation about the same. > > Signed-off-by: Aliasgar Ginwala Thanks. I applied this patch to master. I didn't test

Re: [ovs-dev] [PATCH ovn] Restrict ARP replies for LB VIP only on chassis redirect port

2020-01-09 Thread Numan Siddique
On Thu, Jan 9, 2020 at 4:11 PM Dumitru Ceara wrote: > > On Thu, Jan 9, 2020 at 11:32 AM wrote: > > > > From: Numan Siddique > > > > Presently when ARP request for the load balance VIP is received > > from the provider network, all the ovn-controllers' reply t

Re: [ovs-dev] [PATCH ovn v2] Restrict ARP/IPv6 ND replies for LB VIP only on chassis redirect port

2020-01-09 Thread Numan Siddique
On Thu, Jan 9, 2020 at 7:35 PM Dumitru Ceara wrote: > > On Thu, Jan 9, 2020 at 1:18 PM wrote: > > > > From: Numan Siddique > > > > Presently when ARP/ND request for the load balance VIP is received > > from the provider network, all the ovn-controllers' r

Re: [ovs-dev] [PATCH v6 ovn 1/2] controller: add ipv6 prefix delegation state machine

2020-01-16 Thread Numan Siddique
" On Tue, Jan 14, 2020 at 4:37 PM Lorenzo Bianconi wrote: > > Introduce IPv6 Prefix delegation state machine according to RFC 3633 > https://tools.ietf.org/html/rfc3633. > Add handle_dhcpv6_reply controller action to parse advertise/reply from > IPv6 delegation server. Advertise/reply are parsed

Re: [ovs-dev] [PATCH v6 ovn 2/2] northd: add logical flows for dhcpv6 pfd parsing

2020-01-16 Thread Numan Siddique
On Tue, Jan 14, 2020 at 4:38 PM Lorenzo Bianconi wrote: > > Introduce logical flows in ovn router pipeline in order to parse dhcpv6 > advertise/reply from IPv6 prefix delegation router. > Do not overwrite ipv6_ra_pd_list info in options column of SB port_binding > table written by ovn-controller

Re: [ovs-dev] [PATCH ovn 0/2] Caching logical flow expr tree for each lflow

2020-01-16 Thread Numan Siddique
s() function. Thanks Numan > > On 1/9/20 12:36 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > This patch series tries to improve the time taken to proceess logical > > flows by caching the expr tree. For large scale deployments with lots > > of logical

Re: [ovs-dev] [PATCH v2 ovn 2/3] Forwarding group to load balance l2 traffic with liveness detection

2020-01-16 Thread Numan Siddique
On Sat, Jan 11, 2020 at 6:11 AM Manoj Sharma wrote: > Add forwarding group support for a logical switch. It will add a new OVN > action "fwd_group" with a virtual IP and virtual MAC. Any number of logical > switch ports of this switch can be added to this forwarding group. > If traffic has to be

Re: [ovs-dev] [PATCH v6 ovn 2/2] northd: add logical flows for dhcpv6 pfd parsing

2020-01-16 Thread Numan Siddique
On Thu, Jan 16, 2020 at 7:40 PM Numan Siddique wrote: > > On Tue, Jan 14, 2020 at 4:38 PM Lorenzo Bianconi > wrote: > > > > Introduce logical flows in ovn router pipeline in order to parse dhcpv6 > > advertise/reply from IPv6 prefix delegation router. > > Do n

Re: [ovs-dev] [PATCH v2 ovn 1/3] Forwarding group to load balance l2 traffic with liveness detection

2020-01-16 Thread Numan Siddique
On Sat, Jan 11, 2020 at 6:11 AM Manoj Sharma wrote: > Add a forwarding group table and a reference to the logical switch it is > configured on. The forwarding group is configured with a virtual IP, > virtual > MAC and a number of logical switch ports from a logical switch. > > Signed-off-by:

Re: [ovs-dev] [PATCH v2 ovn 0/3] Forwarding group to load balance l2 traffic with liveness detection

2020-01-16 Thread Numan Siddique
On Sat, Jan 11, 2020 at 6:11 AM Manoj Sharma wrote: > A forwarding group is an aggregation of logical switch ports of a > logical switch to load balance traffic across the ports. It also detects > the liveness if the logical switch ports are realized as OVN tunnel ports > on the physical

Re: [ovs-dev] [PATCH ovn 1/2] ovn-northd: Fix Pre-LB logical flows with IPv4 and IPv6.

2020-01-20 Thread Numan Siddique
On Thu, Jan 16, 2020 at 9:07 PM Dumitru Ceara wrote: > > When both IPv4 and IPv6 load balancers were configured, the logical flows > that send packets that need to be load balanced to conntrack (for > defragmentation) were incorrectly trying to match on IPv6 fields. > > Fix this issue by using

Re: [ovs-dev] [PATCH ovn v2 1/4] ovn-controller: A new action "select".

2020-01-22 Thread Numan Siddique
t to specified field, e.g.: > reg0 = select(1, 2, 3) > A weight can be specified for each member as well, e.g.: > reg0 = select(1=20, 2=30, 3=50) > > Signed-off-by: Han Zhou Hi Han, Thanks for v2. I have one comment. Please see below. With that addressed - Acked-by: Numan Siddiq

Re: [ovs-dev] OVN Soft Freeze

2020-01-22 Thread Numan Siddique
On Tue, Jan 21, 2020 at 5:50 PM Dumitru Ceara wrote: > > On Tue, Jan 21, 2020 at 12:09 PM Mark Michelson wrote: > > > > Hi all, > > > > OVN has entered its "soft freeze" state. That means that any new > > features that should be added prior to the next release need to have > > reviews posted

Re: [ovs-dev] [PATCH ovn v2 1/4] ovn-controller: A new action "select".

2020-01-22 Thread Numan Siddique
On Wed, Jan 22, 2020 at 9:46 PM Han Zhou wrote: > > On Wed, Jan 22, 2020 at 1:17 AM Numan Siddique wrote: > > > > On Tue, Jan 21, 2020 at 4:27 AM Han Zhou wrote: > > > > > > Support a new logical flow action "select", which can be used to > >

Re: [ovs-dev] [PATCH 2/3] ovn-controller.c: Move the position of handling OVN-SB related settings.

2020-01-17 Thread Numan Siddique
ters. The > > patch doesn't skip anything. > > > >> On 1/13/20 5:52 PM, Han Zhou wrote: > >>> Move the logic of handling OVN-SB related setting in external-ids > >>> after the ovs_idl_loop run, so that any change in the external-ids > >>> setting

Re: [ovs-dev] [PATCH] Typo fix: vswtich -> vswitch.

2020-01-17 Thread Numan Siddique
On Fri, Jan 17, 2020 at 5:52 AM Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Numan Siddique Numan > --- > NEWS | 2 +- > tests/ofproto-dpif.at | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/N

Re: [ovs-dev] [PATCH ovn 1/4] ovn-controller: A new action "select".

2020-01-17 Thread Numan Siddique
On Tue, Jan 7, 2020 at 8:00 AM Han Zhou wrote: > > Support a new logical flow action "select", which can be used to > implement features such as ECMP. The action uses OpenFlow group > action to select an integer (uint16_t) from a list of integers, > and assign it to specified field, e.g.: >

Re: [ovs-dev] [PATCH 1/3] ovn-controller.c: Fix possible NULL pointer dereference.

2020-01-17 Thread Numan Siddique
, Han Zhou wrote: > > > In function update_sb_db(), it tries to access cfg->external_ids > > > outside of the "if (cfg)" block. This patch fixes it. > > > > > > Signed-off-by: Han Zhou Acked-by: Numan Siddique Numan > > > --- > > >

Re: [ovs-dev] [PATCH] Fix links to ovs-advanced tutorial

2020-01-17 Thread Numan Siddique
On Fri, Jan 17, 2020 at 7:50 PM wrote: > > From: Lars Kellogg-Stedman > > This fixes the broken link in the README to the ovs-advanced tutorial. > This also adds a hyperlink to Documentation/tutorials/ovn-sandbox.rst > where the tutorial is referenced. > > Closes #7 Thanks for the PR Lars. I

Re: [ovs-dev] [PATCH v2 ovn 2/3] Forwarding group to load balance l2 traffic with liveness detection

2020-01-20 Thread Numan Siddique
On Mon, Jan 20, 2020 at 8:16 PM Manoj Sharma wrote: > > Hi Numan, > > Please see my answers inline. > > From: Numan Siddique > Date: Thursday, January 16, 2020 at 7:53 AM > To: Manoj Sharma > Cc: "ovs-dev@openvswitch.org" > Subject: Re: [ovs-dev] [PA

Re: [ovs-dev] [PATCH ovn 2/2] ovn-northd: Support hairpinning for logical switch load balancing.

2020-01-20 Thread Numan Siddique
On Thu, Jan 16, 2020 at 9:08 PM Dumitru Ceara wrote: > > In case a VIF is trying to connect to a load balancer VIP that includes in > its backends the VIF itself, traffic would get DNAT-ed, ct_lb(VIP), but > when it reaches the VIF, the VIF will try to reply locally as the source IP > is known to

Re: [ovs-dev] [PATCH ovn 1/4] ovn-controller: A new action "select".

2020-01-20 Thread Numan Siddique
On Sat, Jan 18, 2020 at 3:28 AM Han Zhou wrote: > > On Fri, Jan 17, 2020 at 4:38 AM Numan Siddique wrote: > > > > On Tue, Jan 7, 2020 at 8:00 AM Han Zhou wrote: > > > > > > Support a new logical flow action "select", which can be used to > >

Re: [ovs-dev] [PATCH ovn 2/2] ovn-controller: Cache logical flow expr tree for each lflow.

2020-01-21 Thread Numan Siddique
On Tue, Jan 21, 2020 at 2:03 PM Han Zhou wrote: > > On Thu, Jan 9, 2020 at 9:37 AM wrote: > > > > From: Numan Siddique > > > > This patch caches the logical flow expr tree for each logical flow. This > > cache is stored as an hashmap in the output_flow en

Re: [ovs-dev] [PATCH ovn] Fix the travis CI compilation error seen for osx job

2020-01-10 Thread Numan Siddique
On Fri, Jan 10, 2020 at 6:44 PM Lorenzo Bianconi wrote: > > On Fri, Jan 10, 2020 at 1:25 PM wrote: > > > > From: Numan Siddique > > > > After the commit [1], travis CI job for osx [2] is failing with the below > > error: > > > > * > > In

Re: [ovs-dev] [PATCH v1 ovn 0/1] Forwarding group to load balance l2 traffic with liveness detection

2020-01-13 Thread Numan Siddique
On Sat, Jan 11, 2020 at 6:31 AM Manoj Sharma wrote: > > Thank you for the review Numan. > > On 1/8/20, 11:14 PM, "Numan Siddique" wrote: > > Hi Manoj, > > Thanks for the patch. I didn't look into the complete patch. I have > initial few comment

[ovs-dev] Question on ovsdb_idl_omit_alert()

2020-01-02 Thread Numan Siddique
Hi Ben, ovn-controller.c has the below code here [1] ovsdb_idl_omit_alert(ovnsb_idl_loop.idl, _chassis_col_nb_cfg); >From what I understand from this comment [2], when ovn-controller updates this column, SB ovsdb-server shouldn't send the update2/update3 message back to the ovn-controller and

Re: [ovs-dev] [PATCH ovn] ovn-controller: Don't monitor connection table columns

2020-01-02 Thread Numan Siddique
On Thu, Jan 2, 2020 at 9:22 PM Dumitru Ceara wrote: > > On Tue, Dec 24, 2019 at 1:53 PM wrote: > > > > From: Numan Siddique > > > > ovn-controller doesn't need to know any changes to the connection > > table row. This patch omits alerts for the Connection t

Re: [ovs-dev] Question on ovsdb_idl_omit_alert()

2020-01-02 Thread Numan Siddique
On Fri, Jan 3, 2020 at 1:00 AM Ben Pfaff wrote: > > On Fri, Jan 03, 2020 at 12:45:06AM +0530, Numan Siddique wrote: > > Hi Ben, > > > > ovn-controller.c has the below code here [1] > > > > ovsdb_idl_omit_alert(ovnsb_idl_loop.idl, _chassis_col_nb_cfg);

Re: [ovs-dev] [PATCH v4 ovn 0/2] Add IPv6 Prefix delegation (RFC3633)

2019-12-23 Thread Numan Siddique
On Fri, Dec 20, 2019 at 5:02 PM Lorenzo Bianconi wrote: > > Introduce IPv6 Prefix delegation state machine according to RFC 3633 > https://tools.ietf.org/html/rfc3633. > Add handle_dhcpv6_reply controller action to parse advertise/reply from > IPv6 delegation server. > Introduce logical flows in

Re: [ovs-dev] [PATCH ovn 1/2] DNSSL: copy dnssl string in order to avoid truncated value

2020-01-06 Thread Numan Siddique
On Sat, Jan 4, 2020 at 2:32 AM Lorenzo Bianconi wrote: > > ipv6_ra_send can run 2 times in a row before prepare_ipv6_ras updates > the dnss list. Clone the dnss dynamic string before running > packet_put_ra_dnssl_opt in order to avoid sending truncated dnssl list > on the wire. > Moreover move

Re: [ovs-dev] [PATCH v4] ovsdb replication: Provide option to configure probe interval.

2020-01-06 Thread Numan Siddique
On Tue, Jan 7, 2020 at 4:12 AM Ben Pfaff wrote: > > On Fri, Dec 20, 2019 at 06:43:52PM +0530, num...@ovn.org wrote: > > From: Numan Siddique > > > > When ovsdb-server is in backup mode and connects to the active > > ovsdb-server for replication, and if takes

Re: [ovs-dev] [PATCH v6] ovsdb replication: Provide option to configure probe interval.

2020-01-07 Thread Numan Siddique
On Wed, Jan 8, 2020 at 2:02 AM Ben Pfaff wrote: > > On Tue, Jan 07, 2020 at 10:24:48AM +0530, num...@ovn.org wrote: > > From: Numan Siddique > > > > When ovsdb-server is in backup mode and connects to the active > > ovsdb-server for replication, and if takes

Re: [ovs-dev] Question on ovsdb_idl_omit_alert()

2020-01-08 Thread Numan Siddique
On Wed, Jan 8, 2020 at 1:23 PM Han Zhou wrote: > > On Thu, Jan 2, 2020 at 11:51 AM Numan Siddique wrote: > > > > On Fri, Jan 3, 2020 at 1:00 AM Ben Pfaff wrote: > > > > > > On Fri, Jan 03, 2020 at 12:45:06AM +0530, Numan Siddique wrote: > > > &

Re: [ovs-dev] [PATCH v2 ovn 0/2] fix DNSSL and Route Info Option in RA

2020-01-08 Thread Numan Siddique
On Tue, Jan 7, 2020 at 10:20 PM Lorenzo Bianconi wrote: > > Changes since v1: > - rely on xstrdup instead of ds_clone > > Lorenzo Bianconi (2): > DNSSL: copy dnssl string in order to avoid truncated value > RA Route Info Option: copy route info string in order to avoid > truncated value

Re: [ovs-dev] [PATCH ovn 2/2] travis: Obtain testsuite logs from the correct directory.

2020-03-11 Thread Numan Siddique
On Tue, Mar 10, 2020 at 2:43 AM Ihar Hrachyshka wrote: > > These days Automake uses _build/sub for its distcheck builds, not > plain _build. (I don't know whether that is a change from previous > versions.) > > Adopted from https://patchwork.ozlabs.org/patch/1164305/ >

Re: [ovs-dev] [PATCH] travis: Disable sindex build in sparse.

2020-03-12 Thread Numan Siddique
On Thu, Mar 12, 2020 at 4:10 PM Ilya Maximets wrote: > > On 3/12/20 11:13 AM, Numan Siddique wrote: > > On Thu, Mar 12, 2020 at 3:40 PM Ilya Maximets wrote: > >> > >> Sparse introduced a new utility 'sindex' for semantic search, > >> but unfortunately

Re: [ovs-dev] [PATCH ovn] ovn-northd: Add lflows to by pass the svc monitor packets from conntrack.

2020-03-12 Thread Numan Siddique
On Thu, Mar 12, 2020 at 2:43 PM Dumitru Ceara wrote: > > On 3/11/20 7:15 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > The commit [1] added lflows to by pass the service monitor health check > > packets from conntrack. But it missed out adding in the

Re: [ovs-dev] [PATCH ovn] northd: do not insert identical lflows in S_ROUTER_IN_ARP_RESOLVE

2020-03-12 Thread Numan Siddique
On Wed, Mar 11, 2020 at 10:12 PM Lorenzo Bianconi wrote: > > Avoid to configure multiple identical logical flows in > S_ROUTER_IN_ARP_RESOLVE stage. This can happen adding L2 destination > address info about snat since multiple nat entries will use the same > external_ip > > Signed-off-by:

Re: [ovs-dev] [PATCH] travis: Disable sindex build in sparse.

2020-03-12 Thread Numan Siddique
On Thu, Mar 12, 2020 at 3:40 PM Ilya Maximets wrote: > > Sparse introduced a new utility 'sindex' for semantic search, > but unfortunately it fails to build in Travis environment. > Disabling it explicitely as we don't need it anyway. > > Signed-off-by: Ilya Maximets > --- > > Needs to be

Re: [ovs-dev] [PATCH ovn] travis: Disable sindex build in sparse.

2020-03-12 Thread Numan Siddique
On Thu, Mar 12, 2020 at 4:00 PM Ilya Maximets wrote: > > Sparse introduced a new utility 'sindex' for semantic search, > but unfortunately it fails to build in Travis environment. > Disabling it explicitly as we don't need it anyway. > > Signed-off-by: Ilya Maximets Thanks. I applied this patch

Re: [ovs-dev] [PATCH ovn] travis: Disable sindex build in sparse.

2020-03-12 Thread Numan Siddique
On Thu, Mar 12, 2020 at 6:03 PM Ilya Maximets wrote: > > On 3/12/20 11:50 AM, Numan Siddique wrote: > > On Thu, Mar 12, 2020 at 4:00 PM Ilya Maximets wrote: > >> > >> Sparse introduced a new utility 'sindex' for semantic search, > >> but unfortunately

Re: [ovs-dev] [PATCH ovn] travis: Avoid skipping of interconnection tests.

2020-03-12 Thread Numan Siddique
On Wed, Mar 11, 2020 at 9:56 PM Ilya Maximets wrote: > > Following tests has no 'ovn' keyword and always skipped by TravisCI: > > 204: ovn-ic-nbctl.at:25 ovn-ic-nbctl > 205: ovn-ic-sbctl.at:25 ovn-ic-sbctl > 217: ovn-ic.at:2ovn-ic -- AZ register > 218: ovn-ic.at:30 ovn-ic --

Re: [ovs-dev] reside-on-redirect-chassis option

2020-03-12 Thread Numan Siddique
On Thu, Mar 12, 2020 at 3:06 AM Ben Pfaff wrote: > > On Wed, Mar 11, 2020 at 02:29:59PM -0700, Ben Pfaff wrote: > > Hi Numan. I am trying to properly understand the > > reside-on-redirect-chassis option. I think that it has two effects: > > > > 1. Traffic over the router port is always sent to

Re: [ovs-dev] [PATCH OVN] Add external_ids column for tables in nb schema

2020-03-11 Thread Numan Siddique
uthor: Tao YunXiang > Co-authored-by: Liu Chang > Co-authored-by: Rong Yin > Signed-off-by: Tao YunXiang > Signed-off-by: Liu Chang > Signed-off-by: Rong Yin Acked-by: Numan Siddique Numan > --- > ovn-nb.ovsschema | 10 -- > ovn-nb.xml | 12

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Add lflows to by pass the svc monitor packets from conntrack.

2020-03-12 Thread Numan Siddique
applied this patch to master and branch-20.03 Thanks Numan > > Thanks, > Maciej > > On Thu, Mar 12, 2020 at 1:39 PM Dumitru Ceara wrote: > > > On 3/12/20 11:28 AM, num...@ovn.org wrote: > > > From: Numan Siddique > > > > > > The commit [1] added

Re: [ovs-dev] [PATCH v2 ovn] logical-fields: fix memory leak caused by initialize ovnfield_by_name twice

2020-03-10 Thread Numan Siddique
On Sat, Mar 7, 2020 at 4:42 AM Ben Pfaff wrote: > > On Thu, Mar 05, 2020 at 07:21:41AM +0100, Damijan Skvarc wrote: > > ovnfield_by_name is hash of strings which is used to quickly find > > field by name. This hash is initialized from ovn_init_symtab(). In case > > the latter function is called

<    3   4   5   6   7   8   9   10   11   12   >