Re: [ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow

2018-05-10 Thread Shahaf Shuler
Hi, Friday, April 20, 2018 11:07 AM, Stokes, Ian: > Subject: RE: [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow > > > > Hi, > > > > > > Here is a joint work from Mellanox and Napatech, to enable the flow > > > hw offload with the DPDK generic flow interface (rte_flow). > > > > Hi folks, I

Re: [ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow

2018-05-18 Thread Shahaf Shuler
--Shahaf > -Original Message- > From: Stokes, Ian <ian.sto...@intel.com> > Sent: Monday, May 14, 2018 1:18 PM > To: Olga Shern <ol...@mellanox.com>; Shahaf Shuler > <shah...@mellanox.com>; f...@napatech.com > Cc: ovs-dev@openvswitch.org; Flavio Le

[ovs-dev] [PATCH v10 0/7] OVS-DPDK flow offload with rte_flow

2018-05-18 Thread Shahaf Shuler
Hi, Here is a joint work from Mellanox and Napatech, to enable the flow hw offload with the DPDK generic flow interface (rte_flow). The basic idea is to associate the flow with a mark id (a unit32_t number). Later, we then get the flow directly from the mark id, which could bypass some heavy CPU

[ovs-dev] [PATCH v10 5/7] netdev-dpdk: add debug for rte flow patterns

2018-05-18 Thread Shahaf Shuler
From: Yuanhan Liu <y...@fridaylinux.org> For debug purpose. Co-authored-by: Finn Christensen <f...@napatech.com> Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Finn Christensen <f...@napatech.com> Signed-off-by: Shahaf Shuler <shah...@mellanox.com>

[ovs-dev] [PATCH v10 3/7] dpif-netdev: retrieve flow directly from the flow mark

2018-05-18 Thread Shahaf Shuler
-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Finn Christensen <f...@napatech.com> Signed-off-by: Shahaf Shuler <shah...@mellanox.com> --- lib/dp-packet.h | 13 lib/dpif-netdev.c | 44 ++

[ovs-dev] [PATCH v10 1/7] dpif-netdev: associate flow with a mark id

2018-05-18 Thread Shahaf Shuler
added. Co-authored-by: Finn Christensen <f...@napatech.com> Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Finn Christensen <f...@napatech.com> Signed-off-by: Shahaf Shuler <shah...@mellanox.com> --- lib/dpif-netdev.c | 285 +

[ovs-dev] [PATCH v10 2/7] flow: Introduce IP packet sanity checks

2018-05-18 Thread Shahaf Shuler
inn Christensen <f...@napatech.com> Signed-off-by: Shahaf Shuler <shah...@mellanox.com> --- lib/flow.c | 101 ++-- 1 file changed, 69 insertions(+), 32 deletions(-) diff --git a/lib/flow.c b/lib/flow.c index 09b66b818..2c99a5ff4 100

[ovs-dev] [PATCH v10 4/7] netdev-dpdk: implement flow offload with rte flow

2018-05-18 Thread Shahaf Shuler
hoosen. For any unsupported flows, such as MPLS, -1 is returned, meaning the flow offload is failed and then skipped. Co-authored-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Finn Christensen <f...@napatech.com> Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: S

[ovs-dev] [PATCH v10 6/7] dpif-netdev: do hw flow offload in a thread

2018-05-18 Thread Shahaf Shuler
weight as possible. Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Shahaf Shuler <shah...@mellanox.com> --- lib/dpif-netdev.c | 348 - 1 file changed, 258 insertions(+), 90 deletions(-) diff --git a/lib/dpif-netdev.c b

[ovs-dev] [PATCH v10 7/7] Documentation: document ovs-dpdk flow offload

2018-05-18 Thread Shahaf Shuler
From: Yuanhan Liu <y...@fridaylinux.org> Add details in the DPDK howto guide on the way to enable the offload along with the supported NICs and flow types. The flow offload is marked as experimental. Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Shahaf

Re: [ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow

2018-05-21 Thread Shahaf Shuler
Hi Flavio, thanks for reporting this issue. Saturday, May 19, 2018 1:47 AM, Flavio Leitner: > Subject: Re: [ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow > > > > Hello, > > I looked at the patchset (v9) and I found no obvious problems, but I miss > some instrumentation to

Re: [ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow

2018-06-18 Thread Shahaf Shuler
0, flags [none], proto TCP (6), length 40) 10.7.12.62.20 > 1.1.1.1.80: Flags [S], cksum 0x7738 (correct), seq 0, win 8192, length 0 --Shahaf From: Koujalagi, MalleshX Sent: Friday, June 15, 2018 9:29 PM To: Shahaf Shuler ; y...@fridaylinux.org; f...@napatech.com Cc: d...@openvswitch.

Re: [ovs-dev] [PATCH v10 4/7] netdev-dpdk: implement flow offload with rte flow

2018-06-18 Thread Shahaf Shuler
Monday, June 18, 2018 1:17 PM, Andrew Rybchenko: > Subject: Re: [ovs-dev] [PATCH v10 4/7] netdev-dpdk: implement flow offload > with rte flow > > On 05/18/2018 12:14 PM, Shahaf Shuler wrote: > > From: Finn Christensen > > > > The basic yet the major part of this pa

Re: [ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow

2018-06-13 Thread Shahaf Shuler
low > > On Thu, Jun 07, 2018 at 07:24:25AM +0000, Shahaf Shuler wrote: > > Thanks Flavio for the update, > > > > Wednesday, June 6, 2018 5:48 PM, Flavio Leitner: > > > Subject: Re: [ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with > > > rte_flow > >

Re: [ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow

2018-06-14 Thread Shahaf Shuler
re offload are: +- L2: Ethernet, VLAN +- L3: IPv4, IPv6 +- L4: TCP, UDP, SCTP, ICMP --Shahaf From: Koujalagi, MalleshX Sent: Thursday, June 14, 2018 4:35 AM To: y...@fridaylinux.org; Shahaf Shuler ; f...@napatech.com Cc: d...@openvswitch.org; Ergin, Mesut A ; Tsai, James Subject: [ovs-dev] [PATCH v9 0/7

Re: [ovs-dev] [PATCH] dpdk: Use DPDK 17.11.3 release.

2018-06-30 Thread Shahaf Shuler
Wednesday, June 20, 2018 12:40 PM, Ian Stokes: > Subject: [ovs-dev] [PATCH] dpdk: Use DPDK 17.11.3 release. > > Modify travis linux build script to use the latest DPDK stable release > 17.11.3. > Update docs for latest DPDK stable releases. > > Signed-off-by: Ian Stok

[ovs-dev] [PATCH v11 0/7] OVS-DPDK flow offload with rte_flow

2018-06-25 Thread Shahaf Shuler
Hi, Here is a joint work from Mellanox and Napatech, to enable the flow hw offload with the DPDK generic flow interface (rte_flow). The basic idea is to associate the flow with a mark id (a unit32_t number). Later, we then get the flow directly from the mark id, which could bypass some heavy CPU

[ovs-dev] [PATCH v11 2/7] flow: Introduce IP packet sanity checks

2018-06-25 Thread Shahaf Shuler
From: Yuanhan Liu Those checks were part of the miniflow extractor. Moving them out to act as a general helpers for packet validation. Co-authored-by: Finn Christensen Signed-off-by: Yuanhan Liu Signed-off-by: Finn Christensen Signed-off-by: Shahaf Shuler --- lib/flow.c | 101

[ovs-dev] [PATCH v11 7/7] Documentation: document ovs-dpdk flow offload

2018-06-25 Thread Shahaf Shuler
From: Yuanhan Liu Add details in the DPDK howto guide on the way to enable the offload along with the supported NICs and flow types. The flow offload is marked as experimental. Signed-off-by: Yuanhan Liu Signed-off-by: Shahaf Shuler --- Documentation/howto/dpdk.rst | 22

[ovs-dev] [PATCH v11 5/7] netdev-dpdk: add debug for rte flow patterns

2018-06-25 Thread Shahaf Shuler
From: Yuanhan Liu For debug purpose. Co-authored-by: Finn Christensen Signed-off-by: Yuanhan Liu Signed-off-by: Finn Christensen Signed-off-by: Shahaf Shuler --- lib/netdev-dpdk.c | 177 + 1 file changed, 177 insertions(+) diff --git a/lib

[ovs-dev] [PATCH v11 3/7] dpif-netdev: retrieve flow directly from the flow mark

2018-06-25 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler --- lib/dp-packet.h | 13 ++ lib/dpif-netdev.c | 46 +- lib/flow.c| 67 ++ lib/flow.h| 1 + 4 files changed, 121 insertions(+), 6 deletions(-) diff --git a/lib/dp

[ovs-dev] [PATCH v11 4/7] netdev-dpdk: implement flow offload with rte flow

2018-06-25 Thread Shahaf Shuler
rted flows, such as MPLS, -1 is returned, meaning the flow offload is failed and then skipped. Co-authored-by: Yuanhan Liu Signed-off-by: Finn Christensen Signed-off-by: Yuanhan Liu Signed-off-by: Shahaf Shuler --- lib/netdev-dpdk.c | 557 - 1 file ch

[ovs-dev] [PATCH v11 1/7] dpif-netdev: associate flow with a mark id

2018-06-25 Thread Shahaf Shuler
Christensen Signed-off-by: Yuanhan Liu Signed-off-by: Finn Christensen Signed-off-by: Shahaf Shuler --- lib/dpif-netdev.c | 285 + lib/netdev.h | 6 ++ 2 files changed, 291 insertions(+) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c ind

Re: [ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow

2018-06-21 Thread Shahaf Shuler
, 2018 5:46 PM To: Koujalagi, MalleshX ; Shahaf Shuler ; y...@fridaylinux.org Cc: d...@openvswitch.org; Ergin, Mesut A ; Tsai, James Subject: RE: [ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow Hi Mallesh and Shahaf, I have tried to reproduce the issue Mallesh is reporting, using

Re: [ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow

2018-06-22 Thread Shahaf Shuler
enabling HWOL in a simple phy2phy loopback test. I wasn’t able to reproduce it, in fact saw big improvement. Have you tried it? Would really like to address this issue before the v11. From: Finn Christensen Sent: Thursday, June 21, 2018 10:23:22 PM To: Shahaf Shuler

Re: [ovs-dev] [PATCH v4] dpif-netdev: Avoid reordering of packets in a batch with same megaflow

2018-07-09 Thread Shahaf Shuler
EMC miss. > > A new flow map is maintained to keep the original order of packet along with > flow information. Post fastpath processing, packets from flow map are > *appended* to per-flow buffer. > > Signed-off-by: Vishal Deep Ajmera > Co-authored-by: Venkatesan Pradeep >

Re: [ovs-dev] [PATCH v3] dpif-netdev: Avoid reordering of packets in a batch with same megaflow

2018-07-09 Thread Shahaf Shuler
Hi Vishal, I guess the series is not rebased on top of the HWOL series, many of the comments are related to this issue. Saturday, July 7, 2018 3:47 AM, Vishal Deep Ajmera: > Subject: [ovs-dev] [PATCH v3] dpif-netdev: Avoid reordering of packets in a > batch with same megaflow > > OVS reads

Re: [ovs-dev] [PATCH v7 0/6] OVS-DPDK flow offload with rte_flow

2018-03-13 Thread Shahaf Shuler
Wednesday, February 7, 2018 4:12 AM, Yuanhan Liu: > On Tue, Feb 06, 2018 at 09:34:36PM +, Stokes, Ian wrote: > > > Subject: Re: [ovs-dev] [PATCH v7 0/6] OVS-DPDK flow offload with > > > rte_flow Hi, Just to inform I am taking over this patchset for integration in ovs 2.10 release.

Re: [ovs-dev] [PATCH v8 2/6] dpif-netdev: retrieve flow directly from the flow mark

2018-04-11 Thread Shahaf Shuler
tcp_flags. > > > > Co-authored-by: Finn Christensen <f...@napatech.com> > > Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> > > Signed-off-by: Finn Christensen <f...@napatech.com> > > Signed-off-by:

Re: [ovs-dev] [PATCH v8 5/6] dpif-netdev: do hw flow offload in a thread

2018-04-11 Thread Shahaf Shuler
m HW offload for flow mark statistics is low, because the packet is processed by OVS regardless. For more advance HWOL like drop action / redirect action it is mandatory. > > More comments inline below. > > > > Signed-off-by: Yuanhan Liu <y...@fridaylinu

Re: [ovs-dev] [Suspected-Phishing] [PATCH v8 0/6] OVS-DPDK flow offload with rte_flow

2018-04-09 Thread Shahaf Shuler
Tuesday, March 27, 2018 10:55 AM, Shahaf Shuler: Hi, Any comments on this version? > > Hi, > > Here is a joint work from Mellanox and Napatech, to enable the flow hw > offload with the DPDK generic flow interface (rte_flow). > > The basic idea is to associate th

[ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow

2018-04-17 Thread Shahaf Shuler
Hi, Here is a joint work from Mellanox and Napatech, to enable the flow hw offload with the DPDK generic flow interface (rte_flow). The basic idea is to associate the flow with a mark id (a unit32_t number). Later, we then get the flow directly from the mark id, which could bypass some heavy CPU

[ovs-dev] [PATCH v9 3/7] dpif-netdev: retrieve flow directly from the flow mark

2018-04-17 Thread Shahaf Shuler
-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Finn Christensen <f...@napatech.com> Signed-off-by: Shahaf Shuler <shah...@mellanox.com> --- lib/dp-packet.h | 13 lib/dpif-netdev.c | 44 ++

[ovs-dev] [PATCH v9 1/7] dpif-netdev: associate flow with a mark id

2018-04-17 Thread Shahaf Shuler
added. Co-authored-by: Finn Christensen <f...@napatech.com> Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Finn Christensen <f...@napatech.com> Signed-off-by: Shahaf Shuler <shah...@mellanox.com> --- lib/dpif-netdev.c | 285 +

[ovs-dev] [PATCH v9 2/7] flow: Introduce IP packet sanity checks

2018-04-17 Thread Shahaf Shuler
inn Christensen <f...@napatech.com> Signed-off-by: Shahaf Shuler <shah...@mellanox.com> --- lib/flow.c | 101 ++-- 1 file changed, 69 insertions(+), 32 deletions(-) diff --git a/lib/flow.c b/lib/flow.c index 09b66b8..2c99a5f 100644 ---

[ovs-dev] [PATCH v9 4/7] netdev-dpdk: implement flow offload with rte flow

2018-04-17 Thread Shahaf Shuler
hoosen. For any unsupported flows, such as MPLS, -1 is returned, meaning the flow offload is failed and then skipped. Co-authored-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Finn Christensen <f...@napatech.com> Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: S

[ovs-dev] [PATCH v9 5/7] netdev-dpdk: add debug for rte flow patterns

2018-04-17 Thread Shahaf Shuler
From: Yuanhan Liu <y...@fridaylinux.org> For debug purpose. Co-authored-by: Finn Christensen <f...@napatech.com> Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Finn Christensen <f...@napatech.com> Signed-off-by: Shahaf Shuler <shah...@mellanox.com>

[ovs-dev] [PATCH v9 6/7] dpif-netdev: do hw flow offload in a thread

2018-04-17 Thread Shahaf Shuler
weight as possible. Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Shahaf Shuler <shah...@mellanox.com> --- lib/dpif-netdev.c | 348 - 1 file changed, 258 insertions(+), 90 deletions(-) diff --git a/lib/dpif-netdev.c b

[ovs-dev] [PATCH v9 7/7] Documentation: document ovs-dpdk flow offload

2018-04-17 Thread Shahaf Shuler
From: Yuanhan Liu <y...@fridaylinux.org> Add details in the DPDK howto guide on the way to enable the offload along with the supported NICs and flow types. The flow offload is marked as experimental. Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Shahaf

Re: [ovs-dev] [PATCH v8 2/6] dpif-netdev: retrieve flow directly from the flow mark

2018-04-15 Thread Shahaf Shuler
Thursday, April 12, 2018 4:39 PM, Stokes, Ian: > Subject: RE: [PATCH v8 2/6] dpif-netdev: retrieve flow directly from the flow > mark > > > > + > > > > +if (!(nw_frag & FLOW_NW_FRAG_LATER) && nw_proto == > > > IPPROTO_TCP && > > > > +size >= TCP_HEADER_LEN) { > > > > +const

[ovs-dev] [PATCH v8 1/6] dpif-netdev: associate flow with a mark id

2018-03-27 Thread Shahaf Shuler
added. Co-authored-by: Finn Christensen <f...@napatech.com> Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Finn Christensen <f...@napatech.com> Signed-off-by: Shahaf Shuler <shah...@mellanox.com> --- lib/dpif-netdev.c | 285 +

[ovs-dev] [PATCH v8 2/6] dpif-netdev: retrieve flow directly from the flow mark

2018-03-27 Thread Shahaf Shuler
-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Finn Christensen <f...@napatech.com> Signed-off-by: Shahaf Shuler <shah...@mellanox.com> --- lib/dp-packet.h | 13 + lib/dpif-netdev.c | 44 -- lib/flow.c| 155 +++

[ovs-dev] [PATCH v8 0/6] OVS-DPDK flow offload with rte_flow

2018-03-27 Thread Shahaf Shuler
Hi, Here is a joint work from Mellanox and Napatech, to enable the flow hw offload with the DPDK generic flow interface (rte_flow). The basic idea is to associate the flow with a mark id (a unit32_t number). Later, we then get the flow directly from the mark id, which could bypass some heavy CPU

[ovs-dev] [PATCH v8 5/6] dpif-netdev: do hw flow offload in a thread

2018-03-27 Thread Shahaf Shuler
weight as possible. Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Shahaf Shuler <shah...@mellanox.com> --- lib/dpif-netdev.c | 348 - 1 file changed, 258 insertions(+), 90 deletions(-) diff --git a/lib/dpif-netdev.c b

[ovs-dev] [PATCH v8 4/6] netdev-dpdk: add debug for rte flow patterns

2018-03-27 Thread Shahaf Shuler
From: Yuanhan Liu <y...@fridaylinux.org> For debug purpose. Co-authored-by: Finn Christensen <f...@napatech.com> Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Finn Christensen <f...@napatech.com> Signed-off-by: Shahaf Shuler <shah...@mellanox.com>

[ovs-dev] [PATCH v8 6/6] Documentation: document ovs-dpdk flow offload

2018-03-27 Thread Shahaf Shuler
From: Yuanhan Liu <y...@fridaylinux.org> Add details in the DPDK howto guide on the way to enable the offload along with the supported NICs and flow types. The flow offload is marked as experimental. Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Shahaf

[ovs-dev] [PATCH v8 3/6] netdev-dpdk: implement flow offload with rte flow

2018-03-27 Thread Shahaf Shuler
hoosen. For any unsupported flows, such as MPLS, -1 is returned, meaning the flow offload is failed and then skipped. Co-authored-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: Finn Christensen <f...@napatech.com> Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> Signed-off-by: S

Re: [ovs-dev] [PATCH v7 1/6] dpif-netdev: associate flow with a mark id

2018-03-20 Thread Shahaf Shuler
Hi Ian, Thursday, March 15, 2018 1:55 PM, Stokes, Ian: > Adding Shahaf Shuler > > > +static void > > > +try_netdev_flow_put(struct dp_netdev_pmd_thread *pmd, > odp_port_t > > in_port, > > > +struct dp_netdev_flow *flow, struct match *

Re: [ovs-dev] [PATCH v11 0/7] OVS-DPDK flow offload with rte_flow

2018-06-28 Thread Shahaf Shuler
Hi Ian, Flavio, Thursday, June 28, 2018 12:14 PM, Ian Stokes: > Subject: Re: [PATCH v11 0/7] OVS-DPDK flow offload with rte_flow > > On 6/25/2018 2:21 PM, Shahaf Shuler wrote: > > Hi, > > > > Here is a joint work from Mellanox and Napatech, to enable the flow hw > &