Re: [ovs-dev] [PATCH v4] bfd: Support overlay BFD

2020-07-23 Thread Yifeng Sun
Confirmed that the setup is quite unstable. Sometimes bfd flow shows up in datapath-flows.txt but sometimes not. Let me take a look. Thanks, Yifeng On Thu, Jul 23, 2020 at 6:51 AM William Tu wrote: > On Wed, Jul 22, 2020 at 1:41 PM Yifeng Sun wrote: > > > > Current

Re: [ovs-dev] [PATCH v2] bfd: Support overlay BFD

2020-07-22 Thread Yifeng Sun
packet, bfd_should_process_flow should return false so this packet won't be intercepted by OVS's BFD engine. Thanks, Yifeng On Wed, Jul 22, 2020 at 10:54 AM William Tu wrote: > On Wed, Jul 22, 2020 at 01:59:04AM -0700, Yifeng Sun wrote: > > Current OVS intercepts and processes all BF

Re: [ovs-dev] [PATCH v2] bfd: Support overlay BFD

2020-07-22 Thread Yifeng Sun
and this patch returns false in this case. For the above packet, outer IP is extracted as tunnel info, flow->nw_dst is 192.168.10.105. So bfd_should_process_flow returns false. Thanks, Yifeng On Wed, Jul 22, 2020 at 11:02 AM Yifeng Sun wrote: > Thanks for reviewing. > > For these

Re: [ovs-dev] [PATCH v2] bfd: Support overlay BFD

2020-07-22 Thread Yifeng Sun
You are correct, I will fix BFD config in v3. For the overlay BFD packet, we don't set up a port to handle packets targeted at 192.168.10.105. So ovs simply drops them. On Wed, Jul 22, 2020 at 11:26 AM William Tu wrote: > On Wed, Jul 22, 2020 at 11:02:32AM -0700, Yifeng Sun wrote: > &g

[ovs-dev] [PATCH v3] bfd: Support overlay BFD

2020-07-22 Thread Yifeng Sun
for forwarding. This patch keeps BFD's backward compatibility. VMWare-BZ: 2579326 Signed-off-by: Yifeng Sun --- v1->v2: Add test by William's suggestion. v2->v3: Fix BFD config, thanks William. lib/bfd.c | 16 +--- tests/system-traffic.a

[ovs-dev] [PATCH v4] bfd: Support overlay BFD

2020-07-22 Thread Yifeng Sun
for forwarding. This patch keeps BFD's backward compatibility. VMWare-BZ: 2579326 Signed-off-by: Yifeng Sun --- v1->v2: Add test by William's suggestion. v2->v3: Fix BFD config, thanks William. v3->v4: Test will fail at second run, fixed it. lib/bfd.c | 16 +-

Re: [ovs-dev] [PATCH V2] Update scripts to support RHEL 7.9

2020-11-18 Thread Yifeng Sun
LGTM. Reviewed-by: Yifeng Sun On Tue, Nov 17, 2020 at 3:26 PM Greg Rose wrote: > Add support for RHEL7.9 GA release with kernel 3.10.0-1160 > > Signed-off-by: Greg Rose > > --- > V2 - Correct the author > --- > rhel/openvswitch-kmod-fedora.spec.in

Re: [ovs-dev] [PATCH] rhel: Add option to enable AF_XDP on rpm package

2021-02-01 Thread Yifeng Sun
LGTM, thanks. Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun On Thu, Jan 21, 2021 at 10:57 AM Yi-Hung Wei wrote: > This patch adds an RPMBUILD_OPT so that user can enable > AF_XDP support in the rpm package by: > > $ make rpm-fedora RPMBUILD_OPT="--with afxdp" > >

[ovs-dev] [PATCH] connmgr: Check nullptr inside ofmonitor_report()

2021-02-16 Thread Yifeng Sun
: (gdb) print *ofproto $1 = ..., name = 0x55d907602820 "nsx-managed", ..., ports = {..., one = 0x0, mask = 63, n = 0}, ..., connmgr = 0x0, ... This patch fixes it. VMware-BZ: #2700626 Signed-off-by: Yifeng Sun --- ofproto/connmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [ovs-dev] [PATCH] connmgr: Check nullptr inside ofmonitor_report()

2021-02-17 Thread Yifeng Sun
Thanks William and YiHung for review, I sent a new version. On Tue, Feb 16, 2021 at 8:45 PM William Tu wrote: > On Tue, Feb 16, 2021 at 1:40 PM Yi-Hung Wei wrote: > > > > On Tue, Feb 16, 2021 at 1:06 PM Yifeng Sun > wrote: > > > > > > ovs-vswitchd c

[ovs-dev] [PATCHv2] connmgr: Check nullptr inside ofmonitor_report()

2021-02-17 Thread Yifeng Sun
: (gdb) print *ofproto $1 = ..., name = 0x55d907602820 "nsx-managed", ..., ports = {..., one = 0x0, mask = 63, n = 0}, ..., connmgr = 0x0, ... This patch fixes it. VMware-BZ: #2700626 Signed-off-by: Yifeng Sun --- v1->v2: Add check for ofmonitor_flush, thanks William. ofproto/

Re: [ovs-dev] [PATCH] rhel: Fix dual kernel rpm install for RHEL 8.4

2021-08-25 Thread Yifeng Sun
LGTM, thanks Greg. Reviewed-by: Yifeng Sun On Mon, Aug 23, 2021 at 9:33 AM Greg Rose wrote: > RHEL 8.4 is the first of the RHEL 8.x kernels that has broken ABI so > it requires the same sort of fix as we did for several RHEL 7.x kernel > that needed two kernel rpms to work for

[ovs-dev] [PATCH] conntrack: Support packets/bytes stats

2022-02-22 Thread Yifeng Sun
Userspace conntrack doesn't support conntrack stats for packets and bytes. This patch implements it. Signed-off-by: Yifeng Sun --- lib/conntrack-private.h | 9 + lib/conntrack.c | 28 tests/system-common-macros.at | 2 +- tests/system

<    1   2   3   4   5   6