Re: [ovs-dev] [PATCH 4/4] ofp-flow: Reduce memory consumption for ofputil_flow_mod, using minimatch.

2018-03-29 Thread Armando M.
On 20 March 2018 at 13:46, Ben Pfaff wrote: > Until now, struct ofputil_flow_mod, which represents an OpenFlow flow table > modification request, has incorporated a struct match, which made the > overall ofputil_flow_mod about 2.5 kB. This is OK for a small number of > flows, but

Re: [ovs-dev] [PATCH 3/4] flow, match, classifier: Add new functions for miniflow and minimatch.

2018-03-29 Thread Armando M.
On 20 March 2018 at 13:46, Ben Pfaff wrote: > The miniflow and minimatch APIs lack several of the features of the flow > and match APIs. This commit adds a few of the missing functions. > > These functions will be used for the first time in an upcoming commit. > > Signed-off-by:

Re: [ovs-dev] [PATCH 2/4] flow: Improve type-safety of MINIFLOW_GET_TYPE.

2018-03-29 Thread Armando M.
On 20 March 2018 at 13:46, Ben Pfaff wrote: > Until mow, this macro has blindly read the passed-in type's size, but > that's unnecessarily risky. This commit changes it to verify that the > passed-in type is the same size as the field and, on GCC and Clang, that > the types are

Re: [ovs-dev] [PATCH 1/4] match: Add 'tun_md' member to struct minimatch.

2018-03-29 Thread Armando M.
On 20 March 2018 at 13:46, Ben Pfaff wrote: > struct match has had a 'tun_md' member for a long time, but struct > minimatch has never had one. This doesn't matter for the purposes for > which minimatch is currently used, but it means that a minimatch is not > completely