thanks for sharing your information with me. Obviously I didn't understand
you well.
thanks, damijan
On Tue, 10 Mar 2020, 16:51 Numan Siddique, wrote:
> On Tue, Mar 10, 2020 at 7:10 PM Damijan Skvarc
> wrote:
> >
> > On Tue, Mar 10, 2020 at 2:02 PM Numan Siddique wrote:
>
On Tue, Mar 10, 2020 at 2:02 PM Numan Siddique wrote:
> On Sat, Mar 7, 2020 at 4:42 AM Ben Pfaff wrote:
> >
> > On Thu, Mar 05, 2020 at 07:21:41AM +0100, Damijan Skvarc wrote:
> > > ovnfield_by_name is hash of strings which is used to quickly find
> > > field
Hi Mark
On Fri, Feb 28, 2020 at 9:50 PM Mark Michelson wrote:
> On 2/28/20 5:40 AM, Damijan Skvarc wrote:
> > Hi Mark
> >
> > and thanks you made review of suggested patch.
> >
> > just a few words of myself...
> > I don't work profession
==by 0x4395B7: ovn_init_symtab (logical-fields.c:261)
==5999==by 0x406C91: main (ovn-controller.c:1750)
Signed-off-by: Damijan Skvarc
---
controller/lflow.c | 3 +--
include/ovn/logical-fields.h | 1 -
lib/logical-fields.c | 39
==by 0x4395B7: ovn_init_symtab (logical-fields.c:261)
==5999==by 0x406C91: main (ovn-controller.c:1750)
Signed-off-by: Damijan Skvarc
---
controller/lflow.c | 3 +--
include/ovn/logical-fields.h | 1 -
lib/logical-fields.c | 39
Hi Mark
and thanks you made review of suggested patch.
just a few words of myself...
I don't work professionally on this project, I started to look into this
code in my free hours just to satisfy my curiosity about how other people
work. I am following a couple of other projects just to learn
==by 0x406C91: main (ovn-controller.c:1750)
Signed-off-by: Damijan Skvarc
---
lib/logical-fields.c | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/lib/logical-fields.c b/lib/logical-fields.c
index 25ace58..569e31e 100644
--- a/lib/logical-fields.c
Hi Ben and thanks for letting me know about "x" prefix nomenclature, I was not
aware about it.
Thanks also for suggesting more appropriate function name, it much more
descriptive.
I am sending V2 patch
Signed-off-by: Damijan Skvarc
---
lib/util.c | 12
lib/util.h | 1
possibility I would be thankful.
Signed-off-by: Damijan Skvarc
---
lib/util.c | 13 +
lib/util.h | 1 +
2 files changed, 14 insertions(+)
diff --git a/lib/util.c b/lib/util.c
index 830e145..a588c8e 100644
--- a/lib/util.c
+++ b/lib/util.c
@@ -346,6 +346,19 @@ xasprintf(const char
ovn.c:1626)
==25922==by 0x4110D3: ovs_cmdl_run_command__ (command-line.c:247)
==25922==by 0x4066B9: main (ovstest.c:133)
The problem was in test_tree_shape_exhaustively() function which
overides pointer to temporary allocated expression without freeing it first.
Signed-off-by: Damijan Skvarc
ovn.c:1626)
==25922==by 0x4110D3: ovs_cmdl_run_command__ (command-line.c:247)
==25922==by 0x4066B9: main (ovstest.c:133)
The problem was in test_tree_shape_exhaustively() function which
overides pointer to temporary allocated expression without freeing it first.
Signed-off-by: Damijan Skvarc
thanks for review, br damijan
On Thu, 23 Jan 2020, 11:06 Ilya Maximets, wrote:
> > leak was detected by running test: "ofproto-dpif - balance-tcp bonding"
> >
> > Signed-off-by: Damijan Skvarc
>
>
> Thanks! Applied to master and branch-
leak was detected by running test: "ofproto-dpif - balance-tcp bonding"
Signed-off-by: Damijan Skvarc
---
ofproto/ofproto-dpif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index d3cb392..e8c851e 100644
---
New tests were introduced based on lcov report, which reveals apparent code
is not covered by ovs test suites.
Signed-off-by: Damijan Skvarc
---
tests/vtep-ctl.at | 87 +++
1 file changed, 87 insertions(+)
diff --git a/tests/vtep-ctl.at b
:
> On Fri, Dec 13, 2019 at 10:23:53AM +0100, Damijan Skvarc wrote:
> > new tests were introduced based on lcov report, which point out this
> > part of the code is not covered by ovs test suites.
> >
> > Signed-off-by: Damijan Skvarc
>
> This patch does no
new tests were introduced based on lcov report, which point out this
part of the code is not covered by ovs test suites.
Signed-off-by: Damijan Skvarc
---
tests/vtep-ctl.at | 87 +++
1 file changed, 87 insertions(+)
diff --git a/tests/vtep
Signed-off-by: Damijan Skvarc
---
tests/ovs-vsctl.at | 119 +
1 file changed, 119 insertions(+)
diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at
index ff39e15..00a832c 100644
--- a/tests/ovs-vsctl.at
+++ b/tests/ovs-vsctl.at
@@ -531,6
Signed-off-by: Damijan Skvarc
---
tests/ovs-vsctl.at | 119 +
1 file changed, 119 insertions(+)
diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at
index ff39e15..00a832c 100644
--- a/tests/ovs-vsctl.at
+++ b/tests/ovs-vsctl.at
@@ -531,6
unit test is introduced which checks fail-mode related commands.
Signed-off-by: Damijan Skvarc
---
tests/ovs-vsctl.at | 27 +++
1 file changed, 27 insertions(+)
diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at
index 18b9cd7..ff39e15 100644
--- a/tests/ovs-vsctl.at
emory leak can be reproduced quickly with the following command sequence:
ovs-vsctl --no-wait -vreconnect:emer add-zone-tp netdev zone=1 icmp_first=1
icmp_reply=2
ovs-vsctl --no-wait -vreconnect:emer del-zone-tp netdev zone=1
Signed-off-by: Damijan Skvarc
---
ovsdb/mutation.c | 2 ++
1 file
Signed-off-by: Damijan Skvarc
---
ovsdb/execution.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/ovsdb/execution.c b/ovsdb/execution.c
index c55a0b7..f2cf3d7 100644
--- a/ovsdb/execution.c
+++ b/ovsdb/execution.c
@@ -562,7 +562,6 @@ ovsdb_execute_mutate(struct ovsdb_execution *x, struct
Hi Ben & thanks for looking into this.
I can confirm your suggestion works ok and prevents freeing the same
memory twice. Thanks for finding this possibility. Otherwise I would do
this in some other way, but not all people are the same :).
Signed-off-by: Damijan Skvarc
---
ovsdb/file.c
by freeing this memory before
ovsdb_datum_convert() is called.
Signed-off-by: Damijan Skvarc
---
ovsdb/file.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ovsdb/file.c b/ovsdb/file.c
index 8d16b09..7ac7df0 100644
--- a/ovsdb/file.c
+++ b/ovsdb/file.c
@@ -235,6 +235,8 @@ ovsdb_convert_ta
erwards.
Signed-off-by: Damijan Skvarc
---
ovsdb/ovsdb-client.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c
index 8878462..72756eb 100644
--- a/ovsdb/ovsdb-client.c
+++ b/ovsdb/ovsdb-client.c
@@ -2061,6 +2061,7 @@ do_backup(struct jsonrpc *rpc,
(ovsdb-tool.c:79)
problem was in do_db_has_magic() which opens log file which is never closed.
Signed-off-by: Damijan Skvarc
---
ovsdb/ovsdb-tool.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ovsdb/ovsdb-tool.c b/ovsdb/ovsdb-tool.c
index a8f3135..91662ca 100644
--- a/ovsdb
le reading log
file
allocate json object which was not deallocated at the end.
Signed-off-by: Damijan Skvarc
---
ovsdb/ovsdb-tool.c | 37 +
1 file changed, 21 insertions(+), 16 deletions(-)
diff --git a/ovsdb/ovsdb-tool.c b/ovsdb/ovsdb-tool.c
index 3bbf4c
Perfect!
Thanks.
On Wed, Oct 2, 2019 at 5:39 PM Ben Pfaff wrote:
> On Wed, Oct 02, 2019 at 01:44:49PM +0200, Damijan Skvarc wrote:
> > memory leak happens in case previously closed log file was reopened
> again,
> > for example:
> >
> > ovs-appctl vlog/cl
Super, thanks
On Wed, Oct 2, 2019 at 5:31 PM Ben Pfaff wrote:
> On Wed, Oct 02, 2019 at 11:37:52AM +0200, Damijan Skvarc wrote:
> > memory leaks are reported in several tests and are expressed in a
> following way:
> >
> > ==29840== 208 (48 direct, 160 indirect) bytes in
memory leak happens while calling netdev_get_addr_list() function. This
function allocates memory for ip_addr and mask output arguments, but
this memory is never freed.
Signed-off-by: Damijan Skvarc
---
ofproto/ofproto-dpif-xlate.c | 12
1 file changed, 8 insertions(+), 4 deletions
: vlog_unixctl_reopen (vlog.c:683)
==4463==by 0x533730: process_command (unixctl.c:308)
==4463==by 0x533730: run_connection (unixctl.c:342)
==4463==by 0x533730: unixctl_server_run (unixctl.c:393)
==4463==by 0x4073AE: main (ovs-vswitchd.c:128)
Signed-off-by: Damijan Skvarc
---
lib/vlog.c | 5
Thanks for informing me. I have resent new patch request.
regards,Damijan
On Tue, Oct 1, 2019 at 6:28 PM Ben Pfaff wrote:
> On Tue, Oct 01, 2019 at 09:22:29AM +0200, Damijan Skvarc wrote:
> > memory leaks are reported in several tests and are expressed in a
> following way:
>
==by 0x4338F7: jsonrpc_session_recv (jsonrpc.c:1112)
==29840==by 0x40719B: do_wait (ovsdb-client.c:2463)
==29840==by 0x405F76: main (ovsdb-client.c:282)
Signed-off-by: Damijan Skvarc
---
ovsdb/ovsdb-client.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ovsdb/ovsdb
as
pointer and reference to the pointer. Therefore main() could not know rpc
has been changed inside command
handler functions.
regards,Damijan.
On Mon, Sep 30, 2019 at 10:47 PM Ben Pfaff wrote:
> On Mon, Sep 30, 2019 at 10:21:00AM +0200, Damijan Skvarc wrote:
> > Memory leak itself
==by 0x4338F7: jsonrpc_session_recv (jsonrpc.c:1112)
==29840==by 0x40719B: do_wait (ovsdb-client.c:2463)
==29840==by 0x405F76: main (ovsdb-client.c:282)
Signed-off-by: Damijan Skvarc
---
ovsdb/ovsdb-client.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/ovsdb/ovsdb
Ups, shame on me. Thanks for review, I will send another patch
Damijan
On Mon, Sep 30, 2019 at 10:47 PM Ben Pfaff wrote:
> On Mon, Sep 30, 2019 at 09:20:39AM +0200, Damijan Skvarc wrote:
> > memory leaks are reported in several tests and are expressed in a
> following way:
&
-client.c:143)
==29464==by 0x40AF5A: do_convert (ovsdb-client.c:1644)
==29464==by 0x405F76: main (ovsdb-client.c:282)
Signed-off-by: Damijan Skvarc
---
ovsdb/ovsdb-client.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c
index e3ef372..e78e9d9
-client.c:282)
Signed-off-by: Damijan Skvarc
---
ovsdb/ovsdb-client.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c
index bc12d42..e3ef372 100644
--- a/ovsdb/ovsdb-client.c
+++ b/ovsdb/ovsdb-client.c
@@ -1627,7 +1627,9
==by 0x4338F7: jsonrpc_session_recv (jsonrpc.c:1112)
==29840==by 0x40719B: do_wait (ovsdb-client.c:2463)
==29840==by 0x405F76: main (ovsdb-client.c:282)
Signed-off-by: Damijan Skvarc
---
ovsdb/ovsdb-client.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb
Signed-off-by: Damijan Skvarc
---
utilities/ovs-ofctl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
index 06289d2..b2350e0 100644
--- a/utilities/ovs-ofctl.c
+++ b/utilities/ovs-ofctl.c
@@ -590,6 +590,8 @@ open_vconn__(const char *name
Hi William and thanks for your review.
I agree with your proposed changes.
Is there still some action expected from me?
thanks, Damijan
On Thu, Sep 12, 2019 at 8:00 PM William Tu wrote:
> On Fri, Jul 26, 2019 at 10:11:03AM +0200, Damijan Skvarc wrote:
> >
> > While checking v
Kindly reminder to look over this patch. It is quite important since after
a while (after certain number of ssl reconnections) the application is
crashed by OOM killer.
Thanks.
On Fri, Jul 26, 2019 at 10:11 AM Damijan Skvarc
wrote:
>
> While checking valgrind reports after running "
r field name
in this
single entry table directly would be even quicker then using hash. But since I
don't
know about the future/plans of ovn_fields array I am not able to do this change.
Signed-off-by: Damijan Skvarc
---
lib/logical-fields.c | 24 ++--
1 file changed, 1
According to comments I have:
- renamed function name to be "paired" with ovn_destroy_ovnfields
- replaced 0/1 bool values with false/true
Signed-off-by: Damijan Skvarc
---
lib/logical-fields.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/logical-
Within this function actions & match dynamic strings are used as helper
variables for adding entries into logical flow table. Variables are
used several times in order to optimize number of memory allocations,
however at the end memory was forgotten to be deallocated.
Signed-off-by: Dam
On Wed, Aug 7, 2019 at 3:50 PM Numan Siddique wrote:
>
>
> On Wed, Aug 7, 2019 at 4:59 PM Damijan Skvarc
> wrote:
>
>> Within this function actions & match dynamic strings are used as helper
>> variables for adding entries into logical flow table. Variables are
fixed 0-day Robot issues
Signed-off-by: Damijan Skvarc
---
lib/logical-fields.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/logical-fields.c b/lib/logical-fields.c
index 62b9a71..fdc78cf 100644
--- a/lib/logical-fields.c
+++ b/lib/logical-fields.c
@@ -57,9
Within this function actions & match dynamic strings are used as helper
variables for adding entries into logical flow table. Variables are
used several times in order to optimize number of memory allocations,
however at the end memory was forgotten to be deallocated.
Signed-off-by: Dam
removing
ovnfield_by_name table and do a linear search through a list of single
entry. However I want to keep previous functionality in case ovn_fields
array will be extended somewhen in the future.
Signed-off-by: Damijan Skvarc
---
lib/logical-fields.c | 25 +++--
1 file changed
Memory leak happens because of redundand memory allocation for array
of single pointer. Issue was solved by removing this redundand allocation
and using address of pointer to created chassis sb_ha_entity instead.
Signed-off-by: Damijan Skvarc
---
northd/ovn-northd.c | 6 ++
1 file changed
Acked-by: Mark Michelson
> >
> > This will need a backport to the OVS 2.12 branch as well.
> >
> > On 7/31/19 6:43 AM, Damijan Skvarc wrote:
> >> Within this function actions & match dynamic strings are used as helper
> >> variables for adding entries i
Within this function actions & match dynamic strings are used as helper
variables for adding entries into logical flow table. Variables are
used several times in order to optimize number of memory allocations,
however at the end memory was forgotten to be deallocated.
Signed-off-by: Dam
Within this function actions & match dynamic strings are used as helper
variables for adding entries into logical flow table. Variables are
used several times in order to optimize number of memory allocations,
however at the end memory was forgotten to be deallocated.
Signed-off-by: Dam
Dumitru,
your issue was fixed in
https://github.com/openvswitch/ovs/commit/6f6d19db05ca743d6f294618d2c36b6d0b15e2e2
as removed warning. However fix is not merged yet on
https://github.com/ovn-org/ovn.git. Unfortunatelly even merging this fix to
ovn-org/ovn.git will not help, since (saying from
s retrieved by calling
SSL_get_peer_certificate()
where its reference counter is incremented. After retrieved certificate is not
used any more its
reference counter must be decremented by calling X509_free(). If not, allocated
memory is never
freed despite the ssl connection is properly close
Signed-off-by: Damijan Skvarc
---
ovn/controller/physical.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ovn/controller/physical.c b/ovn/controller/physical.c
index 316d373..7ad3e6f 100644
--- a/ovn/controller/physical.c
+++ b/ovn/controller/physical.c
@@ -1091,7 +1091,7
datum. As we zero out rows
> when we allocate them I assumed that this unparsing is safe.
>
> What do you guys think?
>
> Thanks,
> Dumitru
>
> On Fri, Jul 19, 2019 at 4:50 AM Damijan Skvarc
> wrote:
> >
> >
> https://mail.openvswitch.org/pipermail/ovs-dev/2
Thu, Jul 18, 2019 at 06:58:34PM +0200, Damijan Skvarc wrote:
> > Hmm, the problem of "parsed" flag is that it identifies "all" columns of
> > certain row have been parsed, however there are CLI tools which modify
> only
> > individual colums by ca
Hmm, the problem of "parsed" flag is that it identifies "all" columns of
certain row have been parsed, however there are CLI tools which modify only
individual colums by calling ovsdb_idl_txn_write_() function. In this case
and in case parsed flag would be set in ovsdb_idl_txn_write() function
Memory leak occured in case specified key was not found in table
record.
Signed-off-by: Damijan Skvarc
---
lib/db-ctl-base.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c
index fc09293..3bd9f00 100644
--- a/lib/db-ctl-base.c
+++ b/lib/db-ctl-base.c
Patch is mostly intended to prevent valgrind to report memory leak issues
while running unit tests. Otherwise it does not benefit anything since
the application exits immediately after freeing the memory.
Signed-off-by: Damijan Skvarc
---
ovn/utilities/ovn-nbctl.c | 5 +
1 file changed, 5
60 matches
Mail list logo
