Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-09 Thread David Ahern
On 6/8/22 8:58 AM, Jakub Kicinski wrote: > IMO to encourage use of the track-capable API we could keep their names > short and call the legacy functions __netdev_hold() as I mentioned or > maybe netdev_hold_notrack(). I like that option. Similar to the old nla_parse functions that were renamed

Re: [ovs-dev] [PATCH net-next] openvswitch: allow linking a VRF to an OVS bridge

2021-09-21 Thread David Ahern
On 9/20/21 9:34 AM, Antoine Tenart wrote: > There might be questions about the setup in which a VRF is linked to an > OVS bridge; I cc'ed Luis Tomás who wrote the article. My head just exploded. You want to make an L3 device a port of an L2 device. Can someone explain how this is supposed to

[ovs-dev] missing releases on downloads page + missing tags

2020-03-11 Thread David Ahern via dev
Hi: Just updated to top of tree git. I see the updates for building on v5.4 kernel (thanks Greg), but I do not see the v2.11.3 tag in git or the 2.11.3 entry on http://www.openvswitch.org/download/. A few other release are missing as well from the list on the left side. David

Re: [ovs-dev] thundering herd wakeup of handler threads

2020-03-11 Thread David Ahern
On 1/8/20 9:18 AM, Aaron Conole wrote: > David Ahern writes: > >> On 12/16/19 2:42 PM, Aaron Conole wrote: >>> Can you try the following and see if your scalability issue is >>> addressed? I think it could be better integrated, but this is a >>> dif

Re: [ovs-dev] [PATCH V2 09/11] compat: Use nla_parse deprecated functions

2020-02-28 Thread David Ahern
;> >> To be in sync with the upstream kernel, should we use the new upstream >> netlink parsing APIs (i.e. nla_parse_nested_deprecated(), >> nla_parse_deprecated_strict(), genlmsg_parse_deprecated()), and >> backports them to the old APIs if they are not available in the older >>

Re: [ovs-dev] [PATCH] kbuild: Include external modules compile flags

2020-02-21 Thread David Ahern
On 2/5/20 3:48 PM, Gregory Rose wrote: > > I found a way to make this work on the openvswitch out of tree kernel > module.  KCFLAGS > doesn't work because it is added at the end of the gcc command line and > we need to > add a '-include ' directive so that the include file comes > *before* all

Re: [ovs-dev] compiling on v5.4 kernel

2019-12-20 Thread David Ahern
On 12/20/19 11:14 AM, Gregory Rose wrote: > > On 12/19/2019 7:20 PM, Gregory Rose wrote: >> >> Bisecting is hard when you're doing it across 10s of thousands of >> Linux revisions but after a few fitsand starts I think it's this >> patch: >> >> commit 9b9a3f20cbe0ba9269cde6fff9f9c69907e150cf >>

Re: [ovs-dev] thundering herd wakeup of handler threads

2019-12-20 Thread David Ahern
On 12/16/19 2:42 PM, Aaron Conole wrote: > Can you try the following and see if your scalability issue is > addressed? I think it could be better integrated, but this is a > different quick 'n dirty. your patch reduces the number of threads awakened, but it is still really high - 43 out of 71

Re: [ovs-dev] thundering herd wakeup of handler threads

2019-12-16 Thread David Ahern
On 12/16/19 2:42 PM, Aaron Conole wrote: > Can you try the following and see if your scalability issue is > addressed? I think it could be better integrated, but this is a > different quick 'n dirty. I'll to get to it before the end of the week. ___

Re: [ovs-dev] thundering herd wakeup of handler threads

2019-12-13 Thread David Ahern
On 12/13/19 1:52 PM, Aaron Conole wrote: > Jason Baron via dev writes: > >> On 12/10/19 5:20 PM, David Ahern wrote: >>> On 12/10/19 3:09 PM, Jason Baron wrote: >>>> Hi David, >>>> >>>> The idea is that we try and queue new work to 'idle'

Re: [ovs-dev] compiling on v5.4 kernel

2019-12-11 Thread David Ahern
On 12/11/19 12:17 PM, Gregory Rose wrote: > > Hi David, > > I just want to update you on this work.  I've got everything fixed up > and compiling > on 5.4.2 but in the modpostsection there are a lot of bizarre errors.  > I'm not sure where > this comes from so I'm tracking that down. 

Re: [ovs-dev] thundering herd wakeup of handler threads

2019-12-10 Thread David Ahern
On 12/10/19 3:09 PM, Jason Baron wrote: > Hi David, > > The idea is that we try and queue new work to 'idle' threads in an > attempt to distribute a workload. Thus, once we find an 'idle' thread we > stop waking up other threads. While we are searching the wakeup list for > idle threads, we do

Re: [ovs-dev] thundering herd wakeup of handler threads

2019-12-10 Thread David Ahern
On 12/10/19 2:20 PM, Matteo Croce wrote: > > Before this patch (which unfortunately is needed to avoid -EMFILE > errors with many ports), how many sockets are awakened when an ARP is > received? > on systems using 2.7.3 I see only a single handler thread awakened on upcalls. Yes, I saw the

Re: [ovs-dev] thundering herd wakeup of handler threads

2019-12-10 Thread David Ahern
[ adding Jason as author of the patch that added the epoll exclusive flag ] On 12/10/19 12:37 PM, Matteo Croce wrote: > On Tue, Dec 10, 2019 at 8:13 PM David Ahern wrote: >> >> Hi Matteo: >> >> On a hypervisor running a 4.14.91 kernel and OVS 2.11 I am seeing a >>

Re: [ovs-dev] thundering herd wakeup of handler threads

2019-12-10 Thread David Ahern
On 12/10/19 12:37 PM, Matteo Croce wrote: > On Tue, Dec 10, 2019 at 8:13 PM David Ahern wrote: >> >> Hi Matteo: >> >> On a hypervisor running a 4.14.91 kernel and OVS 2.11 I am seeing a >> thundering herd wake up problem. Every packet punted to userspace wak

[ovs-dev] thundering herd wakeup of handler threads

2019-12-10 Thread David Ahern
Hi Matteo: On a hypervisor running a 4.14.91 kernel and OVS 2.11 I am seeing a thundering herd wake up problem. Every packet punted to userspace wakes up every one of the handler threads. On a box with 96 cpus, there are 71 handler threads which means 71 process wakeups for every packet punted.

Re: [ovs-dev] compiling on v5.4 kernel

2019-12-05 Thread David Ahern
On 12/5/19 5:29 PM, Gregory Rose wrote: > > On 12/5/2019 3:22 PM, Gregory Rose wrote: >> >> On 12/5/2019 2:15 PM, Ben Pfaff wrote: >>> On Thu, Dec 05, 2019 at 01:14:54PM -0800, Gregory Rose wrote: We try to keep our out of tree kernel modules compiling against recent kernels and will

Re: [ovs-dev] compiling on v5.4 kernel

2019-12-05 Thread David Ahern
On 12/5/19 2:14 PM, Gregory Rose wrote: > > We try to keep our out of tree kernel modules compiling against recent > kernels and > will eventually add support for 5.4.  Right now our support is up to > 5.0.  However, > you can just build the user space code and not bother with building the > out

[ovs-dev] compiling on v5.4 kernel

2019-12-05 Thread David Ahern
Hi: I am trying to compile ovs code from github for the 5.4 kernel and the module builds are failing (excerpt pasted below). Is anyone working on moving the out of tree modules forward to 5.4 now that it is released and targeted as an LTS? Thanks, David

Re: [ovs-dev] [PATCH net-next 7/8] net: core: dev: Attach extack to NETDEV_PRE_UP

2018-12-05 Thread David Ahern
fier. > > Signed-off-by: Petr Machata > Acked-by: Jiri Pirko > Reviewed-by: Ido Schimmel > --- > net/core/dev.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: David Ahern ___ dev mailing list d..

Re: [ovs-dev] [PATCH net-next 6/8] net: core: dev: Add call_netdevice_notifiers_extack()

2018-12-05 Thread David Ahern
that passes NULL for extack. > > Signed-off-by: Petr Machata > Acked-by: Jiri Pirko > Reviewed-by: Ido Schimmel > --- > net/core/dev.c | 21 - > 1 file changed, 16 insertions(+), 5 deletions(-) Reviewed-by: David Ahern _

Re: [ovs-dev] [PATCH net-next 4/8] net: core: dev: Add extack argument to dev_change_flags()

2018-12-05 Thread David Ahern
geneve.c| 2 +- > net/openvswitch/vport-gre.c | 2 +- > net/openvswitch/vport-vxlan.c | 2 +- > 15 files changed, 33 insertions(+), 23 deletions(-) > Reviewed-by: David Ahern ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH net-next 5/8] net: core: dev: Add extack argument to __dev_change_flags()

2018-12-05 Thread David Ahern
y: Ido Schimmel > --- > include/linux/netdevice.h | 3 ++- > net/core/dev.c| 5 +++-- > net/core/rtnetlink.c | 3 ++- > 3 files changed, 7 insertions(+), 4 deletions(-) > Reviewed-by: David Ahern ___ dev mailing list

Re: [ovs-dev] [PATCH net-next 2/8] net: vrf: cycle_netdev(): Add an extack argument

2018-12-05 Thread David Ahern
mel > --- > drivers/net/vrf.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > Reviewed-by: David Ahern ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH net-next 1/8] net: core: dev: Add extack argument to dev_open()

2018-12-05 Thread David Ahern
| 2 +- > net/core/dev.c | 5 +++-- > net/core/netpoll.c | 2 +- > net/ipv4/ipmr.c | 4 ++-- > net/ipv6/addrconf.c | 2 +- > net/ipv6/ip6mr.c

Re: [ovs-dev] second wave of netlink extended ACK reporting

2017-04-16 Thread David Ahern
On 4/16/17 8:40 AM, Jamal Hadi Salim wrote: > > Johannes or anybody else working on it? > i.e one which sends the extack to the bowels of callees > so we can return meaningful messages > example: rtnetlink::doit() or equivalent seems to be a candidate for > taking it as a param > For things that

Re: [ovs-dev] second wave of netlink extended ACK reporting

2017-04-16 Thread David Ahern
On 4/16/17 8:48 AM, Jamal Hadi Salim wrote: > Excellent. His patches seem to be in. Seems > commit ce07183282975026716107d36fd3f5f93de76668 > is a good point? yes. will send later today. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] second wave of netlink extended ACK reporting

2017-04-16 Thread David Ahern
On 4/16/17 8:40 AM, Jamal Hadi Salim wrote: > > Johannes or anybody else working on it? > i.e one which sends the extack to the bowels of callees > so we can return meaningful messages > example: rtnetlink::doit() or equivalent seems to be a candidate for > taking it as a param I have a patch