Re: [ovs-dev] [PATCH net] openvswitch: Set the skbuff pkt_type for proper pmtud support.

2024-03-25 Thread Eelco Chaudron
On 25 Mar 2024, at 13:37, Ilya Maximets wrote: > On 3/25/24 13:22, Aaron Conole wrote: >> Eelco Chaudron writes: >> >>> On 22 Mar 2024, at 20:06, Aaron Conole wrote: >>> >>>> Open vSwitch is originally intended to switch at la

Re: [ovs-dev] [PATCH net] openvswitch: Set the skbuff pkt_type for proper pmtud support.

2024-03-25 Thread Eelco Chaudron
On 22 Mar 2024, at 20:06, Aaron Conole wrote: > Open vSwitch is originally intended to switch at layer 2, only dealing with > Ethernet frames. With the introduction of l3 tunnels support, it crossed > into the realm of needing to care a bit about some routing details when > making forwarding

Re: [ovs-dev] [PATCH v13 5/6] tests: system-traffic: Add coverage for drop action.

2024-03-22 Thread Eelco Chaudron
ies appears satisfactory to me. I'll hold off on applying the series until Ilya has had another opportunity to review it, considering his comments on a previous revision. Once he approves, I'll proceed with applying the series. Cheers, Eelco Acked-by: Eelco Chaudron

Re: [ovs-dev] [RFC] ofproto-dpif-xlate: Recirculate on stack exhaustion.

2024-03-22 Thread Eelco Chaudron
On 23 Feb 2024, at 2:26, Ilya Maximets wrote: > This change attempts to track the actual available stack and force > recircuation if the flow translation logic is about to overflow it. Thanks Ilya, for taking a stab at this! > Unlike the recursion depth counter, this approach allows to track

Re: [ovs-dev] [PATCH v3] ofproto-dpif-upcall: Try lock for udpif_key map during sweep.

2024-03-22 Thread Eelco Chaudron
On 15 Mar 2024, at 11:04, LIU Yulong wrote: > A potential race condition happened with the following 3 threads: > * PMD thread replaced the old_ukey and transitioned the state to > UKEY_DELETED. > * RCU thread is freeing the old_ukey mutex. > * While the revalidator thread is trying to lock

Re: [ovs-dev] [PATCH v12 6/6] tests: system-offload-traffic: Verify re-probe of drop action.

2024-03-22 Thread Eelco Chaudron
On 15 Mar 2024, at 20:55, Eric Garver wrote: > Verify that the explicit drop action is re-probed if the hw-offload flag > is changed. > > Signed-off-by: Eric Garver Thanks for adding this additional test. With the one small change in 5/6, the series looks good to me. Ack

Re: [ovs-dev] [PATCH v12 5/6] tests: system-traffic: Add coverage for drop action.

2024-03-22 Thread Eelco Chaudron
er="reason >= 0x3" >0.000 ping/1275884 skb:kfree_skb(skbaddr: 0x8acd76546000, \ > location: 0xc0ee3634, protocol: 2048, reason: 196611) > > Acked-by: Eelco Chaudron > Signed-off-by: Eric Garver Looking at this patch again I have one small comment, s

Re: [ovs-dev] [PATCH v12 4/6] dpif: Probe support for OVS_ACTION_ATTR_DROP.

2024-03-22 Thread Eelco Chaudron
On 15 Mar 2024, at 20:55, Eric Garver wrote: > Kernel support has been added for this action. As such, we need to probe > the datapath for support. > > Signed-off-by: Eric Garver Thanks for following up. This change looks good to me. Acked-by: Ee

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-19 Thread Eelco Chaudron
On 19 Mar 2024, at 16:19, Ilya Maximets wrote: > On 3/19/24 15:54, Eelco Chaudron wrote: >> >> >> On 19 Mar 2024, at 15:46, Ilya Maximets wrote: >> >>> On 3/19/24 15:17, Eelco Chaudron wrote: >>>> >>>> >>>> On 19 Mar 2024

Re: [ovs-dev] [PATCH v10 0/2] debugging: Add a revalidator probe, and monitor script

2024-03-19 Thread Eelco Chaudron
On 5 Mar 2024, at 16:44, Aaron Conole wrote: > Resurrecting a feature from 2022, introduce a probe that indicates > why a particular flow may be selected for eviction during revalidation > and includes the flow information. > > The second patch tells fedora builds to include the USDT probe

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-19 Thread Eelco Chaudron
On 19 Mar 2024, at 15:46, Ilya Maximets wrote: > On 3/19/24 15:17, Eelco Chaudron wrote: >> >> >> On 19 Mar 2024, at 15:00, Ilya Maximets wrote: >> >>> On 3/19/24 14:41, Jakob Meng wrote: >>>> >>>> >>>> On 19.03.24

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-19 Thread Eelco Chaudron
On 19 Mar 2024, at 15:00, Ilya Maximets wrote: > On 3/19/24 14:41, Jakob Meng wrote: >> >> >> On 19.03.24 13:22, Ilya Maximets wrote: >>> On 3/19/24 13:21, Ilya Maximets wrote: >>>> On 3/19/24 13:17, Eelco Chaudron wrote: >>>>> >>

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-19 Thread Eelco Chaudron
On 19 Mar 2024, at 13:11, Jakob Meng wrote: > Hi! > > On 15.03.24 11:19, Eelco Chaudron wrote: >> On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: >> >>> ... >> Thank for the patch! What a beast to go trough ;) > > Thank you for doing it any

Re: [ovs-dev] [PATCH v7 2/6] python: Add global option for JSON output to Python tools.

2024-03-19 Thread Eelco Chaudron
On 19 Mar 2024, at 11:24, Jakob Meng wrote: > On 15.03.24 11:16, Eelco Chaudron wrote: >> Hi Jakob, >> >> See some comments below. >> >> //Eelco > > Thanks and comments below again  > > Cheers, > Jakob > >>> ... >>> --- a/

Re: [ovs-dev] [PATCH v7 1/6] Add global option for JSON output to ovs-appctl.

2024-03-19 Thread Eelco Chaudron
On 19 Mar 2024, at 11:09, Jakob Meng wrote: > On 15.03.24 11:15, Eelco Chaudron wrote: >> [...] >> Hi Jakob, >> >> >> Thank you for submitting this series; I believe it's a valuable addition to >> OVS! Apologies for the delayed response. I've r

Re: [ovs-dev] [PATCH v11 4/5] dpif: Probe support for OVS_ACTION_ATTR_DROP.

2024-03-18 Thread Eelco Chaudron
On 15 Mar 2024, at 18:59, Eric Garver wrote: > On Fri, Mar 15, 2024 at 12:37:54PM -0400, Eric Garver wrote: >> On Fri, Mar 15, 2024 at 04:55:50PM +0100, Eelco Chaudron wrote: >>> >>> >>> On 11 Mar 2024, at 18:51, Eric Garver wrote: >>> >&

Re: [ovs-dev] [PATCH v11 4/5] dpif: Probe support for OVS_ACTION_ATTR_DROP.

2024-03-15 Thread Eelco Chaudron
On 15 Mar 2024, at 17:37, Eric Garver wrote: > On Fri, Mar 15, 2024 at 04:55:50PM +0100, Eelco Chaudron wrote: >> >> >> On 11 Mar 2024, at 18:51, Eric Garver wrote: >> >>> Kernel support has been added for this action. As such, we need to probe >>>

Re: [ovs-dev] [PATCH v11 5/5] tests: system-traffic: Add coverage for drop action.

2024-03-15 Thread Eelco Chaudron
er="reason >= 0x3" >0.000 ping/1275884 skb:kfree_skb(skbaddr: 0x8acd76546000, \ > location: 0xc0ee3634, protocol: 2048, reason: 196611) > > Signed-off-by: Eric Garver This patch looks good to me. I re-ran all GitLab test cases and they pass j

Re: [ovs-dev] [PATCH v11 4/5] dpif: Probe support for OVS_ACTION_ATTR_DROP.

2024-03-15 Thread Eelco Chaudron
On 11 Mar 2024, at 18:51, Eric Garver wrote: > Kernel support has been added for this action. As such, we need to probe > the datapath for support. > > Signed-off-by: Eric Garver Thanks for submitting the changes requested. Some comments below. Cheers, Eelco > --- >

Re: [ovs-dev] [PATCH v11 3/5] dpif: Support atomic_bool field type.

2024-03-15 Thread Eelco Chaudron
a reference. > > Signed-off-by: Eric Garver This patch looks good to me. Cheers, Eelco Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v11 2/5] dpif: Make get_datapath_cap() access support by pointer.

2024-03-15 Thread Eelco Chaudron
On 11 Mar 2024, at 18:51, Eric Garver wrote: > This avoids copying the support struct onto the stack. > > Signed-off-by: Eric Garver > --- This change looks good to me. Thanks for catching this. //Eelco Acked-by: Eelco Chaudron ___

Re: [ovs-dev] [PATCH v11 1/5] dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL.

2024-03-15 Thread Eelco Chaudron
by: Eric Garver Thanks Eric for following up on this series!! This patch looks fine to me. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 12/12] documentation: Document ovs-flowviz.

2024-03-15 Thread Eelco Chaudron
On 13 Mar 2024, at 10:03, Adrian Moreno wrote: > Add a man page for ovs-flowviz as well as a topic page with some more > detailed examples. > > Signed-off-by: Adrian Moreno Thank you for including this documentation. It provides a nice insight into how to use the ovs-flowviz tool. I have a

Re: [ovs-dev] [PATCH v2 03/12] python: ovs: flowviz: Add console formatting.

2024-03-15 Thread Eelco Chaudron
lows br-int | ovs-flowviz openflow console -h > > [1] https://rich.readthedocs.io/en/stable/introduction.html > > Signed-off-by: Adrian Moreno Thanks for making these changes, one small nit. Guess your cursor was at a different place than you thought it was :) If this is the only change in you

Re: [ovs-dev] [PATCH v7 6/6] appctl: Add tests for unsupported output formats.

2024-03-15 Thread Eelco Chaudron
On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: > From: Jakob Meng > > Signed-off-by: Jakob Meng Some comments below, you might want to consider adding a commit message. > --- > tests/pmd.at| 5 + > tests/unixctl-py.at | 7 +++ > 2 files changed, 12 insertions(+) > > diff

Re: [ovs-dev] [PATCH v7 5/6] appctl: Add option '--pretty' for pretty-printing JSON output.

2024-03-15 Thread Eelco Chaudron
On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: > From: Jakob Meng > > Signed-off-by: Jakob Meng Some comments below and you might want to add a commit message to this patch. //Eelco > --- > NEWS | 3 +++ > lib/unixctl.c | 4 ++-- > lib/unixctl.h | 1

Re: [ovs-dev] [PATCH v7 4/6] ofproto: Add JSON output for 'dpif/show' command.

2024-03-15 Thread Eelco Chaudron
On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: > From: Jakob Meng > > The 'dpif/show' command now supports machine-readable JSON output in > addition to the plain-text output for humans. An example would be: > > ovs-appctl --format json dpif/show > > Reported-at:

Re: [ovs-dev] [PATCH v7 2/6] python: Add global option for JSON output to Python tools.

2024-03-15 Thread Eelco Chaudron
> From: Jakob Meng > > This patch introduces support for different output formats to the > Python code, as did the previous commit for ovs-xxx tools like > 'ovs-appctl --format json dpif/show'. > In particular, tests/appctl.py gains a global option '-f,--format' > which allows users to request

Re: [ovs-dev] [PATCH v7 1/6] Add global option for JSON output to ovs-appctl.

2024-03-15 Thread Eelco Chaudron
On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: > From: Jakob Meng > > For monitoring systems such as Prometheus it would be beneficial if > OVS would expose statistics in a machine-readable format. > > This patch introduces support for different output formats to ovs-xxx > tools. They gain a

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Try lock for umap iteration during sweep.

2024-03-15 Thread Eelco Chaudron
Hi, Thanks for submitting a patch and researching the problem. I haven't had the chance to review your patch yet, as I still need to dedicate some time to review it, based on the complexity. However, if you've sent a new version in the meantime, please make sure to label it with a version

Re: [ovs-dev] [PATCH] github: Reduce ASLR entropy to be compatible with asan in llvm 14.

2024-03-12 Thread Eelco Chaudron
gt; Signed-off-by: Ilya Maximets Thanks for finding the solution to this! Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v10 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-03-08 Thread Eelco Chaudron
; Acked-by: Han Zhou > Signed-off-by: Kevin Sprague > Co-authored-by: Aaron Conole > Signed-off-by: Aaron Conole Thanks Aaron for following this up. One small nit, but none blocking, maybe can fix it on commit. Acked-by: Eelco Chaudron > --- > v8 -> v9: Reorganiz

Re: [ovs-dev] [PATCH] tests: Fix "SSL db: implementation" test with openssl > 3.2.0.

2024-03-08 Thread Eelco Chaudron
port both the > pre-openssl 3.2.0 error message: "sslv3 alert certificate unknown" and the > post-openssl 3.2.0 error message: "ssl/tls alert certificate unknown". > > Signed-off-by: Timothy Redaelli > --- Other than the small grammer correction this patch look good

Re: [ovs-dev] [PATCH v2] bfd: Improve state change log message.

2024-03-08 Thread Eelco Chaudron
258496 > Signed-off-by: Timothy Redaelli Thanks for following up, the change looks good to me! Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Dump packets that fail Tx preparation.

2024-03-08 Thread Eelco Chaudron
gned-off-by: Ilya Maximets This debug addition looks good to me. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v6 1/2] util: Support checking for kernel versions.

2024-03-08 Thread Eelco Chaudron
On 4 Mar 2024, at 9:22, Felix Huettner via dev wrote: > Extract checking for a given kernel version to a separate function. > It will be used also in the next patch. > > Signed-off-by: Felix Huettner Thanks for fixing the version check. Acked-by: Ee

Re: [ovs-dev] [PATCH v9 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-03-04 Thread Eelco Chaudron
On 4 Mar 2024, at 16:46, Aaron Conole wrote: > Eelco Chaudron writes: > >> On 20 Feb 2024, at 22:47, Aaron Conole wrote: >> >>> From: Kevin Sprague >>> >>> During normal operations, it is useful to understand when a particular flow >>>

Re: [ovs-dev] [PATCH] github: Temporarily disable SNAT with exhaustion system test.

2024-03-01 Thread Eelco Chaudron
olo, can you take a look at fixing the test case? Do you want an FDP issue for this? >> >> Signed-off-by: Ilya Maximets >> --- The change looks good for now. Acked-by: Eelco Chaudron >> tests/system-traffic.at | 1 + >> 1 file changed, 1 insertio

Re: [ovs-dev] [PATCH v2 3/5] netdev-linux: Rename sturct nedev_linux field as is_lag_primary

2024-03-01 Thread Eelco Chaudron
-off-by: Simon Horman Thanks for fixing these. Except for the missing dot in the subject, the changes look good to me. Assuming you will fix this when applying; Acked-by: Eelco Chaudron //Eelco ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 4/5] netdev-linux: Rename local variables as primary_*.

2024-03-01 Thread Eelco Chaudron
word-lists/ > > Signed-off-by: Simon Horman Thanks for fixing these. The changes look good to me. Acked-by: Eelco Chaudron //Eelco ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 2/5] Documentation: Update to refer to main repository.

2024-03-01 Thread Eelco Chaudron
om addressing the use of a master branch, > which remains as a follow-up task. > > [1] df5e5cf ("Documentation: Add section on inclusive language.") > [2] https://inclusivenaming.org/word-lists/ > > Signed-off-by: Simon Horman Thanks for fixing these. The changes loo

Re: [ovs-dev] [PATCH v2 1/5] vswitch.xml: Use member wording for bonds.

2024-03-01 Thread Eelco Chaudron
m "slave" in bond, LACP, and bundle > contexts.") > [2] df5e5cf4318a ("Documentation: Add section on inclusive language.") > [3] https://inclusivenaming.org/word-lists/ > > Signed-off-by: Simon Horman Thanks for fixing these. Changes look good to me. Acked-by: Ee

Re: [ovs-dev] [PATCH v2 5/5] utilities: Use localhost as sample hostname.

2024-03-01 Thread Eelco Chaudron
s so > by using localhost as the hostname instead. > > [1] df5e5cf ("Documentation: Add section on inclusive language.") > [2] https://inclusivenaming.org/word-lists/ > > Cc: Eelco Chaudron > Signed-off-by: Simon Horman Than

Re: [ovs-dev] [PATCH v7 2/2] ofproto-dpif-mirror: Add support for pre-selection filter.

2024-03-01 Thread Eelco Chaudron
On 26 Feb 2024, at 22:16, Mike Pattrick wrote: > Currently a bridge mirror will collect all packets and tools like > ovs-tcpdump can apply additional filters after they have already been > duplicated by vswitchd. This can result in inefficient collection. > > This patch adds support to apply

Re: [ovs-dev] [PATCH v7 1/2] ofproto-dpif-mirror: Reduce number of function parameters.

2024-03-01 Thread Eelco Chaudron
: Mike Pattrick > Acked-by: Simon Horman > Acked-by: Eelco Chaudron Re-acking as there are quite some changes since rev5. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v9 2/2] rhel: Enable USDT scripts by default in Fedora builds.

2024-03-01 Thread Eelco Chaudron
On 20 Feb 2024, at 22:47, Aaron Conole wrote: > All supported versions of Fedora do package libbpf, so it > makes sense to enable USDT support. > > Acked-by: Simon Horman > Signed-off-by: Aaron Conole This patch looks good to me. Acked-by:

Re: [ovs-dev] [PATCH v9 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-03-01 Thread Eelco Chaudron
On 20 Feb 2024, at 22:47, Aaron Conole wrote: > From: Kevin Sprague > > During normal operations, it is useful to understand when a particular flow > gets removed from the system. This can be useful when debugging performance > issues tied to ofproto flow changes, trying to determine deployed

Re: [ovs-dev] [PATCH 2/5] Documentation: Correct spelling errors.

2024-03-01 Thread Eelco Chaudron
On 1 Mar 2024, at 11:00, Simon Horman wrote: > On Wed, Feb 28, 2024 at 10:41:11AM +0100, Eelco Chaudron wrote: >> >> >> On 27 Feb 2024, at 16:36, Simon Horman wrote: >> >>> Correct spelling errors in .rst files flagged by codespell. >> >> Som

Re: [ovs-dev] [PATCH v1 12/12] documentation: Document ovs-flowviz.

2024-02-29 Thread Eelco Chaudron
On 20 Feb 2024, at 7:29, Adrian Moreno wrote: > On 2/19/24 23:53, Ilya Maximets wrote: >> On 2/19/24 09:14, Adrian Moreno wrote: >>> Add a page for flow visualization with a few key concepts and examples. >>> >>> Signed-off-by: Adrian Moreno >>> --- >>> Documentation/automake.mk

Re: [ovs-dev] [PATCH v1 11/12] python: ovs: flowviz: Support html dark style.

2024-02-29 Thread Eelco Chaudron
On 19 Feb 2024, at 9:14, Adrian Moreno wrote: > In order to support dark style in html outputs, allow the config file to > express the background color and set it in a top style object. > > Signed-off-by: Adrian Moreno Thanks for adding this. It makes my eyes happy ;) Ack

Re: [ovs-dev] [PATCH v1 10/12] python: ovs: flowviz: Add datapath graph format.

2024-02-29 Thread Eelco Chaudron
dpctl/dump-flows -m | ovs-flowviz datapath graph --html > > flows.html > > Acked-by: Eelco Chaudron > Signed-off-by: Adrian Moreno Thanks for adding the example to the commit message. Acked-by: Eelco Chaudron ___ dev mailing list

Re: [ovs-dev] [PATCH v1 09/12] python: ovs: flowviz: Add datapath html format.

2024-02-29 Thread Eelco Chaudron
ight drop datapath > html > /tmp/flows.html > $ ovs-appcl dpctl/dump-flows | ovs-flowviz -f "output.port=3" > datapath html > /tmp/flows.html > > Acked-by: Eelco Chaudron > Signed-off-by: Adrian Moreno Thanks for adding the exam

Re: [ovs-dev] [PATCH v1 08/12] python: ovs: flowviz: Add Openflow cookie format.

2024-02-29 Thread Eelco Chaudron
hen by table. > > Example: > $ export OVN_NB_DB=... > $ export OVN_SB_DB=... > $ ovs-vsctl dump-flows br-int | ovs-flowviz openflow cookie > --ovn-filter="acl.*icmp4" > $ ovs-vsctl dump-flows br-int | ovs-flowviz openflow cookie > --ovn-detrace > > Acked-by:

Re: [ovs-dev] [PATCH v1 07/12] python: ovs: flowviz: Add OpenFlow logical view.

2024-02-29 Thread Eelco Chaudron
lows br-int | ovs-flowviz openflow logic -d > $ ovs-ofctl dump-flows br-int | ovs-flowviz openflow logic -d > --ovn-filter="acl.*icmp4" > > Acked-by: Eelco Chaudron > Signed-off-by: Adrian Moreno Ack on the additional change. Acked-by: Eelco Chaudron _

Re: [ovs-dev] [PATCH v1 06/12] python: ovs: flowviz: Add datapath tree format.

2024-02-29 Thread Eelco Chaudron
> - hash-based pallete of recirculation ids: each recirculation id is > assigned a unique color to easily follow the sequence of related > actions. > - full-tree filtering: if a user specifies a filter, an entire subtree > is filtered out if none of its branches satisfy it. &g

Re: [ovs-dev] [PATCH v1 01/12] python: ovs: Add flowviz scheleton.

2024-02-29 Thread Eelco Chaudron
t; > $ pip install .[flowviz] > or > $ pip install ovs[flowviz] > > Signed-off-by: Adrian Moreno Thanks for making the additional nit changes. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v1 03/12] python: ovs: flowviz: Add console formatting.

2024-02-29 Thread Eelco Chaudron
On 19 Feb 2024, at 9:14, Adrian Moreno wrote: > Add a flow formatting framework and one implementation for console > printing using rich. > > The flow formatting framework is a simple set of classes that can be > used to write different flow formatting implementations. It supports > styles to

Re: [ovs-dev] [PATCH v1 02/12] python: ovs: flowviz: Add file processing infra.

2024-02-29 Thread Eelco Chaudron
p-flows > flows.txt && ovs-flowviz -i flows.txt > -f 'drop' datapath json > > Signed-off-by: Adrian Moreno > Thanks for making the suggested changes. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v1 04/12] python: ovs: flowviz: Add default config file.

2024-02-29 Thread Eelco Chaudron
style=light openflow console > > Acked-by: Eelco Chaudron > Signed-off-by: Adrian Moreno Thanks for making the additional nit changes. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] dpif-netdev: Do not create handler threads.

2024-02-29 Thread Eelco Chaudron
On 20 Feb 2024, at 17:50, Mike Pattrick wrote: > On Tue, Feb 20, 2024 at 4:32 AM Eelco Chaudron wrote: >> >> Avoid unnecessary thread creation as no upcalls are generated, >> resulting in idle threads waiting for process termination. >> >> This optimization s

Re: [ovs-dev] [PATCH 1/5] Documentation: Extend copyright to 2024.

2024-02-28 Thread Eelco Chaudron
On 28 Feb 2024, at 14:07, Ilya Maximets wrote: > On 2/28/24 10:35, Eelco Chaudron wrote: >> >> >> On 28 Feb 2024, at 10:15, Simon Horman wrote: >> >>> On Wed, Feb 28, 2024 at 08:40:40AM +0100, Eelco Chaudron wrote: >>>> >>>> >>

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-02-28 Thread Eelco Chaudron
ling=1 - offloads enabled ok >>4: offloads - sflow with sampling=2 - offloads enabled ok >>5: offloads - ping over vxlan tunnel with sflow - offloads enabled ok >> >> Signed-off-by: Chris Mi >> Reviewed-by: Roi Dayan >> Acked-by: Eelco Chaudron >>

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-02-28 Thread Eelco Chaudron
On 28 Feb 2024, at 4:38, Chris Mi wrote: > On 2/28/2024 9:20 AM, Chris Mi via dev wrote: >> On 2/27/2024 6:54 PM, Eelco Chaudron wrote: >>> >>> >>> On 9 Jan 2024, at 11:40, Eelco Chaudron wrote: >>> >>>> On 9 Jan 2024, at 10:22, Chris

Re: [ovs-dev] [PATCH 5/5] Documentation: Update links to upstream Kernel documentation.

2024-02-28 Thread Eelco Chaudron
gt; 1., 2. & 3. Found by inspection > 4. Flagged by check-docs > > Signed-off-by: Simon Horman The changes look good to me. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 4/5] Documentatoin: Update Pacemaker link.

2024-02-28 Thread Eelco Chaudron
On 27 Feb 2024, at 16:36, Simon Horman wrote: > Update link to OCF Resource Agents documentation as the existing link > is broken. Also, use HTTPS. > > Broken link flagged by make check-docs > > Signed-off-by: Simon Horman Thanks for checking. Acked-

Re: [ovs-dev] [PATCH 3/5] Documentation: Anuket project updates.

2024-02-28 Thread Eelco Chaudron
elease/release-notes/release-notes.html > > Signed-off-by: Simon Horman Thanks, these changes look good to me. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/5] Documentation: Correct spelling errors.

2024-02-28 Thread Eelco Chaudron
On 27 Feb 2024, at 16:36, Simon Horman wrote: > Correct spelling errors in .rst files flagged by codespell. Some small nits below. //Eelco > Signed-off-by: Simon Horman > --- > Documentation/howto/sflow.rst | 2 +- > Documentation/howto/tc-offload.rst| 4 ++--

Re: [ovs-dev] [PATCH 1/5] Documentation: Extend copyright to 2024.

2024-02-28 Thread Eelco Chaudron
On 28 Feb 2024, at 10:15, Simon Horman wrote: > On Wed, Feb 28, 2024 at 08:40:40AM +0100, Eelco Chaudron wrote: >> >> >> On 27 Feb 2024, at 16:36, Simon Horman wrote: >> >>> IANAL, but I think we can extend the copyright attached >>> to document

Re: [ovs-dev] [PATCH 1/5] Documentation: Extend copyright to 2024.

2024-02-27 Thread Eelco Chaudron
On 27 Feb 2024, at 16:36, Simon Horman wrote: > IANAL, but I think we can extend the copyright attached > to documentation to cover the current year: we are still > actively working on the documentation. > > Signed-off-by: Simon Horman > --- > Documentation/conf.py | 2 +- > 1 file changed,

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-02-27 Thread Eelco Chaudron
On 9 Jan 2024, at 11:40, Eelco Chaudron wrote: > On 9 Jan 2024, at 10:22, Chris Mi wrote: > >> Hi Roi and Eelco, >> >> Sorry for the late reply. We are still busy with other task. So maybe we'll >> have to postpone it. > > Thanks for the update and I gu

Re: [ovs-dev] [PATCH v4 1/2] util: Support checking for kernel versions.

2024-02-25 Thread Eelco Chaudron
On 23 Feb 2024, at 14:32, Felix Huettner via dev wrote: > Extract checking for a given kernel version to a separate function. > It will be used also in the next patch. > > Signed-off-by: Felix Huettner Just a quick observation on this patch, see comments below. //Eelco > --- > v4: > -

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-21 Thread Eelco Chaudron
On 21 Feb 2024, at 17:45, Adrian Moreno wrote: > On 2/21/24 16:42, Eelco Chaudron wrote: >> >> >> On 21 Feb 2024, at 16:03, Adrian Moreno wrote: >> >>> On 2/21/24 15:49, Aaron Conole wrote: >>>> Adrian Moreno writes: >>>> >&

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-21 Thread Eelco Chaudron
On 21 Feb 2024, at 16:03, Adrian Moreno wrote: > On 2/21/24 15:49, Aaron Conole wrote: >> Adrian Moreno writes: >> >>> On 2/20/24 19:06, Aaron Conole wrote: >>>> Eelco Chaudron writes: >>>> >>>>> On 19 Feb 2024, at

Re: [ovs-dev] [PATCH 3/3] ofproto-dpif-xlate: Fix ignoring IPv6 local_ip for native tunnels.

2024-02-21 Thread Eelco Chaudron
sses") > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2024-February/052938.html > Reported-by: Derrick Lim > Signed-off-by: Ilya Maximets Thanks for the patch, the changes look good to me and the tests are passing. Acked-by: Eelco Chaudron

Re: [ovs-dev] [PATCH 2/3] netdev-dummy: Add local route entries for IP addresses.

2024-02-21 Thread Eelco Chaudron
r linux." > > Signed-off-by: Ihar Hrachyshka > Co-authored-by: Ilya Maximets > Signed-of-by: Ilya Maximets Thanks for the patch, the changes look good to me and the tests are passing. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/3] tests: Move the non-local port as tunnel endpoint test.

2024-02-21 Thread Eelco Chaudron
less error > prone by requesting port numbers for all the ports. > > Signed-off-by: Ilya Maximets Thanks for the patch, the changes look good to me and the tests are passing. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org h

Re: [ovs-dev] [PATCH] ovs-thread: Log pthread failures.

2024-02-21 Thread Eelco Chaudron
would like to have a stack trace in a core dump in case a mutex > lock failed with 'deadlock avoided'. > > Signed-off-by: Ilya Maximets Changes look good to me! Acked-by: Eelco Chaudron //Eelco ___ dev mailing list d...@openvswitch.org htt

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-21 Thread Eelco Chaudron
On 20 Feb 2024, at 19:10, Adrian Moreno wrote: > On 2/20/24 13:43, Eelco Chaudron wrote: >> >> >> On 19 Feb 2024, at 19:57, Aaron Conole wrote: >> >>> Eelco Chaudron writes: >>> >>>> On 12 Feb 2024, at 15:15, Aaron Conole wrote: >

Re: [ovs-dev] [PATCH 2/2] dpif-netlink: Fix overriding the number of handler threads.

2024-02-20 Thread Eelco Chaudron
On 19 Feb 2024, at 20:23, Ilya Maximets wrote: > On 2/8/24 16:53, Eelco Chaudron wrote: >> >> >> On 8 Feb 2024, at 15:00, Ilya Maximets wrote: >> >>> On 2/8/24 13:44, Eelco Chaudron wrote: >>>> >>>> >>>> On 6 Feb 2024, a

Re: [ovs-dev] [PATCH v2] utilities: Add TASK_STOPPED accounting to the kernel_delay.py script.

2024-02-20 Thread Eelco Chaudron
On 30 Jan 2024, at 10:53, Simon Horman wrote: > On Mon, Jan 29, 2024 at 01:51:42PM +0100, Eelco Chaudron wrote: >> This changes add statistics for when a thread is put into stop state. >> For example with the following: >> >> kill -STOP $(pidof ovs-vswitchd); slee

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-20 Thread Eelco Chaudron
On 19 Feb 2024, at 19:57, Aaron Conole wrote: > Eelco Chaudron writes: > >> On 12 Feb 2024, at 15:15, Aaron Conole wrote: >> >>> Aaron Conole writes: >>> >>>> Eelco Chaudron writes: >>>> >>>>> On 2 Feb 2024, at 11:

[ovs-dev] [PATCH v2] dpif-netdev: Do not create handler threads.

2024-02-20 Thread Eelco Chaudron
-off-by: Eelco Chaudron --- v2: Sending this as a separate patch. lib/dpif-netdev.c | 10 +- ofproto/ofproto-dpif-upcall.c | 25 - 2 files changed, 25 insertions(+), 10 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index c1981137f

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-19 Thread Eelco Chaudron
On 12 Feb 2024, at 15:15, Aaron Conole wrote: > Aaron Conole writes: > >> Eelco Chaudron writes: >> >>> On 2 Feb 2024, at 11:31, Adrian Moreno wrote: >>> >>>> On 2/1/24 10:02, Eelco Chaudron wrote: >>>>> >>>>> &

Re: [ovs-dev] [PATCH 2/2] dpif-netlink: Fix overriding the number of handler threads.

2024-02-08 Thread Eelco Chaudron
On 8 Feb 2024, at 15:00, Ilya Maximets wrote: > On 2/8/24 13:44, Eelco Chaudron wrote: >> >> >> On 6 Feb 2024, at 16:01, Ilya Maximets wrote: >> >>> On 2/6/24 15:07, Eelco Chaudron wrote: >>>> >>>> >>>> On 6 Feb 2024, a

Re: [ovs-dev] [PATCH 2/2] dpif-netlink: Fix overriding the number of handler threads.

2024-02-08 Thread Eelco Chaudron
On 6 Feb 2024, at 16:01, Ilya Maximets wrote: > On 2/6/24 15:07, Eelco Chaudron wrote: >> >> >> On 6 Feb 2024, at 14:46, Ilya Maximets wrote: >> >>> On 2/6/24 14:30, Eelco Chaudron wrote: >>>> Previously, the ability to override the syste

Re: [ovs-dev] [PATCH ovs v4] Documentation: Adding note about using the jemalloc library.

2024-02-07 Thread Eelco Chaudron
015748 > Signed-off-by: Roberto Bartzen Acosta Thanks for adding my change request. It looks fine to me now. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/2] dpif-netdev: Do not create handler threads.

2024-02-06 Thread Eelco Chaudron
On 6 Feb 2024, at 15:50, David Marchand wrote: > On Tue, Feb 6, 2024 at 3:47 PM Eelco Chaudron wrote: >> On 6 Feb 2024, at 15:17, David Marchand wrote: >> >>> On Tue, Feb 6, 2024 at 2:31 PM Eelco Chaudron wrote: >>>> >>>> Avoid unneces

Re: [ovs-dev] [PATCH 1/2] dpif-netdev: Do not create handler threads.

2024-02-06 Thread Eelco Chaudron
On 6 Feb 2024, at 15:17, David Marchand wrote: > On Tue, Feb 6, 2024 at 2:31 PM Eelco Chaudron wrote: >> >> Avoid unnecessary thread creation as no upcalls are generated, >> resulting in idle threads waiting for process termination. >> >> This optimization s

Re: [ovs-dev] [PATCH 2/2] dpif-netlink: Fix overriding the number of handler threads.

2024-02-06 Thread Eelco Chaudron
On 6 Feb 2024, at 14:46, Ilya Maximets wrote: > On 2/6/24 14:30, Eelco Chaudron wrote: >> Previously, the ability to override the system default for the number >> of handler threads was broken since to the introduction of the per-CPU >> upcall handlers.

[ovs-dev] [PATCH 2/2] dpif-netlink: Fix overriding the number of handler threads.

2024-02-06 Thread Eelco Chaudron
tlink: Introduce per-cpu upcall dispatch.") Signed-off-by: Eelco Chaudron --- lib/dpif-netlink.c| 8 +++- lib/dpif-provider.h | 4 ofproto/ofproto-dpif-upcall.c | 2 +- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/dpif-netlink.c b/lib/dpif

[ovs-dev] [PATCH 1/2] dpif-netdev: Do not create handler threads.

2024-02-06 Thread Eelco Chaudron
-off-by: Eelco Chaudron --- lib/dpif-netdev.c | 10 +- ofproto/ofproto-dpif-upcall.c | 25 - 2 files changed, 25 insertions(+), 10 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index c1981137f..1a29ab7ac 100644 --- a/lib/dpif-netdev.c

Re: [ovs-dev] [PATCH] bfd: Improve state change log message.

2024-02-06 Thread Eelco Chaudron
On 6 Feb 2024, at 13:58, Ilya Maximets wrote: > On 2/6/24 13:50, Eelco Chaudron wrote: >> >> >> On 6 Feb 2024, at 13:46, Ilya Maximets wrote: >> >>> On 2/4/24 15:40, Timothy Redaelli wrote: >>>> A log message like this one: >>>> >&

Re: [ovs-dev] [PATCH] bfd: Improve state change log message.

2024-02-06 Thread Eelco Chaudron
On 6 Feb 2024, at 13:46, Ilya Maximets wrote: > On 2/4/24 15:40, Timothy Redaelli wrote: >> A log message like this one: >> >> 2024-01-09T06:45:17.201Z|00071|bfd(handler2)|INFO|ovn-0af536-0: BFD state >> change: down->up "Neighbor Signaled Session Down"->"Neighbor Signaled Session >> Down". >>

Re: [ovs-dev] [PATCH branch-3.0] dpdk: Use DPDK 21.11.6 release for OVS 3.0.

2024-02-06 Thread Eelco Chaudron
On 6 Feb 2024, at 13:45, Kevin Traynor wrote: > On 05/02/2024 11:32, Eelco Chaudron wrote: >> >> >> On 2 Feb 2024, at 13:46, Kevin Traynor wrote: >> >>> Update the CI and docs to use DPDK 21.11.6. >>> >>> Signed-off-by: Kevin Trayno

Re: [ovs-dev] [PATCH master/branch-3.3] faq: Update DPDK releases for older branches.

2024-02-05 Thread Eelco Chaudron
ctions, but assume they are fine. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-3.2] dpdk: Use DPDK 22.11.4 release for OVS 3.2.

2024-02-05 Thread Eelco Chaudron
On 2 Feb 2024, at 13:46, Kevin Traynor wrote: > Update the CI and docs to use DPDK 22.11.4. > > Signed-off-by: Kevin Traynor Thanks for getting all DPDK packages upgraded. The changes look good to me. Did not run the GitHub actions, but assume they are fine. Acked-by: Eelco

Re: [ovs-dev] [PATCH branch-3.1] dpdk: Use DPDK 22.11.4 release for OVS 3.1.

2024-02-05 Thread Eelco Chaudron
On 2 Feb 2024, at 13:46, Kevin Traynor wrote: > Update the CI and docs to use DPDK 22.11.4. > > Signed-off-by: Kevin Traynor > --- Thanks for getting all DPDK packages upgraded. The changes look good to me. Did not run the GitHub actions, but assume they are fine. Acked-by: Ee

Re: [ovs-dev] [PATCH branch-3.0] dpdk: Use DPDK 21.11.6 release for OVS 3.0.

2024-02-05 Thread Eelco Chaudron
On 2 Feb 2024, at 13:46, Kevin Traynor wrote: > Update the CI and docs to use DPDK 21.11.6. > > Signed-off-by: Kevin Traynor Thanks for getting all DPDK packages upgraded. The changes look good to me. Did not run the GitHub actions, but assume they are fine. Acked-by: Eelco

Re: [ovs-dev] [PATCH branch-2.17] dpdk: Use DPDK 21.11.6 release for OVS 2.17.

2024-02-05 Thread Eelco Chaudron
On 2 Feb 2024, at 13:46, Kevin Traynor wrote: > Update the CI and docs to use DPDK 21.11.6. > > Signed-off-by: Kevin Traynor > --- Thanks for getting all DPDK packages upgraded. The changes look good to me. Did not run the GitHub actions, but assume they are fine. Acked-by: Ee

Re: [ovs-dev] [PATCH ovs v3] Documentation: Adding note about using the jemalloc library.

2024-02-04 Thread Eelco Chaudron
On 5 Feb 2024, at 2:24, Roberto Bartzen Acosta via dev wrote: > Updating the reference documentation with the inclusion of possible building > problems with libjemalloc and solution suggestions. > > Reported-at: > https://bugs.launchpad.net/ubuntu/+source/openvswitch/+bug/2015748 >

  1   2   3   4   5   6   7   8   9   10   >