On Fri, Apr 05, 2024 at 11:39:58AM +0200, Eelco Chaudron wrote:
>
>
> On 3 Apr 2024, at 16:35, Eric Garver wrote:
>
> > Kernel support has been added for this action. As such, we need to probe
> > the datapath for support.
> >
> > Signed-off-by: Eri
f8acd76546000, \
location: 0xc0ee3634, protocol: 2048, reason: 196611)
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
tests/system-traffic.at | 31 +++
2 files changed, 35 insertions(+)
diff --git a
- better commit message in patch 2
- reordered _DEC_TTL value in switch statements
- add format_dec_ttl_action()
v2:
- new patch (1) to fix build (switch cases)
- fixed check-system-userspace
Eric Garver (6):
dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL.
dpif: Make
This avoids copying the support struct onto the stack.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
ofproto/ofproto-dpif.c | 59 +-
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
Verify that the explicit drop action is re-probed if the hw-offload flag
is changed.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
tests/system-offloads-traffic.at | 12
1 file changed, 12 insertions(+)
diff --git a/tests/system-offloads-traffic.at b/tests/system
The next commit will convert a dp feature from bool to atomic_bool. As
such we have to add support to the macros and functions. We must pass by
reference instead of pass by value because all the atomic operations
require a reference.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
Kernel support has been added for this action. As such, we need to probe
the datapath for support.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 ++-
lib/dpif.h | 2 +-
ofproto/ofproto-dpif.c | 77
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 9 +
lib/dpif
On Wed, Apr 03, 2024 at 12:42:25AM +0200, Ilya Maximets wrote:
> On 4/3/24 00:28, Eric Garver wrote:
> > On Fri, Mar 29, 2024 at 12:26:11AM +0100, Ilya Maximets wrote:
> >> On 3/22/24 14:54, Eric Garver wrote:
> > [..]
> >>> @@ -1649,8 +1693,8 @@ chec
On Fri, Mar 29, 2024 at 12:26:11AM +0100, Ilya Maximets wrote:
> On 3/22/24 14:54, Eric Garver wrote:
[..]
> > @@ -1649,8 +1693,8 @@ check_support(struct dpif_backer *backer)
> > backer->rt_support.max_hash_alg = check_max_dp_hash_alg(backer);
> > backer-&
On Fri, Mar 29, 2024 at 12:26:11AM +0100, Ilya Maximets wrote:
> On 3/22/24 14:54, Eric Garver wrote:
> > Kernel support has been added for this action. As such, we need to probe
> > the datapath for support.
> >
> > Acked-by: Eelco Chaudron
> > Signed-off-by:
On Thu, Mar 28, 2024 at 11:13:13PM +0100, Ilya Maximets wrote:
> On 3/22/24 14:54, Eric Garver wrote:
> > This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
> > action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
> > to make -Werror hap
f8acd76546000, \
location: 0xc0ee3634, protocol: 2048, reason: 196611)
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
tests/system-traffic.at | 31 +++
2 files changed, 35 insertions(+)
diff --git a/tests/system-common-macr
The next commit will convert a dp feature from bool to atomic_bool. As
such we have to add support to the macros and functions. We must pass by
reference instead of pass by value because all the atomic operations
require a reference.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
Kernel support has been added for this action. As such, we need to probe
the datapath for support.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 ++-
lib/dpif.h | 2 +-
ofproto/ofproto-dpif.c
Verify that the explicit drop action is re-probed if the hw-offload flag
is changed.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
tests/system-offloads-traffic.at | 12
1 file changed, 12 insertions(+)
diff --git a/tests/system-offloads-traffic.at b/tests/system
-userspace
Eric Garver (6):
dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL.
dpif: Make get_datapath_cap() access support by pointer.
dpif: Support atomic_bool field type.
dpif: Probe support for OVS_ACTION_ATTR_DROP.
tests: system-traffic: Add coverage for drop action.
tests
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h
This avoids copying the support struct onto the stack.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
ofproto/ofproto-dpif.c | 59 +-
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
The next commit will convert a dp feature from bool to atomic_bool. As
such we have to add support to the macros and functions. We must pass by
reference instead of pass by value because all the atomic operations
require a reference.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
f8acd76546000, \
location: 0xc0ee3634, protocol: 2048, reason: 196611)
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
tests/system-traffic.at | 31 +++
2 files changed, 35 insertions(+)
diff --git a
Verify that the explicit drop action is re-probed if the hw-offload flag
is changed.
Signed-off-by: Eric Garver
---
tests/system-offloads-traffic.at | 12
1 file changed, 12 insertions(+)
diff --git a/tests/system-offloads-traffic.at b/tests/system-offloads-traffic.at
index
:
- alter test such that it's reliable, different xlate_error
- better commit message in patch 2
- reordered _DEC_TTL value in switch statements
- add format_dec_ttl_action()
v2:
- new patch (1) to fix build (switch cases)
- fixed check-system-userspace
Eric Garver (6):
dpif: Stub out
Kernel support has been added for this action. As such, we need to probe
the datapath for support.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 ++-
lib/dpif.h | 2 +-
ofproto/ofproto-dpif.c | 78
This avoids copying the support struct onto the stack.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
ofproto/ofproto-dpif.c | 59 +-
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h
On Fri, Mar 15, 2024 at 12:37:54PM -0400, Eric Garver wrote:
> On Fri, Mar 15, 2024 at 04:55:50PM +0100, Eelco Chaudron wrote:
> >
> >
> > On 11 Mar 2024, at 18:51, Eric Garver wrote:
> >
> > > Kernel support has been added for this action. As such,
On Fri, Mar 15, 2024 at 04:55:50PM +0100, Eelco Chaudron wrote:
>
>
> On 11 Mar 2024, at 18:51, Eric Garver wrote:
>
> > Kernel support has been added for this action. As such, we need to probe
> > the datapath for support.
> >
> > Signed-off-by: Eri
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 1 +
lib/dpif-netdev.c
f8acd76546000, \
location: 0xc0ee3634, protocol: 2048, reason: 196611)
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
tests/system-traffic.at | 31 +++
2 files changed, 35 insertions(+)
diff --git a/tests/system-common-macr
Kernel support has been added for this action. As such, we need to probe
the datapath for support.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 ++-
lib/dpif.h | 2 +-
ofproto/ofproto-dpif.c | 77
statements
- add format_dec_ttl_action()
v2:
- new patch (1) to fix build (switch cases)
- fixed check-system-userspace
Eric Garver (5):
dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL.
dpif: Make get_datapath_cap() access support by pointer.
dpif: Support atomic_bool field
The next commit will convert a dp feature from bool to atomic_bool. As
such we have to add support to the macros and functions. We must pass by
reference instead of pass by value because all the atomic operations
require a reference.
Signed-off-by: Eric Garver
---
ofproto/ofproto-dpif.c | 54
This avoids copying the support struct onto the stack.
Signed-off-by: Eric Garver
---
ofproto/ofproto-dpif.c | 59 +-
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index f59d69c4d1e8
On Thu, Mar 07, 2024 at 08:35:30PM +0100, Ilya Maximets wrote:
> On 3/7/24 18:08, Eric Garver wrote:
> > Kernel support has been added for this action. As such, we need to probe
> > the datapath for support.
> >
> > Signed-off-by: Eric Garver
> > ---
>
The next commit will convert a dp feature from bool to atomic_bool. As
such we have to add support to the macros and functions. We must pass by
reference instead of pass by value because all the atomic operations
require a reference.
Signed-off-by: Eric Garver
---
ofproto/ofproto-dpif.c | 52
if TC offload in use
v3:
- alter test such that it's reliable, different xlate_error
- better commit message in patch 2
- reordered _DEC_TTL value in switch statements
- add format_dec_ttl_action()
v2:
- new patch (1) to fix build (switch cases)
- fixed check-system-userspace
Eric Garver
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 1 +
lib/dpif-netdev.c
f8acd76546000, \
location: 0xc0ee3634, protocol: 2048, reason: 196611)
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
tests/system-traffic.at | 31 +++
2 files changed, 35 insertions(+)
diff --git a/tests/system-common-macr
Kernel support has been added for this action. As such, we need to probe
the datapath for support.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 ---
lib/dpif.h | 1 -
ofproto/ofproto-dpif.c | 89
This avoids copying the support struct onto the stack.
Signed-off-by: Eric Garver
---
ofproto/ofproto-dpif.c | 59 +-
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index f59d69c4d1e8
, different xlate_error
- better commit message in patch 2
- reordered _DEC_TTL value in switch statements
- add format_dec_ttl_action()
v2:
- new patch (1) to fix build (switch cases)
- fixed check-system-userspace
Eric Garver (5):
dpif: Stub out unimplemented action
This avoids copying the support struct onto the stack.
Signed-off-by: Eric Garver
---
ofproto/ofproto-dpif.c | 59 +-
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index f59d69c4d1e8
Kernel support has been added for this action. As such, we need to probe
the datapath for support.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 ---
lib/dpif.h | 1 -
ofproto/ofproto-dpif.c | 89
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 1 +
lib/dpif-netdev.c
The next commit will convert a dp feature from bool to atomic_bool. As
such we have to add support to the macros and functions. We must pass by
reference instead of pass by value because all the atomic operations
require a reference.
Signed-off-by: Eric Garver
---
ofproto/ofproto-dpif.c | 52
f8acd76546000, \
location: 0xc0ee3634, protocol: 2048, reason: 196611)
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
tests/system-traffic.at | 31 +++
2 files changed, 35 insertions(+)
diff --git a/tests/system-common-macr
On Wed, Mar 06, 2024 at 12:34:07PM -0500, Eric Garver wrote:
> Kernel support has been added for this action. As such, we need to probe
> the datapath for support.
>
> Signed-off-by: Eric Garver
> ---
> include/linux/openvswitch.h | 2 +-
> lib/dpif.c |
f8acd76546000, \
location: 0xc0ee3634, protocol: 2048, reason: 196611)
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
tests/system-traffic.at | 31 +++
2 files changed, 35 insertions(+)
diff --git a/tests/system-common-macr
The next commit will convert a dp feature from bool to atomic_bool. As
such we have to add support to the macros and functions. We must pass by
reference instead of pass by value because all the atomic operations
require a reference.
Signed-off-by: Eric Garver
---
ofproto/ofproto-dpif.c | 52
xlate_error
- better commit message in patch 2
- reordered _DEC_TTL value in switch statements
- add format_dec_ttl_action()
v2:
- new patch (1) to fix build (switch cases)
- fixed check-system-userspace
Eric Garver (4):
dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 1 +
lib/dpif-netdev.c
Kernel support has been added for this action. As such, we need to probe
the datapath for support.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 ---
lib/dpif.h | 1 -
ofproto/ofproto-dpif.c | 89
On Fri, Dec 15, 2023 at 06:02:21PM +0100, Adrian Moreno wrote:
>
>
> On 9/28/23 13:50, Eelco Chaudron wrote:
> >
> >
> > On 25 Sep 2023, at 20:04, Eric Garver wrote:
> >
> > > Kernel support has been added for this action. As such, we ne
f8acd76546000, \
location: 0xc0ee3634, protocol: 2048, reason: 196611)
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
tests/system-traffic.at | 31 +++
2 files changed, 35 insert
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
Kernel support has been added for this action. As such, we need to probe
the datapath for support.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 --
lib/dpif.h | 1 -
ofproto/ofproto-dpif.c | 42
:
- new patch (1) to fix build (switch cases)
- fixed check-system-userspace
Eric Garver (3):
dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL.
dpif: Probe support for OVS_ACTION_ATTR_DROP.
tests: system-traffic: Add coverage for drop action.
include/linux/openvswitch.h | 3
On Sat, Sep 09, 2023 at 01:41:05AM +0200, Ilya Maximets wrote:
> On 9/1/23 21:42, Eric Garver wrote:
> > Kernel support is being added for this action. As such, we need to probe
> > the datapath for support.
> >
> > Signed-off-by: Eric Garver
> > ---
>
Kernel support is being added for this action. As such, we need to probe
the datapath for support.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 -
lib/dpif.h | 1 -
ofproto/ofproto-dpif.c | 52
in switch statements
- add format_dec_ttl_action()
v2:
- new patch (1) to fix build (switch cases)
- fixed check-system-userspace
Eric Garver (3):
dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL.
dpif: Probe support for OVS_ACTION_ATTR_DROP.
tests: system-traffic: Add coverage
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
f8acd76546000, \
location: 0xc0ee3634, protocol: 2048, reason: 196611)
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
tests/system-traffic.at | 31 +++
2 files changed, 35 insert
Kernel support is being added for this action. As such, we need to probe
the datapath for support.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 --
lib/dpif.h | 1 -
ofproto/ofproto-dpif.c | 41
- better commit message in patch 2
- reordered _DEC_TTL value in switch statements
- add format_dec_ttl_action()
v2:
- new patch (1) to fix build (switch cases)
- fixed check-system-userspace
Eric Garver (3):
dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL.
dpif: Probe
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 1 +
lib/dpif-netdev.c
f8acd76546000, \
location: 0xc0ee3634, protocol: 2048, reason: 196611)
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
tests/system-traffic.at | 31 +++
2 files changed, 35 insertions(+)
diff --git a/tests/system-common-macr
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 31 +++
1 file changed, 31 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 945037ec0571..e06c0e316ff4 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
Kernel support is being added for this action. As such, we need to probe
the datapath for support.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 --
lib/dpif.h | 1 -
ofproto/ofproto-dpif.c | 41
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
1 file changed, 4 insertions(+)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index 0077a8609c02..afc0df00a329 100644
--- a/tests/system-common-macros.at
+++ b/tests/system-common-macros.at
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 1 +
lib/dpif-netdev.c
in switch statements
- add format_dec_ttl_action()
v2:
- new patch (1) to fix build (switch cases)
- fixed check-system-userspace
Eric Garver (4):
dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL.
dpif: Probe support for OVS_ACTION_ATTR_DROP.
system-common-macros: Check for drop
On Thu, Aug 03, 2023 at 01:43:40PM +0200, Ilya Maximets wrote:
> On 7/28/23 02:04, Eric Garver wrote:
> > Kernel support is being added for this action. As such, we need to probe
> > the datapath for support.
> >
> > Signed-off-by: Eric Garver
>
> Hi, Eric.
copy/paste error in the SUBJECT, but only for the cover letter.
s/v2/v3/
On Thu, Jul 27, 2023 at 08:04:42PM -0400, Eric Garver wrote:
> Probe the datapath implementation for support of OVS_ACTION_ATTR_DROP.
> Also add a new test case.
>
> v3:
> - alter test such that it's reli
Kernel support is being added for this action. As such, we need to probe
the datapath for support.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 --
lib/dpif.h | 1 -
ofproto/ofproto-dpif.c | 34
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 1 +
lib/dpif-netdev.c
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 31 +++
1 file changed, 31 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 945037ec0571..e06c0e316ff4 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
patch (1) to fix build (switch cases)
- fixed check-system-userspace
Eric Garver (4):
dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL.
dpif: Probe support for OVS_ACTION_ATTR_DROP.
system-common-macros: Check for drop action in datapath.
tests: system-traffic: Add coverage
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
1 file changed, 4 insertions(+)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index 0077a8609c02..afc0df00a329 100644
--- a/tests/system-common-macros.at
+++ b/tests/system-common-macros.at
On Mon, Jul 10, 2023 at 06:51:19PM +0200, Ilya Maximets wrote:
> On 7/8/23 00:06, Jakub Kicinski wrote:
> > On Fri, 7 Jul 2023 18:04:36 +0200 Ilya Maximets wrote:
> That already exists, right? Johannes added it in the last release for
> WiFi.
> >>>
> >>> I'm not sure. The
On Fri, Jul 07, 2023 at 02:09:49PM +0200, Eelco Chaudron wrote:
>
>
> On 7 Jul 2023, at 13:08, Ilya Maximets wrote:
>
> > On 7/5/23 21:47, Eelco Chaudron wrote:
> >>
> >>
> >> On Wed, Jul 5, 2023 at 6:46 PM Eric Garver wrote:
> >>
&g
On Thu, Jul 06, 2023 at 10:40:18AM +0200, Eelco Chaudron wrote:
>
>
> On 30 Jun 2023, at 21:05, Eric Garver wrote:
>
> > This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
> > action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
>
On Thu, Jul 06, 2023 at 08:54:16AM -0400, Aaron Conole wrote:
> Eric Garver writes:
>
> > This adds an explicit drop action. This is used by OVS to drop packets
> > for which it cannot determine what to do. An explicit action in the
> > kernel allows passing the reason _
On Wed, Jul 05, 2023 at 04:58:47PM +0200, Eelco Chaudron wrote:
>
>
> On 30 Jun 2023, at 21:05, Eric Garver wrote:
> Hi Eric,
>
> I started reviewing the series, and this test was failing every other run for
> me on ‘check-system-userspace’. I ended up making the following
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 1 +
lib/dpif-netdev.c
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 30 ++
1 file changed, 30 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 4c378e1d02b0..31c1ef46d561 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
1 file changed, 4 insertions(+)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index 0077a8609c02..afc0df00a329 100644
--- a/tests/system-common-macros.at
+++ b/tests/system-common-macros.at
Probe the datapath implementation for support of OVS_ACTION_ATTR_DROP.
Also add a new test case.
v2:
- new patch (1) to fix build (switch cases)
- fixed check-system-userspace
Eric Garver (4):
dpif: stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL
dpif: probe support
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 --
lib/dpif.h | 1 -
ofproto/ofproto-dpif.c | 34 --
4 files changed, 33 insertions(+), 10 deletions(-)
diff --git a/include/linux
On Fri, Jun 30, 2023 at 08:57:15AM +0200, Eelco Chaudron wrote:
>
>
> On 29 Jun 2023, at 22:30, Eric Garver wrote:
>
> > Probe the datapath implementation for support of OVS_ACTION_ATTR_DROP.
> > Also add a new test case.
>
>
> Hi Eric,
>
> Thanks fo
On Fri, Jun 30, 2023 at 11:47:04AM +0200, Simon Horman wrote:
> On Thu, Jun 29, 2023 at 04:30:05PM -0400, Eric Garver wrote:
> > This adds an explicit drop action. This is used by OVS to drop packets
> > for which it cannot determine what to do. An explicit action in the
> >
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 29 +
1 file changed, 29 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 4c378e1d02b0..3268d319381c 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 3 ++-
lib/dpif.c | 6 --
lib/dpif.h | 1 -
ofproto/ofproto-dpif.c | 34 --
4 files changed, 34 insertions(+), 10 deletions(-)
diff --git a/include/linux
# perf trace -e skb:kfree_skb --filter="reason >= 0x3"
[..]
106.023 ping/2465 skb:kfree_skb(skbaddr: 0xa0e8765f2000, \
location:0xc0d9b462, protocol: 2048, reason: 196610)
reason: 196610 --> 0x30002 (OVS_XLATE_RECURSION_TOO_DEEP)
Signed-off-by: Eric Garver
-
ore
traced.
Eric Garver (2):
net: openvswitch: add drop reasons
net: openvswitch: add drop action
include/net/dropreason.h | 6
include/uapi/linux/openvswitch.h | 2 ++
net/openvswitch
Probe the datapath implementation for support of OVS_ACTION_ATTR_DROP.
Also add a new test case.
Eric Garver (3):
dpif: probe support for OVS_ACTION_ATTR_DROP
system-common-macros: check for drop action in datapath
tests: system-traffic: add coverage for drop action
include/linux
These are counterparts to userspace's xlate_error values.
Signed-off-by: Eric Garver
---
include/net/dropreason.h | 6 ++
net/openvswitch/datapath.c | 17 +
net/openvswitch/drop.h | 34 ++
3 files changed, 57 insertions(+)
create mode
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
1 file changed, 4 insertions(+)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index 0077a8609c02..afc0df00a329 100644
--- a/tests/system-common-macros.at
+++ b/tests/system-common-macros.at
On Tue, Oct 27, 2020 at 10:45:17AM -0400, Mark Gray wrote:
> F32 requires the "python3-openvswitch" package now. Also, the
> iptables chain "IN_FedoraServer_allow" does not exist on Fedora 32.
>
> Signed-off-by: Mark Gray
Thanks.
Acked-by: Eric Garver
> 2. Set up IPsec tunnel.
>
> - There are three authentication methods. You can choose one to set up your
> - IPsec tunnel.
> + There are three authentication methods. Choose one method to set up your
> + IPsec tunnel and follow the steps below.
>
> a) Using pre-shared key:
>
> --
> 2.26.2
Otherwise, LGTM.
Acked-by: Eric Garver
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
1 - 100 of 340 matches
Mail list logo
