Re: [ovs-dev] [PATCH v1 ovn] ovs container build.sh requires python3

2019-10-11 Thread Han Zhou
On Fri, Oct 11, 2019 at 2:08 PM wrote: > > From: Aliasgar Ginwala > > building ovn/ovs container breaks while configure: > checking for Python 3 (version 3.4 or later)... no > configure: error: Python 3.4 or later is required but not found in >

Re: [ovs-dev] [PATCH v1] ovs container build.sh requires python3

2019-10-11 Thread Han Zhou
On Fri, Oct 11, 2019 at 2:07 PM wrote: > > From: Aliasgar Ginwala > > building ovn/ovs container breaks while configure: > checking for Python 3 (version 3.4 or later)... no > configure: error: Python 3.4 or later is required but not found in >

Re: [ovs-dev] [PATCH ovn] pinctrl: Update icmp6 header structures.

2019-10-10 Thread Han Zhou
Thanks Ilya and Mark. I verified the compiling and tests, and applied to master. On Thu, Oct 10, 2019 at 1:23 PM Mark Michelson wrote: > Thanks, Ilya, I just ran into this problem when trying to OVN :) > > Acked-by: Mark Michelson > > On 10/10/19 5:43 AM, Ilya Maximets wrote: > > commit

Re: [ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Set no-leader-only as default for clustered dbs

2019-10-03 Thread Han Zhou
On Thu, Oct 3, 2019 at 11:35 AM Ben Pfaff wrote: > > On Thu, Oct 03, 2019 at 10:19:35AM -0700, Han Zhou wrote: > > On Thu, Oct 3, 2019 at 9:09 AM Ben Pfaff wrote: > > > > > > On Tue, Oct 01, 2019 at 05:05:28PM -0700, amgin...@gmail.com wrote: > > > > Fr

Re: [ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Set no-leader-only as default for clustered dbs

2019-10-03 Thread Han Zhou
On Thu, Oct 3, 2019 at 9:09 AM Ben Pfaff wrote: > > On Tue, Oct 01, 2019 at 05:05:28PM -0700, amgin...@gmail.com wrote: > > From: Aliasgar Ginwala > > > > When using ovn-nb/sbctl running in cluster, one can use local > > socket to run different commands. It is very inconvenient to pass > >

Re: [ovs-dev] [PATCH ovn v3] Document process for compatibility between OVS and OVN.

2019-10-02 Thread Han Zhou
Thanks Mark. Please see minor comments inlined. Also: Acked-by: Han Zhou On Wed, Sep 25, 2019 at 10:33 AM Mark Michelson wrote: > > This document serves to provide an explanation for how OVN will remain > compatible with OVS. It provides instructions for OVN contributors for > how

Re: [ovs-dev] [PATCH v2] Modify release document for OVN.

2019-10-02 Thread Han Zhou
| > +| T + 2.5 | Feb 8, May 8 | Fork branch-x.y from master | T + 1.25 > +---++--+ > -| T + 5.5 | Aug 15, Feb 15 | Release version x.y.0| > +| T + 2.75 | Feb 22, May 22 | Release version x.y.0| > +---++--+ > T + 1.75 So we are not only shortening the release cycle but also shortening the time required for branching and releasing. I am ok with that. Acked-by: Han Zhou ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Set no-leader-only as default for clustered dbs

2019-10-02 Thread Han Zhou
/* --leader-only, --no-leader-only: Only accept the leader in a cluster. */ > -static int leader_only = true; > +static int leader_only = false; > > static void sbctl_cmd_init(void); > OVS_NO_RETURN static void usage(void); > -- > 2.20.1 (Apple Git-117) > > ___

Re: [ovs-dev] [PATCH ovn v1] Documentation cleanup: sandbox

2019-10-01 Thread Han Zhou
On Tue, Oct 1, 2019 at 8:10 AM Flavio Fernandes wrote: > > Fix ovn-sandbox documentation with regards to SANDBOXFLAGS. That > is, the sandbox in this repo will actually fail if we attempt to > start it with the --ovn flag. > > Signed-off-by: Flavio Fernandes > --- >

Re: [ovs-dev] [PATCH ovn] Partially revert "Exclude inport and outport symbol tables from conjunction."

2019-10-01 Thread Han Zhou
On Mon, Sep 30, 2019 at 6:51 AM wrote: > > From: Numan Siddique > > This partially revers the commit - 298701dbc99645700be41680a43d049cb061847a > as the commit [1] disables the conjunction. > > We still need the changes to the tests/ovn.at file. > > CC: Han Zhou >

[ovs-dev] [RFC PATCH ovn 09/10] ovn-ic: Interconnection gateway controller.

2019-09-27 Thread Han Zhou
From: Han Zhou Sync local and remote gateways between SB and ISB. Signed-off-by: Han Zhou --- ic/ovn-ic.c | 94 + 1 file changed, 94 insertions(+) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index 4de3e17..ddc9d0a 100644 --- a/ic/ovn

[ovs-dev] [RFC PATCH ovn 10/10] ovn-ic: Interconnection port controller.

2019-09-27 Thread Han Zhou
From: Han Zhou Sync interconnection logical ports and bindings between NB, SB and ISB. With this patch, the OVN interconnection works end to end. Signed-off-by: Han Zhou --- controller/binding.c | 6 +- ic/ovn-ic.c| 342 + lib

[ovs-dev] [RFC PATCH ovn 08/10] ovn-sb: Add columns is_interconn and is_remote to Chassis.

2019-09-27 Thread Han Zhou
From: Han Zhou Support the new columns in Chassis table for OVN interconnection. Also, populate the is_interconn column according to external_ids: is-interconn key of Open_vSwitch table on the chassis. Signed-off-by: Han Zhou --- controller/chassis.c | 14 ++ northd/ovn-northd.c

[ovs-dev] [RFC PATCH ovn 07/10] ovn-ic: Transit switch controller.

2019-09-27 Thread Han Zhou
From: Han Zhou Processing transit switches and sync between INB, ISB and NB. Signed-off-by: Han Zhou --- ic/ovn-ic.c | 113 northd/ovn-northd.c | 8 2 files changed, 121 insertions(+) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c

[ovs-dev] [RFC PATCH ovn 04/10] ovn-isb: Interconnection southbound DB schema and CLI.

2019-09-27 Thread Han Zhou
From: Han Zhou This patch introduces OVN_IC_Southbound DB schema and the CLI ovn-isbctl that manages the DB. Signed-off-by: Han Zhou --- .gitignore | 3 + automake.mk| 38 ++ debian/ovn-common.install | 1 + debian/ovn-common.manpages | 2 + lib

[ovs-dev] [RFC PATCH ovn 05/10] ovn-ic: Interconnection controller with AZ registeration.

2019-09-27 Thread Han Zhou
From: Han Zhou This patch introduces interconnection controller, ovn-ic, and implements the basic AZ registration feature: taking the AZ name from NB DB and create an Availability_Zone entry in IC-SB DB. Signed-off-by: Han Zhou --- Makefile.am | 1 + ic/.gitignore| 2

[ovs-dev] [RFC PATCH ovn 06/10] ovn-northd.c: Refactor allocate_tnlid.

2019-09-27 Thread Han Zhou
From: Han Zhou Move allocate_tnlid() and related interfaces to ovn_util module, so that they be reused by ovn-ic (in next patches). At the same time, define macros for the range of datapath tunnel keys, and reserve a range with ((1u << 16) - 1) keys for global transit switch datapaths,

[ovs-dev] [RFC PATCH ovn 03/10] ovn-inb: Interconnection northbound DB schema and CLI.

2019-09-27 Thread Han Zhou
From: Han Zhou This patch introduces OVN_IC_Northbound DB schema and the CLI ovn-inbctl that manages the DB. Signed-off-by: Han Zhou --- .gitignore | 3 + automake.mk| 37 ++ debian/ovn-common.install | 1 + debian/ovn-common.manpages | 2 + lib

[ovs-dev] [RFC PATCH ovn 02/10] ovn-architecture: Add documentation for OVN interconnection feature.

2019-09-27 Thread Han Zhou
From: Han Zhou Signed-off-by: Han Zhou --- ovn-architecture.7.xml | 107 - 1 file changed, 106 insertions(+), 1 deletion(-) diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml index 7966b65..56b2167 100644 --- a/ovn-architecture.7.xml

[ovs-dev] [RFC PATCH ovn 01/10] ovn-northd.c: Fix datapath tunnel key allocation.

2019-09-27 Thread Han Zhou
From: Han Zhou The max tunnel key for datapath is defined as (1u << 24) - 1, but we are using uint16_t variable to hold the value, which will result in duplicated key when there are enough number of datapath key allocation and deletions. Signed-off-by: Han Zhou --- northd/ovn-northd

[ovs-dev] [RFC PATCH ovn 00/10] OVN Interconnection

2019-09-27 Thread Han Zhou
n az1, add below route: ovn-nbctl lr-route-add lr1 10.0.2.0/24 169.254.100.2 # In az1, add below route: ovn-nbctl lr-route-add lr1 10.0.1.0/24 169.254.100.1 9. Try ping between the workloads in different OVNs. Han Zhou (10): ovn-northd.c: Fix datapath tunnel key allocation. ovn-ar

Re: [ovs-dev] [PATCH 1/2] ovsdb-cluster: Use ovs-vsctl instead of ovn-nbctl and ovn-sbctl.

2019-09-27 Thread Han Zhou
only(idl, leader_only); > run_prerequisites(commands, n_commands, idl); > > /* Execute the commands. > @@ -225,6 +243,10 @@ parse_options(int argc, char *argv[], struct shash *local_options) > {"help", no_argument, NULL, 'h'}, > {"commands&

Re: [ovs-dev] [PATCH ovn] Disable conjunction by force cross product for all the fields.

2019-09-27 Thread Han Zhou
On Fri, Sep 27, 2019 at 9:42 AM Numan Siddique wrote: > > > On Fri, Sep 27, 2019 at 10:05 PM Han Zhou wrote: > >> Thanks Numan. This is cleaner than the RFC. At the same time, shall we >> revert the change of commit: 298701dbc996, which is covered by this change? >

Re: [ovs-dev] [PATCH ovn] Disable conjunction by force cross product for all the fields.

2019-09-27 Thread Han Zhou
Thanks Numan. This is cleaner than the RFC. At the same time, shall we revert the change of commit: 298701dbc996, which is covered by this change? (It is better to maintain one temporary workaround than two) Acked-by: Han Zhou On Fri, Sep 27, 2019 at 8:52 AM wrote: > From: Numan Siddi

Re: [ovs-dev] [RFC PATCH ovn] Disable conjunction

2019-09-27 Thread Han Zhou
Thanks Numan. It looks good to me. Is there a reason why this is RFC? On Wed, Sep 25, 2019 at 1:48 AM wrote: > From: Numan Siddique > > The commit 298701dbc996("Exclude inport and outport symbol tables from > conjunction") > was earlier added to disable conjunction for inport and outport

Re: [ovs-dev] [PATCH ovn v3] Learn the mac binding only if required

2019-09-27 Thread Han Zhou
ulates with flows generated from the MAC_Binding > +table in the OVN Southbound database. If there is a match in table > +66, then its actions set the logical flow flag MLF_LOOKUP_MAC. A typo here: s/66/67 Otherwise looks good to me. Acked-by: Han Zhou

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Add Han Zhou.

2019-09-23 Thread Han Zhou
On Mon, Sep 23, 2019 at 12:08 PM Ben Pfaff wrote: > Han was elected by the OVN committers on Sept. 23. Welcome to the > team, Han! > > CC: Han Zhou > Signed-off-by: Ben Pfaff > --- > MAINTAINERS.rst | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAI

Re: [ovs-dev] [PATCH ovn] Exclude inport and outport symbol tables from conjunction

2019-09-19 Thread Han Zhou
On Wed, Sep 18, 2019 at 2:51 AM Dumitru Ceara wrote: > > On Wed, Sep 18, 2019 at 9:30 AM Dumitru Ceara wrote: > > > > On Tue, Sep 17, 2019 at 6:49 PM Han Zhou wrote: > > > > > > > > > > > > On Tue, Sep 17, 2019 at 5:21 AM Mark Michelson

Re: [ovs-dev] [PATCH v1 ovn] ovn-ctl: Support passing ssl certs for northd

2019-09-17 Thread Han Zhou
n-northd-ssl-key=KEY OVN Northd SSL private key file > + --ovn-northd-ssl-cert=CERT OVN Northd SSL certificate file > + --ovn-northd-ssl-ca-cert=CERT OVN Northd SSL CA certificate file >--ovn-manage-ovsdb=yes|noWhether or not the OVN databases should be >

Re: [ovs-dev] [PATCH ovn v2] Learn the mac binding only if required

2019-09-17 Thread Han Zhou
0=0xaca8006f,reg14=0x3,metadata=0x3,dl_src=00:44:00:00:00:04 > actions=load:1->NXM_NX_REG2[0] > > This patch should also address the issue reported in 'Reported-at' > > Reported-at: https://bugzilla.redhat.com/1729846 > Reported-by: Haidong Li > CC: Han ZHou &

Re: [ovs-dev] [PATCH ovn] Exclude inport and outport symbol tables from conjunction

2019-09-17 Thread Han Zhou
On Tue, Sep 17, 2019 at 5:21 AM Mark Michelson wrote: > > On 9/16/19 12:04 PM, Han Zhou wrote: > > > > > > On Mon, Sep 16, 2019 at 4:15 AM Dumitru Ceara > <mailto:dce...@redhat.com>> wrote: > > > > > > On Sat, Sep 14, 2019 at

Re: [ovs-dev] [PATCH ovn] Exclude inport and outport symbol tables from conjunction

2019-09-16 Thread Han Zhou
On Mon, Sep 16, 2019 at 4:15 AM Dumitru Ceara wrote: > > On Sat, Sep 14, 2019 at 7:16 PM Han Zhou wrote: > > > > > > > > On Sat, Sep 14, 2019 at 9:09 AM Han Zhou wrote: > > > > > > > > > > > > On Sat, Sep 14, 2019 at 12:40 AM Num

Re: [ovs-dev] [PATCH ovn] Exclude inport and outport symbol tables from conjunction

2019-09-14 Thread Han Zhou
On Sat, Sep 14, 2019 at 9:09 AM Han Zhou wrote: > > > > On Sat, Sep 14, 2019 at 12:40 AM Numan Siddique wrote: > > > > > > > > On Sat, Sep 14, 2019 at 2:41 AM Daniel Alvarez Sanchez < dalva...@redhat.com> wrote: > >> > >> Acked-by: Dan

Re: [ovs-dev] [PATCH ovn] Exclude inport and outport symbol tables from conjunction

2019-09-14 Thread Han Zhou
On Sat, Sep 14, 2019 at 12:40 AM Numan Siddique wrote: > > > > On Sat, Sep 14, 2019 at 2:41 AM Daniel Alvarez Sanchez < dalva...@redhat.com> wrote: >> >> Acked-by: Daniel Alvarez >> >> >> On Fri, Sep 13, 2019 at 11:02 PM Mark Michelson wrote: >> > >> > Acked-by: Mark Michelson >> > >> > It

Re: [ovs-dev] [PATCH v3 ovn 0/2] ovn-controller: Logical flow processing optimizations

2019-09-12 Thread Han Zhou
f OVS. > _______ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Thanks Dumitru. For the series: Acked-by: Han Zhou ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [RFC v2] Document process for compatibility between OVS and OVN.

2019-09-12 Thread Han Zhou
On Thu, Sep 12, 2019 at 2:00 PM Mark Michelson wrote: > > On 9/12/19 4:51 PM, Han Zhou wrote: > > Thanks Mark for writing this up. > > > > On Fri, Sep 6, 2019 at 2:08 PM Mark Michelson > <mailto:mmich...@redhat.com>> wrote: > > > > > > This

Re: [ovs-dev] [RFC v2] Document process for compatibility between OVS and OVN.

2019-09-12 Thread Han Zhou
Thanks Mark for writing this up. On Fri, Sep 6, 2019 at 2:08 PM Mark Michelson wrote: > > This document serves to provide an explanation for how OVN will remain > compatible with OVS. It provides instructions for OVN contributors for > how to maintain compatibility even across older versions of

Re: [ovs-dev] [PATCH ovn] Learn the mac binding only if required

2019-09-12 Thread Han Zhou
h the match reg0 = ip && eth.src = mac with > the action - eth.dst = mac > > Eg: > table=31, priority=100,arp,reg0=0xaca8006f,reg14=0x3,metadata=0x3,dl_src=00:44:00:00:00:04 > actions=mod_dl_dst:00:44:00:00:00:04 > > This patch should also address the issue repor

Re: [ovs-dev] Hypervisor down during upgrade OVS 2.10.x to 2.10.y

2019-09-06 Thread Han Zhou
Good finding. So it is a known kernel bug and it won't get fixed in that kernel version. :( >From OVS point of view, the problem is, if such bug exists in kernel, it prevents ovs-vswitchd to be killed (even by SIGKILL) because the process is in system call which got blocked because of the kernel

Re: [ovs-dev] [branch-2.11 1/2] Set release date for 2.11.2.

2019-09-05 Thread Han Zhou
On Tue, Sep 3, 2019 at 3:10 PM Justin Pettit wrote: > > Signed-off-by: Justin Pettit > --- > NEWS | 3 ++- > debian/changelog | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index ff2647739375..f2d44e4630bb 100644 > --- a/NEWS > +++ b/NEWS >

Re: [ovs-dev] [PATCH ovn] Handle GARP reply packets from provider networks only on gateway chassis

2019-09-04 Thread Han Zhou
n if ovn-controller > wakes up, thanks to incremental processing engine. But in the older > versions - 2.11, 2.10 and 2.9, this results in complete flow calculations > resulting in much more CPU cyles. This patch will definitely help in saving > these CPU cyles if backported. > >

Re: [ovs-dev] [ovs-discuss] ovn-controller is taking 100% CPU all the time in one deployment

2019-09-04 Thread Han Zhou
On Sat, Aug 31, 2019 at 12:00 AM Numan Siddique wrote: > > > > On Sat, Aug 31, 2019 at 2:05 AM Han Zhou wrote: >> >> >> >> On Fri, Aug 30, 2019 at 1:25 PM Numan Siddique wrote: >> > >> > Hi Han, >> > >> > I am thinking of t

Re: [ovs-dev] ovn-controller is taking 100% CPU all the time in one deployment

2019-08-30 Thread Han Zhou
On Thu, Aug 29, 2019 at 11:36 PM Numan Siddique wrote: > > > > On Fri, Aug 30, 2019 at 1:04 AM Han Zhou wrote: >> >> >> >> On Thu, Aug 29, 2019 at 12:16 PM Numan Siddique wrote: >>> >>> >>> >>> On Fri, Aug 30, 2019 at 12:

Re: [ovs-dev] [ovs-discuss] ovn-controller is taking 100% CPU all the time in one deployment

2019-08-30 Thread Han Zhou
On Fri, Aug 30, 2019 at 1:25 PM Numan Siddique wrote: > > Hi Han, > > I am thinking of this approach to solve this problem. I still need to test it. > If you have any comments or concerns do let me know. > > > ** > diff --git a/northd/ovn-northd.c

Re: [ovs-dev] [ovs-discuss] ovn-controller is taking 100% CPU all the time in one deployment

2019-08-30 Thread Han Zhou
On Fri, Aug 30, 2019 at 6:46 AM Mark Michelson wrote: > > On 8/30/19 5:39 AM, Daniel Alvarez Sanchez wrote: > > On Thu, Aug 29, 2019 at 10:01 PM Mark Michelson wrote: > >> > >> On 8/29/19 2:39 PM, Numan Siddique wrote: > >>> Hello Everyone, > >>> > >>> In one of the OVN deployments, we are

Re: [ovs-dev] [PATCH v9] ovsdb-tool: Convert clustered db to standalone db.

2019-08-29 Thread Han Zhou
transact unix:socket "$txn"], [0], [ignore], [ignore]) > +done > +AT_CHECK([ovsdb-client transact unix:socket '[["ordinals"]]'], [0], > + [ignore], [ignore]) > +AT_CHECK([ovsdb-client dump unix:socket > clusterdump]) > +AT_CHECK([ovs-appctl -t ovsdb-s

Re: [ovs-dev] [PATCH v6] ovsdb-tool: Convert clustered db to standalone db.

2019-08-29 Thread Han Zhou
On Thu, Aug 29, 2019 at 1:14 PM wrote: > > From: Aliasgar Ginwala > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > E.g. usage to migrate nb/sb db to standalone db from raft: > ovsdb-tool cluster-to-standalone ovnnb_db.db ovnnb_db_cluster.db > > Signed-off-by:

Re: [ovs-dev] ovn-controller is taking 100% CPU all the time in one deployment

2019-08-29 Thread Han Zhou
On Thu, Aug 29, 2019 at 12:16 PM Numan Siddique wrote: > > > On Fri, Aug 30, 2019 at 12:37 AM Han Zhou wrote: > >> >> >> On Thu, Aug 29, 2019 at 11:40 AM Numan Siddique >> wrote: >> > >> > Hello Everyone, >> > >> &g

Re: [ovs-dev] ovn-controller is taking 100% CPU all the time in one deployment

2019-08-29 Thread Han Zhou
On Thu, Aug 29, 2019 at 11:40 AM Numan Siddique wrote: > > Hello Everyone, > > In one of the OVN deployments, we are seeing 100% CPU usage by ovn-controllers all the time. > > After investigations we found the below > > - ovn-controller is taking more than 20 seconds to complete full loop

Re: [ovs-dev] [PATCH v5] ovsdb-tool: Convert clustered db to standalone db.

2019-08-29 Thread Han Zhou
Thanks for the update. Please see some minor comments below, mostly naming and documentation. On Wed, Aug 28, 2019 at 6:32 PM wrote: > > From: Aliasgar Ginwala > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > E.g. usage to migrate nb/sb db to standalone db from

Re: [ovs-dev] [PATCH v1] ovsdb.7.rst: some corrections in ovsdb-client usage.

2019-08-23 Thread Han Zhou
rading a Database > --- > -- > 2.20.1 (Apple Git-117) > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Acked-by: Han Zhou _

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-23 Thread Han Zhou
On Thu, Aug 22, 2019 at 10:29 PM aginwala aginwala wrote: > Thanks for the review Han. > > On Thu, Aug 22, 2019 at 7:27 PM Han Zhou wrote: > >> Ali, thanks for the patch. Please see my comments below. >> >> On Thu, Aug 22, 2019 at 5:53 PM wrote: >> > >

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-22 Thread Han Zhou
Ali, thanks for the patch. Please see my comments below. On Thu, Aug 22, 2019 at 5:53 PM wrote: > > From: Aliasgar Ginwala > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > E.g. usage to migrate nb/sb db to standalone db from raft: > ovsdb-tool migrate-cluster-db

Re: [ovs-dev] [PATCH v3 5/5] ovsdb raft: Support leader election time change online.

2019-08-22 Thread Han Zhou
On Mon, Aug 19, 2019 at 9:30 AM Han Zhou wrote: > > From: Han Zhou > > A new unixctl command cluster/change-election-timer is implemented to > change leader election timeout base value according to the scale needs. > > The change takes effect upon consensus of the cluster

[ovs-dev] [PATCH 3/3] ovsdb.5.rst: Fix minor format problem.

2019-08-22 Thread Han Zhou
From: Han Zhou Signed-off-by: Han Zhou --- Documentation/ref/ovsdb.5.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/ref/ovsdb.5.rst b/Documentation/ref/ovsdb.5.rst index bb35eee..46d268c 100644 --- a/Documentation/ref/ovsdb.5.rst +++ b/Documentation

[ovs-dev] [PATCH 2/3] raft: Save and read new election timer in header snapshot.

2019-08-22 Thread Han Zhou
From: Han Zhou This patch store the latest election timer in snapshot during log compression, and when server restarts it reads the value from the log. Without this, any previous changes to election timer will be lost in the log, and if server restarts, it will use the default value instead

[ovs-dev] [PATCH 1/3] raft.c: Election timer initial reset with value from log.

2019-08-22 Thread Han Zhou
From: Han Zhou After election timer is changed through cluster/change-election-timer command, if a server restarts, it firstly initializes with the default value and use it to reset the timer. Although it reads the latest timer value later from the log, the first timeout may be much shorter than

Re: [ovs-dev] [PATCH v2 ovn 0/5] External OVS source support and separate run dir for OVN

2019-08-22 Thread Han Zhou
On Wed, Aug 21, 2019 at 11:59 PM Numan Siddique wrote: > > > > On Thu, Aug 22, 2019 at 12:27 PM Numan Siddique wrote: >> >> >> >> On Thu, Aug 22, 2019 at 2:19 AM Han Zhou wrote: >>> >>> >>> >>> On Wed, Aug 21, 2019 at 11:5

Re: [ovs-dev] [PATCH v2 ovn 0/5] External OVS source support and separate run dir for OVN

2019-08-21 Thread Han Zhou
On Wed, Aug 21, 2019 at 11:54 AM Numan Siddique wrote: > > > > On Wed, Aug 21, 2019 at 10:30 PM Han Zhou wrote: >> >> >> >> On Mon, Aug 19, 2019 at 11:13 AM wrote: >> > >> > From: Numan Siddique >> > >> > This p

Re: [ovs-dev] [PATCH v3 2/5] ovsdb-idl.c: Allows retry even when using a single remote.

2019-08-21 Thread Han Zhou
On Wed, Aug 21, 2019 at 11:59 AM Ben Pfaff wrote: > > On Wed, Aug 21, 2019 at 11:27:58AM -0700, Ben Pfaff wrote: > > On Wed, Aug 21, 2019 at 11:21:12AM -0700, Han Zhou wrote: > > > On Wed, Aug 21, 2019 at 11:13 AM Ben Pfaff wrote: > > > > > > > >

Re: [ovs-dev] [PATCH v3 2/5] ovsdb-idl.c: Allows retry even when using a single remote.

2019-08-21 Thread Han Zhou
On Wed, Aug 21, 2019 at 11:13 AM Ben Pfaff wrote: > > On Mon, Aug 19, 2019 at 09:29:57AM -0700, Han Zhou wrote: > > From: Han Zhou > > > > When clustered mode is used, the client needs to retry connecting > > to new servers when certain failures happen. Today

Re: [ovs-dev] [PATCH v2 ovn 0/5] External OVS source support and separate run dir for OVN

2019-08-21 Thread Han Zhou
On Mon, Aug 19, 2019 at 11:13 AM wrote: > > From: Numan Siddique > > This patch series adds support for building OVN from external OVS > sources. > > The first patch adds the support to compile OVN from external OVS sources. > The following configuration options are added when configuring OVN >

Re: [ovs-dev] [PATCH v1] ovs-lib: Fix standalone db migration to raft

2019-08-20 Thread Han Zhou
t; > fi > -- > 2.20.1 (Apple Git-117) > > _______ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Thanks Aliasgar. Acked-by: Han Zhou ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] ovsdb monitor: Fix crash when using non-zero last-id with standalone DB.

2019-08-19 Thread Han Zhou
From: Han Zhou When a client uses monitor-cond-since with a non-zero last-id but the server is not in cluster mode for the DB being monitored, it leads to segmentation fault because the txn_history list is not initialized in this case. Program terminated with signal SIGSEGV, Segmentation fault

Re: [ovs-dev] [PATCH v2 1/4] raft.c: Move raft_reset_ping_timer() out of the loop.

2019-08-19 Thread Han Zhou
is optional. Thanks, Han On Wed, Aug 14, 2019 at 3:37 PM Han Zhou wrote: > From: Han Zhou > > Fixes: commit 5a9b53a5 ("ovsdb raft: Fix duplicated transaction execution > when leader failover.") > Signed-off-by: Han Zhou > --- > ovsdb/raft.c | 2 +- > 1 file c

[ovs-dev] [PATCH v3 5/5] ovsdb raft: Support leader election time change online.

2019-08-19 Thread Han Zhou
From: Han Zhou A new unixctl command cluster/change-election-timer is implemented to change leader election timeout base value according to the scale needs. The change takes effect upon consensus of the cluster, implemented through the append-request RPC. A new field "election-timer"

[ovs-dev] [PATCH v3 4/5] raft.c: Set candidate_retrying if no leader elected since last election.

2019-08-19 Thread Han Zhou
From: Han Zhou candiate_retrying is used to determine if the current node is disconnected from the cluster when the node is in candiate role. However, a node can flap between candidate and follower role before a leader is elected when majority of the cluster is down, so is_connected() will flap

[ovs-dev] [PATCH v3 3/5] raft.c: Stale leader should disconnect from cluster.

2019-08-19 Thread Han Zhou
From: Han Zhou As mentioned in RAFT paper, section 6.2: Leaders: A server might be in the leader state, but if it isn’t the current leader, it could be needlessly delaying client requests. For example, suppose a leader is partitioned from the rest of the cluster, but it can still communicate

[ovs-dev] [PATCH v3 2/5] ovsdb-idl.c: Allows retry even when using a single remote.

2019-08-19 Thread Han Zhou
From: Han Zhou When clustered mode is used, the client needs to retry connecting to new servers when certain failures happen. Today it is allowed to retry new connection only if multiple remotes are used, which prevents using LB VIP with clustered nodes. This patch makes sure the retry logic

[ovs-dev] [PATCH v3 1/5] raft.c: Move raft_reset_ping_timer() out of the loop.

2019-08-19 Thread Han Zhou
From: Han Zhou Fixes: commit 5a9b53a5 ("ovsdb raft: Fix duplicated transaction execution when leader failover.") Signed-off-by: Han Zhou --- ovsdb/raft.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/raft.c b/ovsdb/raft.c index c60ef41..1c38b3b 100644 -

Re: [ovs-dev] [PATCH ovn v2] OVN: Fix learning of neighbors from ARP/ND packets.

2019-08-15 Thread Han Zhou
On Wed, Aug 14, 2019 at 11:11 PM Dumitru Ceara wrote: > > On Thu, Aug 8, 2019 at 1:52 AM Han Zhou wrote: > > > > > > > > On Wed, Aug 7, 2019 at 8:12 AM Dumitru Ceara wrote: > >> > >> On Mon, Aug 5, 2019 at 5:34 PM Han Zhou wrote: > >&

Re: [ovs-dev] [PATCH 3/4] raft.c: Set candidate_retrying if no leader elected since last election.

2019-08-14 Thread Han Zhou
On Tue, Aug 13, 2019 at 9:23 AM Han Zhou wrote: > > From: Han Zhou > > candiate_retrying is used to determine if the current node is disconnected > from the cluster when the node is in candiate role. However, a node > can flap between candidate and follower role before a leader

[ovs-dev] [PATCH v2 4/4] raft.c: Set candidate_retrying if no leader elected since last election.

2019-08-14 Thread Han Zhou
From: Han Zhou candiate_retrying is used to determine if the current node is disconnected from the cluster when the node is in candiate role. However, a node can flap between candidate and follower role before a leader is elected when majority of the cluster is down, so is_connected() will flap

[ovs-dev] [PATCH v2 3/4] raft.c: Stale leader should disconnect from cluster.

2019-08-14 Thread Han Zhou
From: Han Zhou As mentioned in RAFT paper, section 6.2: Leaders: A server might be in the leader state, but if it isn’t the current leader, it could be needlessly delaying client requests. For example, suppose a leader is partitioned from the rest of the cluster, but it can still communicate

[ovs-dev] [PATCH v2 2/4] ovsdb-idl.c: Allows retry even when using a single remote.

2019-08-14 Thread Han Zhou
From: Han Zhou When clustered mode is used, the client needs to retry connecting to new servers when certain failures happen. Today it is allowed to retry new connection only if multiple remotes are used, which prevents using LB VIP with clustered nodes. This patch makes sure the retry logic

[ovs-dev] [PATCH v2 1/4] raft.c: Move raft_reset_ping_timer() out of the loop.

2019-08-14 Thread Han Zhou
From: Han Zhou Fixes: commit 5a9b53a5 ("ovsdb raft: Fix duplicated transaction execution when leader failover.") Signed-off-by: Han Zhou --- ovsdb/raft.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/raft.c b/ovsdb/raft.c index c60ef41..1c38b3b 100644 -

Re: [ovs-dev] [PATCH 2/4] ovsdb-idl.c: Allows retry even when using a single remote.

2019-08-14 Thread Han Zhou
if we use this >> approach, idl will show ovn-nbctl: tcp::6641: database connection >> failed () if requests reaches followers and only processes success if >> request reaches leader node with this patch. >> >> >> On Tue, Aug 13, 2019 at 9:23 AM Han Zhou wr

Re: [ovs-dev] [PATCH 4/4] raft.c: Stale leader should disconnect from cluster.

2019-08-13 Thread Han Zhou
On Tue, Aug 13, 2019 at 9:23 AM Han Zhou wrote: > > From: Han Zhou > > As mentioned in RAFT paper, section 6.2: > > Leaders: A server might be in the leader state, but if it isn’t the current > leader, it could be needlessly delaying client requests. For exampl

[ovs-dev] [PATCH 4/4] raft.c: Stale leader should disconnect from cluster.

2019-08-13 Thread Han Zhou
From: Han Zhou As mentioned in RAFT paper, section 6.2: Leaders: A server might be in the leader state, but if it isn’t the current leader, it could be needlessly delaying client requests. For example, suppose a leader is partitioned from the rest of the cluster, but it can still communicate

[ovs-dev] [PATCH 3/4] raft.c: Set candidate_retrying if no leader elected since last election.

2019-08-13 Thread Han Zhou
From: Han Zhou candiate_retrying is used to determine if the current node is disconnected from the cluster when the node is in candiate role. However, a node can flap between candidate and follower role before a leader is elected when majority of the cluster is down, so is_connected() will flap

[ovs-dev] [PATCH 2/4] ovsdb-idl.c: Allows retry even when using a single remote.

2019-08-13 Thread Han Zhou
From: Han Zhou When clustered mode is used, the client needs to retry connecting to new servers when certain failures happen. Today it is allowed to retry new connection only if multiple remotes are used, which prevents using LB VIP with clustered nodes. This patch makes sure the retry logic

[ovs-dev] [PATCH 1/4] raft.c: Move raft_reset_ping_timer() out of the loop.

2019-08-13 Thread Han Zhou
From: Han Zhou Fixes: commit 5a9b53a5 ("ovsdb raft: Fix duplicated transaction execution when leader failover.") Signed-off-by: Han Zhou --- ovsdb/raft.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/raft.c b/ovsdb/raft.c index c60ef41..1c38b3b 100644 -

Re: [ovs-dev] [PATCH] Prevent erroneous duplicate IP address messages.

2019-08-08 Thread Han Zhou
vswitch.org/mailman/listinfo/ovs-dev 0-day robot was complaining because "ovn" was missing in the title. LGTM Acked-by: Han Zhou ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] Add OVN schema version checks in Makefile.am

2019-08-08 Thread Han Zhou
/build-aux/cksum-schema-check $? $@ > + > +CLEANFILES += ovn-sb.ovsschema.stamp > + > include Documentation/automake.mk > include m4/automake.mk > include lib/automake.mk > -- > 2.21.0 > > _______ > dev mailing list > d

Re: [ovs-dev] [PATCH ovn v2] OVN: Fix learning of neighbors from ARP/ND packets.

2019-08-07 Thread Han Zhou
On Wed, Aug 7, 2019 at 8:12 AM Dumitru Ceara wrote: > On Mon, Aug 5, 2019 at 5:34 PM Han Zhou wrote: > > > > > > > > On Mon, Aug 5, 2019 at 1:06 AM Dumitru Ceara wrote: > > > > > > On Mon, Aug 5, 2019 at 1:41 AM Han Zhou wrote: > > > >

[ovs-dev] [PATCH branch 2.12] ovn-controller: Fix inject-pkt command error response.

2019-08-05 Thread Han Zhou
From: Han Zhou From: Han Zhou When using unixctl command inject-packet, it always respond with failure "server not ready", although the command was actually executed successfully. Fixes: 0bd4d85c36ef ("ovn-controller: Initial use of incremental engine - quiet mode.") Sig

Re: [ovs-dev] [PATCH] ovn-controller: Fix flow installation latency caused by recompute.

2019-08-05 Thread Han Zhou
I resent it for backporting to 2.12 as a series followed by a fix from Dumitru, which has been merged in OVN repo, too. https://patchwork.ozlabs.org/project/openvswitch/list/?series=123382 Thanks Dumitru again for the fix. On Tue, Jul 30, 2019 at 12:16 AM Han Zhou wrote: > Thanks M

[ovs-dev] [PATCH branch 2.12 1/2] ovn-controller: Fix flow installation latency caused by recompute.

2019-08-05 Thread Han Zhou
From: Han Zhou When there are in-flight flow-installations pending to ovs-vswitchd, current incremental processing logic prioritizes new change handling. However, in scenarios where frequent recomputes are triggered, the later recompute would block the flow-installation for previously computed

[ovs-dev] [PATCH branch 2.12 2/2] ovn-controller: Fix IP engine run with in-flight messages

2019-08-05 Thread Han Zhou
logical flows and openflow flows due to the fact that the rerun wasn't happening after an aborted run. In order to avoid confusion the engine_aborted variable is now renamed to engine_run_done thus avoiding the negated logic. CC: Han Zhou Fixes: a6b7d9f4f047 ("ovn-controller: Fix flow install

Re: [ovs-dev] [PATCH ovn v2] OVN: Fix learning of neighbors from ARP/ND packets.

2019-08-05 Thread Han Zhou
On Mon, Aug 5, 2019 at 1:06 AM Dumitru Ceara wrote: > > On Mon, Aug 5, 2019 at 1:41 AM Han Zhou wrote: > > > > > > > > On Mon, Jul 29, 2019 at 2:30 AM Dumitru Ceara wrote: > > > > > > Add a restriction on the target protocol addresses to matc

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix inject-pkt command error response.

2019-08-05 Thread Han Zhou
On Mon, Aug 5, 2019 at 6:53 AM Numan Siddique wrote: > > > > On Mon, Aug 5, 2019 at 1:43 PM Dumitru Ceara wrote: >> >> On Mon, Aug 5, 2019 at 9:29 AM Han Zhou wrote: >> > >> > From: Han Zhou >> > >> > When using unixctl comman

[ovs-dev] [PATCH ovn] ovn-controller: Fix inject-pkt command error response.

2019-08-05 Thread Han Zhou
From: Han Zhou When using unixctl command inject-packet, it always respond with failure "server not ready", although the command was actually executed successfully. Fixes: 0bd4d85c36ef ("ovn-controller: Initial use of incremental engine - quiet mode.") Signed-off-by: Han Z

Re: [ovs-dev] [PATCH ovn v2] OVN: Fix learning of neighbors from ARP/ND packets.

2019-08-04 Thread Han Zhou
ps > that are only reachable via a port but can't be directly resolved > through route lookups. Such support was introduced by commit: > > 6b785fd8fe29 ("ovn-util: Allow /32 IP addresses for router ports.") > > Reported-at: https://bugzilla.redhat.com/1729846 > Reported-

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix IP engine run with in-flight messages

2019-08-04 Thread Han Zhou
n was completed. > > This was causing discrepancies between logical flows and openflow flows > due to the fact that the rerun wasn't happening after an aborted run. > > In order to avoid confusion the engine_aborted variable is now renamed to > engine_run_done thus avoiding th

Re: [ovs-dev] [PATCH] ovn-northd: Fix ARP respond flows flapping.

2019-08-01 Thread Han Zhou
On Thu, Jul 25, 2019 at 4:03 PM Han Zhou wrote: > > From: Han Zhou > > From ovn-controller debug log it is seen that when creating a lsp > in NB, a lflow for ARP respond is added and then deleted in SB > by northd (the flow will be added again when the port is bound > to a

Re: [ovs-dev] [PATCH] ovn-controller: Fix flow installation latency caused by recompute.

2019-07-30 Thread Han Zhou
5/19 4:16 PM, Mark Michelson wrote: > > Acked-by: Mark Michelson > > > > Thanks for the informative commit message! > > > > On 7/23/19 10:52 PM, Han Zhou wrote: > >> From: Han Zhou > >> > >> When there are in-flight flow-installations pending to ovs

Re: [ovs-dev] [PATCH ovn 2/2] ovn-controller: Fix flow installation latency caused by recompute.

2019-07-30 Thread Han Zhou
On Mon, Jul 29, 2019 at 9:11 PM Numan Siddique wrote: > > > > On Tue, Jul 30, 2019 at 9:39 AM Numan Siddique wrote: >> >> >> >> On Tue, Jul 30, 2019 at 7:10 AM Han Zhou wrote: >>> >>> From: Han Zhou >>> >>> When the

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix flow installation latency caused by recompute.

2019-07-29 Thread Han Zhou
On Mon, Jul 29, 2019 at 5:05 PM 0-day Robot wrote: > > Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > build: > depbas

[ovs-dev] [PATCH ovn 2/2] ovn-controller: Fix flow installation latency caused by recompute.

2019-07-29 Thread Han Zhou
From: Han Zhou When there are in-flight flow-installations pending to ovs-vswitchd, current incremental processing logic prioritizes new change handling. However, in scenarios where frequent recomputes are triggered, the later recompute would block the flow-installation for previously computed

[ovs-dev] [PATCH ovn 1/2] ovn-controller: Fix path for lib/inc-proc-eng.h after OVN split.

2019-07-29 Thread Han Zhou
From: Han Zhou Signed-off-by: Han Zhou --- controller/ovn-controller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c index 12c919a..d3b28b9 100644 --- a/controller/ovn-controller.c +++ b/controller/ovn-controller.c

  1   2   3   4   5   6   7   8   >