Re: [ovs-dev] [PATCH ovn 4/4] rhel: Run ovn services with the 'openvswitch' user

2019-08-20 Thread Jaime Caamaño Ruiz
hat, and let the admin setup the appropriate mount point as part of the dpdk setup workflow. BR Jaime. -Original Message- From: Jaime Caamaño Ruiz Reply-to: jcaam...@suse.com To: Numan Siddique , Jaime Caamano Cc: ovs dev Subject: Re: [PATCH ovn 4/4] rhel: Run ovn services with the 'openvswitc

Re: [ovs-dev] [PATCH ovn 4/4] rhel: Run ovn services with the 'openvswitch' user

2019-08-20 Thread Jaime Caamaño Ruiz
dique To: Jaime Caamano Cc: ovs dev Subject: Re: [PATCH ovn 4/4] rhel: Run ovn services with the 'openvswitch' user Date: Wed, 14 Aug 2019 18:44:28 +0530 On Wed, Aug 14, 2019 at 6:08 PM Jaime Caamaño Ruiz wrote: > Hello > > Some comments, that probably are due to me being confus

Re: [ovs-dev] [PATCH ovn 4/4] rhel: Run ovn services with the 'openvswitch' user

2019-08-14 Thread Jaime Caamaño Ruiz
n with the same user as ovs"). CC: Jaime Caamaño Ruiz Signed-off-by: Numan Siddique --- rhel/automake.mk| 3 ++- rhel/ovn-fedora.spec.in | 13 + ...r_lib_systemd_system_ovn-controller-vtep.service | 2 ++

[ovs-dev] [PATCH] utilities: Improve ovs-dpctl-top flow parsing

2019-08-12 Thread Jaime Caamaño Ruiz
* check that expected bytes and packets stats are correctly read from every flow. * check that the expected elements are read for every field type aggregation. Signed-off-by: Jaime Caamaño Ruiz --- utilities/ovs-dpctl-top.in | 23 --- 1 file changed, 12 insertions(+), 11

[ovs-dev] [PATCH 2/2] rhel: Fix ovn database dir optional on first run

2019-06-10 Thread Jaime Caamaño Ruiz
OVN database directory is createid on first run so make ownership handling optional. Fixes: 94e1e8be3187 ("rhel: run ovn with the same user as ovs") Signed-off-by: Jaime Caamaño Ruiz --- rhel/usr_lib_systemd_system_ovn-northd.service | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[ovs-dev] [PATCH 1/2] rhel: set useropts optional for ovsdb-server

2019-06-10 Thread Jaime Caamaño Ruiz
systemd assesses the presssence of all EnvironmentFile before execution of Exec* directives, thus useropts needs to be optional even though it will always be created at ExecStartPre. Fixes: 94e1e8be3187 ("rhel: run ovn with the same user as ovs") Signed-off-by: Jaime Caamaño Ruiz

[ovs-dev] [PATCH 2/2] rhel: Fix ovn database dir optional on first run

2019-06-10 Thread Jaime Caamaño Ruiz
OVN database directory is createid on first run so make ownership handling optional. Problem introduced with commit 94e1e8be3. Signed-off-by: Jaime Caamaño Ruiz --- rhel/usr_lib_systemd_system_ovn-northd.service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rhel

[ovs-dev] [PATCH 1/2] rhel: set useropts optional for ovsdb-server

2019-06-10 Thread Jaime Caamaño Ruiz
systemd assesses the presssence of all EnvironmentFile before execution of Exec* directives, thus useropts needs to be optional even though it will always be created at ExecStartPre. Problem introduced with commit 94e1e8be3. Signed-off-by: Jaime Caamaño Ruiz --- rhel

Re: [ovs-dev] [PATCH 1/4] ovn-controller-vtep: Fix wrong value for ovnsb-db argument

2019-06-10 Thread Jaime Caamaño Ruiz
: Re: [ovs-dev] [PATCH 1/4] ovn-controller-vtep: Fix wrong value for ovnsb-db argument Date: Sun, 9 Jun 2019 17:27:06 -0700 On Wed, May 08, 2019 at 01:53:45PM +0200, Jaime Caamaño Ruiz wrote: > Fix help output of ovn-controller-vtep that was suggesting the > openvswitch database instead of t

[ovs-dev] [PATCH] rhel: useropts should be owned by package

2019-06-10 Thread Jaime Caamaño Ruiz
So that is properly cleaned up after package is uninstalled. Signed-off-by: Jaime Caamaño Ruiz --- rhel/openvswitch-fedora.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index d41d11cc4..9c752ff4e 100644 --- a/rhel

[ovs-dev] [PATCH] rhel: let *-ctl handle runtime directory

2019-06-10 Thread Jaime Caamaño Ruiz
/systemd/systemd/issues/12713 Signed-off-by: Jaime Caamaño Ruiz --- rhel/usr_lib_systemd_system_ovsdb-server.service | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/rhel/usr_lib_systemd_system_ovsdb-server.service b/rhel/usr_lib_systemd_system_ovsdb-server.service index 9bb37fd06

[ovs-dev] [PATCH 4/4] rhel: run ovn with the same user as ovs

2019-05-08 Thread Jaime Caamaño Ruiz
Both ovn and ovs share the same log and run directories which are owned by the user running ovs so it makes sense that ovn runs under that user too to diminish security concerns and possible problems with log rotation. Signed-off-by: Jaime Caamaño Ruiz --- rhel/usr_lib_systemd_system_ovn

[ovs-dev] [PATCH 3/4] rhel: secure openvswitch useropts

2019-05-08 Thread Jaime Caamaño Ruiz
. Signed-off-by: Jaime Caamaño Ruiz --- rhel/usr_lib_systemd_system_ovs-vswitchd.service.in | 2 +- rhel/usr_lib_systemd_system_ovsdb-server.service| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rhel/usr_lib_systemd_system_ovs-vswitchd.service.in b/rhel

[ovs-dev] [PATCH 2/4] rhel: start ovn-controller-vtep with ovn-ctl

2019-05-08 Thread Jaime Caamaño Ruiz
Use ovn-ctl to start ovn-controller-vtep from the corresponding systemd unit file. Signed-off-by: Jaime Caamaño Ruiz --- ovn/utilities/ovn-ctl | 10 +- rhel/usr_lib_systemd_system_ovn-controller-vtep.service | 12 ++-- 2 files changed, 15

[ovs-dev] [PATCH 1/4] ovn-controller-vtep: Fix wrong value for ovnsb-db argument

2019-05-08 Thread Jaime Caamaño Ruiz
. Signed-off-by: Jaime Caamaño Ruiz --- ovn/controller-vtep/ovn-controller-vtep.c | 2 +- rhel/usr_lib_systemd_system_ovn-controller-vtep.service | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ovn/controller-vtep/ovn-controller-vtep.c b/ovn/controller-vtep

[ovs-dev] [PATCH] rhel: fix logrotate group when dpdk is enabled

2019-04-30 Thread Jaime Caamaño Ruiz
Otherwise logrotate will fail to generate the rotated log files. Signed-off-by: Jaime Caamaño Ruiz --- rhel/openvswitch-fedora.spec.in | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index

Re: [ovs-dev] Apply e120ff1f8 to stable bracnhes

2018-11-26 Thread Jaime Caamaño Ruiz
, Jaime Caamaño Ruiz wrote: > Commit e120ff1f8 (python-c-ext: Fix memory leak in Parser_finish) > fixes > a bug that is present since OVS 2.6. Could it be cherry picked to > applicable stable branches? It appears that it was already on all of them. Where is it missing?

[ovs-dev] Apply e120ff1f8 to stable bracnhes

2018-11-26 Thread Jaime Caamaño Ruiz
Hi Commit e120ff1f8 (python-c-ext: Fix memory leak in Parser_finish) fixes a bug that is present since OVS 2.6. Could it be cherry picked to applicable stable branches? Thanks Jaime. ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-11-02 Thread Jaime Caamaño Ruiz
Upstream commit: commit 46ebe2834ba5b541f28ee72e556a3fed42c47570 Author: Jaime Caamaño Ruiz Date: Wed Oct 31 18:52:03 2018 +0100 openvswitch: Fix push/pop ethernet validation When there are both pop and push ethernet header actions among the actions to be applied

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Jaime Caamaño Ruiz
ethernet validation Date: Wed, 31 Oct 2018 10:10:18 -0700 On 10/31/2018 9:56 AM, Yi-Hung Wei wrote: > On Wed, Oct 31, 2018 at 9:44 AM Gregory Rose > wrote: > > On 10/31/2018 9:08 AM, Jaime Caamaño Ruiz wrote: > > > When validating push/pop ethernet actions, mac_proto is

[ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Jaime Caamaño Ruiz
When validating push/pop ethernet actions, mac_proto is not being reset correctly. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047554.html Fixes: 6fcecb85ab ("datapath: add Ethernet push and pop actions") Signed-off-by: Jaime Caamaño Ruiz ---

[ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Jaime Caamaño Ruiz
When validating push/pop ethernet actions, mac_proto is not being reset correctly. Signed-off-by: Jaime Caamaño Ruiz Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047554.html Fixes: 6fcecb85ab ("datapath: add Ethernet push and pop actions") ---

[ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Jaime Caamaño Ruiz
When validating push/pop ethernet actions, mac_proto is not being reset correctly. Signed-off-by: Jaime Caamaño Ruiz --- datapath/flow_netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c index c3f1baa05..ee0c18422