Re: [ovs-dev] bug in sflow_choose_agent_address()

2018-09-19 Thread Neil McKee
Yes. Exactly. Neil -- Neil McKee InMon Corp. http://www.inmon.com On Wed, Sep 19, 2018 at 12:10 PM, Justin Pettit wrote: > Thanks for the report. The existing code seems to use "ip" in a way that's > inconsistent, which I think makes it confusing. I think the app

[ovs-dev] bug in sflow_choose_agent_address()

2018-09-19 Thread Neil McKee
ith the ovs{} module enabled will take care of it). Neil -- Neil McKee InMon Corp. http://www.inmon.com ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 09/11] ofproto-dpif-slow: Add IPv6 agent address support.

2018-04-13 Thread Neil McKee
So that's another use-case for this new option. On Fri, Apr 13, 2018 at 10:26 AM, Ben Pfaff <b...@ovn.org> wrote: > Suggested-by: Neil McKee <neil.mc...@inmon.com> > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > ofp

Re: [ovs-dev] [PATCH 1/2] vswitchd: Allow user to directly specify sFlow agent address.

2018-04-10 Thread Neil McKee
when two switches were sending sFlow using each other's agent address, so perhaps a warning not to use this "manually" would be appropriate? -- Neil McKee InMon Corp. http://www.inmon.com On Sat, Mar 31, 2018 at 5:12 PM, Ben Pfaff <b...@ovn.org> wrote: > At least f

Re: [ovs-dev] [RFC PATCH 1/2] sflow: introduce egress flow sampling

2017-08-28 Thread Neil McKee
r use-case? Neil -- Neil McKee InMon Corp. http://www.inmon.com On Thu, Aug 24, 2017 at 5:33 AM, Michal Weglicki <michalx.wegli...@intel.com> wrote: > Currently, sFlow implementation in Open vSwitch samples packets only on > igress. > While it works great for majority of cas

Re: [ovs-dev] [PATCH v2] sflow: Expose ethernet stats via sFlow

2017-02-02 Thread Neil McKee
Robert, It's great to get the multicast and broadcast counters in there. I do wonder if it's worth including the whole ethernet stats block just to distinguish alignment / FCS / frame-too-long errors, given that total errors is already a counter in the generic block. I know that some follow

Re: [ovs-dev] [PATCH] Expose sFLOW "Processor information" counters.

2016-11-21 Thread Neil McKee
ere it's unlikely that hsflowd can be layered on top? Neil -- Neil McKee InMon Corp. http://www.inmon.com On Mon, Nov 21, 2016 at 5:34 AM, mweglicx <michalx.wegli...@intel.com> wrote: > Exports PROCESSOR structure with sFLOW counters. > Refactors vswitchd/system-stats.* function

Re: [ovs-dev] [PATCH] sflow: Expose ethernet and vlan stats via sFlow

2016-11-17 Thread Neil McKee
McKee InMon Corp. http://www.inmon.com On Thu, Nov 17, 2016 at 12:44 AM, Robert Wojciechowicz < robertx.wojciechow...@intel.com> wrote: > On Wed, Nov 16, 2016 at 08:40:42AM -0700, Neil McKee wrote: > > If there is only one VLAN then the numbers are redundant - already > exported

Re: [ovs-dev] [PATCH] sflow: Expose ethernet and vlan stats via sFlow

2016-11-16 Thread Neil McKee
don't think you would be losing anything by leaving it out. Neil -- Neil McKee InMon Corp. http://www.inmon.com On Wed, Nov 16, 2016 at 6:13 AM, Robert Wojciechowicz < robertx.wojciechow...@intel.com> wrote: > On Tue, Nov 15, 2016 at 11:13:10PM -0700, Neil McKee wrote: >

Re: [ovs-dev] [PATCH] sflow: Expose ethernet and vlan stats via sFlow

2016-11-15 Thread Neil McKee
MAC, IP etc.) from them. So I think I'm voting for (1), maybe (2) but not (3). What do you think? Neil -- Neil McKee InMon Corp. http://www.inmon.com On Tue, Nov 15, 2016 at 2:47 AM, Robert Wojciechowicz < robertx.wojciechow...@intel.com> wrote: > Expose existing netdev stats