Re: [ovs-dev] [PATCH] ovsdb-server: Don't drop all connections on read/write status change.

2019-10-14 Thread Numan Siddique
On Mon, Oct 14, 2019 at 2:23 PM Dumitru Ceara wrote: > On Mon, Oct 14, 2019 at 8:21 AM wrote: > > > > From: Numan Siddique > > > > The commit [1] force drops all connections when the db read/write status > changes. > > Prior to the commit [1], whe

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Create etcdir when starting ovsdb servers

2019-10-13 Thread Numan Siddique
On Sun, Oct 13, 2019 at 4:31 AM aginwala wrote: > Acked-by: Aliasgar Ginwala > > Thanks for the review. I applied this to master. Numan > > On Sat, Oct 12, 2019 at 1:16 PM wrote: > >> From: Numan Siddique >> >> 'ovn-ctl promote_ovnnb/promote_ovnsb'

Re: [ovs-dev] [PATCH ovn v4] Document process for compatibility between OVS and OVN.

2019-10-09 Thread Numan Siddique
> > It also creates a document to detail compatibility of specific OVN > versions. > > Signed-off-by: Mark Michelson > Acked-by: Han Zhou > Acked-by: Numan Siddique > --- > v3 -> v4: > * Addressed grammatical fixes > --- > v2 -> v3: > * Rem

Re: [ovs-dev] [PATCH ovn] Partially revert "Exclude inport and outport symbol tables from conjunction."

2019-10-07 Thread Numan Siddique
On Wed, Oct 2, 2019 at 2:54 AM Han Zhou wrote: > > > On Mon, Sep 30, 2019 at 6:51 AM wrote: > > > > From: Numan Siddique > > > > This partially revers the commit - > 298701dbc99645700be41680a43d049cb061847a > > as the commit [1] disables the conj

Re: [ovs-dev] [PATCH] cirrus: Fix typo in the name of sphinx package.

2019-10-01 Thread Numan Siddique
On Tue, Oct 1, 2019, 2:58 PM Ilya Maximets wrote: > This fixes broken build on CirrusCI: > https://cirrus-ci.com/build/4677435792031744 > > CC: Ben Pfaff > Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") > Signed-off-by: Ilya Maximets

Re: [ovs-dev] [PATCH v4] Require Python 3 and remove support for Python 2.

2019-09-27 Thread Numan Siddique
On Sat, Sep 28, 2019, 1:03 AM Ben Pfaff wrote: > On Fri, Sep 27, 2019 at 12:33:05PM +0530, Numan Siddique wrote: > > On Thu, Sep 26, 2019 at 11:12 PM Ben Pfaff wrote: > > > > > Python 2 reaches end-of-life on January 1, 2020, which is only > > > a few months

Re: [ovs-dev] [PATCH ovn] Disable conjunction by force cross product for all the fields.

2019-09-27 Thread Numan Siddique
On Fri, Sep 27, 2019 at 10:15 PM Han Zhou wrote: > > > On Fri, Sep 27, 2019 at 9:42 AM Numan Siddique > wrote: > >> >> >> On Fri, Sep 27, 2019 at 10:05 PM Han Zhou wrote: >> >>> Thanks Numan. This is cleaner than the RFC. At the same time, shall

Re: [ovs-dev] [PATCH ovn] Disable conjunction by force cross product for all the fields.

2019-09-27 Thread Numan Siddique
ed-by: Han Zhou > Thanks. I will submit a patch to revert it. I will go ahead and apply this patch Or You want to revert to be incorporated with this patch ? Separate one seems better to me. Thanks Numan > > On Fri, Sep 27, 2019 at 8:52 AM wrote: > >> From: Numan Siddiqu

Re: [ovs-dev] [RFC PATCH ovn] Disable conjunction

2019-09-27 Thread Numan Siddique
On Fri, Sep 27, 2019 at 12:04 PM Numan Siddique wrote: > > > On Fri, Sep 27, 2019 at 11:56 AM Han Zhou wrote: > >> >> Thanks Numan. It looks good to me. Is there a reason why this is RFC? >> > > Yes. I actually was thinking another way to disable conjunction.

Re: [ovs-dev] [PATCH ovn v3] Learn the mac binding only if required

2019-09-27 Thread Numan Siddique
On Fri, Sep 27, 2019 at 11:51 AM Han Zhou wrote: > > > On Tue, Sep 24, 2019 at 1:39 PM wrote: > > diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml > > index 6115e84b5..c98db48d2 100644 > > --- a/ovn-architecture.7.xml > > +++ b/ovn-architecture.7.xml > > @@ -970,6 +970,24 @@ > >

Re: [ovs-dev] [RFC PATCH ovn] Disable conjunction

2019-09-27 Thread Numan Siddique
2019 at 1:48 AM wrote: > >> From: Numan Siddique >> >> The commit 298701dbc996("Exclude inport and outport symbol tables from >> conjunction") >> was earlier added to disable conjunction for inport and outport symbols. >> This patch exte

Re: [ovs-dev] [PATCH ovn 1/4] configure: Improve checks for OVS source and build directories.

2019-09-26 Thread Numan Siddique
"$dir"` lines up higher so that they > do their intended job of expanding ~ in the right place. That has to > happen early, otherwise, ~/foo will effectively end up as $PWD/\~/foo. > > Signed-off-by: Ben Pfaff > Please consider this Ack for the whole series. Acked-by:

Re: [ovs-dev] [PATCH v3] Require Python 3 and remove support for Python 2.

2019-09-26 Thread Numan Siddique
On Thu, Sep 26, 2019 at 1:18 AM Numan Siddique wrote: > > > On Thu, Sep 26, 2019, 12:12 AM Ben Pfaff wrote: > >> Numan, please (re-)review this when you have time. >> > > Sure. I will do it tomorrow > This patch has merge conflicts. Can you please rebase it.

Re: [ovs-dev] [PATCH v3] Require Python 3 and remove support for Python 2.

2019-09-25 Thread Numan Siddique
On Thu, Sep 26, 2019, 12:12 AM Ben Pfaff wrote: > Numan, please (re-)review this when you have time. > Sure. I will do it tomorrow Thanks Numan > On Fri, Sep 20, 2019 at 08:44:48AM -0700, Ben Pfaff wrote: > > Python 2 reaches end-of-life on January 1, 2020, which is only > > a few months

Re: [ovs-dev] [PATCH ovn 0/1] Remove ovs subtree

2019-09-25 Thread Numan Siddique
On Wed, Sep 25, 2019 at 9:51 PM Ben Pfaff wrote: > On Wed, Sep 25, 2019 at 02:53:53PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > We can delete the ovs subtree as OVN doesn't depend on this folder any > more > > for compilation. > > &

Re: [ovs-dev] Time to remove the OVS subtree from OVN repo

2019-09-25 Thread Numan Siddique
On Tue, Sep 24, 2019 at 2:25 AM Ben Pfaff wrote: > On Tue, Sep 24, 2019 at 01:27:57AM +0530, Numan Siddique wrote: > > Hi, > > > > Now that OVN is compiled with OVS sources from external sources, I think > we > > can go ahead and delete the ovs subtree [1], > &

Re: [ovs-dev] [PATCH ovn v2] Learn the mac binding only if required

2019-09-24 Thread Numan Siddique
Thanks Han for the reviews. Please see below for some comments. Thanks Numan On Wed, Sep 18, 2019 at 4:56 AM Han Zhou wrote: > > On Mon, Sep 16, 2019 at 10:17 AM wrote: > > > > From: Numan Siddique > > > > OVN has the actions - put_arp and put_nd

Re: [ovs-dev] [PATCH ovn] Fix the compilation failures

2019-09-24 Thread Numan Siddique
On Tue, Sep 24, 2019 at 2:09 AM Russell Bryant wrote: > Sorry. > > No worries :) Thanks for the review. I applied this patch to master. Numan > Acked-by: Russell Bryant > > > On Sep 23, 2019, at 4:20 PM, nusid...@redhat.com wrote: > > > > From: Numan Si

[ovs-dev] Time to remove the OVS subtree from OVN repo

2019-09-23 Thread Numan Siddique
Hi, Now that OVN is compiled with OVS sources from external sources, I think we can go ahead and delete the ovs subtree [1], We can delete this in 2 ways (1) Just delete the ovs subfolder using "git rm -rf ovs" (2) Using git filter-branch (2) deletes the history of ovs subfolder and rewrites

Re: [ovs-dev] [PATCH v2 python3 0/6] Remove Python 2 support

2019-09-19 Thread Numan Siddique
parse in Python 3 also. > Require Python 3 and remove support for Python 2. > (I accidently replied to v1 of this series instead of v2, so replying again). I tested this series and it builds fine for me. Acked-by: Numan Siddique for the whole series with one

Re: [ovs-dev] [PATCH python3 0/4] Remove Python 2 support

2019-09-19 Thread Numan Siddique
Python 2. > I tested this series and it builds fine for me. Acked-by: Numan Siddique for the whole series with one correction in patch 4 - which I replied separately. Thanks Numan > .cirrus.yml | 3 +- > .travis.yml

Re: [ovs-dev] [PATCH v2 python3 4/6] Recommend Sphinx from Python 3 in documentation and packaging.

2019-09-19 Thread Numan Siddique
On Thu, Sep 19, 2019 at 7:31 AM Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > .travis.yml | 2 +- > Documentation/intro/install/documentation.rst | 6 +++--- > Documentation/intro/install/rhel.rst | 2 +- > rhel/openvswitch-fedora.spec.in

Re: [ovs-dev] [PATCH v2 1/2 ovn] OVN: Fix container build.

2019-09-19 Thread Numan Siddique
On Fri, Sep 20, 2019 at 2:15 AM wrote: > From: Aliasgar Ginwala > > Current code changes in ovs/ovn split replaced openvswitch with ovn and > caused container patches to break. > Also, as per ff4439d, one should build ovn specifying ovs source. > This patch fixes the same. > > Signed-off-by:

Re: [ovs-dev] [PATCH 1/2 ovn] OVN: Fix container build.

2019-09-19 Thread Numan Siddique
On Thu, Sep 12, 2019 at 7:00 AM aginwala wrote: > Signed-off-by: Aliasgar Ginwala > > Hi Ali, This patch is failing when I compile. Can you please take a look. > utilities/ovn-lib.tmp make[1]: *** No rule to make target 'utilities/docker/create_ovn_dbs.sh', needed by 'all-am'. Stop.

Re: [ovs-dev] [PATCH v3 ovn] northd: add empty_lb controller_event for logical router

2019-09-16 Thread Numan Siddique
On Sat, Sep 14, 2019 at 2:03 AM Mark Michelson wrote: > Acked-by: Mark Michelson > > On 9/10/19 1:00 PM, Lorenzo Bianconi wrote: > > Add empty load balancer controller_event support to logical router > > pipeline. Update northd documentation even for logical switch pipeline > > > >

Re: [ovs-dev] [PATCH ovn] gitignore: Add missing OVN entries.

2019-09-16 Thread Numan Siddique
On Fri, Sep 13, 2019 at 8:24 PM Dumitru Ceara wrote: > Signed-off-by: Dumitru Ceara > Thanks. I applied this patch to master. Numan > --- > .gitignore | 8 > include/ovn/.gitignore | 2 ++ > utilities/.gitignore | 1 + > 3 files changed, 11 insertions(+) > create

Re: [ovs-dev] [PATCH v3 ovn 0/2] ovn-controller: Logical flow processing optimizations

2019-09-16 Thread Numan Siddique
On Fri, Sep 13, 2019 at 3:13 AM Han Zhou wrote: > On Thu, Sep 12, 2019 at 7:14 AM Dumitru Ceara wrote: > > > > This series adds some (independent) optimizations that improve > > ovn-controller performance by lowering the number of operations that > > need to be executed during a iteration of

Re: [ovs-dev] [PATCH ovn] Exclude inport and outport symbol tables from conjunction

2019-09-14 Thread Numan Siddique
come up with ideas. I know Dumitru has some idea to make use of conjunctions for port groups. CC'ing Han if he has any comments on ideas. Thanks Numan > Thanks a lot everyone! > Daniel > > > > On 9/13/19 4:49 PM, nusid...@redhat.com wrote: > > > From: Numan Siddique >

Re: [ovs-dev] [PATCH ovn v2] OVN: Fix learning of neighbors from ARP/ND packets.

2019-09-11 Thread Numan Siddique
On Thu, Aug 15, 2019 at 12:24 PM Han Zhou wrote: > On Wed, Aug 14, 2019 at 11:11 PM Dumitru Ceara wrote: > > > > On Thu, Aug 8, 2019 at 1:52 AM Han Zhou wrote: > > > > > > > > > > > > On Wed, Aug 7, 2019 at 8:12 AM Dumitru Ceara > wrote: > > >> > > >> On Mon, Aug 5, 2019 at 5:34 PM Han Zhou

Re: [ovs-dev] [PATCH] ovn: Fix broken dist* targets.

2019-09-11 Thread Numan Siddique
_libovn_la_SOURCES', > needed by 'distdir'. Stop. > > CC: Mark Michelson > Fixes: f3e24610ea18 ("Remove OVN.") > Signed-off-by: Ilya Maximets > Acked-by: Numan Siddique There's another cleanup patch if you would like to take a look - https://patchwork.ozlabs.org/p

Re: [ovs-dev] [PATCH v5 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-11 Thread Numan Siddique
On Wed, Sep 11, 2019 at 2:53 AM Ankur Sharma wrote: > During E-W routing for vlan backed networks, we replace router port > mac with chassis mac, when packet leaves the source hypervisor. > > As a result, the destination VM (on remote hypervisor) will see > chassis mac as source mac in received

Re: [ovs-dev] [PATCH ovn] ovn-openstack.rst: Add check for Gateway_Chassis table

2019-09-11 Thread Numan Siddique
On Thu, Sep 5, 2019 at 7:57 PM Flavio Fernandes wrote: > This is related to the section called "Adding a Gateway". > > Added workaround command for a known issue in networking-ovn. > Even after the issue is resolved, it may be useful to have this > in the tutorial, so folks have a feel for how

Re: [ovs-dev] [PATCH ovn v2 1/2] Add ovn-appctl utility

2019-09-11 Thread Numan Siddique
On Tue, Sep 10, 2019 at 11:37 PM Mark Michelson wrote: > For the series, > Acked-by: Mark Michelson > Thanks. I applied this series to master. Numan > > On 9/10/19 3:42 AM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Now that OVN has it's

Re: [ovs-dev] [PATCH v4 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-10 Thread Numan Siddique
On Mon, Sep 9, 2019 at 1:58 AM Ankur Sharma wrote: > During E-W routing for vlan backed networks, we replace router port > mac with chassis mac, when packet leaves the source hypervisor. > > As a result, the destination VM (on remote hypervisor) will see > chassis mac as source mac in received

Re: [ovs-dev] [PATCH ovn 1/2] Add ovn-appctl utility

2019-09-10 Thread Numan Siddique
On Wed, Sep 4, 2019 at 11:21 PM Mark Michelson wrote: > On 9/2/19 1:09 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Now that OVN has it's own rundir, "ovs-appctl -t > ovn-controller/ovn-northd" > > doesn't work. To fix this, ovn

Re: [ovs-dev] [RFC v2] Document process for compatibility between OVS and OVN.

2019-09-10 Thread Numan Siddique
Hi Mark, Few comments below. On Sat, Sep 7, 2019 at 2:38 AM Mark Michelson wrote: > This document serves to provide an explanation for how OVN will remain > compatible with OVS. It provides instructions for OVN contributors for > how to maintain compatibility even across older versions of OVS

Re: [ovs-dev] [PATCH] Fix the segfault seen in ovn-controller when running tests

2019-09-09 Thread Numan Siddique
On Mon, Sep 9, 2019 at 8:48 PM Lorenzo Bianconi wrote: > > > > From: Numan Siddique > > > > The test case - "116: ovn -- 2 HVs, 2 lports/HV, localnet ports, DVR N-S > Ping" > > is failing with the segfault in ovn-controller occationally. > > &g

Re: [ovs-dev] [PATCH v3 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-06 Thread Numan Siddique
Hi Ankur, Couple of comments, otherwise LGTM. Thanks Numan On Wed, Sep 4, 2019 at 12:45 AM Ankur Sharma wrote: > During E-W routing for vlan backed networks, we replace router port > mac with chassis mac, when packet leaves the source hypervisor. > > As a result, the destination VM (on

Re: [ovs-dev] [PATCH ovn] Handle GARP reply packets from provider networks only on gateway chassis

2019-09-05 Thread Numan Siddique
On Thu, Sep 5, 2019 at 3:19 AM Han Zhou wrote: > > > On Mon, Sep 2, 2019 at 9:32 AM wrote: > > > > From: Numan Siddique > > > > Suppose there is a provider network (with localnet port) and it is > > connected to a logical router via a distributed ga

Re: [ovs-dev] [PATCH v1 ovn] OVN: Send RARP for vif ports for which OVN does not know the IP.

2019-09-03 Thread Numan Siddique
On Fri, Aug 2, 2019 at 3:12 AM Ankur Sharma wrote: > ISSUE: > For a VIF port (on a bridged logical switch), OVN sends out > GARPs, advertising port's mac and IP. > > However, if a VIF port (on a bridged logical switch) has not > been assigned an IP, then OVN does not advertise anything. > As a

Re: [ovs-dev] [PATCH v2 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-03 Thread Numan Siddique
On Tue, Aug 27, 2019 at 7:31 AM Ankur Sharma wrote: > During E-W routing for vlan backed networks, we replace router port > mac with chassis mac, when packet leaves the source hypervisor. > > As a result, the destination VM (on remote hypervisor) will see > chassis mac as source mac in received

Re: [ovs-dev] [PATCH ovn] Fix configure help string for ovs source/build path

2019-09-03 Thread Numan Siddique
On Fri, Aug 30, 2019 at 6:53 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Signed-off-by: Lorenzo Bianconi > Thanks. I pushed this to master. Numan > --- > acinclude.m4 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/acinclude.m4 b/acinclude.m4 >

Re: [ovs-dev] ovn-controller is taking 100% CPU all the time in one deployment

2019-09-02 Thread Numan Siddique
On Sat, Aug 31, 2019 at 2:48 AM Han Zhou wrote: > > > On Thu, Aug 29, 2019 at 11:36 PM Numan Siddique > wrote: > > > > > > > > On Fri, Aug 30, 2019 at 1:04 AM Han Zhou wrote: > >> > >> > >> > >> On Thu, Aug 29, 2019 at

Re: [ovs-dev] [ovs-discuss] ovn-controller is taking 100% CPU all the time in one deployment

2019-08-31 Thread Numan Siddique
On Sat, Aug 31, 2019 at 2:05 AM Han Zhou wrote: > > > On Fri, Aug 30, 2019 at 1:25 PM Numan Siddique > wrote: > > > > Hi Han, > > > > I am thinking of this approach to solve this problem. I still need to > test it. > > If you

Re: [ovs-dev] [ovs-discuss] ovn-controller is taking 100% CPU all the time in one deployment

2019-08-30 Thread Numan Siddique
2019 at 11:50 PM Han Zhou wrote: > On Fri, Aug 30, 2019 at 6:46 AM Mark Michelson > wrote: > > > > On 8/30/19 5:39 AM, Daniel Alvarez Sanchez wrote: > > > On Thu, Aug 29, 2019 at 10:01 PM Mark Michelson > wrote: > > >> > > >> On 8/29/19 2:3

Re: [ovs-dev] ovn-controller is taking 100% CPU all the time in one deployment

2019-08-30 Thread Numan Siddique
On Fri, Aug 30, 2019 at 1:04 AM Han Zhou wrote: > > > On Thu, Aug 29, 2019 at 12:16 PM Numan Siddique > wrote: > >> >> >> On Fri, Aug 30, 2019 at 12:37 AM Han Zhou wrote: >> >>> >>> >>> On Thu, Aug 29, 2019 at 11:40 AM Numan S

Re: [ovs-dev] ovn-controller is taking 100% CPU all the time in one deployment

2019-08-29 Thread Numan Siddique
On Fri, Aug 30, 2019 at 12:37 AM Han Zhou wrote: > > > On Thu, Aug 29, 2019 at 11:40 AM Numan Siddique > wrote: > > > > Hello Everyone, > > > > In one of the OVN deployments, we are seeing 100% CPU usage by > ovn-controllers all the time. > >

[ovs-dev] ovn-controller is taking 100% CPU all the time in one deployment

2019-08-29 Thread Numan Siddique
Hello Everyone, In one of the OVN deployments, we are seeing 100% CPU usage by ovn-controllers all the time. After investigations we found the below - ovn-controller is taking more than 20 seconds to complete full loop (mainly in lflow_run() function) - The physical switch is sending GARPs

Re: [ovs-dev] [PATCH v4 ovn 0/4] External OVS source support and separate run dir for OVN

2019-08-29 Thread Numan Siddique
On Thu, Aug 29, 2019, 1:16 AM Mark Michelson wrote: > Acked-by: Mark Michelson > Thanks for the review. I applied this series to master. Thanks Numan > On 8/28/19 12:38 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > This patch series adds su

Re: [ovs-dev] [PATCH v8 3/3 ovn] OVN: Vlan backed DVR N-S, redirect packet via localnet port

2019-08-28 Thread Numan Siddique
On Wed, Aug 28, 2019 at 7:27 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that

Re: [ovs-dev] [PATCH v8 2/3 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-28 Thread Numan Siddique
On Wed, Aug 28, 2019 at 7:27 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that

Re: [ovs-dev] [PATCH v8 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-28 Thread Numan Siddique
On Wed, Aug 28, 2019 at 7:26 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that

Re: [ovs-dev] [PATCH v2 ovn 3/3] ovn-controller: Minimize SB DB port_binding lookups.

2019-08-28 Thread Numan Siddique
On Fri, Aug 23, 2019 at 4:55 PM Dumitru Ceara wrote: > Instead of storing only peer_ports in struct local_datapath, store both > local-remote mappings for patch ports. Also, it's useful to directly > store sbrec_port_binding pointers for all datapath ports as we avoid > doing costly

Re: [ovs-dev] [PATCH v2 ovn 2/3] ovn-controller: Optimize update of ct-zones external-ids.

2019-08-28 Thread Numan Siddique
On Fri, Aug 23, 2019 at 4:54 PM Dumitru Ceara wrote: > commit_ct_zones() is called at every ovn-controller iteration but updates > to > ct-zones don't happen at every iteration. Avoid cloning the > br-int->external_ids map unless an update is needed. > > Signed-off-by: Dumitru Ceara > --- >

Re: [ovs-dev] [PATCH v2 ovn 1/3] ofctrl: Avoid recomputing match hash in ofctrl_dup_flow().

2019-08-28 Thread Numan Siddique
On Fri, Aug 23, 2019 at 4:54 PM Dumitru Ceara wrote: > Signed-off-by: Dumitru Ceara > Thanks. I applied this patch to master. Numan > --- > controller/ofctrl.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/controller/ofctrl.c b/controller/ofctrl.c > index

Re: [ovs-dev] [PATCH v7 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-27 Thread Numan Siddique
On Wed, Aug 28, 2019, 6:34 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that >

Re: [ovs-dev] [PATCH v1 ovn] OVN: Replace chassis mac with router port mac on destination chassis

2019-08-27 Thread Numan Siddique
t me know your thoughts, I will be happy to make changes accordingly. > Meanwhile, I am submitting a V2 which is rebased to TOT. > > Appreciate your inputs. > > > Regards, > Ankur > > > > *From:* Numan Siddique > *Sent:* Monday, August 26, 2019 5:02 AM > *To:* Anku

Re: [ovs-dev] [PATCH v1 ovn] OVN: Replace chassis mac with router port mac on destination chassis

2019-08-26 Thread Numan Siddique
Hi Ankur, This patch doesn't apply now. Can you please re base. Few comments below Thanks Numan On Thu, Aug 22, 2019 at 1:51 AM Ankur Sharma wrote: > During E-W routing for vlan backed networks, we replace router port > mac with chassis mac, when packet leaves the source hypervisor. > > As a

Re: [ovs-dev] [PATCH ovn] Fix memory leak in build_pre_lb

2019-08-26 Thread Numan Siddique
On Sun, Aug 25, 2019 at 11:32 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Fix memory leak of ip_address string in build_pre_lb routine if we > install logical flows for empty_lb controller event > > Fixes: f49b17a6cbe3 ("OVN: use trigger_event action to report > 'empty_lb_rule'

Re: [ovs-dev] [PATCH v6 3/4 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-24 Thread Numan Siddique
On Sat, Aug 17, 2019 at 6:08 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that

Re: [ovs-dev] [PATCH v6 2/4 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-24 Thread Numan Siddique
On Sat, Aug 17, 2019 at 6:07 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that

Re: [ovs-dev] [PATCH v6 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-24 Thread Numan Siddique
On Sat, Aug 17, 2019 at 6:23 AM Ankur Sharma wrote: > With 795d7f24ce0e2ed5454e193a059451d237289542 we have added > support for E-W routing on vlan backed networks by replacing > router port macs with chassis macs. > > This replacement of router port mac need NOT be done on > gateway chassis for

Re: [ovs-dev] [PATCH v4 ovn] Containerize components

2019-08-24 Thread Numan Siddique
On Thu, Aug 22, 2019 at 1:54 AM Numan Siddique wrote: > > > On Thu, Aug 22, 2019 at 1:35 AM wrote: > >> From: Aliasgar Ginwala >> >> 1. Containerize ovn central components >> 2. Containerize ovn host >> 3. Update documentation about building/r

Re: [ovs-dev] [PATCH ovn 4/4] rhel: Run ovn services with the 'openvswitch' user

2019-08-24 Thread Numan Siddique
the dpdk initialization is not done. Maybe it's fedora specific? > > If it were to me I would remove that, and let the admin setup the > appropriate mount point as part of the dpdk setup workflow. > > BR > Jaime. > > -Original Message- > From: Jaime Caamaño Rui

Re: [ovs-dev] [PATCH v5 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-23 Thread Numan Siddique
take a look and come back to you if there are any comments. Thanks Numan > Regards, > > Ankur > > *From:* Ankur Sharma > *Sent:* Friday, August 16, 2019 5:37 PM > *To:* Numan Siddique > *Cc:* ovs-dev@openvswitch.org > *Subject:* RE: [ovs-dev] [PATCH v5 1/4 ovn]

Re: [ovs-dev] [PATCH v2] OVS: Containerize components

2019-08-22 Thread Numan Siddique
ation about how to build/run ovs in docker. > > Signed-off-by: aginwala > Acked-by: Numan Siddique As discussed in the meeting today, can you please provide the option to enable or disable kernel module compilation when building the docker images in a follow up patch. Also, is it Ok if you

Re: [ovs-dev] [PATCH ovn] Remove ageing check in run_put_mac_binding

2019-08-22 Thread Numan Siddique
ever be updated > > Signed-off-by: Lorenzo Bianconi > LGTM. Thanks for the patch. Acked-by: Numan Siddique Numan > --- > controller/pinctrl.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/controller/pinctrl.c b/controller/pinctrl.c > index 365a

Re: [ovs-dev] [PATCH v2 ovn 0/5] External OVS source support and separate run dir for OVN

2019-08-22 Thread Numan Siddique
On Thu, Aug 22, 2019 at 12:27 PM Numan Siddique wrote: > > > On Thu, Aug 22, 2019 at 2:19 AM Han Zhou wrote: > >> >> >> On Wed, Aug 21, 2019 at 11:54 AM Numan Siddique >> wrote: >> > >> > >> > >> > On Wed, Aug 21, 2019 a

Re: [ovs-dev] [PATCH v2 ovn 0/5] External OVS source support and separate run dir for OVN

2019-08-22 Thread Numan Siddique
On Thu, Aug 22, 2019 at 2:19 AM Han Zhou wrote: > > > On Wed, Aug 21, 2019 at 11:54 AM Numan Siddique > wrote: > > > > > > > > On Wed, Aug 21, 2019 at 10:30 PM Han Zhou wrote: > >> > >> > >> > >> On

Re: [ovs-dev] [PATCH v4 ovn] Containerize components

2019-08-21 Thread Numan Siddique
On Thu, Aug 22, 2019 at 1:35 AM wrote: > From: Aliasgar Ginwala > > 1. Containerize ovn central components > 2. Containerize ovn host > 3. Update documentation about building/running ovn in containers. > > Signed-off-by: Aliasgar Ginwala > Thanks. Acked-by

Re: [ovs-dev] [PATCH v3 ovn 3/3] OVN: northd: add rate limiting support for SB controller events

2019-08-21 Thread Numan Siddique
On Mon, Aug 19, 2019 at 8:09 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Introduce the capability to associate a meter to each controller event > type in order to not overload the pinctrl thread under heavy load. > Each event type relies on a meter with a defined name: > -

Re: [ovs-dev] [PATCH v3 ovn 2/3] OVN: add meter support to trigger_event action

2019-08-21 Thread Numan Siddique
On Mon, Aug 19, 2019 at 8:09 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Introduce meter support to trigger_event action in order to not > overload pinctrl thread under heavy load > > Signed-off-by: Lorenzo Bianconi > Hi Lorenzo, Can you please add a test for the meter option

Re: [ovs-dev] [PATCH v3 ovn 1/3] OVN: Repair memory leak for OVN controller events.

2019-08-21 Thread Numan Siddique
On Mon, Aug 19, 2019 at 8:08 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > From: Mark Michelson > > From: Mark Michelson > > Controller event action is leaking its genopts. This corrects the error. > > Signed-off-by: Mark Michelson > Signed-off-by: Lorenzo Bianconi > I applied

Re: [ovs-dev] [PATCH v3 ovn] Containerize components

2019-08-21 Thread Numan Siddique
On Wed, Aug 21, 2019 at 10:38 PM wrote: > From: Aliasgar Ginwala > > 1. Containerize ovn central components > 2. Containerize ovn host > 3. Update documentation about building/running ovn in containers. > > Signed-off-by: Aliasgar Ginwala > Hi Aliasgar, There's something odd with this patch.

Re: [ovs-dev] [PATCH v2 ovn 0/5] External OVS source support and separate run dir for OVN

2019-08-21 Thread Numan Siddique
On Wed, Aug 21, 2019 at 10:30 PM Han Zhou wrote: > > > On Mon, Aug 19, 2019 at 11:13 AM wrote: > > > > From: Numan Siddique > > > > This patch series adds support for building OVN from external OVS > > sources. > > > > The first patch adds the

Re: [ovs-dev] [PATCH v2 ovn] Containerize components

2019-08-21 Thread Numan Siddique
On Sat, Aug 17, 2019 at 12:53 PM Aliasgar Ginwala wrote: > 1. Containerize ovn central components > 2. Containerize ovn host > 3. Update documentation about building/running ovn in containers. > > Signed-off-by: aginwala > This patch has conflicts. Would you mind submit v3 rebasing the patch ?

Re: [ovs-dev] [PATCH] Make pidfile_is_running more robust against empty pidfiles

2019-08-20 Thread Numan Siddique
On Tue, Aug 20, 2019 at 2:52 PM Ilya Maximets wrote: > On 20.08.2019 12:16, Ilya Maximets wrote: > > On 20.08.2019 11:48, Numan Siddique wrote: > >> > >> > >> On Wed, Aug 14, 2019 at 9:21 PM Michele Baldessari <mailto:mich...@acksyn.org>> wrote: >

Re: [ovs-dev] [PATCH] test: do not require python2 for CHECK_CONNTRACK macro

2019-08-20 Thread Numan Siddique
I applied this patch to OVN master as this fix is required for ovn repo too. Thanks Numan On Tue, Jul 30, 2019 at 11:51 PM Darrell Ball wrote: > On Tue, Jul 30, 2019 at 10:41 AM Mark Michelson > wrote: > > > Why do these macros require python at all? > > > > alg test tools > > > > > > > On

Re: [ovs-dev] [PATCH] Make pidfile_is_running more robust against empty pidfiles

2019-08-20 Thread Numan Siddique
On Wed, Aug 14, 2019 at 9:21 PM Michele Baldessari wrote: > On Wed, Aug 14, 2019 at 02:28:13PM +0300, Ilya Maximets wrote: > > On 14.08.2019 11:39, Michele Baldessari wrote: > > > In some of our destructive testing of ovn-dbs inside containers managed > > > by pacemaker we reached a situation

Re: [ovs-dev] [PATCH ovn 1/4] Add support for using OVN specific rundirs

2019-08-19 Thread Numan Siddique
On Fri, Aug 16, 2019 at 10:45 PM Mark Michelson wrote: > On 8/13/19 12:27 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). > > The commit [1] changed the package name from openvswitc

Re: [ovs-dev] [PATCH ovn 3/4] Fix "make rpm-fedora"

2019-08-19 Thread Numan Siddique
On Fri, Aug 16, 2019 at 10:46 PM Mark Michelson wrote: > On 8/13/19 12:28 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > "make rpm-fedora" is broken and this patch fixes it. Previous patch > > in this series supported building OVN from

Re: [ovs-dev] [PATCH ovn v4] ovn-northd: Add IGMP Relay support

2019-08-16 Thread Numan Siddique
On Fri, Aug 16, 2019 at 6:23 PM Numan Siddique wrote: > > > On Fri, Aug 16, 2019 at 5:51 PM Dumitru Ceara wrote: > >> Add a new configuration option 'mcast_relay' to the Logical_Router:options >> in the OVN Northbound database. >> >> If a router is configured

Re: [ovs-dev] [PATCH ovn v4] ovn-northd: Add IGMP Relay support

2019-08-16 Thread Numan Siddique
st > traffic and continue to next table. > - Table S_ROUTER_OUT_DELIVERY: add flow matching IP multicast traffic > and set ETH.SRC to the MAC address of the logical port on which > traffic is forwarded. > > Signed-off-by: Dumitru Ceara > Acked-by: Mark Michelson > Acked-by: Numan S

Re: [ovs-dev] [PATCH v5 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-16 Thread Numan Siddique
On Fri, Aug 16, 2019 at 1:11 AM Ankur Sharma wrote: > With 795d7f24ce0e2ed5454e193a059451d237289542 we have added > support for E-W routing on vlan backed networks by replacing > router port macs with chassis macs. > > This replacement of router port mac need NOT be done on > gateway chassis for

Re: [ovs-dev] [PATCH ovn] pinctrl: Fix DNS packet parsing

2019-08-16 Thread Numan Siddique
t; >>> send(p) > > Also add a sanity check on minimum L4 size of packets. > > CC: Numan Siddique > Fixes: 16cb4fb8ca49 ("ovn-controller: Add 'dns_lookup' action") > Reported-at: https://bugzilla.redhat.com/1740335 > Reported-by: Priscila > Signed-off-b

Re: [ovs-dev] [PATCH ovn v3] ovn-northd: Add IGMP Relay support

2019-08-16 Thread Numan Siddique
On Fri, Aug 16, 2019 at 5:26 PM Dumitru Ceara wrote: > On Fri, Aug 16, 2019 at 12:23 PM Numan Siddique > wrote: > > > > > > > > On Mon, Aug 12, 2019 at 5:32 PM Dumitru Ceara wrote: > >> > >> Add a new configuration option 'mcast_relay' to the >

Re: [ovs-dev] [PATCH ovn v3] ovn-northd: Add IGMP Relay support

2019-08-16 Thread Numan Siddique
On Mon, Aug 12, 2019 at 5:32 PM Dumitru Ceara wrote: > Add a new configuration option 'mcast_relay' to the Logical_Router:options > in the OVN Northbound database. > > If a router is configured with 'mcast_relay' enabled then ovn-northd > will install Logical_Flows to allow IP multicast traffic

Re: [ovs-dev] [PATCH v1 ovn] Containerize components

2019-08-16 Thread Numan Siddique
On Thu, Aug 1, 2019 at 3:01 AM Aliasgar Ginwala wrote: > 1. Containerize ovn central components > 2. Containerize ovn host > 3. Update documentation about building/running ovn in containers. > > Hi Aliasgar, Thanks for the patch. This is interesting. I tried out both the OVS patch and this

Re: [ovs-dev] [PATCH ovn 4/4] rhel: Run ovn services with the 'openvswitch' user

2019-08-14 Thread Numan Siddique
vn:openvswitch" and it was not working for me. May be I am doing something wrong ? Thanks for the comments. Numan > BR > Jaime. > > -Original Message- > From: nusid...@redhat.com > To: d...@openvswitch.org > Cc: Jaime Caamano > Subject: [PATCH ovn 4/4]

Re: [ovs-dev] [PATCH ovn] Add support for using OVN specific rundirs

2019-08-12 Thread Numan Siddique
On Mon, Aug 12, 2019 at 2:59 PM Dumitru Ceara wrote: > On Fri, Aug 9, 2019 at 8:24 PM wrote: > > > > From: Numan Siddique > > > > Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). > > The commit [1] changed the package name from openvswit

Re: [ovs-dev] [PATCH v3] ovn-openstack.rst: Miscelaneous fixes.

2019-08-09 Thread Numan Siddique
On Thu, Aug 8, 2019 at 8:32 AM 0-day Robot wrote: > Bleep bloop. Greetings Flavio Fernandes, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > WARNING: Line is 99

Re: [ovs-dev] [PATCH ovn] ovn-northd: Clarify lsp's 'enabled' and 'up' column handling.

2019-08-09 Thread Numan Siddique
On Fri, Aug 9, 2019 at 11:33 PM Justin Pettit wrote: > Signed-off-by: Justin Pettit > Thanks. This looks good to me. Acked-by: Numan Siddique > --- > northd/ovn-northd.c | 8 ++-- > ovn-nb.xml | 1 + > 2 files changed, 7 insertions(+), 2 deletions(-) >

Re: [ovs-dev] [PATCH ovn] Add OVN schema version checks in Makefile.am

2019-08-08 Thread Numan Siddique
On Thu, Aug 8, 2019 at 10:48 PM Han Zhou wrote: > > > On Thu, Aug 8, 2019 at 5:58 AM wrote: > > > > From: Numan Siddique > > > > This was left out during the OVS/OVN split. > > > > We still need to handle the below in the automake files > >

Re: [ovs-dev] [PATCH ovn] Fix DNAT/SNAT system-ovn unit tests

2019-08-08 Thread Numan Siddique
On Mon, Aug 5, 2019 at 11:12 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Fix conntrack checks in the following tests in tests/system-ovn.at: > - ovn -- DNAT and SNAT on distributed router - N/S > - ovn -- DNAT and SNAT on distributed router - E/W > > Fixes: a6ee09882283 ("OVN: run

Re: [ovs-dev] [PATCH v3 3/4 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-08 Thread Numan Siddique
On Fri, Aug 2, 2019 at 5:24 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that

Re: [ovs-dev] [PATCH ovn] Enable OVN in tutorial/ovs-sandbox by default

2019-08-07 Thread Numan Siddique
On Wed, Aug 7, 2019 at 11:27 PM Mark Michelson wrote: > Acked-by: Mark Michelson > > Thanks for the review. I applied this to master. Numan > On 8/7/19 11:06 AM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > The patch removs the --ovn opt

Re: [ovs-dev] 2.12.0 branch snapshot - test 2618 failure on s390x

2019-08-07 Thread Numan Siddique
On Wed, Aug 7, 2019 at 4:20 PM James Page wrote: > Just tripped on this one whilst building for s390x on Ubuntu: > > ## ## > > ## Summary of the failures. ## > ## ## > Failed tests: > openvswitch 2.12.0 test suite test groups: > > NUM:

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-07 Thread Numan Siddique
On Wed, Aug 7, 2019 at 4:59 PM Damijan Skvarc wrote: > Within this function actions & match dynamic strings are used as helper > variables for adding entries into logical flow table. Variables are > used several times in order to optimize number of memory allocations, > however at the end memory

Re: [ovs-dev] [PATCH ovn] Correct the include path when including the header files from lib folder

2019-08-06 Thread Numan Siddique
On Tue, Aug 6, 2019 at 8:26 PM Mark Michelson wrote: > Acked-by: Mark Michelson > Thanks for the review. I applied this to master. Numan > > On 8/6/19 8:56 AM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Compilation will fail when we try

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fixed memory leak in ovn_port_update_sbrec()

2019-08-06 Thread Numan Siddique
On Fri, Aug 2, 2019 at 9:43 PM Numan Siddique wrote: > > > On Fri, Aug 2, 2019 at 5:45 PM Damijan Skvarc > wrote: > >> Memory leak happens because of redundand memory allocation for array >> of single pointer. Issue was solved by removing this redundand allo

  1   2   3   4   5   6   >