[ovs-dev] [PATCH] datapath-windows: Add guards around IpHelper adapter binding calls

. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Switch.h | 2 ++ datapath-windows/ovsext/Vport.c | 34 +++--- 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/datapath-windows/ovsext/Switch.h b/datapath-windows/ovsext/Switch.h index

Re: [ovs-dev] [PATCH] faq: Update features supported on Hyper-V

Acked-by: Sairam Venugopal On 3/11/19, 1:48 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar via dev" wrote: These features were added a while back, so updating the documentation. Signed-off-by: Anand Kumar --- Documentation/faq/releas

Re: [ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

Acked-by: Sairam Venugopal On 2/27/19, 6:10 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: When using a vport we need to guard its usage with the dispatch lock. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/U

Re: [ovs-dev] [PATCH] datapath-windows: Add annotations to find vport functions

Acked-by: Sairam Venugopal On 2/27/19, 9:34 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: Add annotations to find vport functions to check if the dispatch lock is held. Signed-off-by: Alin Gabriel Serdean --- datapath-wind

[ovs-dev] [PATCH] datapath-windows: Fix nbl cleanup when memory allocation fails

StartNblIngressError should be called only when an NBL hasn't been modified. In this case the nbl context was initialized. Rely on existing packet completion mechanism to cleanup the NBL. Found while testing with DriverVerifier with limited memory setting enabled. Signed-off-by: Sairam Venugopal

Re: [ovs-dev] Author should not be mailing list

ot; wrote: Sairam Venugopal writes: > Hey Ben/Aaron, > > > > Is there a known fix for this issue? I sent my commit to d...@openvswitch.org and ran into this. Currently all > patches from the mailing list on patchwork show up under m

Re: [ovs-dev] Author should not be mailing list

This is in regards to “Author should not be mailing list” issue where the from field in the email gets replaced with ovs-dev@openvswitch.org<mailto:ovs-dev@openvswitch.org>. Thanks, Sairam From: Sairam Venugopal Date: Wednesday, February 27, 2019 at 11:43 AM To: Ben Pfaff , Aaron Cono

[ovs-dev] Author should not be mailing list

Hey Ben/Aaron, Is there a known fix for this issue? I sent my commit to d...@openvswitch.org and ran into this. Currently all patches from the mailing list on patchwork show up under my name -

Re: [ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

Do we need to keep the dispatchLock for reading vport structures? If that's the case, then we will need to fix it in other areas of the code too. It would be better to move the locking inside the relevant vport.c functions instead of taking out global ones. Thanks, Sairam On 2/27/19, 6:10

[ovs-dev] [PATCH v2] datapath-windows: Fix potential deadlock in event subscription

before the dispatch lock. Found while testing with Driver Verifier enabled. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/Event.c b/datapath-windows/ovsext/Event.c index 348f032

[ovs-dev] [PATCH] datapath-windows: Fix potential deadlock in event subscription

before the dispatch lock. Found while testing with Driver Verifier enabled. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/Event.c b/datapath-windows/ovsext/Event.c index 348f032

[ovs-dev] [PATCH] datapath-windows: Fix race condition during port creation

Hold the dispatch lock until port-add operations are completed. Found by inspection. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Vport.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c index

Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

Thanks! On 11/15/18, 10:45 AM, "Ben Pfaff" wrote: Alin already did that. On Thu, Nov 15, 2018 at 06:40:00PM +0000, Sairam Venugopal wrote: > Is it too late to backport this to 2.10? > > On 11/15/18, 7:03 AM, "Alin Serdean" wrote: >

Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

nvswitch.org> În numele aserd...@ovn.org > Trimis: Thursday, November 15, 2018 4:52 PM > Către: 'Sairam Venugopal' ; d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in > Buffermgmt.c > > Thanks for the fix

Re: [ovs-dev] [PATCH] Tests: Fix testing bridge - add port after stopping controller on Windows

Thanks for fixing this. The files normally get deleted when the agent closes. Is this a regression or just test related? Ack'ing the fix. Acked-by: Sairam Venugopal On 11/14/18, 7:31 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: On Window

[ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

OVS_BUFFER_CONTEXT gets cleared as part of NdisFreeNetBufferListContext function call. This causes an invalid reference error. Found while testing with driver verifier enabled. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/BufferMgmt.c | 6 -- 1 file changed, 4 insertions

Re: [ovs-dev] [PATCH] [RFC][windows]: Remap VPORT socket pool

Hi Alin, Thanks for the patch. Shashank is giving it a run. How do we prevent this issue in the future? For starters, I think we need to consolidate the usage under nl_* functions to ensure it's not doing something differently in vport_*. We need to look into investing in the test framework

Re: [ovs-dev] [RFC PATCH v1 3/3] windows: Allow add/delete ports via HNS API

Can't you use CreateProcess or _popen to trigger the script/function directly? Thanks, Sairam On 10/8/18, 4:28 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: On Windows 2016 LTSC(RTM) the Container feature and Hyper-V feature both had DCOM API to add

Re: [ovs-dev] [RFC PATCH v1 1/3] datapath-windows: Introduce HNS OVS calls

Hi Alin, Since the hns.psm1 isn't officially supported by Microsoft, is it safe to use the script as part of the OVS repo? Also, "Invoke-HNSRequest" isn't officially documented at this time. I understand that this is an RFC, but do you know if Microsoft plans to finalize this api? If not, I

Re: [ovs-dev] [RFC PATCH v1 2/3] windows, installer: Add a new module file to the installer

Hi Alin, Thanks for the patch. Can't we have the HNSHelper.psm1 be part of the OVS.psm1 directory? Thanks, Sairam On 10/8/18, 4:27 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: This patch adds the new powershell module HNSHelper.psm1 to the OVS windows

[ovs-dev] [PATCH] datapath-windows: Move OVS_IPHELPER_INSTANCE to IpHelper.h

Move the IPHelper Instance to the main header file and update the usage to explicitly point to POVS_IPHELPER_INSTANCE instead of PVOID. Also rename the ipn->context to ipn->instance to make it more readable. Found by inspection. Signed-off-by: Sairam Venugopal --- datapath-windows/

Re: [ovs-dev] [PATCH] datapath-windows: Add support to configure ct zone limits

Hi Anand, Thanks for the patch. See comments inline. Thanks, Sairam On 8/21/18, 2:58 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" wrote: This patch implements limiting conntrack entries per zone using dpctl commands. Example: ovs-appctl

Re: [ovs-dev] [PATCH v3] ofproto-collectors: Windows - Trigger an ARP request before sending IPFIX packet

ing the OVS main thread will break lots of stuff. If it's necessary to block for ARP resolution, then I think it will have to happen in a thread dedicated to that purpose. On Thu, May 24, 2018 at 03:13:58PM +, Sairam Venugopal wrote: > This is the snippet

Re: [ovs-dev] [PATCH v3] ofproto-collectors: Windows - Trigger an ARP request before sending IPFIX packet

vn.org> wrote: On Fri, May 18, 2018 at 03:16:43PM -0700, Sairam Venugopal wrote: > IPFIX templates and flow packets are silently dropped when a corresponding > ARP entry is missing for the Collector. The fix is to explicitly trigger an > ARP request before sending UDP

[ovs-dev] [PATCH v3] ofproto-collectors: Windows - Trigger an ARP request before sending IPFIX packet

-by: Sairam Venugopal <vsai...@vmware.com> --- ofproto/collectors.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/ofproto/collectors.c b/ofproto/collectors.c index bc92332..4ce290e 100644 --- a/ofproto/collectors.c +++ b/ofproto/collectors.c @@ -27,11

[ovs-dev] [PATCH v2] Windows: Trigger an ARP request before sending IPFIX packet

-by: Sairam Venugopal <vsai...@vmware.com> --- ofproto/collectors.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/ofproto/collectors.c b/ofproto/collectors.c index bc92332..4ce290e 100644 --- a/ofproto/collectors.c +++ b/ofproto/collectors.c @@ -27,11

Re: [ovs-dev] [PATCH] Windows: Trigger an ARP request before sending IPFIX packet

Will send out a V2 with the correct Commit Msg Title. Consider this as an RFC. On 5/8/18, 10:07 AM, "Sairam Venugopal" <vsai...@vmware.com> wrote: IPFIX templates and flow packets are silently dropped when a corresponding ARP entry is missing for the Collector. The fix

[ovs-dev] [PATCH] Windows: Trigger an ARP request before sending IPFIX packet

-by: Sairam Venugopal <vsai...@vmware.com> --- ofproto/collectors.c | 25 + 1 file changed, 25 insertions(+) diff --git a/ofproto/collectors.c b/ofproto/collectors.c index bc92332..239599a 100644 --- a/ofproto/collectors.c +++ b/ofproto/collectors.c @@ -27,11

Re: [ovs-dev] [PATCH] datapath-windows: Update ct stats when packet is processed by conntrack

Anand, Thanks for the patch. Can you update the commit message to better describe the underlying issue? Prevent conntrack-counters from getting redundantly incremented for recirculated packets. The counters ought to be incremented only if it's a new lookup or if it's recirculated through a

[ovs-dev] [PATCH] datapath-windows: Block established TCP connections from creating new CT Entry

Established TCP Connections could potentially form invalid Conntrack Entries when OVS is getting installed or the Conntrack Flows are applied. Prevent this from happening by explicitly requiring SYN packets to be present for creating new Conntrack entries. Signed-off-by: Sairam Venugopal <v

Re: [ovs-dev] [PATCH] datapath-windows: Fix static analysis in Stt.c

Didn't realize this patch wasn't acked. Please push this in. Acked-by: Sairam Venugopal <vsai...@vmware.com> Thanks, Sairam On 2/8/18, 9:31 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aser

Re: [ovs-dev] [PATCH] lib/unaligned.h - Fix C++ compiler issue with BUILD_ASSERT on Windows

uess that's what you mean when you say C++?) and in C++11? >That is the goal. I am sure that it can be done. If it should be done >without static_assert for languages that do not support static_assert, >or do not support static_assert in an expression, then that's fine with >me. > >

Re: [ovs-dev] [PATCH] lib/unaligned.h - Fix C++ compiler issue with BUILD_ASSERT on Windows

ase: > >#elif defined(__cplusplus) && __cplusplus >= 201103L >#define BUILD_ASSERT(EXPR) static_assert(EXPR, "assertion failed") > >The post you cite implies that adding []{...} to the definition above >would fix the problem. Is that correct? > >On Wed,

Re: [ovs-dev] [PATCH] lib/unaligned.h - Fix C++ compiler issue with BUILD_ASSERT on Windows

for the time being since we will need to fix this on both Linux and Windows. Thanks, Sairam On 12/19/17, 3:45 PM, "Ben Pfaff" <b...@ovn.org> wrote: >On Tue, Dec 19, 2017 at 03:32:27PM -0800, Sairam Venugopal wrote: >> A static assert declaration may appear a

[ovs-dev] [PATCH] lib/unaligned.h - Fix C++ compiler issue with BUILD_ASSERT on Windows

-by: Sairam Venugopal <vsai...@vmware.com> --- lib/unaligned.h | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/lib/unaligned.h b/lib/unaligned.h index f40e4e1..6bc9063 100644 --- a/lib/unaligned.h +++ b/lib/unaligned.h @@ -51,12 +51,27 @@ static inlin

Re: [ovs-dev] [PATCH v2] windows/lib: Fix Windows C++ compilation issues on common headers

und why this workaround is required. Thanks, Sairam On 12/14/17, 2:12 PM, "Ben Pfaff" <b...@ovn.org> wrote: >On Wed, Dec 13, 2017 at 04:13:20PM -0800, Sairam Venugopal wrote: >> Found when compiling the code with C++ binaries. Most of the issues are >> due to m

[ovs-dev] [PATCH v2] windows/lib: Fix Windows C++ compilation issues on common headers

the padded size. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> Signed-off-by: Shireesh Kumar Singh <shireesh...@vmware.com> Co-authored-by: Shireesh Kumar Singh <shireesh...@vmware.com> --- AUTHORS.rst| 1 + include/openvswitch/util.h | 14 +---

Re: [ovs-dev] [PATCH] datapath-windows: Correct endianness for deleting zone.

.@openvswitch.org; Alin Gabriel Serdean <aserd...@ovn.org>; >> Sairam Venugopal <vsai...@vmware.com> >> Subject: [ovs-dev] [PATCH] datapath-windows: Correct endianness for >> deleting zone. >> >> The zone Netlink attribute is supposed to be in network-byte ord

Re: [ovs-dev] [PATCH] datapath-windows: Correct endianness for deleting zone.

Thanks for the patch. Discussed about the patch offline. This is required since we have now introduced a newer api for deleting 5-tuples and this breaks the assumption of zone-id not being in the right byte order. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 12/4/17, 11

[ovs-dev] [PATCH v2] windows/lib: Fix Windows C++ compilation issues on common headers

Found when compiling the code with C++ binaries. Most of the issues are due to missing explicit cast. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> Signed-off-by: Shireesh Kumar Singh <shireesh...@vmware.com> Co-authored-by: Shireesh Kumar Singh <shireesh...@vmware.com>

[ovs-dev] [PATCH] windows/lib: Fix Windows C++ compilation issues on common headers

Found when compiling the code with C++ binaries. Most of the issues are due to missing explicit cast. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> Signed-off-by: Shireesh Kumar Singh <shireesh...@vmware.com> Co-authored-by: Shireesh Kumar Singh <shireesh...@vmware.co

Re: [ovs-dev] [PATCH v2] datapath-windows: Update OvsIPv4TunnelKey flags in geneve decap.

Thanks for fixing this. Alin/Guru - Can we back port this to 2.8 too? This causes flow misses when geneve options are present. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 10/19/17, 1:26 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" <ovs-dev-boun

Re: [ovs-dev] [PATCH] datapath-windows: Update OvsIPv4TunnelKey flags in geneve decap.

:45 PM, "ovs-dev-boun...@openvswitch.org on behalf of Sairam Venugopal" <ovs-dev-boun...@openvswitch.org on behalf of vsai...@vmware.com> wrote: >Thanks for fixing this. Should we check for geneveHdr->opts before setting >OVS_TNL_F_GENEVE_OPT? > >I know the cur

Re: [ovs-dev] [PATCH] datapath-windows: Update OvsIPv4TunnelKey flags in geneve decap.

Thanks for fixing this. Should we check for geneveHdr->opts before setting OVS_TNL_F_GENEVE_OPT? I know the current code maintains consistency with Linux. But we need to understand if this is intended. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 10/17/17, 5:31 PM, &quo

Re: [ovs-dev] [PATCH] datapath-windows: Remove the workaround in NAT for TCP checksum

Hi Alin, Any update on this one? I believe you had raised this issue and had sent out a patch to address this earlier. Thanks, Sairam On 9/15/17, 3:04 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" wrote:

Re: [ovs-dev] [PATCH] datapath-windows: Increment ct packet counters based on ct_state.

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 9/5/17, 4:53 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" <ovs-dev-boun...@openvswitch.org on behalf of kumaran...@vmware.com> wrote: >For a given packet, packet counters in conntrack should be a

Re: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call to OvsInitForwardingCtx

Good catch. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 8/30/17, 4:03 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" <ovs-dev-boun...@openvswitch.org on behalf of kumaran...@vmware.com> wrote: >Only curNbl in the forwarding co

[ovs-dev] [PATCH v2] datapath-windows: Add an upper limit to conntrack entries

The current implementation lacked an upper bound of number of entries in the system. Set the size to ~2M (2^21) for the time being. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Conntrack.c | 10 ++ datapath-windows/ovsext/Conntrack.h | 1 + 2

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

Please check the comments inline. Thanks, Sairam On 8/28/17, 8:55 PM, "Shashank Ram" <r...@vmware.com> wrote: > > > > >From: ovs-dev-boun...@openvswitch.org <ovs-dev-boun...@openvswitch.org> on >behalf of Sai

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

v-boun...@openvswitch.org on behalf of Sairam >Venugopal" <ovs-dev-boun...@openvswitch.org on behalf of vsai...@vmware.com> >wrote: > >The current implementation lacked an upper bound of number of entries in >the system. Set the size to ~2M (2^21) for the tim

[ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

The current implementation lacked an upper bound of number of entries in the system. Set the size to ~2M (2^21) for the time being. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Conntrack.c | 6 ++ datapath-windows/ovsext/Conntrack.h | 1 + 2 files c

Re: [ovs-dev] [PATCH] datapath-windows: Update ICMP-Type and Code comparison in CT lookup

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 8/11/17, 1:41 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" <ovs-dev-boun...@openvswitch.org on behalf of kumaran...@vmware.com> wrote: > - Update the CT comparison function to compare

Re: [ovs-dev] [PATCH] datapath-windows: Do not modify port field for ICMP during SNAT/DNAT

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 8/10/17, 8:59 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" <ovs-dev-boun...@openvswitch.org on behalf of kumaran...@vmware.com> wrote: >During SNAT/DNAT, we should not be updating the port fie

Re: [ovs-dev] [PATCH v2] datapath-windows: Include ICMP type and code fields to find a matching ct entry

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 6/23/17, 2:05 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" <ovs-dev-boun...@openvswitch.org on behalf of kumaran...@vmware.com> wrote: >In conntrack lookup, ICMP type and code fields were not

Re: [ovs-dev] [PATCH] datapath-windows: Include ICMP type and code fields to find a matching ct entry

Hi Anand, Can you split this patch up instead to handle Conntrack.c and Conntrack-Nat.c in a separate one? This way we can keep the testing isolated to the changes. Acking Conntrack.c change: Acked-by: Sairam Venugopal <vsai...@vmware.com> On 6/22/17, 11:54 AM, "o

Re: [ovs-dev] [PATCH v2] datapath-windows: Add support for UPDATE events in Conntrack

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 6/21/17, 1:33 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" <ovs-dev-boun...@openvswitch.org on behalf of kumaran...@vmware.com> wrote: >Introduce a new event type OVS_EVENT_CT_UPDATE to send a

[ovs-dev] [PATCH] datapath-windows: Fix switch-case alignments in Conntrack.c

Minor - Fix the switch case alignments. Found by inspection. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Conntrack.c | 83 ++--- 1 file changed, 41 insertions(+), 42 deletions(-) diff --git a/datapath-windows/

Re: [ovs-dev] [PATCH] datapath-windows: Fix potential memory leak while creating conntrack entry

-dev-boun...@openvswitch.org> on >behalf of Sairam Venugopal <vsai...@vmware.com> >Sent: Tuesday, June 20, 2017 1:36 PM >To: d...@openvswitch.org >Subject: [ovs-dev] [PATCH] datapath-windows: Fix potential memory leak while > creating conntrack entry > &g

[ovs-dev] [PATCH v2] datapath-windows: Fix potential memory leak while creating conntrack entry

shed Conntrack Entries while traffic was flowing. - Uninstalled and re-installed the driver when traffic was in progress. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Conntrack.c | 123 +--- 1 file changed, 57 insertions(+), 66

Re: [ovs-dev] [PATCH] datapath-windows: Fix potential memory leak while creating conntrack entry

Hi Yin, I would keep it separate. The main intent of this patch is to fix the memory leak and reduce the redundancy in the OvsCtCreateEntry switch cases. Thanks, Sairam From: Yin Lin Date: Tuesday, June 20, 2017 at 3:54 PM To: Sairam Venugopal, "d...@openvswitch.org<mailto:d...@openvsw

Re: [ovs-dev] [PATCH] windows: Remove vlog_init() from service_start function

Alin, Thanks for looking into this! Acked-by: Sairam Venugopal <vsai...@vmware.com> On 6/20/17, 12:14 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >Unit te

Re: [ovs-dev] [PATCH] tests: switch from signed to unsigned when formatting

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 6/20/17, 12:44 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >x->errline is a signed int >(https://url

Re: [ovs-dev] [PATCH] datapath-windows: Add validations for IP_HEADER_LEN

Thanks for patching this. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 6/15/17, 3:15 PM, "ovs-dev-boun...@openvswitch.org on behalf of Shashank Ram" <ovs-dev-boun...@openvswitch.org on behalf of r...@vmware.com> wrote: >Adds validations in OvsGetIp() to mak

[ovs-dev] [PATCH] datapath-windows: Fix potential memory leak while creating conntrack entry

shed Conntrack Entries while traffic was flowing. - Uninstalled and re-installed the driver when traffic was in progress. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Conntrack.c | 59 + 1 file changed, 27 insertions(+), 32

Re: [ovs-dev] [PATCH] datapath-windows: add open flow defines to Types.h

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 6/20/17, 7:59 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >Commit >https://urldefense.p

Re: [ovs-dev] [PATCH v2] datapath-windows: Add validations in fragmentation module

Thanks for adding in the CVE. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 6/9/17, 7:54 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" <ovs-dev-boun...@openvswitch.org on behalf of kumaran...@vmware.com> wrote: >- Minimum valid fragment size i

Re: [ovs-dev] [PATCH] datapath-windows: Add support for UPDATE events in Conntrack

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 6/12/17, 10:21 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" <ovs-dev-boun...@openvswitch.org on behalf of kumaran...@vmware.com> wrote: > - Parse netlink ct attr OVS_CT_ATTR_EVENTMASK >

Re: [ovs-dev] [PATCH] datapath-windows: use NlAttrGet() in Conntrack.c

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 6/14/17, 4:01 PM, "ovs-dev-boun...@openvswitch.org on behalf of Nithin Raju" <ovs-dev-boun...@openvswitch.org on behalf of nit...@vmware.com> wrote: >Couple of minor fixes that got flagged with a static checker.

Re: [ovs-dev] [PATCH] datapath-windows: Define NAT_ACTION enum correctly

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 6/15/17, 12:46 PM, "ovs-dev-boun...@openvswitch.org on behalf of Shashank Ram" <ovs-dev-boun...@openvswitch.org on behalf of r...@vmware.com> wrote: >The existing code throws a warning when compiled >with t

[ovs-dev] [PATCH] datapath-windows: Zero initialize Conntrack-ICMP entry

Set conntrack-icmp entry to {0}. Add some compile time asserts to ensure that conn_* struct's first member is OVS_CT_ENTRY. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Conntrack-icmp.c | 3 ++- datapath-windows/ovsext/Conntrack-other.c | 1 + da

[ovs-dev] [PATCH] datapath-windows: Add original conntrack tuple to FlowKey

Add the original tuple to Flow Key. In case of ICMP and UDP, default the parent entry to NULL until related connections is supported. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Conntrack.c | 35 - datapath-windows/ovsext/DpInte

[ovs-dev] [PATCH] ofproto-dpif: Include EthType in ct_orig_tuple feature probe

Set flow->dl_type to either ETH_TYPE_IP or ETH_TYPE_IPV6 when probing for ct_orig_tuple feature support. This can be expanded later on to check for both IPv4 and IPv6 support. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- ofproto/ofproto-dpif.c | 13 - 1 file c

Re: [ovs-dev] [PATCH] lib Windows: Use xmalloc instead of malloc

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 5/19/17, 2:38 PM, "ovs-dev-boun...@openvswitch.org on behalf of Shashank Ram" <ovs-dev-boun...@openvswitch.org on behalf of r...@vmware.com> wrote: >xmalloc checks if the size is valid before allocating >memory

Re: [ovs-dev] [PATCH v7 2/4] datapath-windows: Add NAT module in conntrack

he remaining >ones in the inline comments. > >-Original Message- >From: Sairam Venugopal >Sent: Tuesday, May 16, 2017 4:50 PM >To: Yin Lin <li...@vmware.com>; d...@openvswitch.org >Subject: Re: [ovs-dev] [PATCH v7 2/4] datapath-windows: Add NAT module in >conntrack &

Re: [ovs-dev] [PATCH v7 3/4] datapath-windows: NAT integration with conntrack

Please find my comments inline. Thanks, Sairam On 5/9/17, 3:59 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yin Lin" wrote: >This patch integrates NAT module with existing conntrack module. NAT >action is now supported. >

Re: [ovs-dev] [PATCH v7 2/4] datapath-windows: Add NAT module in conntrack

Hi Yin, Thanks for the patch. Please find my comments inline. Thanks, Sairam On 5/9/17, 3:59 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yin Lin" wrote: >Signed-off-by: Yin Lin >--- >

Re: [ovs-dev] [PATCH v7 1/4] datapath-windows: Add support for NAT in conntrack

Looks like outlook messed up my formatting. I had 2 comments in this patch. The default case statement is missing and 2 other cases aren't handled: case OVS_NAT_ATTR_UNSPEC: break; case __OVS_NAT_ATTR_MAX: break; default: ; OvsCtExecute_ - parameters exceed

Re: [ovs-dev] [PATCH v7 1/4] datapath-windows: Add support for NAT in conntrack

Not sure why the "From: Anand Kumar <kumaran...@vmware.com>” shows up in the commit description. Since they are already listed as co-author, it should be safe to remove this. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 5/9/17, 3:59 PM, "ovs-dev-boun...@ope

Re: [ovs-dev] [PATCH v6 3/4] datapath-windows: NAT integration with conntrack

Hi Yin, Thanks for the patches. I had some immediate review comments. - OvsUpdateAddressAndPort does not have a return type - Refrain from changing other code that your patch does not require. Please send out separate incremental patch. - This is the correct way to define static inline

Re: [ovs-dev] [PATCH v6 4/4] Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com>

Yin, Can you rebase and rebuild your changes? OvsTcpSegmentNBL arguments have changed and this patch breaks compilation. Can you add commit msgs to your patches? This commit title says: "Signed-off-by:Alin Gabriel…” Can you fix this? Thanks, Sairam On 5/8/17, 3:38 PM,

[ovs-dev] [PATCH v3] Windows: Secure the namedpipe implementation

Update the security policies around the creation of the namedpipe. The current security updates restrict how the namedpipe can be accessed. - Disable Network access - Windows Services can access the namedpipe - Administrators can access the namedpipe Signed-off-by: Sairam Venugopal <v

Re: [ovs-dev] [PATCH v2] Windows: Secure the namedpipe implementation

>> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >> boun...@openvswitch.org] On Behalf Of Sairam Venugopal >> Sent: Friday, May 5, 2017 9:30 PM >> To: d...@openvswitch.org >> Subject: [ovs-dev] [PATCH v2] Windows: Secure the namedpipe >> implementation >> &g

Re: [ovs-dev] [PATCH] windows: fix broken build

Thanks for fixing this. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 5/5/17, 1:20 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >The Windows build is fai

Re: [ovs-dev] [PATCH] Windows: Secure the namedpipe implementation

Hi Ben, Thanks for taking the time to review this. I will address the coding style changes along with other potential comments in the next version. Thanks, Sairam On 5/3/17, 1:05 PM, "Ben Pfaff" <b...@ovn.org> wrote: >On Wed, May 03, 2017 at 12:22:48PM -0700, Sai

[ovs-dev] [PATCH] Windows: Secure the namedpipe implementation

Update the security policies around the creation of the namedpipe. The current security updates restrict how the namedpipe can be accessed. - Disable Network access - Windows Services can access the namedpipe - Administrators can access the namedpipe Signed-off-by: Sairam Venugopal <v

Re: [ovs-dev] [PATCH] datapath-windows: Add missing IPCT_LABEL.

Thanks for adding this in. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 4/19/17, 7:01 PM, "ovs-dev-boun...@openvswitch.org on behalf of Jarno Rajahalme" <ovs-dev-boun...@openvswitch.org on behalf of ja...@ovn.org> wrote: >Add the missing enum definition for

Re: [ovs-dev] [PATCH v6 5/5] datapath-windows: Fragment NBL based on MRU size

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 3/24/17, 1:51 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" <ovs-dev-boun...@openvswitch.org on behalf of kumaran...@vmware.com> wrote: >This patch adds support for Fragmenting NBL based on

Re: [ovs-dev] [PATCH v6 4/5] datapath-windows: Updated OvsTcpSegmentNBL to handle IP fragments.

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 3/24/17, 1:51 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" <ovs-dev-boun...@openvswitch.org on behalf of kumaran...@vmware.com> wrote: >With this patch, OvsTcpSegmentNBL not only supports fragmen

Re: [ovs-dev] [PATCH v6 3/5] datapath-windows: Retain MRU value in the _OVS_BUFFER_CONTEXT.

Thanks for incorporating this change. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 3/24/17, 1:51 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" <ovs-dev-boun...@openvswitch.org on behalf of kumaran...@vmware.com> wrote: >This patch introduce

Re: [ovs-dev] [PATCH v6 1/5] datapath-windows: Added a new file to support Ipv4 fragments.

Thanks for the patches! Acked-by: Sairam Venugopal <vsai...@vmware.com> On 3/24/17, 1:51 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" <ovs-dev-boun...@openvswitch.org on behalf of kumaran...@vmware.com> wrote: >This patch adds functionalities

Re: [ovs-dev] [PATCH 2/3 v2] datapath-windows: Add NAT module in conntrack

Hi Yin, Thanks for sending over the patch. While it looks good for the most part, there are certain indentations that need fixing. I will send those out separately. I see that you have allocated - ovsNatLock and have added in stubs for flush and cleanup similar to Conntrack.c. However, I

[ovs-dev] [PATCH] datapath-windows: Add support for OVS_CT_ATTR_FORCE_COMMIT

Add support for handling OVS_CT_ATTR_FORCE_COMMIT in Conntrack action. When this flag is specified, it implicitly means commit and deletes entries in the reverse direction. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Conntrack.c | 20 +

Re: [ovs-dev] [PATCH] datapath-windows: Trigger conntrack event after setting mark and label

until Mark and Label are present. Thanks, Sairam From: Shashank Ram Date: Thursday, March 2, 2017 at 2:05 PM To: Sairam Venugopal, "d...@openvswitch.org<mailto:d...@openvswitch.org>" Subject: Re: [ovs-dev] [PATCH] datapath-windows: Trigger conntrack event after setting mark and la

Re: [ovs-dev] [PATCH 07/10] windows: add include to stream-windows.c

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 2/5/17, 8:41 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >fatal_signal_unlink_file_now is used but the

Re: [ovs-dev] [PATCH 03/10] windows: add includes to daemon-windows

Why should _getpid() be replaced with the other function? Thanks, Sairam On 2/5/17, 8:41 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >Add fatal-signal.h include since it uses:

Re: [ovs-dev] [PATCH 05/10] windows: fix calls in netlink-socket

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 2/5/17, 8:41 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >Add nl_sock_transact forward declaration, since

Re: [ovs-dev] [PATCH 04/10] windows: add forward declaration to dpif-netlink

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 2/5/17, 8:41 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >dpif_netlink_port_query__ is used before it is d

Re: [ovs-dev] [PATCH 01/10] windows: Add definition of getrusage

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 2/5/17, 8:41 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >getrusage is implemented in lib/getrusage-wind

Re: [ovs-dev] [PATCH 02/10] windows: add definition of getpid and getcwd

Shouldn’t we cast the DWORD to unsigned int for the GetCurrentProcessId? On 2/5/17, 8:41 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >getcwd - is used in lib/util.c. getcwd is

Re: [ovs-dev] [PATCH] windows: Remove dead code in daemon-windows

Commit message should probably say - unused code instead of dead code. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 2/5/17, 3:49 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbaseso

  1   2   >