[ovs-dev] [PATCH] datapath-windows: Add guards around IpHelper adapter binding calls

Protect internal adapter up/down calls with a dispatch lock. It was observed that the InternalAdapter bind calls could happen out of order thereby causing encap packets to not be sent properly. Add assert around the IpHelper bind calls to ensure Up/Down gets called only for the appropriate

Re: [ovs-dev] [PATCH] faq: Update features supported on Hyper-V

Acked-by: Sairam Venugopal On 3/11/19, 1:48 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar via dev" wrote: These features were added a while back, so updating the documentation. Signed-off-by: Anand Kumar --- Documentation/faq/releases.rst | 6

Re: [ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

Acked-by: Sairam Venugopal On 2/27/19, 6:10 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: When using a vport we need to guard its usage with the dispatch lock. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/User.c | 16

Re: [ovs-dev] [PATCH] datapath-windows: Add annotations to find vport functions

Acked-by: Sairam Venugopal On 2/27/19, 9:34 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: Add annotations to find vport functions to check if the dispatch lock is held. Signed-off-by: Alin Gabriel Serdean ---

[ovs-dev] [PATCH] datapath-windows: Fix nbl cleanup when memory allocation fails

StartNblIngressError should be called only when an NBL hasn't been modified. In this case the nbl context was initialized. Rely on existing packet completion mechanism to cleanup the NBL. Found while testing with DriverVerifier with limited memory setting enabled. Signed-off-by: Sairam Venugopal

Re: [ovs-dev] Author should not be mailing list

Not really. I subscribed using my regular work email. This was the last patch that was delivered properly - https://patchwork.ozlabs.org/patch/997861/ Were there any changes done to the mailing list in the past 3 - 4 months? Thanks, Sairam On 2/27/19, 12:25 PM, "Aaron Conole" wrote:

Re: [ovs-dev] Author should not be mailing list

This is in regards to “Author should not be mailing list” issue where the from field in the email gets replaced with ovs-dev@openvswitch.org. Thanks, Sairam From: Sairam Venugopal Date: Wednesday, February 27, 2019 at 11:43 AM To: Ben Pfaff , Aaron Conole Cc:

[ovs-dev] Author should not be mailing list

Hey Ben/Aaron, Is there a known fix for this issue? I sent my commit to d...@openvswitch.org and ran into this. Currently all patches from the mailing list on patchwork show up under my name -

Re: [ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

Do we need to keep the dispatchLock for reading vport structures? If that's the case, then we will need to fix it in other areas of the code too. It would be better to move the locking inside the relevant vport.c functions instead of taking out global ones. Thanks, Sairam On 2/27/19, 6:10

[ovs-dev] [PATCH v2] datapath-windows: Fix potential deadlock in event subscription

Move the EventQueue lock acquisition after the dispatchLock to prevent a potential deadlock in port creation pipeline. There could be a case where a port event could try to take up the Dispatch Lock before the Event Queue lock and the subscription queue event could take up the event queue lock

[ovs-dev] [PATCH] datapath-windows: Fix potential deadlock in event subscription

Move the EventQueue lock acquisition after the dispatchLock to prevent a potential deadlock in port creation pipeline. There could be a case where a port event could try to take up the Dispatch Lock before the Event Queue lock and the subscription queue event could take up the event queue lock

[ovs-dev] [PATCH] datapath-windows: Fix race condition during port creation

Hold the dispatch lock until port-add operations are completed. Found by inspection. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Vport.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c index