Re: [ovs-dev] [BUG] ovs-ofctl version 2.5.0 will crash with OFPFMFC_BAD_COMMAND

2017-01-13 Thread Samuel Jean via dev
Thanks for the quick follow up Ben,

So we'll indeed try against latest versions to rule out the possibility of
a bug that has been fixed already although I could not find any commit with
such mention.  We'll report back here.

At this moment, we can reproduce over and over within minutes.  We've
nailed down -- or at least we think -- to something related to race
condition or memory overwrite between the time connection negotiation
happens and the flow mod packet arrives.  We've been able to run the stress
test for hours when we used --flow-format=NXM+table_id as an argument to
ovs-ofctl but eventually, we've hit the same error.

Sagar is spending more time debugging this issue so maybe he'll be able to
provide more information.

On Fri, Jan 13, 2017 at 1:45 PM, Ben Pfaff <b...@ovn.org> wrote:

> On Thu, Jan 12, 2017 at 03:54:42PM -0500, Samuel Jean via dev wrote:
> > It seems that shelling out to ovs-ofctl very quickly can lead to bug
> where
> > it reports an OFPT_ERROR.
> >
> > We were able to constantly reproduce within minutes of running the above
> > flow modifications on Unbutu.
> >
> > Any help, hints or guidance would be appreciated.  I'd be happy to pursue
> > some debugging that would be required to nail down the issue here.
>
> Thanks for the bug report and especially for the detailed reproduction
> advice.
>
> I've now tried running this reproduction case against Open vSwitch from
> latest master and against the latest versions from the 2.6.x and 2.5.x
> branches, and I can't see any failures even after letting the script run
> for a few minutes.
>
> Maybe you should try 2.5.1 or the latest from branch-2.5 and see if it
> fixes the problem?  And if not, then we'll have to figure out what's
> different between your setup and mine.
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


[ovs-dev] [BUG] ovs-ofctl version 2.5.0 will crash with OFPFMFC_BAD_COMMAND

2017-01-12 Thread Samuel Jean via dev
Hi,

It seems that shelling out to ovs-ofctl very quickly can lead to bug where
it reports an OFPT_ERROR.

We were able to constantly reproduce within minutes of running the above
flow modifications on Unbutu.

Any help, hints or guidance would be appreciated.  I'd be happy to pursue
some debugging that would be required to nail down the issue here.

Best regards,
Sam Jean

# cat ./ofpcrash.sh
#!/bin/sh
ovs-ofctl add-flow br0
'priority=100,table=25,idle_timeout=0,actions=resubmit(,35)' || exit 1
ovs-ofctl add-flow br0
'priority=100,table=35,idle_timeout=0,actions=resubmit(,45)' || exit 1
ovs-ofctl add-flow br0
'priority=100,table=45,idle_timeout=0,actions=resubmit(,50)' || exit 1
ovs-ofctl add-flow br0
'priority=100,table=50,idle_timeout=0,actions=resubmit(,65)' || exit 1
ovs-ofctl add-flow br0
'priority=100,table=65,idle_timeout=0,actions=output:1' || exit 1
ovs-ofctl add-flow br0
'priority=3000,ip,dl_dst=01:00:00:00:00:00/01:00:00:00:00:00,table=0,idle_timeout=0,actions=drop'
|| exit 1
ovs-ofctl add-flow br0
'priority=1000,ip,in_port=1,dl_dst=0c:01:00:12:cf:01,table=0,idle_timeout=0,cookie=20250774994944,actions=resubmit(,25)'
|| exit 1

# while true; do ./ofpcrash.sh || break; done
OFPT_ERROR (xid=0x4): OFPFMFC_BAD_COMMAND
OFPT_FLOW_MOD (xid=0x4):
(***truncated to 64 bytes from 88***)
  01 0e 00 58 00 00 00 04-00 38 20 ff 00 00 00 00 |...X.8 .|
0010  00 00 00 00 00 00 00 00-00 00 00 00 00 00 00 00 ||
0020  00 00 00 00 00 00 00 00-00 00 00 00 00 00 00 00 ||
0030  00 00 00 00 00 00 00 00-32 00 00 00 00 00 00 64 |2..d|

# ovs-ofctl --version
ovs-ofctl (Open vSwitch) 2.5.0
Compiled Sep 15 2016 12:55:18
OpenFlow versions 0x1:0x4

# uname -srmvp
Linux 3.13.0-100-generic #147-Ubuntu SMP Tue Oct 18 16:48:51 UTC 2016
x86_64 x86_64
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev