Re: [ovs-dev] [PATCH] tnl-neigh: Use outgoing ofproto version.

2019-08-14 Thread Vasu Dasari
Looks good Flavio. Acked-By: Vasu Dasari Thanks -Vasu *Vasu Dasari* On Tue, Aug 13, 2019 at 12:45 PM Flavio Leitner via dev < ovs-dev@openvswitch.org> wrote: > On Tue, Aug 13, 2019 at 01:34:04PM -0300, Flavio Leitner via dev wrote: > > When a packet needs to be encapsulat

Re: [ovs-dev] [PATCH v4] tnl-neigh-cache: Purge learnt neighbors when port/bridge is deleted

2019-07-22 Thread Vasu Dasari
Thanks Ben. *Vasu Dasari* On Mon, Jul 22, 2019 at 12:30 PM Ben Pfaff wrote: > On Tue, Jul 16, 2019 at 10:54:31AM -0400, Vasu Dasari wrote: > > Say an ARP entry is learnt on a OVS port and when such a port is deleted, > > learnt entry should be removed from the port. It would h

Re: [ovs-dev] [PATCH v2] ovs-macros: An option to suspend test execution on error

2019-07-16 Thread Vasu Dasari
Thanks Ben and Aaron for your review and comments. *Vasu Dasari* On Tue, Jul 16, 2019 at 12:57 PM Ben Pfaff wrote: > On Mon, Jul 15, 2019 at 05:15:01PM -0400, Vasu Dasari wrote: > > Origins for this patch are captured at > > https://mail.openvswitch.org/pipermail/ovs-discuss/2

[ovs-dev] [PATCH v4] tnl-neigh-cache: Purge learnt neighbors when port/bridge is deleted

2019-07-16 Thread Vasu Dasari
are added and removed on deletion of a ports and bridges. Discussion for this addition is at: https://mail.openvswitch.org/pipermail/ovs-discuss/2019-June/048754.html Signed-off-by: Vasu Dasari Reviewed-by: Flavio Fernandes Reviewed-by: Ben Pfaff --- --- v1 -> v2: Incorporate robot comme

Re: [ovs-dev] [PATCH v1] ovs-macros: An option to suspend test execution on error

2019-07-15 Thread Vasu Dasari
Done. Patch is at: [ovs-dev] [PATCH v2] ovs-macros: An option to suspend test execution on error <https://mail.openvswitch.org/pipermail/ovs-dev/2019-July/360720.html> <https://mail.openvswitch.org/pipermail/ovs-dev/2019-July/360720.html> *Vasu Dasari* On Mon, Jul 15, 2019 at

[ovs-dev] [PATCH v2] ovs-macros: An option to suspend test execution on error

2019-07-15 Thread Vasu Dasari
make check TESTSUITEFLAGS='-v' Signed-off-by: Vasu Dasari Reviewed-by: Ben Pfaff Reviewed-by: Aaron Conole --- v0 -> v1: Discussion at: https://mail.openvswitch.org/pipermail/ovs-dev/2019-July/360589.html 1. Incorporated review commanets from Ben. 2. Changed topics/testing.rst to docum

Re: [ovs-dev] [PATCH v1] ovs-macros: An option to suspend test execution on error

2019-07-15 Thread Vasu Dasari
at_verbose variable. I hope it is ok to use the at_verbose variable. -Vasu *Vasu Dasari* On Mon, Jul 15, 2019 at 3:59 PM Ben Pfaff wrote: > On Mon, Jul 15, 2019 at 03:22:42PM -0400, Vasu Dasari wrote: > > Origins for this patch are captured at > > https://mail.openvswitch.org/piperm

Re: [ovs-dev] [PATCH v1] ovs-macros: An option to suspend test execution on error

2019-07-15 Thread Vasu Dasari
Aaron, I see that documentation for topics/testing is mostly one liners and precise. And hence I chose one liner as well. If I have to put all your recommended test, I think it is better to have a subsection, "Debugging unit tests". What do you think? -Vasu *Vasu Dasari* On Mon, Ju

[ovs-dev] [PATCH v1] ovs-macros: An option to suspend test execution on error

2019-07-15 Thread Vasu Dasari
make check TESTSUITEFLAGS='-v' Signed-off-by: Vasu Dasari Reviewed-by: Ben Pfaff --- v0 -> v1: Discussion at: https://mail.openvswitch.org/pipermail/ovs-dev/2019-July/360589.html 1. Incorporated review commanets from Ben. 2. Changed topics/testing.rst to document this trick 3. Made this tr

Re: [ovs-dev] [PATCH] ovs-macros: An option to suspend test execution on error

2019-07-15 Thread Vasu Dasari
Please ignore this. *Vasu Dasari* On Mon, Jul 15, 2019 at 3:22 PM Vasu Dasari wrote: > Origins for this patch are captured at > https://mail.openvswitch.org/pipermail/ovs-discuss/2019-June/048923.html. > > Summarizing here, when a test fails, it would be good to pause test

[ovs-dev] [PATCH] ovs-macros: An option to suspend test execution on error

2019-07-15 Thread Vasu Dasari
make check TESTSUITEFLAGS='-v' Signed-off-by: Vasu Dasari Reviewed-by: Ben Pfaff --- v0 -> v1: Discussion at: https://mail.openvswitch.org/pipermail/ovs-dev/2019-July/360589.html 1. Incorporated review commanets from Ben. 2. Changed topics/testing.rst to document this trick 3. Made this tr

Re: [ovs-dev] [PATCH] ovs-macros: An option to suspend test execution on error

2019-07-12 Thread Vasu Dasari
Sure. Will do. *Vasu Dasari* On Fri, Jul 12, 2019 at 12:08 PM Ben Pfaff wrote: > On Fri, Jul 12, 2019 at 08:42:51AM -0700, Ben Pfaff wrote: > > On Thu, Jul 11, 2019 at 11:46:04AM -0400, Vasu Dasari wrote: > > > Origins for this patch are captured at > > > >

Re: [ovs-dev] [PATCH] ovs-macros: An option to suspend test execution on error

2019-07-12 Thread Vasu Dasari
Thanks. Will do. *Vasu Dasari* On Fri, Jul 12, 2019 at 11:43 AM Ben Pfaff wrote: > On Thu, Jul 11, 2019 at 11:46:04AM -0400, Vasu Dasari wrote: > > Origins for this patch are captured at > > https://mail.openvswitch.org/pipermail/ovs-discuss/2019-June/048923.html > . > &

[ovs-dev] [PATCH] ovs-macros: An option to suspend test execution on error

2019-07-11 Thread Vasu Dasari
: = And from another window, one can execute ovs-xxx commands like: export OVS_RUNDIR=/opt/vdasari/Developer/ovs/_build-gcc/tests/system-userspace-testsuite.dir/139 $ ovs-ofctl dump-ports br0 . . Signed-off-by: Vasu Dasari --- tests/ovs-macros.at | 27

[ovs-dev] [PATCH v3] tnl-neigh-cache: Purge learnt neighbors when port/bridge is deleted

2019-07-10 Thread Vasu Dasari
are added and removed on deletion of a ports and bridges. Discussion for this addition is at: https://mail.openvswitch.org/pipermail/ovs-discuss/2019-June/048754.html Signed-off-by: Vasu Dasari Acked-by: Flavio Fernandes Acked-by: Ben Pfaff --- v1 -> v2: Incorporate robot comments. Verif

Re: [ovs-dev] [PATCH] tnl-neigh-cache: Purge learnt neighbors when port/bridge is deleted

2019-07-09 Thread Vasu Dasari
My comments inline: On Mon, Jul 8, 2019 at 9:41 AM Flavio Leitner wrote: > On Tue, Jul 02, 2019 at 08:50:16PM -0400, Vasu Dasari wrote: > > Hi Flavio, > > > > I am trying to emulate the test case scenario you mentioned earlier, > where > > in we need to clean you n

Re: [ovs-dev] [PATCH] tnl-neigh-cache: Purge learnt neighbors when port/bridge is deleted

2019-07-02 Thread Vasu Dasari
"native tunnel routing failed". If you agree that 2b and 3b are not supported use cases, then I can submit my code changes as per your review comments. Please let me know what you think of. -Vasu *Vasu Dasari* On Mon, Jun 24, 2019 at 6:15 PM Flavio Leitner wrote: > On Mon, Ju

Re: [ovs-dev] [PATCH] tnl-neigh-cache: Purge learnt neighbors when port/bridge is deleted

2019-06-24 Thread Vasu Dasari
Thanks Flavio for your inputs. My comments inline: *Vasu Dasari* On Mon, Jun 24, 2019 at 3:58 PM Flavio Leitner wrote: > On Wed, Jun 19, 2019 at 11:02:07PM -0400, Vasu Dasari wrote: > > Say an ARP entry is learnt on a OVS port and when such a port is deleted, > > lear

[ovs-dev] [PATCH v2] tnl-neigh-cache: Purge learnt neighbors when port/bridge is deleted

2019-06-20 Thread Vasu Dasari
are added and removed on deletion of a ports and bridges. Discussion for this addition is at: https://mail.openvswitch.org/pipermail/ovs-discuss/2019-June/048754.html Signed-off-by: Vasu Dasari --- v1 -> v2: Incorporate robot comments. Verified the commit with utilities/checkpatch.py

[ovs-dev] [PATCH] tnl-neigh-cache: Purge learnt neighbors when port/bridge is deleted

2019-06-19 Thread Vasu Dasari
are added and removed on deletion of a ports and bridges. Discussion for this addition is at: https://mail.openvswitch.org/pipermail/ovs-discuss/2019-June/048754.html Signed-off-by: Vasu Dasari --- lib/tnl-neigh-cache.c| 20 + lib/tnl-neigh-cache.h| 1 + ofproto