Re: [ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Use env variables for passing options.

2019-10-15 Thread aginwala
On Tue, Oct 15, 2019 at 10:38 AM Ben Pfaff wrote: > On Mon, Oct 14, 2019 at 07:45:11PM -0700, aginwala wrote: > > On Mon, Oct 14, 2019 at 4:38 PM Ben Pfaff wrote: > > > > > On Mon, Oct 14, 2019 at 03:33:25PM -0700, Ben Pfaff wrote: > > > > On Wed, Oct

Re: [ovs-dev] [PATCH v1] ovs container build.sh requires python3

2019-10-14 Thread aginwala
Hi Ben: Can you also push this to OVS master? Got it merged in ovn repo already. On Fri, Oct 11, 2019 at 2:06 PM wrote: > From: Aliasgar Ginwala > > building ovn/ovs container breaks while configure: > checking for Python 3 (version 3.4 or later)... no > configure: error: Python 3.4 or later

Re: [ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Use env variables for passing options.

2019-10-14 Thread aginwala
On Mon, Oct 14, 2019 at 4:38 PM Ben Pfaff wrote: > On Mon, Oct 14, 2019 at 03:33:25PM -0700, Ben Pfaff wrote: > > On Wed, Oct 09, 2019 at 04:56:40PM -0700, amgin...@gmail.com wrote: > > > From: Aliasgar Ginwala > > > > > > Add new env variables OVN_NBCTL_OPTIONS and OVN_SBCTL_OPTIONS for > > >

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Create etcdir when starting ovsdb servers

2019-10-12 Thread aginwala
Acked-by: Aliasgar Ginwala > On Sat, Oct 12, 2019 at 1:16 PM wrote: > From: Numan Siddique > > 'ovn-ctl promote_ovnnb/promote_ovnsb' stores the address of the > active server in /etc/ovn/ovn(nb/sb)-active.conf and this fails as > ovn-ctl doesn't create /etc/ovn dir. > > This patch fixes it. >

Re: [ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Set no-leader-only as default for clustered dbs

2019-10-09 Thread aginwala
the rest of the > OVN community come to consensus here. > > On Thu, Oct 03, 2019 at 02:17:48PM -0700, aginwala wrote: > > Thanks Han and ben for the suggestions. However, one more reason for > using > > this approach is because ovn-controller uses no-leader-only by defaul

Re: [ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Set no-leader-only as default for clustered dbs

2019-10-03 Thread aginwala
Thanks Han and ben for the suggestions. However, one more reason for using this approach is because ovn-controller uses no-leader-only by default so that all the chassis can be randomly distributed to talk to any node in the cluster to avoid overloading leader node in a large scale env

Re: [ovs-dev] [PATCH v10] ovsdb-tool: Convert clustered db to standalone db.

2019-09-19 Thread aginwala
Hi Ben: Just a gentle reminder. Can you please help merge this patch if no additional comments? Got acked-by Han on the same already. On Fri, Aug 30, 2019 at 8:30 AM wrote: > From: Aliasgar Ginwala > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > E.g. usage to

Re: [ovs-dev] [PATCH 1/2 ovn] OVN: Fix container build.

2019-09-19 Thread aginwala
://patchwork.ozlabs.org/patch/1164870/ to handle the same. PTAL. On Thu, Sep 19, 2019 at 11:15 AM Numan Siddique wrote: > > > On Thu, Sep 12, 2019 at 7:00 AM aginwala wrote: > >> Signed-off-by: Aliasgar Ginwala >> >> > Hi Ali, > > This patch is failing when I

Re: [ovs-dev] [PATCH 05/10] trigger: Free leaked ovsdb_schema

2019-09-13 Thread aginwala
. I take it back! On Fri, Sep 13, 2019 at 9:46 AM Yifeng Sun wrote: > Thanks Aginwala, > > Could you please double check if 'json_destroy(result)' is necessary here? > If result != NULL, then it is passed in trigger_success(), which puts > result in 't->reply', > later, jsonrpc

Re: [ovs-dev] [PATCH 05/10] trigger: Free leaked ovsdb_schema

2019-09-12 Thread aginwala
One minor suggestion here: Can you also handle freeing result: diff --git a/ovsdb/trigger.c b/ovsdb/trigger.c index 6f4ed96b0..0158957d6 100644 --- a/ovsdb/trigger.c +++ b/ovsdb/trigger.c @@ -214,6 +214,7 @@ ovsdb_trigger_try(struct ovsdb_trigger *t, long long int now) /*

Re: [ovs-dev] [PATCH 1/2 ovn] OVN: Fix container build.

2019-09-11 Thread aginwala
Signed-off-by: Aliasgar Ginwala On Wed, Sep 11, 2019 at 6:00 PM 0-day Robot wrote: > Bleep bloop. Greetings aginwala aginwala, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See th

Re: [ovs-dev] [PATCH 2/2 ovn] Support starting containers with unix socket

2019-09-11 Thread aginwala
Signed-off-by: Aliasgar Ginwala On Wed, Sep 11, 2019 at 6:04 PM 0-day Robot wrote: > Bleep bloop. Greetings aginwala aginwala, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See th

Re: [ovs-dev] Hypervisor down during upgrade OVS 2.10.x to 2.10.y

2019-09-06 Thread aginwala
Hi: Adding correct ovs-discuss ML. I did get a chance to take a look on it a bit. I think this is the bug in 4.4.0-104-generic kernel on ubuntu 16.04 as its being discussed on ubuntu forum https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1711407 where it can be hit all of a sudden as per the

Re: [ovs-dev] [branch-2.11 1/2] Set release date for 2.11.2.

2019-09-05 Thread aginwala
Hi Justin: Please back-port the above patches to branch-2.10 too as it fails there too. On Thu, Sep 5, 2019 at 4:24 PM Justin Pettit wrote: > > > On Sep 5, 2019, at 4:08 PM, Han Zhou wrote: > > > > Shall older branches support latest kernels? If so, some kernel patches > need to be

Re: [ovs-dev] [PATCH v9] ovsdb-tool: Convert clustered db to standalone db.

2019-08-30 Thread aginwala
Thanks Han. Addressed the minor comment in v10. On Thu, Aug 29, 2019 at 10:31 PM Han Zhou wrote: > Thanks for the update. > > On Thu, Aug 29, 2019 at 6:20 PM wrote: > > > > From: Aliasgar Ginwala > > > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > > E.g. usage

Re: [ovs-dev] [PATCH v8] ovsdb-tool: Convert clustered db to standalone db.

2019-08-29 Thread aginwala
Hi Han and Ben: Sorry, realized little late that ovsdb-tool transact wont work on clustered db. Since in current UT I didn't add AT_CHECK for transact operation for clustered db, test-suite didn't catch the same. Hence, fixed it in v9 and merged it to one UT to use ovsdb-client to insert

Re: [ovs-dev] [PATCH v6] ovsdb-tool: Convert clustered db to standalone db.

2019-08-29 Thread aginwala
On Thu, Aug 29, 2019 at 2:01 PM Han Zhou wrote: > On Thu, Aug 29, 2019 at 1:14 PM wrote: > > > > From: Aliasgar Ginwala > > > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > > E.g. usage to migrate nb/sb db to standalone db from raft: > > ovsdb-tool

Re: [ovs-dev] [PATCH v3] ovsdb-tool: Convert clustered db to standalone db.

2019-08-26 Thread aginwala
Seems some issue in my local env where --enable-Werror --enable-sparse didn't catch this warning. Addressed in v4. On Mon, Aug 26, 2019 at 3:01 PM 0-day Robot wrote: > Bleep bloop. Greetings aginwala aginwala, I am a robot and I have tried > out your patch. > Thanks for your con

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-26 Thread aginwala
Hi Han and Ben: Addressed review comments from both of you in v3 https://patchwork.ozlabs.org/patch/1153456/ . PTAL On Fri, Aug 23, 2019 at 3:37 PM Ginwala, Aliasgar wrote: > Thanks Ben: > > On 8/23/19, 2:50 PM, "Ben Pfaff" wrote: > > On Fri, Aug 23, 2019 at 09:29:00PM +, Ginwala,

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-23 Thread aginwala
Thanks Ben for review! On Fri, Aug 23, 2019 at 10:42 AM Ben Pfaff wrote: > On Thu, Aug 22, 2019 at 05:53:10PM -0700, amgin...@gmail.com wrote: > > From: Aliasgar Ginwala > > > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > > E.g. usage to migrate nb/sb db to

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-23 Thread aginwala
Thanks Han for detailed review. On Fri, Aug 23, 2019 at 8:17 AM Han Zhou wrote: > On Thu, Aug 22, 2019 at 10:29 PM aginwala aginwala > wrote: > > > Thanks for the review Han. > > > > On Thu, Aug 22, 2019 at 7:27 PM Han Zhou wrote: > > > >> Ali, th

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-22 Thread aginwala aginwala
Thanks for the review Han. On Thu, Aug 22, 2019 at 7:27 PM Han Zhou wrote: > Ali, thanks for the patch. Please see my comments below. > > On Thu, Aug 22, 2019 at 5:53 PM wrote: > > > > From: Aliasgar Ginwala > > > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > >

Re: [ovs-dev] [PATCH v1] ovsdb-tool: Convert clustered db to standalone db.

2019-08-22 Thread aginwala aginwala
Thanks Aron. I addressed this warning and sent v2. Didn't see it in subsequent make as it appeared only first time so couldn't notice. On Thu, Aug 22, 2019 at 5:00 PM 0-day Robot wrote: > Bleep bloop. Greetings Aliasgar Ginwala, I am a robot and I have tried > out your patch. > Thanks for your

Re: [ovs-dev] [PATCH v2 ovn] Containerize components

2019-08-21 Thread aginwala
Update documentation about building/running ovn in containers. > > > > Signed-off-by: aginwala > > > > This patch has conflicts. Would you mind submit v3 rebasing the patch ? > > Thanks > Numan > > > > --- > > Documentation/intro/install/general.rst |

Re: [ovs-dev] [PATCH v1 ovn] Containerize components

2019-08-17 Thread aginwala
On Fri, Aug 16, 2019 at 10:33 AM aginwala wrote: > > > On Thu, Aug 15, 2019 at 11:32 PM Numan Siddique > wrote: > >> On Thu, Aug 1, 2019 at 3:01 AM Aliasgar Ginwala >> wrote: >> >> > 1. Containerize ovn central components >> > 2. Conta

Re: [ovs-dev] [PATCH v1 ovn] Containerize components

2019-08-16 Thread aginwala
give it a try and update usage details in doc in v2. > > For ovn db services, it using tcp. Can't we add support to use unix sockets > as well ? I am fine adding this support as a follow up > patch. > > We can for sure as a follow up patch. > Thanks > Numan

Re: [ovs-dev] [PATCH 2/4] ovsdb-idl.c: Allows retry even when using a single remote.

2019-08-14 Thread aginwala
Sure. Thanks for re-validating different corner cases with me. Yup, we can update more details in leader-only section about using single LB VIP while accessing clustered db via ovn-nbctl/ovn-sbctl for sure to avoid confusion. On Wed, Aug 14, 2019 at 3:21 PM Han Zhou wrote: > Hi Aginw

Re: [ovs-dev] [PATCH 2/4] ovsdb-idl.c: Allows retry even when using a single remote.

2019-08-13 Thread aginwala
On Tue, Aug 13, 2019 at 7:07 PM aginwala wrote: > Thanks for the fixes. Found a bug in current code which breaks both nbctl > with local socket and daemon mode on follower nodes. Also nbctl daemon mode > always tries to connect to leader node by default which also failed to > co

Re: [ovs-dev] [PATCH v2] OVN: Enhance ovndb-servers.ocf to handle inactive_probe_interval updates

2019-06-29 Thread aginwala
Thanks Lucas for the patch: It's good to update inactivity_probe via crm resource as we ideally use ovn-nbtl/ovn-sbctl commands to do that since the value one chooses depends on scale and can be different for everyone and we always tune it from active node. Also what do you mean by multiple

Re: [ovs-dev] [PATCH] ovn-ctl: Set max open files limit for SB DB.

2019-05-15 Thread aginwala
Acked-by: aginwala On Wed, May 15, 2019 at 8:58 AM Han Zhou wrote: > > > On Wed, May 15, 2019 at 12:53 AM aginwala wrote: > >> >> >> On Tue, May 14, 2019 at 3:15 PM Han Zhou wrote: >> >>> From: Han Zhou >>> >>> Increase the

Re: [ovs-dev] [PATCH] ovn-ctl: Set max open files limit for SB DB.

2019-05-15 Thread aginwala
On Tue, May 14, 2019 at 3:15 PM Han Zhou wrote: > From: Han Zhou > > Increase the limit on the number of open file descriptors, because > SB DB may connect to large number of chassises. > > Signed-off-by: Han Zhou > --- > ovn/utilities/ovn-ctl | 8 > 1 file changed, 8 insertions(+) >

Re: [ovs-dev] [PATCH v3 2/2] ovndb-servers.ocf: Add ssl support for managing OVN DB resources with pacemaker using LB VIP.

2018-10-11 Thread aginwala aginwala
Thanks Ben: Please backport it to 2.10 and 2.9 On Thu, Oct 11, 2018 at 2:06 PM Ben Pfaff wrote: > On Wed, Oct 10, 2018 at 11:42:08AM +0530, Numan Siddique wrote: > > On Wed, Oct 10, 2018 at 3:42 AM aginwala wrote: > > > > > When starting OVN DBs in HA using pacemaker w

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Allow passing ssl certs when starting OVN DBs in ssl mode.

2018-10-09 Thread aginwala aginwala
Hi Han: Have added the man section for ssl in v3. PTAL. Thanks, On Mon, Oct 8, 2018 at 6:49 PM aginwala aginwala wrote: > Sure. I will add ssl usage example with some brief in the ovn-ctl.8.xml > and send v3 for this patch . Does that sound good? > > On Mon, Oct 8, 2018 at 5:32

[ovs-dev] [PATCH v3 2/2] ovndb-servers.ocf: Add ssl support for managing OVN DB resources with pacemaker using LB VIP.

2018-10-09 Thread aginwala
When starting OVN DBs in HA using pacemaker with ssl, we need to pass ssl certs for starting standby DBs. Hence, we need this change. Signed-off-by: aginwala Acked-by: Han Zhou --- ovn/utilities/ovndb-servers.ocf | 72 - 1 file changed, 71 insertions

[ovs-dev] [PATCH v3 1/2] ovn-ctl: Allow passing ssl certs when starting OVN DBs in ssl mode.

2018-10-09 Thread aginwala
-create-insecure-remote=no start_nb_ovsdb When certs are passed in the command line, it will read certs from the path mentioned instead of default db configs. Certs can be generated based on ovs ssl docs: http://docs.openvswitch.org/en/latest/howto/ssl/ Signed-off-by: aginwala --- ovn/utilities

Re: [ovs-dev] [PATCH 2/2] ovndb-servers.ocf: Add ssl support for managing OVN DB resources with pacemaker using LB VIP.

2018-10-09 Thread aginwala aginwala
Thanks Numan for review. Just to update that V3 will only have changes for ovn-ctl as per Han's suggestion to add details in help section there. ocf script will remain unchanged. That is why I have added acked-by on this patch. :) On Mon, Oct 8, 2018 at 11:59 PM Numan Siddique wrote: > > > On

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Allow passing ssl certs when starting OVN DBs in ssl mode.

2018-10-08 Thread aginwala aginwala
Sure. I will add ssl usage example with some brief in the ovn-ctl.8.xml and send v3 for this patch . Does that sound good? On Mon, Oct 8, 2018 at 5:32 PM Han Zhou wrote: > > > On Mon, Oct 8, 2018 at 4:55 PM aginwala aginwala > wrote: > > > > > > > > On M

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Allow passing ssl certs when starting OVN DBs in ssl mode.

2018-10-08 Thread aginwala aginwala
On Mon, Oct 8, 2018 at 10:47 AM Han Zhou wrote: > > > On Fri, Oct 5, 2018 at 6:48 PM aginwala aginwala > wrote: > > > > Thanks for the review Han. Please find the comments inline below: > > On Thu, Oct 4, 2018 at 9:58 AM Han Zhou wrote: > >> > &

Re: [ovs-dev] [PATCH 2/2] ovndb-servers.ocf: Add ssl support for managing OVN DB resources with pacemaker using LB VIP.

2018-10-08 Thread aginwala aginwala
On Mon, Oct 8, 2018 at 2:17 PM Han Zhou wrote: > > > On Mon, Oct 8, 2018 at 11:55 AM aginwala aginwala > wrote: > > > > Yes, that's right. I will send out v2 in a bit with Han's ack. > > > > > > Regards, > > Aliasgar > > > > On Mon

Re: [ovs-dev] [PATCH 2/2] ovndb-servers.ocf: Add ssl support for managing OVN DB resources with pacemaker using LB VIP.

2018-10-08 Thread aginwala aginwala
Yes, that's right. I will send out v2 in a bit with Han's ack. Regards, Aliasgar On Mon, Oct 8, 2018 at 11:04 AM Ben Pfaff wrote: > On Mon, Oct 08, 2018 at 10:58:49AM -0700, Han Zhou wrote: > > On Fri, Oct 5, 2018 at 6:34 PM aginwala aginwala > wrote: > > > > >

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Allow passing ssl certs when starting OVN DBs in ssl mode.

2018-10-05 Thread aginwala aginwala
t=/etc/openvswitch/cacert.pem \ > > --db-nb-create-insecure-remote=no start_nb_ovsdb > > > > Certs can be generated based on ovs ssl docs: > > http://docs.openvswitch.org/en/latest/howto/ssl/ > > > > Signed-off-by: aginwala > > --- > > ovn/utilities/

Re: [ovs-dev] [PATCH 2/2] ovndb-servers.ocf: Add ssl support for managing OVN DB resources with pacemaker using LB VIP.

2018-10-05 Thread aginwala aginwala
pass > ssl > > certs for starting standby DBs. Hence, we need this change. > > > > Signed-off-by: aginwala > > --- > > ovn/utilities/ovndb-servers.ocf | 74 > - > > 1 file changed, 73 insertions(+), 1 deletion(-) > &g

Re: [ovs-dev] [PATCH v2] debian: Move libovn out from package libopenvswitch.

2018-08-27 Thread aginwala
Tested-by: aginwala wrote: > On Fri, Aug 24, 2018 at 06:07:24PM -0700, Han Zhou wrote: > > From: Han Zhou > > > > Since we are packaging OVN and OVS components separately, libovn > > shouldn't belong to OVS, so move it to ovn-common. Also, remove > > it from l

Re: [ovs-dev] [PATCH] debian: Add ovn-detrace to ovn-common package.

2018-07-30 Thread aginwala
Thanks for adding this. Acked-by: aginwala On Sun, Jul 29, 2018 at 4:27 PM Han Zhou wrote: > Signed-off-by: Han Zhou > --- > debian/ovn-common.install | 1 + > debian/ovn-common.manpages | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/debian/ovn-common

Re: [ovs-dev] [ovs-discuss] ovsdb-server core dump and ovsdb corruption using raft cluster

2018-07-24 Thread aginwala
Hi: Glad to see more people picking up on raft testing. Just to add on, you can also refer to https://mail.openvswitch.org/pipermail/ovs-dev/2018-May/347765.html and https://mail.openvswitch.org/pipermail/ovs-dev/2018-April/346375.html where there are couple of suggestions given by Ben too. See

Re: [ovs-dev] [PATCH] Introduce ovs-appctl command to monitor HVs sb connection status

2018-07-19 Thread aginwala
Signed-off-by: aginwala On Thu, Jul 19, 2018 at 4:01 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Add 'connection-status' command to ovs-appctl utility in order to check > if a given chassis is currently connected to SB db > > Co-authored-by: aginwala > S

Re: [ovs-dev] [PATCH 2/2] ovndb-servers: Set connection table when using

2018-07-09 Thread aginwala
Cool! Thanks! On Mon, Jul 9, 2018 at 11:28 AM Ben Pfaff wrote: > OK, that did it. I backported all three. > > On Mon, Jul 09, 2018 at 11:04:12AM -0700, aginwala wrote: > > Hi Ben: > > > > I guess the cherry pick failed because of the dependency pa

Re: [ovs-dev] [PATCH 2/2] ovndb-servers: Set connection table when using

2018-07-09 Thread aginwala
:26 AM Ben Pfaff wrote: > On Thu, Jun 21, 2018 at 01:29:52AM +0530, Numan Siddique wrote: > > On Sat, Jun 9, 2018 at 7:03 AM, aginwala wrote: > > > > > load balancer to manage ovndb clusters via pacemaker. > > > > > > This is will allow s

Re: [ovs-dev] [PATCH 2/2] ovndb-servers.ocf: Set connections in NB and SB DB tables,

2018-06-19 Thread aginwala
Jun 8, 2018 at 12:32 PM, aginwala wrote: > > > > > > so that we can adjust inactivity_probe for master node, while still not > > > listening on TCP on slave node using use_remote_in_db in ovn-ctl. > > > > > > > Minor comment: the commit message

[ovs-dev] [PATCH 2/2] ovndb-servers: Set connection table when using

2018-06-19 Thread aginwala
for slave SB and NB dbs respectively by unsetting --db-sb-use-remote-in-db and --db-nb-use-remote-in-db in ovn-ctl. Signed-off-by: aginwala --- ovn/utilities/ovndb-servers.ocf | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/ovn/utilities

Re: [ovs-dev] [PATCH v1] ovn-ctl and ovndb-servers set connection table

2018-06-18 Thread aginwala
wrote: > Hi Ali, thanks for the fix. I reviewed and have some minor improvements > suggested. > > On Sun, Jun 3, 2018 at 7:50 PM, aginwala wrote: > > > > only for master node with remote option when using load balancer to > manage > > ovndb clusters via pace

[ovs-dev] [PATCH 2/2] ovndb-servers.ocf: Set connections in NB and SB DB tables,

2018-06-18 Thread aginwala
so that we can adjust inactivity_probe for master node, while still not listening on TCP on slave node using use_remote_in_db in ovn-ctl. Signed-off-by: aginwala --- ovn/utilities/ovndb-servers.ocf | 39 +++ 1 file changed, 23 insertions(+), 16 deletions

[ovs-dev] [PATCH 1/2] ovn-ctl: Support NB and SB DBs to start without

2018-06-18 Thread aginwala
clusters. Signed-off-by: aginwala --- ovn/utilities/ovn-ctl | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl index 4b7eef5..2fce477 100755 --- a/ovn/utilities/ovn-ctl +++ b/ovn/utilities/ovn-ctl @@ -115,6 +115,7

Re: [ovs-dev] Make ofproto_port_open_type() faster

2018-06-11 Thread aginwala
Thanks. :) On Mon, Jun 11, 2018 at 3:40 PM, Ben Pfaff wrote: > On Mon, Jun 11, 2018 at 11:19:08AM -0700, aginwala wrote: > > Can you also apply > > https://github.com/openvswitch/ovs/commit/c381bca52f629f3d35f00471dcd10c > ba1a9a3d99 > > to branch-2.9 too. > > Su

[ovs-dev] Make ofproto_port_open_type() faster

2018-06-11 Thread aginwala
Hi Ben: Can you also apply https://github.com/openvswitch/ovs/commit/c381bca52f629f3d35f00471dcd10cba1a9a3d99 to branch-2.9 too. Wanted to know if its not yet done on purpose to avoid implications if any or you have any other thing in mind. 樂 Regards, Aliasgar

[ovs-dev] [PATCH v1] ovn-ctl and ovndb-servers set connection table

2018-06-08 Thread aginwala
=db:OVN_Northbound,NB_Global,connections will only be set on master node when using load balancer for sb and nb dbs respectively. Signed-off-by: aginwala --- ovn/utilities/ovn-ctl | 6 +- ovn/utilities/ovndb-servers.ocf | 31 ++- 2 files changed, 23 insertions(+), 14

Re: [ovs-dev] [PATCH v5] ovndb-servers.ocf: add LB support for managing ovndb cluster:

2018-06-05 Thread aginwala
Hi Ben: Numan and Han have helped review the same. Have sent a final version (v5) addressing Numan's comment post testing of v4 by him. Regards, On Tue, Jun 5, 2018 at 10:41 AM, Ben Pfaff wrote: > On Sat, Jun 02, 2018 at 09:11:56AM -0700, aginwala wrote: > > using pac

Re: [ovs-dev] [PATCH v4] ovndb-servers.ocf: add LB support for managing ovndb cluster:

2018-06-05 Thread aginwala
On Tue, Jun 5, 2018 at 3:36 AM, Numan Siddique wrote: > On Sat, Jun 2, 2018 at 12:37 AM, aginwala wrote: > > > using pacemaker so that controllers can be placed in different fault > > domains. > > More background about the discussions can be found on: > > https://

[ovs-dev] [PATCH v5] ovndb-servers.ocf: add LB support for managing ovndb cluster:

2018-06-05 Thread aginwala
using pacemaker so that controllers can be placed in different fault domains. More background about the discussions can be found on: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-May/046770.html Signed-off-by: aginwala --- Documentation/topics/integration.rst | 34

Re: [ovs-dev] [PATCH v2] ovndb-servers.ocf: add support for managing cluster

2018-06-03 Thread aginwala
Hi: Have sent out V4 @ https://patchwork.ozlabs.org/patch/924734/ . Please take a look and let me know further. Regards, Aliasgar On Thu, May 31, 2018 at 9:12 AM, aginwala wrote: > > > On Wed, May 30, 2018 at 11:24 PM, Numan Siddique > wrote: > >> >> >> On

[ovs-dev] [PATCH v4] ovndb-servers.ocf: add LB support for managing ovndb cluster:

2018-06-03 Thread aginwala
using pacemaker so that controllers can be placed in different fault domains. More background about the discussions can be found on: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-May/046770.html Signed-off-by: aginwala --- Documentation/topics/integration.rst | 34

Re: [ovs-dev] scale test testing requests (was: raft ovsdb clustering with scale test)

2018-05-31 Thread aginwala
On Fri, May 18, 2018 at 1:35 PM, Ben Pfaff wrote: > I've spent some time stressing the database yesterday and today. So > far, I can't reproduce these particular problems. I do see various ways > to improve OVS and OVN and their tests. > > Here are some suggestions I have for further testing:

Re: [ovs-dev] [PATCH v2] ovndb-servers.ocf: add support for managing cluster

2018-05-31 Thread aginwala
On Wed, May 30, 2018 at 11:24 PM, Numan Siddique wrote: > > > On Thu, May 31, 2018 at 4:06 AM, Han Zhou wrote: > >> >> >> On Wed, May 30, 2018 at 3:27 PM, aginwala wrote: >> >>> >>> >>> On Wed, May 30, 2018 at 2:52 PM, Han Zhou wr

Re: [ovs-dev] [PATCH v2] ovndb-servers.ocf: add support for managing cluster

2018-05-30 Thread aginwala
On Wed, May 30, 2018 at 2:52 PM, Han Zhou wrote: > > > On Tue, May 29, 2018 at 11:40 PM, Numan Siddique > wrote: > > > > On Wed, May 30, 2018 at 5:31 AM, aginwala wrote: > > > > > Thanks for the Review. > > > > > > On W

Re: [ovs-dev] [PATCH v2] ovndb-servers.ocf: add support for managing cluster

2018-05-30 Thread aginwala
Sounds good! Addressed the comments in V3 @ https://patchwork.ozlabs. org/patch/923040/ . Please help review the same and let me know further. On Tue, May 29, 2018 at 11:40 PM, Numan Siddique wrote: > > > On Wed, May 30, 2018 at 5:31 AM, aginwala wrote: > >> Thanks for the Re

[ovs-dev] [PATCH v3] ovndb-servers.ocf: add LB support for managing ovsdb cluster

2018-05-30 Thread aginwala
using pacemaker so that controllers can be placed in different fault domains. Signed-off-by: aginwala --- ovn/utilities/ovndb-servers.ocf | 82 - 1 file changed, 64 insertions(+), 18 deletions(-) diff --git a/ovn/utilities/ovndb-servers.ocf b/ovn

Re: [ovs-dev] [PATCH v2] ovndb-servers.ocf: add support for managing cluster

2018-05-29 Thread aginwala
Thanks for the Review. On Wed, May 23, 2018 at 11:36 AM, Numan Siddique wrote: > On Wed, May 9, 2018 at 12:13 AM, aginwala wrote: > > > using pacemaker so that controllers can be placed in different fault > > domains. > > > > Signed-off-by: aginwala > &

[ovs-dev] [PATCH v2] ovndb-servers.ocf: add support for managing cluster

2018-05-18 Thread aginwala
using pacemaker so that controllers can be placed in different fault domains. Signed-off-by: aginwala <aginw...@ebay.com> --- ovn/utilities/ovndb-servers.ocf | 83 - 1 file changed, 65 insertions(+), 18 deletions(-) diff --git a/ovn/utilities

Re: [ovs-dev] [PATCH] ovn pacemaker: Fix the promotion issue in other cluster nodes when the master node is reset

2018-05-18 Thread aginwala
, On Fri, May 18, 2018 at 12:02 PM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Fri, May 18, 2018 at 11:53 PM, aginwala <aginw...@asu.edu> wrote: > >> >> >> On Thu, May 17, 2018 at 11:23 PM, Numan Siddique <nusid...@redhat.com> >>

Re: [ovs-dev] [PATCH] ovn pacemaker: Fix the promotion issue in other cluster nodes when the master node is reset

2018-05-18 Thread aginwala
On Thu, May 17, 2018 at 11:23 PM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Fri, May 18, 2018 at 4:24 AM, aginwala <aginw...@asu.edu> wrote: > >> Hi: >> >> I tried and it didnt help where Ip resource is always showing stopped >> where

[ovs-dev] [PATCH v1] ovndb-servers.ocf: add LB support for managing ovsdb cluster

2018-05-17 Thread aginwala
using pacemaker so that controllers can be placed in different fault domains. Signed-off-by: aginwala <aginw...@ebay.com> --- ovn/utilities/ovndb-servers.ocf | 63 + 1 file changed, 51 insertions(+), 12 deletions(-) diff --git a/ovn/utilities

Re: [ovs-dev] [PATCH] ovn pacemaker: Fix the promotion issue in other cluster nodes when the master node is reset

2018-05-17 Thread aginwala
Hi: I tried and it didnt help where Ip resource is always showing stopped where my private VIP IP is 192.168.220.108 # kernel panic on active node root@test7:~# echo c > /proc/sysrq-trigger root@test6:~# crm stat Last updated: Thu May 17 22:46:38 2018 Last change: Thu May 17 22:45:03 2018 by

Re: [ovs-dev] [PATCH] ovn-ctl: Handle whitespaces when using eval for start_ovsdb:

2018-04-28 Thread aginwala
ll instances of > eval local x=... > to > local x; eval x=... > > Thanks, > > Ben. > > On Sat, Apr 28, 2018 at 06:21:31PM -0700, aginwala wrote: > > Thanks Ben: > > > > Sounds good. As suggested, I have included other variables as it &g

[ovs-dev] [PATCH v4] ovn-ctl: Handle whitespaces when using eval for start_ovsdb:

2018-04-28 Thread aginwala
. Hence, we need to seperate local keyword for all variables used with eval to make it work with both dash and bash. Signed-off-by: aginwala <aginw...@ebay.com> --- ovn/utilities/ovn-ctl | 60 ++- 1 file changed, 40 insertions(+), 20 deletions(-)

Re: [ovs-dev] [PATCH] ovn-ctl: Handle whitespaces when using eval for start_ovsdb:

2018-04-28 Thread aginwala
some other variable might have a space in it. > > Thanks, > > Ben. > > On Sat, Apr 28, 2018 at 12:00:53PM -0700, aginwala wrote: > > Yes: > > > > I already have sent the patch with this changes in v2 @ > > https://patchwork.ozlabs.org/patch/904894/ > > > >

[ovs-dev] [PATCH] ovn-ctl: Handle whitespaces when using eval for start_ovsdb:

2018-04-28 Thread aginwala
. Hence, we need to remove local keyword for all variables used with eval to make it work with both dash and bash. Signed-off-by: aginwala <aginw...@ebay.com> --- ovn/utilities/ovn-ctl | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git

Re: [ovs-dev] [PATCH] ovn-ctl: Handle whitespaces when using eval for start_ovsdb:

2018-04-28 Thread aginwala
are you willing to make the > change in this form? > > Thanks, > > Ben. > > On Wed, Apr 25, 2018 at 05:51:01PM -0700, aginwala wrote: > > The root cause is ovn-ctl is using sh instead of bash. Parsing works fine > > if we use bash > > > > e.g below is the

[ovs-dev] [PATCH v2] ovn-ctl: Handle whitespaces when using eval for start_ovsdb:

2018-04-26 Thread aginwala
. Hence, we need to remove local keyword for log variable to make it work with both sh and bash. Signed-off-by: aginwala <aginw...@ebay.com> --- ovn/utilities/ovn-ctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl index 25dda52..4

Re: [ovs-dev] [PATCH] ovn-ctl: Handle whitespaces when using eval for start_ovsdb:

2018-04-25 Thread aginwala
It's dash root@test3:~# ls -l /bin/sh lrwxrwxrwx 1 root root 4 Feb 17 2016 /bin/sh -> dash Regards, On Wed, Apr 25, 2018 at 6:24 PM, Ben Pfaff <b...@ovn.org> wrote: > On April 25, 2018 8:51:01 PM EDT, aginwala <aginw...@asu.edu> wrote: >> >> The root cause

Re: [ovs-dev] [PATCH] ovn-ctl: Handle whitespaces when using eval for start_ovsdb:

2018-04-25 Thread aginwala
to skip bash for log and use direct var assignment or will try to figure out something that works for both sh and bash using eval. Let me know your thoughts on that! On Wed, Apr 25, 2018 at 2:06 PM, aginwala <aginw...@asu.edu> wrote: > > > On Wed, Apr 25, 2018 at 12:54 PM, Ben Pfaf

Re: [ovs-dev] [PATCH] ovn-ctl: Handle whitespaces when using eval for start_ovsdb:

2018-04-25 Thread aginwala
On Wed, Apr 25, 2018 at 12:54 PM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Apr 12, 2018 at 03:40:33PM -0700, aginwala wrote: > > eval doesn't understand white spaces which was introduced in commit > > 79c7961b8b3c4b7ea0251dea2ffacfa84c84fecb for starting clustered ovn dbs &

Re: [ovs-dev] [PATCH] tests: Fix ovn test failures in sandbox test env.

2018-04-23 Thread aginwala
On Sun, Apr 22, 2018 at 9:53 AM, Han Zhou wrote: > When clustering support is introduced, the naming convention of > environment variables OVN_NB_DB and OVN_SB_DB changed (something > like unix:nb1.ovsdb). This leads to all ovn-nbctl test cases and > many others fail when they

Re: [ovs-dev] raft ovsdb clustering with scale test

2018-04-23 Thread aginwala
Type mismatch for member 'prev_servers'. Let me know if that clicks you little further as to what could be causing this. Have not gone into raft code into details but now seems worth visiting with hints above. Regards, On Tue, Apr 17, 2018 at 6:07 PM, aginwala <aginw...@asu.edu> wrote: > Thanks

[ovs-dev] [PATCH] ovn-ctl: Handle whitespaces when using eval for start_ovsdb:

2018-04-20 Thread aginwala
:192.168.220.101:6642,tcp:192.168.220.102:6642,tcp:192.168.220.103:6642 \ start_northd gives error: /usr/share/openvswitch/scripts/ovn-ctl: 1: local: -vfile:info: bad variable name As a result ovsdb failes to even initialize and start. This commit fixes the same. Signed-off-by: aginwala <ag

[ovs-dev] [PATCH] tutorial: skip passing .db for backup option for ovn_start_ovsdb_server:

2018-04-18 Thread aginwala
hostname: sandbox Encap geneve ip: "127.0.0.1" options: {csum="true"} Signed-off-by: aginwala <aginw...@ebay.com> --- tutorial/ovs-sandbox | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorial/ovs-sandbox b/tutorial/ovs-s

Re: [ovs-dev] raft ovsdb clustering with scale test

2018-04-17 Thread aginwala
com> wrote: > > > On Tue, Apr 17, 2018 at 5:52 AM, aginwala <aginw...@asu.edu> wrote: > >> Hi Ben/Numan: >> >> >> Just following up again. Let me know for any further >> improvements/suggestions on this. >> >> > Hi Aliasgar, > > I

Re: [ovs-dev] raft ovsdb clustering with scale test

2018-04-16 Thread aginwala
Hi Ben/Numan: Just following up again. Let me know for any further improvements/suggestions on this. Regards, On Mon, Apr 9, 2018 at 10:53 AM, aginwala <aginw...@asu.edu> wrote: > Further Analysis indicates that cluster is not able to select a new leader > and hence ever

Re: [ovs-dev] raft ovsdb clustering with scale test

2018-04-09 Thread aginwala
PM, aginwala <aginw...@asu.edu> wrote: > Hi Ben/Numan: > > So I went ahead to try out clustered db in scale env and results are not > as expected. > OVS branch used is master; commit-id(2062840612904ff0873d46b2f4f226 > bc23f2296d) > > Setup is uing 3 nodes. >

[ovs-dev] raft ovsdb clustering with scale test

2018-04-06 Thread aginwala
Hi Ben/Numan: So I went ahead to try out clustered db in scale env and results are not as expected. OVS branch used is master; commit-id(2062840612904ff0873d46b2f4f226bc23f2296d) Setup is uing 3 nodes. Also disabled inactivity_probe, ovn-nbctl

Re: [ovs-dev] [PATCH 2/2] ovs-sandbox: Support starting multiple ovn-northds.

2018-04-04 Thread aginwala
Sure. sent: https://patchwork.ozlabs.org/patch/895237/ On Wed, Apr 4, 2018 at 6:00 PM, Ben Pfaff <b...@ovn.org> wrote: > Thanks! I applied this patch to master. > > I'll look forward to the bug fix patch. > > On Wed, Apr 04, 2018 at 05:45:50PM -0700, aginwala wrote: >

[ovs-dev] [PATCH] wait=hv is not valid for ovn-sbctl:

2018-04-04 Thread aginwala
Hence removing it from ovn-setup.sh Signed-off-by: aginwala <aginw...@ebay.com> --- tutorial/ovn-setup.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/tutorial/ovn-setup.sh b/tutorial/ovn-setup.sh index 9a725cf..969b233 100755 --- a/tutorial/ovn-setup.sh +++ b/tutorial/ovn-se

Re: [ovs-dev] [PATCH 2/2] ovs-sandbox: Support starting multiple ovn-northds.

2018-04-04 Thread aginwala
Ah n_northds=1 it got messed up while importing the patch ! :) Works Fine! Sure will send separate patch to remove that from ovn-setup.sh On Wed, Apr 4, 2018 at 5:41 PM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Apr 04, 2018 at 05:32:42PM -0700, aginwala wrote: > > On Wed, A

Re: [ovs-dev] [PATCH 2/2] ovs-sandbox: Support starting multiple ovn-northds.

2018-04-04 Thread aginwala
Thanks for the fix. On Wed, Apr 4, 2018 at 3:56 PM, Ben Pfaff wrote: > This allows testing ovn-northd behavior when it is run in an HA > configuration. > > Signed-off-by: Ben Pfaff > --- > tutorial/ovs-sandbox | 17 ++--- > 1 file changed, 14

Re: [ovs-dev] [PATCH 1/2] ovs-sandbox: Connect ovn-northd to all the SB and NB database instances.

2018-04-04 Thread aginwala
Thanks for the enhancement. Reviewed-by: aginwala <aginw...@asu.edu> On Wed, Apr 4, 2018 at 3:56 PM, Ben Pfaff <b...@ovn.org> wrote: > For a clustered database instance, we want ovn-northd to connect to the > entire cluster, not just the first server. > > Signed-off-by:

Re: [ovs-dev] [PATCH v3] ovn-ctl: Support starting clustered OVN dbs

2018-04-04 Thread aginwala
Thanks Ben and Numan for upgrade feature and further optimizations. Sorry couldn't test revised patch by you guys as I am doing some simulations in my scale test to see how the cluster is behaving with more HVs. Adding 1k HVs worked well even-though I intentionally kept killing old and new

Re: [ovs-dev] [PATCH] ovn-ctl: Support starting clustered OVN dbs

2018-04-01 Thread aginwala
On Wed, Mar 28, 2018 at 4:37 AM, wrote: > From: Numan Siddique > > This patch adds the options to start clustered OVN db servers. > To support this following options are added - '--db-nb-cluster-local-addr', > '--db-nb-cluster-remote-addr',

[ovs-dev] [PATCH] Use new default nb and sb dbs for sandbox northd:

2018-03-27 Thread aginwala
v/2018-March/345535.html Signed-off-by: aginwala <aginw...@ebay.com> --- tutorial/ovn-setup.sh | 4 tutorial/ovs-sandbox | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tutorial/ovn-setup.sh b/tutorial/ovn-setup.sh index 943ca58..9a725cf 100755 --- a/tutorial/

Re: [ovs-dev] [PATCH] Use new default nb and sb dbs for sandbox northd:

2018-03-27 Thread aginwala
Please ignore this. I will resend a new patch as the patch file got messed up. On Fri, Mar 23, 2018 at 1:04 PM, <amgin...@gmail.com> wrote: > From: aginwala <aginw...@ebay.com> > > As per new clustering change, ovn-northd sandbox should use nb1.ovsdb and > sb1.ovsdb. It w

Re: [ovs-dev] Clustered DB commits causes sandbox errors

2018-03-27 Thread aginwala
rial/sandbox# ovn-nbctl --wait=hv ls-del ls1 #/ovs/tutorial/sandbox Will submit the formal patch and add --wait=hv in ovn-setup.sh so that its easier to trace this condition too to ensure northd is always working fine. Let me know if someone else has any comments. Regards, On Tue, Mar 27, 2018

Re: [ovs-dev] Clustered DB commits causes sandbox errors

2018-03-27 Thread aginwala
Hi Mark: I did reset to HEAD~6 and the sandbox still crashes . So took commit: cb8cbbbe97b56401c399fa261b9670eb1698bf14 that Han recently used to rebase his patches and it works fine. So the diff is somewhere from this commit to the master. Also, I noticed one thing that if we are using ssl by

  1   2   >