Thanks for the merge and backports Simon.
On Tue, 2024-05-07 at 17:26 +0100, Simon Horman wrote:
> On Tue, May 07, 2024 at 03:16:25PM +0100, Simon Horman wrote:
> > On Fri, May 03, 2024 at 02:22:27PM +0200,
> > martin.kal...@canonical.com wrote:
>
> ...
>
> > Thanks,
> >
> > Sorry for the
/
On Fri, 2024-05-03 at 13:16 +0100, Simon Horman wrote:
> On Wed, May 01, 2024 at 01:50:36PM +0100, Simon Horman wrote:
> > On Wed, May 01, 2024 at 01:10:43PM +0200, Martin Kalcok wrote:
> > > Help text for 'ovsdb-client dump' does not mention that it's
> > > capable
> &
Help text for 'ovsdb-client dump' does not mention that it's capable
of dumping specific table's contents if user supplies table's name
as a third positional argument.
Signed-off-by: Martin Kalcok
---
ovsdb/ovsdb-client.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Martin Kalcok
---
ovn-sb.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ovn-sb.xml b/ovn-sb.xml
index f9fb6c304..bf4689f12 100644
--- a/ovn-sb.xml
+++ b/ovn-sb.xml
@@ -1456,7 +1456,7 @@
ct_dnat sends the packet through the DNAT
Thanks Dumitru,
I didn't noticed that the patch was applied while I was typing my
message :D
Overall I think it's fine if it stays as it was proposed by Ales. I
just wanted to raise a very fringe concern that perhaps using two
separate UDP servers could mask some underlying issue and if there's
Hi Ales,
Sorry that these new tests are causing problems. Just out of curiosity,
do you have link to some failing test runs? I'll add few thoughts
below.
On Tue, 2024-04-23 at 09:41 +0200, Ales Musil wrote:
> The netcat 7.94 allows multiple connections over udp (-k/--keep-open)
> [0],
> without
Thanks for the review Ales and sorry about those unrelated changes. I just
noticed those two typos and thought I'll sneak in the fix.
On Mon, Apr 22, 2024 at 10:49 AM Ales Musil wrote:
>
>
> On Fri, Apr 19, 2024 at 2:33 PM Martin Kalcok
> wrote:
>
>> This cha
wrt the failed ovn-kubernetes tests, they seemed to have passed
successfully in my branch [0]. Is it possible that the tests are unstable?
[0] https://github.com/mkalcok/ovn/actions/runs/8752915096
On Fri, Apr 19, 2024 at 2:33 PM Martin Kalcok
wrote:
> This change fixes bug that breaks abil
tps://datatracker.ietf.org/doc/html/rfc4787
[2]https://datatracker.ietf.org/doc/html/rfc5382
[3]https://datatracker.ietf.org/doc/html/rfc7857
Signed-off-by: Martin Kalcok
---
northd/northd.c | 66 ---
northd/ovn-northd.8.xml | 28 +++
-by: Martin Kalcok
---
controller/chassis.c | 8 ++
include/ovn/actions.h | 8 +-
include/ovn/features.h| 1 +
lib/actions.c | 155 +-
northd/en-global-config.c | 10 +++
northd/en-global-config.h | 1 +
ovn-sb.xml| 22
Thanks for another round of review.
On Wed, Apr 17, 2024 at 1:45 PM Ales Musil wrote:
>
>
> On Wed, Apr 17, 2024 at 1:05 PM Dumitru Ceara wrote:
>
>> On 4/17/24 09:04, Ales Musil wrote:
>> > On Mon, Apr 15, 2024 at 2:15 PM Martin Kalcok <
>> mar
-by: Martin Kalcok
---
controller/chassis.c | 8 ++
include/ovn/actions.h | 1 +
include/ovn/features.h| 1 +
lib/actions.c | 60 +++
northd/en-global-config.c | 11 +++
northd/en-global-config.h | 1 +
ovn-sb.xml
tps://datatracker.ietf.org/doc/html/rfc4787
[2]https://datatracker.ietf.org/doc/html/rfc5382
[3]https://datatracker.ietf.org/doc/html/rfc7857
Signed-off-by: Martin Kalcok
---
northd/northd.c | 66 ---
northd/ovn-northd.8.xml | 29
Thanks for the feedback Ales, Dumitru. I'm back from vacation so I'm again
focusing on this change.
On Tue, Apr 2, 2024 at 5:33 PM Dumitru Ceara wrote:
> On 3/20/24 12:20, Ales Musil wrote:
> > On Tue, Mar 12, 2024 at 9:18 PM Martin Kalcok <
> martin.kal...@canonical.com>
>
_NX_REG13[[0..15]],exec(set_field:0x1020304050607080910111213141516->ct_label))
>> -has prereqs ip
>> +Syntax error at `(' expecting `;'.
>> ct_commit(ct_label=0x181716151413121110090807060504030201);
>> -formats as ct_commit(ct_label=0x16151413121110090807060504030201);
>> -encodes as
>> ct(commit,zone=NXM_NX_REG13[[0..15]],exec(set_field:0x16151413121110090807060504030201->ct_label))
>> -has prereqs ip
>> +Syntax error at `(' expecting `;'.
>>
>>
>> ct_commit(ct_label=0x100/0x100);
>> -encodes as
>> ct(commit,zone=NXM_NX_REG13[[0..15]],exec(set_field:0x100/0x100->ct_label))
>> -has prereqs ip
>> +Syntax error at `(' expecting `;'.
>> ct_commit(ct_label=18446744073709551615);
>> -formats as ct_commit(ct_label=0x);
>> -encodes as
>> ct(commit,zone=NXM_NX_REG13[[0..15]],exec(set_field:0x->ct_label))
>> -has prereqs ip
>> +Syntax error at `(' expecting `;'.
>> ct_commit(ct_label=18446744073709551616);
>> -Decimal constants must be less than 2**64.
>> +Syntax error at `(' expecting `;'.
>>
>> ct_mark = 12345
>> Field ct_mark is not modifiable.
>> diff --git a/utilities/ovn-trace.c b/utilities/ovn-trace.c
>> index e0f1c3ec9a..5e55fbbcc0 100644
>> --- a/utilities/ovn-trace.c
>> +++ b/utilities/ovn-trace.c
>> @@ -3107,7 +3107,6 @@ trace_actions(const struct ovnact *ovnacts, size_t
>> ovnacts_len,
>> execute_ct_next(ovnact_get_CT_NEXT(a), dp, uflow, pipeline,
>> super);
>> break;
>>
>> -case OVNACT_CT_COMMIT_V1:
>> case OVNACT_CT_COMMIT_V2:
>> /* Nothing to do. */
>> break;
>> --
>> 2.44.0
>>
>>
> Makes sense, thanks!
>
> Acked-by: Ales Musil
>
> --
>
> Ales Musil
>
> Senior Software Engineer - OVN Core
>
> Red Hat EMEA <https://www.redhat.com>
>
> amu...@redhat.com
> <https://red.ht/sig>
>
--
Best Regards,
Martin Kalcok.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi Ales, thanks for another round of review.
On Wed, Mar 20, 2024 at 12:34 PM Ales Musil wrote:
>
>
> On Thu, Mar 14, 2024 at 2:13 PM Martin Kalcok
> wrote:
>
>> Hello all,
>> I have one more follow-up regarding the comments in v1. @amusil, you were
>> conce
r
These tests show that while there was some fluctuation between each
individual test, when comparing patched and clean version, they come out
about the same. I'm happy to run more tests/scenarios if you have something
else in mind that should be tested.
On Wed, Mar 13, 2024 at 10:17 AM Mart
[0]
https://github.com/ovn-org/ovn/blob/63b35e2f6789f7843363c8f7a92430402bf989f9/utilities/ovn-sbctl.c#L127
Signed-off-by: Martin Kalcok
---
Documentation/intro/install/general.rst | 2 +-
utilities/ovn-sbctl.8.xml | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/Do
On Tue, Mar 12, 2024 at 9:17 PM Martin Kalcok
wrote:
> Following up on the comments from v1.
>
> @amusil You were right that the struct in actions.h was not necessary
> then. However I also noticed that I forgot to modify `format_CT_COMMIT_V1`
> function and for that I t
Regarding the failed unstable test in the CI, I suspect that this is not
related to the code change, I've had couple successful CI runs in my branch
[0].
Martin.
[0] https://github.com/mkalcok/ovn/actions/runs/8256539983
On Tue, Mar 12, 2024 at 8:45 PM Martin Kalcok
wrote:
> This change fi
/commit/43f741c2f029a68a11436e5b14c5bbda6e207dd3#diff-ca917e7415d06776f8ee2baf6102a866c5c31f998e4df93ff8eaa246b65e1da2
On Tue, Mar 12, 2024 at 8:45 PM Martin Kalcok
wrote:
> Action `ct_commit` currently does not allow specifying zone into
> which connection is committed. For example, in L
.org/doc/html/rfc4787
[2]https://datatracker.ietf.org/doc/html/rfc5382
[3]https://datatracker.ietf.org/doc/html/rfc7857
Signed-off-by: Martin Kalcok
---
northd/northd.c | 68
northd/ovn-northd.8.xml | 29 +
tests/ovn-northd.at | 33
the connection will be committed.
It also comes with new feature flag OVN_FEATURE_CT_COMMIT_TO_ZONE to avoid
incompatibility between northd and controller in case when controller does
not suport these actions.
Original behavior of `ct_commit` without the arguments remains unchanged.
Signed-off-by: Martin
On Thu, Mar 7, 2024 at 1:26 AM Numan Siddique wrote:
>
>
> On Wed, Mar 6, 2024 at 7:26 AM Martin Kalcok
> wrote:
>
>> Hi Ales,
>> Thank you for review and helpful comments. I'll update commit subjects
>> for this series in v2.
>>
>> On
Thanks for reviewing this as well, Ales.
On Wed, Mar 6, 2024 at 8:08 AM Ales Musil wrote:
>
>
> On Wed, Mar 6, 2024 at 8:07 AM Ales Musil wrote:
>
>>
>>
>> On Mon, Mar 4, 2024 at 11:56 AM Martin Kalcok <
>> martin.kal...@canonical.com> wrote:
>&g
Hi Ales,
Thank you for review and helpful comments. I'll update commit subjects for
this series in v2.
On Wed, Mar 6, 2024 at 7:45 AM Ales Musil wrote:
>
>
> On Mon, Mar 4, 2024 at 11:56 AM Martin Kalcok
> wrote:
>
>> Action `ct_commit` currently does not allow specifyi
/OVN would break it.
[0]https://mail.openvswitch.org/pipermail/ovs-dev/2024-February/411670.html
[1]https://datatracker.ietf.org/doc/html/rfc4787
[2]https://datatracker.ietf.org/doc/html/rfc5382
[3]https://datatracker.ietf.org/doc/html/rfc7857
Signed-off-by: Martin Kalcok
---
the connection will be committed.
Original behavior of `ct_commit` without the arguments remains unchanged.
Signed-off-by: Martin Kalcok
---
include/ovn/actions.h | 9 +
lib/actions.c | 20 +++-
ovn-sb.xml| 9 +
3 files changed, 37 insertions(+), 1
h for your first OVN contribution. I have comments
>>> below.
>>>
>>> On 2/7/24 10:56, Martin Kalcok wrote:
>>>> When a machine from an external network tries to access machine
>>>> in the
>>>> OVN's internal network with SNAT e
On Thu, 2024-02-08 at 09:30 +0100, Ales Musil wrote:
>
>
> On Thu, Feb 8, 2024 at 1:22 AM Mark Michelson
> wrote:
> > Hi Martin
> >
> > Thanks a bunch for your first OVN contribution. I have comments
> > below.
> >
> > On 2/7/24 10:56
gical Router. This
will enable SNAT rules to translate only traffic that originates from
internal networks.
Signed-off-by: Martin Kalcok
---
northd/northd.c | 70 ++---
1 file changed, 61 insertions(+), 9 deletions(-)
As this would be my first "
default
behavior.
To start database without performing schema conversion, user can
provide either `--db-cluster-schema-upgrade=no` option or
`--no-db-cluster-schema-upgrade` flag to the ovn-ctl script.
Signed-off-by: Martin Kalcok
---
utilities/ovn-ctl | 7 ++-
utilities/ovn-ctl.8.xml | 21
default
behavior.
To start database without performing schema conversion, user can
provide either `--db-cluster-schema-upgrade=no` option or
`--no-db-cluster-schema-upgrade` flag to the ovn-ctl script.
Signed-off-by: Martin Kalcok
---
utilities/ovn-ctl | 7 ++-
utilities/ovn-ctl.8.xml | 21
argument for this change is that the existing approach
> executes asynchronously, so there is no way for the human or machine
> operator to get the result of the `ovsdb-client` call.
>
> On Mon, Jan 8, 2024 at 10:15 AM Martin Kalcok
> wrote:
> >
> > ovn-ctl script currently automatic
is `no`, to preserve current default
behavior.
Signed-off-by: Martin Kalcok
---
utilities/ovn-ctl | 7 ++-
utilities/ovn-ctl.8.xml | 11 +++
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
index 876565c80..011ef9c0c 100755
Raft election timers for NB and SB DB clusters are configurable via
ovn-ctl but the options are not mention on the man page.
Signed-off-by: Martin Kalcok
---
utilities/ovn-ctl.8.xml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/utilities/ovn-ctl.8.xml b/utilities/ovn-ctl.8.xml
index
36 matches
Mail list logo
