Re: [ovs-dev] [PATCH] docs: Fix 7 byte octets MAC addresses in dpdk.rst

[Stokes, Ian]

> On Mon, Apr 09, 2018 at 05:18:55PM +0200, Timothy Redaelli wrote:
> > Currently the code relies on the standard 6 byte octets, but the
> > documentation uses a wrong 7-byte octects.
> > This commit fix the documention in order to use the correct 6 byte
> > octets syntax.
> >
> > Fixes: 5e7588186839 ("netdev-dpdk: fix port addition for ports sharing
> > same PCI id")
> >
> > Signed-off-by: Timothy Redaelli 
> 
> I find the use of "byte octets" odd here, since a byte and an octet are
> the same thing.  I would tend to say more like "docs: Fix 7-octet MAC
> addresses".
> 
I agree with above.

> I assume Ian will put this in his next DPDK pull request.

Yes, I intended to have this as part of this week's pull request.

Thanks
Ian
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] docs: Fix 7 byte octets MAC addresses in dpdk.rst

[Ben Pfaff]

On Mon, Apr 09, 2018 at 05:18:55PM +0200, Timothy Redaelli wrote:
> Currently the code relies on the standard 6 byte octets, but the
> documentation uses a wrong 7-byte octects.
> This commit fix the documention in order to use the correct 6 byte octets
> syntax.
> 
> Fixes: 5e7588186839 ("netdev-dpdk: fix port addition for ports sharing same 
> PCI id")
> 
> Signed-off-by: Timothy Redaelli 

I find the use of "byte octets" odd here, since a byte and an octet are
the same thing.  I would tend to say more like "docs: Fix 7-octet MAC
addresses".

I assume Ian will put this in his next DPDK pull request.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] docs: Fix 7 byte octets MAC addresses in dpdk.rst

[Timothy Redaelli]

Currently the code relies on the standard 6 byte octets, but the
documentation uses a wrong 7-byte octects.
This commit fix the documention in order to use the correct 6 byte octets
syntax.

Fixes: 5e7588186839 ("netdev-dpdk: fix port addition for ports sharing same PCI 
id")

Signed-off-by: Timothy Redaelli 
---
 Documentation/howto/dpdk.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/howto/dpdk.rst b/Documentation/howto/dpdk.rst
index 79b626c76..69e692f40 100644
--- a/Documentation/howto/dpdk.rst
+++ b/Documentation/howto/dpdk.rst
@@ -53,9 +53,9 @@ with multiple ports. Using a PCI device like above won't 
work. Instead, below
 usage is suggested::
 
 $ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \
-options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:01"
+options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55"
 $ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \
-options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:02"
+options:dpdk-devargs="class=eth,mac=00:11:22:33:44:56"
 
 Note: such syntax won't support hotplug. The hotplug is supposed to work with
 future DPDK release, v18.05.
-- 
2.14.3

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev