On Thu, Sep 26, 2019 at 02:18:15PM +0200, Eelco Chaudron wrote:
>
>
> On 13 Sep 2019, at 19:15, William Tu wrote:
>
> >The patch detects the numa node id from the name of the netdev,
> >by reading the '/sys/class/net//device/numa_node'.
> >If not available, ex: virtual device, or any error
On 13 Sep 2019, at 19:15, William Tu wrote:
The patch detects the numa node id from the name of the netdev,
by reading the '/sys/class/net//device/numa_node'.
If not available, ex: virtual device, or any error happens,
return numa id 0.
See comments below, but I think the main problem that
On Fri, Sep 13, 2019 at 11:40 AM Aaron Conole wrote:
>
> William Tu writes:
>
> > Hi Aaron,
> >
> > I think this might be a false positive?
>
> Looks like it.
Hi Aaron,
I looked at the checkpatch.py.
Adding a space in front of /sys makes it PASSED, but I couldn't figure it out
a solution to
William Tu writes:
> Hi Aaron,
>
> I think this might be a false positive?
Looks like it.
> I didn't find any lack whitespace here
>
> On Fri, Sep 13, 2019 at 11:01 AM 0-day Robot wrote:
>>
>> Bleep bloop. Greetings William Tu, I am a robot and I have tried out your
>> patch.
>> Thanks
Hi Aaron,
I think this might be a false positive?
I didn't find any lack whitespace here
On Fri, Sep 13, 2019 at 11:01 AM 0-day Robot wrote:
>
> Bleep bloop. Greetings William Tu, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error
Bleep bloop. Greetings William Tu, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#35 FILE: lib/netdev-afxdp.c:561:
The patch detects the numa node id from the name of the netdev,
by reading the '/sys/class/net//device/numa_node'.
If not available, ex: virtual device, or any error happens,
return numa id 0.
Signed-off-by: William Tu
---
lib/netdev-afxdp.c | 38 +-
1 file
