Re: [ovs-dev] [PATCH 1/3] tests/sendpkt.py: Fix to work with Python3

2018-06-14 Thread Ben Pfaff
Thanks Timothy (and Ashish).  I applied this to master.

On Mon, Jun 04, 2018 at 03:21:46PM -0700, Ashish Varma wrote:
> Acked-by: Ashish Varma >
> 
> On Thu, May 31, 2018 at 7:52 AM, Timothy Redaelli 
> wrote:
> 
> > CC: Ashish Varma 
> > Fixes: 296251ca0c82 ("tests: Added NSH related unit test cases for
> > datapath")
> > Signed-off-by: Timothy Redaelli 
> > ---
> >  tests/sendpkt.py | 5 -
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/sendpkt.py b/tests/sendpkt.py
> > index 50a4795eb..328ae2bc9 100755
> > --- a/tests/sendpkt.py
> > +++ b/tests/sendpkt.py
> > @@ -66,7 +66,10 @@ for a in args[1:]:
> >
> >  hex_list.append(temp)
> >
> > -pkt = "".join(map(chr, hex_list))
> > +if sys.version_info < (3, 0):
> > +pkt = "".join(map(chr, hex_list))
> > +else:
> > +pkt = bytes(hex_list)
> >
> >  try:
> >  sockfd = socket.socket(socket.AF_PACKET, socket.SOCK_RAW)
> > --
> > 2.17.0
> >
> >
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


Re: [ovs-dev] [PATCH 1/3] tests/sendpkt.py: Fix to work with Python3

2018-06-04 Thread Ashish Varma
Acked-by: Ashish Varma >

On Thu, May 31, 2018 at 7:52 AM, Timothy Redaelli 
wrote:

> CC: Ashish Varma 
> Fixes: 296251ca0c82 ("tests: Added NSH related unit test cases for
> datapath")
> Signed-off-by: Timothy Redaelli 
> ---
>  tests/sendpkt.py | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/sendpkt.py b/tests/sendpkt.py
> index 50a4795eb..328ae2bc9 100755
> --- a/tests/sendpkt.py
> +++ b/tests/sendpkt.py
> @@ -66,7 +66,10 @@ for a in args[1:]:
>
>  hex_list.append(temp)
>
> -pkt = "".join(map(chr, hex_list))
> +if sys.version_info < (3, 0):
> +pkt = "".join(map(chr, hex_list))
> +else:
> +pkt = bytes(hex_list)
>
>  try:
>  sockfd = socket.socket(socket.AF_PACKET, socket.SOCK_RAW)
> --
> 2.17.0
>
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


[ovs-dev] [PATCH 1/3] tests/sendpkt.py: Fix to work with Python3

2018-05-31 Thread Timothy Redaelli
CC: Ashish Varma 
Fixes: 296251ca0c82 ("tests: Added NSH related unit test cases for datapath")
Signed-off-by: Timothy Redaelli 
---
 tests/sendpkt.py | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/sendpkt.py b/tests/sendpkt.py
index 50a4795eb..328ae2bc9 100755
--- a/tests/sendpkt.py
+++ b/tests/sendpkt.py
@@ -66,7 +66,10 @@ for a in args[1:]:
 
 hex_list.append(temp)
 
-pkt = "".join(map(chr, hex_list))
+if sys.version_info < (3, 0):
+pkt = "".join(map(chr, hex_list))
+else:
+pkt = bytes(hex_list)
 
 try:
 sockfd = socket.socket(socket.AF_PACKET, socket.SOCK_RAW)
-- 
2.17.0

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev