Re: [ovs-dev] [PATCH v1] ovs-testcontroller: Added section for runtime managment commands
Thanks for the review. I will send a v2 patch with your suggestions. On Tue, Aug 7, 2018 at 4:06 PM, Ben Pfaff wrote: > On Mon, Aug 06, 2018 at 05:21:37PM -0700, Ashish Varma wrote: > > Even though there are no runtime management commands supported by > > ovs-testcontroller, the '--unixctl' section of the man page refers to > > 'RUNTIME MANAGEMENT COMMANDS'. This message which refers to the runtime > > management commands section is common for all '--unixctl' option. > > (via 'lib/unixctl.man') > > > > Added an empty section in the man page for 'RUNTIME MANAGEMENT COMMANDS' > to > > avoid confusion to the reader of the man page. > > > > Signed-off-by: Ashish Varma > > Thanks for improving the OVS documentation! > > However, unixctl is useless if there are no commands. It's probably > better to remove the support for it. > > Thanks, > > Ben. > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v1] ovs-testcontroller: Added section for runtime managment commands
On Mon, Aug 06, 2018 at 05:21:37PM -0700, Ashish Varma wrote: > Even though there are no runtime management commands supported by > ovs-testcontroller, the '--unixctl' section of the man page refers to > 'RUNTIME MANAGEMENT COMMANDS'. This message which refers to the runtime > management commands section is common for all '--unixctl' option. > (via 'lib/unixctl.man') > > Added an empty section in the man page for 'RUNTIME MANAGEMENT COMMANDS' to > avoid confusion to the reader of the man page. > > Signed-off-by: Ashish Varma Thanks for improving the OVS documentation! However, unixctl is useless if there are no commands. It's probably better to remove the support for it. Thanks, Ben. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH v1] ovs-testcontroller: Added section for runtime managment commands
Even though there are no runtime management commands supported by ovs-testcontroller, the '--unixctl' section of the man page refers to 'RUNTIME MANAGEMENT COMMANDS'. This message which refers to the runtime management commands section is common for all '--unixctl' option. (via 'lib/unixctl.man') Added an empty section in the man page for 'RUNTIME MANAGEMENT COMMANDS' to avoid confusion to the reader of the man page. Signed-off-by: Ashish Varma --- utilities/ovs-testcontroller.8.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/utilities/ovs-testcontroller.8.in b/utilities/ovs-testcontroller.8.in index df3c35f..5ea325f 100644 --- a/utilities/ovs-testcontroller.8.in +++ b/utilities/ovs-testcontroller.8.in @@ -146,6 +146,9 @@ Use this option more than once to add flows from multiple files. .so lib/common.man .so lib/ofp-version.man . +.SH "RUNTIME MANAGEMENT COMMANDS" +There are no runtime management commands defined for \fBovs\-testcontroller\fR. +. .SH EXAMPLES .PP To bind locally to port 6653 (the default) and wait for incoming -- 2.7.4 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
