Re: [ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

2018-08-07 Thread Han Zhou
On Tue, Aug 7, 2018 at 2:03 AM, Justin Pettit wrote: > > > > On Aug 6, 2018, at 1:27 PM, Han Zhou wrote: > > > > Thanks Justin for the great work!! > > Sorry that I didn't get time to review the series, just some quick questions regarding the kernel bug you mentioned. > > Yes, I think you were

Re: [ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

2018-08-07 Thread Justin Pettit
> On Aug 6, 2018, at 1:27 PM, Han Zhou wrote: > > Thanks Justin for the great work!! > Sorry that I didn't get time to review the series, just some quick questions > regarding the kernel bug you mentioned. Yes, I think you were on vacation, and I was running up against my own, so it all

Re: [ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

2018-08-06 Thread Han Zhou
On Mon, Jul 30, 2018 at 8:12 PM, Justin Pettit wrote: > > > > On Jul 30, 2018, at 5:58 PM, Justin Pettit wrote: > > > > Thanks for the review! I've pushed this series to master. > > I also just pushed this to branch-2.10. > > The rate-limiting is implemented using meters. Unfortunately,

Re: [ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

2018-07-31 Thread Justin Pettit
> On Jul 30, 2018, at 5:58 PM, Justin Pettit wrote: > > Thanks for the review! I've pushed this series to master. I also just pushed this to branch-2.10. The rate-limiting is implemented using meters. Unfortunately, there's a bug in the current kernels that prevents meters from working

Re: [ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

2018-07-30 Thread Justin Pettit
> On Jul 30, 2018, at 12:55 PM, Ben Pfaff wrote: > > On Sun, Jul 29, 2018 at 11:46:38PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Besides the comments I gave on patch 6 (oops), I suggest the following > for more consistent formatting: > > diff --git a/ovn/lib/actions.c

Re: [ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

2018-07-30 Thread Ben Pfaff
On Sun, Jul 29, 2018 at 11:46:38PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Besides the comments I gave on patch 6 (oops), I suggest the following for more consistent formatting: diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c index 6d4ed1e2c4ed..4f3cd48ce713 100644 ---

[ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

2018-07-30 Thread Justin Pettit
Signed-off-by: Justin Pettit --- include/ovn/actions.h | 1 + ovn/lib/actions.c | 56 +-- ovn/northd/ovn-northd.c | 4 ++ ovn/ovn-nb.ovsschema | 5 ++- ovn/ovn-nb.xml| 9 + ovn/utilities/ovn-nbctl.8.xml | 6 ++-