Re: [ovs-dev] [PATCH] OVN resource agent - make promotion synchronous

2019-07-17 Thread Ben Pfaff
On Tue, Jul 09, 2019 at 09:02:57AM +0200, Michele Baldessari wrote: > Currently inside the ovsdb_server_promote() function we call 'promote_ovnnb' > and 'promote_ovnsb' and then just record the new master state in the > CIB. > > This creates a race because those two promote commands are

Re: [ovs-dev] [PATCH] OVN resource agent - make promotion synchronous

2019-07-17 Thread Numan Siddique
On Wed, Jul 17, 2019 at 7:41 PM Aaron Conole wrote: > Michele Baldessari writes: > > > On Wed, Jul 17, 2019 at 06:23:56AM -0500, Terry Wilson wrote: > >> Is this just waiting on a couple of line length issues to be fixed? Or > do > >> those really matter? > > > > Hi Terry, > > > > I kind of

Re: [ovs-dev] [PATCH] OVN resource agent - make promotion synchronous

2019-07-17 Thread Aaron Conole
Michele Baldessari writes: > On Wed, Jul 17, 2019 at 06:23:56AM -0500, Terry Wilson wrote: >> Is this just waiting on a couple of line length issues to be fixed? Or do >> those really matter? > > Hi Terry, > > I kind of ignored it because the ovn/utilities/ovndb-servers.ocf file > has already a

Re: [ovs-dev] [PATCH] OVN resource agent - make promotion synchronous

2019-07-17 Thread Michele Baldessari
On Wed, Jul 17, 2019 at 06:23:56AM -0500, Terry Wilson wrote: > Is this just waiting on a couple of line length issues to be fixed? Or do > those really matter? Hi Terry, I kind of ignored it because the ovn/utilities/ovndb-servers.ocf file has already a bunch of lines > 79 chars. I can still

Re: [ovs-dev] [PATCH] OVN resource agent - make promotion synchronous

2019-07-17 Thread Terry Wilson
Is this just waiting on a couple of line length issues to be fixed? Or do those really matter? On Tue, Jul 9, 2019 at 3:10 AM 0-day Robot wrote: > Bleep bloop. Greetings Michele Baldessari, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some

Re: [ovs-dev] [PATCH] OVN resource agent - make promotion synchronous

2019-07-09 Thread 0-day Robot
Bleep bloop. Greetings Michele Baldessari, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 89 characters long (recommended limit is 79) #50 FILE:

Re: [ovs-dev] [PATCH] OVN resource agent - make promotion synchronous

2019-07-09 Thread Lucas Alvares Gomes
Thanks for the patch Michele. As @Daniel pointed out, this have been tested and works. On Tue, Jul 9, 2019 at 8:18 AM Michele Baldessari wrote: > > Currently inside the ovsdb_server_promote() function we call 'promote_ovnnb' > and 'promote_ovnsb' and then just record the new master state in the

Re: [ovs-dev] [PATCH] OVN resource agent - make promotion synchronous

2019-07-09 Thread Numan Siddique
On Tue, Jul 9, 2019 at 1:04 PM Daniel Alvarez Sanchez wrote: > Thanks a lot Michele. > Just mentioning that this has been tested in an OpenStack environment > successfully. A timeout is not needed for the while loop since > pacemaker will enforce its own. > > On Tue, Jul 9, 2019 at 9:20 AM

Re: [ovs-dev] [PATCH] OVN resource agent - make promotion synchronous

2019-07-09 Thread Daniel Alvarez Sanchez
Thanks a lot Michele. Just mentioning that this has been tested in an OpenStack environment successfully. A timeout is not needed for the while loop since pacemaker will enforce its own. On Tue, Jul 9, 2019 at 9:20 AM Michele Baldessari wrote: > > Currently inside the ovsdb_server_promote()

[ovs-dev] [PATCH] OVN resource agent - make promotion synchronous

2019-07-09 Thread Michele Baldessari
Currently inside the ovsdb_server_promote() function we call 'promote_ovnnb' and 'promote_ovnsb' and then just record the new master state in the CIB. This creates a race because those two promote commands are asynchronous so when we exit the ovsdb_server_promote() function the underlying DBs are