Thanks for the review! Sorry about duplicating your work--I think that
we both prepared the same change at the same time.
I applied this to master.
On Tue, Jan 30, 2018 at 01:16:26PM -0800, Yifeng Sun wrote:
> Thanks for the patch, which is better than the one I submitted.
>
> Tested-by:
Thanks for the patch, which is better than the one I submitted.
Tested-by: Yifeng Sun
Reviewed-by: Yifeng Sun
On Tue, Jan 30, 2018 at 1:00 PM, Ben Pfaff wrote:
> Until now, classifier_remove() returned either null or the
Until now, classifier_remove() returned either null or the classifier rule
passed to it, which is an unusual interface. This commit changes it to
return true if it succeeds or false on failure.
In addition, most of classifier_remove()'s callers know ahead of time that
it must succeed, even