Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

On Mon, 20 Nov 2017 08:48:10 -0800 Ben Pfaff wrote: > On Mon, Nov 20, 2017 at 11:42:43AM -0200, Flavio Leitner wrote: > > On Sun, 19 Nov 2017 10:58:11 -0800 Ben Pfaff wrote: > > > The other technical issue here is about whether && and || should be > > > at the

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

On Mon, Nov 20, 2017 at 11:42:43AM -0200, Flavio Leitner wrote: > On Sun, 19 Nov 2017 10:58:11 -0800 Ben Pfaff wrote: > > The other technical issue here is about whether && and || should be > > at the beginning or end of a line. The coding style document, > > intentionally, does

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

Hi Ben, On Sun, 19 Nov 2017 10:58:11 -0800 Ben Pfaff wrote: > On Fri, Nov 17, 2017 at 03:51:34PM -0200, Flavio Leitner wrote: > > No functional change, just fixing coding style. > > > > Signed-off-by: Flavio Leitner > > I see from the thread that there's

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

On Sun, 19 Nov 2017 11:18:25 -0800 Ben Pfaff wrote: [...] > I tend to take this patch as a kind of bug report against the coding > style document. The right response to that might be to explain why the > coding style document is wrong and the history behind it, and to thank > the

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

On 11/19/17, 11:18 AM, "Ben Pfaff" wrote: On Fri, Nov 17, 2017 at 07:34:49PM +, Darrell Ball wrote: > This patch mostly breaks OVS coding style in many instances and also invents its own coding guidelines. > > 1/OVS prefers variable declarations near their

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

On 11/19/17, 10:25 AM, "Flavio Leitner" wrote: On Sat, 18 Nov 2017 00:41:27 + Darrell Ball wrote: > On 11/17/17, 3:01 PM, "Flavio Leitner" wrote: > > On Fri, 17 Nov 2017 19:34:49 + > Darrell

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

On Fri, Nov 17, 2017 at 07:34:49PM +, Darrell Ball wrote: > This patch mostly breaks OVS coding style in many instances and also invents > its own coding guidelines. > > 1/OVS prefers variable declarations near their usage and your patch violates > extensively. > Most of this patch is

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

On Fri, Nov 17, 2017 at 03:51:34PM -0200, Flavio Leitner wrote: > No functional change, just fixing coding style. > > Signed-off-by: Flavio Leitner I see from the thread that there's some controversy here. I think that there are two aspects to it: technical and nontechnical.

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

On Sat, 18 Nov 2017 00:41:27 + Darrell Ball wrote: > On 11/17/17, 3:01 PM, "Flavio Leitner" wrote: > > On Fri, 17 Nov 2017 19:34:49 + > Darrell Ball wrote: > > > This patch mostly breaks OVS coding style in many

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

On 11/17/17, 3:01 PM, "Flavio Leitner" wrote: On Fri, 17 Nov 2017 19:34:49 + Darrell Ball wrote: > This patch mostly breaks OVS coding style in many instances and also invents its own coding guidelines. > > 1/OVS prefers

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

On Fri, 17 Nov 2017 19:34:49 + Darrell Ball wrote: > This patch mostly breaks OVS coding style in many instances and also invents > its own coding guidelines. > > 1/OVS prefers variable declarations near their usage and your patch violates > extensively.

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

This patch mostly breaks OVS coding style in many instances and also invents its own coding guidelines. 1/OVS prefers variable declarations near their usage and your patch violates extensively. Most of this patch is related to this. I’ll point out a few to provide examples, but I don’t like

[ovs-dev] [PATCH] conntrack: coding style fixes.

No functional change, just fixing coding style. Signed-off-by: Flavio Leitner --- lib/conntrack.c | 335 +++- 1 file changed, 188 insertions(+), 147 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index