Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

2017-08-29 Thread Shashank Ram
___ >From: ovs-dev-boun...@openvswitch.org <ovs-dev-boun...@openvswitch.org> on >behalf of Sairam Venugopal <vsai...@vmware.com> >Sent: Monday, August 28, 2017 4:56 PM >To: d...@openvswitch.org >Subject: [ovs-dev] [PATCH] datapath-

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

2017-08-29 Thread Sairam Venugopal
ram Venugopal <vsai...@vmware.com> >Sent: Monday, August 28, 2017 4:56 PM >To: d...@openvswitch.org >Subject: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack > entries > >The current implementation lacked an upper bound of number of entries in >the syst

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

2017-08-29 Thread Sairam Venugopal
Hi Anand, OvsProcessConntrackEntry ensures that the old entry is deleted before creating a new one. So it would prevent newer entries from being created or the limit being hit. I added in the function before processing to exit out quickly only if there was no matching entry and commit was

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

2017-08-29 Thread Anand Kumar
Hi Sairam, Thanks for the patch. Please find my comment inline. Regards, Anand Kumar On 8/28/17, 4:56 PM, "ovs-dev-boun...@openvswitch.org on behalf of Sairam Venugopal" wrote: The current implementation lacked an upper

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

2017-08-28 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org <ovs-dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Sent: Monday, August 28, 2017 4:56 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Add an

[ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

2017-08-28 Thread Sairam Venugopal
The current implementation lacked an upper bound of number of entries in the system. Set the size to ~2M (2^21) for the time being. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Conntrack.c | 6 ++ datapath-windows/ovsext/Conntrack.h | 1 + 2 files changed,