Re: [ovs-dev] [PATCH] dpif-netdev: Avoids repeated addition of DP_STAT_LOST.

2017-01-16 Thread Daniele Di Proietto 





On 16/01/2017 09:31, "Ben Pfaff"  wrote:

>On Mon, Jan 16, 2017 at 04:56:39AM -0800, nickcooper-zhangtonghao wrote:
>> Signed-off-by: nickcooper-zhangtonghao 
>> ---
>>  lib/dpif-netdev.c | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
>> index 08167b5..3901129 100644
>> --- a/lib/dpif-netdev.c
>> +++ b/lib/dpif-netdev.c
>> @@ -4258,7 +4258,6 @@ fast_path_processing(struct dp_netdev_pmd_thread *pmd,
>>  ofpbuf_uninit();
>>  ofpbuf_uninit(_actions);
>>  fat_rwlock_unlock(>upcall_rwlock);
>> -dp_netdev_count_packet(pmd, DP_STAT_LOST, lost_cnt);
>>  } else if (OVS_UNLIKELY(any_miss)) {
>>  for (i = 0; i < cnt; i++) {
>>  if (OVS_UNLIKELY(!rules[i])) {
>
>Acked-by: Ben Pfaff 
>
>I believe that this also should be tagged:
>
>CC: Daniele Di Proietto 
>Fixes: 8aaa125dab66 ("dpif-netdev: Share emc and fast path output batches.")
>
>Since this dates to May 2015 and DPDK isn't really my area, I'll leave
>this to Daniele for final application.

LGTM as well, I added the tags and applied this to master, branch-2.6 and 
branch-2.5

Thanks!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] dpif-netdev: Avoids repeated addition of DP_STAT_LOST.

2017-01-16 Thread Ben Pfaff 
On Mon, Jan 16, 2017 at 04:56:39AM -0800, nickcooper-zhangtonghao wrote:
> Signed-off-by: nickcooper-zhangtonghao 
> ---
>  lib/dpif-netdev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> index 08167b5..3901129 100644
> --- a/lib/dpif-netdev.c
> +++ b/lib/dpif-netdev.c
> @@ -4258,7 +4258,6 @@ fast_path_processing(struct dp_netdev_pmd_thread *pmd,
>  ofpbuf_uninit();
>  ofpbuf_uninit(_actions);
>  fat_rwlock_unlock(>upcall_rwlock);
> -dp_netdev_count_packet(pmd, DP_STAT_LOST, lost_cnt);
>  } else if (OVS_UNLIKELY(any_miss)) {
>  for (i = 0; i < cnt; i++) {
>  if (OVS_UNLIKELY(!rules[i])) {

Acked-by: Ben Pfaff 

I believe that this also should be tagged:

CC: Daniele Di Proietto 
Fixes: 8aaa125dab66 ("dpif-netdev: Share emc and fast path output batches.")

Since this dates to May 2015 and DPDK isn't really my area, I'll leave
this to Daniele for final application.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] dpif-netdev: Avoids repeated addition of DP_STAT_LOST.

2017-01-16 Thread nickcooper-zhangtonghao 
Signed-off-by: nickcooper-zhangtonghao 
---
 lib/dpif-netdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 08167b5..3901129 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -4258,7 +4258,6 @@ fast_path_processing(struct dp_netdev_pmd_thread *pmd,
 ofpbuf_uninit();
 ofpbuf_uninit(_actions);
 fat_rwlock_unlock(>upcall_rwlock);
-dp_netdev_count_packet(pmd, DP_STAT_LOST, lost_cnt);
 } else if (OVS_UNLIKELY(any_miss)) {
 for (i = 0; i < cnt; i++) {
 if (OVS_UNLIKELY(!rules[i])) {
-- 
1.8.3.1




___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev