Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix ukey installation failure logs and counters.

2024-04-05 Thread Ilya Maximets
On 4/5/24 15:46, Eelco Chaudron wrote: > > > On 5 Apr 2024, at 15:04, Ilya Maximets wrote: > >> On 4/5/24 14:33, Eelco Chaudron wrote: >>> >>> >>> On 4 Apr 2024, at 14:09, Ilya Maximets wrote: >>> ukey_install() returns boolean signaling if the ukey was installed or not. Installation

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix ukey installation failure logs and counters.

2024-04-05 Thread Eelco Chaudron
On 5 Apr 2024, at 15:04, Ilya Maximets wrote: > On 4/5/24 14:33, Eelco Chaudron wrote: >> >> >> On 4 Apr 2024, at 14:09, Ilya Maximets wrote: >> >>> ukey_install() returns boolean signaling if the ukey was installed >>> or not. Installation may fail for a few reasons: >>> >>> 1. Conflicting

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix ukey installation failure logs and counters.

2024-04-05 Thread Ilya Maximets
On 4/5/24 14:33, Eelco Chaudron wrote: > > > On 4 Apr 2024, at 14:09, Ilya Maximets wrote: > >> ukey_install() returns boolean signaling if the ukey was installed >> or not. Installation may fail for a few reasons: >> >> 1. Conflicting ukey. >> 2. Mutex contention while trying to replace

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix ukey installation failure logs and counters.

2024-04-05 Thread Eelco Chaudron
On 4 Apr 2024, at 14:09, Ilya Maximets wrote: > ukey_install() returns boolean signaling if the ukey was installed > or not. Installation may fail for a few reasons: > > 1. Conflicting ukey. > 2. Mutex contention while trying to replace existing ukey. > 3. The same ukey already exists and

[ovs-dev] [PATCH] ofproto-dpif-upcall: Fix ukey installation failure logs and counters.

2024-04-04 Thread Ilya Maximets
ukey_install() returns boolean signaling if the ukey was installed or not. Installation may fail for a few reasons: 1. Conflicting ukey. 2. Mutex contention while trying to replace existing ukey. 3. The same ukey already exists and active. Only the first case here signals an actual problem.