Re: [ovs-dev] [PATCH] rhel: Update for DPDK 20.11

2021-02-03 Thread Tonghao Zhang 
On Wed, Feb 3, 2021 at 1:25 AM Ilya Maximets  wrote:
>
> On 1/25/21 2:34 PM, Tonghao Zhang wrote:
> > On Fri, Jan 22, 2021 at 10:50 PM Timothy Redaelli  
> > wrote:
> >>
> >> With DPDK 20.11, meson and pkgconfig are used instead of the old
> >> Makefile-based system and so --with-dpdk option is changed to only
> >> accept shared or static instead of the directory.
> >>
> >> This commit uses --with-dpdk=shared since Fedora and RHEL ship shared
> >> libraries of DPDK.
> >>
> >> Fixes: 252e1e576443 ("dpdk: Update to use DPDK v20.11.")
> >> Signed-off-by: Timothy Redaelli 
>
> Thanks!
> I updated the subject line to better reflect the change and
> applied to master and branch-2.15.
>
> >> ---
> >>  rhel/openvswitch-fedora.spec.in | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/rhel/openvswitch-fedora.spec.in 
> >> b/rhel/openvswitch-fedora.spec.in
> >> index 2c0c4fa18..21929e6cf 100644
> >> --- a/rhel/openvswitch-fedora.spec.in
> >> +++ b/rhel/openvswitch-fedora.spec.in
> >> @@ -162,7 +162,7 @@ This package provides IPsec tunneling support for OVS 
> >> tunnels.
> >>  --disable-libcapng \
> >>  %endif
> >>  %if %{with dpdk}
> >> ---with-dpdk=$(dirname %{_datadir}/dpdk/*/.config) \
> >> +--with-dpdk=shared \
> > one question, should we change the version of dpdk required:
> > BuildRequires: dpdk-devel >= 17.05.1 --> 20.11
>
> Yes, we need that.  Thanks for pointing out.
>
> Could one of you, please, prepare a patch with this change?
patch is sent, please review, thanks!
http://patchwork.ozlabs.org/project/openvswitch/patch/20210203151049.67212-1-xiangxia.m@gmail.com/
> Best regards, Ilya Maximets.



-- 
Best regards, Tonghao
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] rhel: Update for DPDK 20.11

2021-02-02 Thread Ilya Maximets 
On 1/25/21 2:34 PM, Tonghao Zhang wrote:
> On Fri, Jan 22, 2021 at 10:50 PM Timothy Redaelli  
> wrote:
>>
>> With DPDK 20.11, meson and pkgconfig are used instead of the old
>> Makefile-based system and so --with-dpdk option is changed to only
>> accept shared or static instead of the directory.
>>
>> This commit uses --with-dpdk=shared since Fedora and RHEL ship shared
>> libraries of DPDK.
>>
>> Fixes: 252e1e576443 ("dpdk: Update to use DPDK v20.11.")
>> Signed-off-by: Timothy Redaelli 

Thanks!
I updated the subject line to better reflect the change and
applied to master and branch-2.15.

>> ---
>>  rhel/openvswitch-fedora.spec.in | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/rhel/openvswitch-fedora.spec.in 
>> b/rhel/openvswitch-fedora.spec.in
>> index 2c0c4fa18..21929e6cf 100644
>> --- a/rhel/openvswitch-fedora.spec.in
>> +++ b/rhel/openvswitch-fedora.spec.in
>> @@ -162,7 +162,7 @@ This package provides IPsec tunneling support for OVS 
>> tunnels.
>>  --disable-libcapng \
>>  %endif
>>  %if %{with dpdk}
>> ---with-dpdk=$(dirname %{_datadir}/dpdk/*/.config) \
>> +--with-dpdk=shared \
> one question, should we change the version of dpdk required:
> BuildRequires: dpdk-devel >= 17.05.1 --> 20.11

Yes, we need that.  Thanks for pointing out.

Could one of you, please, prepare a patch with this change?

Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] rhel: Update for DPDK 20.11

2021-01-25 Thread Tonghao Zhang 
On Fri, Jan 22, 2021 at 10:50 PM Timothy Redaelli  wrote:
>
> With DPDK 20.11, meson and pkgconfig are used instead of the old
> Makefile-based system and so --with-dpdk option is changed to only
> accept shared or static instead of the directory.
>
> This commit uses --with-dpdk=shared since Fedora and RHEL ship shared
> libraries of DPDK.
>
> Fixes: 252e1e576443 ("dpdk: Update to use DPDK v20.11.")
> Signed-off-by: Timothy Redaelli 
> ---
>  rhel/openvswitch-fedora.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
> index 2c0c4fa18..21929e6cf 100644
> --- a/rhel/openvswitch-fedora.spec.in
> +++ b/rhel/openvswitch-fedora.spec.in
> @@ -162,7 +162,7 @@ This package provides IPsec tunneling support for OVS 
> tunnels.
>  --disable-libcapng \
>  %endif
>  %if %{with dpdk}
> ---with-dpdk=$(dirname %{_datadir}/dpdk/*/.config) \
> +--with-dpdk=shared \
one question, should we change the version of dpdk required:
BuildRequires: dpdk-devel >= 17.05.1 --> 20.11

>  %endif
>  --enable-ssl \
>  --disable-static \
> --
> 2.29.2
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev



-- 
Best regards, Tonghao
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] rhel: Update for DPDK 20.11

2021-01-22 Thread Timothy Redaelli 
With DPDK 20.11, meson and pkgconfig are used instead of the old
Makefile-based system and so --with-dpdk option is changed to only
accept shared or static instead of the directory.

This commit uses --with-dpdk=shared since Fedora and RHEL ship shared
libraries of DPDK.

Fixes: 252e1e576443 ("dpdk: Update to use DPDK v20.11.")
Signed-off-by: Timothy Redaelli 
---
 rhel/openvswitch-fedora.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 2c0c4fa18..21929e6cf 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch-fedora.spec.in
@@ -162,7 +162,7 @@ This package provides IPsec tunneling support for OVS 
tunnels.
 --disable-libcapng \
 %endif
 %if %{with dpdk}
---with-dpdk=$(dirname %{_datadir}/dpdk/*/.config) \
+--with-dpdk=shared \
 %endif
 --enable-ssl \
 --disable-static \
-- 
2.29.2

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev