Re: [ovs-dev] [PATCH] rstp: Show root bridge info.

On Fri, Jul 14, 2017 at 10:30:52AM +0800, nickcooper-zhangtonghao wrote: > > > On Jul 14, 2017, at 7:05 AM, Ben Pfaff wrote: > > > > This change makes me nervous about dereferencing a null 'p'. I think > > that it will not do so, for a root bridge, but it takes some study to > >

Re: [ovs-dev] [PATCH] rstp: Show root bridge info.

> On Jul 14, 2017, at 7:05 AM, Ben Pfaff wrote: > > This change makes me nervous about dereferencing a null 'p'. I think > that it will not do so, for a root bridge, but it takes some study to > see that. > > How about this, instead? It has a small amount of code duplication,

Re: [ovs-dev] [PATCH] rstp: Show root bridge info.

Who can help me to review this patch. Thanks. > On Jun 20, 2017, at 11:04 AM, nickcooper-zhangtonghao > wrote: > > When we use the 'ovs-appctl rstp/show', the root bridge > of rstp is always 'unknown root port'. We don't expect > that. The reason is that the committer

[ovs-dev] [PATCH] rstp: Show root bridge info.

When we use the 'ovs-appctl rstp/show', the root bridge of rstp is always 'unknown root port'. We don't expect that. The reason is that the committer added the check for var 'p'. In the rstp, if a bridge is root bridge, there is not root port, and we don't use the root port 'p', 'rstp/show' in the