On Fri, Nov 18, 2016 at 12:35:13PM -0700, Neil McKee wrote:
> That sounds like a robust way to do it, yes. Does it have the desired
> effect? Does it eliminate this structure for all the virtual ethernet
> ports? I believe there should only be <= 1 physical ethernet port on each
It
On Thu, Nov 17, 2016 at 10:21:23AM -0800, Neil McKee wrote:
> I'm wondering if the ethernet stats block is going to mean anything for
> virtual interfaces. What if we only export it for physical interfaces?
> That might reduce the overhead significantly. (Maybe your patch already
> does this -
I'm wondering if the ethernet stats block is going to mean anything for
virtual interfaces. What if we only export it for physical interfaces?
That might reduce the overhead significantly. (Maybe your patch already
does this - I haven't read it carefully enough to be sure).
Neil
--
Neil
If there is only one VLAN then the numbers are redundant - already exported
in the struct if_counters.
The vlan_counters structure was never intended to be exported by an
interface. It was designed for the (rarely used) vlan datasource -- that's
why the counters in it are not directional.
So I
On Tue, Nov 15, 2016 at 11:13:10PM -0700, Neil McKee wrote:
> Hi Robert,
>
> (3) adding vlan counters for every vlan that an interface belongs to -- I
> not sure about this one. What if an interface is on a whole set of vlans?
> This vlan counters structure has hardly ever been used.
Hi Robert,
It seems like there are three separable things here:
(1) filling in the multicast and broadcast counters that were missing from
the generic interface counters structure. This is great -- assuming it's
portable across OS versions etc.
(2) adding the ethernet counters structure. This
Expose existing netdev stats via sFlow.
Export sFlow ETHERNET structure with available counters.
Map existing stats to counters in the GENERIC INTERFACE
sFlow structure.
Export sFlow VLAN structure with available counters.
Adjust unit test to accommodate these new counters.
Signed-off-by: Robert
