Re: [ovs-dev] [PATCH] userspace: Enable non-bridge port as tunnel endpoint.

2019-07-16 Thread Yifeng Sun
Thanks Ben for pointing this out. There surely is a mistake that we need to fix. We will come up a new version. Thanks, Yifeng On Tue, Jul 16, 2019 at 3:04 PM Ben Pfaff wrote: > > On Tue, Jul 16, 2019 at 10:55:08AM -0700, Yifeng Sun wrote: > > For userspace datapath, currently only the bridge it

Re: [ovs-dev] [PATCH] userspace: Enable non-bridge port as tunnel endpoint.

2019-07-16 Thread Ben Pfaff
On Tue, Jul 16, 2019 at 10:55:08AM -0700, Yifeng Sun wrote: > For userspace datapath, currently only the bridge itself, the LOCAL port, > can be the tunnel endpoint to encap/decap tunnel packets. This patch > enables non-bridge port as tunnel endpoint. One use case is for users to > create a brid

Re: [ovs-dev] [PATCH] userspace: Enable non-bridge port as tunnel endpoint.

2019-07-16 Thread William Tu
On Tue, Jul 16, 2019 at 2:13 PM Ben Pfaff wrote: > > On Tue, Jul 16, 2019 at 02:59:55PM -0400, 0-day Robot wrote: > > checkpatch: > > WARNING: Unexpected sign-offs from developers who are not authors or > > co-authors or committers: William Tu > > Lines checked: 184, Warnings: 1, Errors: 0 > > I

Re: [ovs-dev] [PATCH] userspace: Enable non-bridge port as tunnel endpoint.

2019-07-16 Thread Ben Pfaff
On Tue, Jul 16, 2019 at 02:59:55PM -0400, 0-day Robot wrote: > checkpatch: > WARNING: Unexpected sign-offs from developers who are not authors or > co-authors or committers: William Tu > Lines checked: 184, Warnings: 1, Errors: 0 I agree with the robot in this case. Is William a co-author?

Re: [ovs-dev] [PATCH] userspace: Enable non-bridge port as tunnel endpoint.

2019-07-16 Thread 0-day Robot
Bleep bloop. Greetings Yifeng Sun, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: W

[ovs-dev] [PATCH] userspace: Enable non-bridge port as tunnel endpoint.

2019-07-16 Thread Yifeng Sun
For userspace datapath, currently only the bridge itself, the LOCAL port, can be the tunnel endpoint to encap/decap tunnel packets. This patch enables non-bridge port as tunnel endpoint. One use case is for users to create a bridge and a vtep port as tap, and configure underlay IP at vtep port as