Re: [ovs-dev] [PATCH 03/12] ovs-vsctl: Add datapath and CT zone commands.

2019-07-29 Thread Darrell Ball
added one more comment. On Fri, Jul 26, 2019 at 4:10 PM Darrell Ball wrote: > added one more comment for now > > > On Fri, Jul 26, 2019 at 11:13 AM Darrell Ball wrote: > >> Thanks for the patch >> >> Not a full review; just some initial testing >> >> >> 1/ AT_CHECK([RUN_OVS_VSCTL([add-zone-tp

Re: [ovs-dev] [PATCH 03/12] ovs-vsctl: Add datapath and CT zone commands.

2019-07-26 Thread Darrell Ball
added one more comment for now On Fri, Jul 26, 2019 at 11:13 AM Darrell Ball wrote: > Thanks for the patch > > Not a full review; just some initial testing > > > 1/ AT_CHECK([RUN_OVS_VSCTL([add-zone-tp netdev zone=2 icmp_first=2 > icmp_reply_blah=3])]) > > The above syntax is NOT flagged as an

Re: [ovs-dev] [PATCH 03/12] ovs-vsctl: Add datapath and CT zone commands.

2019-07-26 Thread Darrell Ball
Thanks for the patch Not a full review; just some initial testing 1/ AT_CHECK([RUN_OVS_VSCTL([add-zone-tp netdev zone=2 icmp_first=2 icmp_reply_blah=3])]) The above syntax is NOT flagged as an error 2/ AT_CHECK([RUN_OVS_VSCTL([--may-exist add-zone-tp netdev zone=2 icmp_first=2

Re: [ovs-dev] [PATCH 03/12] ovs-vsctl: Add datapath and CT zone commands.

2019-07-26 Thread William Tu
On Thu, Jul 25, 2019 at 04:24:05PM -0700, Yi-Hung Wei wrote: > From: William Tu > > The patch adds the following commands > $ ovs-vsctl {add,del,list}-dp > for creating/deleting/listing the datapath, and > $ ovs-vsctl {add,del,list}-zone-tp > for conntrack zones and timeout policies. > >

[ovs-dev] [PATCH 03/12] ovs-vsctl: Add datapath and CT zone commands.

2019-07-25 Thread Yi-Hung Wei
From: William Tu The patch adds the following commands $ ovs-vsctl {add,del,list}-dp for creating/deleting/listing the datapath, and $ ovs-vsctl {add,del,list}-zone-tp for conntrack zones and timeout policies. Signed-off-by: William Tu --- tests/ovs-vsctl.at | 20 +++-