On Mon, Jul 29, 2019 at 3:51 PM Yi-Hung Wei wrote:
> On Mon, Jul 29, 2019 at 1:12 PM Darrell Ball wrote:
> >> > "is_default" - can you explain this one ?
> >>
> >> This flag is used to configure the default timeout policy in the
> >> datapath. If 'is_default' is true, it will set the provided t
On Mon, Jul 29, 2019 at 1:12 PM Darrell Ball wrote:
>> > "is_default" - can you explain this one ?
>>
>> This flag is used to configure the default timeout policy in the
>> datapath. If 'is_default' is true, it will set the provided timeout
>> policy to be the default timeout policy. The default
On Mon, Jul 29, 2019 at 12:37 PM Yi-Hung Wei wrote:
> On Fri, Jul 26, 2019 at 11:41 AM Darrell Ball wrote:
> >
> > Thanks for the patch
> >
> > I found this patch hard to review since it does not contain
> implementations
> > The same comment applies to Patch 6
> > I think Patches 5-7 can be com
On Fri, Jul 26, 2019 at 11:41 AM Darrell Ball wrote:
>
> Thanks for the patch
>
> I found this patch hard to review since it does not contain implementations
> The same comment applies to Patch 6
> I think Patches 5-7 can be combined into one patch, which will make review
> easier.
Thanks Darrel
On Fri, Jul 26, 2019 at 11:41 AM Darrell Ball wrote:
> Thanks for the patch
>
> I found this patch hard to review since it does not contain implementations
> The same comment applies to Patch 6
> I think Patches 5-7 can be combined into one patch, which will make review
> easier.
>
> some other c
Thanks for the patch
I found this patch hard to review since it does not contain implementations
The same comment applies to Patch 6
I think Patches 5-7 can be combined into one patch, which will make review
easier.
some other comments inline
On Thu, Jul 25, 2019 at 4:27 PM Yi-Hung Wei wrote:
This patch defines the dpif interface for a datapath to support
adding, deleting, getting and dumping conntrack timeout policy.
The timeout policy is identified by a 4 bytes unsigned integer in
datapath, and it currently support timeout for TCP, UDP, and ICMP
protocols.
Signed-off-by: Yi-Hung Wei
