On Mon, Apr 16, 2018 at 04:40:19PM -0500, Mark Michelson wrote:
> On 04/13/2018 12:26 PM, Ben Pfaff wrote:
> >I didn't realize until now that the tree had two different ways of parsing
> >strings in the form : and :. There are the
> >long-standing inet_parse_active() and inet_parse_passive() funct
On 04/13/2018 12:26 PM, Ben Pfaff wrote:
I didn't realize until now that the tree had two different ways of parsing
strings in the form : and :. There are the
long-standing inet_parse_active() and inet_parse_passive() functions, and
more recently the ipv46_parse() function. This commit eliminat
Hi Mark.
I hope my commit message did not come across as critical. I understand
why the new API was added. If criticism is warranted, it should be
directed toward me as having failed to originally catch the redundancy
in the review process.
Feedback is welcome (and needed for review). I'll loo
Hi Ben,
The cleanup of IPv6 address parsing is greatly appreciated. I haven't
yet reviewed the meat of this patchset, but I figured I'd weigh in on
the commit message on this patch.
I wrote the newer parsing code when extending load balancers to work for
IPv6. The issues I ran into were:
*
I didn't realize until now that the tree had two different ways of parsing
strings in the form : and :. There are the
long-standing inet_parse_active() and inet_parse_passive() functions, and
more recently the ipv46_parse() function. This commit eliminates the
latter and changes the code to use t
