Re: [ovs-dev] [PATCH 08/12] datapath-config: Consume datapath, CT_Zone, and CT_Timeout_Policy tables

2019-07-29 Thread Yi-Hung Wei
On Fri, Jul 26, 2019 at 1:22 PM William Tu wrote: > > +static void > > +datapath_update_ct_zone_config(struct datapath *dp, struct dpif *dpif, > > + unsigned int idl_seqno) > > +{ > > +const struct ovsrec_datapath *dp_cfg = dp->cfg; > > +struct

Re: [ovs-dev] [PATCH 08/12] datapath-config: Consume datapath, CT_Zone, and CT_Timeout_Policy tables

2019-07-28 Thread Darrell Ball
One more comment Not a full review; just focusing on the more important parts for now. On Fri, Jul 26, 2019 at 5:44 PM Darrell Ball wrote: > Thanks for the patch; not a full review > > On Thu, Jul 25, 2019 at 4:29 PM Yi-Hung Wei wrote: > >> This patch reads the datapath, CT_Zone, and

Re: [ovs-dev] [PATCH 08/12] datapath-config: Consume datapath, CT_Zone, and CT_Timeout_Policy tables

2019-07-26 Thread Darrell Ball
Thanks for the patch; not a full review On Thu, Jul 25, 2019 at 4:29 PM Yi-Hung Wei wrote: > This patch reads the datapath, CT_Zone, and CT_Timeout_Policy tables > from ovsdb, stores the information in a per datapath internal datapath > structure, and pushes down the conntrack timeout policy

Re: [ovs-dev] [PATCH 08/12] datapath-config: Consume datapath, CT_Zone, and CT_Timeout_Policy tables

2019-07-26 Thread William Tu
I only have some minor comments inline below. On Thu, Jul 25, 2019 at 04:24:10PM -0700, Yi-Hung Wei wrote: > This patch reads the datapath, CT_Zone, and CT_Timeout_Policy tables > from ovsdb, stores the information in a per datapath internal datapath > structure, and pushes down the conntrack

[ovs-dev] [PATCH 08/12] datapath-config: Consume datapath, CT_Zone, and CT_Timeout_Policy tables

2019-07-25 Thread Yi-Hung Wei
This patch reads the datapath, CT_Zone, and CT_Timeout_Policy tables from ovsdb, stores the information in a per datapath internal datapath structure, and pushes down the conntrack timeout policy into the datapath via dpif interface. The per datapath internal data structure will be used in