Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-08 Thread Damijan Skvarc
On Wed, Aug 7, 2019 at 3:50 PM Numan Siddique wrote: > > > On Wed, Aug 7, 2019 at 4:59 PM Damijan Skvarc > wrote: > >> Within this function actions & match dynamic strings are used as helper >> variables for adding entries into logical flow table. Variables are >> used several times in order to

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-07 Thread Numan Siddique
On Wed, Aug 7, 2019 at 4:59 PM Damijan Skvarc wrote: > Within this function actions & match dynamic strings are used as helper > variables for adding entries into logical flow table. Variables are > used several times in order to optimize number of memory allocations, > however at the end memory

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-07 Thread 0-day Robot
Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (northd/ovn-northd.c). Repository lacks necessary

[ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-07 Thread Damijan Skvarc
Within this function actions & match dynamic strings are used as helper variables for adding entries into logical flow table. Variables are used several times in order to optimize number of memory allocations, however at the end memory was forgotten to be deallocated. Signed-off-by: Damijan

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-02 Thread 0-day Robot
Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-02 Thread Damijan Skvarc
Done! Thanks for review. On Wed, Jul 31, 2019 at 6:40 PM Mark Michelson wrote: > I've pushed this to OVN master. Damijan, could you post a backport patch > for OVS 2.12, please? Thanks! > > On 7/31/19 9:17 AM, Mark Michelson wrote: > > Thanks for the fix! > > Acked-by: Mark Michelson > > > >

[ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-02 Thread Damijan Skvarc
Within this function actions & match dynamic strings are used as helper variables for adding entries into logical flow table. Variables are used several times in order to optimize number of memory allocations, however at the end memory was forgotten to be deallocated. Signed-off-by: Damijan

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-01 Thread 0-day Robot
Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (northd/ovn-northd.c). Repository lacks necessary

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-07-31 Thread Mark Michelson
I've pushed this to OVN master. Damijan, could you post a backport patch for OVS 2.12, please? Thanks! On 7/31/19 9:17 AM, Mark Michelson wrote: Thanks for the fix! Acked-by: Mark Michelson This will need a backport to the OVS 2.12 branch as well. On 7/31/19 6:43 AM, Damijan Skvarc wrote:

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-07-31 Thread Mark Michelson
Thanks for the fix! Acked-by: Mark Michelson This will need a backport to the OVS 2.12 branch as well. On 7/31/19 6:43 AM, Damijan Skvarc wrote: Within this function actions & match dynamic strings are used as helper variables for adding entries into logical flow table. Variables are used

[ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-07-31 Thread Damijan Skvarc
Within this function actions & match dynamic strings are used as helper variables for adding entries into logical flow table. Variables are used several times in order to optimize number of memory allocations, however at the end memory was forgotten to be deallocated. Signed-off-by: Damijan